hokein wrote:
Thanks, it looks like this introduces a new false positive:
```
#include
std::optional func(int a) {
if (a)
return std::make_optional(nullptr); // emit a dangling.
}
```
I'm going to revert it.
https://github.com/llvm/llvm-project/pull/107213
___
Author: Haojian Wu
Date: 2024-09-12T09:24:32+02:00
New Revision: 0683c4e839524c37fe4ddfa1bce1e31ba556041b
URL:
https://github.com/llvm/llvm-project/commit/0683c4e839524c37fe4ddfa1bce1e31ba556041b
DIFF:
https://github.com/llvm/llvm-project/commit/0683c4e839524c37fe4ddfa1bce1e31ba556041b.diff
LO
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/108340
Get the right offset to apply from the RecordLayout.
>From af62225a90e3dd2ebd234c391a4e05dd1d1d7df9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Thu, 12 Sep 2024 09:36:17 +0200
Subject: [
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Get the right offset to apply from the RecordLayout.
---
Full diff: https://github.com/llvm/llvm-project/pull/108340.diff
5 Files Affected:
- (modified) clang/lib/AST/ByteCode/Interp.h (+12)
- (modified)
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
dmpolukhin wrote:
> this is causing a crash with precompiled headers. I can try to reduce, but
> hopefully the problem is obvious from this assert/stack trace?
@aeubanks co
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) {
for (unsigned I = 0; I != NumParams; ++I)
Params.push_back(readDeclAs
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin ,Dmitry Polukhin
Message-ID:
In-Reply-To:
@@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) {
for (unsigned I = 0; I != NumParams; ++I)
Params.push_back(readDeclAs
@@ -46,14 +46,15 @@ void AvoidEndlCheck::check(const MatchFinder::MatchResult
&Result) {
// Handle the more common streaming '... << std::endl' case
const CharSourceRange TokenRange =
CharSourceRange::getTokenRange(Expression->getSourceRange());
-const Stri
https://github.com/zmodem created
https://github.com/llvm/llvm-project/pull/108342
This was obsoleted by Visual Studio providing built-in support for running
clang-format in VS2017.
We haven't shipped it for years (since
10d2195305ac49605f2b7b6a25a4076c31923191), never got it working with VS2
llvmbot wrote:
@llvm/pr-subscribers-platform-windows
Author: Hans (zmodem)
Changes
This was obsoleted by Visual Studio providing built-in support for running
clang-format in VS2017.
We haven't shipped it for years (since
10d2195305ac49605f2b7b6a25a4076c31923191), never got it working wi
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/108344
This relands #107213, with a fix to the "make_optional(nullptr)" false positive
(please see the second commit in this PR).
>From d1096323a87897b917ede2c29afd42c9f2674cd7 Mon Sep 17 00:00:00 2001
From: Haojian Wu
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
This relands #107213, with a fix to the "make_optional(nullptr)" false
positive (please see the second commit in this PR).
---
Full diff: https://github.com/llvm/llvm-project/pull/108344.diff
4 Files Affected
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/108344
>From d1096323a87897b917ede2c29afd42c9f2674cd7 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Thu, 12 Sep 2024 09:27:03 +0200
Subject: [PATCH 1/2] Reapply "[clang] Diagnose dangling issues for the
"Container" c
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -verify %s
+// RUN: diff %s %s.expected
nhaehnle wrote:
Right, it's all a little mind-bending, but my point is that since you're trying
to test whether the invocation of `not %{lit} %S/LitTests --update-tests` in
`lit-plugin
https://github.com/nhaehnle approved this pull request.
I didn't go over the core.py implementation with a comb, but this looks
reasonable to me. Thanks!
https://github.com/llvm/llvm-project/pull/97369
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: Younan Zhang
Date: 2024-09-12T16:36:06+08:00
New Revision: 2149914ea10c05c17fc6e994af5cc96b6b312f1b
URL:
https://github.com/llvm/llvm-project/commit/2149914ea10c05c17fc6e994af5cc96b6b312f1b
DIFF:
https://github.com/llvm/llvm-project/commit/2149914ea10c05c17fc6e994af5cc96b6b312f1b.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/108148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -113,9 +113,11 @@ class TreeTransform {
class ForgetPartiallySubstitutedPackRAII {
Derived &Self;
TemplateArgument Old;
+Sema::ArgumentPackSubstitutionIndexRAII ResetPackSubstIndex;
ilya-biryukov wrote:
Could you add a short comment mentioning
https://github.com/ilya-biryukov approved this pull request.
LGTM from my side if all other tests pass.
Given that it's a small change and bugfix, I think it should be okay to land
this without waiting for other reviewers. We could always follow up with more
fixes if they have additional commen
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Keenuts wrote:
Thanks for looking into this.
I don't know what's causing the ""Virtual register defs don't dominate all
uses", as some cases are located in the middle of a block and doesn't seem to
be related to BB sorting (even though this is probably the cause)
```
127 bb.10.do.end8:
[...]
1
@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s
zyn0217 wrote:
Can you move the test to a pre-existing file instead of adding a new one? e.g.
somewhere like clang/test/SemaTemplate/pack-deduction.cpp, since this patch is
affecting somet
https://github.com/NagyDonat commented:
I re-reviewed the commit and added two very minor remarks, otherwise LGTM.
https://github.com/llvm/llvm-project/pull/102602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/102602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -327,6 +327,8 @@ Static Analyzer
New features
+- Now CSA models `builtin_*_overflow` functions.
NagyDonat wrote:
```suggestion
- Now CSA models `__builtin_*_overflow` functions.
```
https://github.com/llvm/llvm-project/pull/102602
___
@@ -16,21 +16,93 @@
#include "clang/Basic/Builtins.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
+#include "clang/StaticAnalyzer/Checkers/Taint.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
https://github.com/tru approved this pull request.
LGTM. Let's remove it.
https://github.com/llvm/llvm-project/pull/108342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ckandeler updated
https://github.com/llvm/llvm-project/pull/67802
>From dec33143e617967dee46ce4123a2e298220d73fc Mon Sep 17 00:00:00 2001
From: Christian Kandeler
Date: Fri, 29 Sep 2023 15:01:58 +0200
Subject: [PATCH] [clangd] Collect comments from function definitions into t
Author: Mikael Holmen
Date: 2024-09-12T11:23:13+02:00
New Revision: 63dab72fd5b96cd98bba6d041d08bb2a6f3aaa0a
URL:
https://github.com/llvm/llvm-project/commit/63dab72fd5b96cd98bba6d041d08bb2a6f3aaa0a
DIFF:
https://github.com/llvm/llvm-project/commit/63dab72fd5b96cd98bba6d041d08bb2a6f3aaa0a.diff
@@ -870,7 +872,8 @@ class DiagnosticsEngine : public
RefCountedBase {
/// \param FormatString A fixed diagnostic format string that will be hashed
/// and mapped to a unique DiagID.
template
- unsigned getCustomDiagID(Level L, const char (&FormatString)[N]) {
+ [[depr
@@ -200,7 +273,33 @@ class DiagnosticIDs : public RefCountedBase
{
// FIXME: Replace this function with a create-only facilty like
// createCustomDiagIDFromFormatString() to enforce safe usage. At the time of
// writing, nearly all callers of this function were invalid.
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/108352
This PR introduces new WebKit checker to warn a member variable that is a raw
reference or a raw pointer to an object, which is capable of creating a
CheckedRef/CheckedPtr.
>From ac0447762c98da3cfb41a6b462034e3a
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
This PR introduces new WebKit checker to warn a member variable that is a raw
reference or a raw pointer to an object, which is capable of creating a
CheckedRef/Che
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/108352
>From ac0447762c98da3cfb41a6b462034e3ab410bc33 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 12 Sep 2024 02:13:12 -0700
Subject: [PATCH 1/2] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce
member va
https://github.com/Szelethus commented:
Alright, I think this patch is good from a design standpoint! I'll get into the
nitty-gritty in a bit.
https://github.com/llvm/llvm-project/pull/106350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -86,6 +124,19 @@ Options
this option enables.
Default is `true`.
+.. _option-ReportDefaultFunctions:
+
+.. option:: ReportDefaultFunctions
+
+When `true`, the check reports the default set of functions.
+Default is `true`.
Szelethus wrote:
"Y
https://github.com/Szelethus edited
https://github.com/llvm/llvm-project/pull/106350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b06954a5d02a41a38b72f7914c791428ccd95318
5abb2493cfc67f2bd1dcdd946ed9ecbef8929d2b --e
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/85786
>From 395ce72afbf9e4b12fcbfaf9cdbda8921c9ff72a Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Tue, 23 Jul 2024 19:59:06 -0700
Subject: [PATCH 01/18] [RISCV][FMV] Support target_clones
---
.../clang/Basic/Diagnosti
https://github.com/Xazax-hun approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun edited
https://github.com/llvm/llvm-project/pull/108280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -300,6 +300,8 @@ Improvements to Clang's diagnostics
- Clang now diagnoses cases where a dangling ``GSLOwner`` object
is constructed, e.g. ``std::vector v = {std::string()};``
(#GH100526).
+- Don't emit bogus dangling diagnostics when ``[[gsl::Owner]]`` and
`[[clang::li
@@ -16,21 +16,93 @@
#include "clang/Basic/Builtins.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
+#include "clang/StaticAnalyzer/Checkers/Taint.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
@@ -505,6 +505,27 @@ void test_builtin_elementwise_log2(int i, float f, double
d, float4 v, int3 iv,
// expected-error@-1 {{1st argument must be a floating point type (was
'unsigned4' (vector of 4 'unsigned int' values))}}
}
+void test_builtin_elementwise_popcount(int i, f
https://github.com/Xazax-hun approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/108344
>From d1096323a87897b917ede2c29afd42c9f2674cd7 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Thu, 12 Sep 2024 09:27:03 +0200
Subject: [PATCH 1/2] Reapply "[clang] Diagnose dangling issues for the
"Container" c
https://github.com/Xazax-hun approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/108352
>From ac0447762c98da3cfb41a6b462034e3ab410bc33 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 12 Sep 2024 02:13:12 -0700
Subject: [PATCH 1/3] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce
member va
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/108352
>From ac0447762c98da3cfb41a6b462034e3ab410bc33 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 12 Sep 2024 02:13:12 -0700
Subject: [PATCH 1/4] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce
member va
@@ -300,6 +300,8 @@ Improvements to Clang's diagnostics
- Clang now diagnoses cases where a dangling ``GSLOwner`` object
is constructed, e.g. ``std::vector v = {std::string()};``
(#GH100526).
+- Don't emit bogus dangling diagnostics when ``[[gsl::Owner]]`` and
`[[clang::li
Keenuts wrote:
Ok, so I've figured out 3 issues:
1. A bug in my sorting of merge instructions. If LHS == RHS, I returned LHS <
RHS, that was wrong. Executed outside of GDB, it was very slow to show the
backtrace and crash, so tests looked like it was hanging, but it was just
crashing.
2. An e
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?=
Message-ID:
In-Reply-To:
Vy
llvmbot wrote:
@llvm/pr-subscribers-mlir-affine
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvmlibc/Res
llvmbot wrote:
@llvm/pr-subscribers-mlir-memref
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvmlibc/Res
llvmbot wrote:
@llvm/pr-subscribers-mlir-llvm
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvmlibc/Restr
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-mlir-ods
@llvm/pr-subscribers-mlir-arith
@llvm/pr-subscribers-mlir-linalg
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-pr
llvmbot wrote:
@llvm/pr-subscribers-mlir-gpu
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvmlibc/Restri
llvmbot wrote:
@llvm/pr-subscribers-mlir-tosa
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvmlibc/Restr
llvmbot wrote:
@llvm/pr-subscribers-mlir-sparse
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvmlibc/Res
llvmbot wrote:
@llvm/pr-subscribers-mlir-bufferization
Author: VitalyR (VitalyAnkh)
Changes
---
Patch is 140.25 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/108355.diff
130 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/llvml
https://github.com/bradh352 updated
https://github.com/llvm/llvm-project/pull/108241
>From 89d238800f0287f29f95165e05530d3f5e397245 Mon Sep 17 00:00:00 2001
From: Brad House
Date: Wed, 11 Sep 2024 10:27:50 -0400
Subject: [PATCH] Add AlignFunctionDeclarations attribute to
AlignConsecutiveDeclar
bradh352 wrote:
I just corrected the formatting...
https://github.com/llvm/llvm-project/pull/108241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?=
Message-ID:
In-Reply-To:
Vy
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 59731eebf8f24e3e90dc77e91a08d068b529cfc5
65c7658359b856bd736229d501def16027fd2a42 --e
https://github.com/mstorsjo created
https://github.com/llvm/llvm-project/pull/108357
While these flags semantically are relevant only for C++, we do add them to
CMAKE_REQUIRED_FLAGS if they are detected. All flags in that variable are used
both when testing compilation of C and C++ (and for de
llvmbot wrote:
@llvm/pr-subscribers-libcxxabi
Author: Martin Storsjö (mstorsjo)
Changes
While these flags semantically are relevant only for C++, we do add them to
CMAKE_REQUIRED_FLAGS if they are detected. All flags in that variable are used
both when testing compilation of C and C++ (a
llvmbot wrote:
@llvm/pr-subscribers-libcxx
@llvm/pr-subscribers-libunwind
Author: Martin Storsjö (mstorsjo)
Changes
While these flags semantically are relevant only for C++, we do add them to
CMAKE_REQUIRED_FLAGS if they are detected. All flags in that variable are used
both when testing
Fznamznon wrote:
ping @AaronBallman
https://github.com/llvm/llvm-project/pull/103917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -16,7 +16,7 @@ like Toy to get the information they need.
MLIR provides a set of always available-hooks for certain core transformations,
as seen in the [previous chapter](Ch-3.md), where we registered some
-canonicalizations via a hook on our operations (`getCanonicalizati
@@ -121,7 +121,7 @@ struct EmulateWideIntPass final
[&typeConverter](Operation *op) { return typeConverter.isLegal(op); });
RewritePatternSet patterns(ctx);
-// Add common pattenrs to support contants, functions, etc.
matthias-springer wrote:
@@ -14,7 +14,7 @@
"name": "punctuation.definition.string.begin.cpp"
},
"1": {
- "name": "mlir.delimeter.raw.string.cpp"
matthias-springer wrote:
I'm not sure if this is safe to change...
https://github.com/llvm/llvm-project/
@@ -316,7 +316,7 @@ static omp::DeclareReductionOp
declareReduction(PatternRewriter &builder,
reduction, {arith::CmpFPredicate::OLT, arith::CmpFPredicate::OLE},
{arith::CmpFPredicate::OGT, arith::CmpFPredicate::OGE}, isMin) ||
matchSelectReduction(
-
@@ -239,7 +239,7 @@ std::optional
mlir::detail::getDefaultIndexBitwidth(
// Returns the endianness if specified in the given entry. If the entry is
empty
// the default endianness represented by an empty attribute is returned.
-Attribute mlir::detail::getDefaultEndianness(Da
@@ -335,7 +335,7 @@ SPIR-V Dialect op| LLVM Dialect op
`spirv.FOrdEqual` | `llvm.fcmp "oeq"`
`spirv.FOrdGreaterThan`| `llvm.fcmp "ogt"`
`spirv.FOrdGreaterThanEqual` | `llvm.fcmp "oge"`
-`spirv.FOrdLessThan` | `llvm.fcmp "olt"`
--
@@ -41,7 +41,7 @@ def Arith_CmpFPredicateAttr : I64EnumAttr<
I64EnumAttrCase<"OEQ", 1, "oeq">,
I64EnumAttrCase<"OGT", 2, "ogt">,
I64EnumAttrCase<"OGE", 3, "oge">,
- I64EnumAttrCase<"OLT", 4, "olt">,
matthias-springer wrote:
This is not a
@@ -121,7 +121,7 @@ struct EmulateWideIntPass final
[&typeConverter](Operation *op) { return typeConverter.isLegal(op); });
RewritePatternSet patterns(ctx);
-// Add common pattenrs to support contants, functions, etc.
VitalyAnkh wrote:
You are
https://github.com/VitalyAnkh converted_to_draft
https://github.com/llvm/llvm-project/pull/108355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/VitalyAnkh edited
https://github.com/llvm/llvm-project/pull/108355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14,7 +14,7 @@
"name": "punctuation.definition.string.begin.cpp"
},
"1": {
- "name": "mlir.delimeter.raw.string.cpp"
VitalyAnkh wrote:
But it is indeed a typo. Should we correct it?
https://github.com/llvm/llvm-project/pu
alexfh wrote:
Hi @mizvekov, we started seeing crashes after this commit.
I'm working on a shareable test case, but here's the assertion failure and the
stack trace:
```
assert.h assertion failed at llvm-project/clang/lib/AST/TemplateName.cpp:184 in
TemplateDecl *clang::TemplateName::getAsTempl
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/108197
>From 5901d82ea0543074853b963f7dc9106a6fe3bcee Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Wed, 11 Sep 2024 11:33:45 +
Subject: [PATCH 1/6] [clang] Do not expand pack while retaining expansion
---
cl
@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s
usx95 wrote:
Done.
https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
cor3ntin wrote:
> I tried out #94981 and -fno-relaxed-template-template-args and can confirm
> both fix it. I'm now running into a separate LoopVectorizer crash, but I made
> it out of the frontend :)
>
> Using -fno-relaxed-template-template-args should be fine, in llvm-test-suite
> we alread
Keenuts wrote:
> > OpLoopMerge are taking BB operands, but verifier expected register operand.
>
> Hopefully, the fix may be as simple as to change
> lib/Target/SPIRV/SPIRVInstrInfo.td line 620-621 `ID:$merge, ID:$continue`
> into `unknown:$merge, unknown:$continue` as in line 626 for OpBranch
chrchr-github wrote:
Thank for addressing this.
I still wonder why using `new`/`delete` with additional UB (deleting pointer
with offset) is necessary in the examples.
Why not simply define a function taking a pointer argument and do the
arithmetic on that?
https://github.com/llvm/llvm-project
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/108358
We shouldn't emit this until C++14.
>From 82627320e5b3ec07f01d9f1761e5e871b1dc5919 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Thu, 12 Sep 2024 12:44:48 +0200
Subject: [PATCH] [clang][by
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
We shouldn't emit this until C++14.
---
Full diff: https://github.com/llvm/llvm-project/pull/108358.diff
2 Files Affected:
- (modified) clang/lib/AST/ByteCode/Interp.cpp (+1-1)
- (modified) clang/test/AST
https://github.com/cor3ntin approved this pull request.
Can we get a changelog entry?
LGTM otherwise
https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/108197
>From 5901d82ea0543074853b963f7dc9106a6fe3bcee Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Wed, 11 Sep 2024 11:33:45 +
Subject: [PATCH 1/7] [clang] Do not expand pack while retaining expansion
---
cl
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/108197
>From 5901d82ea0543074853b963f7dc9106a6fe3bcee Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Wed, 11 Sep 2024 11:33:45 +
Subject: [PATCH 1/7] [clang] Do not expand pack while retaining expansion
---
cl
usx95 wrote:
Thanks for the review. Landing now. For other reviewers, feel free to drop more
comments, and I would be happy to address in a followup.
https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: Utkarsh Saxena
Date: 2024-09-12T13:21:26+02:00
New Revision: 849d1b8b1f1fc16dc28b07da358515a52b79ea81
URL:
https://github.com/llvm/llvm-project/commit/849d1b8b1f1fc16dc28b07da358515a52b79ea81
DIFF:
https://github.com/llvm/llvm-project/commit/849d1b8b1f1fc16dc28b07da358515a52b79ea81.diff
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-09-12T13:25:25+02:00
New Revision: f22a8d18229fe94fe340afbf02ad9592ca199784
URL:
https://github.com/llvm/llvm-project/commit/f22a8d18229fe94fe340afbf02ad9592ca199784
DIFF:
https://github.com/llvm/llvm-project/commit/f22a8d18229fe94fe340afbf02ad9592ca199784.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/108358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea approved this pull request.
https://github.com/llvm/llvm-project/pull/108342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Hans
Date: 2024-09-12T13:27:38+02:00
New Revision: ddd2af3c5a076f2c5f2024019067b206d1b411b4
URL:
https://github.com/llvm/llvm-project/commit/ddd2af3c5a076f2c5f2024019067b206d1b411b4
DIFF:
https://github.com/llvm/llvm-project/commit/ddd2af3c5a076f2c5f2024019067b206d1b411b4.diff
LOG: Del
https://github.com/zmodem closed
https://github.com/llvm/llvm-project/pull/108342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 556 matches
Mail list logo
