ilya-biryukov wrote:
Other than the test, the idea of the change does seem correct, here's the
relevant comment from `Sema.h`:
```cpp
/// The current index into pack expansion arguments that will be
/// used for substitution of parameter packs.
///
/// The pack expansion index will be -1 to indi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5f05d5ec8f9bb15c0ac29fce843a2c73165ac414
33b9d83aeea01fc62a67b71f49a63dcaf4e49509 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
5f05d5ec8f9bb15c0ac29fce843a2c73165ac414...33b9d83aeea01fc62a67b71f49a63dcaf4e49509
llvm/
https://github.com/igelbox ready_for_review
https://github.com/llvm/llvm-project/pull/108187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/paulwalker-arm closed
https://github.com/llvm/llvm-project/pull/107599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Paul Walker
Date: 2024-09-11T14:03:01+01:00
New Revision: 2a130f1a140613445b8f387d3fa54328c1b94cde
URL:
https://github.com/llvm/llvm-project/commit/2a130f1a140613445b8f387d3fa54328c1b94cde
DIFF:
https://github.com/llvm/llvm-project/commit/2a130f1a140613445b8f387d3fa54328c1b94cde.diff
L
zimirza wrote:
Thank you for the thorough feedback. I apologize for going back and forth in
this pull request. I will try to double check my work in future pull requests.
https://github.com/llvm/llvm-project/pull/107285
___
cfe-commits mailing list
cf
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Vakhurin Sergei (igelbox)
Changes
Resolves: #70930 (and probably latest comments from
https://github.com/clangd/clangd/issues/251)
by fixing racing for the shared `DiagStorage` value which caused messing w
https://github.com/sdesmalen-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/108008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/108197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Migrate Builtins emitter to use const RecordKeeper.
---
Full diff: https://github.com/llvm/llvm-project/pull/108195.diff
2 Files Affected:
- (modified) clang/utils/TableGen/ClangBuiltinsEmitter.cpp (+1-1)
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdesmalen-arm wrote:
> > The SME type attributes are not part of the name mangling
>
> If `int(&)() __arm_streaming` is a different type from `int(&)()` for
> template instantiation, it should have different mangling. If it doesn't,
> that's a bug. If there is no spec for the correct mangling,
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lenary wrote:
Reviewing on the basis this is stacked on top of #107817
https://github.com/llvm/llvm-project/pull/108131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary approved this pull request.
https://github.com/llvm/llvm-project/pull/108131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary approved this pull request.
LGTM, on the basis the preprocessor changes are in a different PR.
https://github.com/llvm/llvm-project/pull/107817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/108224
OpenCL has a reserved operator (^^), the use of which was diagnosed as an error
(735c6cdebdcd4292928079cb18a90f0dd5cd65fb). However, OpenCL also encourages
working with the blocks language extension. This
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Aaron Ballman (AaronBallman)
Changes
OpenCL has a reserved operator (^^), the use of which was diagnosed as an error
(735c6cdebdcd4292928079cb18a90f0dd5cd65fb). However, OpenCL also encourages
working with the blocks language extensi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b9c2e2e3e910f8283f52c574fd8b6a7981d6cb0d
81c7e305213deaa55131d044f17029a62e185025 --e
cor3ntin wrote:
The changes to the lexer look fine.
I do have a question though
Both the OpenCL 3.0 2.0 "C language specification" mention "^^ as being
reserved"
(https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html)
However it does not appear to be the case - in the Ope
@@ -82,7 +83,7 @@ namespace clang {
/// to either Ignore (nothing), Remark (emit a remark), Warning
/// (emit a warning) or Error (emit as an error). It allows clients to
/// map ERRORs to Error or Fatal (stop emitting diagnostics after this
one).
-enum class
@@ -179,13 +180,85 @@ class DiagnosticMapping {
class DiagnosticIDs : public RefCountedBase {
public:
/// The level of the diagnostic, after it has been through mapping.
- enum Level {
-Ignored, Note, Remark, Warning, Error, Fatal
+ enum Level : uint8_t { Ignored, Note,
https://github.com/erichkeane approved this pull request.
I think this is fine to commit, sorry my review took so long!
https://github.com/llvm/llvm-project/pull/70976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/70976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,13 +180,85 @@ class DiagnosticMapping {
class DiagnosticIDs : public RefCountedBase {
public:
/// The level of the diagnostic, after it has been through mapping.
- enum Level {
-Ignored, Note, Remark, Warning, Error, Fatal
+ enum Level : uint8_t { Ignored, Note,
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/108215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
I think this change is sensible/innocuous enough. While the clangd
justification is somewhat motivating, it would depend on where we want to
backport it to.
it seems to me that a x.0.0 release would probably be acceptable for
backport
@@ -3567,7 +3567,10 @@ bool Sema::resolveAssumedTemplateNameAsType(Scope *S,
TemplateName &Name,
if (Corrected && Corrected.getFoundDecl()) {
diagnoseTypo(Corrected, PDiag(diag::err_no_template_suggest)
<< ATN->getDeclName());
-Name =
Author: Timm Baeder
Date: 2024-09-11T16:14:41+02:00
New Revision: 35f7cfb22420a7c94b48e54fa28195ada9863d1a
URL:
https://github.com/llvm/llvm-project/commit/35f7cfb22420a7c94b48e54fa28195ada9863d1a
DIFF:
https://github.com/llvm/llvm-project/commit/35f7cfb22420a7c94b48e54fa28195ada9863d1a.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/108207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
erichkeane wrote:
What cases are we wanting to check our lifetime extending context when there is
possibly
@@ -2509,8 +2509,9 @@ Parser::DeclGroupPtrTy
Parser::ParseDeclGroup(ParsingDeclSpec &DS,
// P2718R0 - Lifetime extension in range-based for loops.
if (getLangOpts().CPlusPlus23) {
-auto &LastRecord = Actions.ExprEvalContexts.back();
+auto &LastReco
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
- "Must be in an expression evaluation context");
-return ExprEvalContexts.back().InLifetimeExtendingContext;
+
@@ -120,10 +120,11 @@ void aggregateWithReferences() {
clang_analyzer_dump(viaReference);// expected-warning-re
{{&lifetime_extended_object{RefAggregate, viaReference, S{{[0-9]+}}} }}
clang_analyzer_dump(viaReference.rx); // expected-warning-re
{{&lifetime_extended_obj
AaronBallman wrote:
Given how late in the cycle it is, I would say we shouldn't backport *now* but
if we do another point release of 19.x, then we should backport then.
https://github.com/llvm/llvm-project/pull/108148
___
cfe-commits mailing list
cfe-
erichkeane wrote:
> Given how late in the cycle it is, I would say we shouldn't backport _now_
> but if we do another point release of 19.x, then we should backport then.
Offline, Aaron and I discussed the changes this release cycle, and I think I
agree with this. We're too close to the curre
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
yronglin wrote:
We check `isInLifetimeExtendingContext` when we create a
`MaterializedTemporaryExpr`, if in
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
erichkeane wrote:
Sure, but why would this be in a case where we're not in an evaluation context?
You're r
@@ -2509,8 +2509,9 @@ Parser::DeclGroupPtrTy
Parser::ParseDeclGroup(ParsingDeclSpec &DS,
// P2718R0 - Lifetime extension in range-based for loops.
if (getLangOpts().CPlusPlus23) {
-auto &LastRecord = Actions.ExprEvalContexts.back();
+auto &LastReco
@@ -2509,8 +2509,9 @@ Parser::DeclGroupPtrTy
Parser::ParseDeclGroup(ParsingDeclSpec &DS,
// P2718R0 - Lifetime extension in range-based for loops.
if (getLangOpts().CPlusPlus23) {
-auto &LastRecord = Actions.ExprEvalContexts.back();
+auto &LastReco
@@ -120,10 +120,11 @@ void aggregateWithReferences() {
clang_analyzer_dump(viaReference);// expected-warning-re
{{&lifetime_extended_object{RefAggregate, viaReference, S{{[0-9]+}}} }}
clang_analyzer_dump(viaReference.rx); // expected-warning-re
{{&lifetime_extended_obj
yronglin wrote:
Thanks for your review! @cor3ntin @erichkeane
https://github.com/llvm/llvm-project/pull/108039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
python3kgae wrote:
> This pull request is missing the appropriate text in 'ReleaseNotes.rst'. I am
> looking for advice on what is appropriate to put in that file, and where.
Here's a PR with ReleaseNotes.rst change
https://github.com/llvm/llvm-project/commit/57f879cdd4c63189c569bdc1ce4e87e734
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/108039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> The changes to the lexer look fine.
>
> I do have a question though Both the OpenCL 3.0 2.0 "C language
> specification" mention "^^ as being reserved"
> (https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html)
>
> However it does not appear to be the
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change comment command emitter to const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderived
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change HTMLNamedCharacterReferenceEmitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablege
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change HTML Tags emitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderivedde
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change DataCollectors Emitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderi
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change Diagnostic Emitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderivedd
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change Opcode Emitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefin
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change OptionDoc Emitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderivedde
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
yronglin wrote:
Oh, I understand your concern. It's because we use
`Sema::currentEvaluationContext()`, it's
https://github.com/stevecor closed
https://github.com/llvm/llvm-project/pull/77021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/108039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
erichkeane wrote:
Ah! I should have thought that was the case. No need to add it back, thanks
for clarify
@@ -2509,8 +2509,9 @@ Parser::DeclGroupPtrTy
Parser::ParseDeclGroup(ParsingDeclSpec &DS,
// P2718R0 - Lifetime extension in range-based for loops.
if (getLangOpts().CPlusPlus23) {
-auto &LastRecord = Actions.ExprEvalContexts.back();
+auto &LastReco
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108201
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/108039
>From a74835579629073b4542cad0d17d5f4c7f501d52 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 10 Sep 2024 22:27:23 +0800
Subject: [PATCH 1/3] Reapply "[Clang][CWG1815] Support lifetime extension of
tempora
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7810,9 +7813,11 @@ class Sema final : public SemaBase {
}
bool isInLifetimeExtendingContext() const {
-assert(!ExprEvalContexts.empty() &&
- "Must be in an expression evaluation context");
-return ExprEvalContexts.back().InLifetimeExtendingContext;
+
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,12 +39,13 @@ using namespace llvm;
namespace {
class DiagGroupParentMap {
- RecordKeeper &Records;
- std::map > Mapping;
+ const RecordKeeper &Records;
+ std::map> Mapping;
AaronBallman wrote:
Not for this PR, but maybe this should use a `MapVector
@@ -39,12 +39,13 @@ using namespace llvm;
namespace {
class DiagGroupParentMap {
- RecordKeeper &Records;
- std::map > Mapping;
+ const RecordKeeper &Records;
+ std::map> Mapping;
+
public:
- DiagGroupParentMap(RecordKeeper &records) : Records(records) {
-std::vector
@@ -255,20 +257,18 @@ class InferPedantic {
GMap;
DiagGroupParentMap &DiagGroupParents;
- const std::vector &Diags;
- const std::vector DiagGroups;
+ ArrayRef Diags;
AaronBallman wrote:
Are we sure this isn't going to cause lifetime issues because
@@ -68,7 +69,8 @@ getCategoryFromDiagGroup(const Record *Group,
// The diag group may the subgroup of one or more other diagnostic groups,
// check these for a category as well.
- const std::vector &Parents = DiagGroupParents.getParents(Group);
+ const std::vector &Paren
https://github.com/paulwalker-arm edited
https://github.com/llvm/llvm-project/pull/108008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Clement Courbet
Date: 2024-09-11T17:02:47+02:00
New Revision: 512cecad4c384c84b79fea050a755cb7e46c6ac5
URL:
https://github.com/llvm/llvm-project/commit/512cecad4c384c84b79fea050a755cb7e46c6ac5
DIFF:
https://github.com/llvm/llvm-project/commit/512cecad4c384c84b79fea050a755cb7e46c6ac5.dif
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/108215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2509,8 +2509,9 @@ Parser::DeclGroupPtrTy
Parser::ParseDeclGroup(ParsingDeclSpec &DS,
// P2718R0 - Lifetime extension in range-based for loops.
if (getLangOpts().CPlusPlus23) {
-auto &LastRecord = Actions.ExprEvalContexts.back();
+auto &LastReco
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/108039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 507 matches
Mail list logo
