[clang] 6dacc38 - [OpenACC] Properly ignore side-effects in clause arguments

2024-09-10 Thread via cfe-commits
Author: erichkeane Date: 2024-09-10T13:10:52-07:00 New Revision: 6dacc382f5158b28550c25cd452848f4ab3ecd63 URL: https://github.com/llvm/llvm-project/commit/6dacc382f5158b28550c25cd452848f4ab3ecd63 DIFF: https://github.com/llvm/llvm-project/commit/6dacc382f5158b28550c25cd452848f4ab3ecd63.diff LO

[clang] 27a01f6 - [clang] correct argument offset for function template partial ordering (#107972)

2024-09-10 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-09-10T17:11:49-03:00 New Revision: 27a01f6b4c47baefc347e47e4d38ea26bb721b2d URL: https://github.com/llvm/llvm-project/commit/27a01f6b4c47baefc347e47e4d38ea26bb721b2d DIFF: https://github.com/llvm/llvm-project/commit/27a01f6b4c47baefc347e47e4d38ea26bb721b2d.dif

[clang] [clang] correct argument offset for function template partial ordering (PR #107972)

2024-09-10 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/107972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] Full path names are used in several unittests instead of the binary name. Fix up the testcase failures (PR #107974)

2024-09-10 Thread via cfe-commits
https://github.com/HighW4y2H3ll edited https://github.com/llvm/llvm-project/pull/107974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-10 Thread via cfe-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/107458 >From c7435ccfabc5a4a91266e7dff71815a4c1094c37 Mon Sep 17 00:00:00 2001 From: jofernau Date: Tue, 10 Sep 2024 14:24:27 -0400 Subject: [PATCH] [HIP][Clang][CodeGen] Handle hip bin symbols properly. Remove '_' in f

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-10 Thread Frederik Carlier via cfe-commits
qmfrederik wrote: @davidchisnall and @compnerd -- anything else you need before this can get merged? https://github.com/llvm/llvm-project/pull/107604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ commented: Aha makes sense! Looks like you're putting no restrictions on what the opaque function is. This may cause some false negatives but it's probably ultimately ok, but it might be a good idea to confirm. https://github.com/llvm/llvm-project/pull/107676 ___

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/107676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Artem Dergachev via cfe-commits
@@ -67,6 +68,15 @@ class DerefFuncDeleteExprVisitor const Decl *D = CE->getCalleeDecl(); if (D && D->hasBody()) return VisitBody(D->getBody()); +else if (!VisitLambdaBody) { + for (unsigned i = 0; i < CE->getNumArgs(); ++i) { +auto *Arg = CE->getA

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-10 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/107954 >From 1c66d2767ca20f42b6edaae834cc186be7d23712 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 9 Sep 2024 19:39:02 -0700 Subject: [PATCH 1/4] [HLSL] Add `[[hlsl::row_access]]` attribute This PR introduces

[clang] [HLSL] Allow truncation to scalar (PR #104844)

2024-09-10 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/104844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-10 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/108083 To detect unsafe use of bit_cast that should be reinterpret_cast instead. Otherwise, bit_cast bypasses all checks done by compilers and linters. Fixes #106987 >From 6916d5ecdc327b2771fbbca226095bd99d394d

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Carlos Galvez (carlosgalvezp) Changes To detect unsafe use of bit_cast that should be reinterpret_cast instead. Otherwise, bit_cast bypasses all checks done by compilers and linters. Fixes #106987 --- Full diff: https://githu

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Carlos Galvez (carlosgalvezp) Changes To detect unsafe use of bit_cast that should be reinterpret_cast instead. Otherwise, bit_cast bypasses all checks done by compilers and linters. Fixes #106987 --- Full diff: https://github.com/l

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b8b8fbe19dea2825b801c4738ff78dbf26aae430 6916d5ecdc327b2771fbbca226095bd99d394dab --e

[clang] [llvm] [Utils] add --update-tests flag to llvm-lit (PR #97369)

2024-09-10 Thread Henrik G. Olsson via cfe-commits
@@ -0,0 +1,10 @@ +// RUN: %clang_cc1 -verify %s +// RUN: diff %s %s.expected hnrklssn wrote: The files in the `Inputs` directory are not discovered by lit, so this doesn't actually run the RUN lines. Instead a copy is made, and a new lit instance is launched to

[clang] [llvm] [Utils] add --update-tests flag to llvm-lit (PR #97369)

2024-09-10 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: > I think the integration into lit is okay. The diff updater seems neat, but I > think it could be taken into a separate change, see also the inline comment. > In general, I think this PR really does three separate things, that ought to > be in separate changes: > > * Add

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/108097 HLSL 202x inherits from C++11, which generates additional loop hint information for loops that must progress. Since HLSL 202x is going to be the default for Clang we want to make sure all our tests pass with

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Chris B (llvm-beanz) Changes HLSL 202x inherits from C++11, which generates additional loop hint information for loops that must progress. Since HLSL 202x is going to be the default for Clang we want to make sure all our tests pass with it

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/108097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread Cooper Partin via cfe-commits
https://github.com/coopp approved this pull request. Looks fine to me. Am I correct that there will be quite a few more incoming changes for the other tests that use hlsl2021 or older settings? https://github.com/llvm/llvm-project/pull/108097 ___ cfe

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/108097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-10 Thread via cfe-commits
@@ -387,6 +387,65 @@ float3 asin(float3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_asin) float4 asin(float4); +//===--===// +// asuint builtins +//===--

[clang] [BPF] make __BPF_FEATURE_MAY_GOTO available for cpuv1 (PR #108071)

2024-09-10 Thread via cfe-commits
https://github.com/yonghong-song approved this pull request. https://github.com/llvm/llvm-project/pull/108071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread Chris B via cfe-commits
llvm-beanz wrote: > Looks fine to me. Am I correct that there will be quite a few more incoming > changes for the other tests that use hlsl2021 or older settings? Just a few more. Most of the tests don't change when 202x is the default. https://github.com/llvm/llvm-project/pull/108097

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2024-09-10 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman oke, thanks for the update. https://github.com/llvm/llvm-project/pull/106036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -1216,10 +1324,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -1216,10 +1324,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -944,12 +950,67 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +struct InheritedConstructorDeductionInfo { + TemplateDecl *DerivedClassTemplate; + TypeSourceInfo *CCType; +}; + +// Build th

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -944,12 +950,67 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +struct InheritedConstructorDeductionInfo { + TemplateDecl *DerivedClassTemplate; + TypeSourceInfo *CCType; +}; + +// Build th

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -944,12 +950,67 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +struct InheritedConstructorDeductionInfo { + TemplateDecl *DerivedClassTemplate; antangelo wrote: Done http

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -1216,10 +1308,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -1216,10 +1308,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-10 Thread via cfe-commits
@@ -936,19 +940,21 @@ Expr *buildIsDeducibleConstraint(Sema &SemaRef, Context.DeclarationNames.getCXXDeductionGuideName(AliasTemplate)); }; + TemplateDecl *TD = DeducingTemplate ? DeducingTemplate : AliasTemplate; + SmallVector IsDeducibleTypeTraitArgs = {

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-10 Thread Dan Liew via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: %clang_cc1 -fsyntax-only -I%S/Inputs -Wthread-safety %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -I%S/Inputs -Wthread-safety -std=c++98 %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -I%S/Inputs -Wthread-safety -std=c++11 %s -D C

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-10 Thread Dan Liew via cfe-commits
@@ -5080,6 +5083,17 @@ void Parser::ParseLexedCAttribute(LateParsedAttribute &LA, bool EnterScope, ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, nullptr, nullptr, SourceLocation(), ParsedAttr::Form::GNU(), nullptr); + const auto &SM = P

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-10 Thread Dan Liew via cfe-commits
@@ -5080,6 +5083,17 @@ void Parser::ParseLexedCAttribute(LateParsedAttribute &LA, bool EnterScope, ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, nullptr, nullptr, SourceLocation(), ParsedAttr::Form::GNU(), nullptr); + const auto &SM = P

[clang] [llvm] [docs] Add a section on AI-generated content to the developer policy (PR #91014)

2024-09-10 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/91014 >From 88e4991013a05e26cece87d3989ad957a4e18e3d Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Wed, 4 Sep 2024 16:52:49 + Subject: [PATCH 1/5] [clang] Fix FIXME in dynamic initializer emission, NFCI This poten

[clang] [llvm] [docs] Add a section on AI-generated content to the developer policy (PR #91014)

2024-09-10 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/91014 >From 88e4991013a05e26cece87d3989ad957a4e18e3d Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Wed, 4 Sep 2024 16:52:49 + Subject: [PATCH 1/6] [clang] Fix FIXME in dynamic initializer emission, NFCI This poten

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-10 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106588 >From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Wed, 24 Jul 2024 16:49:19 -0600 Subject: [PATCH 1/9] [HLSL] set alwaysinline on HLSL functions HLSL inlines all its

[clang] [llvm] [docs] Add a section on AI-generated content to the developer policy (PR #91014)

2024-09-10 Thread Reid Kleckner via cfe-commits
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/91014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-10 Thread Yeoul Na via cfe-commits
@@ -5080,6 +5083,17 @@ void Parser::ParseLexedCAttribute(LateParsedAttribute &LA, bool EnterScope, ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, nullptr, nullptr, SourceLocation(), ParsedAttr::Form::GNU(), nullptr); + const auto &SM = P

[clang] [HLSL] Add `[[hlsl::row_access]]` attribute (PR #107954)

2024-09-10 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp requested changes to this pull request. There's been some discussion about the design for this offline that should be resolved before this PR is completed. https://github.com/llvm/llvm-project/pull/107954 ___ cfe-commits mai

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-10 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl created https://github.com/llvm/llvm-project/pull/108116 Building with no optimizations resulted in failures since the lane constant wasn't a constant in LLVM IR. >From 3b813cd5b0555e6b654f575140e4db9a57ed699a Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Tu

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brendan Dahl (brendandahl) Changes Building with no optimizations resulted in failures since the lane constant wasn't a constant in LLVM IR. --- Full diff: https://github.com/llvm/llvm-project/pull/108116.diff 3 Files Affected: - (modi

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-10 Thread Derek Schuff via cfe-commits
@@ -1888,18 +1888,15 @@ static __inline__ v128_t __FP16_FN_ATTRS wasm_f16x8_splat(float __a) { return (v128_t)__builtin_wasm_splat_f16x8(__a); } -static __inline__ float __FP16_FN_ATTRS wasm_f16x8_extract_lane(v128_t __a, -

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-10 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/108121 Implement elementwise popcount to support HLSL function 'countbits'. Closes #99094 >From 365886deae6e35ee2761c2fae2a28caa0e214880 Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Fri, 6 Sep 2024 21:03:05 +

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sarah Spall (spall) Changes Implement elementwise popcount to support HLSL function 'countbits'. Closes #99094 --- Full diff: https://github.com/llvm/llvm-project/pull/108121.diff 13 Files Affected: - (modified) clang/docs/LanguageExt

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-10 Thread Sarah Spall via cfe-commits
spall wrote: This pull request is missing the appropriate text in 'ReleaseNotes.rst'. I am looking for advice on what is appropriate to put in that file, and where. https://github.com/llvm/llvm-project/pull/108121 ___ cfe-commits mailing list cfe-comm

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 109cd11dc4aea6b3596f8b2cb5a719f35b190cfa 365886deae6e35ee2761c2fae2a28caa0e214880 --e

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/108097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: > Looks like you're putting no restrictions on what the opaque function is. > This may cause some false negatives but it's probably ultimately ok, but it > might be a good idea to confirm. Yes, we're not putting any requirement for the functions for now. https://github.com/llvm/l

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/107676 >From 9a8c60355f88d7d4cee6d9f75312bb87d13b74a9 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 7 Sep 2024 01:45:05 -0700 Subject: [PATCH] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not gene

[clang] 69ed733 - [RISCV] Add testcase for -mcmodel= (#107816)

2024-09-10 Thread via cfe-commits
Author: Jim Lin Date: 2024-09-11T09:17:05+08:00 New Revision: 69ed73380b9a1ec2d09d9b443a52b3ccd141334d URL: https://github.com/llvm/llvm-project/commit/69ed73380b9a1ec2d09d9b443a52b3ccd141334d DIFF: https://github.com/llvm/llvm-project/commit/69ed73380b9a1ec2d09d9b443a52b3ccd141334d.diff LOG:

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-10 Thread Jim Lin via cfe-commits
https://github.com/tclin914 closed https://github.com/llvm/llvm-project/pull/107816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Emit "omnipotent char" for intrinsics with type cast (PR #107793)

2024-09-10 Thread via cfe-commits
huhu233 wrote: > I'll need to look to see if the TBAA metadata we're adding matches what we > initially envisaged but my gut feeling matches @arsenm. > > I'm assuming the original code emitted an error, something along the lines of > "no version of svst1 available for long long*", which you've

[clang] [HLSL] fix elementwise bitreverse test (PR #108128)

2024-09-10 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/108128 The test called 'ceil' instead of 'bitreverse', which I assume was a copy paste leftover. >From 86e24b508c47ee6ad09cbaec299baeab32cf964b Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Wed, 11 Sep 2024 01:22:37

[clang] [HLSL] fix elementwise bitreverse test (PR #108128)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sarah Spall (spall) Changes The test called 'ceil' instead of 'bitreverse', which I assume was a copy paste leftover. --- Full diff: https://github.com/llvm/llvm-project/pull/108128.diff 1 Files Affected: - (modified) clang/test/Sema/b

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-10 Thread Jim Lin via cfe-commits
https://github.com/tclin914 updated https://github.com/llvm/llvm-project/pull/107817 >From e394e7ca9e769deb3f286f53a48a049340bd51bd Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Mon, 9 Sep 2024 13:09:23 +0800 Subject: [PATCH 1/3] [RISCV] Allow -mcmodel= to accept large for RV64 --- clang/lib/D

[clang] [RISCV] Emit predefined macro __riscv_cmodel_large for large code model (PR #108131)

2024-09-10 Thread Jim Lin via cfe-commits
https://github.com/tclin914 created https://github.com/llvm/llvm-project/pull/108131 None >From e394e7ca9e769deb3f286f53a48a049340bd51bd Mon Sep 17 00:00:00 2001 From: Jim Lin Date: Mon, 9 Sep 2024 13:09:23 +0800 Subject: [PATCH 1/4] [RISCV] Allow -mcmodel= to accept large for RV64 --- clang

[clang] [RISCV] Emit predefined macro __riscv_cmodel_large for large code model (PR #108131)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jim Lin (tclin914) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/108131.diff 5 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/lib/Basic/Targets/RISCV.cpp (+2) - (modified) clang/li

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-10 Thread Jim Lin via cfe-commits
tclin914 wrote: > What I am missing is: > > * adjustments in `clang/lib/Basic/Targets/RISCV.cpp` to emit the macro > `__riscv_cmodel_large` > * new tests in `clang/test/Preprocessor/riscv-cmodel.c` > > Related PRs: > > * [Add __riscv_cmodel_large define for large code modelĀ  > riscv-non-isa/r

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/107676 >From be0c2e0af8e06f4b5f33855a7020b5148cb1846c Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 10 Sep 2024 19:03:12 -0700 Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not generat

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
@@ -67,6 +68,15 @@ class DerefFuncDeleteExprVisitor const Decl *D = CE->getCalleeDecl(); if (D && D->hasBody()) return VisitBody(D->getBody()); +else if (!VisitLambdaBody) { + for (unsigned i = 0; i < CE->getNumArgs(); ++i) { +auto *Arg = CE->getA

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: > > Looks like you're putting no restrictions on what the opaque function is. > > This may cause some false negatives but it's probably ultimately ok, but it > > might be a good idea to confirm. > > Yes, we're not putting any requirement for the functions for now. Actually, why n

[clang-tools-extra] [Docs][clang-query] disclose Windows linetab bug on clang-query tab auto-complete (PR #107956)

2024-09-10 Thread via cfe-commits
https://github.com/MichelleCDjunaidi edited https://github.com/llvm/llvm-project/pull/107956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][clang-query] disclose Windows linetab bug on clang-query tab auto-complete (PR #107956)

2024-09-10 Thread via cfe-commits
https://github.com/MichelleCDjunaidi updated https://github.com/llvm/llvm-project/pull/107956 >From f7e11ba4d19320397d653a17f769f87260db8b86 Mon Sep 17 00:00:00 2001 From: MichelleCDjunaidi <87893361+michellecdjuna...@users.noreply.github.com> Date: Tue, 10 Sep 2024 11:15:24 +0800 Subject: [PATC

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-10 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106588 >From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Wed, 24 Jul 2024 16:49:19 -0600 Subject: [PATCH 01/10] [HLSL] set alwaysinline on HLSL functions HLSL inlines all it

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-10 Thread Congcong Cai via cfe-commits
@@ -225,3 +225,14 @@ void bad_custom_stream() { // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl] // CHECK-FIXES: logger << '\n'; } + +namespace gh107859 { + +#define ENDL std::endl; + +void bad_macr

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: Should we forbidden bit cast pointer to number and number to pointer? or we should only forbidden bit cast pointer to pointer. https://github.com/llvm/llvm-project/pull/108083 ___ cfe-commits mailing list cfe-

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-10 Thread via cfe-commits
@@ -0,0 +1,32 @@ +=== +External Clang-Tidy Examples +=== + +Introduction + + +This page provides examples of what people have done with `clang-tidy` that +might serve as useful guides (or starting points) to develop your own che

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Artem Dergachev via cfe-commits
@@ -67,6 +68,48 @@ class DerefFuncDeleteExprVisitor const Decl *D = CE->getCalleeDecl(); if (D && D->hasBody()) return VisitBody(D->getBody()); +else { + auto name = safeGetName(D); + if (name == "ensureOnMainThread" || name == "ensureOnMainRunLoop")

[clang] [clang] Allow `pragma float_control(precise, *)` to... (PR #105912)

2024-09-10 Thread Egor Chesakov via cfe-commits
echesakov wrote: Ping https://github.com/llvm/llvm-project/pull/105912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-10 Thread via cfe-commits
https://github.com/ofAlpaca created https://github.com/llvm/llvm-project/pull/108142 Resolve #94928 Hi @zyn0217 This PR adds `if (TD->getTemplateDecl())` to prevent `InnerD` becoming `nullptr`, suggested by @firstmoonlight. I also add `-ast-dump-decl-types` option and declare type `CHECK` to t

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: ofAlpaca (ofAlpaca) Changes Resolve #94928 Hi @zyn0217 This PR adds `if (TD->getTemplateDecl())` to prevent `InnerD` becoming `nullptr`, suggested by @firstmoonlight. I also add `-ast-dump-decl-types` option and declare type `CHECK` to th

[clang] -ast-dump-decl-types crashes on codes involving concepts #94928 (PR #108142)

2024-09-10 Thread via cfe-commits
https://github.com/ofAlpaca updated https://github.com/llvm/llvm-project/pull/108142 >From efcf875af403831bbd4d472a9a3a9fbff4438753 Mon Sep 17 00:00:00 2001 From: ofAlpaca Date: Wed, 11 Sep 2024 11:24:55 +0800 Subject: [PATCH] [clang] Fix TemplatedDecl being nullptr and cause crash --- clang/

[clang] [NFC] Fix an inaccurate comment about typo-correction. (PR #108143)

2024-09-10 Thread Michael Park via cfe-commits
https://github.com/mpark created https://github.com/llvm/llvm-project/pull/108143 The comment describes "If the identifier was typo-corrected", but it doesn't need to have been typo-corrected, just being annotated is enough to retry. >From a5cb61e79b928dae0272dc9b3c5448050361f775 Mon Sep 17 00

[clang] [NFC] Fix an inaccurate comment about typo-correction. (PR #108143)

2024-09-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Park (mpark) Changes The comment describes "If the identifier was typo-corrected", but it doesn't need to have been typo-corrected, just being annotated is enough to retry. --- Full diff: https://github.com/llvm/llvm-project/pull/

[clang] Add "clang-format-on-save-mode" minor mode to clang-format.el (PR #104533)

2024-09-10 Thread Campbell Barton via cfe-commits
ideasman42 wrote: Is there any action needed on my side? (the PR was approved over a week ago). https://github.com/llvm/llvm-project/pull/104533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
@@ -67,6 +68,48 @@ class DerefFuncDeleteExprVisitor const Decl *D = CE->getCalleeDecl(); if (D && D->hasBody()) return VisitBody(D->getBody()); +else { + auto name = safeGetName(D); + if (name == "ensureOnMainThread" || name == "ensureOnMainRunLoop")

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/107676 >From cb214cc1f922e16ea4bd81f3c9cac54bc97c2968 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 10 Sep 2024 19:03:12 -0700 Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not generat

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
@@ -67,6 +68,48 @@ class DerefFuncDeleteExprVisitor const Decl *D = CE->getCalleeDecl(); if (D && D->hasBody()) return VisitBody(D->getBody()); +else { + auto name = safeGetName(D); + if (name == "ensureOnMainThread" || name == "ensureOnMainRunLoop")

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/107676 >From 3a5031d022f01baaf6fd96b2c2c0891e9b627d2c Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 10 Sep 2024 19:03:12 -0700 Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not generat

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/107676 >From 516ba7d30880f9aa2a0bf6ed884f5d5541b430ce Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 10 Sep 2024 19:03:12 -0700 Subject: [PATCH] This PR makes WebKit's RefCntblBaseVirtualDtor checker not generat

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-10 Thread Nathan Ridge via cfe-commits
@@ -1477,6 +1477,26 @@ TEST_F(SymbolCollectorTest, Documentation) { forCodeCompletion(false; } +TEST_F(SymbolCollectorTest, DocumentationInMain) { HighCommander4 wrote: Another test case that would be useful to have is one where th

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-10 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thank you for the test case. Debugging it helped me better understand the changes to `ASTContext.cpp`. I believe the fact that these changes are needed to get the tests to pass, tells us that there is a bug in `ASTContex

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-10 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-10 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. Aha great LGTM! https://github.com/llvm/llvm-project/pull/107676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d03822d - [clang][bytecode] Fix lookup of source locations in implicit ctors (#107992)

2024-09-10 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-11T07:21:49+02:00 New Revision: d03822d8887adc9312e65abf8d8ce1a16007f2a0 URL: https://github.com/llvm/llvm-project/commit/d03822d8887adc9312e65abf8d8ce1a16007f2a0 DIFF: https://github.com/llvm/llvm-project/commit/d03822d8887adc9312e65abf8d8ce1a16007f2a0.diff L

[clang] [clang][bytecode] Fix lookup of source locations in implicit ctors (PR #107992)

2024-09-10 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/107992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (PR #107676)

2024-09-10 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/107676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 203a2ca - [webkit.RefCntblBaseVirtualDtor] Make ThreadSafeRefCounted not generate warnings (#107676)

2024-09-10 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-09-10T22:25:03-07:00 New Revision: 203a2ca8cd6af505e11a38aebceeaf864271042c URL: https://github.com/llvm/llvm-project/commit/203a2ca8cd6af505e11a38aebceeaf864271042c DIFF: https://github.com/llvm/llvm-project/commit/203a2ca8cd6af505e11a38aebceeaf864271042c.diff

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-10 Thread Nikolas Klauser via cfe-commits
@@ -309,7 +309,10 @@ enum BuiltinTemplateKind : int { BTK__make_integer_seq, /// This names the __type_pack_element BuiltinTemplateDecl. - BTK__type_pack_element + BTK__type_pack_element, + + /// This names the __type_list_dedup BuiltinTemplateDecl. phi

[clang] [clang-tools-extra] [Clang] Add __type_list_dedup builtin to deduplicate types in template arguments (PR #106730)

2024-09-10 Thread Nikolas Klauser via cfe-commits
@@ -309,7 +309,10 @@ enum BuiltinTemplateKind : int { BTK__make_integer_seq, /// This names the __type_pack_element BuiltinTemplateDecl. - BTK__type_pack_element + BTK__type_pack_element, + + /// This names the __type_list_dedup BuiltinTemplateDecl. + BTK__type_list_de

[clang] 6dbdb84 - [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815)

2024-09-10 Thread via cfe-commits
Author: Nikolas Klauser Date: 2024-09-11T08:47:24+02:00 New Revision: 6dbdb8430b492959c399a7809247424c6962902f URL: https://github.com/llvm/llvm-project/commit/6dbdb8430b492959c399a7809247424c6962902f DIFF: https://github.com/llvm/llvm-project/commit/6dbdb8430b492959c399a7809247424c6962902f.dif

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-10 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/107815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-10 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 milestoned https://github.com/llvm/llvm-project/pull/107815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-10 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: /cherry-pick 6dbdb84 https://github.com/llvm/llvm-project/pull/107815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (PR #107815)

2024-09-10 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#108147 https://github.com/llvm/llvm-project/pull/107815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >