[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/107397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Zahira Ammarguellat (zahiraam) Changes This is a warning that wasn't associated with the source location. Moved it to Sema and changed the warning message to a more verbose one. --- Full diff: https://gi

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-09 Thread Sam Elliott via cfe-commits
lenary wrote: > > What's the status of backend support for the large code model? That would > > presumably be a prerequisite to landing this. > > It was just merged: #70308. I expected I was out of date, thanks for the link. The psABI says the large code model is not compatible with PIC - thi

[clang] cf8fb43 - [AArch64] Implement NEON vamin/vamax intrinsics (#99041)

2024-09-09 Thread via cfe-commits
Author: Momchil Velikov Date: 2024-09-09T13:34:41+01:00 New Revision: cf8fb4320f1be29c55909adf5ff8ad47e02b2dbe URL: https://github.com/llvm/llvm-project/commit/cf8fb4320f1be29c55909adf5ff8ad47e02b2dbe DIFF: https://github.com/llvm/llvm-project/commit/cf8fb4320f1be29c55909adf5ff8ad47e02b2dbe.dif

[clang] [llvm] [AArch64] Implement NEON vamin/vamax intrinsics (PR #99041)

2024-09-09 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov closed https://github.com/llvm/llvm-project/pull/99041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Coroutines] Transform "coro_elide_safe" calls to switch ABI coroutines to the `noalloc` variant (PR #99285)

2024-09-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/1107 Here is the relevant pie

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/107598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Zahira Ammarguellat (zahiraam) Changes In https://github.com/llvm/llvm-project/pull/100302, `int` TBAA information was added to math function calls to indicate the type of non-argument memory a function might modify. The purpose

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-09 Thread Malay Sanghi via cfe-commits
@@ -0,0 +1,443 @@ +/*===--- avx10_2satcvtdsintrin.h - AVX512SATCVTDS intrinsics === + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Ap

[clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread Andrew Savonichev via cfe-commits
asavonic wrote: Thanks Michael, I'm glad I'm not the only one seeing this problem. > > If an implicit import happens between (2) and (3), it may indirectly bring > > the same field into the context. When (3) happens we add it again, > > duplicating the field and breaking the record. This is no

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-09-09 Thread Kerry McLaughlin via cfe-commits
kmclaughlin-arm wrote: > Isn't this a bug in the mangler? I mean, it's better to print an error rather > than silently miscompile, but this doesn't really solve the issue. Hi @efriedma-quic, The SME type attributes are not part of the name mangling. We figured an error message would be useful

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-09 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > Thank you for the PR! I'd like to better understand motivation and > justification of SPIR-V BE-related changes though. The goal would be to > understand whether AllSvmDevices is indeed a better choice (for whom?) than > Device as a default mem scope value in SPIR-V BE. > > 1

[clang] [Clang] Add __builtin_selectvector and use it for AVX512 intrinsics (PR #91306)

2024-09-09 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > clang already supports `?:` with a vector condition; does this add anything > new on top of that? This works with bool vectors. I didn't realize you could use the ternary operator, since I only tested with them. I guess we could extend the ternary operator to accept bool v

[clang] [llvm] [Utils] add --update-tests flag to llvm-lit (PR #97369)

2024-09-09 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle edited https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Utils] add --update-tests flag to llvm-lit (PR #97369)

2024-09-09 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle commented: I think the integration into lit is okay. The diff updater seems neat, but I think it could be taken into a separate change, see also the inline comment. In general, I think this PR really does three separate things, that ought to be in separate changes:

[clang] [llvm] [Utils] add --update-tests flag to llvm-lit (PR #97369)

2024-09-09 Thread Nicolai Hähnle via cfe-commits
@@ -0,0 +1,10 @@ +// RUN: %clang_cc1 -verify %s +// RUN: diff %s %s.expected nhaehnle wrote: The way I understand it, the update-verify-tests plugin in lit will overwrite this source file, which may end up overwriting this RUN line if there is a bug. Basically,

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

2024-09-09 Thread Daniel Krupp via cfe-commits
dkrupp wrote: @haoNoQ gentle ping. Could you please check if this would be good to be merged now? thanks. https://github.com/llvm/llvm-project/pull/67352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-09 Thread Erich Keane via cfe-commits
@@ -876,6 +876,11 @@ class Sema; /// function pointer or reference (C++ [over.call.object]). FunctionDecl *Function; +/// LambdaName - When the OverloadCandidate is for a +/// lambda's operator(), points to the declaration of +/// the lambda variable. +

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-09 Thread Erich Keane via cfe-commits
@@ -10204,15 +10205,14 @@ class Sema final : public SemaBase { /// both @c a1 and @c a2. If @p SuppressUserConversions, then don't /// allow user-defined conversions via constructors or conversion /// operators. - void - AddMethodCandidate(CXXMethodDecl *Method, DeclAcc

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-09 Thread Erich Keane via cfe-commits
@@ -6292,11 +6298,16 @@ SemaCodeCompletion::ProduceCallSignatureHelp(Expr *Fn, ArrayRef Args, SmallVector ArgExprs(1, NakedFn); ArgExprs.append(ArgsWithoutDependentTypes.begin(), ArgsWithoutDependentTypes.end()); +auto *const Lam

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank commented: I commented in issue but I think the problem is with `re.Match` not Tuple. [Python docs](https://docs.python.org/3.5/library/typing.html#typing.Tuple) seem to show Tuple had subscripting from its introduction in 3.5. The script currently passes a strict m

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
@@ -526,7 +526,7 @@ def process_doc(doc_file: Tuple[str, str]) -> Tuple[str, Optional[re.Match[str]] # Is it a redirect? return check_name, match -def format_link(doc_file: Tuple[str, str]) -> str: +def format_link(doc_file) -> str: ---

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
@@ -538,7 +538,7 @@ def format_link(doc_file: Tuple[str, str]) -> str: else: return "" -def format_link_alias(doc_file: Tuple[str, str]) -> str: +def format_link_alias(doc_file) -> str: nicovank wrote: So can this. https://github.

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
@@ -511,7 +511,7 @@ def has_auto_fix(check_name: str) -> str: return "" -def process_doc(doc_file: Tuple[str, str]) -> Tuple[str, Optional[re.Match[str]]]: +def process_doc(doc_file): nicovank wrote: Change the `re.Match[str]` to `typing.Any

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1a9acd786d493b00c08d1611f51420d421b74cf1 d8140f9013f47094a159fd2918128d9252ca3280 --e

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/107850 >From 36fff2ffdb29d8510c31464f6f6aad97721607c9 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Mon, 9 Sep 2024 14:03:12 +0200 Subject: [PATCH 1/2] [clang-tidy] remove type annotations that require python3.

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. I'm not satisfied with the quality of the reports. The report refers to `Subtraction of two pointers that do not point into the same array is undefined behavior` without pointing out where the two pointers point to (and/or wher

[clang] [clang, hexagon] Update copyright, license text (PR #107161)

2024-09-09 Thread via cfe-commits
SidManning wrote: LGTM https://github.com/llvm/llvm-project/pull/107161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-09 Thread Balázs Kéri via cfe-commits
balazske wrote: > I'm not satisfied with the quality of the reports. The report refers to > `Subtraction of two pointers that do not point into the same array is > undefined behavior` without pointing out where the two pointers point to > (and/or where are they declared, or set to point to dif

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
steakhal wrote: LGTM, thanks! https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
@@ -2380,8 +2380,16 @@ RegionStoreManager::bind(RegionBindingsConstRef B, Loc L, SVal V) { // Binding directly to a symbolic region should be treated as binding // to element 0. - if (const SymbolicRegion *SR = dyn_cast(R)) -R = GetElementZeroRegion(SR, SR->getPointe

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
@@ -40,3 +40,12 @@ void testInlineAsmMemcpyUninit(void) MyMemcpy(&a[1], &b[1], sizeof(b) - sizeof(b[1])); c = a[0]; // expected-warning{{Assigned value is garbage or undefined}} } + +void *globalPtr; + +void testNoCrash() +{ + // Use global pointer to make it symbolic.

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
steakhal wrote: Let's wait for the premerge tests before merging. https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/107572 >From 0e8db855a1bde0692260f5aa26c245328a358a50 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 6 Sep 2024 15:15:52 +0300 Subject: [PATCH 1/2] clang/csa: fix crash on bind to symbolic region with void

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-09 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/107213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][VLS] Support RISCV VLS calling convention (PR #100346)

2024-09-09 Thread Brandon Wu via cfe-commits
@@ -317,38 +323,45 @@ ABIArgInfo RISCVABIInfo::coerceAndExpandFPCCEligibleStruct( // Fixed-length RVV vectors are represented as scalable vectors in function // args/return and must be coerced from fixed vectors. -ABIArgInfo RISCVABIInfo::coerceVLSVector(QualType Ty) const {

[clang] Fix codegen for transparent_union function params (PR #104816)

2024-09-09 Thread Lei Huang via cfe-commits
https://github.com/lei137 updated https://github.com/llvm/llvm-project/pull/104816 >From ea3a071a2255fa103f5097272b2fa896a3d4b979 Mon Sep 17 00:00:00 2001 From: Lei Huang Date: Mon, 19 Aug 2024 12:24:31 -0400 Subject: [PATCH 1/3] Fix codegen for transparent_union function params Update codegen

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/107867 use ::std::endl as default message when matched expr does not have valid source text >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes use ::std::endl as default message when matched expr does not have valid source text --- Full diff: https://github.com/llvm/llvm-project/pull/107867.diff 3

[clang] [analyzer] Improve handling of unsigned values in ArrayBoundCheckerV2 (PR #81034)

2024-09-09 Thread Balazs Benics via cfe-commits
steakhal wrote: In this PR, we decided to suppress some reports. It turns out the `alpha.security.ReturnPtrRange` would overtake some the suppressed reports and issue a diagnostic itself. Here is an example: https://compiler-explorer.com/z/P9bGTjv5W ```c++ const char *unwindTerminator(const char

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-09 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,478 @@ +/*===--- avx10_2satcvtdsintrin.h - AVX512SATCVTDS intrinsics === + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Ap

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/107572 >From 0e8db855a1bde0692260f5aa26c245328a358a50 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 6 Sep 2024 15:15:52 +0300 Subject: [PATCH 1/3] clang/csa: fix crash on bind to symbolic region with void *

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: added missing declarations. should fix the CI https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Congcong Cai via cfe-commits
@@ -511,7 +511,7 @@ def has_auto_fix(check_name: str) -> str: return "" -def process_doc(doc_file: Tuple[str, str]) -> Tuple[str, Optional[re.Match[str]]]: +def process_doc(doc_file: Tuple[str, str]) -> Tuple[str, Optional[Any]]: HerrCai0907

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 deleted https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-09 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: Tagging @svenvh to be aware of the discussion. I personally don't have a strong opinion at the moment of what should be a default. Currently [SPIR-V To LLVM translator](https://github.com/KhronosGroup/SPIRV-LLVM-Translator) picks "Device" as the default (translation of the atom

[clang] ea92045 - Fix codegen for transparent_union function params (#104816)

2024-09-09 Thread via cfe-commits
Author: Lei Huang Date: 2024-09-09T11:01:22-04:00 New Revision: ea9204505cf1099b98b1fdcb898f0bd35e463984 URL: https://github.com/llvm/llvm-project/commit/ea9204505cf1099b98b1fdcb898f0bd35e463984 DIFF: https://github.com/llvm/llvm-project/commit/ea9204505cf1099b98b1fdcb898f0bd35e463984.diff LOG

[clang] Fix codegen for transparent_union function params (PR #104816)

2024-09-09 Thread Lei Huang via cfe-commits
https://github.com/lei137 closed https://github.com/llvm/llvm-project/pull/104816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes Fixes: #107846 --- Full diff: https://github.com/llvm/llvm-project/pull/107871.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/add_new_check.py (+2-2) ``diff di

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/107867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I think the reason is python3.8 don't support re.Match. see #107871 https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/107871 Fixes: #107846 >From ffc8fb76d35d4cc7d90efeb0346259060fcaa218 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 23:04:10 +0800 Subject: [PATCH] [clang-tidy][NFC] fix add_new_check python3.8

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes Fixes: #107846 --- Full diff: https://github.com/llvm/llvm-project/pull/107871.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/add_new_check.py (+2-2) ``diff diff --gi

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-09-09 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 54e4912ebcee4a54b05367f52a0e83b36a792c81 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: I see `typing.Match` will be [removed in 3.13](https://docs.python.org/3/library/typing.html#typing.Match). I'm not sure if that means it won't work altogether with 3.13 or just the typecheck. ![image](https://github.com/user-attachments/assets/c3d77647-356d-43ba-b344-da8822a0d

[clang-tools-extra] [clang-tidy][run-clang-tidy] Fix minor shutdown noise (PR #105724)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: I'm going to go ahead and merge this. IMO this doesn't need backporting because 1. it only happens on abnormal exit where users probably wouldn't be surprised to see a stacktrace anyway, and 2. there is no regression really (check prior to asyncio change also had some noise aft

[clang-tools-extra] [clang-tidy][run-clang-tidy] Fix minor shutdown noise (PR #105724)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/105724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-09 Thread Dmitry Polukhin via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: @@ -764,6 +792,15 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) { Record.push_back(D->param_size()); for (auto *P : D->parameters()) Re

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-09 Thread Dmitry Polukhin via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/104512 >From 8772795571c9e36c498cb3dba5496e695dfcb7a2 Mon Sep 17 00:00:00 2001 From: Dmitry P

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-09 Thread Dmitry Polukhin via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: @@ -764,6 +792,15 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) { Record.push_back(D->param_size()); for (auto *P : D->parameters()) R

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-09 Thread Dmitry Polukhin via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: @@ -1188,6 +1188,11 @@ class ASTReader /// once recursing loading has been completed. llvm::SmallVector PendingOdrMergeChecks; + /// Lambdas that ne

[clang-tools-extra] 86e5c54 - [clang-tidy][run-clang-tidy] Fix minor shutdown noise (#105724)

2024-09-09 Thread via cfe-commits
Author: Nicolas van Kempen Date: 2024-09-09T11:15:28-04:00 New Revision: 86e5c5468ae3fcd65b23fd7b3cb0182e676829bd URL: https://github.com/llvm/llvm-project/commit/86e5c5468ae3fcd65b23fd7b3cb0182e676829bd DIFF: https://github.com/llvm/llvm-project/commit/86e5c5468ae3fcd65b23fd7b3cb0182e676829bd.

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-09 Thread Dmitry Polukhin via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: @@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) { for (unsigned I = 0; I != NumParams; ++I) Params.push_back(readDeclAs

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/107472 >From acb5cf2af69f7941c24c4e53b67f9f2d4a18dbc8 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Thu, 5 Sep 2024 15:41:54 -0600 Subject: [PATCH 1/2] [flang][Driver] Support -Xlinker in flang --- clang/incl

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-09 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/104458 >From 11f67c73a8de04ce94dbed467de043668234e202 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 15 Aug 2024 11:27:34 -0400 Subject: [PATCH 1/4] [Clang][Sema] Use the correct lookup context when

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-09 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/104458 >From 11f67c73a8de04ce94dbed467de043668234e202 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 15 Aug 2024 11:27:34 -0400 Subject: [PATCH 1/5] [Clang][Sema] Use the correct lookup context when

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-09 Thread Nathan Gauër via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [analyzer] Improve handling of unsigned values in ArrayBoundCheckerV2 (PR #81034)

2024-09-09 Thread Donát Nagy via cfe-commits
NagyDonat wrote: These reports are definitely FPs caused by buggy number handling, so it would be good to suppress them. I was planning to rewrite both `alpha.security.ReturnPtrRange` and `alpha.unix.cstring.OutOfBounds` to rely on the "backend" prototyped within ArrayBoundV2 instead of the c

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Update: I misread the docs, `typing.re` is what's going to be removed, `typing.Match` is only deprecated but not planned for removal yet. Still think `Any` is the way to go to avoid introducing the deprecated type but either solution is actually fine. https://github.com/llvm/l

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. Bikeshedding: let's delete that empty line. Otherwise LGTM. https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Donát Nagy via cfe-commits
@@ -3,6 +3,9 @@ int clang_analyzer_eval(int); NagyDonat wrote: ```suggestion ``` https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [llvm] [TableGen] Change SetTheory set/vec to use const Record * (PR #107692)

2024-09-09 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/107692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1651014 - [TableGen] Change SetTheory set/vec to use const Record * (#107692)

2024-09-09 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-09T08:47:42-07:00 New Revision: 1651014960b90bd1398f61bec0866d4a187910ef URL: https://github.com/llvm/llvm-project/commit/1651014960b90bd1398f61bec0866d4a187910ef DIFF: https://github.com/llvm/llvm-project/commit/1651014960b90bd1398f61bec0866d4a187910ef.diff L

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/107572 >From 0e8db855a1bde0692260f5aa26c245328a358a50 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 6 Sep 2024 15:15:52 +0300 Subject: [PATCH 1/4] clang/csa: fix crash on bind to symbolic region with void *

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Pavel Skripkin via cfe-commits
@@ -3,6 +3,9 @@ int clang_analyzer_eval(int); pskrgag wrote: fixed, thanks! https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-09 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/107737 >From 2aa7527b52656d064c39aec94c9f1001ed10f7d8 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Fri, 6 Sep 2024 09:52:36 + Subject: [PATCH 1/2] [clang-repl] Simplify the value printing logic to enable

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/107472 >From acb5cf2af69f7941c24c4e53b67f9f2d4a18dbc8 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Thu, 5 Sep 2024 15:41:54 -0600 Subject: [PATCH 1/3] [flang][Driver] Support -Xlinker in flang --- clang/incl

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tom Eccles via cfe-commits
@@ -0,0 +1,8 @@ +! RUN: %flang -### -o /dev/null %s -Xlinker -rpath=/not/a/real/path 2>&1 | FileCheck --check-prefix=SINGLE %s +! RUN: %flang -### -o /dev/null %s -Xlinker -rpath -Xlinker /not/a/real/path 2>&1 | FileCheck --check-prefix=MULTIPLE %s + + +! SINGLE: "-rpath=/not/a/

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b4feb26606de84ff53d9b65a3b79c00a2b4d7c22 9dab439803727470ce07e92a3dc5c46d9bb056b2 --e

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. Thanks for the updates. LGTM https://github.com/llvm/llvm-project/pull/107472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,6 @@ +! RUN: %flang -### -o /dev/null %s -Xlinker -rpath=/not/a/real/path 2>&1 | FileCheck %s + +! CHECK: "-fc1" +! CHECK-NEXT: "-rpath=/not/a/real/path" tarunprabhu wrote: Thanks. I have updated the tests quite extensively. There are now checks for

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > Thanks for the updates. LGTM Thanks for the reviews, Tom :-) https://github.com/llvm/llvm-project/pull/107472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Support -Xlinker in flang (PR #107472)

2024-09-09 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,8 @@ +! RUN: %flang -### -o /dev/null %s -Xlinker -rpath=/not/a/real/path 2>&1 | FileCheck --check-prefix=SINGLE %s +! RUN: %flang -### -o /dev/null %s -Xlinker -rpath -Xlinker /not/a/real/path 2>&1 | FileCheck --check-prefix=MULTIPLE %s + + +! SINGLE: "-rpath=/not/a/

[clang] eba6160 - [flang][Driver] Support --no-warnings option (#107455)

2024-09-09 Thread via cfe-commits
Author: Tarun Prabhu Date: 2024-09-09T09:57:49-06:00 New Revision: eba6160deec5a32e4b31c2a446172d0e388195c9 URL: https://github.com/llvm/llvm-project/commit/eba6160deec5a32e4b31c2a446172d0e388195c9 DIFF: https://github.com/llvm/llvm-project/commit/eba6160deec5a32e4b31c2a446172d0e388195c9.diff

[clang] [flang] [flang][Driver] Support --no-warnings option (PR #107455)

2024-09-09 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu closed https://github.com/llvm/llvm-project/pull/107455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-09 Thread Tarun Prabhu via cfe-commits
@@ -1980,9 +1980,11 @@ within a command line are combined with spaces; spaces and backslashes within an argument are escaped with backslashes. This format differs from the format of the equivalent section produced by GCC with the -frecord-gcc-switches flag. This option is curr

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-09 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/102975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-09 Thread Kiran Chandramohan via cfe-commits
@@ -1980,9 +1980,11 @@ within a command line are combined with spaces; spaces and backslashes within an argument are escaped with backslashes. This format differs from the format of the equivalent section produced by GCC with the -frecord-gcc-switches flag. This option is curr

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-09 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-09 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3cdb30e - [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (#104458)

2024-09-09 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-09-09T12:06:45-04:00 New Revision: 3cdb30ebbc18fa894d3bd67aebcff76ce7c741ac URL: https://github.com/llvm/llvm-project/commit/3cdb30ebbc18fa894d3bd67aebcff76ce7c741ac DIFF: https://github.com/llvm/llvm-project/commit/3cdb30ebbc18fa894d3bd67aebcff76ce7c741ac

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-09 Thread via cfe-commits
cor3ntin wrote: /cherry-pick 3cdb30e https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-09 Thread via cfe-commits
https://github.com/cor3ntin milestoned https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread via cfe-commits
yronglin wrote: I've found the root cause. It's because Exprs in `MaybeODRUseExprs` was losed after enter `RebuildDefaultInit` in `InitListChecker::FillInEmptyInitForField`. https://github.com/llvm/llvm-project/pull/97308 ___ cfe-commits mailing list

[clang] db6051d - [analyzer] fix crash on binding to symbolic region with `void *` type (#107572)

2024-09-09 Thread via cfe-commits
Author: Pavel Skripkin Date: 2024-09-09T18:12:38+02:00 New Revision: db6051dae085c35020c1273ae8d38508c9958bc7 URL: https://github.com/llvm/llvm-project/commit/db6051dae085c35020c1273ae8d38508c9958bc7 DIFF: https://github.com/llvm/llvm-project/commit/db6051dae085c35020c1273ae8d38508c9958bc7.diff

[clang] [analyzer] fix crash on binding to symbolic region with `void *` type (PR #107572)

2024-09-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/107572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >