@@ -1437,6 +1437,15 @@ TEST(SignatureHelpTest, Overloads) {
EXPECT_EQ(0, Results.activeParameter);
}
+TEST(SignatureHelpTest, ShowLambdaNameInsteadOfOperatorParens) {
+ auto const Results = signatures(R"cpp(
+auto foo = [](int x, int y){};
+int main() { foo(^); }
--
@@ -9147,7 +9147,8 @@ class Sema final : public SemaBase {
///
/// \returns true if lookup succeeded, false if it failed.
bool LookupQualifiedName(LookupResult &R, DeclContext *LookupCtx,
- bool InUnqualifiedLookup = false);
+
@@ -876,6 +876,11 @@ class Sema;
/// function pointer or reference (C++ [over.call.object]).
FunctionDecl *Function;
+/// LambdaName - When the OverloadCandidate is for a
+/// lambda's operator(), points to the declaration of
+/// the lambda variable.
+
@@ -2390,7 +2390,8 @@ static bool LookupQualifiedNameInUsingDirectives(Sema &S,
LookupResult &R,
}
bool Sema::LookupQualifiedName(LookupResult &R, DeclContext *LookupCtx,
- bool InUnqualifiedLookup) {
+ bool InUnqual
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin
Message-ID:
In-Reply-To:
@@ -764,6 +792,15 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) {
Record.push_back(D->param_size());
for (auto *P : D->parameters())
Record.AddDeclRef(P)
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin
Message-ID:
In-Reply-To:
@@ -1188,6 +1188,11 @@ class ASTReader
/// once recursing loading has been completed.
llvm::SmallVector PendingOdrMergeChecks;
+ /// Lambdas that need to be loaded rig
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee
,Dmitry
Polukhin
Message-ID:
In-Reply-To:
@@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) {
for (unsigned I = 0; I != NumParams; ++I)
Params.push_back(readDeclAs());
FD->setPar
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Kyungwoo Lee
,Dmitry
Polukhin
Message-ID:
In-Reply-To:
@@ -764,6 +792,15 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) {
Record.push_back(D->param_size());
for (auto *P : D->parameters())
Record.AddDeclRef(P
@@ -876,6 +876,11 @@ class Sema;
/// function pointer or reference (C++ [over.call.object]).
FunctionDecl *Function;
+/// LambdaName - When the OverloadCandidate is for a
+/// lambda's operator(), points to the declaration of
+/// the lambda variable.
+
@@ -10204,15 +10205,14 @@ class Sema final : public SemaBase {
/// both @c a1 and @c a2. If @p SuppressUserConversions, then don't
/// allow user-defined conversions via constructors or conversion
/// operators.
- void
- AddMethodCandidate(CXXMethodDecl *Method, DeclAcc
JinjinLi868 wrote:
> > > The vector tests should still be added
> >
> >
> > sorry. if i remove the change of the vector. i have to remove the testcase.
> > because, for the current code convert between vector type of half and
> > bfloat16, it has a bug. And it will be Assert "Invalid cast!""
https://github.com/ChuanqiXu9 approved this pull request.
LGTM. Let's give it a try : )
https://github.com/llvm/llvm-project/pull/99282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chuanqi Xu
Date: 2024-09-09T11:24:50+08:00
New Revision: 74ac96ae1a81c7ecc0e27ff6f45309cff1f2df97
URL:
https://github.com/llvm/llvm-project/commit/74ac96ae1a81c7ecc0e27ff6f45309cff1f2df97
DIFF:
https://github.com/llvm/llvm-project/commit/74ac96ae1a81c7ecc0e27ff6f45309cff1f2df97.diff
LO
https://github.com/JinjinLi868 updated
https://github.com/llvm/llvm-project/pull/89051
>From 6688d7ed8a0ce0c6885b82218e832320da57eef0 Mon Sep 17 00:00:00 2001
From: JinjinLi868
Date: Wed, 4 Sep 2024 16:43:48 +0800
Subject: [PATCH] [clang] Fix half && bfloat16 convert node expr codegen
Data typ
https://github.com/ergawy updated
https://github.com/llvm/llvm-project/pull/104664
>From 9e14adcabd84f1f746e60cb2cc4582f0c852a776 Mon Sep 17 00:00:00 2001
From: ergawy
Date: Sat, 17 Aug 2024 00:20:11 -0500
Subject: [PATCH] [flang][driver] Add pre-processing type to `.i` files
This diff allows
arsenm wrote:
I don't understand this. The code is a strict aliasing violation, so why should
clang work around it?
https://github.com/llvm/llvm-project/pull/107793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/arsenm approved this pull request.
lgtm assuming the const_cast goes away in a subsequent change
https://github.com/llvm/llvm-project/pull/107692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/89051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kareem Ergawy
Date: 2024-09-09T06:36:48+02:00
New Revision: b5ee4639dee0fd74c1215547e35bd9a10cfc5925
URL:
https://github.com/llvm/llvm-project/commit/b5ee4639dee0fd74c1215547e35bd9a10cfc5925
DIFF:
https://github.com/llvm/llvm-project/commit/b5ee4639dee0fd74c1215547e35bd9a10cfc5925.diff
https://github.com/ergawy closed
https://github.com/llvm/llvm-project/pull/104664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
> lgtm assuming the const_cast goes away in a subsequent change
Thanks. Yeah as I said above, I think we can make the Record* in DefInit const
and then get rid of the const_cast<>. But the mutable for CorrespondingDefInit
will stay, with it serving as a cache.
https://github.c
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/99282
>From c47f9218c5672f6cb38492b692114da2976b Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 4 Jun 2024 23:22:00 -0700
Subject: [PATCH] [Clang] C++20 Coroutines: Introduce Frontend Attribute
[[cla
@@ -206,19 +206,28 @@ namespace cwg1814 { // cwg1814: yes
#endif
}
-namespace cwg1815 { // cwg1815: no
+namespace cwg1815 { // cwg1815: 19
h-vetinari wrote:
This should be `// cwg1815: 20` I think?
https://github.com/llvm/llvm-project/pull/97308
jediry wrote:
@owenca I've opened an issue
[here](https://github.com/llvm/llvm-project/issues/107808)
https://github.com/llvm/llvm-project/pull/107312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?Herv=C3=A9?= Poussineau ,
=?utf-8?q?H
@@ -206,19 +206,28 @@ namespace cwg1814 { // cwg1814: yes
#endif
}
-namespace cwg1815 { // cwg1815: no
+namespace cwg1815 { // cwg1815: 19
Endilll wrote:
Seems to be the case, yeah.
>From what I see, this effort was started back before 19 has branched, and wa
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/107737
>From 2aa7527b52656d064c39aec94c9f1001ed10f7d8 Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Fri, 6 Sep 2024 09:52:36 +
Subject: [PATCH] [clang-repl] Simplify the value printing logic to enable
ou
Author: Yuxuan Chen
Date: 2024-09-08T23:08:58-07:00
New Revision: e17a39bc314f97231e440c9e68d9f46a9c07af6d
URL:
https://github.com/llvm/llvm-project/commit/e17a39bc314f97231e440c9e68d9f46a9c07af6d
DIFF:
https://github.com/llvm/llvm-project/commit/e17a39bc314f97231e440c9e68d9f46a9c07af6d.diff
L
https://github.com/yuxuanchen1997 closed
https://github.com/llvm/llvm-project/pull/99282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 edited
https://github.com/llvm/llvm-project/pull/99283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 closed
https://github.com/llvm/llvm-project/pull/99283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 edited
https://github.com/llvm/llvm-project/pull/99285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yuxuanchen1997 closed
https://github.com/llvm/llvm-project/pull/99285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/107292
>From a88a4eda4ce2ad32ee2ec02549b25c9f08aa14e9 Mon Sep 17 00:00:00 2001
From: Joao Saffran
Date: Tue, 3 Sep 2024 19:06:22 +
Subject: [PATCH 1/3] Adding `asuint` implementation to hlsl
---
clang/includ
@@ -387,6 +387,23 @@ float3 asin(float3);
_HLSL_BUILTIN_ALIAS(__builtin_elementwise_asin)
float4 asin(float4);
+//===--===//
+// asuint builtins
+//===--
https://github.com/kito-cheng approved this pull request.
LGTM, and I would prefer wait one more LGTM from Craig or Philip *OR* wait one
more week to make sure no further comment :)
https://github.com/llvm/llvm-project/pull/85786
___
cfe-commits maili
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/107561
>From 92a30ff72fd922df3c29ac31fc2c7d46df1ff84e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 6 Sep 2024 18:35:45 +0800
Subject: [PATCH 1/3] [Clang] Don't assert non-empty packs for
FunctionParmPackExpr
huhu233 wrote:
> I don't understand this. The code is a strict aliasing violation, so why
> should clang work around it?
Hi, @arsenm, the violation is due to the compiler emitting different TBAA for
`svst1` (long) and other users of `res2` (long long). TBAA is invisible to ACLE
users, and the
MaxEW707 wrote:
> I don't have a very strong opinion. I find it surprising in that the clang
> driver is supposed to be gcc-compatible, and having to use `clang
> -fstrict-aliasing` (but only when targeting Windows) to get the default
> behavior looks a bit surprising.
>
> (I agree it's a bet
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/107292
>From a88a4eda4ce2ad32ee2ec02549b25c9f08aa14e9 Mon Sep 17 00:00:00 2001
From: Joao Saffran
Date: Tue, 3 Sep 2024 19:06:22 +
Subject: [PATCH 1/3] Adding `asuint` implementation to hlsl
---
clang/includ
pskrgag wrote:
CC @steakhal @NagyDonat
https://github.com/llvm/llvm-project/pull/107572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zmodem approved this pull request.
https://github.com/llvm/llvm-project/pull/107509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 requested changes to this pull request.
Apologies for the slow response time. I finally had a chance to look at this in
a bit more detail, though I still don't think I fully understand this patch.
At this point, my main feedback is that it would be good to incl
@@ -1069,6 +1071,27 @@ void SymbolCollector::addDefinition(const NamedDecl &ND,
Symbol S = DeclSym;
// FIXME: use the result to filter out symbols.
S.Definition = *DefLoc;
+
+ std::string DocComment;
+ std::string Documentation;
+ if (!(S.Flags & Symbol::HasDocComment)
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/67802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 145 of 145 matches
Mail list logo
