[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-06 Thread via cfe-commits
https://github.com/higher-performance created https://github.com/llvm/llvm-project/pull/107627 This partially fixes #62072 by making sure that re-declarations of a function do not have the effect of removing lifetimebound from the canonical declaration. It doesn't handle the implicit 'this' pa

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-06 Thread via cfe-commits
higher-performance wrote: @ilya-biryukov https://github.com/llvm/llvm-project/pull/107627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (higher-performance) Changes This partially fixes #62072 by making sure that re-declarations of a function do not have the effect of removing lifetimebound from the canonical declaration. It doesn't handle the implicit 'this' parame

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
https://github.com/s-perron edited https://github.com/llvm/llvm-project/pull/107408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
https://github.com/s-perron approved this pull request. This looks good. No major issue. There are a few typos, and a couple smaller issues that we can follow up on in another PR. https://github.com/llvm/llvm-project/pull/107408 ___ cfe-commits mailin

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -744,79 +744,139 @@ static void insertSpirvDecorations(MachineFunction &MF, MachineIRBuilder MIB) { MI->eraseFromParent(); } -// Find basic blocks of the switch and replace registers in spv_switch() by its -// MBB equivalent. -static void processSwitches(MachineFunctio

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -744,79 +744,139 @@ static void insertSpirvDecorations(MachineFunction &MF, MachineIRBuilder MIB) { MI->eraseFromParent(); } -// Find basic blocks of the switch and replace registers in spv_switch() by its -// MBB equivalent. -static void processSwitches(MachineFunctio

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [llvm] [SPIR-V] Add SPIR-V structurizer (PR #107408)

2024-09-06 Thread Steven Perron via cfe-commits
@@ -0,0 +1,1410 @@ +//===-- SPIRVStructurizer.cpp --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] 4c1a6a2 - [flang][Driver] Support -Qunused-arguments (#107462)

2024-09-06 Thread via cfe-commits
Author: Tarun Prabhu Date: 2024-09-06T12:33:51-06:00 New Revision: 4c1a6a29cce08cd6229a0c5a8b18a8319588d858 URL: https://github.com/llvm/llvm-project/commit/4c1a6a29cce08cd6229a0c5a8b18a8319588d858 DIFF: https://github.com/llvm/llvm-project/commit/4c1a6a29cce08cd6229a0c5a8b18a8319588d858.diff

[clang] [flang] [flang][Driver] Support -Qunused-arguments (PR #107462)

2024-09-06 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu closed https://github.com/llvm/llvm-project/pull/107462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0745219 - [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (#107293)

2024-09-06 Thread via cfe-commits
Author: Stanislav Mekhanoshin Date: 2024-09-06T11:41:21-07:00 New Revision: 0745219d4a8fc26fe149d851be285f78568afa70 URL: https://github.com/llvm/llvm-project/commit/0745219d4a8fc26fe149d851be285f78568afa70 DIFF: https://github.com/llvm/llvm-project/commit/0745219d4a8fc26fe149d851be285f78568afa

[clang] [llvm] [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (PR #107293)

2024-09-06 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/107293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ farzonl wrote: nevermind, this isn't something the team is conserned about. https://github.com/llvm/llvm-project/pull/107129 ___ cfe-commi

[clang] [llvm] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-09-06 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/104856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-09-06 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. I've a few questions here, but otherwise LGTMy non-expert eyes. Would be good to get a review from @bogner before completing. https://github.com/llvm/llvm-project/pull/104856 ___ cfe-commits mail

[clang] [llvm] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-09-06 Thread Damyan Pepper via cfe-commits
@@ -879,6 +879,10 @@ static TargetTypeInfo getTargetTypeInfo(const TargetExtType *Ty) { ScalableVectorType::get(Type::getInt8Ty(C), TotalNumElts)); } + // DirectX intangible types + if (Name.starts_with("dx.")) +return TargetTypeInfo(PointerType::get(C, 0), Ta

[clang] [llvm] [DirectX] Add DirectXTargetCodeGenInfo (PR #104856)

2024-09-06 Thread Damyan Pepper via cfe-commits
@@ -879,6 +879,10 @@ static TargetTypeInfo getTargetTypeInfo(const TargetExtType *Ty) { ScalableVectorType::get(Type::getInt8Ty(C), TotalNumElts)); } + // DirectX intangible types + if (Name.starts_with("dx.")) damyanp wrote: I'm surprised that w

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/3] Don't emit int TBAA metadata on more complex FP math

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Farzon Lotfi via cfe-commits
@@ -1512,6 +1512,83 @@ void SetElementTypeAsReturnType(Sema *S, CallExpr *TheCall, TheCall->setType(ReturnType); } +static bool CheckScalarOrVector(Sema *S, CallExpr *TheCall, QualType Scalar, + unsigned ArgIndex) { + assert(TheCall->getNumArg

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/107129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-06 Thread Doug Wyatt via cfe-commits
dougsonos wrote: > Hi @dougsonos > > We’re experiencing an unforeseen pain point trying to use rtsan without > function effects, and wanted to ask **how you would feel about making > function effect warnings opt-in rather than opt-out.** > > While users can easily opt in to function effects a

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
https://github.com/bogner commented: This is going in the right direction but the tests need some work. I made a couple of comments to point you in the right direction. We also need to make sure we're testing all of the cases we care about, so we need tests with inputs of `int`, `uint`, vector

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s bogner wrote: It's probably better if we remove the `-disable-llvm-passes` and

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -387,6 +387,23 @@ float3 asin(float3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_asin) float4 asin(float4); +//===--===// +// asuint builtins +//===--

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s + + +// CHECK-LABEL: test_asuint4_uint +// CHECK: ret i32 %0 +export uint test_asuint4_uint(uint

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s + + +// CHECK-LABEL: test_asuint4_uint +// CHECK: ret i32 %0 +export uint test_asuint4_uint(uint

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s + + +// CHECK-LABEL: test_asuint4_uint +// CHECK: ret i32 %0 +export uint test_asuint4_uint(uint

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,34 @@ +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-none-eabihf -mcpu=cortex-r5 -mfpu=vfpv3-d16 -marm -S -o - %s \ +// RUN: | FileCheck %s --check-prefix=CHECK-R +// RUN: %clang -target arm-none-none-eabihf -mcpu=cortex-r5 -mfpu=vfpv3-d16 -mthum

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Eli Friedman via cfe-commits
@@ -338,10 +338,16 @@ def warn_anyx86_excessive_regsave : Warning< InGroup>; def warn_arm_interrupt_vfp_clobber : Warning< "interrupt service routine with vfp enabled may clobber the " - "interruptee's vfp state">, + "interruptee's vfp state; " + "consider using the `int

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-09-06 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Isn't this a bug in the mangler? I mean, it's better to print an error rather than silently miscompile, but this doesn't really solve the issue. https://github.com/llvm/llvm-project/pull/107581 ___ cfe-commits mailing list cfe-com

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-09-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang,llvm` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/877 Here is the relevant piece of the build l

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread Saleem Abdulrasool via cfe-commits
@@ -1699,11 +1699,18 @@ class CGObjCGNUstep2 : public CGObjCGNUstep { llvm::Value *EmitIvarOffset(CodeGenFunction &CGF, const ObjCInterfaceDecl *Interface, const ObjCIvarDecl *Ivar) override { -const std::string

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza ready_for_review https://github.com/llvm/llvm-project/pull/107285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-09-06 Thread Reid Kleckner via cfe-commits
@@ -215,6 +215,14 @@ struct NewUnspecified; SingleTemplate tmpl_single; UnspecTemplate tmpl_unspec; +// Member pointers used in base specifiers force an unspecified inheritance model +struct MemPtrInBase : UnspecTemplate {}; rnk wrote: Yes, but it's not clea

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-09-06 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: Sorry, looks like I wrote pending comments and didn't publish them https://github.com/llvm/llvm-project/pull/91990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-09-06 Thread Reid Kleckner via cfe-commits
@@ -13,3 +15,18 @@ template struct S3 { int T::*foo; }; + +template struct Base {}; +struct +S5 // #S5 +: +Base +// expected-error@-1 {{member pointer has incomplete base type 'S5'}} rnk wrote: I agree on the desired behavior, but doesn't this test show tha

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-09-06 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/91990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-06 Thread Yeoul Na via cfe-commits
rapidsna wrote: Will fix several test failures. https://github.com/llvm/llvm-project/pull/107619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s --check-prefixes=CHECK + +// CHECK: %hlsl.select = select i1 +// CHECK: ret i32 %hlsl.selec

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s --check-prefixes=CHECK + +// CHECK: %hlsl.select = select i1 +// CHECK: ret i32 %hlsl.selec

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,41 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s --check-prefixes=CHECK + +// CHECK: %hlsl.select = select i1 +// CHECK: ret i32 %hlsl.selec

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -1603,6 +1603,32 @@ double3 saturate(double3); _HLSL_BUILTIN_ALIAS(__builtin_hlsl_elementwise_saturate) double4 saturate(double4); +//===--===// +// select builtins +//===---

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-06 Thread Chris Apple via cfe-commits
cjappl wrote: > My sense is that it would be weird for -Wall not to include > -Wfunction-effects, but that it would be OK for -Wfunction-effects not to be > enabled by default. I do agree, it seems reasonable for it to be in `-Wall` or similar! That is absolutely what I'd expect as a user :)

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Benson Chu via cfe-commits
https://github.com/pestctrl updated https://github.com/llvm/llvm-project/pull/89654 >From b7117c5940b018f33f99b449cecbd928a36665af Mon Sep 17 00:00:00 2001 From: Jake Vossen Date: Wed, 30 Jun 2021 15:13:13 -0500 Subject: [PATCH 1/3] [ARM] Save floating point registers with save_fp function att

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Benson Chu via cfe-commits
@@ -338,10 +338,16 @@ def warn_anyx86_excessive_regsave : Warning< InGroup>; def warn_arm_interrupt_vfp_clobber : Warning< "interrupt service routine with vfp enabled may clobber the " - "interruptee's vfp state">, + "interruptee's vfp state; " + "consider using the `int

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/107292 >From a88a4eda4ce2ad32ee2ec02549b25c9f08aa14e9 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Tue, 3 Sep 2024 19:06:22 + Subject: [PATCH 1/3] Adding `asuint` implementation to hlsl --- clang/includ

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-09-06 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/106495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeView] Flatten cmd args in frontend for LF_BUILDINFO (PR #106369)

2024-09-06 Thread via cfe-commits
https://github.com/nebulark updated https://github.com/llvm/llvm-project/pull/106369 >From e190d074a0a77c9f8a7d7938a8187a7e2076e290 Mon Sep 17 00:00:00 2001 From: Florian Schmiderer Date: Wed, 28 Aug 2024 12:36:39 +0200 Subject: [PATCH 1/2] [Codeview] Moved flattening of commandline arguments i

[clang] de88d7d - [-Wunsafe-buffer-usage] Fix a bug in "warning libc functions (#101583)"

2024-09-06 Thread via cfe-commits
Author: ziqingluo-90 Date: 2024-09-06T12:57:47-07:00 New Revision: de88d7db7b77141297fbb5638ee1e18d1fba53b8 URL: https://github.com/llvm/llvm-project/commit/de88d7db7b77141297fbb5638ee1e18d1fba53b8 DIFF: https://github.com/llvm/llvm-project/commit/de88d7db7b77141297fbb5638ee1e18d1fba53b8.diff

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-09-06 Thread Mital Ashok via cfe-commits
@@ -13,3 +15,18 @@ template struct S3 { int T::*foo; }; + +template struct Base {}; +struct +S5 // #S5 +: +Base +// expected-error@-1 {{member pointer has incomplete base type 'S5'}} MitalAshok wrote: Yes, that's just how `-fcomplete-member-pointers` works

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-09-06 Thread Mital Ashok via cfe-commits
@@ -215,6 +215,14 @@ struct NewUnspecified; SingleTemplate tmpl_single; UnspecTemplate tmpl_unspec; +// Member pointers used in base specifiers force an unspecified inheritance model +struct MemPtrInBase : UnspecTemplate {}; MitalAshok wrote: I see what you

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-06 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: > > We're seeing a crash with this patch when compiling with -Weverything. > > ``` > > clang: ../../clang/include/clang/AST/Expr.h:3026: const clang::Expr > > *clang::CallExpr::getArg(unsigned int) const: Assertion `Arg < getNumArgs() > > && "Arg access out of range!"' faile

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-06 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: > Btw a question about the new warning: So with > -Wunsafe-buffer-usage-in-libc-call clang now warns on the following? > > ``` > #include > > void foo(void) { > char q[10]; > snprintf(q, 10, "%s", "hello"); > } > ``` > > It says > > ``` > foo.c:5:3: warning: function

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread Frederik Carlier via cfe-commits
https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/107604 >From 64073399d392b187297a6aeb1c6634c271103330 Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Fri, 6 Sep 2024 11:54:59 + Subject: [PATCH] Set dllimport on Objective C ivar offsets This commit ensu

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-06 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/107627 >From 4c0561d79eedc7060597aa33bfb6e41a64df340c Mon Sep 17 00:00:00 2001 From: higher-performance Date: Fri, 6 Sep 2024 14:16:15 -0400 Subject: [PATCH] Propagate lifetimebound from formal parameters to

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c014db47ca298ad7a0f52a57c3bfc2a9914371b2 4c0561d79eedc7060597aa33bfb6e41a64df340c --e

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-09-06 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/107627 >From edadbdc5844b1d99ce624e3c64dc3d519e2a1e51 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Fri, 6 Sep 2024 14:16:15 -0400 Subject: [PATCH] Propagate lifetimebound from formal parameters to

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread Frederik Carlier via cfe-commits
@@ -1699,11 +1699,18 @@ class CGObjCGNUstep2 : public CGObjCGNUstep { llvm::Value *EmitIvarOffset(CodeGenFunction &CGF, const ObjCInterfaceDecl *Interface, const ObjCIvarDecl *Ivar) override { -const std::string

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Bill Wendling via cfe-commits
@@ -2943,6 +2943,9 @@ class Parser : public CodeCompletionHandler { return false; } + bool ParseGNUSingleAttribute(ParsedAttributes &Attrs, SourceLocation &EndLoc, bwendling wrote: > Ah, I see. The WG14 specified one is __builtin_has_c_attribute, corre

[clang] [clang-tools-extra] [llvm] [clang-format] Add support for BasedOnStyle referencing an arbitrary file (PR #107312)

2024-09-06 Thread Ryan Saunders via cfe-commits
@@ -5274,9 +5274,17 @@ struct FormatStyle { friend std::error_code parseConfiguration(llvm::MemoryBufferRef Config, FormatStyle *Style, + const std::vector &StyleSearchPaths, jediry wrote: Yes, I can certainly do that if that is prefer

[clang] [clang-tools-extra] [llvm] [clang-format] Add support for BasedOnStyle referencing an arbitrary file (PR #107312)

2024-09-06 Thread Ryan Saunders via cfe-commits
@@ -39,6 +39,10 @@ IO::IO(void *Context) : Ctxt(Context) {} IO::~IO() = default; +SourceMgr& IO::getSourceMgr() { jediry wrote: Sure, I can break this up. https://github.com/llvm/llvm-project/pull/107312 ___ cfe-c

[clang] [clang-tools-extra] [clang] Hide the `TargetOptions` pointer from `CompilerInvocation` (PR #106271)

2024-09-06 Thread Jan Svoboda via cfe-commits
@@ -216,7 +216,7 @@ enum OpenCLTypeKind : uint8_t { /// class TargetInfo : public TransferrableTargetInfo, public RefCountedBase { - std::shared_ptr TargetOpts; + TargetOptions *TargetOpts; jansvoboda11 wrote: Upstream breaks internal APIs

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Erich Keane via cfe-commits
@@ -2943,6 +2943,9 @@ class Parser : public CodeCompletionHandler { return false; } + bool ParseGNUSingleAttribute(ParsedAttributes &Attrs, SourceLocation &EndLoc, erichkeane wrote: >I'm not sure how? It would change the purpose of this patch. If yo

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. OK with this for now, once the parse function name changes. https://github.com/llvm/llvm-project/pull/107300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-09-06 Thread Benson Chu via cfe-commits
@@ -0,0 +1,34 @@ +// REQUIRES: arm-registered-target +// RUN: %clang -target arm-none-none-eabihf -mcpu=cortex-r5 -mfpu=vfpv3-d16 -marm -S -o - %s \ +// RUN: | FileCheck %s --check-prefix=CHECK-R +// RUN: %clang -target arm-none-none-eabihf -mcpu=cortex-r5 -mfpu=vfpv3-d16 -mthum

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/107300 >From c30c6c11686cc95ba20eb7000d210b17757fbfe3 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Sep 2024 12:49:04 -0700 Subject: [PATCH 1/3] [Parser][NFC] Move the core parsing of an attribute into a

[clang] 7815abe - [Parser][NFC] Move the core parsing of an attribute into a separate method (#107300)

2024-09-06 Thread via cfe-commits
Author: Bill Wendling Date: 2024-09-06T21:08:33Z New Revision: 7815abec165114da29e191022c2816f857b1984f URL: https://github.com/llvm/llvm-project/commit/7815abec165114da29e191022c2816f857b1984f DIFF: https://github.com/llvm/llvm-project/commit/7815abec165114da29e191022c2816f857b1984f.diff LOG:

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/107300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang-format] Add support for BasedOnStyle referencing an arbitrary file (PR #107312)

2024-09-06 Thread Ryan Saunders via cfe-commits
jediry wrote: > I am not sure if it's best to push a new command line flag to all other tools > that use clang-format as a library. > > Have you considered any other alternatives that can self-contain this in > clang-format? e.g can we just treat paths as relative to current > `.clang-format`

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: One question I have about this is do we actually need new builtins? These are just doing bit casts correct? Could we implement them entirely in the header? Something like: ```hlsl template T bit_cast(U Val) { return __builtin_bit_cast(T, Val); } uint

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-09-06 Thread Jan Svoboda via cfe-commits
@@ -1125,6 +1125,54 @@ class YAMLVFSWriter { void write(llvm::raw_ostream &OS); }; +/// File system that tracks the number of calls to the underlying file system. +/// This is particularly useful when wrapped around \c RealFileSystem to add +/// lightweight tracking of expen

[clang] 70fcdb3 - [llvm][support] Implement tracing virtual file system (#88326)

2024-09-06 Thread via cfe-commits
Author: Jan Svoboda Date: 2024-09-06T14:14:44-07:00 New Revision: 70fcdb3d52272eba96d4b268d334826690524f50 URL: https://github.com/llvm/llvm-project/commit/70fcdb3d52272eba96d4b268d334826690524f50 DIFF: https://github.com/llvm/llvm-project/commit/70fcdb3d52272eba96d4b268d334826690524f50.diff L

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-09-06 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/88326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-06 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna updated https://github.com/llvm/llvm-project/pull/107619 >From 1a0e2dede95bd69ab6badc9aafbd60d5eaf5d407 Mon Sep 17 00:00:00 2001 From: Yeoul Na Date: Thu, 5 Sep 2024 09:52:41 -0700 Subject: [PATCH] [Parser][BoundsSafety] Print attribute as macro if it's system defin

[clang-tools-extra] [NFC][clang-tidy] document fix to bugprone-return-const-ref-from-parameter (PR #107641)

2024-09-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/107641 Describe how the issue that is diagnosed by this check can be resolved. Namely, by adding an overload for the xvalue case (`&&` parameter). Fixes #107600 >From 714b66e135efc70aa9b5e9fce3dfe7475a4e0c6c Mon Sep

[clang-tools-extra] [NFC][clang-tidy] document fix to bugprone-return-const-ref-from-parameter (PR #107641)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Julian Schmidt (5chmidti) Changes Describe how the issue that is diagnosed by this check can be resolved. Namely, by adding an overload for the xvalue case (`&&` parameter). Fixes #107600 --- Full diff: https://github.com/llvm/llvm-

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread via cfe-commits
@@ -387,6 +387,23 @@ float3 asin(float3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_asin) float4 asin(float4); +//===--===// +// asuint builtins +//===--

[clang] [lld] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-06 Thread Rahman Lavaee via cfe-commits
https://github.com/rlavaee updated https://github.com/llvm/llvm-project/pull/107494 >From 1e4f893052f763908897aa9236bc0400bb03823b Mon Sep 17 00:00:00 2001 From: Rahman Lavaee Date: Thu, 5 Sep 2024 19:14:11 + Subject: [PATCH] Deprecate the `-fbasic-block-sections=labels` option. This featu

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-09-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `clang,llvm` at step 8 "test-build-unified-tree-check-clang-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/6155 H

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/107292 >From a88a4eda4ce2ad32ee2ec02549b25c9f08aa14e9 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Tue, 3 Sep 2024 19:06:22 + Subject: [PATCH 1/3] Adding `asuint` implementation to hlsl --- clang/includ

[clang] [llvm] [llvm][support] Implement tracing virtual file system (PR #88326)

2024-09-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/64

[clang] 92cd66d - [clang][deps][test] Update reference to tracing VFS

2024-09-06 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2024-09-06T14:29:44-07:00 New Revision: 92cd66d905aa63fe4d77bb632812dff87e0e1c08 URL: https://github.com/llvm/llvm-project/commit/92cd66d905aa63fe4d77bb632812dff87e0e1c08 DIFF: https://github.com/llvm/llvm-project/commit/92cd66d905aa63fe4d77bb632812dff87e0e1c08.diff L

<    1   2   3   4   5   6   >