[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/97308 >From e6ee9bef17ca8c597f816661f5bdf16eb5a6a982 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:55:40 +0800 Subject: [PATCH 1/8] Reapply "[Clang][CWG1815] Support lifetime extension of temporary

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
@@ -6298,6 +6298,15 @@ class Sema final : public SemaBase { using ImmediateInvocationCandidate = llvm::PointerIntPair; + enum class LifetimeExtendingContext { +None, // Not in a lifetime extending context. +FlagOnly, // A flag indicating whether we are in l

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
yronglin wrote: Good catch! I've added more test from std examples. https://github.com/llvm/llvm-project/pull/97308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang][TableGen] Migrate clang-tblgen to use const RecordKeeper (PR #107533)

2024-09-06 Thread Rahul Joshi via cfe-commits
jurahul wrote: This is a refactor for better const correctness in TableGen backends. Please see the discourse thread here: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefinitions-api-potential-downstream-breakages/81089 https://github.com/llvm/llvm-project/pull/10

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang][TableGen] Migrate clang-tblgen to use const RecordKeeper (PR #107533)

2024-09-06 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/107533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Migrate clang-tblgen to use const RecordKeeper (PR #107533)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Rahul Joshi (jurahul) Changes Migrate clang tablegen backends to use const RecordKeeper. --- Patch is 135.31 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/107533.diff 22 Files Affec

[clang] [clang][TableGen] Migrate clang-tblgen to use const RecordKeeper (PR #107533)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Migrate clang tablegen backends to use const RecordKeeper. --- Patch is 135.31 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/107533.diff 22 Files Affected: - (

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/97308 >From e6ee9bef17ca8c597f816661f5bdf16eb5a6a982 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:55:40 +0800 Subject: [PATCH 1/9] Reapply "[Clang][CWG1815] Support lifetime extension of temporary

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Paul T Robinson via cfe-commits
@@ -1,42 +1,64 @@ -// Check that PS4 clang doesn't report a warning message when locating -// system header files (either by looking at the value of SCE_ORBIS_SDK_DIR -// or relative to the location of the compiler driver), if "-nostdinc", -// "--sysroot" or "-isysroot" option is

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/107410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Paul T Robinson via cfe-commits
@@ -323,46 +323,63 @@ toolchains::PS4PS5Base::PS4PS5Base(const Driver &D, const llvm::Triple &Triple, const ArgList &Args, StringRef Platform, const char *EnvVar) : Generic_ELF(D, Triple, Args) { - // D

[clang] [PS4, PS5][Driver] Detangle --sysroot and -isysroot (PR #107410)

2024-09-06 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 approved this pull request. LGTM, but pointed out the need for a test comment update (& replicate to the PS5 equivalent test). https://github.com/llvm/llvm-project/pull/107410 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/97308 >From e6ee9bef17ca8c597f816661f5bdf16eb5a6a982 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:55:40 +0800 Subject: [PATCH 01/10] Reapply "[Clang][CWG1815] Support lifetime extension of tempora

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread Frederik Carlier via cfe-commits
https://github.com/qmfrederik created https://github.com/llvm/llvm-project/pull/107604 Ensures that offsets for instance variables are marked with `dllimport` if the interface to which they belong has this attribute. >From 83511b91e37a9191fcde289b1f302c79e8533b6f Mon Sep 17 00:00:00 2001 From:

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Frederik Carlier (qmfrederik) Changes Ensures that offsets for instance variables are marked with `dllimport` if the interface to which they belong has this attribute. --- Full diff: https://github.com/llvm/llvm-project/pull/107604.diff

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
@@ -5578,19 +5579,35 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation Loc, FieldDecl *Field) { ImmediateCallVisitor V(getASTContext()); if (!NestedDefaultChecking) V.TraverseDecl(Field); - if (V.HasImmediateCalls) { + + // CWG1815 + // Support lifetime ext

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
yronglin wrote: > I think I need a second run through Thanks for the review! https://github.com/llvm/llvm-project/pull/97308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread Frederik Carlier via cfe-commits
qmfrederik wrote: @davidchisnall Would you mind reviewing this PR? This came up when trying to build gnustep-gui using the Windows-native version of LLVM/clang (i.e., not in MSYS). The problem is that all the ivar references are missing the `dllimport` annotation. This is not a problem on M

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 62fec3d23d2325869e6eba0263b0b9f834c2067f 83511b91e37a9191fcde289b1f302c79e8533b6f --e

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/97308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,26 @@ +//===-- Implementation of ctime function --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-06 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/97308 >From e6ee9bef17ca8c597f816661f5bdf16eb5a6a982 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 7 Aug 2024 22:55:40 +0800 Subject: [PATCH 01/11] Reapply "[Clang][CWG1815] Support lifetime extension of tempora

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,26 @@ +//===-- Implementation of ctime function --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -156,6 +156,13 @@ LIBC_INLINE struct tm *gmtime_internal(const time_t *timer, struct tm *result) { return result; } +// TODO: localtime is not yet implemented and a temporary solution is to +// use gmtime, https://github.com/llvm/llvm-project/issues/107597 +LIBC_IN

[clang] Set dllimport on Objective C ivar offsets (PR #107604)

2024-09-06 Thread Frederik Carlier via cfe-commits
https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/107604 >From 2b42d2048e27d30ad77a6793ae36a9b2204b4435 Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Fri, 6 Sep 2024 11:54:59 + Subject: [PATCH] Set dllimport on Objective C ivar offsets This commit ensu

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,25 @@ +//===-- Implementation of ctime_r function ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,25 @@ +//===-- Implementation of ctime_r function ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-09-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: > > The vector tests should still be added > > sorry. if i remove the change of the vector. i have to remove the testcase. > because, for the current code convert between vector type of half and > bfloat16, it has a bug. And it will be Assert "Invalid cast!"" > OK, LGTM with th

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
@@ -0,0 +1,21 @@ +//===-- Implementation header of ctime_r *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [lld] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

2024-09-06 Thread Rahman Lavaee via cfe-commits
https://github.com/rlavaee updated https://github.com/llvm/llvm-project/pull/107494 >From dd73efa8e99982c1ab015156c32bdc71f679361c Mon Sep 17 00:00:00 2001 From: Rahman Lavaee Date: Thu, 5 Sep 2024 19:14:11 + Subject: [PATCH] Deprecate the `-fbasic-block-sections=labels` option. This featu

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-06 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/106786 >From 92e82b249836b4f17d1e13a927ca3e8300f671ee Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 30 Aug 2024 13:57:13 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Simplify handling of implicit DSA/map

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-06 Thread Krzysztof Parzyszek via cfe-commits
@@ -6060,69 +6057,55 @@ StmtResult SemaOpenMP::ActOnOpenMPExecutableDirective( return StmtError(); // Generate list of implicitly defined firstprivate variables. VarsWithInheritedDSA = DSAChecker.getVarsWithInheritedDSA(); +VariableImplicitInfo ImpInfo = DSACh

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-09-06 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: To better understand the motivation, I have two questions: * Why do you give Clang module maps describing modules that are already described in PCM files? Unless the module map describes some other top-level module that's yet to be built, the information it provides is redun

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-06 Thread Chris Apple via cfe-commits
cjappl wrote: Hi @dougsonos We’re experiencing an unforeseen pain point trying to use rtsan without function effects, and wanted to ask **how you would feel about making function effect warnings opt-in rather than opt-out.** While users can easily opt in to function effects and not rtsan, t

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-06 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/106786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-06 Thread Sean Perry via cfe-commits
https://github.com/perry-ca created https://github.com/llvm/llvm-project/pull/107613 An example of this is the -mpure-code option. Without a config file being used, an error message will print `-mpure-code`. But if a config file is used, the error message will print `-mexecute-only`. >From

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Sean Perry (perry-ca) Changes An example of this is the -mpure-code option. Without a config file being used, an error message will print `-mpure-code`. But if a config file is used, the error message will print `-mexecute-only`.

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sean Perry (perry-ca) Changes An example of this is the -mpure-code option. Without a config file being used, an error message will print `-mpure-code`. But if a config file is used, the error message will print `-mexecute-only`. ---

[clang] a291fe5 - clang/AMDGPU: Update test message order

2024-09-06 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2024-09-06T21:18:41+04:00 New Revision: a291fe5ed44fa37493d038c78ff4d73135fd85a9 URL: https://github.com/llvm/llvm-project/commit/a291fe5ed44fa37493d038c78ff4d73135fd85a9 DIFF: https://github.com/llvm/llvm-project/commit/a291fe5ed44fa37493d038c78ff4d73135fd85a9.diff

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] adding `asfloat` function to hlsl (PR #107614)

2024-09-06 Thread via cfe-commits
https://github.com/joaosaffran created https://github.com/llvm/llvm-project/pull/107614 None >From eb176f0cef8943ae5ae9d64d71d01649dd30fd93 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 6 Sep 2024 16:27:51 + Subject: [PATCH] adding asfloat function to hlsl --- clang/lib/Headers

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c08f80e348ed84e4372d4a8687dfcaaa2df813aa fb0aff395cafb42efb10b0fbda36d32ede25aad3 --e

[clang] adding `asfloat` function to hlsl (PR #107614)

2024-09-06 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (PR #107293)

2024-09-06 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/107293 >From 8361742ca5fe20a3168b3274166909412e225184 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Wed, 4 Sep 2024 12:00:27 -0700 Subject: [PATCH 1/2] [AMDGPU] Add target intrinsic for s_buffer_prefetch_

[clang] [llvm] [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (PR #107293)

2024-09-06 Thread Stanislav Mekhanoshin via cfe-commits
@@ -0,0 +1,36 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -global-isel=0 -march=amdgcn -mcpu=gfx1200 < %s | FileCheck --check-prefix=GCN %s +; RUN: llc -global-isel=1 -march=amdgcn -mcpu=gfx1200 < %s | FileC

[clang] adding `asfloat` function to hlsl (PR #107614)

2024-09-06 Thread via cfe-commits
https://github.com/joaosaffran closed https://github.com/llvm/llvm-project/pull/107614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-06 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna created https://github.com/llvm/llvm-project/pull/107619 This correctly adds macro identifier for late parsed attrs, which has been missing. 'operator<<' for StreamingDiagnostic and ParsedAttr checks if Attr should be printed as macro and does it. This also fixes t

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yeoul Na (rapidsna) Changes This correctly adds macro identifier for late parsed attrs, which has been missing. 'operator<<' for StreamingDiagnostic and ParsedAttr checks if Attr should be printed as macro and does it. This also fixes th

[clang] [Parser][BoundsSafety] Print attribute as macro if it's system defined (PR #107619)

2024-09-06 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna edited https://github.com/llvm/llvm-project/pull/107619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,69 @@ +//===-- sanitizer/rtsan_interface.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-06 Thread via cfe-commits
@@ -840,8 +840,10 @@ llvm::Function *CGNVCUDARuntime::makeModuleCtorFunction() { FatBinStr = new llvm::GlobalVariable( CGM.getModule(), CGM.Int8Ty, /*isConstant=*/true, llvm::GlobalValue::ExternalLinkage, nullptr, - "__hip_fatbin_" + CGM.getCo

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-06 Thread Sean Perry via cfe-commits
https://github.com/perry-ca updated https://github.com/llvm/llvm-project/pull/107613 >From 27f31954976948e4e0d194db5da6bc550b4c2200 Mon Sep 17 00:00:00 2001 From: Sean Perry Date: Fri, 6 Sep 2024 10:54:07 -0500 Subject: [PATCH 1/2] clone the alias option too --- clang/lib/Driver/Driver.cpp

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,69 @@ +//===-- sanitizer/rtsan_interface.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-06 Thread via cfe-commits
https://github.com/jofrn edited https://github.com/llvm/llvm-project/pull/107458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-06 Thread via cfe-commits
https://github.com/jofrn edited https://github.com/llvm/llvm-project/pull/107458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-06 Thread via cfe-commits
https://github.com/jofrn edited https://github.com/llvm/llvm-project/pull/107458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,35 @@ +// RUN: %clangxx -fsanitize=realtime %s -o %t +// RUN: not %run %t 2>&1 | FileCheck %s +// RUN: %clangxx %s -fsanitize=realtime -o - -S -emit-llvm | FileCheck %s --check-prefix=CHECK-ENABLED-IR +// RUN: %clangxx %s -o - -S -emit-llvm | FileCheck %s --check-pref

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/106736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-06 Thread via cfe-commits
jofrn wrote: Thank you for your comments. Updated the code to use 'RelocatableDeviceCode' in the case of external linkage. https://github.com/llvm/llvm-project/pull/107458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -54,6 +54,8 @@ FEATURE(memtag_globals, FEATURE(xray_instrument, LangOpts.XRayInstrument) FEATURE(undefined_behavior_sanitizer, LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(realtime_sanitizer, vitalybuka wrote: clang/feature should

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Chris Apple via cfe-commits
@@ -54,6 +54,8 @@ FEATURE(memtag_globals, FEATURE(xray_instrument, LangOpts.XRayInstrument) FEATURE(undefined_behavior_sanitizer, LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(realtime_sanitizer, cjappl wrote: https://github.com/llvm/l

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Chris Apple via cfe-commits
@@ -54,6 +54,8 @@ FEATURE(memtag_globals, FEATURE(xray_instrument, LangOpts.XRayInstrument) FEATURE(undefined_behavior_sanitizer, LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(realtime_sanitizer, cjappl wrote: But not merged yet, waiti

[clang] [clang][rtsan] Add realtime_sanitizer to Features.def (PR #106650)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/106650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb14941 - [clang][rtsan] Add realtime_sanitizer to Features.def (#106650)

2024-09-06 Thread via cfe-commits
Author: Chris Apple Date: 2024-09-06T10:46:47-07:00 New Revision: fb1494137e551448d8742d5e6367bf62e923598d URL: https://github.com/llvm/llvm-project/commit/fb1494137e551448d8742d5e6367bf62e923598d DIFF: https://github.com/llvm/llvm-project/commit/fb1494137e551448d8742d5e6367bf62e923598d.diff L

[clang] [clang][rtsan] Add realtime_sanitizer to Features.def (PR #106650)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/106650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. LGTM, with addressed comments https://github.com/llvm/llvm-project/pull/106736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] [AMDGPU] Add target intrinsic for s_buffer_prefetch_data (PR #107293)

2024-09-06 Thread Stanislav Mekhanoshin via cfe-commits
rampitec wrote: > I think the parent needs some revision for global/flat/infer handling Do you like this more? https://github.com/llvm/llvm-project/pull/107624 https://github.com/llvm/llvm-project/pull/107293 ___ cfe-commits mailing list cfe-commits@l

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-09-06 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > To better understand the motivation, I have two questions: > > * Why do you give Clang module maps describing modules that are already > described in PCM files? Unless the module map describes some other top-level > module that's yet to be built, the information it provi

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Justin Bogner via cfe-commits
@@ -387,6 +387,23 @@ float3 asin(float3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_asin) float4 asin(float4); +//===--===// +// asuint builtins +//===--

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-06 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: you need to update lit test clang/test/CodeGenCUDA/device-stub.cu as it fails now [clang/test/CodeGenCUDA/device-stub.cu](https://buildkite.com/llvm-project/github-pull-requests/builds/98392#0191c73e-12f8-4cf3-9618-d3fd752f9149) https://github.com/llvm/llvm-project/pull/107458

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
@@ -387,6 +387,23 @@ float3 asin(float3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_asin) float4 asin(float4); +//===--===// +// asuint builtins +//===--

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-06 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/107285 From b982621407a1ab1746a023809aae5c6a2b983679 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= <149377404+zimi...@users.noreply.github.com>

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
@@ -1427,6 +1447,14 @@ bool CheckAllArgsHaveFloatRepresentation(Sema *S, CallExpr *TheCall) { checkAllFloatTypes); } +bool CheckArgIsFloatOrIntWithoutImplicits(Sema *S, Expr *Arg) { + auto checkFloat = [](clang::QualType PassedType) -> bool

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/3] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
@@ -1427,6 +1447,14 @@ bool CheckAllArgsHaveFloatRepresentation(Sema *S, CallExpr *TheCall) { checkAllFloatTypes); } +bool CheckArgIsFloatOrIntWithoutImplicits(Sema *S, Expr *Arg) { + auto checkFloat = [](clang::QualType PassedType) -> bool

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s + + +// CHECK-LABEL: test_asuint4_uint +// CHECK: ret i32 %0 +export uint test_asuint4_uint(uint

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl deleted https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-06 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeView] Flatten cmd args in frontend for LF_BUILDINFO (PR #106369)

2024-09-06 Thread Alexandre Ganea via cfe-commits
aganea wrote: > I always set Argv0 and Commandline, even if they are just an empty string. > Some tools had issues if those were not set. We already did use the empty > string for BuildInfoRecord::TypeServerPDB, so now its also more consistent. Ah yes, that's good. Looks good, thanks again!

[clang] [llvm] [CodeView] Flatten cmd args in frontend for LF_BUILDINFO (PR #106369)

2024-09-06 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea approved this pull request. https://github.com/llvm/llvm-project/pull/106369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >