https://github.com/erichkeane commented:
I'm a little cold on review here, so I don't want to accept this, but I did a
scroll through and don't have any problems here. Additionally, a bunch of
whitespace changes are still in this, which is making it difficult tor eview.
https://github.com/llv
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/106657
>From 214f801923d654f5fcc96241840aa7742cd0e85b Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Thu, 29 Aug 2024 20:32:02 -0700
Subject: [PATCH 1/2] Improve code that fills resource binding flags
---
clang/lib
@@ -0,0 +1,136 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 5
+; RUN: llc -global-isel=0 -march=amdgcn -mcpu=gfx1200 < %s | FileCheck
--check-prefixes=GCN,SDAG %s
+; RUN: llc -global-isel=1 -march=amdgcn -mcpu=gfx1200 < %s
llvmbot wrote:
Failed to cherry-pick: eec1fac
https://github.com/llvm/llvm-project/actions/runs/10688677657
Please manually backport the fix and push it to your github fork. Once this is
done, please create a [pull
request](https://github.com/llvm/llvm-project/compare)
https://github.com/l
@@ -0,0 +1,136 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 5
+; RUN: llc -global-isel=0 -march=amdgcn -mcpu=gfx1200 < %s | FileCheck
--check-prefixes=GCN,SDAG %s
+; RUN: llc -global-isel=1 -march=amdgcn -mcpu=gfx1200 < %s
@@ -0,0 +1,136 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 5
+; RUN: llc -global-isel=0 -march=amdgcn -mcpu=gfx1200 < %s | FileCheck
--check-prefixes=GCN,SDAG %s
+; RUN: llc -global-isel=1 -march=amdgcn -mcpu=gfx1200 < %s
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/107133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight wrote:
Do the include guard macros make it problematic to expose as a textual header?
I would not have thought that to be the case.
https://github.com/llvm/llvm-project/pull/96246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager
&SourceMgr,
return false;
}
+static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) {
jwakely wrote:
Shouldn't the library use `[[__deprecated__]]` and `[[clang::__
https://github.com/spall updated
https://github.com/llvm/llvm-project/pull/107129
>From 3e0cd3c450eb4aa28742c4879733987e9e2692e7 Mon Sep 17 00:00:00 2001
From: Sarah Spall
Date: Wed, 28 Aug 2024 01:44:35 +
Subject: [PATCH 1/3] implement select intrinsic
---
clang/include/clang/Basic/Built
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager
&SourceMgr,
return false;
}
+static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) {
AaronBallman wrote:
Maybe? I think they absolutely should, but those names are
@@ -612,57 +588,61 @@ static RegisterBindingFlags
HLSLFillRegisterBindingFlags(Sema &S,
return Flags;
}
- if (!isDeclaredWithinCOrTBuffer(TheDecl)) {
-// make sure the type is a basic / numeric type
-if (TheVarDecl) {
- QualType TheQualTy = TheVarDecl->get
@@ -612,57 +588,61 @@ static RegisterBindingFlags
HLSLFillRegisterBindingFlags(Sema &S,
return Flags;
}
- if (!isDeclaredWithinCOrTBuffer(TheDecl)) {
-// make sure the type is a basic / numeric type
-if (TheVarDecl) {
- QualType TheQualTy = TheVarDecl->get
https://github.com/banach-space commented:
What's the end goal here? To add an option for every possible bit-width? If
yes, then these options should take bit width as parameters.
Btw, does GFortran implement anything like this? If yes, are you making sure
that the semantics in Flang are consi
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) {
*p = (packedfloat3) { 3.2f, 2.3f, 0.1f };
}
// CHECK: @test3(
-// CHECK: store <4 x float> {{.*}}, align 4
+// CHECK: store <3 x float> {{.*}}, align 4
efriedma-quic wrote:
> that sounds essentially what the op
@@ -28104,6 +28104,251 @@ TEST_F(FormatTest, BreakBinaryOperations) {
Style);
}
+TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) {
+ FormatStyle Style = getLLVMStyle();
+ Style.FixNamespaceComments = false;
+ Style.ShortNamespaceLines = 0;
+ Style.M
Renaud-K wrote:
The end goal is testing for issues that this PR would expose and that I am
planning on filing next.
Every bit-width? (5,6,7,9,11,12,13,14,15) I don't think so.
It does not matter what gfortran does. It is not a feature, it is hidden for
testing purposes.
https://github.com/
@@ -6652,6 +6652,48 @@ the configuration (without a prefix: ``Auto``).
For example: BOOST_PP_STRINGIZE
+.. _WrapNamespaceBodyWithEmptyLines:
+
+**WrapNamespaceBodyWithEmptyLines** (``WrapNamespaceBodyWithEmptyLinesStyle``)
:versionbadge:`clang-format 19` :ref:`¶ `
Author: Martin Storsjö
Date: 2024-09-03T22:45:11+03:00
New Revision: eb05e8fde1ebc4cda2106b1236620a8a89b36b7c
URL:
https://github.com/llvm/llvm-project/commit/eb05e8fde1ebc4cda2106b1236620a8a89b36b7c
DIFF:
https://github.com/llvm/llvm-project/commit/eb05e8fde1ebc4cda2106b1236620a8a89b36b7c.diff
https://github.com/mstorsjo closed
https://github.com/llvm/llvm-project/pull/106875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Martin Storsjö
Date: 2024-09-03T22:45:54+03:00
New Revision: fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10
URL:
https://github.com/llvm/llvm-project/commit/fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10
DIFF:
https://github.com/llvm/llvm-project/commit/fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10.diff
https://github.com/mstorsjo closed
https://github.com/llvm/llvm-project/pull/106686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mstorsjo milestoned
https://github.com/llvm/llvm-project/pull/106686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo wrote:
/cherry-pick fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10
https://github.com/llvm/llvm-project/pull/106686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
/pull-request llvm/llvm-project#107146
https://github.com/llvm/llvm-project/pull/106686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,6 +32,26 @@ bool isRecordLBrace(const FormatToken &Tok) {
TT_StructLBrace, TT_UnionLBrace);
}
+bool LineStartsNamespaceScope(const AnnotatedLine *Line,
+ const AnnotatedLine *PreviousLine,
+
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-expensive-checks-win` running on `as-worker-93` while
building `clang,libclc,llvm` at step 7 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/14/bu
https://github.com/JustinStitt updated
https://github.com/llvm/llvm-project/pull/86618
>From e73df4dedbb2e2be8b72ca3a8e847d5cbca29bed Mon Sep 17 00:00:00 2001
From: Justin Stitt
Date: Tue, 5 Mar 2024 03:14:49 +
Subject: [PATCH] implement wraps attribute
Signed-off-by: Justin Stitt
---
cl
Author: Martin Storsjö
Date: 2024-09-03T23:14:38+03:00
New Revision: 70f3511adaea4d3a9f8fadb23e84f518cc0654ab
URL:
https://github.com/llvm/llvm-project/commit/70f3511adaea4d3a9f8fadb23e84f518cc0654ab
DIFF:
https://github.com/llvm/llvm-project/commit/70f3511adaea4d3a9f8fadb23e84f518cc0654ab.diff
mstorsjo wrote:
/cherry-pick fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10
70f3511adaea4d3a9f8fadb23e84f518cc0654ab
https://github.com/llvm/llvm-project/pull/106686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
ian-twilightcoder wrote:
> Do the include guard macros make it problematic to expose as a textual
> header? I would not have thought that to be the case.
It means that the header guard declaration would be compiled into every pcm
that includes the header. Which is maybe fine for this one, but
https://github.com/ian-twilightcoder closed
https://github.com/llvm/llvm-project/pull/105855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ian Anderson
Date: 2024-09-03T13:34:43-07:00
New Revision: 319e8cd201e6744199da377fba237dd276063e49
URL:
https://github.com/llvm/llvm-project/commit/319e8cd201e6744199da377fba237dd276063e49
DIFF:
https://github.com/llvm/llvm-project/commit/319e8cd201e6744199da377fba237dd276063e49.diff
https://github.com/erichkeane commented:
I'll have to take another look at this when I get more time for it, but I'm
glad this is getting further attention. I'd refactored this only a year or two
ago (preivously it was a single really long function with a loop), so it is
disappointing that we
@@ -52,38 +52,6 @@ using namespace sema;
//===--===/
namespace {
-namespace TemplateInstArgsHelpers {
erichkeane wrote:
Awe, I thought this was clever/useful :)
https://github.com/llvm/llvm
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apolloww created
https://github.com/llvm/llvm-project/pull/107153
#100205 skips CoroSplit and CoroCleanup in ThinLTO pre-link pipeline
unconditionally. It defers coroutine optimizations to ThinLTO post-link so that
across-module CoroElide is possible by leaving coroutine fun
Author: Martin Storsjö
Date: 2024-09-03T23:50:54+03:00
New Revision: cbb5f03f5042aa6d7c5d17963eba192861c9165c
URL:
https://github.com/llvm/llvm-project/commit/cbb5f03f5042aa6d7c5d17963eba192861c9165c
DIFF:
https://github.com/llvm/llvm-project/commit/cbb5f03f5042aa6d7c5d17963eba192861c9165c.diff
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Wei Wang (apolloww)
Changes
#100205 skips CoroSplit and CoroCleanup in ThinLTO pre-link pipeline
unconditionally. It defers coroutine optimizations to ThinLTO post-link so that
across-module CoroElide is possible by leaving coroutine func
mstorsjo wrote:
/cherry-pick
https://github.com/llvm/llvm-project/commit/fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10
https://github.com/llvm/llvm-project/commit/70f3511adaea4d3a9f8fadb23e84f518cc0654ab
cbb5f03f5042aa6d7c5d17963eba192861c9165c
https://github.com/llvm/llvm-project/pull/106686
___
https://github.com/dmasloff updated
https://github.com/llvm/llvm-project/pull/106145
>From 219424f9cd3477d9290c8766eaa857234a1ae387 Mon Sep 17 00:00:00 2001
From: dmasloff
Date: Mon, 26 Aug 2024 22:11:05 +0300
Subject: [PATCH 1/3] [clang-format] Add new option:
WrapNamespaceBodyWithNewlines
-
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/106811
>From 4abb34b1b21e666e20a9b3bad8af146d3bf322f0 Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Fri, 30 Aug 2024 23:54:41 +
Subject: [PATCH 1/2] Fix implicit conversion rank ordering
DXC prefers dimen
https://github.com/kwk updated https://github.com/llvm/llvm-project/pull/106407
>From ca503d037c9e05bd986dfe56296059c691db822a Mon Sep 17 00:00:00 2001
From: Konrad Kleine
Date: Wed, 28 Aug 2024 17:22:29 +0200
Subject: [PATCH] Fix CLANG_BOOTSTRAP_TARGETS in Release.cmake
Take all `LLVM_RELEASE_
https://github.com/kwk ready_for_review
https://github.com/llvm/llvm-project/pull/106407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kwk updated https://github.com/llvm/llvm-project/pull/106407
>From ca503d037c9e05bd986dfe56296059c691db822a Mon Sep 17 00:00:00 2001
From: Konrad Kleine
Date: Wed, 28 Aug 2024 17:22:29 +0200
Subject: [PATCH] Fix CLANG_BOOTSTRAP_TARGETS in Release.cmake
Take all `LLVM_RELEASE_
@@ -18695,6 +18695,50 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
CGM.getHLSLRuntime().getSaturateIntrinsic(), ArrayRef{Op0},
nullptr, "hlsl.saturate");
}
+ case Builtin::BI__builtin_hlsl_select: {
+Value *OpCond = EmitScalarExpr(E->getArg(0));
@@ -55,15 +55,23 @@ set(STAGE1_RUNTIMES "compiler-rt")
if (LLVM_RELEASE_ENABLE_PGO)
list(APPEND STAGE1_PROJECTS "lld")
- set(CLANG_BOOTSTRAP_TARGETS
+ set(tmp_targets
generate-profdata
stage2-package
stage2-clang
+stage2
stage2-install
stage2-c
Author: Helena Kotas
Date: 2024-09-03T14:11:06-07:00
New Revision: 334d1238aafa8ca017d433caaf8f6e00f2622111
URL:
https://github.com/llvm/llvm-project/commit/334d1238aafa8ca017d433caaf8f6e00f2622111
DIFF:
https://github.com/llvm/llvm-project/commit/334d1238aafa8ca017d433caaf8f6e00f2622111.diff
401 - 448 of 448 matches
Mail list logo
