[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd edited https://github.com/llvm/llvm-project/pull/107112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd edited https://github.com/llvm/llvm-project/pull/107112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
@@ -7939,7 +7927,14 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, } } return ExprError(); + } else if (Result.isUnset()) { +// BuildOverloadedArrowExpr returns an empty expression to indicate +// that we n

[libclc] 903d1c6 - [libclc] More cross compilation fixes (#97811)

2024-09-03 Thread via cfe-commits
Author: Harald van Dijk Date: 2024-09-03T17:01:20+01:00 New Revision: 903d1c6ee5de4ee87c1737906c264e219c05d4cb URL: https://github.com/llvm/llvm-project/commit/903d1c6ee5de4ee87c1737906c264e219c05d4cb DIFF: https://github.com/llvm/llvm-project/commit/903d1c6ee5de4ee87c1737906c264e219c05d4cb.dif

[clang] [libclc] [llvm] [libclc] More cross compilation fixes (PR #97811)

2024-09-03 Thread Harald van Dijk via cfe-commits
https://github.com/hvdijk closed https://github.com/llvm/llvm-project/pull/97811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread via cfe-commits
@@ -7939,7 +7927,14 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, } } return ExprError(); + } else if (Result.isUnset()) { +// BuildOverloadedArrowExpr returns an empty expression to indicate +// that we n

[clang] 903d1c6 - [libclc] More cross compilation fixes (#97811)

2024-09-03 Thread via cfe-commits
Author: Harald van Dijk Date: 2024-09-03T17:01:20+01:00 New Revision: 903d1c6ee5de4ee87c1737906c264e219c05d4cb URL: https://github.com/llvm/llvm-project/commit/903d1c6ee5de4ee87c1737906c264e219c05d4cb DIFF: https://github.com/llvm/llvm-project/commit/903d1c6ee5de4ee87c1737906c264e219c05d4cb.dif

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: Can you update the description too? No changelog needed, I assume we want to backport that @AaronBallman https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. https://github.com/llvm/llvm-project/pull/107087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
@@ -7939,7 +7927,14 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, } } return ExprError(); + } else if (Result.isUnset()) { +// BuildOverloadedArrowExpr returns an empty expression to indicate +// that we n

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/104458 >From a719de89be6af3607f67baddd8868f8e0fc7882f Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 15 Aug 2024 11:27:34 -0400 Subject: [PATCH 1/3] [Clang][Sema] Use the correct lookup context when

[clang] [llvm] [LV] Mask off possibly aliasing vector lanes (PR #100579)

2024-09-03 Thread Graham Hunter via cfe-commits
@@ -2778,6 +2808,60 @@ void VPWidenPointerInductionRecipe::print(raw_ostream &O, const Twine &Indent, } #endif +void VPAliasLaneMaskRecipe::execute(VPTransformState &State) { + IRBuilderBase Builder = State.Builder; + Value *SinkValue = State.get(getSinkValue(), 0, true); +

[clang-tools-extra] Update clang tidy Contributing guide (PR #106672)

2024-09-03 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hmm, in that case, would it be better to note the Windows exception in the > documentation and open up an issue tracker for the tab issue instead, since > the bug and fix (due to it affecting all tab-related operations on Windows) > is out of scope for this documentation

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks (Please update the description before merging) https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Can you update the description too? No changelog needed, I assume we want to > backport that @AaronBallman If we can backport it, it seems like a reasonable one to backport; the biggest question I have is whether we have any concerns about the changes being risky or not.

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -7981,7 +7969,7 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, SmallVector OperatorArrows; CTypes.insert(Context.getCanonicalType(BaseType)); -while (BaseType->isRecordType()) { +while (BaseType->getAsRecordDecl()) {

[clang] 9626e84 - [clang][bytecode][NFC] Simplify builtin-functions.cpp (#107118)

2024-09-03 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-03T18:41:01+02:00 New Revision: 9626e84faeaab200665bae9694458c2beb3d49c7 URL: https://github.com/llvm/llvm-project/commit/9626e84faeaab200665bae9694458c2beb3d49c7 DIFF: https://github.com/llvm/llvm-project/commit/9626e84faeaab200665bae9694458c2beb3d49c7.diff L

[clang] [clang][bytecode][NFC] Simplify builtin-functions.cpp (PR #107118)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/107118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Steven Wu via cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef canonicalizePlatformName(llvm::StringRef Platform) { .Case("ShaderModel", "shadermodel") .Default(Platform); } +static std::vector equivalentPlatformNames(llvm::StringRef Platform) { cach

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan approved this pull request. LGTM in general. https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Implement FP8 floating-point mode helper intrinsics (PR #100608)

2024-09-03 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/100608 >From 17964507593a4ae3d2b13c4fe84500472705485f Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Thu, 25 Jul 2024 18:25:40 +0100 Subject: [PATCH 1/2] [AArch64] Implement FP8 floating-point mode helper

[clang] [AArch64] Implement FP8 floating-point mode helper intrinsics (PR #100608)

2024-09-03 Thread Momchil Velikov via cfe-commits
momchil-velikov wrote: > > * passing `__arm_fpm_init()` as the `__fpm` to these CodeGen tests cannot > > check whether the correct value is used to zero-out the target bits. > > Good point, in the tests where we set a field to zero we should start with a > non-zero in that field. Tweaked the

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread Renaud Kauffmann via cfe-commits
https://github.com/Renaud-K created https://github.com/llvm/llvm-project/pull/107126 I would to add hidden options to disable types through the `TargetCharacteristics`. I am seeing issues when I do this programmatically and would like, for anyone, to have the ability to reproduce them for deve

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Renaud Kauffmann (Renaud-K) Changes I would to add hidden options to disable types through the `TargetCharacteristics`. I am seeing issues when I do this programmatically and would like, for anyone, to have the ability to reproduce them f

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Renaud Kauffmann (Renaud-K) Changes I would to add hidden options to disable types through the `TargetCharacteristics`. I am seeing issues when I do this programmatically and would like, for anyone, to have the ability to reproduce

[clang] added regcall struct by reg support (PR #95257)

2024-09-03 Thread Erich Keane via cfe-commits
erichkeane wrote: As background: That chunking behavior was not in the specification document that I was provided internally when I implemented that. IIRC at the time, regcall wasn't actually documented externally, so that documentation likely post-dates when I did my implementation. https:/

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
@@ -7981,7 +7969,7 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, SmallVector OperatorArrows; CTypes.insert(Context.getCanonicalType(BaseType)); -while (BaseType->isRecordType()) { +while (BaseType->getAsRecordDecl()) {

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f9ad24946026c45e22c445f8ebc79b8b651e1dad 8a1c51bdd290fc47cac359646aeb01623574231f --e

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: @AaronBallman btw, backporting that would be nice... https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in annotating ObjCBlockLParen (PR #107021)

2024-09-03 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/107021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle spaces in file paths in git-clang-format.bat (PR #107041)

2024-09-03 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/107041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-09-03 Thread via cfe-commits
bipmis wrote: I am seeing this causing a build failure in one the benchmarks in SPEC CPU2017 FP name 510.parest_r. Benchmark description is available at https://www.spec.org/cpu2017/Docs/benchmarks/510.parest_r.html and it is based on deal.II open source finite element library. I have not red

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -7981,7 +7969,7 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, SmallVector OperatorArrows; CTypes.insert(Context.getCanonicalType(BaseType)); -while (BaseType->isRecordType()) { +while (BaseType->getAsRecordDecl()) {

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-03 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-03 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/107129 Implement support for HLSL intrinsic select. This would close issue #75377 >From 226ea652f160b22922e9582c5a5c53511042d735 Mon Sep 17 00:00:00 2001 From: Sarah Spall Date: Wed, 28 Aug 2024 01:44:35 + Subject:

[clang] [HLSL] Implement support for HLSL intrinsic - select (PR #107129)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Sarah Spall (spall) Changes Implement support for HLSL intrinsic select. This would close issue #75377 --- Full diff: https://github.com/llvm/llvm-project/pull/107129.diff 6 Files Affected: - (modified) clang/include/clang/Basi

[clang] [libclc] [llvm] [libclc] More cross compilation fixes (PR #97811)

2024-09-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot7` while building `clang,libclc,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/3294 Here is the relevant

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread Renaud Kauffmann via cfe-commits
https://github.com/Renaud-K updated https://github.com/llvm/llvm-project/pull/107126 >From 8a1c51bdd290fc47cac359646aeb01623574231f Mon Sep 17 00:00:00 2001 From: Renaud-K Date: Tue, 3 Sep 2024 09:34:09 -0700 Subject: [PATCH 1/2] Allow disabling of types from the command line --- clang/includ

[clang] [clang] Add test for CWG2486 (`noexcept` and function pointer conversion) (PR #107131)

2024-09-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/107131 [CWG2486](https://cplusplus.github.io/CWG/issues/2486.html) "Call to `noexcept` function via `noexcept(false)` pointer/lvalue" allows `noexcept` functions to be called via `noexcept(false)` pointers or values.

[clang] [clang] Add test for CWG2486 (`noexcept` and function pointer conversion) (PR #107131)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes [CWG2486](https://cplusplus.github.io/CWG/issues/2486.html) "Call to `noexcept` function via `noexcept(false)` pointer/lvalue" allows `noexcept` functions to be called via `noexcept(false)` pointers or

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread Peter Klausler via cfe-commits
https://github.com/klausler approved this pull request. https://github.com/llvm/llvm-project/pull/107126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] Allow disabling of types from the command line (PR #107126)

2024-09-03 Thread Peter Klausler via cfe-commits
@@ -6761,6 +6761,12 @@ def fdefault_integer_8 : Flag<["-"],"fdefault-integer-8">, Group, HelpText<"Set the default integer and logical kind to an 8 byte wide type">; def fdefault_real_8 : Flag<["-"],"fdefault-real-8">, Group, HelpText<"Set the default real kind to an 8 byt

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef canonicalizePlatformName(llvm::StringRef Platform) { .Case("ShaderModel", "shadermodel") .Default(Platform); } +static std::vector equivalentPlatformNames(llvm::StringRef Platform) { ian-

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-09-03 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/106603 >From 18814eb544e4e8d9274583c41e65b7f16c3bdfcc Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Thu, 29 Aug 2024 18:18:42 + Subject: [PATCH 1/2] [CMake][compiler-rt] Support for using compiler-rt atomic li

[clang] [clang] Add test for CWG2486 (`noexcept` and function pointer conversion) (PR #107131)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/107131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 26a4edf - [CMake][compiler-rt] Support for using compiler-rt atomic library (#106603)

2024-09-03 Thread via cfe-commits
Author: Petr Hosek Date: 2024-09-03T10:28:49-07:00 New Revision: 26a4edf655aac138ef4f8cebf865d34b9ab4ff2d URL: https://github.com/llvm/llvm-project/commit/26a4edf655aac138ef4f8cebf865d34b9ab4ff2d DIFF: https://github.com/llvm/llvm-project/commit/26a4edf655aac138ef4f8cebf865d34b9ab4ff2d.diff LO

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-09-03 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/106603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM with some minor grammatical nits in a comment. https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -5443,11 +5443,24 @@ struct EnsureImmediateInvocationInDefaultArgs // Rewrite to source location to refer to the context in which they are used. ExprResult TransformSourceLocExpr(SourceLocExpr *E) { -if (E->getParentContext() == SemaRef.CurContext) +DeclContext

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -5443,11 +5443,24 @@ struct EnsureImmediateInvocationInDefaultArgs // Rewrite to source location to refer to the context in which they are used. ExprResult TransformSourceLocExpr(SourceLocExpr *E) { -if (E->getParentContext() == SemaRef.CurContext) +DeclContext

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-09-03 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > I think we can just switch it to be a textual header; it no longer has any > decls. It does still have _MM3DNOW_H_INCLUDED, but we could probably remove that https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits m

[clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Clang bits LGTM https://github.com/llvm/llvm-project/pull/106505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PGO][Pipeline] Enable PGOForceFunctionAttrs in PGO optimization pipelines (PR #106790)

2024-09-03 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks updated https://github.com/llvm/llvm-project/pull/106790 >From a469c523921c3bcb3a8e2a6ad5eaa856a6035449 Mon Sep 17 00:00:00 2001 From: Arthur Eubanks Date: Fri, 30 Aug 2024 20:14:18 + Subject: [PATCH 1/2] [PGO][Pipeline] Enable PGOForceFunctionAttrs in PGO optim

[clang] [llvm] [PGO][Pipeline] Enable PGOForceFunctionAttrs in PGO optimization pipelines (PR #106790)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Arthur Eubanks (aeubanks) Changes Remove flag that turns on the PGOForceFunctionAttrs pass and always add it to default pipelines when using PGO. This is NFC by default since PGOOpt->ColdOptType is by default ColdFuncOpt::Default. Remov

[clang] fb14f1d - [PGO][Pipeline] Enable PGOForceFunctionAttrs in PGO optimization pipelines (#106790)

2024-09-03 Thread via cfe-commits
Author: Arthur Eubanks Date: 2024-09-03T10:35:08-07:00 New Revision: fb14f1df54c3e4edaaf3aa34268147f4da11d3b4 URL: https://github.com/llvm/llvm-project/commit/fb14f1df54c3e4edaaf3aa34268147f4da11d3b4 DIFF: https://github.com/llvm/llvm-project/commit/fb14f1df54c3e4edaaf3aa34268147f4da11d3b4.diff

[clang] [llvm] [PGO][Pipeline] Enable PGOForceFunctionAttrs in PGO optimization pipelines (PR #106790)

2024-09-03 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/106790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Steven Wu via cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef canonicalizePlatformName(llvm::StringRef Platform) { .Case("ShaderModel", "shadermodel") .Default(Platform); } +static std::vector equivalentPlatformNames(llvm::StringRef Platform) { cach

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Steven Wu via cfe-commits
https://github.com/cachemeifyoucan edited https://github.com/llvm/llvm-project/pull/105855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Adjust resource binding diagnostic flags code (PR #106657)

2024-09-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/106657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Adjust resource binding diagnostic flags code (PR #106657)

2024-09-03 Thread Justin Bogner via cfe-commits
@@ -612,57 +588,61 @@ static RegisterBindingFlags HLSLFillRegisterBindingFlags(Sema &S, return Flags; } - if (!isDeclaredWithinCOrTBuffer(TheDecl)) { -// make sure the type is a basic / numeric type -if (TheVarDecl) { - QualType TheQualTy = TheVarDecl->get

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-03 Thread Chris B via cfe-commits
@@ -414,9 +414,20 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD, void CGHLSLRuntime::setHLSLFunctionAttributes(const FunctionDecl *FD, llvm::Function *Fn) { - if (FD->isInExportDeclContext()) { -const String

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/107133 None >From 000e16cbd27783be68afdd9952c65e58f4cd7040 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 3 Sep 2024 10:14:35 -0700 Subject: [PATCH] [AMDGPU] Add target intrinsic for s_prefetch_data

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-clang-codegen Author: Stanislav Mekhanoshin (rampitec) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/107133.diff 9 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (+1) - (mod

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Shilei Tian via cfe-commits
@@ -19489,6 +19489,12 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, F, {EmitScalarExpr(E->getArg(0)), EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), EmitScalarExpr(E->getArg(3))}); } + case AMDGPU::BI__builtin_amdgcn_s

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef canonicalizePlatformName(llvm::StringRef Platform) { .Case("ShaderModel", "shadermodel") .Default(Platform); } +static std::vector equivalentPlatformNames(llvm::StringRef Platform) { ian-

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Stanislav Mekhanoshin via cfe-commits
@@ -19489,6 +19489,12 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, F, {EmitScalarExpr(E->getArg(0)), EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), EmitScalarExpr(E->getArg(3))}); } + case AMDGPU::BI__builtin_amdgcn_s

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/107133 >From 000e16cbd27783be68afdd9952c65e58f4cd7040 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 3 Sep 2024 10:14:35 -0700 Subject: [PATCH 1/2] [AMDGPU] Add target intrinsic for s_prefetch_data -

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Shilei Tian via cfe-commits
@@ -19489,6 +19489,12 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, F, {EmitScalarExpr(E->getArg(0)), EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), EmitScalarExpr(E->getArg(3))}); } + case AMDGPU::BI__builtin_amdgcn_s

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/107133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread via cfe-commits
https://github.com/jkorous-apple edited https://github.com/llvm/llvm-project/pull/101583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread via cfe-commits
@@ -0,0 +1,106 @@ +// RUN: %clang_cc1 -std=c++20 -Wno-all -Wunsafe-buffer-usage \ +// RUN:-verify %s + +typedef struct {} FILE; +void memcpy(); +void __asan_memcpy(); +void strcpy(); +void strcpy_s(); +void wcscpy_s(); +unsigned strlen( const char* str ); +int fprintf(

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread via cfe-commits
@@ -0,0 +1,106 @@ +// RUN: %clang_cc1 -std=c++20 -Wno-all -Wunsafe-buffer-usage \ +// RUN:-verify %s + +typedef struct {} FILE; +void memcpy(); +void __asan_memcpy(); +void strcpy(); +void strcpy_s(); +void wcscpy_s(); +unsigned strlen( const char* str ); +int fprintf(

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread via cfe-commits
https://github.com/jkorous-apple commented: Commenting on the tests as there are specific examples. https://github.com/llvm/llvm-project/pull/101583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread via cfe-commits
@@ -0,0 +1,106 @@ +// RUN: %clang_cc1 -std=c++20 -Wno-all -Wunsafe-buffer-usage \ +// RUN:-verify %s + +typedef struct {} FILE; +void memcpy(); +void __asan_memcpy(); +void strcpy(); +void strcpy_s(); +void wcscpy_s(); +unsigned strlen( const char* str ); +int fprintf(

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread via cfe-commits
https://github.com/jkorous-apple edited https://github.com/llvm/llvm-project/pull/101583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/107133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/107133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) { AaronBallman wrote: These are great questions! `__has_cpp_attribute` should r

[clang] [clang] Add test for CWG2486 (`noexcept` and function pointer conversion) (PR #107131)

2024-09-03 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. https://github.com/llvm/llvm-project/pull/107131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/107133 >From 000e16cbd27783be68afdd9952c65e58f4cd7040 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Tue, 3 Sep 2024 10:14:35 -0700 Subject: [PATCH 1/3] [AMDGPU] Add target intrinsic for s_prefetch_data -

[clang] [llvm] [AMDGPU] Add target intrinsic for s_prefetch_data (PR #107133)

2024-09-03 Thread Stanislav Mekhanoshin via cfe-commits
@@ -19489,6 +19489,12 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, F, {EmitScalarExpr(E->getArg(0)), EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), EmitScalarExpr(E->getArg(3))}); } + case AMDGPU::BI__builtin_amdgcn_s

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-09-03 Thread Eli Friedman via cfe-commits
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) { *p = (packedfloat3) { 3.2f, 2.3f, 0.1f }; } // CHECK: @test3( -// CHECK: store <4 x float> {{.*}}, align 4 +// CHECK: store <3 x float> {{.*}}, align 4 efriedma-quic wrote: On targets with SIMD vectors (basical

[clang] [Clang][Sema] clang generates incorrect fix-its for API_AVAILABLE (PR #105855)

2024-09-03 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/105855 >From f54f7bf02ae2a93e9b321be181b59485e241a51a Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Fri, 23 Aug 2024 09:43:22 -0700 Subject: [PATCH] [Clang][Sema] clang generates incorrect fix-its for AP

[clang] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2024-09-03 Thread Erich Keane via cfe-commits
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) { erichkeane wrote: I concur with Aaron. The point of this restriction is to pe

[clang] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) { AaronBallman wrote: Because we don't support any non-standard attributes witho

[clang] [-Wunsafe-buffer-usage] Warning Libc functions (PR #101583)

2024-09-03 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 edited https://github.com/llvm/llvm-project/pull/101583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix sema init crashing on initialization sequences (PR #98102)

2024-09-03 Thread Erich Keane via cfe-commits
@@ -5576,6 +5576,10 @@ static void TryOrBuildParenListInitialization( ExprResult ER; ER = IS.Perform(S, SubEntity, SubKind, Arg ? MultiExprArg(Arg) : std::nullopt); + + if (ER.isInvalid()) erichkeane wrote: For `ExprResul

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-09-03 Thread Kees Cook via cfe-commits
kees wrote: > > I’m a little concerned about not allowing the attribute in C++ - the > > existence of other options in C++ does not mean they are an option (due to > > various and sundry restrictions of C++ version upgrades different projects > > have), but also you trivially end up in cases w

[clang] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2024-09-03 Thread Erich Keane via cfe-commits
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) { erichkeane wrote: > Because we don't support any non-standard attributes witho

[clang] Fix codegen for transparent_union function params (PR #104816)

2024-09-03 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan approved this pull request. LGTM for using `CGT.ConvertType()` like you did previously. I agree that if we were to do a larger/refactoring patch, that can be separate since this PR fixes the current codegen. https://github.com/llvm/llvm-project/pull/104816 _

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-09-03 Thread Shilei Tian via cfe-commits
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) { *p = (packedfloat3) { 3.2f, 2.3f, 0.1f }; } // CHECK: @test3( -// CHECK: store <4 x float> {{.*}}, align 4 +// CHECK: store <3 x float> {{.*}}, align 4 shiltian wrote: Hmm, that sounds essentially what the opti

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-09-03 Thread Shilei Tian via cfe-commits
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) { *p = (packedfloat3) { 3.2f, 2.3f, 0.1f }; } // CHECK: @test3( -// CHECK: store <4 x float> {{.*}}, align 4 +// CHECK: store <3 x float> {{.*}}, align 4 shiltian wrote: Does it make sense to move the logic to ba

[clang] eec1fac - [Clang] Fix handling of placeholder variables name in init captures (#107055)

2024-09-03 Thread via cfe-commits
Author: cor3ntin Date: 2024-09-03T20:36:15+02:00 New Revision: eec1fac9b51d06c8afafe9952a20ba7cd4c3ce1c URL: https://github.com/llvm/llvm-project/commit/eec1fac9b51d06c8afafe9952a20ba7cd4c3ce1c DIFF: https://github.com/llvm/llvm-project/commit/eec1fac9b51d06c8afafe9952a20ba7cd4c3ce1c.diff LOG:

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/107055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread via cfe-commits
https://github.com/cor3ntin milestoned https://github.com/llvm/llvm-project/pull/107055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: /cherry-pick eec1fac https://github.com/llvm/llvm-project/pull/107055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-03 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/70976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-03 Thread Erich Keane via cfe-commits
@@ -101,91 +102,164 @@ namespace clang { }; } -class DiagnosticMapping { - LLVM_PREFERRED_TYPE(diag::Severity) - unsigned Severity : 3; - LLVM_PREFERRED_TYPE(bool) - unsigned IsUser : 1; - LLVM_PREFERRED_TYPE(bool) - unsigned IsPragma : 1; - LLVM_PREFERRED_TYPE(bo

<    1   2   3   4   5   >