[clang] [Clang][AST] Add Test Cases for Reference Qualifiers in Opr Overload (PR #102878)

2024-08-12 Thread Muhammad Abdul via cfe-commits
https://github.com/0xzre updated https://github.com/llvm/llvm-project/pull/102878 >From 11b625354ff05c4384603932e6acca347df2132b Mon Sep 17 00:00:00 2001 From: 0xzre Date: Mon, 12 Aug 2024 17:42:37 +0700 Subject: [PATCH 1/2] [Clang][AST] Add Test Cases for Reference Qualifiers in Operator Over

[clang] Fixes and closes issues, #53390 and #58710. Added new controls to IndentNamespaceAliases, IndentUsingDeclarations and DecorateReflowedComments. (PR #102894)

2024-08-12 Thread Rajkumar Ananthu via cfe-commits
https://github.com/rajkumarananthu created https://github.com/llvm/llvm-project/pull/102894 Issue #53390 was reported to have an option to control indenting namespace aliases independently of NamespaceIndentation, added this feature. Issue #58710 was reported to have an option to control the d

[clang] Fixes and closes issues, #53390 and #58710. Added new controls to IndentNamespaceAliases, IndentUsingDeclarations and DecorateReflowedComments. (PR #102894)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Rajkumar Ananthu (rajkumarananthu) Changes Issue #53390 was reported to have an option to control indenting namespace aliases independently of NamespaceIndentation, added this feature. Issue #58710 was reported to have an option to

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-08-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, but please add a release note so users know about the fix. https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > We were compiling simple testcase with complex parameters with clang and it > was crashing because libraries was built using gcc. > > @AaronBallman, Reason for new flag was to enable this for other C standards > as well. Currently we use c11 as standard in VxWorks toolcha

[clang] [clang][Interp] Compile field+base destruction into class dtor func (PR #102871)

2024-08-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/102871 >From 3c780a997df63f6c60d25d34067675af30c9ca02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 12 Aug 2024 11:45:27 +0200 Subject: [PATCH] [clang][Interp] Compile field+base destruction

[clang] aa86e5b - [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (#102716)

2024-08-12 Thread via cfe-commits
Author: Shilei Tian Date: 2024-08-12T08:57:37-04:00 New Revision: aa86e5beffec33c84289e2a103c6de0311865be5 URL: https://github.com/llvm/llvm-project/commit/aa86e5beffec33c84289e2a103c6de0311865be5 DIFF: https://github.com/llvm/llvm-project/commit/aa86e5beffec33c84289e2a103c6de0311865be5.diff L

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-12 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/102716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix diagnosing uninitialized nested union fields (PR #102824)

2024-08-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/102824 >From e0c9d600c95b2d97a749b53c165fb865bb75414e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 11 Aug 2024 19:52:51 +0200 Subject: [PATCH] [clang][Interp] Fix diagnosing uninitialized ne

[clang] 895ca18 - [PS4/PS5][Driver] Allow -static in PlayStation drivers (#102020)

2024-08-12 Thread via cfe-commits
Author: Edd Dawson Date: 2024-08-12T14:00:50+01:00 New Revision: 895ca18a1c5a93ebc2b9bcc4673c138a908827a2 URL: https://github.com/llvm/llvm-project/commit/895ca18a1c5a93ebc2b9bcc4673c138a908827a2 DIFF: https://github.com/llvm/llvm-project/commit/895ca18a1c5a93ebc2b9bcc4673c138a908827a2.diff LO

[clang] [PS4/PS5][Driver] Allow -static in PlayStation drivers (PR #102020)

2024-08-12 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/102020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
https://github.com/kiran-isaac created https://github.com/llvm/llvm-project/pull/102896 Backend: - Caller and callee arguments no longer have to match, just to take up the same space, as they can be changed before the call - Allowed tail calls if callee and callee both (or neither) use sret, wh

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
https://github.com/kiran-isaac updated https://github.com/llvm/llvm-project/pull/102896 >From 24806b179d34b4afb21832e4a2150c13995b59e0 Mon Sep 17 00:00:00 2001 From: Kiran Date: Thu, 8 Aug 2024 13:07:24 +0100 Subject: [PATCH] [ARM] musttail fixes Backend: - Caller and callee arguments no longe

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
https://github.com/kiran-isaac edited https://github.com/llvm/llvm-project/pull/102896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
https://github.com/kiran-isaac ready_for_review https://github.com/llvm/llvm-project/pull/102896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Kiran (kiran-isaac) Changes Backend: - Caller and callee arguments no longer have to match, just to take up the same space, as they can be changed before the call - Allowed tail calls if callee and callee

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
kiran-isaac wrote: @jthackray @ostannard https://github.com/llvm/llvm-project/pull/102896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-12 Thread via cfe-commits
https://github.com/kiran-isaac updated https://github.com/llvm/llvm-project/pull/102896 >From 24806b179d34b4afb21832e4a2150c13995b59e0 Mon Sep 17 00:00:00 2001 From: Kiran Date: Thu, 8 Aug 2024 13:07:24 +0100 Subject: [PATCH] [ARM] musttail fixes Backend: - Caller and callee arguments no longe

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/3507 Here is the relevant piece of the build log for

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Are VLAs something we need to care about here @AaronBallman ? VLAs are always something we need to care about thanks to exposing them in C++. :-D We should add some test coverage to ensure the behavior is reasonable. Other test cases to consider: lifetime around `this` in

[clang] [llvm] Add emitAtomicCompareExchangeBuiltin helper function (PR #101966)

2024-08-12 Thread Nikita Popov via cfe-commits
nikic wrote: The TLI dependency in Clang CodeGen is a pretty substantial departure from how things currently work -- with the major implication that you can no longer reliably run codegen for a target for which the corresponding LLVM backend has not been compiled. Currently, codegen tests assu

[clang] [ASTDump] TextNodeDumper learned to dump builtin name for AtomicExpr (PR #102748)

2024-08-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/102748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Coroutines] Change `llvm.coro.noop` to accept `llvm_anyptr_ty` instead (PR #102096)

2024-08-12 Thread Matt Arsenault via cfe-commits
@@ -123,6 +123,17 @@ bool coro::declaresIntrinsics(const Module &M, return false; } +// Verifies if a module has any intrinsics. +bool coro::declaresIntrinsics(const Module &M, + const DenseSet &Identifiers) { + for (const Function &F : M.functi

[clang] [llvm] [Coroutines] Change `llvm.coro.noop` to accept `llvm_anyptr_ty` instead (PR #102096)

2024-08-12 Thread Joseph Huber via cfe-commits
@@ -123,6 +123,17 @@ bool coro::declaresIntrinsics(const Module &M, return false; } +// Verifies if a module has any intrinsics. +bool coro::declaresIntrinsics(const Module &M, + const DenseSet &Identifiers) { + for (const Function &F : M.functi

[clang] [llvm] [Coroutines] Change `llvm.coro.noop` to accept `llvm_anyptr_ty` instead (PR #102096)

2024-08-12 Thread Matt Arsenault via cfe-commits
@@ -123,6 +123,17 @@ bool coro::declaresIntrinsics(const Module &M, return false; } +// Verifies if a module has any intrinsics. +bool coro::declaresIntrinsics(const Module &M, + const DenseSet &Identifiers) { + for (const Function &F : M.functi

[clang] [clang] Add frontend flag to enable support for broken external resugarers (PR #102510)

2024-08-12 Thread Yitzhak Mandelbaum via cfe-commits
ymand wrote: Gentle ping. It's critical that this land so we can unbreak our system. Thanks! https://github.com/llvm/llvm-project/pull/102510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][ASTMatcher] Add `matchesString` for `StringLiteral` which matches literals on given `RegExp` (PR #102152)

2024-08-12 Thread Aaron Ballman via cfe-commits
@@ -125,6 +125,7 @@ RegistryMaps::RegistryMaps() { REGISTER_MATCHER_OVERLOAD(equals); REGISTER_REGEX_MATCHER(isExpansionInFileMatching); + REGISTER_REGEX_MATCHER(matchesString); REGISTER_REGEX_MATCHER(matchesName); REGISTER_REGEX_MATCHER(matchesSelector); --

[clang] [clang][ASTMatcher] Add `matchesString` for `StringLiteral` which matches literals on given `RegExp` (PR #102152)

2024-08-12 Thread Aaron Ballman via cfe-commits
@@ -2503,6 +2503,28 @@ TEST_P(ASTMatchersTest, IsDelegatingConstructor) { cxxConstructorDecl(isDelegatingConstructor(), parameterCountIs(1; } +TEST_P(ASTMatchersTest, MatchesString) { + StatementMatcher Literal = stringLiteral(matchesString("foo.*")); + EXPECT_TRUE

[clang] [llvm] [Coroutines] Change `llvm.coro.noop` to accept `llvm_anyptr_ty` instead (PR #102096)

2024-08-12 Thread Joseph Huber via cfe-commits
@@ -123,6 +123,17 @@ bool coro::declaresIntrinsics(const Module &M, return false; } +// Verifies if a module has any intrinsics. +bool coro::declaresIntrinsics(const Module &M, + const DenseSet &Identifiers) { + for (const Function &F : M.functi

[clang] [X86_64] Fix empty field error in vaarg of C++. (PR #101639)

2024-08-12 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker updated https://github.com/llvm/llvm-project/pull/101639 >From 3ff5909e6c0cc7acff96ed4e8524a3b5949b209f Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 2 Aug 2024 16:36:31 +0800 Subject: [PATCH 1/3] [X86_64] Fix empty field error in vaarg of C++. Such struct

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread via cfe-commits
https://github.com/owlxiao created https://github.com/llvm/llvm-project/pull/102899 NutShell is an open-source Linux-compatible RISC-V processor, it supports riscv64/32. Overview: https://github.com/OSCPU/NutShell This PR add two CPUs: - `nutshell-rv32`: rv32imac_zicsr_zifencei - `nutshell-rv6

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [AArch64] Add FEAT_SME_B16B16 and remove FEAT_B16B16 (PR #102501)

2024-08-12 Thread via cfe-commits
https://github.com/SpencerAbson closed https://github.com/llvm/llvm-project/pull/102501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang Author: Xiao (owlxiao) Changes NutShell is an open-source Linux-compatible RISC-V processor, it supports riscv64/32. Overview: https://github.com/OSCPU/NutShell This PR add two CPUs: - `nutshell-rv32`: rv32imac

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: Some relevant context for what CPUs we permit merging into LLVM: https://github.com/llvm/llvm-project/pull/102452#issuecomment-2275962014 How does this apply to NutShell? https://github.com/llvm/llvm-project/pull/102899 ___ cfe-commits

[clang] [clang] Avoid triggering vtable instantiation for C++23 constexpr dtor (PR #102605)

2024-08-12 Thread via cfe-commits
vient wrote: Will this be backported to release/19.x? https://github.com/llvm/llvm-project/pull/102605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Ensure `--print-runtime-dir` path exists (PR #102834)

2024-08-12 Thread Alexandre Ganea via cfe-commits
aganea wrote: To give the whole picture, the story is that while building the LLVM package on Windows, I was seeing this: ``` [51/52] Running sanitizer_common testsllvm-lit.py: C:\src\git\llvm-project\llvm\utils\lit\lit\llvm\config.py:57: note: using lit tools: C:\Program Files\Git\usr\bin\ ll

[clang] [PS5][Driver] Link main components with -pie by default (PR #102901)

2024-08-12 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/102901 The PS5 linker currently forces `-pie` for typical link jobs. Have the driver pass `pie` under the same conditions. With this change we can remove our private linker patch and also allow `-no-pie` to ha

[clang] [PS5][Driver] Link main components with -pie by default (PR #102901)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Edd Dawson (playstation-edd) Changes The PS5 linker currently forces `-pie` for typical link jobs. Have the driver pass `pie` under the same conditions. With this change we can remove our private linker patch and also allow `-no-pie` to h

[clang] [X86_64] Fix empty field error in vaarg of C++. (PR #101639)

2024-08-12 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker updated https://github.com/llvm/llvm-project/pull/101639 >From 3ff5909e6c0cc7acff96ed4e8524a3b5949b209f Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 2 Aug 2024 16:36:31 +0800 Subject: [PATCH 1/3] [X86_64] Fix empty field error in vaarg of C++. Such struct

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread via cfe-commits
owlxiao wrote: > Some relevant context for what CPUs we permit merging into LLVM: [#102452 > (comment)](https://github.com/llvm/llvm-project/pull/102452#issuecomment-2275962014) > > How does this apply to NutShell? I'm sorry to see this. I will handle it manually once Hazard3 is merged into t

[clang-tools-extra] [clang-tidy] Create bugprone-public-enable-shared-from-this check (PR #102299)

2024-08-12 Thread via cfe-commits
@@ -0,0 +1,34 @@ +.. title:: clang-tidy - bugprone-incorrect-enable-shared-from-this + +bugprone-incorrect-enable-shared-from-this +=== EugeneZelenko wrote: Please make same length as check name. https://github.com/llvm/llvm-p

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-08-12 Thread Mital Ashok via cfe-commits
MitalAshok wrote: The feature test macro (`__cpp_lib_is_within_lifetime`) should be defined by the standard library in ``/`` (so libc++ or libstdc++). All that changes for Clang with this patch is `__has_builtin(__builtin_is_within_lifetime)`. P2641R4 doesn't appear to be in [cxx_status](htt

[clang] [AIX] Turn on `#pragma mc_func` check by default (PR #101336)

2024-08-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Thank you! However, we're getting pretty late in the release cycle and so I'd > like to see this backed out of 19.x ASAP (and given the direction the > discussion is going, I think it should be backed out of main as well). @qiongsiwu will you be able to get these changes

[clang] [llvm] [AArch64] Add FEAT_SME_B16B16 and remove FEAT_B16B16 (PR #102501)

2024-08-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang,llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/2630 Here is the relevant

[clang] [AIX] Turn on `#pragma mc_func` check by default (PR #101336)

2024-08-12 Thread Qiongsi Wu via cfe-commits
qiongsiwu wrote: > > Thank you! However, we're getting pretty late in the release cycle and so > > I'd like to see this backed out of 19.x ASAP (and given the direction the > > discussion is going, I think it should be backed out of main as well). > > @qiongsiwu will you be able to get these c

[clang] [HLSL] Split out the ROV attribute from the resource attribute, make it a new spellable attribute. (PR #102414)

2024-08-12 Thread Justin Bogner via cfe-commits
@@ -296,12 +296,13 @@ void CGHLSLRuntime::annotateHLSLResource(const VarDecl *D, GlobalVariable *GV) { for (auto *FD : RD->fields()) { const auto *HLSLResAttr = FD->getAttr(); const auto *HLSLResClassAttr = FD->getAttr(); +const auto *ROVAttr = FD->getAttr();

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw requested changes to this pull request. After consulting with NutShell's maintainer @poemonsense, I think this PR should be rejected for the following reasons: 1. There are no commercial plans for this educational processor. 2. This project is no longer maintained. h

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-12 Thread via cfe-commits
https://github.com/martinboehme requested changes to this pull request. https://github.com/llvm/llvm-project/pull/94869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-12 Thread via cfe-commits
@@ -0,0 +1,59 @@ +// RUN: %check_clang_tidy -std=c++17-or-later %s bugprone-use-after-move %t -- \ +// RUN:-config="{CheckOptions: {bugprone-use-after-move.AllowMovedSmartPtrUse: false}}" -- -fno-delayed-template-parsing -I %S/../modernize/Inputs/smart-ptr/ + +#include "uni

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-12 Thread via cfe-commits
@@ -250,3 +251,14 @@ For example, if an additional member variable is added to ``S``, it is easy to forget to add the reinitialization for this additional member. Instead, it is safer to assign to the entire struct in one go, and this will also avoid the use-after-move warning

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-12 Thread via cfe-commits
@@ -200,7 +200,8 @@ An exception to this are objects of type ``std::unique_ptr``, (objects of these classes are guaranteed to be empty after they have been moved from). Therefore, an object of these classes will only be considered to be used if it is dereferenced, i.e. if ``op

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-12 Thread via cfe-commits
@@ -0,0 +1,59 @@ +// RUN: %check_clang_tidy -std=c++17-or-later %s bugprone-use-after-move %t -- \ +// RUN:-config="{CheckOptions: {bugprone-use-after-move.AllowMovedSmartPtrUse: false}}" -- -fno-delayed-template-parsing -I %S/../modernize/Inputs/smart-ptr/ + +#include "uni

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-12 Thread via cfe-commits
martinboehme wrote: > Nope, there is no reliable way to "survey users". Default behavior of checks > changes every release. Some checks are getting limited, by excluding some use > cases, some checks are getting extended. In this case situation is easy. > Users will update Clang-tidy, and if c

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-12 Thread Daniil Fukalov via cfe-commits
dfukalov wrote: > Can you provide more context on the motivation / what you're trying to > achieve here? The motivation is as usual IWYU and similar refactoring - to reduce build time and probablility of non-related source(s) recompile. > Did you know that LLVM intentionally does not follow I

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-08-12 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm updated https://github.com/llvm/llvm-project/pull/98671 >From 1ad95178817e58dd7767f0c8b472ec0b7e46cd45 Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Fri, 12 Jul 2024 13:57:33 -0400 Subject: [PATCH 1/5] Fix assertion failure during operator overload resolution. --- c

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-08-12 Thread Daniel M. Katz via cfe-commits
katzdm wrote: > LGTM, but please add a release note so users know about the fix. @AaronBallman Appreciate the reminder! Done. https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [clang] Allow class with anonymous union member to be const-default-constructible even if a union member has a default member initializer (#95854) (PR #96301)

2024-08-12 Thread Jessica Clarke via cfe-commits
@@ -0,0 +1,21 @@ +// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s +// +// -expected-no-diagnostics jrtc27 wrote: ? https://github.com/llvm/llvm-project/pull/96301 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-12 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/102664 >From 4735b4c7bad13dee4bbeb819aba8ac555f842322 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Fri, 9 Aug 2024 20:08:43 +0100 Subject: [PATCH] [APINotes] Support C++ tag conformances to Swift protocols This a

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-12 Thread Egor Zhdan via cfe-commits
@@ -572,6 +572,13 @@ class TagTableInfo ReleaseOpLength - 1); Data += ReleaseOpLength - 1; } +unsigned ConformsToLength = +endian::readNext(Data); +if (ConformsToLength > 0) { egorzhdan wrote: D

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-12 Thread Egor Zhdan via cfe-commits
@@ -1230,6 +1231,12 @@ class TagTableInfo : public CommonTypeTableInfo { } else { writer.write(0); } +if (auto ConformsTo = TI.SwiftConformsTo) { + writer.write(ConformsTo->size() + 1); + OS.write(ConformsTo->c_str(), ConformsTo->size()); --

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-12 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/102602 >From 7b4f999b39f4308cab253204e6be41ea7a70f695 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 9 Aug 2024 14:37:47 +0300 Subject: [PATCH 1/5] clang/csa: add initial support for builtin overflow --- ..

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/102622 >From 9d3d49fa755c28b21c3b4771faae65cf418dec5a Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Wed, 24 Jul 2024 14:25:44 -0700 Subject: [PATCH 1/3] [clang][rtsan] Introduce realtime sanitizer codegen and driver

[clang] [clang][Interp] Compile field+base destruction into class dtor func (PR #102871)

2024-08-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/102871 >From 390f3a513722f4f00013dd3213ca5d1f672a0c72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 12 Aug 2024 11:45:27 +0200 Subject: [PATCH] [clang][Interp] Compile field+base destruction

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/102622 >From 9d3d49fa755c28b21c3b4771faae65cf418dec5a Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Wed, 24 Jul 2024 14:25:44 -0700 Subject: [PATCH 1/4] [clang][rtsan] Introduce realtime sanitizer codegen and driver

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-12 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon commented: Would it be possible to split this into PRs per subproject please (bolt/clang/lld/llvm/mlir)? https://github.com/llvm/llvm-project/pull/102707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-12 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/102664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Introduce ffp-model=aggressive (PR #100453)

2024-08-12 Thread Kevin P. Neal via cfe-commits
kpneal wrote: Since you asked about "=strict", I don't think the strict model should change handling of excess precision. The rounding part of the constrained intrinsics shouldn't have any effect at all on excess precision. Eliminating excess precision also shouldn't happen with exception hand

[clang] [Driver] Have getTargetSubDirPath better match get_compiler_rt_target (PR #100091)

2024-08-12 Thread Rainer Orth via cfe-commits
rorth wrote: > Do we still need to fix this for 19.1.0-final? I think so, yes. E.g. when building on LLVM without specifying `LLVM_HOST_TRIPLE` explicitly (like when using `test-release.sh`), the `config.guess` output is used which is `sparc64-unknown-linux-gnu`. However, `compiler-rt` alwa

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-globalisel Author: Janek van Oirschot (JanekvO) Changes !!! Stacked PR on top of #95951 commit, please only review the latest commit 51f72f115b340a092c2c9f8569911b944a4efb6d Converts AMDGPUResourceUsageAnalysis pass from Module to MachineFunc

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Janek van Oirschot (JanekvO) Changes !!! Stacked PR on top of #95951 commit, please only review the latest commit 51f72f115b340a092c2c9f8569911b944a4efb6d Converts AMDGPUResourceUsageAnalysis pass from Module to MachineFunction pass. M

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Janek van Oirschot (JanekvO) Changes !!! Stacked PR on top of #95951 commit, please only review the latest commit 51f72f115b340a092c2c9f8569911b944a4efb6d Converts AMDGPUResourceUsageAnalysis pass from Module to MachineFunction pass.

[clang] [llvm] [HLSL][DXIL][SPIRV] Create llvm dot intrinsic and use for HLSL (PR #102872)

2024-08-12 Thread Thorsten Schütt via cfe-commits
tschuett wrote: Please advertise your achievements: https://github.com/llvm/llvm-project/blob/main/llvm/docs/GlobalISel/GenericOpcode.rst Please add the intrinsics with semantics to the langref: https://github.com/llvm/llvm-project/blob/main/llvm/docs/LangRef.rst @nikic will review Please prote

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-12 Thread Doug Wyatt via cfe-commits
@@ -2397,6 +2397,1262 @@ class UnsafeBufferUsageReporter : public UnsafeBufferUsageHandler { }; } // namespace +// = + +namespace FXAnalysis { + +enum class DiagnosticID : uint8_t { + None = 0, // s

[clang] [llvm] Add emitAtomicCompareExchangeBuiltin helper function (PR #101966)

2024-08-12 Thread Michael Kruse via cfe-commits
Meinersbur wrote: `TargetLibraryInfoImpl` is not contained in the backends, but implemented entirely in [`TargetLibraryInfo.cpp`](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Analysis/TargetLibraryInfo.cpp). `TargetLowering` is implemented in the backend, but is also optional. If

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 832203545d4e2157ca29f99b18e3360ffa180183 ecab8b292912692d4823a90f26db29f0cb624551 --e

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-12 Thread Jay Foad via cfe-commits
jayfoad wrote: > > Did you know that LLVM intentionally does not follow IWYU and favors > > forward declarations: > > https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible > > Yes, but I actually do not see what part of the mentioned standard' section > conflicts with the c

[clang] [llvm] [RISCV] Add NutShell RV32/64 processors definition (PR #102899)

2024-08-12 Thread via cfe-commits
https://github.com/owlxiao closed https://github.com/llvm/llvm-project/pull/102899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-12 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/99656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Have getTargetSubDirPath better match get_compiler_rt_target (PR #100091)

2024-08-12 Thread Rainer Orth via cfe-commits
@@ -766,9 +766,19 @@ ToolChain::getTargetSubDirPath(StringRef BaseDir) const { return {}; }; - if (auto Path = getPathForTriple(getTriple())) + llvm::Triple Triple = getTriple(); + + // Try triple as is. + if (auto Path = getPathForTriple(Triple)) return *Path;

[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

2024-08-12 Thread Janek van Oirschot via cfe-commits
JanekvO wrote: Upstream's formatting does not seem to agree with my local `git clang-format`. https://github.com/llvm/llvm-project/pull/102913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

2024-08-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/102622 >From 9d3d49fa755c28b21c3b4771faae65cf418dec5a Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Wed, 24 Jul 2024 14:25:44 -0700 Subject: [PATCH 1/5] [clang][rtsan] Introduce realtime sanitizer codegen and driver

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-12 Thread Jon Roelofs via cfe-commits
@@ -2397,6 +2397,1262 @@ class UnsafeBufferUsageReporter : public UnsafeBufferUsageHandler { }; } // namespace +// = + +namespace FXAnalysis { + +enum class DiagnosticID : uint8_t { + None = 0, // s

[clang] [clang] Implement `__builtin_is_implicit_lifetime()` (PR #101807)

2024-08-12 Thread Aaron Ballman via cfe-commits
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema &Self, TypeTrait UTT, return false; case UTT_IsTriviallyEqualityComparable: return isTriviallyEqualityComparableType(Self, T, KeyLoc); + case UTT_IsImplicitLifetime: { +DiagnoseVLAInCXXTypeTrait(Self

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-08-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > LGTM, but please add a release note so users know about the fix. > > @AaronBallman Appreciate the reminder! Done. Thanks! Do you need someone to land the changes? https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits

[clang] 3825a7c - [clang][Interp] Fix diagnosing uninitialized nested union fields (#102824)

2024-08-12 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-12T17:11:23+02:00 New Revision: 3825a7c542f362ace2e943f4fc3ec8538750db3c URL: https://github.com/llvm/llvm-project/commit/3825a7c542f362ace2e943f4fc3ec8538750db3c DIFF: https://github.com/llvm/llvm-project/commit/3825a7c542f362ace2e943f4fc3ec8538750db3c.diff L

[clang] [clang][Interp] Fix diagnosing uninitialized nested union fields (PR #102824)

2024-08-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/102824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-12 Thread Nikita Popov via cfe-commits
nikic wrote: I'm seeing a 0.06% increase in build time with this change. Per-file breakdown: http://llvm-compile-time-tracker.com/compare_clang.php?from=9a227ba3e129eaa89498b97421afefb1e9d681df&to=e354fa543d20a8f50ea678c4cfc7d6dc091ad569&stat=instructions%3Au&sortBy=interestingness Clearly, thi

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. Is it possible to check other enabled check? If not, I would like add an option to control the way to fix instead of change the behavior directly. https://github.com/llvm/llvm-project/pull/102831

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/102831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-08-12 Thread Daniel M. Katz via cfe-commits
katzdm wrote: > > > LGTM, but please add a release note so users know about the fix. > > > > > > @AaronBallman Appreciate the reminder! Done. > > Thanks! Do you need someone to land the changes? Yep, I don't have commit privilege - would appreciate the help :) https://github.com/llvm/llvm-pr

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -324,7 +324,14 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM, } } - if (Subtarget.hasSSE2()) { + if (Subtarget.hasAVX10_2() || Subtarget.hasAVX10_2_512()) { +setOperationAction(ISD::FP_TO_UINT_SAT, MVT::i32, Legal); +setOperationAction(

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -150,9 +150,11 @@ set(x86_files avx10_2_512minmaxintrin.h avx10_2_512niintrin.h avx10_2_512satcvtintrin.h + avx10_2_512satcvtdsintrin.h phoebewang wrote: Alphanumeric order. https://github.com/llvm/llvm-project/pull/102592 __

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -99,6 +99,12 @@ TARGET_BUILTIN(__builtin_ia32_vcvttsh2si64, "OiV8xIi", "ncV:128:", "avx512fp16") TARGET_BUILTIN(__builtin_ia32_vcvttsh2usi64, "UOiV8xIi", "ncV:128:", "avx512fp16") TARGET_BUILTIN(__builtin_ia32_directstore_u64, "vULi*ULi", "n", "movdiri") +// AVX10.2 SATCV

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,453 @@ +/*===--- avx10_2satcvtdsintrin.h - AVX512SATCVTDS intrinsics === + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Ap

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -2122,6 +2122,36 @@ TARGET_BUILTIN(__builtin_ia32_vpdpwuud256, "V8iV8iV8iV8i", "nV:256:", "avxvnniin TARGET_BUILTIN(__builtin_ia32_vpdpwuuds128, "V4iV4iV4iV4i", "nV:128:", "avxvnniint16|avx10.2-256") TARGET_BUILTIN(__builtin_ia32_vpdpwuuds256, "V8iV8iV8iV8i", "nV:256:", "a

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,184 @@ +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx10.2-512 -emit-llvm -o - | FileCheck %s + +#include +#include + +long long test_mm_cvttssd_si64(__m128d __A) { + // CHECK-LABEL: @test_mm_c

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -150,9 +150,11 @@ set(x86_files avx10_2_512minmaxintrin.h avx10_2_512niintrin.h avx10_2_512satcvtintrin.h + avx10_2_512satcvtdsintrin.h avx10_2minmaxintrin.h avx10_2niintrin.h avx10_2satcvtintrin.h + avx10_2satcvtdsintrin.h phoebewang wrote:

[clang] [llvm] [X86][AVX10.2] Support saturated converts (PR #102592)

2024-08-12 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,453 @@ +/*===--- avx10_2satcvtdsintrin.h - AVX512SATCVTDS intrinsics === + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Ap

<    1   2   3   4   5   >