@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S,
CXXRecordDecl *Record) {
}
}
+bool EffectivelyConstexprDestructor = true;
+// Avoid triggering vtable instantiation due to a dtor that is not
+// "effectively constexpr" for better compa
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/102605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin commented:
General direction looks good!
https://github.com/llvm/llvm-project/pull/102605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S,
CXXRecordDecl *Record) {
}
}
+bool EffectivelyConstexprDestructor = true;
+// Avoid triggering vtable instantiation due to a dtor that is not
+// "effectively constexpr" for better compa
Author: Anton Sidorenko
Date: 2024-08-09T16:02:27+03:00
New Revision: 02645d66f93809f7f52b742987f350793136221f
URL:
https://github.com/llvm/llvm-project/commit/02645d66f93809f7f52b742987f350793136221f
DIFF:
https://github.com/llvm/llvm-project/commit/02645d66f93809f7f52b742987f350793136221f.dif
https://github.com/asi-sc closed
https://github.com/llvm/llvm-project/pull/102285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/gribozavr approved this pull request.
Thank you! This change fixes and unblocks our nullability and lifetime tooling.
Please merge at your convenience.
https://github.com/llvm/llvm-project/pull/102510
___
cfe-commits mailing list
cf
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/102615
We were using tryGetRealPathName in certain places, which resolves
symlinks (sometimes). This was resulting in discrepancies in behavior,
depending on how a file was first reached.
This path migrates all usages
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: kadir çetinkaya (kadircet)
Changes
We were using tryGetRealPathName in certain places, which resolves
symlinks (sometimes). This was resulting in discrepancies in behavior,
depending on how a file was first reached.
This path m
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/102580
From 08367f06167d8b12ee4de06a37915decd1e754e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Fri, 9 Aug 2024 09:31:55 +0200
Subject: [PATCH 1/2] [clang][analyzer] Remove array bounds c
https://github.com/AaronBallman commented:
Was there an RFC for this? I ask because it's introducing another qualifier and
that has broad impacts on things beyond Clang like libc++, etc so we really
need buy-in from a wider range of the community than will likely see this PR.
https://github.co
@@ -971,9 +971,12 @@ static const Expr
*SubstituteConstraintExpressionWithoutSatisfaction(
// this may happen while we're comparing two templates' constraint
// equivalence.
LocalInstantiationScope ScopeForParameters(S);
- if (auto *FD = DeclInfo.getDecl()->getAsFunctio
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+template static void destroy() {
+T t;
+++t;
+}
+
+struct Incomplete;
+
+template struct HasD {
+ ~HasD() { destroy(); }
+};
+
+struct HasVT {
+ virtual ~HasVT();
+}
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/102605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -50,6 +101,44 @@ class BuiltinFunctionChecker : public Checker {
} // namespace
+void BuiltinFunctionChecker::HandleOverflowBuiltin(const CallEvent &Call,
+ CheckerContext &C,
+
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/102602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat approved this pull request.
Thanks for the updates, I'm satisfied with the state of this commit. However
let's wait for an independent approval from @steakhal @haoNoQ or someone else,
because this change does reduce the scope of this checker.
https://github.com/llv
@@ -47,11 +47,17 @@ set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "")
set(STAGE1_PROJECTS "clang")
-set(STAGE1_RUNTIMES "")
+
+# Building Flang on Windows requires compiler-rt, so we need to build it in
+# stage1. compiler-rt is al
AaronBallman wrote:
The precommit CI failures are related to your changes and need to be addressed.
https://github.com/llvm/llvm-project/pull/102510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/AaronBallman requested changes to this pull request.
I think using "broken" in the name of the diagnostic and the internal option is
a bit problematic -- that's too much of a value judgement, IMO. After all, the
previous functionality worked well enough for those folks.
Woul
@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S,
CXXRecordDecl *Record) {
}
}
+bool EffectivelyConstexprDestructor = true;
+// Avoid triggering vtable instantiation due to a dtor that is not
+// "effectively constexpr" for better compa
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/102572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Thank you for the improved documentation! I made some suggestions for clarity,
but please make sure I didn't change your intended meaning.
https://github.com/llvm/llvm-project/pull/102572
___
cfe-commits mail
@@ -1230,6 +1230,57 @@ parsing their headers, those should be included after
the import. If the
imported modules don't provide such a header, one can be made manually for
improved compile time performance.
+Reachability of internal partition units
+---
@@ -1230,6 +1230,57 @@ parsing their headers, those should be included after
the import. If the
imported modules don't provide such a header, one can be made manually for
improved compile time performance.
+Reachability of internal partition units
+---
@@ -1230,6 +1230,57 @@ parsing their headers, those should be included after
the import. If the
imported modules don't provide such a header, one can be made manually for
improved compile time performance.
+Reachability of internal partition units
+---
@@ -1230,6 +1230,57 @@ parsing their headers, those should be included after
the import. If the
imported modules don't provide such a header, one can be made manually for
improved compile time performance.
+Reachability of internal partition units
+---
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+template static void destroy() {
+T t;
+++t;
+}
+
+struct Incomplete;
+
+template struct HasD {
+ ~HasD() { destroy(); }
+};
+
+struct HasVT {
+ virtual ~HasVT();
+}
https://github.com/MitalAshok created
https://github.com/llvm/llvm-project/pull/102619
Fixes #102588
>From f47340974464dccae08980a1f8e78f0982169a58 Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Fri, 9 Aug 2024 15:03:38 +0100
Subject: [PATCH] [Clang][SemaCXX] Preserve qualifiers in derived-t
https://github.com/jthackray approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/101978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mital Ashok (MitalAshok)
Changes
Fixes #102588
---
Full diff: https://github.com/llvm/llvm-project/pull/102619.diff
3 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+1)
- (modified) clang/lib/Sema/SemaDeclCXX.cpp (+5-4)
- (
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+template static void destroy() {
+T t;
+++t;
+}
+
+struct Incomplete;
+
+template struct HasD {
+ ~HasD() { destroy(); }
+};
+
+struct HasVT {
+ virtual ~HasVT();
+}
https://github.com/ian-twilightcoder closed
https://github.com/llvm/llvm-project/pull/102567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ian Anderson
Date: 2024-08-09T07:06:11-07:00
New Revision: 4c5ef6690040383956461828457ac27f7f912edb
URL:
https://github.com/llvm/llvm-project/commit/4c5ef6690040383956461828457ac27f7f912edb
DIFF:
https://github.com/llvm/llvm-project/commit/4c5ef6690040383956461828457ac27f7f912edb.diff
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/100419
>From 5d2b3fa876c00869a3964081a57ae23563d18175 Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Wed, 24 Jul 2024 16:58:56 +0100
Subject: [PATCH 1/4] [Clang] Check explicit object param for defaulted
relation
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1d77dd50f1bab20d2025d25f79784d5be1520847
f47340974464dccae08980a1f8e78f0982169a58 --e
https://github.com/thesamesam approved this pull request.
Thanks @AaronBallman!
Other than gdb (thank you Carlos for working on that), I'm only aware of two
issues:
* qtlocation -> boost (https://bugs.gentoo.org/895516 ->
https://bugreports.qt.io/browse/QTBUG-116652 ->
https://github.com/boos
https://github.com/thesamesam edited
https://github.com/llvm/llvm-project/pull/102364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/102619
>From fc436186e37ff9852269599c750f8e836aee5e99 Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Fri, 9 Aug 2024 15:03:38 +0100
Subject: [PATCH] [Clang][SemaCXX] Preserve qualifiers in derived-to-base cast
in
https://github.com/cjappl created
https://github.com/llvm/llvm-project/pull/102622
Introduce the `-fsanitize=realtime` flag in clang driver
Plug in the RealtimeSanitizer PassManager pass in Codegen, and attribute a
function based on if it has the `[[clang::nonblocking]]` function effect.
>Fr
cjappl wrote:
I was not able to figure out a way to separate the CodeGen from the driver,
seeing as the codegen only happens when the sanitizer is enabled. This means to
write unit tests for the CodeGen, I needed the -fsanitize=realtime flag. If
someone has advice on how to get around this pro
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chris Apple (cjappl)
Changes
Introduce the `-fsanitize=realtime` flag in clang driver
Plug in the RealtimeSanitizer PassManager pass in Codegen, and attribute a
function based on if it has the `[[clang::nonblocking]]` function effect.
-
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Chris Apple (cjappl)
Changes
Introduce the `-fsanitize=realtime` flag in clang driver
Plug in the RealtimeSanitizer PassManager pass in Codegen, and attribute a
function based on if it has the `[[clang::nonblocking]]` function effe
@@ -845,6 +845,12 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
if (SanOpts.has(SanitizerKind::ShadowCallStack))
Fn->addFnAttr(llvm::Attribute::ShadowCallStack);
+ if (SanOpts.has(SanitizerKind::Realtime)) {
+for (const FunctionEffectWithCon
@@ -995,6 +996,13 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
FPM.addPass(BoundsCheckingPass());
});
+if (LangOpts.Sanitize.has(SanitizerKind::Realtime))
+ PB.registerScalarOptimizerLateEPCallback(
cjappl wrote:
I am co
@@ -552,11 +552,15 @@ SanitizerArgs::SanitizerArgs(const ToolChain &TC,
SanitizerKind::Leak | SanitizerKind::Thread |
SanitizerKind::Memory | SanitizerKind::KernelAddress |
SanitizerKind::Scudo | Sanitiz
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/102605
>From eb97afb9cade7b496ec55acdd4f02a915c4a4955 Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Fri, 9 Aug 2024 05:20:37 -0700
Subject: [PATCH 1/2] [clang] Avoid triggering vtable instantiation fo
cjappl wrote:
Pinging for a possible review:
@Sirraide @AaronBallman @MaskRay @vitalybuka @dougsonos
Co-Author @davidtrevelyan
https://github.com/llvm/llvm-project/pull/102622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
MitalAshok wrote:
@cor3ntin If everything is still good with this could you commit this for me?
Thanks!
https://github.com/llvm/llvm-project/pull/100419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/NagyDonat approved this pull request.
This change seems to be correct, but I don't know enough to dig into the
details and provide a confident review. However, I as far as I know there are
no significantly better reviewers, so I can give you the formal approval.
I think you
@@ -712,22 +712,30 @@ bool Sema::addInstantiatedCapturesToScope(
auto AddSingleCapture = [&](const ValueDecl *CapturedPattern,
unsigned Index) {
ValueDecl *CapturedVar = LambdaClass->getCapture(Index)->getCapturedVar();
-if (CapturedVar->
https://github.com/shiltian closed
https://github.com/llvm/llvm-project/pull/101407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/100766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/100766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -712,22 +712,30 @@ bool Sema::addInstantiatedCapturesToScope(
auto AddSingleCapture = [&](const ValueDecl *CapturedPattern,
unsigned Index) {
ValueDecl *CapturedVar = LambdaClass->getCapture(Index)->getCapturedVar();
-if (CapturedVar->
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/102601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -38,6 +38,10 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett wrote:
This looks like a macro that a compiler might set for you, is that not the case
here?
http
@@ -11,6 +11,11 @@
#include "lldb/Host/Config.h"
+#if defined(__AIX__)
+//FIXME for AIX
+#undef LLDB_ENABLE_LIBXML2
DavidSpickett wrote:
In theory if you configure with `-DLLDB_ENABLE_LIBXML2=OFF`, the libxml2 parts
will be removed. Was something else being
https://github.com/DavidSpickett commented:
It's worth putting the PR into draft mode just to be extra clear this is a
request for early feedback.
This PR will be later split up of course, so very general comments from me.
Very impressive effort overall.
https://github.com/llvm/llvm-project/p
@@ -40,6 +40,113 @@ add_custom_target(lldb-sbapi-dwarf-enums
DEPENDS ${sb_languages_file})
set_target_properties(lldb-sbapi-dwarf-enums PROPERTIES FOLDER
"LLDB/Tablegenning")
+if(CMAKE_SYSTEM_NAME MATCHES "AIX")
+add_lldb_library(liblldb STATIC ${option_framework}
-
@@ -1510,6 +1510,18 @@ bool Module::SetLoadAddress(Target &target, lldb::addr_t
value,
return false;
}
+bool Module::SetLoadAddressByType(Target &target, lldb::addr_t value,
+bool value_is_offset, bool &changed, int type_id) {
+ ObjectFile *obje
@@ -342,7 +342,7 @@ uint32_t SBBreakpoint::GetIgnoreCount() const {
return count;
}
-void SBBreakpoint::SetThreadID(tid_t tid) {
+void SBBreakpoint::SetThreadID(lldb::tid_t tid) {
DavidSpickett wrote:
If these lldb:: are fixing compilation errors they would
@@ -0,0 +1,62 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,7 @@
+
+This product contains small piece of code to support AIX, taken from netbsd.
+
+ * LICENSE:
+* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License)
DavidSpickett wrote:
We'll need to confirm license compatibility for this.
htt
Author: Joel E. Denny
Date: 2024-08-09T10:41:42-04:00
New Revision: 3c639b83a6071d3e6ec9f44da7a7788165a65d45
URL:
https://github.com/llvm/llvm-project/commit/3c639b83a6071d3e6ec9f44da7a7788165a65d45
DIFF:
https://github.com/llvm/llvm-project/commit/3c639b83a6071d3e6ec9f44da7a7788165a65d45.diff
https://github.com/jdenny-ornl closed
https://github.com/llvm/llvm-project/pull/102483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,6 +67,10 @@ class RegisterContextUnwind : public
lldb_private::RegisterContext {
bool ReadPC(lldb::addr_t &start_pc);
+#ifdef __AIX__
+ bool ReadLR(lldb::addr_t &lr);
+#endif
+
DavidSpickett wrote:
It's likely we'd ask you to make this a method on
@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S,
CXXRecordDecl *Record) {
}
}
+bool EffectivelyConstexprDestructor = true;
+// Avoid triggering vtable instantiation due to a dtor that is not
+// "effectively constexpr" for better compa
jdenny-ornl wrote:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/102483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jcsxky wrote:
> Note that @jcsxky has a similar patch #102554 that fixes the same thing. I
> don't intend to contend against him, and admittedly, that patch works.
>
> But I don't think that approach is so reasonable because it is hacky in that
> `ForConstraintInstantiation` is disabled in the
@@ -0,0 +1,7 @@
+
+This product contains small piece of code to support AIX, taken from netbsd.
+
+ * LICENSE:
+* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License)
DavidSpickett wrote:
And if there is a way not to pull in this code, we're like
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/102619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -38,6 +38,10 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett wrote:
Also remember that users may be debugging AIX from a non-AIX host where the
compiler would
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/102601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> I think a default-error, sfinae-failing diagnostic should be pretty safe;
> everyone will get the correct diagnostics by default, and some narrow subset
> of people can disable them if they cause issues.
Clang community stance has consistently been that we have no interes
MitalAshok wrote:
Does this also fix #92486?
https://github.com/llvm/llvm-project/pull/102605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jdenny-ornl wrote:
> Possibly worth increasing it to a minute then,
Should we also land the env var? If so, I'll just extend this patch.
Either way, any objection to moving `[Default]SecondsToWait` into
executeToolChainProgram so we're maintaining it in just one place?
> this is basically j
Author: Yupei Liu
Date: 2024-08-09T23:13:11+08:00
New Revision: 52126dc72c3f6f4d27e3835b0ad53e162af25e53
URL:
https://github.com/llvm/llvm-project/commit/52126dc72c3f6f4d27e3835b0ad53e162af25e53
DIFF:
https://github.com/llvm/llvm-project/commit/52126dc72c3f6f4d27e3835b0ad53e162af25e53.diff
LOG
https://github.com/LYP951018 closed
https://github.com/llvm/llvm-project/pull/100766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25831,19 +25843,108 @@ TEST_F(FormatTest, RequiresClausesPositions) {
verifyFormat("template \n"
"int S::bar(T t) &&\n"
- "requires F {\n"
+ "requires F\n"
+ "{\n"
" return 5;\n"
"}
@@ -25831,19 +25843,108 @@ TEST_F(FormatTest, RequiresClausesPositions) {
verifyFormat("template \n"
"int S::bar(T t) &&\n"
- "requires F {\n"
+ "requires F\n"
+ "{\n"
" return 5;\n"
"}
@@ -5682,12 +5683,15 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
(Style.BreakTemplateDeclarations == FormatStyle::BTDS_Leave &&
Right.NewlinesBefore > 0);
}
- if (Left.ClosesRequiresClause && Right.isNot(tok::semi) &&
- Rig
LYP951018 wrote:
Thanks for the review ;)
https://github.com/llvm/llvm-project/pull/100766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -845,6 +845,12 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
if (SanOpts.has(SanitizerKind::ShadowCallStack))
Fn->addFnAttr(llvm::Attribute::ShadowCallStack);
+ if (SanOpts.has(SanitizerKind::Realtime)) {
+for (const FunctionEffectWithCon
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/102629
With the --force (or -f) option, git-clang-format wipes out input files
excluded by a .clang-format-ignore file if they have unstaged changes.
This patch adds a hidden clang-format option --list-ignored that lis
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
With the --force (or -f) option, git-clang-format wipes out input files
excluded by a .clang-format-ignore file if they have unstaged changes.
This patch adds a hidden clang-format option --list-ignored th
cor3ntin wrote:
So, friend functions do not increase the template depth?
That seems... weird!
https://github.com/llvm/llvm-project/pull/99813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Fznamznon wrote:
> Does this also fix #92486?
Yes, it does.
https://github.com/llvm/llvm-project/pull/102605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ameerj wrote:
Thanks for the review feedback @owenca @HazardyKnusperkeks
Please merge this PR for me if you feel it is ready as I don't have merge
permissions
https://github.com/llvm/llvm-project/pull/95013
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/102629
>From 9b71b289feb75cdc6d67a6ac696ff0ba7969549d Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 9 Aug 2024 08:15:43 -0700
Subject: [PATCH 1/2] [clang-format] Fix a serious bug in `git clang-format -f`
With the
@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S,
CXXRecordDecl *Record) {
}
}
+bool EffectivelyConstexprDestructor = true;
+// Avoid triggering vtable instantiation due to a dtor that is not
+// "effectively constexpr" for better compa
https://github.com/stuij commented:
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/101978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7042,12 +7042,38 @@ void Sema::CheckCompletedCXXClass(Scope *S,
CXXRecordDecl *Record) {
}
}
+bool EffectivelyConstexprDestructor = true;
+// Avoid triggering vtable instantiation due to a dtor that is not
+// "effectively constexpr" for better compa
AaronBallman wrote:
> I have relayed the comments internally and we are discussing it. I will let
> you know as soon as possible.
Thank you!
> No we were not aware of other use cases. But -Wunknown-pragmas=
> sounds like a good idea! Do you think this can be useful in other cases? How
> do w
AaronBallman wrote:
> > I'm wondering why the GNU-compatible behavior is not on by default,
> > especially when in GNU mode (e.g., `-std=gnu17`)?
>
> ATR-PASS-COMPLEX-IN-GPRS was missing in clang as shown in ABI doc :
> https://example61560.wordpress.com/wp-content/uploads/2016/11/powerpc_abi.
owenca wrote:
> Thanks for the review feedback @owenca @HazardyKnusperkeks Please merge this
> PR for me if you feel it is ready as I don't have merge permissions
I wonder if anyone can come up with a better name than `OnePerLine`. See
https://github.com/llvm/llvm-project/pull/101882#issuecomm
ahatanak wrote:
@rjmccall sent an RFC for upstreaming pointer authentication work to llvm-dev
in 2019, which mentions the `__ptrauth` qualifier.
https://discourse.llvm.org/t/rfc-pointer-authentication-for-arm64e/53433
I don't think we sent an RFC for adding support for the `__ptrauth` qualifie
Author: Daniel Kiss
Date: 2024-08-09T17:51:38+02:00
New Revision: 9e9fa00dcb9522db3f78d921eda6a18b9ee568bb
URL:
https://github.com/llvm/llvm-project/commit/9e9fa00dcb9522db3f78d921eda6a18b9ee568bb
DIFF:
https://github.com/llvm/llvm-project/commit/9e9fa00dcb9522db3f78d921eda6a18b9ee568bb.diff
L
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/101978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> > Possibly worth increasing it to a minute then,
>
> Should we also land the env var? If so, I'll just extend this patch.
>
> Either way, any objection to moving `[Default]SecondsToWait` into
> executeToolChainProgram so we're maintaining it in just one place?
>
> > this is b
101 - 200 of 418 matches
Mail list logo
