[clang] [Clang] Remove some dead code in getNumTeamsExprForTargetDirective (PR #95695)

2024-07-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/3353 Here is the relev

[clang] [clang][analyzer] MmapWriteExecChecker improvements (PR #97078)

2024-07-25 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/97078 From 1f04ce794a3aefc0f5622a9dea0a92a1e2b50be9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Tue, 25 Jun 2024 16:27:00 +0200 Subject: [PATCH 1/3] [clang][analyzer] MmapWriteExecChecker

[clang] [clang][analyzer] MmapWriteExecChecker improvements (PR #97078)

2024-07-25 Thread Balázs Kéri via cfe-commits
@@ -1,13 +1,14 @@ // RUN: %clang_analyze_cc1 -triple i686-unknown-linux -analyzer-checker=alpha.security.MmapWriteExec -analyzer-config alpha.security.MmapWriteExec:MmapProtExec=1 -analyzer-config alpha.security.MmapWriteExec:MmapProtRead=4 -DUSE_ALTERNATIVE_PROT_EXEC_DEFINIT

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-25 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] remove unneeded nullptr checks after dereference (PR #100489)

2024-07-25 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/100489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove some dead code in getNumTeamsExprForTargetDirective (PR #95695)

2024-07-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/1917 Here is the relevant piece of

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectField::IdentifierNamespace` (PR #100525)

2024-07-25 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis created https://github.com/llvm/llvm-project/pull/100525 There is a `IDNS_Ordinary` flag in `IndirectField::IdentifierNamespace` so that members in nested anonymous struct/union can be found as ordinary identifiers. ```c struct S { struct { int x; }; // Previous be

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectField::IdentifierNamespace` (PR #100525)

2024-07-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yanzuo Liu (zwuis) Changes There is a `IDNS_Ordinary` flag in `IndirectField::IdentifierNamespace` so that members in nested anonymous struct/union can be found as ordinary identifiers. ```c struct S { struct { int x; }; // Previous b

[clang] 693d757 - Internalize a clang Sarif function

2024-07-25 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-07-25T00:13:00-07:00 New Revision: 693d757b63e5020e0fa78bb71fc16acdad5f8232 URL: https://github.com/llvm/llvm-project/commit/693d757b63e5020e0fa78bb71fc16acdad5f8232 DIFF: https://github.com/llvm/llvm-project/commit/693d757b63e5020e0fa78bb71fc16acdad5f8232.diff

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-07-25 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/96171 >From 1df587efeb71fb1929667f008d7e9b251863d9d8 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Thu, 20 Jun 2024 21:43:31 +1100 Subject: [PATCH 1/5] [cmake] switch to CMake's native check_linker_flag, delet

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/100400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread Timm Baeder via cfe-commits
@@ -3593,8 +3593,14 @@ VarCreationState Compiler::visitDecl(const VarDecl *VD) { if (R.notCreated()) return R; - if (R) -return true; + if (R) { tbaederr wrote: Yes, remove it please. https://github.com/llvm/llvm-project/pull/100400

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. LGTM with the suggested changes. This might not be perfect wrt. revisiting `DecompositionDecl`s, but we can handle problems when they arise. https://github.com/llvm/llvm-project/pull/100400 ___ c

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread Timm Baeder via cfe-commits
@@ -5234,6 +5240,9 @@ bool Compiler::visitDeclRef(const ValueDecl *D, const Expr *E) { return false; }; +if (isa(VD)) tbaederr wrote: ```suggestion // DecompositionDecls are just proxies for us. if (isa(VD)) ``` http

[clang] [clang][analyzer] MmapWriteExecChecker improvements (PR #97078)

2024-07-25 Thread Balazs Benics via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: steakhal wrote: Please make sure that the premerge bots are happy before merging. https://github.com/llvm/llvm-project/pull/97078 ___ cfe-commits mailing

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM, thanks. https://github.com/llvm/llvm-project/pull/99564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-07-25 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/96171 >From 1df587efeb71fb1929667f008d7e9b251863d9d8 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Thu, 20 Jun 2024 21:43:31 +1100 Subject: [PATCH 1/6] [cmake] switch to CMake's native check_linker_flag, delet

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

2024-07-25 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: FWIW, in addition to `-c` in combination with `-fsyntax-only`, this now also warns for `-c` in combination with `-E`. That sounds like a reasonable thing to do to me, so it's probably fine, but it'd be nice to have that aspect acknowledged as one intended behaviour change as w

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-07-25 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. Wow, how can this ever have worked? Appears that the answer is that there simply aren't any existing callers of this constructor... In any case, thanks for the fix! https://github.com/llvm/llvm-project/pull/95697 _

[clang] [llvm] AMDGPU: Handle remote/fine-grained memory in atomicrmw fmin/fmax lowering (PR #96759)

2024-07-25 Thread Matt Arsenault via cfe-commits
arsenm wrote: ping in https://github.com/llvm/llvm-project/pull/96759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (PR #100525)

2024-07-25 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/100525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (PR #100525)

2024-07-25 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/100525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread Matt Arsenault via cfe-commits
@@ -692,23 +692,22 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, RValue Call = CGF.EmitCall(E->getCallee()->getType(), callee, E, ReturnValueSlot()); - // Check the supported intrinsic. + ASTContext &Context = CGF.getContext(); if

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread Matt Arsenault via cfe-commits
@@ -692,23 +692,22 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, RValue Call = CGF.EmitCall(E->getCallee()->getType(), callee, E, ReturnValueSlot()); - // Check the supported intrinsic. + ASTContext &Context = CGF.getContext(); if

[clang] d82df1b - [PS4/PS5][Driver] Always pass LTO options to the linker (#100423)

2024-07-25 Thread via cfe-commits
Author: Edd Dawson Date: 2024-07-25T09:43:17+01:00 New Revision: d82df1b891fecae0af7de5e970b592ce37178a30 URL: https://github.com/llvm/llvm-project/commit/d82df1b891fecae0af7de5e970b592ce37178a30 DIFF: https://github.com/llvm/llvm-project/commit/d82df1b891fecae0af7de5e970b592ce37178a30.diff LO

[clang] [PS4/PS5][Driver] Always pass LTO options to the linker (PR #100423)

2024-07-25 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/100423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4/PS5][Driver] Always pass LTO options to the linker (PR #100423)

2024-07-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/2206 Here is the relevant piece of the bu

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, nice improvement. https://github.com/llvm/llvm-project/pull/100405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/100405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Donát Nagy via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { NagyDonat wrote: I think this function could be useful for other checkers as well; consider moving this to a

[clang] 4ca1a90 - [clang][CUDA] Assume unknown emission status for skipped function definitions (#100124)

2024-07-25 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-07-25T11:21:18+02:00 New Revision: 4ca1a901dc6ca1926a594f57e6c4997ea9d185a4 URL: https://github.com/llvm/llvm-project/commit/4ca1a901dc6ca1926a594f57e6c4997ea9d185a4 DIFF: https://github.com/llvm/llvm-project/commit/4ca1a901dc6ca1926a594f57e6c4997ea9d185a4.dif

[clang] [clang][CUDA] Assume unknown emission status for skipped function definitions (PR #100124)

2024-07-25 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/100124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][VLS] Support RISCV VLS calling convention (PR #100346)

2024-07-25 Thread Brandon Wu via cfe-commits
@@ -608,6 +608,9 @@ class CGFunctionInfo final /// Log 2 of the maximum vector width. unsigned MaxVectorWidth : 4; + /// Log2 of ABI_VLEN used in RISCV VLS calling convention. + unsigned Log2RISCVABIVLen : 4; 4vtomat wrote: Yes, we need 5 bits, thanks f

[clang] [llvm] [RISCV][VLS] Support RISCV VLS calling convention (PR #100346)

2024-07-25 Thread Brandon Wu via cfe-commits
@@ -1333,6 +1333,15 @@ def Experimental : SubtargetFeature<"experimental", "HasExperimental", "true", "Experimental intrinsics">; +def FeatureABIVLen32B 4vtomat wrote: Yeah, that's a good idea since the backend doesn't use them~ http

[clang] 456c512 - [clang][Driver] Add cc1 flag for setting SkipFunctionBodies (#100135)

2024-07-25 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-07-25T11:27:14+02:00 New Revision: 456c5121f8e6f37881f236bdf573ef29cad5af1e URL: https://github.com/llvm/llvm-project/commit/456c5121f8e6f37881f236bdf573ef29cad5af1e DIFF: https://github.com/llvm/llvm-project/commit/456c5121f8e6f37881f236bdf573ef29cad5af1e.dif

[clang] [clang][Driver] Add flag for setting SkipFunctionBodies (PR #100135)

2024-07-25 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/100135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Enable config file options (PR #100343)

2024-07-25 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: /cherry-pick 8a77961 https://github.com/llvm/llvm-project/pull/100343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][VLS] Support RISCV VLS calling convention (PR #100346)

2024-07-25 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/100346 >From 15161b0b7637d52b6285624a4bf9f52a6664082c Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Sun, 21 Jul 2024 09:49:11 -0700 Subject: [PATCH 1/4] [RISCV][VLS] Support RISCV VLS calling convention This patch a

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-25 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: Given the growing number of OpenMP and/or "offloading" flags, I agree with @AnastasiaStulova that it would be good to clarify the overall goal/design. That's not clear to me. Is there are reference implementation that Flang is meant to follow? For example Clang or GFortra

[clang] Add _MM_FROUND_TO_NEAREST_TIES_EVEN to avx512fintrin.h (PR #99691)

2024-07-25 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: GCC thread (for reference): https://gcc.gnu.org/pipermail/gcc-patches/2024-July/657957.html https://github.com/llvm/llvm-project/pull/99691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][FMV][AArch64] Improve streaming mode compatibility. (PR #100181)

2024-07-25 Thread Sander de Smalen via cfe-commits
@@ -0,0 +1,46 @@ +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme -Waarch64-sme-attributes -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme -Waarch64-sme-attributes -fsyntax-only -verify=expected-cpp -x c++ %

[clang] [clang][ASTImporter][NFC] add unittests for unnamed EnumDecl (PR #100545)

2024-07-25 Thread Ding Fei via cfe-commits
https://github.com/danix800 created https://github.com/llvm/llvm-project/pull/100545 These tests are for multiple anonymous EnumDecls structural eq test & importing. We found the anonymous enums importing issue a few days ago and tried to fix it but 0a6233a68c7b575d05bca0f0c708b7e97cc710d1 alre

[clang] [clang][ASTImporter][NFC] add unittests for unnamed EnumDecl (PR #100545)

2024-07-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ding Fei (danix800) Changes These tests are for multiple anonymous EnumDecls structural eq test & importing. We found the anonymous enums importing issue a few days ago and tried to fix it but 0a6233a68c7b575d05bca0f0c708b7e97cc710d1 alre

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-25 Thread Anastasia Stulova via cfe-commits
AnastasiaStulova wrote: Adding ``--offload-target=`` seems like a good idea since it will be consistent with ``--target=``. One related question I have - does Flang compile for one offload model or can it mix those (let's say compile sources with mixed OpenACC and OpenMP pragmas)? If mixing i

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/100302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread Matt Arsenault via cfe-commits
@@ -692,23 +692,22 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, RValue Call = CGF.EmitCall(E->getCallee()->getType(), callee, E, ReturnValueSlot()); - // Check the supported intrinsic. + ASTContext &Context = CGF.getContext(); if

[clang] [Clang] Initializer list on RHS of assignment (PR #100548)

2024-07-25 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok created https://github.com/llvm/llvm-project/pull/100548 This implements [CWG2768](https://cplusplus.github.io/CWG/issues/2768.html). Also fixes a bug where `x op= {v}` was treated as `x op= v` for compound assignments, which shouldn't have happened. Fixes #10052

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-25 Thread Nikolas Klauser via cfe-commits
@@ -1599,13 +1599,66 @@ createTypePackElementParameterList(const ASTContext &C, DeclContext *DC) { nullptr); } +static TemplateParameterList *createCommonTypeList(const ASTContext &C, + D

[clang] [Clang] Initializer list on RHS of assignment (PR #100548)

2024-07-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mital Ashok (MitalAshok) Changes This implements [CWG2768](https://cplusplus.github.io/CWG/issues/2768.html). Also fixes a bug where `x op= {v}` was treated as `x op= v` for compound assignments, which shouldn't have happened. Fixes #100

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-25 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/99473 >From d6903daf0da6979822b8981ea3641455ff6d06f8 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 16 Jul 2024 14:48:10 +0200 Subject: [PATCH 1/2] [Clang] Add __common_type builtin --- clang/include/cl

[clang] [Clang] Initializer list on RHS of assignment (PR #100548)

2024-07-25 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/100548 >From 2c1d87c025a8caa818dd275560f31d0d4f8d64b8 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Thu, 25 Jul 2024 10:56:16 +0100 Subject: [PATCH] [Clang] Initializer list on RHS of assignment --- clang/docs/

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-25 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin If no further feedback is needed, could you please proceed with the merge? Thanks https://github.com/llvm/llvm-project/pull/97860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Balazs Benics via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { steakhal wrote: Makes sense. I think I'd prefer moving this utility in a followup patch, as it may take a wh

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/100405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/100400 >From 6ede7586fc4602ab15be59c58fe5f7181ffaca16 Mon Sep 17 00:00:00 2001 From: yronglin Date: Wed, 24 Jul 2024 23:12:27 +0800 Subject: [PATCH 1/2] [Clang][Interp] Fix handling of DecompositionDecl Signed-off-by

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread via cfe-commits
@@ -3593,8 +3593,14 @@ VarCreationState Compiler::visitDecl(const VarDecl *VD) { if (R.notCreated()) return R; - if (R) -return true; + if (R) { yronglin wrote: Removed. https://github.com/llvm/llvm-project/pull/100400 __

[clang] ca69444 - [Clang] Fix a variable shadowing in MapLattice (NFC) (#95697)

2024-07-25 Thread via cfe-commits
Author: Shivam Gupta Date: 2024-07-25T16:33:05+05:30 New Revision: ca69444cef0858ad4facecbfc2232a02422aca9f URL: https://github.com/llvm/llvm-project/commit/ca69444cef0858ad4facecbfc2232a02422aca9f DIFF: https://github.com/llvm/llvm-project/commit/ca69444cef0858ad4facecbfc2232a02422aca9f.diff

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-07-25 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/95697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-07-25 Thread Shivam Gupta via cfe-commits
xgupta wrote: Thanks for the review @martinboehme! https://github.com/llvm/llvm-project/pull/95697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add a test for #100095 (PR #100556)

2024-07-25 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh created https://github.com/llvm/llvm-project/pull/100556 The test is set to XFAIL with assertions enabled. >From 09cf032759b43e8a30720be9ef2f9caf13bcb0cb Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Thu, 25 Jul 2024 13:02:38 +0200 Subject: [PATCH] Add a t

[clang] Add a test for #100095 (PR #100556)

2024-07-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexander Kornienko (alexfh) Changes The test is set to XFAIL with assertions enabled. --- Full diff: https://github.com/llvm/llvm-project/pull/100556.diff 1 Files Affected: - (added) clang/test/SemaCXX/pr100095.cpp (+17) ``

[clang] Avoid accessing unset optional, workaround for #100095 (PR #100408)

2024-07-25 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > ... I'd like to see at least a test added to this PR. See #100556. The test would fail with assertions enabled (thus, marked XFAIL: asserts), and when compiled against hardened libc++ (e.g. libc++ built with `-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST`). https://gith

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread via cfe-commits
@@ -692,23 +692,22 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, RValue Call = CGF.EmitCall(E->getCallee()->getType(), callee, E, ReturnValueSlot()); - // Check the supported intrinsic. + ASTContext &Context = CGF.getContext(); if

[clang] [Clang] Fix a variable shadowing in MapLattice (NFC) (PR #95697)

2024-07-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/2624 Here is the

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-25 Thread A. Jiang via cfe-commits
@@ -1511,6 +1511,43 @@ Attributes (N2335) C2 ``#embed`` (N3017) C23 C89, C++ ===

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread via cfe-commits
@@ -692,23 +692,22 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, RValue Call = CGF.EmitCall(E->getCallee()->getType(), callee, E, ReturnValueSlot()); - // Check the supported intrinsic. + ASTContext &Context = CGF.getContext(); if

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-25 Thread via cfe-commits
https://github.com/vfdff edited https://github.com/llvm/llvm-project/pull/100302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Confirmed: reverting the change locally restores the builds, although I don't > yet see why. The fact that there's a missing symbol suggests the STL on the machine is not conforming... the symbol that's missing (`_ZNKSt8time_putIcSt19ostreambuf_iteratorIcSt11char_traits

[clang] f8006a5 - [analyzer][NFC] Add some docs for LazyCompoundValue (#97407)

2024-07-25 Thread via cfe-commits
Author: Kristóf Umann Date: 2024-07-25T13:26:59+02:00 New Revision: f8006a5932b1ccdf3a1eed7b20b5cb608c0a020c URL: https://github.com/llvm/llvm-project/commit/f8006a5932b1ccdf3a1eed7b20b5cb608c0a020c DIFF: https://github.com/llvm/llvm-project/commit/f8006a5932b1ccdf3a1eed7b20b5cb608c0a020c.diff

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-25 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/99473 >From d6903daf0da6979822b8981ea3641455ff6d06f8 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 16 Jul 2024 14:48:10 +0200 Subject: [PATCH 1/4] [Clang] Add __common_type builtin --- clang/include/cl

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-25 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/97407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-25 Thread Kristóf Umann via cfe-commits
Szelethus wrote: I decided to merge this. We are still miles ahead with these docs, and I don't wanna accidentally forget the PR. https://github.com/llvm/llvm-project/pull/97407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Aha! https://bugs.llvm.org/show_bug.cgi?id=33767 We have a mixture of both `std::tm` and `::tm` in here, try switching to using `::tm` and see if that helps. https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: We could probably also add something like `-Xarch_device_ ` in lieu of `-Xopenmp-target= ` since the `=` format isn't really standard in this area. https://github.com/llvm/llvm-project/pull/100152 ___ cfe-commits mailing list cfe-commi

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Donát Nagy via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { NagyDonat wrote: Of course, feel free to leave it for a followup patch. https://github.com/llvm/llvm-project

[clang] [ASTMatchers] Extend hasName matcher when matching templates (PR #100349)

2024-07-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/100349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 90929dd - [analyzer] Don't invalidate the super region when a std object ctor runs (#100405)

2024-07-25 Thread via cfe-commits
Author: Balazs Benics Date: 2024-07-25T13:43:47+02:00 New Revision: 90929dd97a8f2c00148bee676bf8b44bec063d9b URL: https://github.com/llvm/llvm-project/commit/90929dd97a8f2c00148bee676bf8b44bec063d9b DIFF: https://github.com/llvm/llvm-project/commit/90929dd97a8f2c00148bee676bf8b44bec063d9b.diff

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/100405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Interp] Visit `DecompositionDecl` and create a local variable (PR #100400)

2024-07-25 Thread via cfe-commits
https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/100400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 534e2dd - [Clang][Interp] Visit `DecompositionDecl` and create a local variable (#100400)

2024-07-25 Thread via cfe-commits
Author: yronglin Date: 2024-07-25T19:44:25+08:00 New Revision: 534e2dd29f252cc13b94312895d2f4b39b54b9d4 URL: https://github.com/llvm/llvm-project/commit/534e2dd29f252cc13b94312895d2f4b39b54b9d4 DIFF: https://github.com/llvm/llvm-project/commit/534e2dd29f252cc13b94312895d2f4b39b54b9d4.diff LOG:

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-25 Thread Rainer Orth via cfe-commits
rorth wrote: > Aha! > > https://bugs.llvm.org/show_bug.cgi?id=33767 Ah, old sins (from the GCC side no less) keep haunting me. > We have a mixture of both `std::tm` and `::tm` in here, try switching to > using `::tm` and see if that helps. Unfortunately not: I always get the undefined refere

[clang] [Clang][Sema] Improve support for explicit specializations of constrained member functions & member function templates (PR #88963)

2024-07-25 Thread Krystian Stasiowski via cfe-commits
@@ -10339,24 +10339,53 @@ Sema::CheckMemberSpecialization(NamedDecl *Member, LookupResult &Previous) { if (Previous.empty()) { // Nowhere to look anyway. } else if (FunctionDecl *Function = dyn_cast(Member)) { +SmallVector Candidates; +bool Ambiguous = false;

[clang] [ASTMatchers] Extend hasName matcher when matching templates (PR #100349)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Allow users to match all record instantiations by using <> as a wildcard. I think this will change the behavior of existing matchers, consider: ``` template struct S { Ty Val; void Call(); }; int main() { S<> s; s.Call(); // Currently matches only this S anothe

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-25 Thread Sergio Afonso via cfe-commits
https://github.com/skatrak updated https://github.com/llvm/llvm-project/pull/100152 >From cf26a318d3b49eb6217f29405cee9fd2c20f8e8a Mon Sep 17 00:00:00 2001 From: Sergio Afonso Date: Tue, 23 Jul 2024 16:19:55 +0100 Subject: [PATCH 1/4] [Flang][Driver] Introduce -fopenmp-targets offloading optio

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > We have a mixture of both `std::tm` and `::tm` in here, try switching to > > using `::tm` and see if that helps. > > Unfortunately not: I always get the undefined reference to the `std::tm const > *` version, no matter what I tried. Drat! If you dump the symbols from

[clang] [Clang] fix assertion failure in invalid delete operator declaration check (PR #99308)

2024-07-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! Thank you for the fix! https://github.com/llvm/llvm-project/pull/99308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix assertion failure in invalid delete operator declaration check (PR #99308)

2024-07-25 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman If no further feedback is needed, could you please proceed with the merge? Thanks https://github.com/llvm/llvm-project/pull/99308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang] fix assertion failure in invalid delete operator declaration check (PR #99308)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman If no further feedback is needed, could you please proceed with > the merge? Thanks Can do! Btw, you should feel free to obtain commit privileges yourself if you'd like: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access https://github.com/l

[clang] f916cb6 - [Clang] fix assertion failure in invalid delete operator declaration check (#99308)

2024-07-25 Thread via cfe-commits
Author: Oleksandr T. Date: 2024-07-25T08:08:18-04:00 New Revision: f916cb6184fb04b27ae7b867edcfd162c3a49694 URL: https://github.com/llvm/llvm-project/commit/f916cb6184fb04b27ae7b867edcfd162c3a49694 DIFF: https://github.com/llvm/llvm-project/commit/f916cb6184fb04b27ae7b867edcfd162c3a49694.diff

[clang] [Clang] fix assertion failure in invalid delete operator declaration check (PR #99308)

2024-07-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/99308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix assertion failure in invalid delete operator declaration check (PR #99308)

2024-07-25 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman Thanks https://github.com/llvm/llvm-project/pull/99308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Should we prefix this with `__builtin_` as mentioned in https://github.com/llvm/llvm-project/issues/98310#issuecomment-2221105713 ? https://github.com/llvm/llvm-project/pull/99473 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-25 Thread Rainer Orth via cfe-commits
rorth wrote: > If you dump the symbols from the STL shared library on the system, is there > one for `time_put` at all? If so, what is the mangled symbol it exports? While the source requires ``` _ZNKSt8time_putIcSt19ostreambuf_iteratorIcSt11char_traitsIcEEE3putES3_RSt8ios_basecPKSt2tmPKcSB_ s

[clang] [Clang] fix assertion failure in invalid delete operator declaration check (PR #99308)

2024-07-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/2579 Here is the relevant piece of the build log for

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Blech, thank you for trying! I guess that unless there's some way to hide this ugliness in the cmake scripts or someone else has better ideas to try, the `asm` aliasing (on Solaris only) may be our best path forward. https://github.com/llvm/llvm-project/pull/99075 _

[clang] [Clang] Fix confusing diagnositcs related to explicit this parameters (PR #100351)

2024-07-25 Thread Braden Helmer via cfe-commits
https://github.com/bradenhelmer updated https://github.com/llvm/llvm-project/pull/100351 >From 4e0845195d6593b907bbf65d436ededee9c2aacd Mon Sep 17 00:00:00 2001 From: Braden Helmer Date: Tue, 23 Jul 2024 11:04:06 -0400 Subject: [PATCH] Fixed confusing diagnostics / add release notes --- clang

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-07-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the diagnostic improvement! https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-07-25 Thread Aaron Ballman via cfe-commits
@@ -76,10 +76,33 @@ struct S { struct SVS : public VS { void vm() { } }; + + struct CS { AaronBallman wrote: When switching the diagnostic approach, be sure to add test coverage for unused copy/move constructors, copy/move assignment, and destructors

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-07-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-07-25 Thread Aaron Ballman via cfe-commits
@@ -402,7 +402,7 @@ def warn_unused_function : Warning<"unused function %0">, InGroup, DefaultIgnore; def warn_unused_template : Warning<"unused %select{function|variable}0 template %1">, InGroup, DefaultIgnore; -def warn_unused_member_function : Warning<"unused member fun

  1   2   3   4   >