[clang] [llvm] [LoongArch] Support la664 (PR #100068)

2024-07-23 Thread via cfe-commits
https://github.com/Ami-zhang updated https://github.com/llvm/llvm-project/pull/100068 >From 97051ad2c670bb0b8ae2160b032b7ab95a7b43ea Mon Sep 17 00:00:00 2001 From: Ami-zhang Date: Mon, 29 Apr 2024 16:58:15 +0800 Subject: [PATCH] [LoongArch] Support la664 A new ProcessorModel called `la664` is

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/99898 >From 7862d7e5fc63749f68bfdc0f0d8c226d341c55e1 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 22 Jul 2024 17:58:05 +0100 Subject: [PATCH 1/3] [RISCV] Mark zacas as experimental again due to unresolved ABI is

[clang] 70e7d26 - [RISCV] Mark zacas as experimental again due to unresolved ABI issue (#99898)

2024-07-23 Thread via cfe-commits
Author: Alex Bradbury Date: 2024-07-23T08:06:15+01:00 New Revision: 70e7d26e560173c8b9db4c75ab4a3004cd5f021a URL: https://github.com/llvm/llvm-project/commit/70e7d26e560173c8b9db4c75ab4a3004cd5f021a DIFF: https://github.com/llvm/llvm-project/commit/70e7d26e560173c8b9db4c75ab4a3004cd5f021a.diff

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/99898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LoongArch] Support la664 (PR #100068)

2024-07-23 Thread via cfe-commits
https://github.com/Ami-zhang updated https://github.com/llvm/llvm-project/pull/100068 >From b88d699f9a8877d77af0a87d4955af40420142ee Mon Sep 17 00:00:00 2001 From: Ami-zhang Date: Mon, 29 Apr 2024 16:58:15 +0800 Subject: [PATCH] [LoongArch] Support la664 A new ProcessorModel called `la664` is

[clang] fcec298 - [LoongArch] Support la664 (#100068)

2024-07-23 Thread via cfe-commits
Author: Ami-zhang Date: 2024-07-23T15:14:20+08:00 New Revision: fcec298087dba0c83f6d0bbafd6cd934c42cbf82 URL: https://github.com/llvm/llvm-project/commit/fcec298087dba0c83f6d0bbafd6cd934c42cbf82 DIFF: https://github.com/llvm/llvm-project/commit/fcec298087dba0c83f6d0bbafd6cd934c42cbf82.diff LOG

[clang] [llvm] [LoongArch] Support la664 (PR #100068)

2024-07-23 Thread Lu Weining via cfe-commits
https://github.com/SixWeining closed https://github.com/llvm/llvm-project/pull/100068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8a615bc - [LoongArch] Summary the release notes for LLVM 19

2024-07-23 Thread Weining Lu via cfe-commits
Author: Weining Lu Date: 2024-07-23T15:19:07+08:00 New Revision: 8a615bcf2f8c8140c6eadae964c8ea7fb4cfee33 URL: https://github.com/llvm/llvm-project/commit/8a615bcf2f8c8140c6eadae964c8ea7fb4cfee33 DIFF: https://github.com/llvm/llvm-project/commit/8a615bcf2f8c8140c6eadae964c8ea7fb4cfee33.diff LO

[clang-tools-extra] 2dd82c5 - [clang-tidy][NFC] Added -fexceptions to const-correctness-values.cp

2024-07-23 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2024-07-23T07:38:49Z New Revision: 2dd82c5ac56623d38de977ef027b252b4908e4c5 URL: https://github.com/llvm/llvm-project/commit/2dd82c5ac56623d38de977ef027b252b4908e4c5 DIFF: https://github.com/llvm/llvm-project/commit/2dd82c5ac56623d38de977ef027b252b4908e4c5.diff LOG: [

[clang-tools-extra] 26c99c4 - [clang-tidy] fix misc-const-correctness to work with function-try-blocks (#99925)

2024-07-23 Thread Piotr Zegar via cfe-commits
Author: Thomas Schenker Date: 2024-07-23T07:38:49Z New Revision: 26c99c421794902b0d929fd9eff81314da55675c URL: https://github.com/llvm/llvm-project/commit/26c99c421794902b0d929fd9eff81314da55675c DIFF: https://github.com/llvm/llvm-project/commit/26c99c421794902b0d929fd9eff81314da55675c.diff LO

[clang] 6db5f4f - [Clang] Ignore empty FieldDecls when asking for the field number (#100040)

2024-07-23 Thread via cfe-commits
Author: Bill Wendling Date: 2024-07-23T00:49:46-07:00 New Revision: 6db5f4fd2a287de9d20adc7a44cfcc66fc462c9c URL: https://github.com/llvm/llvm-project/commit/6db5f4fd2a287de9d20adc7a44cfcc66fc462c9c DIFF: https://github.com/llvm/llvm-project/commit/6db5f4fd2a287de9d20adc7a44cfcc66fc462c9c.diff

[clang] [Clang] Ignore empty FieldDecls when asking for the field number (PR #100040)

2024-07-23 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/100040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0998e3c - [clang] Add method 'backupStr' to ASTContext (#99417)

2024-07-23 Thread via cfe-commits
Author: Youngsuk Kim Date: 2024-07-23T04:13:04-04:00 New Revision: 0998e3c4e66ded6e42b8ce162748df05b5ddb627 URL: https://github.com/llvm/llvm-project/commit/0998e3c4e66ded6e42b8ce162748df05b5ddb627 DIFF: https://github.com/llvm/llvm-project/commit/0998e3c4e66ded6e42b8ce162748df05b5ddb627.diff

[clang] [clang] Add method 'backupStr' to ASTContext (PR #99417)

2024-07-23 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/99417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Allow non-literal types in C++23 (PR #100062)

2024-07-23 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM Considering that the literal type requirement was quite literally just straight-up removed in C++23, returning early here is basically just doing what the standard did, so this change makes sense to me. Also, one option would be to

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

2024-07-23 Thread via cfe-commits
@@ -1721,11 +1723,15 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { Diag(Tok.getLocation(), diag::warn_pp_date_time); // MSVC, ICC, GCC, VisualAge C++ extension. The generated string should be // of the form "Ddd Mmm dd hh::mm::ss ", which is returned b

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

2024-07-23 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/99075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Model builtin-like functions as builtin functions (PR #99886)

2024-07-23 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: LGTM. https://github.com/llvm/llvm-project/pull/99886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-07-23 Thread via cfe-commits
@@ -124,7 +124,7 @@ NamedDecl *Parser::ParseCXXInlineMethodDef( ? diag::warn_cxx98_compat_defaulted_deleted_function : diag::ext_defaulted_deleted_function) << 0 /* defaulted */; - Actions.SetDeclDefaulted(FnD, KWLoc); +

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-07-23 Thread via cfe-commits
@@ -15,3 +32,9 @@ bool operator==(const Foo &, const Foo &) = default; // expected-warning {{comp // Declare the defaulted comparison function as a non-member function. Arguments are passed by value. bool operator==(Foo, Foo) = default; // expected-warning {{comparing floa

[clang] Template Diagnostic Improvements (PR #99933)

2024-07-23 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

2024-07-23 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @ilya-biryukov I'm a bit torn about how we would proceed: if Corentin insists on the current (which my patch continues the effort) implementation, do you think it feasible for me to merge part of your codes (specifically, the way we propagate up unexpanded flags for lambda bodie

[clang] Template Diagnostic Improvements (PR #99933)

2024-07-23 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Allow non-literal types in C++23 (PR #100062)

2024-07-23 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/100062 >From 18a4a08009ecd8e5a557d77028fc4efdbf5901ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 23 Jul 2024 07:02:23 +0200 Subject: [PAT

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-07-23 Thread via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= , =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= , =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: @@ -0,0 +1,125 @@ +//===--- TaggedUnionMemberCountCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, und

[clang] [PS5] Adopt new compiler-rt naming scheme for the profile library. (PR #99862)

2024-07-23 Thread via cfe-commits
https://github.com/goussepi updated https://github.com/llvm/llvm-project/pull/99862 >From f2bbdbd5507f5d29e2d0877df135bf1f28bf753b Mon Sep 17 00:00:00 2001 From: Pierre Gousseau Date: Mon, 22 Jul 2024 10:49:08 + Subject: [PATCH] [PS5] Adopt new compiler-rt naming scheme for the profile lib

[clang] b5fb7b2 - [PS5] Adopt new compiler-rt naming scheme for the profile library. (#99862)

2024-07-23 Thread via cfe-commits
Author: goussepi Date: 2024-07-23T10:08:40+01:00 New Revision: b5fb7b209085acdb33748ab4fe33cbfbdbfeeddf URL: https://github.com/llvm/llvm-project/commit/b5fb7b209085acdb33748ab4fe33cbfbdbfeeddf DIFF: https://github.com/llvm/llvm-project/commit/b5fb7b209085acdb33748ab4fe33cbfbdbfeeddf.diff LOG:

[clang] [PS5] Adopt new compiler-rt naming scheme for the profile library. (PR #99862)

2024-07-23 Thread via cfe-commits
https://github.com/goussepi closed https://github.com/llvm/llvm-project/pull/99862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/100085 'fopen' should return a new FILE handle, thus we should assume it can't alias with commonly used FILE handles, such as with 'stdin', 'stdout' or 'stderr'. This problem appears in code that handles either some

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Balazs Benics via cfe-commits
steakhal wrote: I didn't mention this in the release notes as I don't think it's that impactful. https://github.com/llvm/llvm-project/pull/100085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes 'fopen' should return a new FILE handle, thus we should assume it can't alias with commonly used FILE handles, such as with 'stdin', 'stdout' or 'stderr'. This problem appears in code tha

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/100085 >From c8148c88a39434501b9dacb374b3ca9d81ee8fdf Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Tue, 23 Jul 2024 08:55:16 +0200 Subject: [PATCH 1/2] [analyzer] Assume the result of 'fopen' can't alias with '

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread via cfe-commits
@@ -61,27 +61,43 @@ TemplateParameterList::TemplateParameterList(const ASTContext& C, bool IsPack = P->isTemplateParameterPack(); if (const auto *NTTP = dyn_cast(P)) { - if (!IsPack && NTTP->getType()->containsUnexpandedParameterPack()) -ContainsUnexpande

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread via cfe-commits
@@ -61,27 +61,43 @@ TemplateParameterList::TemplateParameterList(const ASTContext& C, bool IsPack = P->isTemplateParameterPack(); if (const auto *NTTP = dyn_cast(P)) { - if (!IsPack && NTTP->getType()->containsUnexpandedParameterPack()) -ContainsUnexpande

[clang] Diag mismatch 97878 (PR #99824)

2024-07-23 Thread via cfe-commits
cor3ntin wrote: Thanks a lot of this fix, I think this makes sense. Can you: - Update the title of the PR to be more descriptive - Add a release note? (`clang/docs/ReleaseNotes.rst`) Thanks! https://github.com/llvm/llvm-project/pull/99824 ___ cfe-co

[clang] [Clang][Interp] `__builtin_os_log_format_buffer_size` should be an unevaluated builtin (PR #99895)

2024-07-23 Thread Mitch Phillips via cfe-commits
hctim wrote: Hi, Unfortunately this patch appears to have introduced a memory leak that was detected by the sanitizer buildbots (https://lab.llvm.org/buildbot/#/builders/52/builds/1079). The issue can be reproduced with a minimal ASan build configuration, like: ``` $ cmake \ -DCMAKE_C_COMPIL

[clang] 5f05d5e - Revert "[Clang][Interp] `__builtin_os_log_format_buffer_size` should be an unevaluated builtin (#99895)"

2024-07-23 Thread Mitch Phillips via cfe-commits
Author: Mitch Phillips Date: 2024-07-23T11:23:53+02:00 New Revision: 5f05d5ec8f9bb15c0ac29fce843a2c73165ac414 URL: https://github.com/llvm/llvm-project/commit/5f05d5ec8f9bb15c0ac29fce843a2c73165ac414 DIFF: https://github.com/llvm/llvm-project/commit/5f05d5ec8f9bb15c0ac29fce843a2c73165ac414.diff

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-07-23 Thread Kristóf Umann via cfe-commits
@@ -0,0 +1,125 @@ +//===--- TaggedUnionMemberCountCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-07-23 Thread Kristóf Umann via cfe-commits
@@ -0,0 +1,182 @@ +//===--- TaggedUnionMemberCountCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][CodeGen] Don't crash on output whose size is zero. (PR #99849)

2024-07-23 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/99849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Don't use canonical type when checking dependence in Type::isOverloadable (PR #98563)

2024-07-23 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/98563 >From 5cefddec13ca2bafb58a6f714fd2bef435166c8d Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 11 Jul 2024 18:28:50 -0400 Subject: [PATCH 1/2] [Clang][AST] Don't use canonical type when checking

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-07-23 Thread via cfe-commits
@@ -124,7 +124,7 @@ NamedDecl *Parser::ParseCXXInlineMethodDef( ? diag::warn_cxx98_compat_defaulted_deleted_function : diag::ext_defaulted_deleted_function) << 0 /* defaulted */; - Actions.SetDeclDefaulted(FnD, KWLoc); +

[clang-tools-extra] dd23b34 - [clang-tidy][performance-unnecessary-value-param] Make `handleMoveFix` virtual (#99867)

2024-07-23 Thread via cfe-commits
Author: Clement Courbet Date: 2024-07-23T11:32:26+02:00 New Revision: dd23b347890512ee82741648e941df24e1d666ee URL: https://github.com/llvm/llvm-project/commit/dd23b347890512ee82741648e941df24e1d666ee DIFF: https://github.com/llvm/llvm-project/commit/dd23b347890512ee82741648e941df24e1d666ee.dif

[clang-tools-extra] [clang-tidy][performance-unnecessary-value-param] Make `handleMoveFix` virtual (PR #99867)

2024-07-23 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/99867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Model builtin-like functions as builtin functions (PR #99886)

2024-07-23 Thread Donát Nagy via cfe-commits
@@ -570,13 +570,8 @@ void differentBranchesTest(int i) { { A a; a.foo() > 0 ? a.foo() : A(std::move(a)).foo(); -#ifdef DFS -// peaceful-note@-2 {{Assuming the condition is false}} -// peaceful-note@-3 {{'?' condition is false}} -#else -// peaceful-note@-5

[clang] [Driver] Have getTargetSubDirPath better match get_compiler_rt_target (PR #100091)

2024-07-23 Thread Rainer Orth via cfe-commits
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/100091 As explained in [[Driver] Support non-canonical triples with new runtime lib layout](https://reviews.llvm.org/D133407), there are massive problems if `clang`'s and `compiler-rt`'s ideas of the target triple don't

[clang] [Driver] Have getTargetSubDirPath better match get_compiler_rt_target (PR #100091)

2024-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rainer Orth (rorth) Changes As explained in [[Driver] Support non-canonical triples with new runtime lib layout](https://reviews.llvm.org/D133407), there are massive problems if `clang`'s and `compiler-rt`'s ideas of the target triple don

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-07-23 Thread via cfe-commits
https://github.com/ofAlpaca updated https://github.com/llvm/llvm-project/pull/99542 >From 2a381b47002db3c7a119a893c1a70e0b1604151f Mon Sep 17 00:00:00 2001 From: schiang Date: Thu, 18 Jul 2024 09:53:35 +0800 Subject: [PATCH 1/4] Pass 'Scope *' for 'SetDeclDefaulted()' and related utlis --- cl

[clang] [Clang][AST] Don't use canonical type when checking dependence in Type::isOverloadable (PR #98563)

2024-07-23 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, modulo - missing release note - can you move the test in a GH97646 namespace and put it in `decltype.cpp`, or rename `typeof_unqual.cpp` to typeof.cpp and put it there? Maybe, while you are at it, add a test for `__typeof_unqual`

[clang] [Clang][CodeGen] Add metadata for load from reference (PR #98746)

2024-07-23 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Compile-time impact: http://llvm-compile-time-tracker.com/compare.php?from=f0fad9f3e00dbe8e58024d1c98e36b7b9b1b17a9&to=f01369d38b67364b5c35bf87984f813a53ce18d1&stat=instructions%3Au https://github.com/llvm/llvm-project/pull/98746 ___ cf

[clang] f18dd9e - Reapply "[Clang][Interp] `__builtin_os_log_format_buffer_size` should be an unevaluated builtin (#99895)"

2024-07-23 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-23T11:57:40+02:00 New Revision: f18dd9edec9c2135a8906d795258a8c5a24f74f3 URL: https://github.com/llvm/llvm-project/commit/f18dd9edec9c2135a8906d795258a8c5a24f74f3 DIFF: https://github.com/llvm/llvm-project/commit/f18dd9edec9c2135a8906d795258a8c5a24f74f3.diff LO

[clang-tools-extra] Draft: Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-23 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/99917 >From e71d153d953f1e30f7480973bcae2a16bf51711f Mon Sep 17 00:00:00 2001 From: Nathan James Date: Tue, 23 Jul 2024 10:59:45 +0100 Subject: [PATCH] Create a new check to look for mis-use in calls that take iterat

[clang-tools-extra] Draft: Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-23 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/99917 >From 7be8e9d71b61ae669fc80e1dd0eef5e963b1d20c Mon Sep 17 00:00:00 2001 From: Nathan James Date: Tue, 23 Jul 2024 10:59:45 +0100 Subject: [PATCH] Create a new check to look for mis-use in calls that take iterat

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -1599,13 +1599,66 @@ createTypePackElementParameterList(const ASTContext &C, DeclContext *DC) { nullptr); } +static TemplateParameterList *createCommonTypeList(const ASTContext &C, + D

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
https://github.com/Sirraide commented: Overall, the implementation seems fine. Do we want a release note for this since it’s supposed to be an internal thing? CC @AaronBallman Also, some documentation *somewhere* as to what this builtin does would be nice, even if it’s just in a comment som

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/99473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -1599,13 +1599,66 @@ createTypePackElementParameterList(const ASTContext &C, DeclContext *DC) { nullptr); } +static TemplateParameterList *createCommonTypeList(const ASTContext &C, + D

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -6844,6 +6844,14 @@ CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { return Results; } +QualType Sema::getTypeMember(StringRef Name, QualType Type) { Sirraide wrote: ```suggestion QualType Sema::getTypeMember(QualType Type, StringRef Name)

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -932,6 +932,10 @@ bool Sema::LookupBuiltin(LookupResult &R) { R.addDecl(getASTContext().getTypePackElementDecl()); return true; } +if (II == getASTContext().getCommonTypeName()) { + R.addDecl(getASTContext().getCommonTypeDecl());

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -2282,6 +2282,10 @@ class Sema final : public SemaBase { /// Check to see if a given expression could have '.c_str()' called on it. bool hasCStrMethod(const Expr *E); + // Check whether a type member 'Type::Name' exists, and if yes, return the + // type. If there is n

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -1599,13 +1599,66 @@ createTypePackElementParameterList(const ASTContext &C, DeclContext *DC) { nullptr); } +static TemplateParameterList *createCommonTypeList(const ASTContext &C, + D

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static std::optional commonTypeImpl(Sema &S, + TemplateName BaseTemplate, + SourceLocation TemplateLoc

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

2024-07-23 Thread via cfe-commits
@@ -6844,6 +6844,14 @@ CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { return Results; } +QualType Sema::getTypeMember(StringRef Name, QualType Type) { Sirraide wrote: Also, `SemaChecking` is for ‘extra semantic checking’. It feels a bit weir

[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-23 Thread Nathan James via cfe-commits
https://github.com/njames93 edited https://github.com/llvm/llvm-project/pull/99917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-23 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/99917 >From 1b91c22714179e44cc494b6a7adcde2f4b6bc6d6 Mon Sep 17 00:00:00 2001 From: Nathan James Date: Tue, 23 Jul 2024 10:59:45 +0100 Subject: [PATCH] Create a new check to look for mis-use in calls that take iterat

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-23 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @KyunLFA Could you send the commit hash of the clang build which you're using? I'm unable to reproduce. https://github.com/llvm/llvm-project/pull/98547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-23 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > This seems to break tests on my Windows box: > http://45.33.8.238/win/91548/step_6.txt This is the failed test: ``` c:\src\llvm-project\out\gn\bin\clang.exe -Ofast -O2 -### -Werror C:\src\llvm-project\clang\test\Driver\Ofast.c 2>&1 | c:\src\llvm-project\out\gn\bin\filecheck.e

[clang] 363e036 - [AST] NFC: add an assertion for invariant of CXXFoldExpr

2024-07-23 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2024-07-23T12:28:59+02:00 New Revision: 363e036ac002d5af4bb82e303052b806a98086a1 URL: https://github.com/llvm/llvm-project/commit/363e036ac002d5af4bb82e303052b806a98086a1 DIFF: https://github.com/llvm/llvm-project/commit/363e036ac002d5af4bb82e303052b806a98086a1.diff

[clang] [clang][ExprConst] Allow non-literal types in C++23 (PR #100062)

2024-07-23 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/100062 >From 695dff600a78e62ec65a964f80438661bd7a522c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 23 Jul 2024 07:02:23 +0200 Subject: [PAT

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-07-23 Thread Vlad Serebrennikov via cfe-commits
@@ -4856,7 +4856,7 @@ bool TemplateDeclInstantiator::SubstDefaultedFunction(FunctionDecl *New, : DFI); } - SemaRef.SetDeclDefaulted(New, Tmpl->getLocation()); + SemaRef.SetDeclDefaulted(nullptr, New, Tmpl->getLocation()); Endilll wrote:

[clang] [clang][analyzer] Support `ownership_{returns,takes}` attributes (PR #98941)

2024-07-23 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/98941 >From c1746eec0e985bb394ecd604129cd0c30d5c66ca Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Wed, 17 Jul 2024 16:41:20 +0300 Subject: [PATCH 1/9] clang/sema: disallow more than one 'onweship_takes' with di

[clang] [clang][analyzer] Support `ownership_{returns,takes}` attributes (PR #98941)

2024-07-23 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: Rebased on top of d89f3e8df3160b3afc07bc742c81aa4738ea9646 https://github.com/llvm/llvm-project/pull/98941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-23 Thread Nathan James via cfe-commits
https://github.com/njames93 edited https://github.com/llvm/llvm-project/pull/99917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/100085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, this is a nice improvement. I vaguely recall that a few months ago somebody else on our team had trouble with false positives similar false positives, so it's good to see that these will be fixed. https://github.com/llvm/llvm-proje

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Donát Nagy via cfe-commits
@@ -451,6 +462,10 @@ class StreamChecker : public Checker` In your code the three standard streams have exactly identical roles (as far as I see), and I think it would be good to emphasize this by storing them in a three-element array instead of three separate independently name

[clang] [clang][ASTImporter] Fix import of template parameter default values. (PR #100100)

2024-07-23 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/100100 Default values of template parameters (non-type, type, template) were not correctly handled in the "inherited" case. This occurs if the first declaration contains the default value but a next one not. The defa

[clang] [clang][ASTImporter] Fix import of template parameter default values. (PR #100100)

2024-07-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes Default values of template parameters (non-type, type, template) were not correctly handled in the "inherited" case. This occurs if the first declaration contains the default value but a next one not. The de

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-07-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: FYI, as a headsup - I've bisected a regression down to this PR/commit. Before this change, all libcxx tests pass on Windows/armv7, but after this change, a bunch of coroutine tests fail on this target - see https://github.com/llvm/llvm-project/issues/100101. https://github.com

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/99880 >From ad2d2f42282d5493761fa0af13b77dc7aab73bba Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Mon, 22 Jul 2024 15:19:07 +0200 Subject: [PATCH 1/2] [Sema] Default arguments for template parameters affect

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-23 Thread Mehdi Amini via cfe-commits
joker-eph wrote: It seems that this broke the CI: https://lab.llvm.org/buildbot/#/builders/153/builds/3898 https://github.com/llvm/llvm-project/pull/99898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] Template Diagnostic Improvements (PR #99933)

2024-07-23 Thread Braden Helmer via cfe-commits
bradenhelmer wrote: I don't have write access, if someone could merge that would be great! https://github.com/llvm/llvm-project/pull/99933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 363e036ac002d5af4bb82e303052b806a98086a1 34a18e0c78c2915df201aea368f6c2763f885fbe --e

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread Ilya Biryukov via cfe-commits
@@ -61,27 +61,43 @@ TemplateParameterList::TemplateParameterList(const ASTContext& C, bool IsPack = P->isTemplateParameterPack(); if (const auto *NTTP = dyn_cast(P)) { - if (!IsPack && NTTP->getType()->containsUnexpandedParameterPack()) -ContainsUnexpande

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread Ilya Biryukov via cfe-commits
@@ -61,27 +61,43 @@ TemplateParameterList::TemplateParameterList(const ASTContext& C, bool IsPack = P->isTemplateParameterPack(); if (const auto *NTTP = dyn_cast(P)) { - if (!IsPack && NTTP->getType()->containsUnexpandedParameterPack()) -ContainsUnexpande

[clang] [Clang] Fix confusing diagnostic with explicit 'this' parameters. (PR #99824)

2024-07-23 Thread Braden Helmer via cfe-commits
https://github.com/bradenhelmer edited https://github.com/llvm/llvm-project/pull/99824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Default arguments for template parameters affect ContainsUnexpandedPacks (PR #99880)

2024-07-23 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov updated https://github.com/llvm/llvm-project/pull/99880 >From ad2d2f42282d5493761fa0af13b77dc7aab73bba Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Mon, 22 Jul 2024 15:19:07 +0200 Subject: [PATCH 1/3] [Sema] Default arguments for template parameters affect

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

2024-07-23 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand approved this pull request. LGTM now, thanks! https://github.com/llvm/llvm-project/pull/91384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix confusing diagnostic with explicit 'this' parameters. (PR #99824)

2024-07-23 Thread Braden Helmer via cfe-commits
https://github.com/bradenhelmer updated https://github.com/llvm/llvm-project/pull/99824 >From e4c3701ea6be894b1094f45d0590c61e5aa44897 Mon Sep 17 00:00:00 2001 From: Braden Helmer Date: Sun, 21 Jul 2024 14:10:17 -0400 Subject: [PATCH 1/3] Fix diag mismatch --- clang/lib/Sema/SemaOverload.cpp

[clang] [Sema] Fix computations of "unexpanded packs" in substituted lambdas (PR #99882)

2024-07-23 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > @ilya-biryukov I'm a bit torn about how we would proceed: if Corentin insists > on the current (which my patch continues the effort) implementation, do you > think it feasible for me to merge part of your codes (specifically, the way > we propagate up unexpanded flags fo

[clang] 20d7fff - [clang][Interp] Fix atomic builtins with integral pointers

2024-07-23 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-23T13:15:32+02:00 New Revision: 20d7fff5eaaa9d78807035d63e5c503bfc1b497e URL: https://github.com/llvm/llvm-project/commit/20d7fff5eaaa9d78807035d63e5c503bfc1b497e DIFF: https://github.com/llvm/llvm-project/commit/20d7fff5eaaa9d78807035d63e5c503bfc1b497e.diff LO

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-23 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/96364 >From 0d0a1e242db6a117ffb37ab4ce3d72e6adf26a2e Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 12 Jun 2024 14:14:26 -0400 Subject: [PATCH 1/6] [Clang][Parse] Fix ambiguity with nested-name-specif

[clang] [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (PR #100085)

2024-07-23 Thread Balazs Benics via cfe-commits
@@ -451,6 +462,10 @@ class StreamChecker : public Checker StdFileStreamDecls = {}; void evalFopen(const FnDescription *Desc, const CallEvent &Call, CheckerContext &C) const; @@ -919,9 +918,8 @@ ProgramStateRef StreamChecker::assumeNoAliasingWithStdStreams(

[clang] b60fec2 - [analyzer] Assume the result of 'fopen' can't alias with 'std{in,out,err}' (#100085)

2024-07-23 Thread via cfe-commits
Author: Balazs Benics Date: 2024-07-23T13:22:58+02:00 New Revision: b60fec27fd1bbab8c2c7a77b4be7836a1beb326f URL: https://github.com/llvm/llvm-project/commit/b60fec27fd1bbab8c2c7a77b4be7836a1beb326f DIFF: https://github.com/llvm/llvm-project/commit/b60fec27fd1bbab8c2c7a77b4be7836a1beb326f.diff

  1   2   3   4   5   6   >