[clang] [clang][test] Split AArch64 target feature checks across multiple lines. NFC (PR #99365)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jon Roelofs (jroelofs) Changes Whenever these tests change, it's difficult to see why they don't match, and the diff after you've fixed them isn't easy to grok. By splitting them with a sed pipe, we fix both issues simultaneously. ---

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -3742,6 +3751,124 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + // Given two shadows ..., ..., return the interleaved value + // ABABABAB ... + // + // Width == number of elements in A == number of elements in B + Val

[clang] [APINotes] Reduce memory footprint for Obj-C/C++ contexts (PR #99358)

2024-07-17 Thread Saleem Abdulrasool via cfe-commits
@@ -286,6 +280,31 @@ inline bool operator==(const ContextTableKey &lhs, const ContextTableKey &rhs) { lhs.contextKind == rhs.contextKind && lhs.contextID == rhs.contextID; } +/// A stored Objective-C or C++ declaration, represented by the ID of its parent +/// conte

[clang] [APINotes] Reduce memory footprint for Obj-C/C++ contexts (PR #99358)

2024-07-17 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. Interesting that we haven't had issues with storing the context kind instead of the decl kind. Perhaps that was not being used? https://github.com/llvm/llvm-project/pull/99358 ___ cfe-commits mai

[clang] [llvm] [msan] Precommit MSan Arm NEON vst tests (PR #98247)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,1515 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2 +; Test memory sanitizer instrumentation for Arm NEON VST instructions. +; +; RUN: opt < %s -passes=msan -S | FileCheck %s +; +; Forked from llvm/test/CodeGen/AArch

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-17 Thread Matheus Izvekov via cfe-commits
@@ -6308,11 +6308,11 @@ TypeResult Sema::ActOnTypeName(Declarator &D) { CheckExtraCXXDefaultArguments(D); } - if (const AutoType *AutoT = T->getAs()) -CheckConstrainedAuto( -AutoT, -TInfo->getTypeLoc().getContainedAutoTypeLoc().getConceptNameLoc());

[clang] [llvm] [msan] Precommit MSan Arm NEON vst tests (PR #98247)

2024-07-17 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. Please use args instead of undefs https://github.com/llvm/llvm-project/pull/98247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/98941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: It looks great! I only had one more thing to test. Besides that it would be nice to advertise this in the `clang/docs/ReleaseNotes.rst`. Usually, from that release notes we also link to the checker or the relevant doc pages - in this case it would be nice

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -24,3 +24,7 @@ void f15(int, int) void f16(int *i, int *j) __attribute__((ownership_holds(foo, 1))) __attribute__((ownership_holds(foo, 1))); // OK, same index void f17(void*) __attribute__((ownership_takes(__, 1))); void f18() __attribute__((ownership_takes(foo, 1))); //

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -103,14 +103,49 @@ using namespace std::placeholders; namespace { // Used to check correspondence between allocators and deallocators. -enum AllocationFamily { +enum AllocationFamilyKind { AF_None, AF_Malloc, AF_CXXNew, AF_CXXNewArray, AF_IfNameIndex, AF_A

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -14,6 +14,13 @@ void free(void *); void __attribute((ownership_takes(malloc, 1))) my_free(void *); +void __attribute((ownership_returns(malloc1))) *my_malloc1(size_t); steakhal wrote: Interesting. https://github.com/llvm/llvm-project/pull/98941 __

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -103,14 +103,49 @@ using namespace std::placeholders; namespace { // Used to check correspondence between allocators and deallocators. -enum AllocationFamily { +enum AllocationFamilyKind { AF_None, AF_Malloc, AF_CXXNew, AF_CXXNewArray, AF_IfNameIndex, AF_A

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -1490,7 +1532,7 @@ ProgramStateRef MallocChecker::ProcessZeroAllocCheck( return State; } } else -llvm_unreachable("not a CallExpr or CXXNewExpr"); +assert(false && "not a CallExpr or CXXNewExpr"); steakhal wrote: ```suggestion } else {

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -103,14 +103,49 @@ using namespace std::placeholders; namespace { // Used to check correspondence between allocators and deallocators. -enum AllocationFamily { +enum AllocationFamilyKind { AF_None, AF_Malloc, AF_CXXNew, AF_CXXNewArray, AF_IfNameIndex, AF_A

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -103,14 +103,49 @@ using namespace std::placeholders; namespace { // Used to check correspondence between allocators and deallocators. -enum AllocationFamily { +enum AllocationFamilyKind { AF_None, AF_Malloc, AF_CXXNew, AF_CXXNewArray, AF_IfNameIndex, AF_A

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
@@ -1122,7 +1157,7 @@ MallocChecker::performKernelMalloc(const CallEvent &Call, CheckerContext &C, if (TrueState && !FalseState) { SVal ZeroVal = C.getSValBuilder().makeZeroVal(Ctx.CharTy); return MallocMemAux(C, Call, Call.getArgExpr(0), ZeroVal, TrueState, -

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/98941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [msan] Precommit MSan Arm NEON vst tests (PR #98247)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,1515 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2 +; Test memory sanitizer instrumentation for Arm NEON VST instructions. +; +; RUN: opt < %s -passes=msan -S | FileCheck %s +; +; Forked from llvm/test/CodeGen/AArch

[clang] [APINotes] Reduce memory footprint for Obj-C/C++ contexts (PR #99358)

2024-07-17 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/99358 >From 8fcad7fee075e59dcf38716f19de738f51d85d82 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Wed, 17 Jul 2024 18:13:34 +0100 Subject: [PATCH] [APINotes] Reduce memory footprint for Obj-C/C++ contexts We were

[clang] [APINotes] Reduce memory footprint for Obj-C/C++ contexts (PR #99358)

2024-07-17 Thread Egor Zhdan via cfe-commits
egorzhdan wrote: Yeap, exactly, we weren't actually using the context kind, so this patch basically just removes it. https://github.com/llvm/llvm-project/pull/99358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [APINotes] Reduce memory footprint for Obj-C/C++ contexts (PR #99358)

2024-07-17 Thread Egor Zhdan via cfe-commits
@@ -286,6 +280,31 @@ inline bool operator==(const ContextTableKey &lhs, const ContextTableKey &rhs) { lhs.contextKind == rhs.contextKind && lhs.contextID == rhs.contextID; } +/// A stored Objective-C or C++ declaration, represented by the ID of its parent +/// conte

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-07-17 Thread Cooper Partin via cfe-commits
@@ -0,0 +1,292 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bou

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-17 Thread Utkarsh Saxena via cfe-commits
@@ -60,39 +74,65 @@ bool compileFromString(StringRef Code, StringRef Standard, StringRef FileName) { return Compiler.ExecuteAction(Action); } +std::string GetMetadata(json::Object *Event) { + std::string Metadata = ""; + if (json::Object *Args = Event->getObject("args"))

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-07-17 Thread Cooper Partin via cfe-commits
@@ -0,0 +1,292 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bou

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-17 Thread Matheus Izvekov via cfe-commits
@@ -6308,11 +6308,11 @@ TypeResult Sema::ActOnTypeName(Declarator &D) { CheckExtraCXXDefaultArguments(D); } - if (const AutoType *AutoT = T->getAs()) -CheckConstrainedAuto( -AutoT, -TInfo->getTypeLoc().getContainedAutoTypeLoc().getConceptNameLoc());

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-17 Thread Utkarsh Saxena via cfe-commits
@@ -83,16 +83,27 @@ namespace llvm { class raw_pwrite_stream; +struct TimeTraceMetadata { + std::string Detail; + // Source file information for the event. + std::string Filename; usx95 wrote: Done. https://github.com/llvm/llvm-project/pull/98320 ___

[clang] [CMake][Fuchsia] Install libc++ for baremetal targets (PR #99372)

2024-07-17 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/99372 We already build the library and want to install it also. >From bced10358296d34adedaff825d9d67150a6d243b Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Wed, 17 Jul 2024 11:44:41 -0700 Subject: [PATCH] [CMake]

[clang] [CMake][Fuchsia] Install libc++ for baremetal targets (PR #99372)

2024-07-17 Thread via cfe-commits
https://github.com/PiJoules approved this pull request. https://github.com/llvm/llvm-project/pull/99372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Fuchsia] Install libc++ for baremetal targets (PR #99372)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes We already build the library and want to install it also. --- Full diff: https://github.com/llvm/llvm-project/pull/99372.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (-2)

[clang] 130ef73 - [CMake][Fuchsia] Install libc++ for baremetal targets (#99372)

2024-07-17 Thread via cfe-commits
Author: Petr Hosek Date: 2024-07-17T11:46:17-07:00 New Revision: 130ef7375493b560df0854338233bacf95e5 URL: https://github.com/llvm/llvm-project/commit/130ef7375493b560df0854338233bacf95e5 DIFF: https://github.com/llvm/llvm-project/commit/130ef7375493b560df0854338233bacf95e5.diff LO

[clang] [CMake][Fuchsia] Install libc++ for baremetal targets (PR #99372)

2024-07-17 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/99372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Support for assume directive : Parse & AST modules (PR #97535)

2024-07-17 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/97535 >From a331d2343a43a9ca2030ef07a25ca93ff26a5778 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Mon, 1 Jul 2024 03:29:45 -0500 Subject: [PATCH 1/8] Support for "#pragma omp assume" Directive in Par

[clang] [clang] Support --sysroot= for ${arch}-windows-msvc targets (PR #96417)

2024-07-17 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/96417 >From 0b98d155f166d6a20b4ee05a5a5d8c34f3e95f71 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sun, 23 Jun 2024 00:07:19 -0400 Subject: [PATCH] Support --sysroot= for ${arch}-windows-msvc targets I think it is

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-17 Thread Vlad Serebrennikov via cfe-commits
@@ -7416,10 +7416,11 @@ NamedDecl *Sema::ActOnVariableDeclarator( tryToFixVariablyModifiedVarType(TInfo, R, D.getIdentifierLoc(), /*DiagID=*/0); - if (const AutoType *AutoT = R->getAs()) -CheckConstrainedAuto( -AutoT, -

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-17 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/98622 >From 5310764fb4044bcd4229434e80b64870c4b4ee8c Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Fri, 12 Jul 2024 15:12:37 +0300 Subject: [PATCH 1/3] [clang] Fix crash in concept deprecation Apparently we

[clang-tools-extra] [libc] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-17 Thread Piotr Zegar via cfe-commits
@@ -502,6 +502,12 @@ Changes in existing checks usages of ``std::string_view::compare``. Added a `StringLikeClasses` option to detect usages of ``compare`` method in custom string-like classes. +- Improved :doc:`readability-redundant-smartptr-get + ` identify

[clang-tools-extra] [libc] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-17 Thread Piotr Zegar via cfe-commits
@@ -502,6 +502,12 @@ Changes in existing checks usages of ``std::string_view::compare``. Added a `StringLikeClasses` option to detect usages of ``compare`` method in custom string-like classes. +- Improved :doc:`readability-redundant-smartptr-get + ` identify

[clang-tools-extra] [libc] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-17 Thread Piotr Zegar via cfe-commits
@@ -502,6 +502,12 @@ Changes in existing checks usages of ``std::string_view::compare``. Added a `StringLikeClasses` option to detect usages of ``compare`` method in custom string-like classes. +- Improved :doc:`readability-redundant-smartptr-get + ` identify

[clang-tools-extra] [libc] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-17 Thread Piotr Zegar via cfe-commits
@@ -235,3 +276,13 @@ void Negative() { if (MACRO(x) == nullptr) ; } + +void test_redundant_get() { + std::vector> v; + auto f = [](int) {}; + for (auto i = v.begin(); i != v.end(); ++i) { +f(*i->get()); PiotrZSL wrote: try also do a test with some

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-07-17 Thread Xiang Li via cfe-commits
@@ -0,0 +1,292 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bou

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-17 Thread Vlad Serebrennikov via cfe-commits
@@ -6308,11 +6308,11 @@ TypeResult Sema::ActOnTypeName(Declarator &D) { CheckExtraCXXDefaultArguments(D); } - if (const AutoType *AutoT = T->getAs()) -CheckConstrainedAuto( -AutoT, -TInfo->getTypeLoc().getContainedAutoTypeLoc().getConceptNameLoc());

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-07-17 Thread Xiang Li via cfe-commits
@@ -0,0 +1,292 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bou

[clang] [clang] pointer to member with qualified-id enclosed in parentheses in unevaluated context should be invalid (PR #89713)

2024-07-17 Thread Hubert Tong via cfe-commits
hubert-reinterpretcast wrote: I think (at least part of) the fix is to add a condition to https://github.com/llvm/llvm-project/blob/21e6777957457451196084cd48ebc42bce9619f0/clang/lib/Sema/SemaExpr.cpp#L14117-L14120 that the operand is not parenthesized. For reference, the address-of-member-fun

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-07-17 Thread Nikita Popov via cfe-commits
nikic wrote: Thanks for following up on this! For the record, this was the final result: https://llvm-compile-time-tracker.com/compare.php?from=18cdfa72e046a40d4372ee98602fd1a65a94&to=0bb68b55715487447ffceaa1ab59f7a0bc8c7979&stat=instructions:u https://github.com/llvm/llvm-project/pull/968

[clang] [llvm] [msan] Precommit MSan Arm NEON vst tests (PR #98247)

2024-07-17 Thread Thurston Dang via cfe-commits
https://github.com/thurstond closed https://github.com/llvm/llvm-project/pull/98247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Only propagate past CXXDefaultInitExpr if init is (PR #99236)

2024-07-17 Thread Samira Bazuzi via cfe-commits
@@ -465,7 +465,12 @@ class ResultObjectVisitor : public AnalysisASTVisitor { } if (auto *DIE = dyn_cast(E)) { - PropagateResultObject(DIE->getExpr(), Loc); + // If it has a rewritten init, we should propagate to that. If it doesn't, + // then the CXXDe

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2024-07-17 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/95474 >From 69b09ea5b0f0a1c5419c488ade29b6fedc6de773 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Thu, 13 Jun 2024 14:20:50 -0700 Subject: [PATCH] [Clang] Implement P2280R4 Using unknown pointers and references

[clang] [llvm] Remove 3dnow from X86TargetParser. (PR #99352)

2024-07-17 Thread James Y Knight via cfe-commits
@@ -171,14 +171,14 @@ constexpr FeatureBitset FeaturesClearwaterforest = // Geode Processor. constexpr FeatureBitset FeaturesGeode = -FeatureX87 | FeatureCMPXCHG8B | FeatureMMX | Feature3DNOW | Feature3DNOWA; jyknight wrote: (I somewhat lean towards submi

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/98320 >From 03cc5fbebaf0c0c737e9304b8b3310ab4908fcaa Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 10 Jul 2024 13:52:46 + Subject: [PATCH 01/10] Add an option to add source file info to -ftime-trace --- c

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Thurston Dang via cfe-commits
https://github.com/thurstond converted_to_draft https://github.com/llvm/llvm-project/pull/99360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/98320 >From 03cc5fbebaf0c0c737e9304b8b3310ab4908fcaa Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 10 Jul 2024 13:52:46 + Subject: [PATCH 01/11] Add an option to add source file info to -ftime-trace --- c

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Thurston Dang via cfe-commits
@@ -2483,13 +2484,21 @@ struct MemorySanitizerVisitor : public InstVisitor { using OriginCombiner = Combiner; /// Propagate origin for arbitrary operation. - void setOriginForNaryOp(Instruction &I) { + /// + /// Optionally skips n trailing operands. + void setOriginFo

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-07-17 Thread Xiang Li via cfe-commits
https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/88781 >From 0065f8eade1fc00bce560ceeba9431a4616615b9 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Mon, 15 Apr 2024 12:23:46 -0700 Subject: [PATCH 1/5] [Doc][HLSL] Add documentation for root signature This patch a

[clang] [Doc][HLSL] Add documentation for root signature (PR #88781)

2024-07-17 Thread Xiang Li via cfe-commits
https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/88781 >From 4da15566a6dbe3f7fec1e09ec1bd5ea681a7bab5 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Mon, 15 Apr 2024 12:23:46 -0700 Subject: [PATCH 1/5] [Doc][HLSL] Add documentation for root signature This patch a

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99380)

2024-07-17 Thread via cfe-commits
https://github.com/matthew-f created https://github.com/llvm/llvm-project/pull/99380 The regular expressions match functions that aren't anchored in the global namespace. For example `::remove` matches any object with a `removeXyz` method. This change is to remove these false positives >From

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99380)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (matthew-f) Changes The regular expressions match functions that aren't anchored in the global namespace. For example `::remove` matches any object with a `removeXyz` method. This change is to remove these false positives

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99380)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (matthew-f) Changes The regular expressions match functions that aren't anchored in the global namespace. For example `::remove` matches any object with a `removeXyz` method. This change is to remove these false positives ---

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99380)

2024-07-17 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -3865,6 +3866,125 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + // Given two shadows ..., ..., return the interleaved value + // ABABABAB ... + // + // Width == number of elements in A == number of elements in B + Val

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Thurston Dang via cfe-commits
@@ -3865,6 +3866,125 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + // Given two shadows ..., ..., return the interleaved value + // ABABABAB ... + // + // Width == number of elements in A == number of elements in B + Val

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Thurston Dang via cfe-commits
@@ -3742,6 +3751,124 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + // Given two shadows ..., ..., return the interleaved value + // ABABABAB ... + // + // Width == number of elements in A == number of elements in B + Val

[libclc] libclc: increase fp16 support (PR #98149)

2024-07-17 Thread Romaric Jodin via cfe-commits
@@ -181,3 +181,15 @@ _CLC_OVERLOAD _CLC_DEF double atan(double x) _CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, atan, double); #endif // cl_khr_fp64 + +#ifdef cl_khr_fp16 rjodinchr wrote: I agree, but I had some weird compilation errors. Does it work o

[libclc] libclc: increase fp16 support (PR #98149)

2024-07-17 Thread Romaric Jodin via cfe-commits
@@ -181,3 +181,15 @@ _CLC_OVERLOAD _CLC_DEF double atan(double x) _CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, atan, double); #endif // cl_khr_fp64 + +#ifdef cl_khr_fp16 rjodinchr wrote: Alright, just found that it is due to includes order in `atan.cl

[libclc] libclc: increase fp16 support (PR #98149)

2024-07-17 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr updated https://github.com/llvm/llvm-project/pull/98149 >From 449321d1d22c39201e132cbd8b5846cbe12dbe39 Mon Sep 17 00:00:00 2001 From: Romaric Jodin Date: Tue, 9 Jul 2024 14:22:26 +0200 Subject: [PATCH] libclc: increase fp16 support Increase fp16 support to allow cl

[libclc] libclc: increase fp16 support (PR #98149)

2024-07-17 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: Also, just leave that thought here: A next step might be to use `native` functions instead (when available). They should provide enough precision for half, but be more performance. Also as the accuracy is undefined for those functions, maybe it should be an opt-in option in th

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/98941 >From 3d362cfb1e197713a51ce798996ff4308e7ab5aa Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Wed, 17 Jul 2024 16:41:20 +0300 Subject: [PATCH 1/6] clang/sema: disallow more than one 'onweship_takes' with di

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Pavel Skripkin via cfe-commits
@@ -1122,7 +1157,7 @@ MallocChecker::performKernelMalloc(const CallEvent &Call, CheckerContext &C, if (TrueState && !FalseState) { SVal ZeroVal = C.getSValBuilder().makeZeroVal(Ctx.CharTy); return MallocMemAux(C, Call, Call.getArgExpr(0), ZeroVal, TrueState, -

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Pavel Skripkin via cfe-commits
@@ -103,14 +103,49 @@ using namespace std::placeholders; namespace { // Used to check correspondence between allocators and deallocators. -enum AllocationFamily { +enum AllocationFamilyKind { AF_None, AF_Malloc, AF_CXXNew, AF_CXXNewArray, AF_IfNameIndex, AF_A

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Pavel Skripkin via cfe-commits
@@ -103,14 +103,49 @@ using namespace std::placeholders; namespace { // Used to check correspondence between allocators and deallocators. -enum AllocationFamily { +enum AllocationFamilyKind { AF_None, AF_Malloc, AF_CXXNew, AF_CXXNewArray, AF_IfNameIndex, AF_A

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Pavel Skripkin via cfe-commits
@@ -24,3 +24,7 @@ void f15(int, int) void f16(int *i, int *j) __attribute__((ownership_holds(foo, 1))) __attribute__((ownership_holds(foo, 1))); // OK, same index void f17(void*) __attribute__((ownership_takes(__, 1))); void f18() __attribute__((ownership_takes(foo, 1))); //

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-17 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: > Do you want to extend the scope of this PR to add some minimal docs to the > attribute? > If not, that's also fine, we will create a separate ticket for adding them > later. I am would be happy to give it a try, but I think we need to fix couple of things to truly follow the

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-17 Thread Utkarsh Saxena via cfe-commits
@@ -83,16 +83,27 @@ namespace llvm { class raw_pwrite_stream; +struct TimeTraceMetadata { usx95 wrote: Done. https://github.com/llvm/llvm-project/pull/98320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix a regression with alignas on structure members in C (PR #98642)

2024-07-17 Thread James Y Knight via cfe-commits
https://github.com/jyknight approved this pull request. Thanks, LGTM. I like this version. Did this change also fix any other bugs? Since it looks like we were previously not skipping ProcessDeclAttribute for ``[[]]`` attributes in C23 mode, when IncludeCXX11Attributes == false, and we were su

[clang] [Sema] Don't drop weak_import from a declaration that follows a declaration directly contained in a linkage-specification (PR #85886)

2024-07-17 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. LGTM. The (existing) diagnostic wording does seem a little awkward, so if you want to put effort into cleaning that up, it'd be welcome, but I won't hold up this fix. https://github.com/llvm/llvm-project/pull/85886 __

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Thurston Dang via cfe-commits
@@ -3742,6 +3751,124 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + // Given two shadows ..., ..., return the interleaved value + // ABABABAB ... + // + // Width == number of elements in A == number of elements in B + Val

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Thurston Dang via cfe-commits
https://github.com/thurstond ready_for_review https://github.com/llvm/llvm-project/pull/99360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_inplace_task]] (PR #99282)

2024-07-17 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/99282 >From dfb903c47573a01c25a67ea1025fdc3c268673c8 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH] [Clang] Introduce [[clang::coro_await_elidable]] --- clang/

[clang] [Clang] Reuse tail-padding for more types that are not POD for the purpose of layout (PR #90462)

2024-07-17 Thread Mital Ashok via cfe-commits
MitalAshok wrote: I have reached out to Fuschia on their discord and am still waiting for a response. I was unable to find a place to ask someone related to IBM XL what is supposed to happen (and I couldn't get the xl++ compiler to check what it does). Would be grateful if someone more knowl

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -3865,6 +3866,42 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + /// Handle Arm NEON vector store intrinsics (vst{2,3,4}). + /// + /// Arm NEON vector store intrinsics have the output address (pointer) as the + /// last argument

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -3865,6 +3866,42 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + /// Handle Arm NEON vector store intrinsics (vst{2,3,4}). + /// + /// Arm NEON vector store intrinsics have the output address (pointer) as the + /// last argument

[clang] [llvm] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_await_elidable]] (PR #99282)

2024-07-17 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 edited https://github.com/llvm/llvm-project/pull/99282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-17 Thread Vitaly Buka via cfe-commits
@@ -3865,6 +3866,42 @@ struct MemorySanitizerVisitor : public InstVisitor { setOriginForNaryOp(I); } + /// Handle Arm NEON vector store intrinsics (vst{2,3,4}). + /// + /// Arm NEON vector store intrinsics have the output address (pointer) as the + /// last argument

[clang] [llvm] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_await_elidable]] (PR #99282)

2024-07-17 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 edited https://github.com/llvm/llvm-project/pull/99282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement f16x8.replace_lane instruction. (PR #99388)

2024-07-17 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl created https://github.com/llvm/llvm-project/pull/99388 Use a builtin and intrinsic until half types are better supported for instruction selection. >From a6d65f276fba7487fdecf2e31edef457f74fbafe Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Wed, 17 Jul 2024

[clang] [llvm] [WebAssembly] Implement f16x8.replace_lane instruction. (PR #99388)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brendan Dahl (brendandahl) Changes Use a builtin and intrinsic until half types are better supported for instruction selection. --- Full diff: https://github.com/llvm/llvm-project/pull/99388.diff 7 Files Affected: - (modified) clang/in

[clang] [llvm] [WebAssembly] Implement f16x8.replace_lane instruction. (PR #99388)

2024-07-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly @llvm/pr-subscribers-mc Author: Brendan Dahl (brendandahl) Changes Use a builtin and intrinsic until half types are better supported for instruction selection. --- Full diff: https://github.com/llvm/llvm-project/pull/99388.diff 7

[clang] [llvm] [AArch64][PAC] Sign block addresses used in indirectbr. (PR #97647)

2024-07-17 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,106 @@ +; RUN: llc -mtriple arm64e-apple-darwin \ jroelofs wrote: does update_test_checks do horrible things to the CHECK lines in this? https://github.com/llvm/llvm-project/pull/97647 ___ cfe-commits mailin

[clang-tools-extra] [clangd] fix extract-to-function for overloaded operators (PR #81640)

2024-07-17 Thread via cfe-commits
BenBlumer wrote: Would be great to see this merged. This bug prevents basic function extractions from working. https://github.com/llvm/llvm-project/pull/81640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-17 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 01/13] [NFC] Add assertion to ensure that FiniteMathOnly to

[clang] [Clang] Fix Microsoft ABI inheritance model when member pointer is used in a base specifier (PR #91990)

2024-07-17 Thread Mital Ashok via cfe-commits
@@ -9015,11 +9015,20 @@ bool Sema::RequireCompleteTypeImpl(SourceLocation Loc, QualType T, if (const MemberPointerType *MPTy = T->getAs()) { if (!MPTy->getClass()->isDependentType()) { - if (getLangOpts().CompleteMemberPointers && - !MPTy->getClass()->getA

[clang] [llvm] Remove 3dnow from X86TargetParser. (PR #99352)

2024-07-17 Thread Simon Pilgrim via cfe-commits
@@ -171,14 +171,14 @@ constexpr FeatureBitset FeaturesClearwaterforest = // Geode Processor. constexpr FeatureBitset FeaturesGeode = -FeatureX87 | FeatureCMPXCHG8B | FeatureMMX | Feature3DNOW | Feature3DNOWA; RKSimon wrote: I think we should add the defin

[clang] [Sema] Don't drop weak_import from a declaration that follows a declaration directly contained in a linkage-specification (PR #85886)

2024-07-17 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/85886 >From d39667c7e65c10babb478d8f8d54fecb66d90568 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 19 Mar 2024 15:50:00 -0700 Subject: [PATCH 1/5] [Sema] Don't drop weak_import from a declaration that foll

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-17 Thread Peter Smith via cfe-commits
https://github.com/smithp35 edited https://github.com/llvm/llvm-project/pull/97237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-17 Thread Peter Smith via cfe-commits
@@ -1546,16 +1581,28 @@ static void CollectARMPACBTIOptions(const ToolChain &TC, const ArgList &Args, CmdArgs.push_back( Args.MakeArgString(Twine("-msign-return-address=") + Scope)); - if (Scope != "none") + if (Scope != "none") { +if (Triple.getEnvironment() ==

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-17 Thread Peter Smith via cfe-commits
https://github.com/smithp35 commented: Apologies for the delay in responding, been a bit backed up. I like the idea of pauthtest as it does give some leeway to change the signing schema. I expect that with some work this could be made to work with bare-metal targets too, but I think it is best

[clang] 07f8a65 - [clang] Ensure pointers passed to runtime support functions are correctly signed (#98276)

2024-07-17 Thread via cfe-commits
Author: Oliver Hunt Date: 2024-07-17T15:22:53-07:00 New Revision: 07f8a65d09608d67bfd6adbd62bb0999c7363456 URL: https://github.com/llvm/llvm-project/commit/07f8a65d09608d67bfd6adbd62bb0999c7363456 DIFF: https://github.com/llvm/llvm-project/commit/07f8a65d09608d67bfd6adbd62bb0999c7363456.diff L

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-17 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/98276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Don't treat ObjC method args as module directives (PR #97654)

2024-07-17 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/97654 >From b5f39ac8b2ed97e53e13dd71618d8da993a48480 Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Wed, 10 Jul 2024 17:02:39 -0700 Subject: [PATCH] [clang][deps] Don't treat ObjC method args as module directi

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-17 Thread David Truby via cfe-commits
DavidTruby wrote: Linux builds appear to have stopped, but all the previous linux builds worked so I think this is fine to merge. I will revert if it breaks post-commit. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-

<    1   2   3   4   5   >