ChuanqiXu9 wrote:
@kadircet Comments addressed. Maybe due to some github's issue, my replies are
separated and didn't form a standalone list. Hope this won't make it harder.
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo {
unsigned short SuitableAlign;
unsigned short NewAlign;
unsigned MaxVectorAlign;
phoebewang wrote:
I noticed that, but the value is set for Darwin, but the failure prefix is a
non Darwin one.
https://
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96160
>From f891f791dfe882389d83d3c4c4fb57d67a845c04 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 18 Jun 2024 15:38:18 +0300
Subject: [PATCH 1/3] [PAC][clang][Driver] Add signed GOT flag
Add `-fptrauth-el
ChuanqiXu9 wrote:
Haven't look into the details but just a quick scanning.
I feel the name `[[coro_inplace_task]]` is not so good. Since it doesn't happen
unconditionally. It happens conditionally. I still want to try to make it clear
in the name. I still like names like `[[coro_elide_after_a
ChuanqiXu9 wrote:
BTW, it will be better to use stacked PR for this one and
https://github.com/llvm/llvm-project/pull/98974.
https://github.com/llvm/llvm-project/pull/98971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/DominikAdamski created
https://github.com/llvm/llvm-project/pull/99002
-fcuda-is-device flag is not used for OpenMP offloading for AMD GPUs and it
does not need to be added as clang cc1 option for OpenMP code.
This PR has the same functionality as
https://github.com/llvm/ll
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Dominik Adamski (DominikAdamski)
Changes
-fcuda-is-device flag is not used for OpenMP offloading for AMD GPUs and it
does not need to be added as clang cc1 option for OpenMP code.
This PR has the same fu
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Dominik Adamski (DominikAdamski)
Changes
-fcuda-is-device flag is not used for OpenMP offloading for AMD GPUs and it
does not need to be added as clang cc1 option for OpenMP code.
This PR has the same functionality as
https://gi
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96478
>From 5399237a71c0ccd872821034d83ea2c3a04bed3f Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Fri, 21 Jun 2024 12:32:51 +0300
Subject: [PATCH 1/2] [PAC][AArch64] Support init/fini array signing
If both `-f
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/99005
The current implementation for the assignment case uses a combination of the
`LK_Extended` lifetime kind and the validity of `AEntity`, which is somewhat
messy and doesn't align well with the intended mental mode
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
The current implementation for the assignment case uses a combination of the
`LK_Extended` lifetime kind and the validity of `AEntity`, which is somewhat
messy and doesn't align well with the intended mental mo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 58c7df90f838251c3682abfe91abadaa68ff6a01
8d656fc6da199e4fc600ed6454614d03bcc57721 --e
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/96478
>From 5399237a71c0ccd872821034d83ea2c3a04bed3f Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Fri, 21 Jun 2024 12:32:51 +0300
Subject: [PATCH 1/3] [PAC][AArch64] Support init/fini array signing
If both `-f
Author: cor3ntin
Date: 2024-07-16T10:39:06+02:00
New Revision: 244892735941a455506ae38ae0fb40cf80cdb351
URL:
https://github.com/llvm/llvm-project/commit/244892735941a455506ae38ae0fb40cf80cdb351
DIFF:
https://github.com/llvm/llvm-project/commit/244892735941a455506ae38ae0fb40cf80cdb351.diff
LOG:
cor3ntin wrote:
I'll merge that. If there are further feedback I'd be happy to do post commit
reviews and additional work on this feature
@AaronBallman Thanks for the review!
https://github.com/llvm/llvm-project/pull/98160
___
cfe-commits mailing lis
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/98160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running
on `linaro-clang-armv8-quick` while building `clang` at step 4 "build stage 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/154/builds/1447
Here is the relevant piece of
https://github.com/cor3ntin approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/98736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -242,7 +242,7 @@ bool types::isCXX(ID Id) {
case TY_CXXHUHeader:
case TY_PP_CXXHeaderUnit:
case TY_ObjCXXHeader: case TY_PP_ObjCXXHeader:
- case TY_CXXModule: case TY_PP_CXXModule:
+ case TY_CXXModule: case TY_PP_CXXModule: case TY_ModuleFile:
Chuanq
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `clang` at step 4 "build".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/877
Here is the relevant piece of the build log
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/99007
Reverts llvm/llvm-project#98160
Breaks CI on some architectures
>From 97a9ef1c1810b88102d097d334b2017cce782390 Mon Sep 17 00:00:00 2001
From: cor3ntin
Date: Tue, 16 Jul 2024 10:59:38 +0200
Subject: [PATCH] =?U
Author: cor3ntin
Date: 2024-07-16T11:00:27+02:00
New Revision: 762a47828ef6c19426e37e1ecae6768035a4ccac
URL:
https://github.com/llvm/llvm-project/commit/762a47828ef6c19426e37e1ecae6768035a4ccac
DIFF:
https://github.com/llvm/llvm-project/commit/762a47828ef6c19426e37e1ecae6768035a4ccac.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/99007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Xazax-hun wrote:
@MaskRay Thanks for the review. Do you think this is good to go or is there
anything else you want me to change?
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Reverts llvm/llvm-project#98160
Breaks CI on some architectures
---
Patch is 53.87 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/99007.diff
7 Files Affected:
-
https://github.com/Xazax-hun approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/99005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Xazax-hun wrote:
I really like the test coverage of this feature, but I started to wonder if we
should start splitting up some sema tests into subfolders. I think the
bounds-safety related tests would be a good candidate to have their own
subfolder :)
https://github.com/llvm/llvm-project/pull
jakubjelinek wrote:
@ThePhd @AaronBallman
And even more importantly (checking on godbolt again):
```c
int a = sizeof (
#embed __FILE__ limit (1)
);
```
is 1 in clang as well as clang++ trunk and 4 with clang/clang++ trunk with
-save-temps.
I thought there was agreement that at least for C th
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/99009
This is mostly a proof of concept requiring a number of workarounds, but
demonstrates that it is feasible.
>From add4a1681a9cfcfb20443c5652e3166ec739c31b Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Tue, 1
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Petr Hosek (petrhosek)
Changes
This is mostly a proof of concept requiring a number of workarounds, but
demonstrates that it is feasible.
---
Full diff: https://github.com/llvm/llvm-project/pull/99009.diff
1 Files Affected:
- (modified
DavidSpickett wrote:
@luporl please help reproduce the bot failure
https://lab.llvm.org/buildbot/#/builders/39/builds/528.
You can also try it under qemu -
https://linaro.atlassian.net/wiki/spaces/TCWGPUB/pages/29360783374/How+to+Reproduce+32+bit+Arm+Builds+Without+Hardware.
https://github.co
Author: Haojian Wu
Date: 2024-07-16T11:23:39+02:00
New Revision: c30ce8b9d33d1050ead549705702c1472b7a7d3f
URL:
https://github.com/llvm/llvm-project/commit/c30ce8b9d33d1050ead549705702c1472b7a7d3f
DIFF:
https://github.com/llvm/llvm-project/commit/c30ce8b9d33d1050ead549705702c1472b7a7d3f.diff
LO
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/99005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/99005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
Ping: would be glad to see feedback on the changes from those who are
interested.
https://github.com/llvm/llvm-project/pull/96478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
kovdan01 wrote:
Ping: would be glad to see feedback on the changes from those who are
interested.
https://github.com/llvm/llvm-project/pull/96160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: Daniel Grumberg
Date: 2024-07-16T11:24:28+01:00
New Revision: 2c13194eab28474089841903acd5790b8b1a559a
URL:
https://github.com/llvm/llvm-project/commit/2c13194eab28474089841903acd5790b8b1a559a
DIFF:
https://github.com/llvm/llvm-project/commit/2c13194eab28474089841903acd5790b8b1a559a.dif
https://github.com/daniel-grumberg closed
https://github.com/llvm/llvm-project/pull/98914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/98991
>From 727d92f0651cec3110d321582a884f1c939d8a6d Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Tue, 16 Jul 2024 12:43:33 +0800
Subject: [PATCH 1/2] Revert "[Clang] Instantiate local constexpr functions
eagerly
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/98991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Younan Zhang
Date: 2024-07-16T18:53:48+08:00
New Revision: 862715ea813d8ffa73050ada17567b45c41a1023
URL:
https://github.com/llvm/llvm-project/commit/862715ea813d8ffa73050ada17567b45c41a1023
DIFF:
https://github.com/llvm/llvm-project/commit/862715ea813d8ffa73050ada17567b45c41a1023.diff
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo {
unsigned short SuitableAlign;
unsigned short NewAlign;
unsigned MaxVectorAlign;
Fznamznon wrote:
I pasted log in a weird way, sorry, all failures in this particular test I see
are for Darwin.
```
// M
@@ -442,6 +442,9 @@ def warn_drv_deprecated_arg : Warning<
def warn_drv_deprecated_arg_no_relaxed_template_template_args : Warning<
"argument '-fno-relaxed-template-template-args' is deprecated">,
InGroup;
+def warn_drv_deprecated_arg_ofast : Warning<
+ "argument '-Ofast'
tschuett wrote:
We are deprecating -Ofast and I would prefer to hint users first at conforming
behaviour -O3 and then as last resort at -O3 with -ffast-math.
https://github.com/llvm/llvm-project/pull/98736
___
cfe-commits mailing list
cfe-commits@list
@@ -0,0 +1,355 @@
+//===--- PrerequisiteModulesTests.cpp ---*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
@@ -0,0 +1,355 @@
+//===--- PrerequisiteModulesTests.cpp ---*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
https://github.com/mikecrowe created
https://github.com/llvm/llvm-project/pull/99021
When fixing #92896 in 0e62d5cf55479981da5e05e406bbca4afb3cdc4f (#94104) I
failed to spot that I'd broken converting from fmt::printf, fmt::fprintf and
fmt::sprintf in these checks since the format parameter of
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Mike Crowe (mikecrowe)
Changes
When fixing #92896 in 0e62d5cf55479981da5e05e406bbca4afb3cdc4f (#94104) I failed to spot that I'd broken converting from fmt::printf,
fmt::fprintf and fmt::sprintf in these checks since the format
mikecrowe wrote:
The previous fix hadn't made it into a release yet, so I don't think that this
newly-discovered problem requires mentioning in the release notes. I'm happy to
create a separate issue for it if you'd like me to though.
https://github.com/llvm/llvm-project/pull/99021
___
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/99002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
> We are deprecating -Ofast and I would prefer to hint users first at
> conforming behaviour -O3 and then as last resort at -O3 with -ffast-math.
@tschuett I'm sympathetic to this arguments, but I think it's no less important
to tell users in no uncertain terms how to preserve t
vfdff wrote:
the case pass on window target with extra `extern "C"` for the function, but
it is strange the linux target test has not finish.
https://github.com/llvm/llvm-project/pull/98704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
tschuett wrote:
> > We are deprecating -Ofast and I would prefer to hint users first at
> > conforming behaviour -O3 and then as last resort at -O3 with -ffast-math.
>
> @tschuett I'm sympathetic to this arguments, but I think it's no less
> important to tell users in no uncertain terms how to
@@ -0,0 +1,43 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// The test may fail as time out on windows
+// REQUIRES: system-linux
+
+// RUN: %clang -S -O3 -emit-llvm -o - -x c++ %s | FileCheck %s
-check-prefixes=CHECK,
https://github.com/vfdff closed https://github.com/llvm/llvm-project/pull/98990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vfdff wrote:
this can be closed now as we already know the reason of failure on windows
because the **function naming rules**
https://github.com/llvm/llvm-project/pull/98990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
@@ -242,7 +242,7 @@ bool types::isCXX(ID Id) {
case TY_CXXHUHeader:
case TY_PP_CXXHeaderUnit:
case TY_ObjCXXHeader: case TY_PP_ObjCXXHeader:
- case TY_CXXModule: case TY_PP_CXXModule:
+ case TY_CXXModule: case TY_PP_CXXModule: case TY_ModuleFile:
sharad
https://github.com/sharadhr edited
https://github.com/llvm/llvm-project/pull/98761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
egorzhdan wrote:
Yeah, I can't see any usages of this in the past few years. It was probably
used a long while ago.
https://github.com/llvm/llvm-project/pull/98943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
Author: Egor Zhdan
Date: 2024-07-16T12:39:04+01:00
New Revision: 4348f32ec609540e642be1be263d6ad2b60a90fd
URL:
https://github.com/llvm/llvm-project/commit/4348f32ec609540e642be1be263d6ad2b60a90fd
DIFF:
https://github.com/llvm/llvm-project/commit/4348f32ec609540e642be1be263d6ad2b60a90fd.diff
LO
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/98943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -318,6 +309,10 @@ bool StandalonePrerequisiteModules::canReuse(
Clang.getHeaderSearchOpts().ForceCheckCXX20ModulesInputFiles = true;
Clang.getHeaderSearchOpts().ValidateASTInputFilesContent = true;
+ // Following the practice of clang's driver to suppres the checking f
@@ -0,0 +1,411 @@
+//===--- PrerequisiteModulesTests.cpp ---*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifi
@@ -0,0 +1,335 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,335 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,335 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,335 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/kadircet approved this pull request.
thanks a lot, LGTM!
i think the only big item remaining is injecting resource-dir correctly when
running clang-scan-deps.
the most important follow up (for functionality, rather than optimizations and
usability) is indexing the PCMs as w
@@ -0,0 +1,199 @@
+//===-- ProjectModules.h -*-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,335 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/99022
Implement https://isocpp.org/files/papers/P2963R3.pdf
>From 028bac287cbc6d07ad426aa91b7df9195153dd08 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Tue, 9 Jul 2024 16:08:44 +0200
Subject: [PATCH 01/10] [Cl
@@ -0,0 +1,335 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/vfdff updated https://github.com/llvm/llvm-project/pull/96025
>From ed6292fd0e9119322c39e5f37e2225c76e324101 Mon Sep 17 00:00:00 2001
From: zhongyunde 00443407
Date: Tue, 18 Jun 2024 09:21:07 -0400
Subject: [PATCH 1/9] [TBAA] Emit int TBAA metadata on FP math libcalls
Base on
cor3ntin wrote:
@Endilll I think Aaron's suggestion gets you closer to what @tschuett wants
https://github.com/llvm/llvm-project/pull/98736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/99023
When #embed appears in an initializer list, we may choose a "fast path"
- if the target declaration is a char array, we simply initialize it with
string literal that contains embedded data. However we need to b
https://github.com/Fznamznon edited
https://github.com/llvm/llvm-project/pull/99023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
When #embed appears in an initializer list, we may choose a "fast path" if the
target declaration is a char array. We simply initialize it with string literal
that contains embedded data. However
Fznamznon wrote:
> Just checked that one and it still fails on latest clang trunk using godbolt.
Hmm, ok. https://github.com/llvm/llvm-project/pull/99023 . Thanks for pointing
this out.
https://github.com/llvm/llvm-project/pull/97274
___
cfe-commits
https://github.com/AaronBallman approved this pull request.
The 32-bit fix LGTM!
https://github.com/llvm/llvm-project/pull/99022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-07-16T13:57:41+02:00
New Revision: 5b310a1c3c5aabae325934a6475e93ea8b71cdc2
URL:
https://github.com/llvm/llvm-project/commit/5b310a1c3c5aabae325934a6475e93ea8b71cdc2
DIFF:
https://github.com/llvm/llvm-project/commit/5b310a1c3c5aabae325934a6475e93ea8b71cdc2.diff
LO
@@ -4434,16 +4433,41 @@ class CodeGenFunction : public CodeGenTypeCache {
llvm::Value *StorageAddress,
GlobalDecl SchemaDecl,
QualType SchemaType);
+
llvm:
@@ -2373,7 +2373,9 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
DestLV.setTBAAInfo(TBAAAccessInfo::getMayAliasInfo());
return EmitLoadOfLValue(DestLV, CE->getExprLoc());
}
-return Builder.CreateBitCast(Src, DstTy);
+
+llvm::Value *Result =
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/98847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3126,3 +3137,57 @@ CodeGenFunction::EmitPointerAuthAuth(const
CGPointerAuthInfo &PointerAuth,
return EmitPointerAuthCommon(*this, PointerAuth, Pointer,
llvm::Intrinsic::ptrauth_auth);
}
+
+llvm::Value *CodeGenFunction::EmitPointerAuthSign(Q
@@ -351,3 +434,125 @@ CodeGenModule::getVTablePointerAuthInfo(CodeGenFunction
*CGF,
/* IsIsaPointer */ false,
/* AuthenticatesNullValues */ false, Discriminator);
}
+
+llvm::Value *CodeGenFunction::AuthPointerToPointerCast(
https://github.com/kovdan01 commented:
Mostly LGTM. There are several new pretty minor comments, but they can be
addressed in a follor-up PR.
The thing which is better to be addressed as a part of this PR is deleting
three unneeded member functions from `CodeGenFunction`. IMHO there is no reas
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/98847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -707,7 +707,34 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const
FunctionDecl *FD,
const CallExpr *E, llvm::Constant *calleeValue) {
CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E);
CGCallee callee = CGCallee::forDirect(calle
AaronBallman wrote:
> I thought there was agreement that at least for C the literals have type int,
That's correct; this patch gets started on addressing that issue by updating
the way we expand the embedded contents but isn't intended to fix the type
issue yet (that will be a follow-up patch)
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/97274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/98736
>From 44b4a682f2b3d7e140f7b1bd124e7aabdbf439ad Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 13 Jul 2024 13:10:25 +0300
Subject: [PATCH 1/4] [clang] Add deprecation warning for `-Ofast` driver
opt
@@ -10,31 +10,36 @@
// RUN: %clang -Ofast -fno-strict-aliasing -### %s 2>&1 | FileCheck
-check-prefix=CHECK-OFAST-NO-STRICT-ALIASING %s
// RUN: %clang -Ofast -fno-vectorize -### %s 2>&1 | FileCheck
-check-prefix=CHECK-OFAST-NO-VECTORIZE %s
+// CHECK-OFAST: argument '-Ofast'
@@ -442,6 +442,9 @@ def warn_drv_deprecated_arg : Warning<
def warn_drv_deprecated_arg_no_relaxed_template_template_args : Warning<
"argument '-fno-relaxed-template-template-args' is deprecated">,
InGroup;
+def warn_drv_deprecated_arg_ofast : Warning<
+ "argument '-Ofast'
tbaederr wrote:
> You can also try it under qemu -
> https://linaro.atlassian.net/wiki/spaces/TCWGPUB/pages/29360783374/How+to+Reproduce+32+bit+Arm+Builds+Without+Hardware.
https://github.com/llvm/llvm-project/pull/70306
___
cfe-commits mailing list
c
https://github.com/SunilKuravinakop updated
https://github.com/llvm/llvm-project/pull/97535
>From a331d2343a43a9ca2030ef07a25ca93ff26a5778 Mon Sep 17 00:00:00 2001
From: Sunil Kuravinakop
Date: Mon, 1 Jul 2024 03:29:45 -0500
Subject: [PATCH 1/7] Support for "#pragma omp assume" Directive in Par
@@ -0,0 +1,43 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// The test may fail as time out on windows
+// REQUIRES: system-linux
+
+// RUN: %clang -S -O3 -emit-llvm -o - -x c++ %s | FileCheck %s
-check-prefixes=CHECK,
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/99023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/98736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
> It looks like the removal missed a few bits: PNaClABIBuiltinVaList and
> clang/lib/CodeGen/Targets/PNaCl.cpp weren't removed.
I was under the impression those bits were still needed for Chromium. CC
@dschuff
> > Unfortunately, this utterly breaks Halide, which was in fa
1 - 100 of 443 matches
Mail list logo
