[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-15 Thread Davis Herring via cfe-commits
opensdh wrote: > You might want to know that CWG1835 is causing some disruption in the wild I believe it, although the alternative (having to write `(it->end) < it->end` in the issue's example) seems like it would be just as user-hostile. > I wonder if we should consider deploying that change

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -931,7 +931,8 @@ def O : Joined<["-"], "O">, Group, def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>, Alias, AliasArgs<["1"]>; def Ofast : Joined<["-"], "Ofast">, Group, - Visibility<[ClangOption, CC1Option, FlangOption]>; + Visibility<[Clan

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -442,6 +442,9 @@ def warn_drv_deprecated_arg : Warning< def warn_drv_deprecated_arg_no_relaxed_template_template_args : Warning< "argument '-fno-relaxed-template-template-args' is deprecated">, InGroup; +def warn_drv_deprecated_arg_ofast : Warning< + "argument '-Ofast'

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-15 Thread Phoebe Wang via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; phoebewang wrote: I'm surprised the change of alignment affects ABI. Did you just expand ``` MaxVectorAlign =

[clang] [clang] Inject tokens containing #embed back into token stream (PR #97274)

2024-07-15 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: I'm looking through https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655012.html This patch fixes cases like: ``` const unsigned char w[] = { #embed __FILE__ prefix([0] = 42, [15] =) limit(32) }; ``` And also cases like ``` void foo (int, int, int, int); void bar (void) { f

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -328,12 +328,20 @@ class ComplexExprEmitter } } - QualType getPromotionType(QualType Ty, bool IsDivOpCode = false) { + QualType getPromotionType(FPOptionsOverride Features, QualType Ty, +bool IsDivOpCode = false) { if (auto *CT = Ty-

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -347,6 +355,8 @@ class ComplexExprEmitter #define HANDLEBINOP(OP) \ ComplexPairTy VisitBin##OP(const BinaryOperator *E) { \ QualType promotionTy = getPromotionType(

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-15 Thread Phoebe Wang via cfe-commits
@@ -57594,6 +57599,86 @@ static SDValue combinePDEP(SDNode *N, SelectionDAG &DAG, return SDValue(); } +// Fixup the MMX intrinsics' types: in IR they are expressed with <1 x i64>, phoebewang wrote: Right. I forgot the 32bit case. https://github.com/llvm/l

[clang] [clang] Inject tokens containing #embed back into token stream (PR #97274)

2024-07-15 Thread Jakub Jelínek via cfe-commits
jakubjelinek wrote: I meant also e.g. basic tests like gcc/testsuite/c-c++-common/cpp/embed-20.c in https://gcc.gnu.org/pipermail/gcc-patches/2024-July/657053.html (and various others too). Just checked that one and it still fails on latest clang trunk using godbolt. https://github.com/llvm/ll

[clang] [Clang] Fix null pointer dereference in VisitUsingEnumDecl (PR #97910)

2024-07-15 Thread via cfe-commits
Sirraide wrote: CI failure looks unrelated. https://github.com/llvm/llvm-project/pull/97910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-15 Thread Phoebe Wang via cfe-commits
@@ -94,14 +94,15 @@ entry: ; ; MMX Store +; Note: doesn't actually emit a non-temporal store here. ; define void @test_mmx(ptr nocapture %a0, ptr nocapture %a1) { ; ALL-LABEL: test_mmx: ; ALL: # %bb.0: # %entry ; ALL-NEXT:movq (%rdi), %mm0 ; ALL-NEXT:psrl

[clang-tools-extra] [clang-doc] add enum test (PR #97679)

2024-07-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,121 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/index.html -check-prefix=HTM

[clang-tools-extra] [clang-doc] add enum test (PR #97679)

2024-07-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,121 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/index.html -check-prefix=HTM

[clang-tools-extra] [clang-doc] add enum test (PR #97679)

2024-07-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,121 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --doxygen --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/index.html -check-prefix=HTM

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-15 Thread Mariya Podchishchaeva via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; Fznamznon wrote: I did MaxVectorAlign = 2^14 in base TargetInfo, ``` if (Ty->getAs() && getContext().getType

[clang] [TBAA] Emit int TBAA metadata on FP math libcall expf (PR #96025)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,43 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// The test may fail as time out on windows +// REQUIRES: system-linux + +// RUN: %clang -S -O3 -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,

[clang] 94efdff - [AArch64][RISCV] Document option --print-supported-extensions (#98698)

2024-07-15 Thread via cfe-commits
Author: Jonathan Thackray Date: 2024-07-15T16:06:07+01:00 New Revision: 94efdff84a8f6d52915b90b705fe991f4888c544 URL: https://github.com/llvm/llvm-project/commit/94efdff84a8f6d52915b90b705fe991f4888c544 DIFF: https://github.com/llvm/llvm-project/commit/94efdff84a8f6d52915b90b705fe991f4888c544.d

[clang] [AArch64][RISCV] Document option --print-supported-extensions (PR #98698)

2024-07-15 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/98698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-15 Thread Paul Kirth via cfe-commits
ilovepi wrote: > I don't think this possible since the line directive matches the line of the > html or md file you pipe into FileCheck, which is different from the line > that's define in the source code. I've opted for just matching any number to > make the test case less brittle I’m not s

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,270 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=html --output=%t --executor=standalone %s +// RUN: clang-doc --format=md --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/index_json.js -check-prefix=JSON-INDEX +// RUN: FileCheck %s < %

[clang] [clang][ExtractAPI][NFC] Remove some nullptr dereference problems (PR #98914)

2024-07-15 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg created https://github.com/llvm/llvm-project/pull/98914 A places try to get a NamedDecl's name using getName when it isn't a simple identifier, migrate these areas to getNameAsString. rdar://125315602 >From 20a72b3170d284f1f984d1dc7c868fe5632df510 Mon Sep 17

[clang] [clang][ExtractAPI][NFC] Remove some nullptr dereference problems (PR #98914)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Daniel Grumberg (daniel-grumberg) Changes A places try to get a NamedDecl's name using getName when it isn't a simple identifier, migrate these areas to getNameAsString. rdar://125315602 --- Full diff: https://github.com/llvm/llvm-projec

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-15 Thread Phoebe Wang via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; phoebewang wrote: I think set `MaxVectorAlign = 2^14` in base TargetInfo only should solve the problem and won't result

[clang-tools-extra] [clang-doc] add nested namespace test case (PR #97681)

2024-07-15 Thread Paul Kirth via cfe-commits
ilovepi wrote: To clarify my earlier comment, FileCheck is just matching text on the input based on the check lines. So in this cases the LINE directive should just affect what text will be accepted when doin matching. It won’t try to match the lines to the position in the file being checked.

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-15 Thread Mariya Podchishchaeva via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; Fznamznon wrote: I'm not sure it will? With only modifying base TargetInfo clang will continue emit LLVM IR where giant

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-15 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/98629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/7] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] [PS4/PS5][NFC] Split PScpu::Linker into PS4/PS5 classes (PR #98884)

2024-07-15 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4/PS5][NFC] Split PScpu::Linker into PS4/PS5 classes (PR #98884)

2024-07-15 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Looks like you don't have write permission so I'll merge it for you. https://github.com/llvm/llvm-project/pull/98884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 03fe7a8 - [PS4/PS5][NFC] Split PScpu::Linker into PS4/PS5 classes (#98884)

2024-07-15 Thread via cfe-commits
Author: Edd Dawson Date: 2024-07-15T11:36:45-04:00 New Revision: 03fe7a83ce79d43b63052e7762573b57a8c52db8 URL: https://github.com/llvm/llvm-project/commit/03fe7a83ce79d43b63052e7762573b57a8c52db8 DIFF: https://github.com/llvm/llvm-project/commit/03fe7a83ce79d43b63052e7762573b57a8c52db8.diff LO

[clang] [PS4/PS5][NFC] Split PScpu::Linker into PS4/PS5 classes (PR #98884)

2024-07-15 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/98884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4/PS5][NFC] Split PScpu::Linker into PS4/PS5 classes (PR #98884)

2024-07-15 Thread via cfe-commits
github-actions[bot] wrote: @playstation-edd Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with

[clang] [PS4/PS5][NFC] Split PScpu::Linker into PS4/PS5 classes (PR #98884)

2024-07-15 Thread Edd Dawson via cfe-commits
playstation-edd wrote: > Looks like you don't have write permission so I'll merge it for you. Thanks! https://github.com/llvm/llvm-project/pull/98884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-15 Thread James Y Knight via cfe-commits
@@ -7,7 +7,7 @@ define <2 x i32> @test_pswapdsi(<2 x i32> %a) nounwind readnone { jyknight wrote: Done. https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-15 Thread James Y Knight via cfe-commits
@@ -936,6 +936,24 @@ X86 Support ^^^ - Remove knl/knm specific ISA supports: AVX512PF, AVX512ER, PREFETCHWT1 +- Support has been removed for the AMD "3DNow!" instruction-set. + Neither modern AMD CPUs, nor any Intel CPUs implement these + instructions, and they were

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-15 Thread James Y Knight via cfe-commits
@@ -481,7 +481,7 @@ defm WriteAESKeyGen : X86SchedWritePair; // Key Generation. // Carry-less multiplication instructions. defm WriteCLMul : X86SchedWritePair; -// EMMS/FEMMS jyknight wrote: Thanks, done. That was a leftover from a previous iteration where I

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/5] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-07-15 Thread via cfe-commits
Sirraide wrote: > This seems to have the desired effect of only paying for the feature when > it's in use. It does seem to have helped a bit, yeah. https://github.com/llvm/llvm-project/pull/96844 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-07-15 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/96844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-15 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > I think the next reland needs to cover the non-type template case, so that we > have a way to suppress the warning for all cases (this gives developer time > to do the cleanup transition). @hokein The problem with the non-type template case is that we would have to check t

[clang] c2fab5a - Fix memory leak in unit test

2024-07-15 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-15T12:13:49-04:00 New Revision: c2fab5a4c69c857061b06b9a826bf4730821e483 URL: https://github.com/llvm/llvm-project/commit/c2fab5a4c69c857061b06b9a826bf4730821e483 DIFF: https://github.com/llvm/llvm-project/commit/c2fab5a4c69c857061b06b9a826bf4730821e483.diff

[clang] [clang][Sema] Add support for OpenBSD's syslog format attribute (PR #97366)

2024-07-15 Thread via cfe-commits
Sirraide wrote: >> Hmm, this function also seems to exist on Linux, though. Additionally, from >> my man syslog docs: > I'm not sure what you mean by that in relation to this addition of a format > attribute. I think my question was mainly as to why `syslog` is treated as an OpenBSD feature

[clang] [clang][Sema] Add support for OpenBSD's syslog format attribute (PR #97366)

2024-07-15 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. So yeah, this still needs a release note, and I don’t think we should be treating it / referring to it as an openbsd-exclusive feature, but apart from that the changes LGTM. https://github.com/llvm/llvm-project/pull/97366

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-07-15 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > That's a pretty substantial policy change to propose, and this probably isn't > the place to propose/discuss it. If that's your intent, probably best to take > that up on discord. > I am not proposing a policy change. I believe the current policy is aimed at giving an escap

[clang] [Clang] Guard against null in template instantiation process (PR #97913)

2024-07-15 Thread via cfe-commits
@@ -636,6 +636,9 @@ bool Sema::SetupConstraintScope( ? FD->getInstantiatedFromMemberFunction() : FD->getInstantiatedFromDecl(); +if (!InstantiatedFrom) + return true; + smanna12 wrote: Thank you @zyn0217 for the reviews and cl

[clang] [Clang] Guard against null in template instantiation process (PR #97913)

2024-07-15 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/97913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Given the amount of pain involved, I think this should be applied as a C++23 change rather than applied as a DR. I'd like to avoid adding a feature flag for this if possible (I'd prefer warning-default-as-error instead, but that doesn't seem particularly plausible here), bu

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-15 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/98547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,799 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang-tools-extra] Allow specifying pipe syntax for use-ranges checks (PR #98696)

2024-07-15 Thread Piotr Zegar via cfe-commits
@@ -166,6 +166,15 @@ utils::UseRangesCheck::ReplacerMap UseRangesCheck::getReplacerMap() const { return Result; } +UseRangesCheck::UseRangesCheck(StringRef Name, ClangTidyContext *Context) +: utils::UseRangesCheck(Name, Context), + UseReversePipe(Options.get("UseRe

[clang] [llvm] [X86][MC,Driver] Support -msse2avx to encode SSE instruction with VEX prefix (PR #96860)

2024-07-15 Thread via cfe-commits
https://github.com/JaydeepChauhan14 updated https://github.com/llvm/llvm-project/pull/96860 >From b4a534ad6f811cf0868b7fd1ee641fae8502e171 Mon Sep 17 00:00:00 2001 From: Chauhan Jaydeep Ashwinbhai Date: Thu, 27 Jun 2024 15:17:50 +0800 Subject: [PATCH 01/15] [X86][MC] Added support for -msse2avx

[clang-tools-extra] [libc] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-15 Thread via cfe-commits
https://github.com/akshaykumars614 updated https://github.com/llvm/llvm-project/pull/98757 >From 283ec53fe19f0008c3c04210ea5c9b20c3d9781c Mon Sep 17 00:00:00 2001 From: akshaykumars614 Date: Sat, 13 Jul 2024 14:14:53 -0400 Subject: [PATCH 1/5] clang-tidy: readability-redundant-smartptr-get does

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-15 Thread Matheus Izvekov via cfe-commits
@@ -7416,10 +7416,11 @@ NamedDecl *Sema::ActOnVariableDeclarator( tryToFixVariablyModifiedVarType(TInfo, R, D.getIdentifierLoc(), /*DiagID=*/0); - if (const AutoType *AutoT = R->getAs()) -CheckConstrainedAuto( -AutoT, -

[clang] [llvm] [X86][MC,Driver] Support -msse2avx to encode SSE instruction with VEX prefix (PR #96860)

2024-07-15 Thread via cfe-commits
@@ -2711,6 +2711,8 @@ static void CollectArgsForIntegratedAssembler(Compilation &C, } if (!UseRelaxRelocations) CmdArgs.push_back("-mrelax-relocations=no"); + if (Args.hasArg(options::OPT_msse2avx)) +CmdArgs.push_back("-msse2avx"); JaydeepChauhan1

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread Justin Bogner via cfe-commits
https://github.com/bogner ready_for_review https://github.com/llvm/llvm-project/pull/90553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) Changes This adds a new document about DXIL Resource Handling. I've attempted to describe here how we intend to use TargetExtTypes to represent resources in LLVM IR and the various intrinsics we'll need to

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Justin Bogner (bogner) Changes This adds a new document about DXIL Resource Handling. I've attempted to describe here how we intend to use TargetExtTypes to represent resources in LLVM IR and the various intrinsi

[clang] [llvm] [X86][MC,Driver] Support -msse2avx to encode SSE instruction with VEX prefix (PR #96860)

2024-07-15 Thread via cfe-commits
https://github.com/JaydeepChauhan14 updated https://github.com/llvm/llvm-project/pull/96860 >From b4a534ad6f811cf0868b7fd1ee641fae8502e171 Mon Sep 17 00:00:00 2001 From: Chauhan Jaydeep Ashwinbhai Date: Thu, 27 Jun 2024 15:17:50 +0800 Subject: [PATCH 01/16] [X86][MC] Added support for -msse2avx

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/8] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] [HLSL] Remove hlsl::Resource (PR #98938)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Justin Bogner (bogner) Changes This was added in an effort to support resource types before we created the HLSLResource builtin type, but it isn't needed. --- Full diff: https://github.com/llvm/llvm-project/pull/

[clang] [llvm] [X86][MC,Driver] Support -msse2avx to encode SSE instruction with VEX prefix (PR #96860)

2024-07-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/96860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/98940 Summary: Currently there are several layers to handle `printf`. Since we now have varargs and an implementation of `printf` this can be heavily simplified. 1. The frontend renames `printf` into `omp_vprintf` and

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libc Author: Joseph Huber (jhuber6) Changes Summary: Currently there are several layers to handle `printf`. Since we now have varargs and an implementation of `printf` this can be heavily simplified. 1. The frontend renames `printf` into `omp_vprintf` a

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-offload Author: Joseph Huber (jhuber6) Changes Summary: Currently there are several layers to handle `printf`. Since we now have varargs and an implementation of `printf` this can be heavily simplified. 1. The frontend renames `printf` into `omp_vprintf

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-15 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag created https://github.com/llvm/llvm-project/pull/98941 Add support for checking mismatched ownership_returns/ownership_takes attributes. Closes #76861 >From e08dd7946051202d35199bf181602f88589f8ed9 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Sun, 14 Jul 20

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pavel Skripkin (pskrgag) Changes Add support for checking mismatched ownership_returns/ownership_takes attributes. Closes #76861 --- Full diff: https://github.com/llvm/llvm-project/pull/98941.diff 2 Files Affected: - (modified) clang/

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/6] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0309709a6786653da7164334c83b09c9f37b943a 463a6c0cbaf46539be9fa9a2e89fe805d2bd4d7c --e

[clang] [llvm] [RISC-V] Remove experimental for Zicfiss/Zicfilp. (PR #98891)

2024-07-15 Thread Craig Topper via cfe-commits
topperc wrote: > Both of them are ratified. https://wiki.riscv.org/display/HOME/Ratified+Extensions Experimental is not the same not ratified. Moving an extension out of experimental should mean that the compiler generated code for a it is well tested and complete. Can you summarize the curren

[clang] [clang-tools-extra] [Clang][AST] Move NamespaceDecl bits to DeclContext (PR #98567)

2024-07-15 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > Is there any follow up work for this? @mizvekov Yes, but it's not directly related. I'm going to submit a patch in the future which stores the `SourceLocation` of the `inline` keyword for inline namespace, and perhaps another patch that extends `NestedNameSpecifier` such t

[clang-tools-extra] e6ec7c8 - [Clang][AST] Move NamespaceDecl bits to DeclContext (#98567)

2024-07-15 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-07-15T13:57:56-04:00 New Revision: e6ec7c8f74d1be778f4ddf794d0e2fb63b0dc3be URL: https://github.com/llvm/llvm-project/commit/e6ec7c8f74d1be778f4ddf794d0e2fb63b0dc3be DIFF: https://github.com/llvm/llvm-project/commit/e6ec7c8f74d1be778f4ddf794d0e2fb63b0dc3be

[clang] [clang-tools-extra] [Clang][AST] Move NamespaceDecl bits to DeclContext (PR #98567)

2024-07-15 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/98567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/90553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/90553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-15 Thread Damyan Pepper via cfe-commits
@@ -29,6 +29,7 @@ pointer of the template parameter type. The pointer is populated from a call to data through until lowering in the backend. Resource types are annotated with the ``HLSLResource`` attribute, which drives -code generation for resource binding metadata. The ``h

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-07-15 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 4e4bcdc19268543a8348736dede46d8f8cad0066 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH 1/3] [Clang] Introduce [[clang::coro_inplace_task]] --- clan

[clang] [llvm] [RISC-V] Remove experimental for Zicfiss/Zicfilp. (PR #98891)

2024-07-15 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: AFAIK LLD doesn't support Zicfilp yet, which I feel is a prerequisite to marking it as non-experimental https://github.com/llvm/llvm-project/pull/98891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-15 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/98832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-15 Thread Eli Friedman via cfe-commits
@@ -6106,11 +6111,14 @@ void CodeGenModule::emitIFuncDefinition(GlobalDecl GD) { Aliases.push_back(GD); - llvm::Type *DeclTy = getTypes().ConvertTypeForMem(D->getType()); - llvm::Type *ResolverTy = llvm::GlobalIFunc::getResolverFunctionType(DeclTy); + // The resolver mig

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-15 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. Not what I was expecting, but this works, sure. LGTM. https://github.com/llvm/llvm-project/pull/98832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] [llvm] [Coverage][MC/DC] Show uncoverable and unreachable conditions (PR #94137)

2024-07-15 Thread Alan Phipps via cfe-commits
evodius96 wrote: I think this is a useful option, thanks. So the default preserves existing behavior? I think that's perfect and amenable to change in the future of needed. https://github.com/llvm/llvm-project/pull/94137 ___ cfe-commits mailing list c

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman deleted https://github.com/llvm/llvm-project/pull/97342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread Matt Arsenault via cfe-commits
@@ -5892,8 +5892,6 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, getTarget().getTriple().isAMDGCN() || (getTarget().getTriple().isSPIRV() && getTarget().getTriple().getVendor() == Triple::VendorType::AMD)) { -

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/98832 >From 15011e64e79627a3de2e4434549fabbf7fe86e09 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 14 Jul 2024 12:11:17 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Aaron Ballman via cfe-commits
@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-15 Thread Kim Gräsman via cfe-commits
kimgr wrote: @llvm-beanz Thanks for the pointers! Here's what I ended up with as a first step: https://github.com/include-what-you-use/include-what-you-use/commit/b03f60adb2a9fa884d35bea5eb77c9e8a05d80c0 I couldn't get the `get_target_property` spelling you suggested to work (it doesn't resolv

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/98940 >From c5be26a03cde6a4818e44298a37e41addc2cb4c5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 15 Jul 2024 12:42:09 -0500 Subject: [PATCH] [OpenMP][libc] Remove special handling for OpenMP printf Summary:

[clang] [libc] [llvm] [OpenMP][libc] Remove special handling for OpenMP printf (PR #98940)

2024-07-15 Thread Joseph Huber via cfe-commits
@@ -5892,8 +5892,6 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, getTarget().getTriple().isAMDGCN() || (getTarget().getTriple().isSPIRV() && getTarget().getTriple().getVendor() == Triple::VendorType::AMD)) { -

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/98832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/98832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-15 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/9] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-15 Thread Kim Gräsman via cfe-commits
kimgr wrote: > The LLVM_EXTERNAL_PROJECT mode solution using $ won't work > so well, > as it pins the resource directory to the build tree. So it won't resolve > correctly after install, I suppose. Ah, in that mode I guess we could use the default behavior, and not override the resource dir.

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-15 Thread Matheus Izvekov via cfe-commits
@@ -7416,10 +7416,11 @@ NamedDecl *Sema::ActOnVariableDeclarator( tryToFixVariablyModifiedVarType(TInfo, R, D.getIdentifierLoc(), /*DiagID=*/0); - if (const AutoType *AutoT = R->getAs()) -CheckConstrainedAuto( -AutoT, -

<    1   2   3   4   5   >