[clang] 9d88990 - [clang][Interp][NFC] Remove visit{Global,Local,This}Initializer

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T10:47:50+02:00 New Revision: 9d889906720c1a4fbdb3b8aaacfeebd62f235b87 URL: https://github.com/llvm/llvm-project/commit/9d889906720c1a4fbdb3b8aaacfeebd62f235b87 DIFF: https://github.com/llvm/llvm-project/commit/9d889906720c1a4fbdb3b8aaacfeebd62f235b87.diff LO

[clang] 181e4c6 - [clang][Interp] Check for non-primitive types in unary operators

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T10:47:51+02:00 New Revision: 181e4c6291c94a38c0ee89d2128f8d70b15d2d23 URL: https://github.com/llvm/llvm-project/commit/181e4c6291c94a38c0ee89d2128f8d70b15d2d23 DIFF: https://github.com/llvm/llvm-project/commit/181e4c6291c94a38c0ee89d2128f8d70b15d2d23.diff LO

[clang] [clang][driver] Improve Clang-CL support for C++20 standard modules (PR #98761)

2024-07-14 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr updated https://github.com/llvm/llvm-project/pull/98761 >From 1fed92a00f0d732a2575861c2bf6a6d053407255 Mon Sep 17 00:00:00 2001 From: Sharadh Rajaraman Date: Sat, 13 Jul 2024 19:25:47 +0100 Subject: [PATCH 1/2] Allow `--precompile` and `-fprebuilt-module-path` to be

[clang] [clang][driver] Improve Clang-CL support for C++20 standard modules (PR #98761)

2024-07-14 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr edited https://github.com/llvm/llvm-project/pull/98761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-07-14 Thread Nikolas Klauser via cfe-commits
@@ -0,0 +1,45 @@ +// RUN: %clang_cc1 %s -verify -fno-builtin -Werror=comment -Wno-error=abi -Wfatal-errors=assume -Wno-fatal-errors=assume + +#define diagnose_if(...) __attribute__((diagnose_if(__VA_ARGS__))) + +template +void diagnose_if_wcomma() diagnose_if(b, "oh no", "warnin

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-07-14 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/70976 >From a91f499900d4cea4804833d004b6c4e54a7d8b15 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Sun, 3 Sep 2023 17:26:28 -0700 Subject: [PATCH 1/7] [clang] Extend diagnose_if to accept more detailed warni

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-14 Thread Piyou Chen via cfe-commits
https://github.com/BeMg ready_for_review https://github.com/llvm/llvm-project/pull/85786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-14 Thread Piyou Chen via cfe-commits
BeMg wrote: 1. Drop the full arch string syntax due to this syntax be removed from spec. https://github.com/llvm/llvm-project/pull/85786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [mlir] [NFC] Fix some typos (PR #98791)

2024-07-14 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3f222f3 - [NFC] Fix some typos (#98791)

2024-07-14 Thread via cfe-commits
Author: c8ef Date: 2024-07-14T13:28:11+02:00 New Revision: 3f222f3bc65ca5acaa0c00d61ae132d10bf79282 URL: https://github.com/llvm/llvm-project/commit/3f222f3bc65ca5acaa0c00d61ae132d10bf79282 DIFF: https://github.com/llvm/llvm-project/commit/3f222f3bc65ca5acaa0c00d61ae132d10bf79282.diff LOG: [NF

[clang] [compiler-rt] [llvm] [mlir] [NFC] Fix some typos (PR #98791)

2024-07-14 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/98791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread via cfe-commits
@@ -17938,17 +17974,16 @@ void Sema::MarkFunctionReferenced(SourceLocation Loc, FunctionDecl *Func, if (FirstInstantiation || TSK != TSK_ImplicitInstantiation || Func->isConstexpr()) { - if (Func->isConstexpr()) + if (isa(Func->getDeclCon

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread via cfe-commits
https://github.com/cor3ntin commented: Thanks a lot for working on this regression https://github.com/llvm/llvm-project/pull/98758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread via cfe-commits
@@ -5340,20 +5341,31 @@ bool Sema::CheckCXXDefaultArgExpr(SourceLocation CallLoc, FunctionDecl *FD, struct ImmediateCallVisitor : public RecursiveASTVisitor { const ASTContext &Context; - ImmediateCallVisitor(const ASTContext &Ctx) : Context(Ctx) {} + llvm::SmallPtrSetIm

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/98758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread via cfe-commits
@@ -16983,6 +16995,30 @@ Sema::VerifyIntegerConstantExpression(Expr *E, llvm::APSInt *Result, SmallVector Notes; EvalResult.Diag = &Notes; + // Check if the expression refers to local functions yet to be instantiated. + // If so, instantiate them now, as the constant ev

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread via cfe-commits
@@ -5340,20 +5341,31 @@ bool Sema::CheckCXXDefaultArgExpr(SourceLocation CallLoc, FunctionDecl *FD, struct ImmediateCallVisitor : public RecursiveASTVisitor { const ASTContext &Context; - ImmediateCallVisitor(const ASTContext &Ctx) : Context(Ctx) {} + llvm::SmallPtrSetIm

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 commented: Curiously, if we move the call to lambda wrapper out of the function, then it would compile even on trunk -- https://gcc.godbolt.org/z/aEcajcEvE I probably overlooked something here. https://github.com/llvm/llvm-project/pull/98758 _

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/98758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-14 Thread via cfe-commits
@@ -1519,7 +1519,8 @@ bool Sema::IsAtLeastAsConstrained(NamedDecl *D1, auto IsExpectedEntity = [](const FunctionDecl *FD) { FunctionDecl::TemplatedKind Kind = FD->getTemplatedKind(); return Kind == FunctionDecl::TK_NonTemplate || - Kind == FunctionDe

[clang] [lld] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)

2024-07-14 Thread via cfe-commits
https://github.com/whitequark updated https://github.com/llvm/llvm-project/pull/92677 >From 5f8f347ca1ddcda307a7fc2e3ef7d33c5f2c398d Mon Sep 17 00:00:00 2001 From: Catherine Date: Sun, 19 May 2024 04:41:27 + Subject: [PATCH] Conditionalize use of POSIX features missing on WASI/WebAssembly.

[clang] [lld] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)

2024-07-14 Thread via cfe-commits
https://github.com/whitequark updated https://github.com/llvm/llvm-project/pull/92677 >From 69bd8547e9cc1268ca41339c98b2b17d13d69be3 Mon Sep 17 00:00:00 2001 From: Catherine Date: Sun, 19 May 2024 04:41:27 + Subject: [PATCH] Conditionalize use of POSIX features missing on WASI/WebAssembly.

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/97860 >From cb3c677c9eb10998ed7357cdde2722f3b3c1c847 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 6 Jul 2024 00:24:06 +0300 Subject: [PATCH] [Clang] prevent checking destructor reference with an invalid in

[clang] Adds a pseudonym to clang"s windows mangler... (PR #97792)

2024-07-14 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: LGTM, but I don't have the commit access, hence cannot merge your PR. Someone closely related to the community should take a look. https://github.com/llvm/llvm-project/pull/97792 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] 677cc15 - clang/AMDGPU: Defeat attribute optimization in attribute test

2024-07-14 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2024-07-14T19:15:54+04:00 New Revision: 677cc15e0ff2e0e6aa30538eb187990a6a8f53c0 URL: https://github.com/llvm/llvm-project/commit/677cc15e0ff2e0e6aa30538eb187990a6a8f53c0 DIFF: https://github.com/llvm/llvm-project/commit/677cc15e0ff2e0e6aa30538eb187990a6a8f53c0.diff

[clang] Fix broken link (PR #98818)

2024-07-14 Thread Anita Hammer via cfe-commits
https://github.com/anitahammer created https://github.com/llvm/llvm-project/pull/98818 None >From 66ed69a43ef3896a6f2a7a35e8b127c29a71222a Mon Sep 17 00:00:00 2001 From: Anita Hammer <166057949+anitaham...@users.noreply.github.com> Date: Sun, 14 Jul 2024 16:24:32 +0100 Subject: [PATCH] Update U

[clang] Fix broken link (PR #98818)

2024-07-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix broken link (PR #98818)

2024-07-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Anita Hammer (anitahammer) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/98818.diff 1 Files Affected: - (modified) clang/docs/UsersManual.rst (+1-1) ``diff diff --git a/clang/docs/UsersManual.rst b/clang/d

[clang] [clang][driver] Improve Clang-CL support for C++20 standard modules (PR #98761)

2024-07-14 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr updated https://github.com/llvm/llvm-project/pull/98761 >From 1fed92a00f0d732a2575861c2bf6a6d053407255 Mon Sep 17 00:00:00 2001 From: Sharadh Rajaraman Date: Sat, 13 Jul 2024 19:25:47 +0100 Subject: [PATCH 1/3] Allow `--precompile` and `-fprebuilt-module-path` to be

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -10,6 +10,7 @@ // RUN: %clang -Ofast -fno-strict-aliasing -### %s 2>&1 | FileCheck -check-prefix=CHECK-OFAST-NO-STRICT-ALIASING %s // RUN: %clang -Ofast -fno-vectorize -### %s 2>&1 | FileCheck -check-prefix=CHECK-OFAST-NO-VECTORIZE %s +// CHECK-OFAST: warning: argument '-

[clang] [clang][driver] Support `--precompile` and `-fmodule-*` options in Clang-CL (PR #98761)

2024-07-14 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr edited https://github.com/llvm/llvm-project/pull/98761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -470,6 +470,9 @@ New Compiler Flags Deprecated Compiler Flags - +- ``-Ofast`` is deprecated in favor of ``-O3``, possibly combined with ``-ffast-math``. jyknight wrote: Suggestion: ``` - The ``-Ofast`` command-line option has been

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-14 Thread James Y Knight via cfe-commits
https://github.com/jyknight edited https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-14 Thread James Y Knight via cfe-commits
https://github.com/jyknight commented: Thanks for sending this. I had planned to, but hadn't gotten around to it yet. https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -442,6 +442,9 @@ def warn_drv_deprecated_arg : Warning< def warn_drv_deprecated_arg_no_relaxed_template_template_args : Warning< "argument '-fno-relaxed-template-template-args' is deprecated">, InGroup; +def warn_drv_deprecated_arg_ofast : Warning< + "argument '-Ofast'

[clang-tools-extra] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-14 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/98757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] clang-tidy: readability-redundant-smartptr-get does not remove -> (#97964) (PR #98757)

2024-07-14 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: > can you tell me where to add test case and release notes entry Tests: clang-tools-extra/test/clang-tidy/checkers/readability/redundant-smartptr-get.cpp Release notes: clang-tools-extra/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/98757 _

[clang] Fix a regression with alignas on structure members in C (PR #98642)

2024-07-14 Thread James Y Knight via cfe-commits
jyknight wrote: I'm not sure I understand what happened here, since `_Alignas` did work properly before this change, right? How/why are `_Alignas` and `alignas` acting differently from eachother in C23 mode? https://github.com/llvm/llvm-project/pull/98642 __

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-07-14 Thread David Blaikie via cfe-commits
dwblaikie wrote: > Also, I think we presently have sufficient review bandwidth in clang proper, > even including the area of modules, so that any non-trivial change can be > reviewed, and I also propose that we abstain from trying to directly commit > those. That's a pretty substantial policy

[clang] 33af112 - [clang][Interp] Fix modifying const objects in functions calls in ctors

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T17:47:11+02:00 New Revision: 33af112f99fe956fb93fb2b797a141ee93956283 URL: https://github.com/llvm/llvm-project/commit/33af112f99fe956fb93fb2b797a141ee93956283 DIFF: https://github.com/llvm/llvm-project/commit/33af112f99fe956fb93fb2b797a141ee93956283.diff LO

[clang] 3aae4ca - [clang][Interp] Improve InterpFrame::describe()

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T18:20:51+02:00 New Revision: 3aae4caffa3134d4edd1811fd2c35cbc95eb7441 URL: https://github.com/llvm/llvm-project/commit/3aae4caffa3134d4edd1811fd2c35cbc95eb7441 DIFF: https://github.com/llvm/llvm-project/commit/3aae4caffa3134d4edd1811fd2c35cbc95eb7441.diff LO

[clang] [Clang] Reconsider the timing of instantiation of local constexpr lambdas (PR #98758)

2024-07-14 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @cor3ntin I'm stuck here for hours and I think I need some help. So let me explain what happens before #95660. Consider the example that doesn't compile before #95660: ```cpp template constexpr int func(F f) { constexpr bool y = f(1UL); return y; } int main() { auto predi

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -38,11 +38,11 @@ int test4(volatile int *addr) { return (int)oldval; } -// This should have both inputs be of type x86_mmx. +// This should have both inputs be of type <1 x i64>. jyknight wrote: No conflict, although the comment doesn't really have any v

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -1,9 +0,0 @@ -; RUN: llvm-as < %s | llvm-dis | FileCheck %s -; RUN: verify-uselistorder %s -; Basic smoke test for x86_mmx type. - -; CHECK: define x86_mmx @sh16 jyknight wrote: `x86_mmx` would be translated to `<1 x i64>`, like in the other tests. That is: ``

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -57594,6 +57599,86 @@ static SDValue combinePDEP(SDNode *N, SelectionDAG &DAG, return SDValue(); } +// Fixup the MMX intrinsics' types: in IR they are expressed with <1 x i64>, jyknight wrote: No -- the problem is that DAGtoDAG is after LegalizeTypes, a

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-14 Thread James Y Knight via cfe-commits
@@ -44,8 +44,8 @@ Type *Type::getPrimitiveType(LLVMContext &C, TypeID IDNumber) { case FP128TyID : return getFP128Ty(C); case PPC_FP128TyID : return getPPC_FP128Ty(C); case LabelTyID : return getLabelTy(C); - case MetadataTyID : return getMetadataTy(C); - case

[clang] [clang][driver] Support `--precompile` and `-fmodule-*` options in Clang-CL (PR #98761)

2024-07-14 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr edited https://github.com/llvm/llvm-project/pull/98761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. LGTM with a few minors https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
@@ -481,7 +481,7 @@ defm WriteAESKeyGen : X86SchedWritePair; // Key Generation. // Carry-less multiplication instructions. defm WriteCLMul : X86SchedWritePair; -// EMMS/FEMMS RKSimon wrote: keep these - FEMMS still uses this sched class https://github.com/l

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
@@ -936,6 +936,24 @@ X86 Support ^^^ - Remove knl/knm specific ISA supports: AVX512PF, AVX512ER, PREFETCHWT1 +- Support has been removed for the AMD "3DNow!" instruction-set. + Neither modern AMD CPUs, nor any Intel CPUs implement these + instructions, and they were

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
@@ -1341,7 +1341,7 @@ defm : Zn4WriteResXMMPair; // Key Gener // Carry-less multiplication instructions. defm : Zn4WriteResXMMPair; -// EMMS/FEMMS RKSimon wrote: keep these - FEMMS still uses this sched class https://github.com/llvm/llvm-project/pull/96246 _

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
@@ -1301,7 +1301,7 @@ defm : Zn3WriteResXMMPair; // Key Gener // Carry-less multiplication instructions. defm : Zn3WriteResXMMPair; -// EMMS/FEMMS RKSimon wrote: keep these - FEMMS still uses this sched class https://github.com/llvm/llvm-project/pull/96246

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-14 Thread Simon Pilgrim via cfe-commits
@@ -7,7 +7,7 @@ define <2 x i32> @test_pswapdsi(<2 x i32> %a) nounwind readnone { RKSimon wrote: update test title https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70306 >From 8825030bcb7f2249fbc37a9911b8b5a7afc56d15 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 25 Oct 2023 08:33:30 +0200 Subject: [PATCH] [clang][Interp] Implement dynamic memory allocat

[clang-tools-extra] [clang-tidy] Only expand macros in modernize-use-std-format/print (PR #97911)

2024-07-14 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe updated https://github.com/llvm/llvm-project/pull/97911 >From f6c1a231681092189a621e2bc6af97300b2a7bfa Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Wed, 12 Jun 2024 21:06:26 +0100 Subject: [PATCH 1/4] [clang-tidy] Only expand macros in modernize-use-std-format/

[clang-tools-extra] [clang-tidy] Only expand macros in modernize-use-std-format/print (PR #97911)

2024-07-14 Thread Mike Crowe via cfe-commits
mikecrowe wrote: > Unfortunately, walking the format string looking for macros also seems to > match a macro that encloses the whole function invocation. This results in > the check failing to work on expressions inside Catch2 `REQUIRE` macros for > example. > > My new test case (that current

[clang] fa133d3 - [clang][Interp] Implement dynamic memory allocation handling (#70306)

2024-07-14 Thread via cfe-commits
Author: Timm Baeder Date: 2024-07-14T19:58:17+02:00 New Revision: fa133d3151b5e428b1c5819d29b0ad28a90882a2 URL: https://github.com/llvm/llvm-project/commit/fa133d3151b5e428b1c5819d29b0ad28a90882a2 DIFF: https://github.com/llvm/llvm-project/commit/fa133d3151b5e428b1c5819d29b0ad28a90882a2.diff L

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/70306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `clang` at step 4 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/764 Here is the relevant piece of t

[clang] 27f5c00 - [clang][Interp] Fix a build failure on Windows

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T20:15:20+02:00 New Revision: 27f5c00c607e08b3cdf37f3bf9f4ccf156de2ab4 URL: https://github.com/llvm/llvm-project/commit/27f5c00c607e08b3cdf37f3bf9f4ccf156de2ab4 DIFF: https://github.com/llvm/llvm-project/commit/27f5c00c607e08b3cdf37f3bf9f4ccf156de2ab4.diff LO

[clang] 93d2b23 - [test] Improve ifunc tests

2024-07-14 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-07-14T11:18:55-07:00 New Revision: 93d2b23ad2b96ed47b68a7e3c142cb306f418f2a URL: https://github.com/llvm/llvm-project/commit/93d2b23ad2b96ed47b68a7e3c142cb306f418f2a DIFF: https://github.com/llvm/llvm-project/commit/93d2b23ad2b96ed47b68a7e3c142cb306f418f2a.diff

[clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via cfe-commits
https://github.com/vortex73 created https://github.com/llvm/llvm-project/pull/98827 - [ ] Added Option to statically build lldb - [ ] Packages lldb for easier package finding in other builds. >From 8ecf1b30678503f96d41112feb3ac87944c13158 Mon Sep 17 00:00:00 2001 From: Vortex Date: Sun, 14 Jul

[clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Narayan (vortex73) Changes - [ ] Added Option to statically build lldb - [ ] Packages lldb for easier package finding in other builds. --- Full diff: https://github.com/llvm/llvm-project/pull/98827.diff 4 Files Affected: - (modified) cl

[clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via cfe-commits
https://github.com/vortex73 edited https://github.com/llvm/llvm-project/pull/98827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Add Static Build option for LLDB Libraries (PR #98827)

2024-07-14 Thread via cfe-commits
https://github.com/vortex73 closed https://github.com/llvm/llvm-project/pull/98827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-14 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x64-windows-msvc` running on `windows-gcebot2` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/63/builds/509 Here is the relevant piece of the build l

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/98832 When an ifunc is emitted before its resolver, the resolver is created by `GetOrCreateLLVMFunction` without ever calling `SetFunctionAttributes`. The causes missing `!kcfi_type` with -fsanitize=kcfi. ``` extern vo

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes When an ifunc is emitted before its resolver, the resolver is created by `GetOrCreateLLVMFunction` without ever calling `SetFunctionAttributes`. The causes missing `!kcfi_typ

[clang] [clang] inherit GD to let the codegen add kcfi type for ifunc (PR #96400)

2024-07-14 Thread Fangrui Song via cfe-commits
MaskRay wrote: > The usual mechanism for emitting deferred definitions involves > CodeGenModule::EmitDeferred(): declarations get added to the list by > addDeferredDeclToEmit(), then it goes through to emit all the declarations on > the list. So it's a matter of making sure the resolver ends u

[clang] ba3dcec - Revert "[clang][Interp] Fix a build failure on Windows"

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T21:17:39+02:00 New Revision: ba3dcec16b6bb955f2c65a3df157744069441d7f URL: https://github.com/llvm/llvm-project/commit/ba3dcec16b6bb955f2c65a3df157744069441d7f DIFF: https://github.com/llvm/llvm-project/commit/ba3dcec16b6bb955f2c65a3df157744069441d7f.diff LO

[clang] 48d703e - Revert "[clang][Interp] Implement dynamic memory allocation handling (#70306)"

2024-07-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-14T21:17:47+02:00 New Revision: 48d703e7f56282ce5d690e45a129a4a7fd040ee6 URL: https://github.com/llvm/llvm-project/commit/48d703e7f56282ce5d690e45a129a4a7fd040ee6 DIFF: https://github.com/llvm/llvm-project/commit/48d703e7f56282ce5d690e45a129a4a7fd040ee6.diff LO

[clang] [CodeGen] Set attributes on resolvers emitted after ifuncs (PR #98832)

2024-07-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/98832 >From 15011e64e79627a3de2e4434549fabbf7fe86e09 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 14 Jul 2024 12:11:17 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (PR #95024)

2024-07-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/95024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia][CMake] Use MinSizeRel for baremetal runtimes (PR #98835)

2024-07-14 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/98835 Size matters more than performance for these targets. >From 7125521d0fd280a89f5a5576eec512bb99aa7dde Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Sun, 14 Jul 2024 13:27:08 -0700 Subject: [PATCH] [Fuchsia][C

[clang] [clang] Emitting a warning if optimizations are enabled with sanitizers (PR #95934)

2024-07-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. . https://github.com/llvm/llvm-project/pull/95934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia][CMake] Use MinSizeRel for baremetal runtimes (PR #98835)

2024-07-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes Size matters more than performance for these targets. --- Full diff: https://github.com/llvm/llvm-project/pull/98835.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+4-4) ``

[clang] [llvm] [X86][MC,Driver] Support -msse2avx to encode SSE instruction with VEX prefix (PR #96860)

2024-07-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. This driver option needs a `TargetSpecific` flag, otherwise this LGTM. https://github.com/llvm/llvm-project/pull/96860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang] Make the GPU toolchains implicitly link `-lm` and `-lc` (PR #98170)

2024-07-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. LGTM, if @yxsamliu who has reviewed this is happy. https://github.com/llvm/llvm-project/pull/98170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] 73acf8d - [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (#95024)

2024-07-14 Thread via cfe-commits
Author: Craig Topper Date: 2024-07-14T13:39:17-07:00 New Revision: 73acf8d755e04996f17b7694b4794459e492dede URL: https://github.com/llvm/llvm-project/commit/73acf8d755e04996f17b7694b4794459e492dede DIFF: https://github.com/llvm/llvm-project/commit/73acf8d755e04996f17b7694b4794459e492dede.diff

[clang] [llvm] [RISCV] Add -m[no-]scalar-strict-align and -m[no-]vector-strict-align. (PR #95024)

2024-07-14 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/95024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] AMDGPU: Move attributor into optimization pipeline (PR #83131)

2024-07-14 Thread via cfe-commits
dyung wrote: @arsenm are you aware that there is a test failure from this change that is still failing now about 16 hours later? Can you please take a look and revert if you need time to investigate so that we can get the bots back to green? Some failing bots: 1. https://lab.llvm.org/buildbot/

[clang] ca4ebae - [clang][NFC] Fix a warning (#98611)

2024-07-14 Thread via cfe-commits
Author: Piotr Fusik Date: 2024-07-14T22:44:19+02:00 New Revision: ca4ebae38c09b48c78789b77e7a98ec149957716 URL: https://github.com/llvm/llvm-project/commit/ca4ebae38c09b48c78789b77e7a98ec149957716 DIFF: https://github.com/llvm/llvm-project/commit/ca4ebae38c09b48c78789b77e7a98ec149957716.diff L

[clang] [clang][NFC] Fix a warning (PR #98611)

2024-07-14 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik closed https://github.com/llvm/llvm-project/pull/98611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia][CMake] Use MinSizeRel for baremetal runtimes (PR #98835)

2024-07-14 Thread via cfe-commits
https://github.com/zeroomega approved this pull request. https://github.com/llvm/llvm-project/pull/98835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adds a pseudonym to clang"s windows mangler... (PR #97792)

2024-07-14 Thread via cfe-commits
https://github.com/memory-thrasher updated https://github.com/llvm/llvm-project/pull/97792 >From d7223618f85cb14009c1b224b3b705cc78c54974 Mon Sep 17 00:00:00 2001 From: Sidney Kelley Date: Thu, 4 Jul 2024 23:03:16 -0700 Subject: [PATCH] Adds support to clang"s windows mangler to handle template

[clang] 6ffa995 - [Fuchsia][CMake] Use MinSizeRel for baremetal runtimes (#98835)

2024-07-14 Thread via cfe-commits
Author: Petr Hosek Date: 2024-07-14T13:50:34-07:00 New Revision: 6ffa995517a9b4c15aba0eb511cba309e21808cf URL: https://github.com/llvm/llvm-project/commit/6ffa995517a9b4c15aba0eb511cba309e21808cf DIFF: https://github.com/llvm/llvm-project/commit/6ffa995517a9b4c15aba0eb511cba309e21808cf.diff LO

[clang] [Fuchsia][CMake] Use MinSizeRel for baremetal runtimes (PR #98835)

2024-07-14 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/98835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adds a pseudonym to clang"s windows mangler... (PR #97792)

2024-07-14 Thread via cfe-commits
memory-thrasher wrote: Alright. Pinging the other reviewers. @rnk @tahonermann @MaxEW707 @zmodem https://github.com/llvm/llvm-project/pull/97792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-14 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/96228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-14 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @shafik Thank you for your review. If the changes look good to @zyn0217, I would appreciate it if someone could merge them, as I don't have access. Thanks. https://github.com/llvm/llvm-project/pull/96228 ___ cfe-commits mailing list

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-14 Thread Oliver Hunt via cfe-commits
@@ -333,7 +338,8 @@ void CodeGenFunction::registerGlobalDtorWithLLVM(const VarDecl &VD, llvm::FunctionCallee Dtor, llvm::Constant *Addr) { // Create a function which calls the d

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-14 Thread Oliver Hunt via cfe-commits
@@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -triple arm64-apple-ios -fptrauth-calls -fcxx-exceptions -emit-llvm %s -o - | FileCheck %s + +class Foo { + public: + ~Foo() { + } +}; + +// CHECK-LABEL: define void @_Z1fv() +// CHECK: call void @__cxa_throw(ptr %{{.*}}, ptr @_ZTI3Foo, ptr

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-14 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/98276 >From 4b92c4af87a1a381dad09b243db4d3ec71d64738 Mon Sep 17 00:00:00 2001 From: John McCall Date: Wed, 18 Sep 2019 02:21:37 -0400 Subject: [PATCH 1/4] Sign function pointers passed to atexit and __cxa_atexit. Patch

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-07-14 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,170 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [clang] inherit GD to let the codegen add kcfi type for ifunc (PR #96400)

2024-07-14 Thread via cfe-commits
aokblast wrote: Wow, it helps me alot. I make the thing too complicate. I think I can close this PR. Thanks you two very much! https://github.com/llvm/llvm-project/pull/96400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang] inherit GD to let the codegen add kcfi type for ifunc (PR #96400)

2024-07-14 Thread via cfe-commits
https://github.com/aokblast closed https://github.com/llvm/llvm-project/pull/96400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-14 Thread Brian Cain via cfe-commits
https://github.com/androm3da approved this pull request. You might want to get approval from someone else - I'm not even remotely close to a maintainer here. https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@list

[clang] Resign function pointer (PR #98847)

2024-07-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0fc4e3052454391b7e54a05c1918527cf36c74cc b8e2bacfd917b190c62cdd296d51e8ba98cc4611 --e

  1   2   >