[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-07-12 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 4e4bcdc19268543a8348736dede46d8f8cad0066 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH 1/3] [Clang] Introduce [[clang::coro_inplace_task]] --- clan

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-07-12 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 4e4bcdc19268543a8348736dede46d8f8cad0066 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH 1/3] [Clang] Introduce [[clang::coro_inplace_task]] --- clan

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-07-12 Thread Xiang Li via cfe-commits
@@ -1,9 +1,10 @@ // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify -// expected-error@+1 {{invalid resource class specifier 'c' used; expected 'b', 's', 't', or 'u'}} -float a : register(c0, space1); +// valid, The register keywor

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-12 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @pranavk see #98613 https://github.com/llvm/llvm-project/pull/98547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-07-12 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Clarifying a couple of things here I think we need the distinction between simple NFC, for trivial, non-controversial and non-surprising changes like some renames, small whitespace / formatting change, documentation changes, and complex NFC, which requires some thinking and

[clang] [test] Precommit tests for PR96025, NFC (PR #98704)

2024-07-12 Thread via cfe-commits
https://github.com/vfdff created https://github.com/llvm/llvm-project/pull/98704 Check whether timeout exists in the Windows operating system. >From 1b8503202474c15aa46fc4cc9151003a8d3ca336 Mon Sep 17 00:00:00 2001 From: zhongyunde 00443407 Date: Fri, 12 Jul 2024 21:09:46 -0400 Subject: [PATCH]

[clang] [test] Precommit tests for PR96025, NFC (PR #98704)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Allen (vfdff) Changes Check whether timeout exists in the Windows operating system. --- Full diff: https://github.com/llvm/llvm-project/pull/98704.diff 1 Files Affected: - (added) clang/test/CodeGen/math-libcalls-tbaa.cpp (+38) `

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > > max aligment [...] LLVM Verifier accepts is 2^14 > > The verifier limit in most places is 2^32. It looks like 2^14 is specifically > for ByVal. And there isn't really any good reason for that limit; it was > arbitrarily chosen in > [66011c1](https://github.com/llvm/llvm-

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Phoebe Wang via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; phoebewang wrote: What's this used for? Can we limit it to 2^14? https://github.com/llvm/llvm-project/pull/98629 ___

[clang] [clang] Add option to opt out of the missing_dependent_template_keyword diagnostic (PR #98613)

2024-07-12 Thread Pranav Kant via cfe-commits
pranavk wrote: This doesn't seem to handle all the cases? See https://github.com/abseil/abseil-cpp/pull/1711 for absl build failures that are not silenced by using this option. https://github.com/llvm/llvm-project/pull/98613 ___ cfe-commits mailing l

[clang] [TBAA] Emit int TBAA metadata on FP math libcall expf (PR #96025)

2024-07-12 Thread via cfe-commits
vfdff wrote: hi @efriedma-quic I find the case will timeout even without this changes ,so would it reasonable to add **require Linux for this test** now ? https://buildkite.com/llvm-project/github-pull-requests/builds/80879#0190a9c3-b007-4daa-9656-0c8f00601ee9 https://github.com/llvm/llvm-p

[clang] [test] Precommit tests for PR96025, NFC (PR #98704)

2024-07-12 Thread via cfe-commits
vfdff wrote: require Linux for this test as it time out on Windows ? https://github.com/llvm/llvm-project/pull/98704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/96228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for this fix! https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I don't think the build error is related to this change. https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86_32][C++] fix 0 sized struct case in vaarg. (PR #86388)

2024-07-12 Thread Longsheng Mou via cfe-commits
CoTinker wrote: Inconsistency here is inevitable. Such struct `SuperEmpty { struct{ int a[0];} b;}` in c++ mode can not be ignored in i386 for that c++ fields are never empty, and its TypeInfo.Width = TypeInfo.Align = 0. https://github.com/llvm/llvm-project/blob/594989918bf9e178f3b7c5e200d700d0

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
shafik wrote: > The sad part is that MSVC and some old versions of GCC don't like `template` > being added here :( It looks like the description provides a workaround for gcc but a bug report against MSVC should be filed if we don' have one already. https://github.com/llvm/llvm-project/pull/9

[clang] [clang] Prevent dangling StringRefs (PR #98699)

2024-07-12 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM. If it does fix the mentioned issue, please add a release note. https://github.com/llvm/llvm-project/pull/98699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang][NFCI] Remove records of unsatisfied atomic expressions in ConstraintSatisfaction (PR #98654)

2024-07-12 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, I agree that we currently don't use it, so we might as well remove it. But the overall situation is all wrong, we shouldn't be storing fully formed diagnostic strings in the AST, we should be storing them as PartialDiagnostics. But

[clang] fb19649 - [Clang][NFCI] Remove records of unsatisfied atomic expressions in ConstraintSatisfaction (#98654)

2024-07-12 Thread via cfe-commits
Author: Younan Zhang Date: 2024-07-13T11:49:21+08:00 New Revision: fb19649535d3d31a748409542947d09291643204 URL: https://github.com/llvm/llvm-project/commit/fb19649535d3d31a748409542947d09291643204 DIFF: https://github.com/llvm/llvm-project/commit/fb19649535d3d31a748409542947d09291643204.diff

[clang] [Clang][NFCI] Remove records of unsatisfied atomic expressions in ConstraintSatisfaction (PR #98654)

2024-07-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/98654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Matheus Izvekov via cfe-commits
@@ -7416,10 +7416,11 @@ NamedDecl *Sema::ActOnVariableDeclarator( tryToFixVariablyModifiedVarType(TInfo, R, D.getIdentifierLoc(), /*DiagID=*/0); - if (const AutoType *AutoT = R->getAs()) -CheckConstrainedAuto( -AutoT, -

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Matheus Izvekov via cfe-commits
@@ -7416,10 +7416,11 @@ NamedDecl *Sema::ActOnVariableDeclarator( tryToFixVariablyModifiedVarType(TInfo, R, D.getIdentifierLoc(), /*DiagID=*/0); - if (const AutoType *AutoT = R->getAs()) -CheckConstrainedAuto( -AutoT, -

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-07-12 Thread Brian Cain via cfe-commits
https://github.com/androm3da created https://github.com/llvm/llvm-project/pull/98712 These can be used to create a fully-bootstrapped toolchain to target hexagon {baremetal,linux} with scripts like the ones in https://github.com/quic/toolchain_for_hexagon >From 3cb0ce53c66815496ac0b5296ee36aa

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brian Cain (androm3da) Changes These can be used to create a fully-bootstrapped toolchain to target hexagon {baremetal,linux} with scripts like the ones in https://github.com/quic/toolchain_for_hexagon --- Full diff: https://github.com/l

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov requested changes to this pull request. See previous comments, I think this is primarily an error recovery issue on the decltype, we shouldn't let it escape an undeduced auto, as that would confuse further analysis. https://github.com/llvm/llvm-project/pull/98622 __

[clang] [clang][Sema] Add support for OpenBSD's syslog format attribute (PR #97366)

2024-07-12 Thread Brad Smith via cfe-commits
brad0 wrote: > Hmm, this function also seems to exist on Linux, though. Additionally, from > my `man syslog` docs: I'm not sure what you mean by that in relation to this addition of a format attribute. > > The remaining arguments are a format, as in `printf(3)`, and any arguments > > require

[clang] [SPARC][clang] Add -m(no-)v8plus flags handling (PR #98713)

2024-07-12 Thread via cfe-commits
https://github.com/koachan created https://github.com/llvm/llvm-project/pull/98713 Implement handling for `-m(no-)v8plus` flags to allow the user to switch between V8 and V8+ mode with 32-bit code. Currently it only toggles the V9 feature bit, ABI and codegen changes will be done in future pa

[clang] [SPARC][clang] Add -m(no-)v8plus flags handling (PR #98713)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Koakuma (koachan) Changes Implement handling for `-m(no-)v8plus` flags to allow the user to switch between V8 and V8+ mode with 32-bit code. Currently it only toggles the V9 feature bit, ABI and codegen changes will be done in fut

[clang] 7d59020 - [clang][Interp][NFC] Remove unused include

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-13T07:25:47+02:00 New Revision: 7d5902025d20e00b1865d02dfe514fb35259ae2a URL: https://github.com/llvm/llvm-project/commit/7d5902025d20e00b1865d02dfe514fb35259ae2a DIFF: https://github.com/llvm/llvm-project/commit/7d5902025d20e00b1865d02dfe514fb35259ae2a.diff LO

[clang] 634128b - [clang][Interp][NFC] Remove some unused includes

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-13T07:25:47+02:00 New Revision: 634128be4610a4d85d92935109ed7761f0e06af1 URL: https://github.com/llvm/llvm-project/commit/634128be4610a4d85d92935109ed7761f0e06af1 DIFF: https://github.com/llvm/llvm-project/commit/634128be4610a4d85d92935109ed7761f0e06af1.diff LO

[clang] 66e6df2 - [clang][Interp] Fix one-past-end pointers going back into the block

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-13T07:25:47+02:00 New Revision: 66e6df22b5a509c16e50364d72b1a40bacaea91a URL: https://github.com/llvm/llvm-project/commit/66e6df22b5a509c16e50364d72b1a40bacaea91a DIFF: https://github.com/llvm/llvm-project/commit/66e6df22b5a509c16e50364d72b1a40bacaea91a.diff LO

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The size of ArgFlagsTy is, as far as I can tell, basically irrelevant: it's only used as part of computing the calling convention in isel. I don't think anyone will notice if it's a few bytes larger. The non-byval alignment limit was last adjusted in https://reviews.llvm

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Eli Friedman via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; efriedma-quic wrote: It's used in the same ASTContext code that's modified by this patch. Probably fine to adjust it fo

[clang] [clang] Prevent dangling StringRefs (PR #98699)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik requested changes to this pull request. It looks like we are using the same pattern that fix is using in `ASTStmtReader::VisitRequiresExpr` which gives me some comfort but I am not happy that we have a relatively complex and easy to get wrong operation repeated in thr

[clang] [llvm] [Coverage][MC/DC] Show uncoverable and unreachable conditions (PR #94137)

2024-07-12 Thread via cfe-commits
https://github.com/Lambdaris updated https://github.com/llvm/llvm-project/pull/94137 >From 23669f721d056d6e4961e2572e438e5c1f91cab1 Mon Sep 17 00:00:00 2001 From: Lambdaris Date: Sun, 2 Jun 2024 10:19:31 +0800 Subject: [PATCH 1/3] [coverage] Mark branches with either counter is zero as folded

[clang] [llvm] [Coverage][MC/DC] Show uncoverable and unreachable conditions (PR #94137)

2024-07-12 Thread via cfe-commits
Lambdaris wrote: Add an option "--mcdc-exclude" to control which conditions can be excluded from coverage. By default it's "constant,unreachable". https://github.com/llvm/llvm-project/pull/94137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [Coverage][MC/DC] Show uncoverable and unreachable conditions (PR #94137)

2024-07-12 Thread via cfe-commits
https://github.com/Lambdaris updated https://github.com/llvm/llvm-project/pull/94137 >From 23669f721d056d6e4961e2572e438e5c1f91cab1 Mon Sep 17 00:00:00 2001 From: Lambdaris Date: Sun, 2 Jun 2024 10:19:31 +0800 Subject: [PATCH 1/3] [coverage] Mark branches with either counter is zero as folded

[clang] 1fe406f - [Clang] Fix parsing of reversible type traits in template arguments (#95969)

2024-07-12 Thread via cfe-commits
Author: cor3ntin Date: 2024-07-13T08:53:02+02:00 New Revision: 1fe406fffe11dad0457a4d214ce67bf492196145 URL: https://github.com/llvm/llvm-project/commit/1fe406fffe11dad0457a4d214ce67bf492196145 DIFF: https://github.com/llvm/llvm-project/commit/1fe406fffe11dad0457a4d214ce67bf492196145.diff LOG:

[clang] [Clang] Fix parsing of reversible type traits in template arguments (PR #95969)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/95969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5