[clang] [Clang] Fix parsing of invalid type-requirement (PR #98545)

2024-07-12 Thread Younan Zhang via cfe-commits
@@ -11698,6 +11698,13 @@ Sema::ActOnTypenameType(Scope *S, SourceLocation TypenameLoc, // Construct a dependent template specialization type. assert(DTN && "dependent template has non-dependent name?"); assert(DTN->getQualifier() == SS.getScopeRep()); + ---

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > The android NDK code is wrong, but this no longer compiles (even with > -Wno-error). Well that's unfortunate! Thank you for letting us know. @alanzhao1 do you think it's reasonable for the workaround to only apply to code in system headers, or does the NDK get included a

[clang-tools-extra] [clang-doc] add enum test (PR #97679)

2024-07-12 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97679 >From b5e0335199541225a1b0eb5eaf661cd4df55dbd7 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 4 Jul 2024 01:14:11 -0400 Subject: [PATCH 1/4] [clang-doc] add enum test --- clang-tools-extra/test/clang-d

[clang] [C2y] Add documentation to conform to WG14 N3262; NFC (PR #98146)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Perhaps also update > > https://github.com/llvm/llvm-project/blob/345861b186645f82c0b812427fdafe6ebd62a058/clang/www/c_status.html#L1283-L1285 Oh what the heck, I thought I already did that! :-D But yes, I'll update that when landing, thank you! https://github.com/llvm/l

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Python part seems fine to me, but I'd like @DeinAlptraum to confirm that. https://github.com/llvm/llvm-project/pull/98489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-12 Thread via cfe-commits
@@ -30,6 +35,7 @@ template bool MapASTVisitor::mapDecl(const T *D) { if (D->getParentFunctionOrMethod()) return true; + llvm::timeTraceProfilerBegin("emit info phase", "emit info"); PeterChou1 wrote: emit info was originally meant to mean the code pa

[clang] 2c2148d - [C2y] Add documentation to conform to WG14 N3262; NFC (#98146)

2024-07-12 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-07-12T07:07:27-04:00 New Revision: 2c2148de851faaca5fe0f47bcac84a10fcd53017 URL: https://github.com/llvm/llvm-project/commit/2c2148de851faaca5fe0f47bcac84a10fcd53017 DIFF: https://github.com/llvm/llvm-project/commit/2c2148de851faaca5fe0f47bcac84a10fcd53017.diff

[clang] [C2y] Add documentation to conform to WG14 N3262; NFC (PR #98146)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/98146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-12 Thread via cfe-commits
@@ -13,12 +13,17 @@ #include "clang/Index/USRGeneration.h" #include "llvm/ADT/StringExtras.h" #include "llvm/Support/Error.h" +#include "llvm/Support/TimeProfiler.h" namespace clang { namespace doc { void MapASTVisitor::HandleTranslationUnit(ASTContext &Context) { + if

[clang] 84bc0a9 - [Clang] Fix parsing of invalid type-requirement (#98545)

2024-07-12 Thread via cfe-commits
Author: cor3ntin Date: 2024-07-12T13:12:14+02:00 New Revision: 84bc0a9e02bbcfc0f1e1333f642be37e687fb429 URL: https://github.com/llvm/llvm-project/commit/84bc0a9e02bbcfc0f1e1333f642be37e687fb429 DIFF: https://github.com/llvm/llvm-project/commit/84bc0a9e02bbcfc0f1e1333f642be37e687fb429.diff LOG:

[clang] [Clang] Fix parsing of invalid type-requirement (PR #98545)

2024-07-12 Thread via cfe-commits
cor3ntin wrote: Thanks! https://github.com/llvm/llvm-project/pull/98545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix parsing of invalid type-requirement (PR #98545)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/98545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8ef26f1 - [clang] Add option to opt out of the missing_dependent_template_keyword diagnostic (#98613)

2024-07-12 Thread via cfe-commits
Author: Haojian Wu Date: 2024-07-12T13:14:41+02:00 New Revision: 8ef26f1289bf069ccc0d6383f2f4c0116a1206c1 URL: https://github.com/llvm/llvm-project/commit/8ef26f1289bf069ccc0d6383f2f4c0116a1206c1 DIFF: https://github.com/llvm/llvm-project/commit/8ef26f1289bf069ccc0d6383f2f4c0116a1206c1.diff LO

[clang] [clang] Add option to opt out of the missing_dependent_template_keyword diagnostic (PR #98613)

2024-07-12 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/98613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/98489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Jannick Kremer via cfe-commits
@@ -1820,6 +1820,18 @@ def availability(self): return AvailabilityKind.from_id(self._availability) +@property +def binary_operator(self): +""" +Retrieves the opcode if this cursor points to a binary operator +:return: +""" + +

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum commented: The Python changes look good to me, just one part that might need changes. Can someone approve the CI workflows so we also get the results for the bindings tests to confirm? https://github.com/llvm/llvm-project/pull/98489 __

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-12 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/97860 >From cb3c677c9eb10998ed7357cdde2722f3b3c1c847 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 6 Jul 2024 00:24:06 +0300 Subject: [PATCH] [Clang] prevent checking destructor reference with an invalid in

[clang] [Clang] Fix parsing of reversible type traits in template arguments (PR #95969)

2024-07-12 Thread via cfe-commits
@@ -1385,6 +1385,12 @@ Parser::isCXXDeclarationSpecifier(ImplicitTypenameContext AllowImplicitTypename, if (!getLangOpts().ObjC && Next.is(tok::identifier)) return TPResult::True; +if (Next.is(tok::l_paren) && +Tok.getIdentifierInfo()->hasRevertedTokenID

[clang] [Clang] Fix parsing of reversible type traits in template arguments (PR #95969)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/95969 >From cd4427b8356ffd1385b33050c06e8f0263aafeb4 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 18 Jun 2024 20:44:16 +0200 Subject: [PATCH 1/2] [Clang] Fix parsing of reversible typetraits in template a

[clang] [clang][NFC] Fix a warning (PR #98611)

2024-07-12 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/98611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-12 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/96228 >From 9e2730da07df0ee5102912490a687ba40bf06def Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 24 Jun 2024 18:55:51 +0300 Subject: [PATCH] [Clang] fix cast failures by adjusting the resolution of record

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-12 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/96228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-07-12 Thread via cfe-commits
PeterChou1 wrote: > any progress here? I wanted to merge the test cases prs so we could view the regressions from the tests https://github.com/llvm/llvm-project/pull/93281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-12 Thread via cfe-commits
cor3ntin wrote: @ldionne https://github.com/llvm/llvm-project/pull/97619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-12 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s a-tarasyuk wrote: @shafik @zyn0217 could you please review this PR when you have a moment? Thanks! https://github.com/llvm/llvm-project/pull/96228 __

[clang-tools-extra] [clang-doc] modify basic-project test (PR #97684)

2024-07-12 Thread via cfe-commits
@@ -54,306 +54,249 @@ // JSON-INDEX-NEXT: }; // JSON-INDEX-NEXT: } -// HTML-SHAPE: -// HTML-SHAPE-NEXT: -// HTML-SHAPE-NEXT: class Shape -// HTML-SHAPE-NEXT: -// HTML-SHAPE-NEXT: -// HTML-SHAPE-NEXT: -// HTML-SHAPE-NEXT: -// HTML-SHAPE-NEXT: -// HTML-SHAPE-NEXT: -//

[clang] [Clang] Warn with -Wpre-c23-compat instead of -Wpre-c++17-compat for u8 character literals in C23 (PR #97210)

2024-07-12 Thread via cfe-commits
cor3ntin wrote: It's a bit weird to have an extension warning given we seem to not support u8 in older language modes at all https://www.godbolt.org/z/1KrqGeT1q I think we should support the extension before in addition of having a warning for it @AaronBallman https://github.com/llvm/llvm-p

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/21

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a4cdd94ed0afe76854f837ce3c49c74e712d721d 39b7b5a6af4fc7801ce98e33f802a2e17c29cd9b --e

[clang] [clang-tools-extra] [Clang][AST] Move NamespaceDecl bits to DeclContext (PR #98567)

2024-07-12 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @Endilll Should I go ahead with this change anyways? https://github.com/llvm/llvm-project/pull/98567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Thomas Wucher via cfe-commits
@@ -1820,6 +1820,18 @@ def availability(self): return AvailabilityKind.from_id(self._availability) +@property +def binary_operator(self): +""" +Retrieves the opcode if this cursor points to a binary operator +:return: +""" + +

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Thomas Wucher via cfe-commits
https://github.com/thomaswucher edited https://github.com/llvm/llvm-project/pull/98489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-msan` running on `sanitizer-buildbot5` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/164/builds/920 Here is the relevant

[clang] [Clang] Fix parsing of reversible type traits in template arguments (PR #95969)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Presuming precommit CI comes back without surprises, this LGTM! https://github.com/llvm/llvm-project/pull/95969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-07-12 Thread via cfe-commits
@@ -160,6 +160,8 @@ static char GetFirstChar(const Preprocessor &PP, const Token &Tok) { bool TokenConcatenation::AvoidConcat(const Token &PrevPrevTok, const Token &PrevTok, const Token &Tok) const { +

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Jannick Kremer via cfe-commits
@@ -1820,6 +1820,18 @@ def availability(self): return AvailabilityKind.from_id(self._availability) +@property +def binary_operator(self): +""" +Retrieves the opcode if this cursor points to a binary operator +:return: +""" + +

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread Budimir Aranđelović via cfe-commits
budimirarandjelovicsyrmia wrote: Problem is in function f41 where diagnosing depends on architecture and operating system. ``` void f41(char *out, ... /* args */) // #f41 { va_list args; char *ch; vscanf("%s", ch); vprintf(out, args); } ``` As this is unusual situation, I suppos

[clang] [clang][driver] Fix -print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-12 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \ +// RUN: --target=armv7em-apple-darwin \ +// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-HARD_STATIC %s +// CHECK-CLANGRT-HARD_STATIC: lib

[clang] [analyzer] Don't display the offset value in underflows (PR #98621)

2024-07-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/98621 Previously alpha.security.ArrayBoundV2 displayed the (negative) offset value when it reported an underflow, but this produced lots of very similar and redundant reports in certain situations. After this commi

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/1534 Here is

[clang] [clang][driver] Fix -print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-12 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun updated https://github.com/llvm/llvm-project/pull/98325 From 200d0b7ab622012fb8e74fcc40df6ba3be6bc215 Mon Sep 17 00:00:00 2001 From: Gabor Horvath Date: Mon, 8 Jul 2024 11:18:02 +0100 Subject: [PATCH] [clang][driver] Fix --print-libgcc-file-name on Darwin platforms

[clang] [analyzer] Don't display the offset value in underflows (PR #98621)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) Changes Previously alpha.security.ArrayBoundV2 displayed the (negative) offset value when it reported an underflow, but this produced lots of very similar and redundant reports in certain situations. After this com

[clang] [analyzer] Don't display the offset value in underflows (PR #98621)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) Changes Previously alpha.security.ArrayBoundV2 displayed the (negative) offset value when it reported an underflow, but this produced lots of very similar and redundant reports in certain situation

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-07-12 Thread via cfe-commits
cor3ntin wrote: In light of further complexities noted here, I'm abandoning this in favor of #95969 https://github.com/llvm/llvm-project/pull/96097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/96097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Don't display the offset value in underflows (PR #98621)

2024-07-12 Thread Donát Nagy via cfe-commits
@@ -609,7 +610,7 @@ void ArrayBoundCheckerV2::performCheck(const Expr *E, CheckerContext &C) const { // CHECK UPPER BOUND DefinedOrUnknownSVal Size = getDynamicExtent(State, Reg, SVB); if (auto KnownSize = Size.getAs()) { -// In a situation where both overflow and ov

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/98622 Apparently we can't assume that `AutoTypeLoc` from `AutoType` is always valid. Fixes #98164 >From 5310764fb4044bcd4229434e80b64870c4b4ee8c Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Fri, 12 Jul 202

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes Apparently we can't assume that `AutoTypeLoc` from `AutoType` is always valid. Fixes #98164 --- Full diff: https://github.com/llvm/llvm-project/pull/98622.diff 3 Files Affected: - (modified) clang/l

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/90574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-07-12 Thread Aaron Ballman via cfe-commits
@@ -905,6 +912,7 @@ void Preprocessor::Lex(Token &Result) { // This token is injected to represent the translation of '#include "a.h"' // into "import a.h;". Mimic the notional ';'. case tok::annot_module_include: +case tok::annot_repl_input_end: ---

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes generally LGTM but I'd love to hear from @ChuanqiXu9 as well. https://github.com/llvm/llvm-project/pull/90574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-07-12 Thread Aaron Ballman via cfe-commits
@@ -860,9 +861,15 @@ bool Preprocessor::HandleIdentifier(Token &Identifier) { ModuleImportLoc = Identifier.getLocation(); NamedModuleImportPath.clear(); IsAtImport = true; -ModuleImportExpectsIdentifier = true; CurLexerCallback = CLK_LexAfterModuleImport;

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: There are multiple distinct issues that were caught: build failure -- https://lab.llvm.org/buildbot/#/builders/72/builds/1123 sanitizer failure -- https://lab.llvm.org/buildbot/#/builders/164/builds/920 different failure from above -- https://lab.llvm.org/buildbot/#/builders

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Do you have an idea as to why the type location is invalid in the first place? https://github.com/llvm/llvm-project/pull/98622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Clang][NEON] Add neon target guard to intrinsics (PR #98624)

2024-07-12 Thread via cfe-commits
https://github.com/Lukacma created https://github.com/llvm/llvm-project/pull/98624 This patch improves reported error when NEON intrinsics are used without neon target feature. >From bbb844893d973f67ecc130595bfe4fe36b2cb707 Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Fri, 12 Jul 2024 12

[clang] [Clang][NEON] Add neon target guard to intrinsics (PR #98624)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Lukacma) Changes This patch improves reported error when NEON intrinsics are used without neon target feature. --- Full diff: https://github.com/llvm/llvm-project/pull/98624.diff 4 Files Affected: - (modified) clang/include/clang

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-12 Thread Thomas Wucher via cfe-commits
@@ -1820,6 +1820,18 @@ def availability(self): return AvailabilityKind.from_id(self._availability) +@property +def binary_operator(self): +""" +Retrieves the opcode if this cursor points to a binary operator +:return: +""" + +

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Do you have an idea as to why the type location is invalid in the first place? Looking at the new test, my guess is that `auto` remains undeduced, so it has nowhere to point out to. https://github.com/llvm/llvm-project/pull/98622 ___

[clang] [Clang][AArch64] Add missing SME/SVE2.1 feature macros (PR #98285)

2024-07-12 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. I am not sure the CI is failing for this patch with an Assert to insert a node. It does not seams to be related to the changes in here. https://github.com/llvm/llvm-project/pull/98285 ___

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM but I agree with Aaron that tracking exactly where we create an invalid Loc would be interesting. https://github.com/llvm/llvm-project/pull/98622 ___ cfe-commits mailing list cfe-commits@lis

[clang] [clang-tools-extra] [Clang][AST] Move NamespaceDecl bits to DeclContext (PR #98567)

2024-07-12 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > @Endilll Should I go ahead with this change anyways? I would prefer if you can reduce the scope of the PR by avoiding the introduction of `NamespaceDeclBits` (it looks like you do more than just that). But if you feel strongly about it, I don't want to hold you off because of

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang,llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/1309 Here is the relevant

[clang] [clang] Fix crash in concept deprecation (PR #98622)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Do you have an idea as to why the type location is invalid in the first > > place? > > Looking at the new test, my guess is that `auto` remains undeduced, so it has > nowhere to point out to. Even when it's undeduced, we should still have a source location for it becau

[clang] Add __builtin_fma16. (PR #97424)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Changes LGTM but please be sure to add a release note when landing so users know about the improvement. https://github.com/llvm/llvm-project/pull/97424 ___ cfe-commits mailing list cfe-commit

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang,llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/1300 Here is the relevant pie

[clang] [Clang] Warn with -Wpre-c23-compat instead of -Wpre-c++17-compat for u8 character literals in C23 (PR #97210)

2024-07-12 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > It's a bit weird to have an extension warning given we seem to not support u8 > in older language modes at all https://www.godbolt.org/z/1KrqGeT1q > > I think we should support the extension before in addition of having a > warning for it @AaronBallman It's not an extens

[clang] [Clang] Warn with -Wpre-c23-compat instead of -Wpre-c++17-compat for u8 character literals in C23 (PR #97210)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/76612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM aside from a minor code formatting suggestion. https://github.com/llvm/llvm-project/pull/76612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-07-12 Thread Aaron Ballman via cfe-commits
@@ -233,6 +233,7 @@ ENUM_CODEGENOPT(StructReturnConvention, StructReturnConventionKind, 2, SRCK_Defa CODEGENOPT(RelaxAll , 1, 0) ///< Relax all machine code instructions. CODEGENOPT(RelaxedAliasing , 1, 0) ///< Set when -fno-strict-aliasing is enabled. +CODEGENOPT

[clang] [llvm] [AArch64] Make user-visible Arm architecture version strings consistent (PR #98550)

2024-07-12 Thread Jonathan Thackray via cfe-commits
@@ -472,22 +472,22 @@ def FeatureFP8 : ExtensionWithMArch<"fp8", "FP8", "FEAT_FP8", "Enable FP8 instructions", [FeatureFAMINMAX, FeatureLUT, FeatureBF16]>; def FeatureFP8FMA : ExtensionWithMArch<"fp8fma", "FP8FMA", "FEAT_FP8FMA", - "Enable fp8 multiply-add instructions",

[clang] [llvm] [AArch64] Make user-visible Arm architecture version strings consistent (PR #98550)

2024-07-12 Thread Jonathan Thackray via cfe-commits
@@ -210,29 +210,29 @@ def FeatureDotProd : ExtensionWithMArch<"dotprod", "DotProd", "FEAT_DotProd", "Enable dot product support", [FeatureNEON]>; def FeatureMPAM : Extension<"mpam", "MPAM", "FEAT_MPAM", - "Enable v8.4-A Memory system Partitioning and Monitoring extension">

[clang] [llvm] [AArch64] Make user-visible Arm architecture version strings consistent (PR #98550)

2024-07-12 Thread Jonathan Thackray via cfe-commits
jthackray wrote: > LGTM. Seems like there are still many more inconsistencies that could be > improved too. Yes, the more I looked through, the more I spotted. I'm aiming to get something merged before llvm19 branching, since these are (much more) user-visible now. https://github.com/llvm/llv

[clang] [llvm] [AArch64] Make user-visible Arm architecture version strings consistent (PR #98550)

2024-07-12 Thread Jonathan Thackray via cfe-commits
@@ -106,24 +106,24 @@ def FeatureSpecRestrict : Extension<"specrestrict", "SpecRestrict", "FEAT_CSV2_2 //===--===// def FeatureLSE : ExtensionWithMArch<"lse", "LSE", "FEAT_LSE", - "Enable ARMv8.1 Large Syst

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -51,6 +52,9 @@ namespace clang { namespace clangd { + +extern llvm::cl::opt ExperimentalModulesSupport; kadircet wrote: we don't need this declaration for the command line flag, we're already passing this through `ClangdLSPServer::Options`. https://githu

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,199 @@ +//===-- ProjectModules.h -*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,340 @@ +//===- ModulesBuilder.cpp *- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,110 @@ +//===- ModulesBuilder.h --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -112,6 +114,9 @@ class ClangdServer { /// This throttler controls which preambles may be built at a given time. clangd::PreambleThrottler *PreambleThrottler = nullptr; +/// Enable experimental support for modules. kadircet wrote: no i think tha

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,340 @@ +//===- ModulesBuilder.cpp *- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2024-07-12 Thread kadir çetinkaya via cfe-commits
@@ -0,0 +1,355 @@ +//===--- PrerequisiteModulesTests.cpp ---*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifi

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/98629 The max aligment that ISel and therefore LLVM Verifier accepts is 2^14. The patch also forces indirect passing and returning of vectors bigger than this limit for generic and x86_64 targets. >From ba498f559c7

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Mariya Podchishchaeva (Fznamznon) Changes The max aligment that ISel and therefore LLVM Verifier accepts is 2^14. The patch also forces indirect passing and returning of vectors bigger than this limit for generic and x86_64 target

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes The max aligment that ISel and therefore LLVM Verifier accepts is 2^14. The patch also forces indirect passing and returning of vectors bigger than this limit for

[clang] ba29e3a - [clang][OpenMP] Add early exit to/unindent `ActOnOpenMPLoopInitialization`

2024-07-12 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-07-12T08:18:28-05:00 New Revision: ba29e3a58dcdf0012df9fdaa3e7ed10cee56d5c5 URL: https://github.com/llvm/llvm-project/commit/ba29e3a58dcdf0012df9fdaa3e7ed10cee56d5c5 DIFF: https://github.com/llvm/llvm-project/commit/ba29e3a58dcdf0012df9fdaa3e7ed10cee56d5c5

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-07-12 Thread Florian Hahn via cfe-commits
@@ -233,6 +233,7 @@ ENUM_CODEGENOPT(StructReturnConvention, StructReturnConventionKind, 2, SRCK_Defa CODEGENOPT(RelaxAll , 1, 0) ///< Relax all machine code instructions. CODEGENOPT(RelaxedAliasing , 1, 0) ///< Set when -fno-strict-aliasing is enabled. +CODEGENOPT

[clang] [Clang] Disallow explicit object parameters in more contexts (PR #89078)

2024-07-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM -- @cor3ntin, are you happy with the changes as well? https://github.com/llvm/llvm-project/pull/89078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] 7a93508 - [clang][Interp] Reject calling function pointers if types don't match

2024-07-12 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-12T15:32:40+02:00 New Revision: 7a935089d4593de6767901810594058904412106 URL: https://github.com/llvm/llvm-project/commit/7a935089d4593de6767901810594058904412106 DIFF: https://github.com/llvm/llvm-project/commit/7a935089d4593de6767901810594058904412106.diff LO

[clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-12 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98387 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-07-12 Thread Budimir Aranđelović via cfe-commits
budimirarandjelovicsyrmia wrote: > @budimirarandjelovicsyrmia, can you please add a workaround so that the NDK > code can continue to compile? I will investigate this. https://github.com/llvm/llvm-project/pull/70307 ___ cfe-commits mailing list cfe-c

[clang] [Clang] [C23] Implement N2653: u8 strings are char8_t[] (PR #97208)

2024-07-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add another test project to clang-doc (PR #97518)

2024-07-12 Thread Paul Kirth via cfe-commits
ilovepi wrote: Closing wasn’t necessary. The changes here could have just been made the the basic project instead of as new files. https://github.com/llvm/llvm-project/pull/97518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang-tools-extra] [clang-doc] modify basic-project test (PR #97684)

2024-07-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM, but let’s update the pr title and description to match the current patch. Also, a title like modify tests isn’t very informative. Something like “Support markdown and simplify checks” seems more appropriate. Additionally, those two

<    1   2   3   4   5   >