[clang] [Clang] Move the builtin workaround logic to the lexer (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/96097 >From b77b2d9b10ad90ee67893904732003bf11eec21d Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 19 Jun 2024 19:47:43 +0200 Subject: [PATCH 1/5] [Clang] Move the builtin workaround logic to the lexer ---

[clang] [Clang] Move the builtin workaround logic to the lexer (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
@@ -1673,6 +1673,7 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { return II && HasExtension(*this, II->getName()); }); } else if (II == Ident__has_builtin) { +EvaluatingHasBuiltinMacro = true; Endilll wrote: I'm not particularly pro

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/96097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll ready_for_review https://github.com/llvm/llvm-project/pull/96097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes --- Patch is 83.35 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/96097.diff 19 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+4) - (modified) clang

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-06-29 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 5d7ebf65f321735debcd919aae6b6dcb4ed5537f Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH] [Clang] Introduce [[clang::coro_inplace_task]] --- clang/in

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/96097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-06-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cd0f89109bf90442cab8cfeaf5fce17cbddeef73 5d7ebf65f321735debcd919aae6b6dcb4ed5537f --

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: CC @MitalAshok https://github.com/llvm/llvm-project/pull/96097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: To clear potential confusion, Corentin suggested to me offline to take over this PR. I fixed the tests and implemented the workaround for `__has_builtin` case, which surfaced while I was fixing the tests. https://github.com/llvm/llvm-project/pull/96097 __

[clang] df067e5 - [clang][Interp][NFC] Pretty-print global temporary APValues

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T18:29:02+02:00 New Revision: df067e567f7793a7c82096df0387a6e6dd31a828 URL: https://github.com/llvm/llvm-project/commit/df067e567f7793a7c82096df0387a6e6dd31a828 DIFF: https://github.com/llvm/llvm-project/commit/df067e567f7793a7c82096df0387a6e6dd31a828.diff LO

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-29 Thread Thorsten Schütt via cfe-commits
tschuett wrote: If this is a new float type, could you please split out the apfloat changes in separate PR. https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread Paul Kirth via cfe-commits
@@ -979,6 +980,17 @@ static llvm::Error serializeIndex(ClangDocContext &CDCtx) { "error creating index file: " + FileErr.message()); } + llvm::SmallString<128> RootPath(CDCtx.OutDirectory); + if (llvm

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: This is almost there. I've left a few minor comments, but I'd like to see better testing here. I'm awfully surprised we don't need to update any test lines, other than the 1 JS check. It would really help to see how the output is changing, if that was capt

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread Paul Kirth via cfe-commits
@@ -7,6 +7,7 @@ // RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Rectangle.html -check-prefix=HTML-RECTANGLE // RUN: FileCheck %s -input-file=%t/docs/GlobalNamespace/Circle.html -check-prefix=HTML-CIRCLE +// JSON-INDEX: var RootPath = "{{.*}}"; ilove

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/93281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread Paul Kirth via cfe-commits
@@ -1,12 +1,19 @@ function genLink(Ref) { var Path = `${window.location.protocol}//${window.location.host}/${Ref.Path}`; + var isFileProtocol = window.location.protocol.startsWith("file"); + // we treat the file paths different depending on if we're + // serving via a http

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread Paul Kirth via cfe-commits
@@ -1,12 +1,19 @@ function genLink(Ref) { var Path = `${window.location.protocol}//${window.location.host}/${Ref.Path}`; + var isFileProtocol = window.location.protocol.startsWith("file"); + // we treat the file paths different depending on if we're + // serving via a http

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-29 Thread Paul Kirth via cfe-commits
@@ -80,8 +80,8 @@ function createIndex(Index) { // Runs after DOM loads document.addEventListener("DOMContentLoaded", function() { - // JsonIndex is a variable from another file that contains the index - // in JSON format - var Index = JSON.parse(JsonIndex); - createIndex(

[clang] [compiler-rt] [compiler-rt] adding safestack support for sunos platforms. (PR #95648)

2024-06-29 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/95648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 540fd42 - [compiler-rt] adding safestack support for sunos platforms. (#95648)

2024-06-29 Thread via cfe-commits
Author: David CARLIER Date: 2024-06-29T18:13:44+01:00 New Revision: 540fd42c755f20f7b79c6c79493ec36d8cb9b3d3 URL: https://github.com/llvm/llvm-project/commit/540fd42c755f20f7b79c6c79493ec36d8cb9b3d3 DIFF: https://github.com/llvm/llvm-project/commit/540fd42c755f20f7b79c6c79493ec36d8cb9b3d3.diff

[clang] [compiler-rt] [compiler-rt] adding safestack support for sunos platforms. (PR #95648)

2024-06-29 Thread David CARLIER via cfe-commits
https://github.com/devnexen closed https://github.com/llvm/llvm-project/pull/95648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix RuntimeInterfaceBuilder for 32-bit systems (PR #97071)

2024-06-29 Thread Eymen Ünay via cfe-commits
eymay wrote: Great work, I can imagine how hard it would be to uncover it! Small note: I think you may also want to remove the Arm macro guards that mask the unittest in the same commit, as you did in the previous [PR](https://github.com/llvm/llvm-project/pull/96900/files#diff-9b27f347e7ca15f9

[clang] [clang] Emitting a warning if optimizations are enabled with sanitizers (PR #95934)

2024-06-29 Thread Fangrui Song via cfe-commits
MaskRay wrote: I agree that we should not add a driver diagnostic. Using sanitizers with -O2/-O3 is pretty common, especially when user programs are so large that -O0 is too slow or does not build at all. I think msan is the most affected sanitizer which will detect fewer bugs. https://github.

[clang] [compiler-rt] [compiler-rt] adding safestack support for sunos platforms. (PR #95648)

2024-06-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang,compiler-rt` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/bu

[clang] [HLSL][clang][Driver] Fix error when using the option -fcgl in --driver-mode=dxc. (PR #97001)

2024-06-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/97001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] adding safestack support for sunos platforms. (PR #95648)

2024-06-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `clang,compiler-rt` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/772 Here is the relevant pie

[clang] d957da8 - [clang][Interp] Allow taking the address of a non-const global reference

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T19:55:29+02:00 New Revision: d957da83791930a3c23f4f936ca7c7644c4b07a4 URL: https://github.com/llvm/llvm-project/commit/d957da83791930a3c23f4f936ca7c7644c4b07a4 DIFF: https://github.com/llvm/llvm-project/commit/d957da83791930a3c23f4f936ca7c7644c4b07a4.diff LO

[clang] deb039e - [clang][Interp][NFC] Provide Program accessor for global temporaries

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T19:55:30+02:00 New Revision: deb039e69ed7efc94ef517809f36298f40359c21 URL: https://github.com/llvm/llvm-project/commit/deb039e69ed7efc94ef517809f36298f40359c21 DIFF: https://github.com/llvm/llvm-project/commit/deb039e69ed7efc94ef517809f36298f40359c21.diff LO

[clang] [clang][NFC] Move more functions from `Sema` to `SemaObjC` (PR #97172)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/97172 This patch continues the effort to split `Sema` up, moving more function to `SemaObjC`. Additional context can be found in https://github.com/llvm/llvm-project/pull/84184 and https://github.com/llvm/llvm-projec

[clang] [clang][NFC] Move more functions from `Sema` to `SemaObjC` (PR #97172)

2024-06-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch continues the effort to split `Sema` up, moving more function to `SemaObjC`. Additional context can be found in https://github.com/llvm/llvm-project/pull/84184 and https://github.com/llvm/l

[clang] [Clang] Prevent null pointer dereference in template deduction guide creation (PR #97097)

2024-06-29 Thread via cfe-commits
smanna12 wrote: Thank you @antangelo for reviews! https://github.com/llvm/llvm-project/pull/97097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f7fec8c - [Clang] Prevent null pointer dereference in template deduction guide creation (#97097)

2024-06-29 Thread via cfe-commits
Author: smanna12 Date: 2024-06-29T13:32:39-05:00 New Revision: f7fec8c80a986e82ef174080a3e07703c7b2c3c6 URL: https://github.com/llvm/llvm-project/commit/f7fec8c80a986e82ef174080a3e07703c7b2c3c6 DIFF: https://github.com/llvm/llvm-project/commit/f7fec8c80a986e82ef174080a3e07703c7b2c3c6.diff LOG:

[clang] [Clang] Prevent null pointer dereference in template deduction guide creation (PR #97097)

2024-06-29 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/97097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] adding safestack support for sunos platforms. (PR #95648)

2024-06-29 Thread Rainer Orth via cfe-commits
rorth wrote: This patch broke the [Solaris/amd64](https://lab.llvm.org/staging/#/builders/94/builds/4729) buildbot. For god's sake, can you please either test your Illumos patches on Solaris, too (there are Solaris buildbots in the cfarm for exactly such a purpose) and finally handle Issue #

[clang] [Clang] Prevent null pointer dereference in template deduction guide creation (PR #97097)

2024-06-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/776 Here is the relevant piece of the bui

[clang] [clang] Use std::make_unique (NFC) (PR #97176)

2024-06-29 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/97176 This patch is based on clang-tidy's modernize-make-unique but limited to those cases where type names are mentioned twice like std::unique_ptr(new Type()), which is a bit mouthful. >From 84e939e920af0c540

[clang] [clang] Use std::make_unique (NFC) (PR #97176)

2024-06-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kazu Hirata (kazutakahirata) Changes This patch is based on clang-tidy's modernize-make-unique but limited to those cases where type names are mentioned twice like std::unique_ptr(new Type()), which is a bit mouthful. --- Fu

[clang] [compiler-rt] [compiler-rt] adding safestack support for sunos platforms. (PR #95648)

2024-06-29 Thread David CARLIER via cfe-commits
devnexen wrote: oh I see let me figure out a fix, getting into it. https://github.com/llvm/llvm-project/pull/95648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-29 Thread Zequan Wu via cfe-commits
ZequanWu wrote: > @ZequanWu I can't successfully build your reproducer with clang trunk. Would > it be possible to provide the full test case or a fully reduced one? Because I reverted this change at https://github.com/llvm/llvm-project/commit/567b2c608c307c097315dd5ec4d6a5bbcddf898d, so it n

[clang] 8d4aa1f - [clang][Interp] Update global temporaries at the end of a declaration

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T21:10:24+02:00 New Revision: 8d4aa1f22ea08b12a7958b681e8a265f78cb349f URL: https://github.com/llvm/llvm-project/commit/8d4aa1f22ea08b12a7958b681e8a265f78cb349f DIFF: https://github.com/llvm/llvm-project/commit/8d4aa1f22ea08b12a7958b681e8a265f78cb349f.diff LO

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-29 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > > @ZequanWu I can't successfully build your reproducer with clang trunk. > > Would it be possible to provide the full test case or a fully reduced one? > > Because I reverted this change at > [567b2c6](https://github.com/llvm/llvm-project/commit/567b2c608c307c097315dd5ec4d6

[clang] [clang] Use std::make_unique (NFC) (PR #97176)

2024-06-29 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie edited https://github.com/llvm/llvm-project/pull/97176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use std::make_unique (NFC) (PR #97176)

2024-06-29 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/97176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Mital Ashok via cfe-commits
MitalAshok wrote: Looks like `!__is_identifier()` is used instead of `__has_builtin` sometimes. With this patch, `__is_identifier()` is true because there's no lparen after the name In libc++: 7f302f220e7b8727ed1bf8832dcc2d87b897e527 (Pretty easy fix to replace `__has_keyword(__reference_binds

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-29 Thread Zequan Wu via cfe-commits
ZequanWu wrote: > > > @ZequanWu I can't successfully build your reproducer with clang trunk. > > > Would it be possible to provide the full test case or a fully reduced one? > > > > > > Because I reverted this change at > > [567b2c6](https://github.com/llvm/llvm-project/commit/567b2c608c307c0

[clang] 37698d9 - [clang][Interp][NFC] Use CheckLoad() in Inc/Dec ops

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T21:10:24+02:00 New Revision: 37698d924840a229e5a1bece8f5e845e0f5c80a6 URL: https://github.com/llvm/llvm-project/commit/37698d924840a229e5a1bece8f5e845e0f5c80a6 DIFF: https://github.com/llvm/llvm-project/commit/37698d924840a229e5a1bece8f5e845e0f5c80a6.diff LO

[clang] [clang][NFC] Use range-based for loops (PR #96831)

2024-06-29 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/96831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-29 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > > > > @ZequanWu I can't successfully build your reproducer with clang trunk. > > > > Would it be possible to provide the full test case or a fully reduced > > > > one? > > > > > > > > > Because I reverted this change at > > > [567b2c6](https://github.com/llvm/llvm-project

[clang] 40f4bd1 - [clang][Interp] Allow reading mutable members if they were created...

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T21:10:24+02:00 New Revision: 40f4bd18f2fb01731fa7891fb7349e05dc98aeec URL: https://github.com/llvm/llvm-project/commit/40f4bd18f2fb01731fa7891fb7349e05dc98aeec DIFF: https://github.com/llvm/llvm-project/commit/40f4bd18f2fb01731fa7891fb7349e05dc98aeec.diff LO

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-06-29 Thread Guillot Tony via cfe-commits
https://github.com/to268 updated https://github.com/llvm/llvm-project/pull/79845 >From 44d103f75aef4227262b823fd5168c081307ce23 Mon Sep 17 00:00:00 2001 From: Guillot Tony Date: Mon, 29 Jan 2024 15:14:32 +0100 Subject: [PATCH 1/4] Implementation base of N3006 Underspecified object declarations

[clang] 5a8c4b5 - [clang][Interp] Don't allow reading from non-const blocks when returning

2024-06-29 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-29T21:10:25+02:00 New Revision: 5a8c4b597beed38e392f221042d29f475a3d1626 URL: https://github.com/llvm/llvm-project/commit/5a8c4b597beed38e392f221042d29f475a3d1626 DIFF: https://github.com/llvm/llvm-project/commit/5a8c4b597beed38e392f221042d29f475a3d1626.diff LO

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Looks like !__is_identifier() is used instead of > __has_builtin sometimes. With this patch, __is_identifier( trait name>) is true because there's no lparen after the name Thank you, I'll make `__is_identifier` work. > Apparantly __has_feature(__is_abstract) is also supposed t

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @zygoloid @cor3ntin @AaronBallman in the light of new data in https://github.com/llvm/llvm-project/pull/96097#issuecomment-2198314023, do you think this lex approach to revertible type trait identifiers is still viable? https://github.com/llvm/llvm-project/pull/96097 ___

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-06-29 Thread Guillot Tony via cfe-commits
to268 wrote: I've rebased the branch from main https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: ``` /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/uniform_int_dist.h:250:31: error: expected unqualified-id static_assert(!_Up_traits::__is_signed, "U must be unsigned"); ``` Results from CI are not making this any better. https://github.com/llvm/llvm

[clang] [clang] Warn when builtin names are used outside of invocations (PR #96097)

2024-06-29 Thread Mital Ashok via cfe-commits
MitalAshok wrote: What if we went in the other direction? We want to deprecate `__is_pointer` as an identifier, so only make it an identifier when it is being used by libstdc++ as an identifier. libstdc++ usage looks something like: ```c++ // type template template struct __is_pointer; templat

[clang] [llvm] Add f8E4M3 IEEE 754 type to llvm (PR #97179)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov created https://github.com/llvm/llvm-project/pull/97179 This PR adds `f8E4M3` type to llvm. `f8E4M3` type follows IEEE 754 convention ```c f8E4M3 (IEEE 754) - Exponent: 4 - Mantissa: 3 - Exponent bias: 7 - Follows IEEE 754 conventions for representation of specia

[clang] [llvm] Add f8E4M3 IEEE 754 type to llvm (PR #97179)

2024-06-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Alexander Pivovarov (apivovarov) Changes This PR adds `f8E4M3` type to llvm. `f8E4M3` type follows IEEE 754 convention ```c f8E4M3 (IEEE 754) - Exponent: 4 - Mantissa: 3 - Exponent bias: 7 - Follows IEEE 754 conventions for repres

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type to mlir (PR #97118)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type to mlir (PR #97118)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
apivovarov wrote: > If this is a new float type, could you please split out the apfloat changes > in separate PR. Sure - [PR-97179](https://github.com/llvm/llvm-project/pull/97179) Add f8E4M3 IEEE 754 type to llvm https://github.com/llvm/llvm-project/pull/97118 ___

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type to mlir (PR #97118)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type to mlir (PR #97118)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From 38a885014046f5e696a98361586919d14362dbed Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 21:09:33 + Subject: [PATCH 1/2] Add f8E4M3 IEEE 754 type to llvm --- clang/include

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type to mlir (PR #97118)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From 38a885014046f5e696a98361586919d14362dbed Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 21:09:33 + Subject: [PATCH 1/2] Add f8E4M3 IEEE 754 type to llvm --- clang/include

[clang] [CUDA][NFC] CudaArch to OffloadArch rename (PR #97028)

2024-06-29 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda updated https://github.com/llvm/llvm-project/pull/97028 >From 74eb15f035e4aed1dd19b735ac0b2fc5ad172213 Mon Sep 17 00:00:00 2001 From: Jakub Chlanda Date: Fri, 28 Jun 2024 09:25:56 + Subject: [PATCH] [CUDA][NFC] CudaArch to OffloadArch rename Rename CudaArch to O

[clang] [llvm] Add f8E4M3 IEEE 754 type to llvm (PR #97179)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97179 >From 639ca43f1c57657ecaeb43a097664bae008093fd Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 21:09:33 + Subject: [PATCH] Add f8E4M3 IEEE 754 type to llvm --- clang/include/cla

[clang] [llvm] Add f8E4M3 IEEE 754 type to llvm (PR #97179)

2024-06-29 Thread Alexander Pivovarov via cfe-commits
apivovarov wrote: Thorsten, Matt, What you think about adding the following tests? ```c // E4M3 <-> E5M2 ConvertE4M3ToE5M2 ConvertE5M2ToE4M3 // E4M3 <-> E4M3FN ConvertE4M3ToE4M3FN ConvertE4M3FNToE4M3 ``` @tschuett @arsenm https://github.com/llvm/llvm-project/pull/97179 _

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I'm concerned that we're calling EvaluateKnownConstInt on an lvalue; that might indicate there's something wrong with the AST. Usually there should be an lvalue-to-rvalue cast somewhere. https://github.com/llvm/llvm-project/pull/97146 _

[clang] [clang] Implement function pointer type discrimination (PR #96992)

2024-06-29 Thread Eli Friedman via cfe-commits
@@ -2220,6 +2220,11 @@ llvm::Constant *ConstantLValueEmitter::emitPointerAuthPointer(const Expr *E) { // The assertions here are all checked by Sema. assert(Result.Val.isLValue()); + auto *Base = Result.Val.getLValueBase().get(); + if (auto *Decl = dyn_cast_or_null(Base

[clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-06-29 Thread via cfe-commits
temyurchenko wrote: > Do you need someone to land these changes on your behalf? Given that the PR is approved, perhaps, yo > Do you need someone to land these changes on your behalf? @erichkeane, perhaps you can land these, given that the PR is approved? https://github.com/llvm/llvm-project/p

[clang] eb5dbaf - [clang] Use std::make_unique (NFC) (#97176)

2024-06-29 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-06-29T16:12:18-07:00 New Revision: eb5dbaf8d013839a66691e954a58d22a41f3c027 URL: https://github.com/llvm/llvm-project/commit/eb5dbaf8d013839a66691e954a58d22a41f3c027 DIFF: https://github.com/llvm/llvm-project/commit/eb5dbaf8d013839a66691e954a58d22a41f3c027.diff L

[clang] [clang] Use std::make_unique (NFC) (PR #97176)

2024-06-29 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/97176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-29 Thread via cfe-commits
https://github.com/CedricSwa updated https://github.com/llvm/llvm-project/pull/94865 >From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001 From: Cedric Schwarzer Date: Sat, 8 Jun 2024 17:52:02 +0200 Subject: [PATCH 1/5] Improve error message for invalid lambda captures --- c

[clang] [clang] Default to -fno-sized-deallocation for AIX (PR #97076)

2024-06-29 Thread Xing Xue via cfe-commits
https://github.com/xingxue-ibm updated https://github.com/llvm/llvm-project/pull/97076 >From d6a486c4f007297d087fe4454da3ec501e824825 Mon Sep 17 00:00:00 2001 From: Xing Xue Date: Fri, 28 Jun 2024 11:25:25 -0400 Subject: [PATCH 1/2] Default to -fno-sized-deallocation for AIX. --- clang/lib/Dr

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-29 Thread via cfe-commits
https://github.com/CedricSwa updated https://github.com/llvm/llvm-project/pull/94865 >From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001 From: Cedric Schwarzer Date: Sat, 8 Jun 2024 17:52:02 +0200 Subject: [PATCH 1/5] Improve error message for invalid lambda captures --- c

[clang] [clang-tools-extra] [clang-format] Aggregate options regarding empty lines (PR #96770)

2024-06-29 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/96770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2853a83 - [clang-format] Add option to remove leading blank lines (#91221)

2024-06-29 Thread via cfe-commits
Author: sstwcw Date: 2024-06-30T01:20:20Z New Revision: 2853a838d22b69f61ed376abbd9ab5e625111f44 URL: https://github.com/llvm/llvm-project/commit/2853a838d22b69f61ed376abbd9ab5e625111f44 DIFF: https://github.com/llvm/llvm-project/commit/2853a838d22b69f61ed376abbd9ab5e625111f44.diff LOG: [clang

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-29 Thread via cfe-commits
https://github.com/CedricSwa updated https://github.com/llvm/llvm-project/pull/94865 >From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001 From: Cedric Schwarzer Date: Sat, 8 Jun 2024 17:52:02 +0200 Subject: [PATCH 1/5] Improve error message for invalid lambda captures --- c

[clang-tools-extra] aec7670 - [clangd] Revert the change concerning new lines

2024-06-29 Thread via cfe-commits
Author: sstwcw Date: 2024-06-30T02:04:44Z New Revision: aec7670b5d6354b63b011c9ed0632b70983b0328 URL: https://github.com/llvm/llvm-project/commit/aec7670b5d6354b63b011c9ed0632b70983b0328 DIFF: https://github.com/llvm/llvm-project/commit/aec7670b5d6354b63b011c9ed0632b70983b0328.diff LOG: [clang

[clang] [clang-format] Add option to remove leading blank lines (PR #91221)

2024-06-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot7` while building `clang-tools-extra,clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/676 Here is the relev

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-29 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/97080 >From b49737505ad3ad84e977787daf141b98fe3e6607 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 29 Jun 2024 00:24:30 +0800 Subject: [PATCH 1/2] [WebAssembly] support getVT from wasm externref and funcr

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: > I'm concerned that we're calling EvaluateKnownConstInt on an lvalue; that > might indicate there's something wrong with the AST. Usually there should be > an lvalue-to-rvalue cast somewhere. @efriedma-quic lvalue-to-rvalue cast is done here at https://github.com/llvm/llvm-p

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-29 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/97080 >From b49737505ad3ad84e977787daf141b98fe3e6607 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 29 Jun 2024 00:24:30 +0800 Subject: [PATCH 1/2] [WebAssembly] support getVT from wasm externref and funcr

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-29 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > What happens if you compile a file that really vectorizes reference types? > The attached test doesn't seem to actually end up getting vectorized after > all. Can you add a test that get vectorized? Is it possible to vectorize external reference types? I don't think there

[clang] 6b737c4 - [clang][Sema] Fix crash on atomic builtins with incomplete type args (#96374)

2024-06-29 Thread via cfe-commits
Author: Takuya Shimizu Date: 2024-06-30T14:09:10+09:00 New Revision: 6b737c444617fe8c11eb48f978c579cc160bfff0 URL: https://github.com/llvm/llvm-project/commit/6b737c444617fe8c11eb48f978c579cc160bfff0 DIFF: https://github.com/llvm/llvm-project/commit/6b737c444617fe8c11eb48f978c579cc160bfff0.diff

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-29 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/96374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-29 Thread via cfe-commits
https://github.com/PeterChou1 approved this pull request. https://github.com/llvm/llvm-project/pull/96921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-29 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/8] [clang-doc] make loading of json side bar async --- clang-t

[clang] ab20086 - [CUDA][NFC] CudaArch to OffloadArch rename (#97028)

2024-06-29 Thread via cfe-commits
Author: Jakub Chlanda Date: 2024-06-30T07:56:07+02:00 New Revision: ab200864220b72b3bdf1fe9d001ad3d1e4d9d4b3 URL: https://github.com/llvm/llvm-project/commit/ab200864220b72b3bdf1fe9d001ad3d1e4d9d4b3 DIFF: https://github.com/llvm/llvm-project/commit/ab200864220b72b3bdf1fe9d001ad3d1e4d9d4b3.diff

[clang] [CUDA][NFC] CudaArch to OffloadArch rename (PR #97028)

2024-06-29 Thread Jakub Chlanda via cfe-commits
https://github.com/jchlanda closed https://github.com/llvm/llvm-project/pull/97028 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-29 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: Going to merge as the failed tests are not related to this PR. ``` cat github-pull-requests_build_76910_linux-linux-x64.log | grep -B 2 -A 10 "Failed Tests " -- Failed Tests (1): BO

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-29 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 closed https://github.com/llvm/llvm-project/pull/81442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93281 >From f5872e7c82d097ae3c141765d3f1d7e3d0b25b82 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 04:28:08 -0400 Subject: [PATCH 1/4] clang-doc switched from using relative to absolute paths ---

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-29 Thread via cfe-commits
@@ -1,12 +1,19 @@ function genLink(Ref) { var Path = `${window.location.protocol}//${window.location.host}/${Ref.Path}`; + var isFileProtocol = window.location.protocol.startsWith("file"); + // we treat the file paths different depending on if we're + // serving via a http

[clang] [TBAA] Emit int TBAA metadata on FP math libcalls (PR #96025)

2024-06-29 Thread via cfe-commits
vfdff wrote: hi, is there any new suggestion ? https://github.com/llvm/llvm-project/pull/96025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-29 Thread Nikita Popov via cfe-commits
https://github.com/nikic requested changes to this pull request. This is probably caused by some downstream patches in google3? https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp does not contain any mentions of `M->getFunction` or `M->getCont

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght created https://github.com/llvm/llvm-project/pull/97146 fixes https://github.com/llvm/llvm-project/issues/96670 The cause is that we might return a lvalue here at https://github.com/llvm/llvm-project/blob/3e53c97d33210db68188e731e93ee48dbaeeae32/clang/lib/AST/ExprC

[clang] [Clang][ExprConstant] fix constant expression did not evaluate to integer (PR #97146)

2024-06-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zhikai Zeng (Backl1ght) Changes fixes https://github.com/llvm/llvm-project/issues/96670 The cause is that we might return a lvalue here at https://github.com/llvm/llvm-project/blob/3e53c97d33210db68188e731e93ee48dbaeeae32/clang/lib/AST/Ex

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-06-29 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: ping https://github.com/llvm/llvm-project/pull/96228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >