Author: Younan Zhang
Date: 2024-06-27T18:49:58+08:00
New Revision: 2a948d11c0540004dc906d948bac58398bafe928
URL:
https://github.com/llvm/llvm-project/commit/2a948d11c0540004dc906d948bac58398bafe928
DIFF:
https://github.com/llvm/llvm-project/commit/2a948d11c0540004dc906d948bac58398bafe928.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/96864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtcxzyw wrote:
> Does that mean it has a negative net effect, or its neutral
It is neutral.
> (in which case the original motivating case should be enough).
But this patch may have an impact on compile time.
https://github.com/llvm/llvm-project/pull/96620
___
https://github.com/mydeveloperday commented:
You need to regenerate the clang-format-style options rst page using the tool
in clang/doc/tools
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/92731
>From 9107c1a0b215cc9af17f0168961b59edca3a9127 Mon Sep 17 00:00:00 2001
From: Julian Brown
Date: Wed, 1 May 2024 06:35:59 -0500
Subject: [PATCH] [OpenMP] OpenMP 5.1 "assume" directive parsing support
This is a mini
https://github.com/mahesh-attarde closed
https://github.com/llvm/llvm-project/pull/95257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mahesh-attarde wrote:
Thanks aaron for clearing assumptions. Will work on it with separate PR.
https://github.com/llvm/llvm-project/pull/95257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/zyn0217 commented:
Thanks for the patch.
While I think this makes sense, it still confuses me whether there was some
redundancy in the guard condition. Do we have any situation where `Pattern` is
non-null whereas `ParentFD` becomes null? I assume they are always paired, at
l
klensy wrote:
Small ping.
https://github.com/llvm/llvm-project/pull/92231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Simon Pilgrim
Date: 2024-06-27T12:29:55+01:00
New Revision: 286955caa32b5b9fd959176c85ffb925e8093a0d
URL:
https://github.com/llvm/llvm-project/commit/286955caa32b5b9fd959176c85ffb925e8093a0d
DIFF:
https://github.com/llvm/llvm-project/commit/286955caa32b5b9fd959176c85ffb925e8093a0d.diff
@@ -11523,10 +11525,16 @@ static bool CheckTargetCausesMultiVersioning(Sema &S,
FunctionDecl *OldFD,
const auto *OldTVA = OldFD->getAttr();
// If the old decl is NOT MultiVersioned yet, and we don't cause that
// to change, this is a simple redeclaration.
- if ((NewTA &
@@ -102,8 +102,9 @@ int __attribute__((target_version("sha2"))) combine(void) {
return 1; }
// expected-error@+1 {{multiversioned function declaration has a different
calling convention}}
int __attribute__((aarch64_vector_pcs, target_version("sha3"))) combine(void)
{ return 2
@@ -11523,10 +11525,16 @@ static bool CheckTargetCausesMultiVersioning(Sema &S,
FunctionDecl *OldFD,
const auto *OldTVA = OldFD->getAttr();
// If the old decl is NOT MultiVersioned yet, and we don't cause that
// to change, this is a simple redeclaration.
- if ((NewTA &
@@ -11498,11 +11502,9 @@ static void patchDefaultTargetVersion(FunctionDecl
*From, FunctionDecl *To) {
if (MVKindTo == MultiVersionKind::None &&
(MVKindFrom == MultiVersionKind::TargetVersion ||
- MVKindFrom == MultiVersionKind::TargetClones)) {
-To->setIsMu
@@ -102,8 +102,9 @@ int __attribute__((target_version("sha2"))) combine(void) {
return 1; }
// expected-error@+1 {{multiversioned function declaration has a different
calling convention}}
int __attribute__((aarch64_vector_pcs, target_version("sha3"))) combine(void)
{ return 2
https://github.com/NagyDonat approved this pull request.
The new changes also LGTM, feel free to merge this when you want.
https://github.com/llvm/llvm-project/pull/96295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
asmok-g wrote:
Hi!
Is it expected for this to fail with unique_ptrs ? We have a case in the code
where the return type is an alias to unique_ptr and it's failing. Also, cases
where the return type is something like
```
absl::Nullable>
```
that is failing. Is that expected ?
https://github.c
https://github.com/budimirarandjelovicsyrmia updated
https://github.com/llvm/llvm-project/pull/70307
From a66ca21ad79df2385fbaec12344f9c16cc3c5b83 Mon Sep 17 00:00:00 2001
From: budimirarandjelovicsyrmia
Date: Thu, 26 Oct 2023 10:39:52 +0200
Subject: [PATCH] [clang] Emit bad shift warnings
---
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/96084
>From 23844cd8b8fad07bce0c34f58430322090c5a793 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 19 Jun 2024 23:25:13 +0800
Subject: [PATCH 1/9] [Clang] Add diagnostic notes for implcitly generated
deductio
@@ -108,8 +108,11 @@ struct Foo {
Foo(T const (&)[N]);
};
+// FIXME: Prefer non-canonical template arguments in the deduction guide?
zyn0217 wrote:
Good to know that, remove the FIXME now.
https://github.com/llvm/llvm-project/pull/96084
___
@@ -2096,3 +2096,19 @@ let ArchGuard = "defined(__aarch64__) ||
defined(__arm64ec__)", TargetGuard = "r
def VLDAP1_LANE : WInst<"vldap1_lane", ".(c*!).I", "QUlQlUlldQdPlQPl">;
def VSTL1_LANE : WInst<"vstl1_lane", "v*(.!)I", "QUlQlUlldQdPlQPl">;
}
+
+//Lookup table read wi
@@ -6420,6 +6420,76 @@ def : Pat<(v16i8 (int_aarch64_neon_tbx1 (v16i8 V128:$Rd),
let Predicates = [HasLUT] in {
defm LUT2 : BaseSIMDTableLookupIndexed2<"luti2">;
defm LUT4 : BaseSIMDTableLookupIndexed4<"luti4">;
+
+ def : Pat<(v16i8 (int_aarch64_neon_vluti2_lane (v8i8 V64:
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/96084
>From 23844cd8b8fad07bce0c34f58430322090c5a793 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Wed, 19 Jun 2024 23:25:13 +0800
Subject: [PATCH 01/10] [Clang] Add diagnostic notes for implcitly generated
deduct
RKSimon wrote:
It would probably explain why the typo hasn't caused regression - I'm going off
static analysis reports here, not crash reports.
https://github.com/llvm/llvm-project/pull/96888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/94352
>From ff839bef048a65760f4cd0e9abafe11cfebd9362 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 4 Jun 2024 21:08:27 +0800
Subject: [PATCH 01/12] [RISCV] Add support for getHostCPUFeatures using
hwprobe
C
@@ -83,8 +83,14 @@ void riscv::getRISCVTargetFeatures(const Driver &D, const
llvm::Triple &Triple,
// and other features (ex. mirco architecture feature) from mcpu
if (Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) {
StringRef CPU = A->getValue();
-if (CPU == "nat
Author: Simon Pilgrim
Date: 2024-06-27T13:09:48+01:00
New Revision: 4d167fb28b8c8b2e278fb09b1c435db6d6393d56
URL:
https://github.com/llvm/llvm-project/commit/4d167fb28b8c8b2e278fb09b1c435db6d6393d56
DIFF:
https://github.com/llvm/llvm-project/commit/4d167fb28b8c8b2e278fb09b1c435db6d6393d56.diff
@@ -83,8 +83,14 @@ void riscv::getRISCVTargetFeatures(const Driver &D, const
llvm::Triple &Triple,
// and other features (ex. mirco architecture feature) from mcpu
if (Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) {
StringRef CPU = A->getValue();
-if (CPU == "nat
Author: Krzysztof Parzyszek
Date: 2024-06-27T07:16:27-05:00
New Revision: 34fe6da6e464e74a331c056d050074a6c9216527
URL:
https://github.com/llvm/llvm-project/commit/34fe6da6e464e74a331c056d050074a6c9216527
DIFF:
https://github.com/llvm/llvm-project/commit/34fe6da6e464e74a331c056d050074a6c9216527
https://github.com/kparzysz closed
https://github.com/llvm/llvm-project/pull/96811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/budimirarandjelovicsyrmia reopened
https://github.com/llvm/llvm-project/pull/70307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/budimirarandjelovicsyrmia updated
https://github.com/llvm/llvm-project/pull/70307
From 9e4309a805f31096d72cb21cd266175cac5b07c1 Mon Sep 17 00:00:00 2001
From: budimirarandjelovicsyrmia
Date: Thu, 26 Oct 2023 10:39:52 +0200
Subject: [PATCH] [clang] Emit bad shift warnings
---
AaronBallman wrote:
I was thinking about this more last night. The standard says:
> The macro
>`INFINITY`
> is defined if and only if the implementation supports an infinity for the
> type float. It expands to a
> constant expression of type float representing positive or unsigned infinity.
https://github.com/budimirarandjelovicsyrmia updated
https://github.com/llvm/llvm-project/pull/70307
From f8b8175f074c4caba44517ac9ea2714d50c5e86e Mon Sep 17 00:00:00 2001
From: budimirarandjelovicsyrmia
Date: Thu, 26 Oct 2023 10:39:52 +0200
Subject: [PATCH] [clang] Emit bad shift warnings
---
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/96900
todo
From 2e1eac5919a56fd15a7c79281d6544c4958d6874 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 27 Jun 2024 14:28:03 +0200
Subject: [PATCH] [clang-repl] Fix unboxing of va_a
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Stefan Gränitz (weliveindetail)
Changes
todo
---
Full diff: https://github.com/llvm/llvm-project/pull/96900.diff
3 Files Affected:
- (modified) clang/include/clang/Interpreter/Value.h (+2)
- (modified) clang/lib/Interpreter/Interpreter
@@ -102,8 +102,9 @@ int __attribute__((target_version("sha2"))) combine(void) {
return 1; }
// expected-error@+1 {{multiversioned function declaration has a different
calling convention}}
int __attribute__((aarch64_vector_pcs, target_version("sha3"))) combine(void)
{ return 2
alexey-bataev wrote:
> > > > don't you need more code in AST?
> > >
> > >
> > > Sorry, I don't quite understand the question! Could you elaborate a
> > > little please?
> >
> >
> > I was thinking maybe you need changes in AST related files, like
> > `ASTWriter.cpp`, but that might be not ne
nikic wrote:
Yes, this causes a massive compile-time regression:
http://llvm-compile-time-tracker.com/compare.php?from=253a294b54a6096a0b66f840931dd0e345d70c4f&to=20869e8ed55c58696ce4e9dc3d18cd6af01ed49c&stat=instructions:u
https://github.com/llvm/llvm-project/pull/96620
___
Author: Timm Baeder
Date: 2024-06-27T14:43:39+02:00
New Revision: 468d668c5c4031366ae38804927b450f9faf409c
URL:
https://github.com/llvm/llvm-project/commit/468d668c5c4031366ae38804927b450f9faf409c
DIFF:
https://github.com/llvm/llvm-project/commit/468d668c5c4031366ae38804927b450f9faf409c.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/83683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10343,6 +10343,23 @@ void CGOpenMPRuntime::emitTargetDataStandAloneCall(
MapNamesArray,
InputInfo.MappersArray.emitRawPointer(CGF)};
+// Nowait calls have header declarations that take 13 arguments. Hence, the
shiltian wrote:
You can m
https://github.com/shiltian commented:
Besides, don't you need to update clang tests?
https://github.com/llvm/llvm-project/pull/96386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/2] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
@@ -290,8 +290,24 @@ StringRef riscv::getRISCVArch(const llvm::opt::ArgList
&Args,
// 2. Get march (isa string) based on `-mcpu=`
if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) {
StringRef CPU = A->getValue();
-if (CPU == "native")
+if (CPU == "nativ
ichaer wrote:
Thanks, @mydeveloperday :). That made me realise I had to fix the comments as
well, I think they are OK now. Let me know what you think.
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/94352
>From ff839bef048a65760f4cd0e9abafe11cfebd9362 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 4 Jun 2024 21:08:27 +0800
Subject: [PATCH 01/13] [RISCV] Add support for getHostCPUFeatures using
hwprobe
C
https://github.com/shiltian approved this pull request.
https://github.com/llvm/llvm-project/pull/96738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/96738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12078,6 +12079,43 @@ static void DiagnoseFailedExplicitSpec(Sema &S,
OverloadCandidate *Cand) {
<< (ES.getExpr() ? ES.getExpr()->getSourceRange() : SourceRange());
}
+static void NoteImplicitDeductionGuide(Sema &S, CXXDeductionGuideDecl *DG) {
+ // We want to alway
https://github.com/hokein approved this pull request.
thanks, looks good.
https://github.com/llvm/llvm-project/pull/96084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/96084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -627,6 +627,9 @@ Improvements to Clang's diagnostics
used rather than when they are needed for constant evaluation or when code
is generated for them.
The check is now stricter to prevent crashes for some unsupported
declarations (Fixes #GH95495).
+- Clang now shows i
@@ -12078,6 +12079,43 @@ static void DiagnoseFailedExplicitSpec(Sema &S,
OverloadCandidate *Cand) {
<< (ES.getExpr() ? ES.getExpr()->getSourceRange() : SourceRange());
}
+static void NoteImplicitDeductionGuide(Sema &S, CXXDeductionGuideDecl *DG) {
+ // We want to alway
https://github.com/john-brawn-arm created
https://github.com/llvm/llvm-project/pull/96903
This adds intrinsics defined in ARM-software/acle#260
Doing this requires some changes to the GCS instruction definitions, as these
intrinsics make use of how some instructions don't modify the input regi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: John Brawn (john-brawn-arm)
Changes
This adds intrinsics defined in ARM-software/acle#260
Doing this requires some changes to the GCS instruction definitions, as these
intrinsics make use of how some instructions don't modify the input re
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: John Brawn (john-brawn-arm)
Changes
This adds intrinsics defined in ARM-software/acle#260
Doing this requires some changes to the GCS instruction definitions, as these
intrinsics make use of how some instructions don't modify th
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/96906
Use this to replace the emission of the amdgpu-unsafe-fp-atomics
attribute in favor of per-instruction metadata. In the future
new fine grained controls should be introduced that also cover
the integer cases.
Add
arsenm wrote:
* **#96906** https://app.graphite.dev/github/pr/llvm/llvm-project/96906?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈
* `main`
This stack of pull requests is managed by Graphite
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
Use this to replace the emission of the amdgpu-unsafe-fp-atomics
attribute in favor of per-instruction metadata. In the future
new fine grained controls should be introduced that also cover
the integ
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/96906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
### Merge activity
* **Jun 27, 9:27 AM EDT**: @arsenm started a stack merge that includes this
pull request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96738).
https://github.com/llvm/llvm-project/pull/96738
__
https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/96738
>From d16cc8ec8b9ad4780fcaa14a035193ee930cd8fe Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Tue, 11 Jun 2024 10:40:27 +0200
Subject: [PATCH 1/2] clang/AMDGPU: Use atomicrmw for ds fmin/fmax builtins
---
c
Author: Matt Arsenault
Date: 2024-06-27T15:32:08+02:00
New Revision: 8f63d154ec996cba590a83a4542dd545c78af85c
URL:
https://github.com/llvm/llvm-project/commit/8f63d154ec996cba590a83a4542dd545c78af85c
DIFF:
https://github.com/llvm/llvm-project/commit/8f63d154ec996cba590a83a4542dd545c78af85c.diff
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/96738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/96739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmcardle wrote:
Hi @asmok-g, it was definitely not my intention to break any use cases where
the analysis was behavior properly!
I wanted to verify that the prior release, which predates this change,
understands smart pointer returns on trylock functions, but I'm having trouble
finding a test
https://github.com/CarolineConcatto updated
https://github.com/llvm/llvm-project/pull/88499
>From a4d4a0ff71f5086c9fdf43e332b9752074eb42dc Mon Sep 17 00:00:00 2001
From: Caroline Concatto
Date: Thu, 11 Apr 2024 16:10:16 +
Subject: [PATCH 1/5] [CLANG][LLVM][AArch64]Add SME2.1 intrinsics for
@@ -102,8 +102,9 @@ int __attribute__((target_version("sha2"))) combine(void) {
return 1; }
// expected-error@+1 {{multiversioned function declaration has a different
calling convention}}
int __attribute__((aarch64_vector_pcs, target_version("sha3"))) combine(void)
{ return 2
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/96908
- Fix some errors in the snippet;
- update the code snippet to reflect the current implementation status in clang;
>From 8da371ef1450852e3dede28b1f1dcb7c27ede530 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Th
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/96628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
- Fix some errors in the snippet;
- update the code snippet to reflect the current implementation status in clang;
---
Full diff: https://github.com/llvm/llvm-project/pull/96908.diff
1 Files Affected:
- (modi
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/96628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/96628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -855,6 +863,25 @@ __rndrrs(uint64_t *__p) {
}
#endif
+/* 11.2 Guarded Control Stack intrinsics */
+#if defined(__ARM_64BIT_STATE) && __ARM_64BIT_STATE
+static __inline__ void * __attribute__((__always_inline__, __nodebug__))
+__gcspr() {
+ return (void *)__builtin_arm_rsr6
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/96908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DominikAdamski created
https://github.com/llvm/llvm-project/pull/96909
`-fcuda-is-device` flag is not used for OpenMP offloading for AMD GPUs and it
does not need to be added as clang cc1 option for OpenMP code.
>From 6bd9a2e440dd61184bf7f4061ea78fa8ed31e17c Mon Sep 17 00:00
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Dominik Adamski (DominikAdamski)
Changes
`-fcuda-is-device` flag is not used for OpenMP offloading for AMD GPUs and it
does not need to be added as clang cc1 option for OpenMP code.
---
Full diff: https://github.com/llvm/llvm-pro
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Dominik Adamski (DominikAdamski)
Changes
`-fcuda-is-device` flag is not used for OpenMP offloading for AMD GPUs and it
does not need to be added as clang cc1 option for OpenMP code.
---
Full diff: https://github.com/llvm/llvm-proje
https://github.com/jhuber6 approved this pull request.
We don't even pass this in the NVPTX offloading case, so there's no reason to
do it for AMDGPU.
https://github.com/llvm/llvm-project/pull/96909
___
cfe-commits mailing list
cfe-commits@lists.llvm.
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while
building `clang` at step 7 "test-build-stage1-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/168/bu
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T
*D) {
// If there is an error generating a USR for the decl, skip this decl.
if (index::generateUSRForDecl(D, USR))
return true;
+
+ // Prevent Visiting USR twice
+ {
+std::lock_guard Guard(USRVisi
tbaederr wrote:
That failure looks like it's just a case of
https://github.com/llvm/llvm-project/issues/54972
https://github.com/llvm/llvm-project/pull/83683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
mtrofin wrote:
Should this be discussed in a RFC on discourse?
https://github.com/llvm/llvm-project/pull/94693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Krzysztof Parzyszek
Date: 2024-06-27T09:05:48-05:00
New Revision: 4ed8796bfe7e2666b56ae9fc5b8fe9ec05e0566f
URL:
https://github.com/llvm/llvm-project/commit/4ed8796bfe7e2666b56ae9fc5b8fe9ec05e0566f
DIFF:
https://github.com/llvm/llvm-project/commit/4ed8796bfe7e2666b56ae9fc5b8fe9ec05e0566f
weiweichen wrote:
> Could you explain more about what broke? Are you using target(..) attributes?
`TargetInfo::CreateTargetInfo` is giving up back empty `opt->featureMap` for
`AArch64` while before the mentioned PR, we can get a list of features. Is
there a different way to get them back?
htt
weiweichen wrote:
> Could you explain more about what broke? Are you using target(..) attributes?
`TargetInfo::CreateTargetInfo` is giving up back empty `opt->featureMap` for
`AArch64`. But before the [PR
mentioned](https://github.com/llvm/llvm-project/pull/94279), we can get a list
of featur
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/96913
It is possible to get a qualified rvalue in C. Consider:
struct { cont int i; } foo();
_Generic(foo().i, ...);
foo() returns an rvalue for the anonymous structure, the member access
expression then resu
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
It is possible to get a qualified rvalue in C. Consider:
struct { cont int i; } foo();
_Generic(foo().i, ...);
foo() returns an rvalue for the anonymous structure, the member access
expression then
a-tarasyuk wrote:
ping
https://github.com/llvm/llvm-project/pull/92963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21,7 +21,7 @@
// RUN: %clang --target=aarch64 -march=armv8a+fp16fml -### -c %s 2>&1 |
FileCheck -check-prefix=GENERICV8A-FP16FML %s
jroelofs wrote:
oh, ok. TIL.
https://github.com/llvm/llvm-project/pull/96795
_
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/96795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Thank you for working on this! The changes LGTM aside from nits.
https://github.com/llvm/llvm-project/pull/96844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
@@ -7623,6 +7623,7 @@
handleNonBlockingNonAllocatingTypeAttr(TypeProcessingState &TPState,
FunctionEffectSet FX(EPI.FunctionEffects);
FunctionEffectSet::Conflicts Errs;
bool Success = FX.insert(NewEC, Errs);
+ (void)Success;
AaronBallman wrote:
A bette
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/96844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-beanz wrote:
> The grammer looks exactly the same with modules. May it be compatible with
> modules?
The grammar is the same (although HLSL only supports the `export` keyword in a
subset of the places C++ does), but the behavior isn't the same. We may look to
shift HLSL's behavior to mat
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/76612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Changes generally LGTM though I think this should come with a release note so
users know about the new command line options and functionality?
https://github.com/llvm/llvm-project/pull/76612
___
cfe-commits m
@@ -185,10 +185,56 @@ llvm::MDNode *CodeGenTBAA::getTypeInfoHelper(const Type
*Ty) {
return getChar();
// Handle pointers and references.
- // TODO: Implement C++'s type "similarity" and consider dis-"similar"
- // pointers distinct.
- if (Ty->isPointerType() || Ty->
https://github.com/AnastasiaStulova approved this pull request.
LGTM, nice refactoring!
https://github.com/llvm/llvm-project/pull/96641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 424 matches
Mail list logo
