weiweichen wrote:
Not sure if this is the right fix, so any clang experts here, please take a
look to see if this is acceptable?
https://github.com/llvm/llvm-project/pull/96832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
willghatch wrote:
@labrinea please take a look. The [PR
mentioned](https://github.com/llvm/llvm-project/pull/94279) above removed this
code and broke AArch64 feature detection for us.
https://github.com/llvm/llvm-project/pull/96832
___
cfe-commits m
https://github.com/trcrsired updated
https://github.com/llvm/llvm-project/pull/96417
>From 3a1790211a993908d6a9ab3cca1fa6eb2421e710 Mon Sep 17 00:00:00 2001
From: trcrsired
Date: Sun, 23 Jun 2024 00:07:19 -0400
Subject: [PATCH] Support --sysroot= for ${arch}-windows-msvc targets
I think it is
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/96809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi requested changes to this pull request.
While this is likely a step in the right direction, I'm a bit skeptical that
this patch is entirely correct.
First, I think we need to understand why we only want to cache/memoize the USR
strings from definitions.
Second, th
@@ -12,16 +12,25 @@
#include "clang/AST/Comment.h"
#include "clang/Index/USRGeneration.h"
#include "llvm/ADT/StringExtras.h"
-#include "llvm/Support/Error.h"
+#include "llvm/Support/Mutex.h"
+#include
namespace clang {
namespace doc {
+
+static std::unordered_set USRVisi
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T
*D) {
// If there is an error generating a USR for the decl, skip this decl.
if (index::generateUSRForDecl(D, USR))
return true;
+
+ // Prevent Visiting USR twice
+ {
+std::lock_guard Guard(USRVisi
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T
*D) {
// If there is an error generating a USR for the decl, skip this decl.
if (index::generateUSRForDecl(D, USR))
return true;
+
+ // Prevent Visiting USR twice
+ {
+std::lock_guard Guard(USRVisi
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T
*D) {
// If there is an error generating a USR for the decl, skip this decl.
if (index::generateUSRForDecl(D, USR))
return true;
+
+ // Prevent Visiting USR twice
+ {
+std::lock_guard Guard(USRVisi
@@ -12,16 +12,25 @@
#include "clang/AST/Comment.h"
#include "clang/Index/USRGeneration.h"
#include "llvm/ADT/StringExtras.h"
-#include "llvm/Support/Error.h"
+#include "llvm/Support/Mutex.h"
+#include
namespace clang {
namespace doc {
+
+static std::unordered_set USRVisi
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T
*D) {
// If there is an error generating a USR for the decl, skip this decl.
if (index::generateUSRForDecl(D, USR))
return true;
+
+ // Prevent Visiting USR twice
+ {
+std::lock_guard Guard(USRVisi
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T
*D) {
// If there is an error generating a USR for the decl, skip this decl.
if (index::generateUSRForDecl(D, USR))
return true;
+
+ // Prevent Visiting USR twice
+ {
+std::lock_guard Guard(USRVisi
https://github.com/ahmedbougacha closed
https://github.com/llvm/llvm-project/pull/94056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/minglotus-6 edited
https://github.com/llvm/llvm-project/pull/81442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
The grammer looks exactly the same with modules. May it be compatible with
modules?
https://github.com/llvm/llvm-project/pull/96823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/96453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -309,6 +309,39 @@ def err_asm_invalid_type : Error<
def err_ms_asm_bitfield_unsupported : Error<
"an inline asm block cannot have an operand which is a bit-field">;
+def asm_invalid_constraint_generic : TextSubstitution<
+ "invalid %select{input|output}0 constraint '%1'
https://github.com/e-kud edited https://github.com/llvm/llvm-project/pull/96363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/e-kud updated https://github.com/llvm/llvm-project/pull/96363
>From 4f8504878da33925609d52912e8d0e1f64c41066 Mon Sep 17 00:00:00 2001
From: Evgenii Kudriashov
Date: Fri, 21 Jun 2024 14:00:58 -0700
Subject: [PATCH 1/2] [clang] Improve diagnostics for constraints of inline asm
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/94693
>From 210121e2ba5c5e7d759b6e603d1daece5e1e9d12 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Tue, 4 Jun 2024 23:22:00 -0700
Subject: [PATCH] [Clang] Introduce [[clang::coro_inplace_task]]
---
clang/in
https://github.com/e-kud updated https://github.com/llvm/llvm-project/pull/96363
>From 4f8504878da33925609d52912e8d0e1f64c41066 Mon Sep 17 00:00:00 2001
From: Evgenii Kudriashov
Date: Fri, 21 Jun 2024 14:00:58 -0700
Subject: [PATCH 1/3] [clang] Improve diagnostics for constraints of inline asm
cyyself wrote:
I have a question: SpacemiT-X60 does not support Zicclsm on Vector, which is
the same as K230, as discussed in #88029 . Is the Zicclsm safe here?
https://github.com/llvm/llvm-project/pull/94564
___
cfe-commits mailing list
cfe-commits@l
efriedma-quic wrote:
I don't see any issues with the code. I'd prefer if we has a
TYSan-instrumented bootstrap build of LLVM before we merge this, so we're
confident this doesn't cause any unexpected issues.
https://github.com/llvm/llvm-project/pull/76612
_
e-kud wrote:
> I think the specific checks clang is doing here have to be part of clang: in
> particular, clang needs to translate from gcc syntax to LLVM IR asm syntax,
> and that requires parsing the constraints. So these checks are necessary, and
> emitting better diagnostics for checks we
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin`
running on `doug-worker-3` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/23/builds/407
Here is the rel
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/95917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
awson wrote:
@erichkeane, @cor3ntin
I see you actively reviewed (related, failed) #89036.
Could you look into this?
The idea of the fix is extremely simple: if we want to do something once, but
mistakenly do it twice, just don't do it the first time.
https://github.com/llvm/llvm-project/pull
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/96453
>From a035ae25314f3168f73108988f2bb7671e7d9e7f Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Mon, 24 Jun 2024 11:41:23 +0800
Subject: [PATCH 1/3] [Doc] Update documentation for no-transitive-change
---
cla
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as
of Clang 19.x is:
comes, the term BMI will refer to the Reduced BMI and the Full BMI will only
be meaningful to build systems which elect to support two-phase compilation.
+Experimental No Tra
https://github.com/dougsonos created
https://github.com/llvm/llvm-project/pull/96844
- Put new FunctionProtoType trailing objects last.
- Inline FunctionEffectsRef::get()
- Manually inline FunctionEffectsRef::Profile().
>From 038b39d3235c6c8151127c34d34f498dd298273c Mon Sep 17 00:00:00 2001
Fro
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Doug Wyatt (dougsonos)
Changes
- Put new FunctionProtoType trailing objects last.
- Inline FunctionEffectsRef::get()
- Manually inline FunctionEffectsRef::Profile().
---
Full diff: https://github.com/llvm/llvm-project/pull/96844.diff
4 F
dougsonos wrote:
This reduces the compile-time regression introduced by
f03cb005eb4ba3c6fb645aca2228e907db8cd452
[Clang] Introduce `nonblocking`/`nonallocating` attributes (#84983)
https://github.com/llvm/llvm-project/pull/96844
___
cfe-commits mailin
@@ -132,7 +132,6 @@ class TemplateArgument;
class TemplateArgumentListInfo;
class TemplateArgumentLoc;
class TemplateTypeParmDecl;
-template class TreeTransform;
dougsonos wrote:
Was made unnecessary by a late change in the previous branch.
https://github.co
@@ -3857,9 +3857,19 @@ void FunctionProtoType::Profile(llvm::FoldingSetNodeID
&ID, QualType Result,
}
epi.ExtInfo.Profile(ID);
- ID.AddInteger((epi.AArch64SMEAttributes << 1) | epi.HasTrailingReturn);
- epi.FunctionEffects.Profile(ID);
+ unsigned EffectCount = epi.Fu
@@ -3857,9 +3857,19 @@ void FunctionProtoType::Profile(llvm::FoldingSetNodeID
&ID, QualType Result,
}
epi.ExtInfo.Profile(ID);
- ID.AddInteger((epi.AArch64SMEAttributes << 1) | epi.HasTrailingReturn);
- epi.FunctionEffects.Profile(ID);
+ unsigned EffectCount = epi.Fu
@@ -7623,6 +7623,7 @@
handleNonBlockingNonAllocatingTypeAttr(TypeProcessingState &TPState,
FunctionEffectSet FX(EPI.FunctionEffects);
FunctionEffectSet::Conflicts Errs;
bool Success = FX.insert(NewEC, Errs);
+ (void)Success;
dougsonos wrote:
>From the
@@ -8619,6 +8621,18 @@ QualType DecayedType::getPointeeType() const {
void FixedPointValueToString(SmallVectorImpl &Str, llvm::APSInt Val,
unsigned Scale);
+inline FunctionEffectsRef FunctionEffectsRef::get(QualType QT) {
dougsonos
@@ -5132,6 +5130,10 @@ class FunctionProtoType final
return hasExtParameterInfos() ? getNumParams() : 0;
}
+ unsigned numTrailingObjects(OverloadToken) const {
dougsonos wrote:
Seems necessary when making Qualifiers no longer last.
https://github.com/
tbaederr wrote:
I guess you meant to link to
https://llvm-compile-time-tracker.com/compare.php?from=f03cb005eb4ba3c6fb645aca2228e907db8cd452&to=038b39d3235c6c8151127c34d34f498dd298273c&stat=instructions:u
directly?
https://github.com/llvm/llvm-project/pull/96844
___
dougsonos wrote:
> I guess you meant to link to
> https://llvm-compile-time-tracker.com/compare.php?from=f03cb005eb4ba3c6fb645aca2228e907db8cd452&to=038b39d3235c6c8151127c34d34f498dd298273c&stat=instructions:u
> directly?
Thanks!
https://github.com/llvm/llvm-project/pull/96844
___
https://github.com/h-vetinari updated
https://github.com/llvm/llvm-project/pull/93429
>From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?=
Date: Mon, 25 Apr 2022 09:45:22 +0300
Subject: [PATCH 1/8] [runtimes] [CMake] Use CMAKE_REQUIRED_
@@ -108,8 +108,11 @@ struct Foo {
Foo(T const (&)[N]);
};
+// FIXME: Prefer non-canonical template arguments in the deduction guide?
template
using Bar = Foo; // expected-note {{candidate template ignored:
couldn't infer template argument 'X'}} \
+
@@ -108,8 +108,11 @@ struct Foo {
Foo(T const (&)[N]);
};
+// FIXME: Prefer non-canonical template arguments in the deduction guide?
template
using Bar = Foo; // expected-note {{candidate template ignored:
couldn't infer template argument 'X'}} \
+
Author: Clement Courbet
Date: 2024-06-27T07:56:06+02:00
New Revision: 6b931ab516616127ce4cd5a0ad5e37d5a1d1696b
URL:
https://github.com/llvm/llvm-project/commit/6b931ab516616127ce4cd5a0ad5e37d5a1d1696b
DIFF:
https://github.com/llvm/llvm-project/commit/6b931ab516616127ce4cd5a0ad5e37d5a1d1696b.dif
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/95901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/trcrsired created
https://github.com/llvm/llvm-project/pull/96856
https://github.com/llvm/llvm-project/issues/96247
These libraries are not linked for windows gnu targets since the libraries are
not linked. I need to find out what's going on here. But first, I will just run
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: cqwrteur (trcrsired)
Changes
https://github.com/llvm/llvm-project/issues/96247
These libraries are not linked for windows gnu targets since the libraries are
not linked. I need to find out what's going on here. But first, I wi
https://github.com/trcrsired updated
https://github.com/llvm/llvm-project/pull/96856
>From e824af82ad45b0e1392173d0f0f4f3463413d038 Mon Sep 17 00:00:00 2001
From: cqwrteur <100043421+trcrsi...@users.noreply.github.com>
Date: Thu, 27 Jun 2024 02:10:40 -0400
Subject: [PATCH] Attempt to fix issue 9
https://github.com/trcrsired edited
https://github.com/llvm/llvm-project/pull/96856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davemgreen wrote:
Could you explain more about what broke? Are you using target(..) attributes?
https://github.com/llvm/llvm-project/pull/96832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: Timm Bäder
Date: 2024-06-27T08:53:20+02:00
New Revision: e096b282cc228f8c5c774c857a943eaa0f5e1586
URL:
https://github.com/llvm/llvm-project/commit/e096b282cc228f8c5c774c857a943eaa0f5e1586
DIFF:
https://github.com/llvm/llvm-project/commit/e096b282cc228f8c5c774c857a943eaa0f5e1586.diff
LO
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/93203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -672,7 +672,7 @@ class StdLibraryFunctionsChecker
StringRef getNote() const { return Note; }
};
- using ArgTypes = std::vector>;
+ using ArgTypes = ArrayRef>;
Xazax-hun wrote:
I am also wondering if `optional` is a smell, since QualType can be
nul
301 - 360 of 360 matches
Mail list logo
