[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-25 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Ztso. (PR #96465)

2024-06-25 Thread Philip Reames via cfe-commits
preames wrote: Once https://github.com/llvm/llvm-project/pull/90266 lands with the attributes off by default, I think we should move forward with relanding this. We do need one change though - our TSO lowering unconditionally uses the A6S ABI variant - right? - so we need to adjust the attrib

[clang] 2604830 - Add support for __builtin_verbose_trap (#79230)

2024-06-25 Thread via cfe-commits
Author: Akira Hatanaka Date: 2024-06-25T08:33:05-07:00 New Revision: 2604830aacdd563715da030d0396b565e912436f URL: https://github.com/llvm/llvm-project/commit/2604830aacdd563715da030d0396b565e912436f DIFF: https://github.com/llvm/llvm-project/commit/2604830aacdd563715da030d0396b565e912436f.diff

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-25 Thread Ilya Biryukov via cfe-commits
@@ -229,6 +229,10 @@ C++20 Feature Support will now work. (#GH62925). +- Clang refactored the BMI format to make it possible to support no transitive changes ilya-biryukov wrote: Maybe explicitly mention the user-facing effect of what "no transitive chan

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-25 Thread Ilya Biryukov via cfe-commits
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-25 Thread Ilya Biryukov via cfe-commits
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-25 Thread Ilya Biryukov via cfe-commits
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-25 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-25 Thread Dan Liew via cfe-commits
delcypher wrote: @ahatanak Excited to see this finally land 🎉 https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-25 Thread Alexis Perry-Holby via cfe-commits
AlexisPerry wrote: I believe I've addressed all the review comments and all the checks have passed. Could someone with commit access please merge this on my behalf? Thank you. https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Voicu (AlexVlx) Changes This is mostly stealing from #75357, and updating it to reflect the pivot towards AMDGCN flavoured SPIR-V and the slightly different set of limitations. As we bring up more functionality it will be updated acc

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/96659 This is in support of WG14 N2848 which only define the macros if infinity and nan are supported, so use of -ffinite-math will cause the macros to not be defined. >From b59c7f8c91d7c128975554d90bef3657ce3b272

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes This is in support of WG14 N2848 which only define the macros if infinity and nan are supported, so use of -ffinite-math will cause the macros to not be defined. --- Full diff: https://github.com/llvm/l

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/96657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/96657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Joseph Huber via cfe-commits
@@ -284,3 +284,48 @@ Example Usage Base* basePtr = &obj; basePtr->virtualFunction(); // Allowed since obj is constructed in device code } + +SPIR-V Support on HIPAMD ToolChain +== + +The HIPAMD ToolChain supports targetting +`AMDG

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Alexey Bataev via cfe-commits
@@ -2503,24 +2621,36 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( "Not an OpenMP directive!"); ParsingOpenMPDirectiveRAII DirScope(*this); ParenBraceBracketBalancer BalancerRAIIObj(*this); - SmallVector Clauses; - std::bitset SeenClauses;

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Alexey Bataev via cfe-commits
@@ -2374,88 +2374,206 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Alexey Bataev via cfe-commits
@@ -2503,24 +2621,36 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( "Not an OpenMP directive!"); ParsingOpenMPDirectiveRAII DirScope(*this); ParenBraceBracketBalancer BalancerRAIIObj(*this); - SmallVector Clauses; - std::bitset SeenClauses;

[clang] b7768c5 - [clang][Interp][NFC] Use delegate() to delegate to only initlist item

2024-06-25 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-25T17:50:53+02:00 New Revision: b7768c5485844306cd3c8afeef609ddf9d79696a URL: https://github.com/llvm/llvm-project/commit/b7768c5485844306cd3c8afeef609ddf9d79696a DIFF: https://github.com/llvm/llvm-project/commit/b7768c5485844306cd3c8afeef609ddf9d79696a.diff LO

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/96374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/96374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > The `preserve_none` calling convention is new in clang 19 and hasn't been > released yet; do fixes need a release note if they happen within the release > cycle a feature is added? Nope, no need for a release note in this case; I forgot that this was new for clang 19 ra

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Do you need me to land the changes on your behalf? https://github.com/llvm/llvm-project/pull/96487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP][Clang][Sema] Fix crash when calling builtins with pointer arguments (PR #95957)

2024-06-25 Thread Shilei Tian via cfe-commits
shiltian wrote: you have test failure https://buildkite.com/llvm-project/github-pull-requests/builds/73905#01902d01-7814-41af-b8e6-4d7d258fd4ec and https://buildkite.com/llvm-project/github-pull-requests/builds/73905#01902d01-7817-438a-b2cc-554580bfe611. Need to get it fixed before we merge i

[clang] [Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros (PR #90574)

2024-06-25 Thread via cfe-commits
yronglin wrote: Friendly ping~ https://github.com/llvm/llvm-project/pull/90574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx commented: > I'll need to play with this with my driver code. I'm guessing it's because it > needs to generate an entirely separate toolchain? The OpenMP path basically > does that by inferring the toolchain from the string value, so we can support > `--offload-arch=

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/96657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Krzysztof Parzyszek via cfe-commits
@@ -2374,88 +2374,206 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Krzysztof Parzyszek via cfe-commits
@@ -2503,24 +2621,36 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( "Not an OpenMP directive!"); ParsingOpenMPDirectiveRAII DirScope(*this); ParenBraceBracketBalancer BalancerRAIIObj(*this); - SmallVector Clauses; - std::bitset SeenClauses;

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Link to WG14 N2848: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2848.pdf https://github.com/llvm/llvm-project/pull/96659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-25 Thread Konstantin Varlamov via cfe-commits
var-const wrote: @ahatanak Thank you so much for pushing this through! This will be awesome for our hardening effort in libc++. Thanks to everyone for all the feedback and discussions as well! https://github.com/llvm/llvm-project/pull/79230 ___ cfe-c

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-25 Thread via cfe-commits
https://github.com/CedricSwa updated https://github.com/llvm/llvm-project/pull/94865 >From 012849c5410960001ca5bbcb90ea2cf4a661b840 Mon Sep 17 00:00:00 2001 From: Cedric Schwarzer Date: Sat, 8 Jun 2024 17:52:02 +0200 Subject: [PATCH 1/4] Improve error message for invalid lambda captures --- c

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Do we want some sort of optimization for constant printf? 99% of the time, we could parse the string at compile-time. (This sort of optimization is common for embedded targets.) If the format string isn't constant, is parsing the string on the GPU really slower than ask

[clang] [Serialization] Storing DeclID separately (PR #95897)

2024-06-25 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Thanks for this patch, I will try it on our codebase to see the effects of it and report back to you. I am also trying to understand in which cases this would be a win and when not. IIUC, this is always a win when `ModuleFileIndex != 0` and a pessimization otherwise. When

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/94691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I'll need to play with this with my driver code. I'm guessing it's because > > it needs to generate an entirely separate toolchain? The OpenMP path > > basically does that by inferring the toolchain from the string value, so we > > can support `--offload-arch=sm_89,gfx90a` f

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Do we want some sort of optimization for constant printf? 99% of the time, we > could parse the string at compile-time. (This sort of optimization is common > for embedded targets.) I was going to make a follow-up patch that simply skipped sending back the size if there were

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Also, I just merged the prerequisite patches into this, to get the relevant changed just look at the most recent commit. The lack of stacked PRs in GitHub really irks me. https://github.com/llvm/llvm-project/pull/96369 ___ cfe-commits

[clang] Fix codegen of consteval functions returning an empty class, and related issues (PR #93115)

2024-06-25 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: (I'd like a re-review of the latest version: I made significant revisions to address the tail-padding issues.) https://github.com/llvm/llvm-project/pull/93115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-25 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/96122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] align all help message in run-clang-tidy (PR #96199)

2024-06-25 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/96199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Clang: convert `__m64` intrinsics to unconditionally use SSE2 instead of MMX. (PR #96540)

2024-06-25 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I guess the clang calling convention code never uses MMX types for passing/returning values? Have you looked at the code quality? #41665 mentions potential issues with widening vectors. This doesn't touch inline asm or _mm_empty; I guess you're leaving that for a follow

[clang] 580343d - [clang][Interp][NFC] Destroy InitMap when moving contents to DeadBlock

2024-06-25 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-25T18:32:12+02:00 New Revision: 580343d96f18e3c2fa8d7a8e25a175aaa2e20522 URL: https://github.com/llvm/llvm-project/commit/580343d96f18e3c2fa8d7a8e25a175aaa2e20522 DIFF: https://github.com/llvm/llvm-project/commit/580343d96f18e3c2fa8d7a8e25a175aaa2e20522.diff LO

[clang] [clang][analyzer] Improve PointerSubChecker (PR #96501)

2024-06-25 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM. I'm a bit surprised to see that this checker duplicates the logic of the array bounds checkers (in the special case when the indexing operation is within a pointer subtraction). Right now this is OK but we'll need to delete this on

[clang] [clang][analyzer] Improve PointerSubChecker (PR #96501)

2024-06-25 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/96501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 05ca207 - [C23] Update status page regarding FLT_MAX_EXP

2024-06-25 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-06-25T12:34:34-04:00 New Revision: 05ca20744159a33349271a96b90959a0a3807133 URL: https://github.com/llvm/llvm-project/commit/05ca20744159a33349271a96b90959a0a3807133 DIFF: https://github.com/llvm/llvm-project/commit/05ca20744159a33349271a96b90959a0a3807133.diff

[clang-tools-extra] d7dd778 - [clang-doc] update install path to share/clang-doc instead of share/clang (#96555)

2024-06-25 Thread via cfe-commits
Author: PeterChou1 Date: 2024-06-25T09:39:33-07:00 New Revision: d7dd778cde84110e38521a6b55dfeb4e1c649ec2 URL: https://github.com/llvm/llvm-project/commit/d7dd778cde84110e38521a6b55dfeb4e1c649ec2 DIFF: https://github.com/llvm/llvm-project/commit/d7dd778cde84110e38521a6b55dfeb4e1c649ec2.diff LO

[clang-tools-extra] [clang-doc] update install path to share/clang-doc instead of share/clang (PR #96555)

2024-06-25 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/96555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] dbd5c78 - [clang-doc] Remove stdexecpt from clang-doc test (#96552)

2024-06-25 Thread via cfe-commits
Author: PeterChou1 Date: 2024-06-25T09:40:58-07:00 New Revision: dbd5c7805bae510c79b51c2c7700a590f2df446d URL: https://github.com/llvm/llvm-project/commit/dbd5c7805bae510c79b51c2c7700a590f2df446d DIFF: https://github.com/llvm/llvm-project/commit/dbd5c7805bae510c79b51c2c7700a590f2df446d.diff LO

[clang-tools-extra] [clang-doc] Remove stdexecpt from clang-doc test (PR #96552)

2024-06-25 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/96552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > > > I'll need to play with this with my driver code. I'm guessing it's > > > because it needs to generate an entirely separate toolchain? The OpenMP > > > path basically does that by inferring the toolchain from the string > > > value, so we can support `--offload-arch=sm_89,g

[clang] [TBAA] Emit int TBAA metadata on FP math libcalls (PR #96025)

2024-06-25 Thread Eli Friedman via cfe-commits
@@ -707,7 +707,39 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, const CallExpr *E, llvm::Constant *calleeValue) { CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E); CGCallee callee = CGCallee::forDirect(calle

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-25 Thread Paul Kirth via cfe-commits
ilovepi wrote: The two complementary patches, making the test free standing, and fixing the default asset path to be `share/clang-doc` have landed now. Can you update your patch, and resolve conflicts. If that passes CI, then I think we're probably about ready to reland. https://github.com/ll

[clang] [llvm] [clang][docs] Add preliminary documentation for SPIR-V support in the HIPAMD ToolChain (PR #96657)

2024-06-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I looked at this and it doesn't look super appealing (turned into something > of a rabbit hole), it'd duplicate a lot of the existing toolchain, and would > also try to squat in an already overcrowded space (there's already HIPSPV). We already have a SPIR-V toolchain for HIP?

[clang] [llvm] Clang: convert `__m64` intrinsics to unconditionally use SSE2 instead of MMX. (PR #96540)

2024-06-25 Thread Simon Pilgrim via cfe-commits
@@ -614,12 +623,15 @@ _mm_shuffle_epi8(__m128i __a, __m128i __b) ///1: Clear the corresponding byte in the destination. \n ///0: Copy the selected source byte to the corresponding byte in the ///destination. \n -///Bits [3:0] select the source byte to be copied.

[clang] 5e2beed - [C23] Move WG14 N2931 to the TS18661 section

2024-06-25 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-06-25T12:46:41-04:00 New Revision: 5e2beed9a1643cd6358fb8b43feb893543d90bf3 URL: https://github.com/llvm/llvm-project/commit/5e2beed9a1643cd6358fb8b43feb893543d90bf3 DIFF: https://github.com/llvm/llvm-project/commit/5e2beed9a1643cd6358fb8b43feb893543d90bf3.diff

[clang] [llvm] Clang: convert `__m64` intrinsics to unconditionally use SSE2 instead of MMX. (PR #96540)

2024-06-25 Thread Simon Pilgrim via cfe-commits
@@ -21,10 +21,29 @@ typedef int __v2si __attribute__((__vector_size__(8))); typedef short __v4hi __attribute__((__vector_size__(8))); typedef char __v8qi __attribute__((__vector_size__(8))); RKSimon wrote: Add a deprecation message if SSE2 is not defined or j

[clang] [llvm] Remove mmx 3dnow (PR #96246)

2024-06-25 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: > > So can we get all the mmx patches done in time for the 19.0 branch? > > Maybe? Depends on how the discussion on the other PR goes -- whether that > proposal is acceptable, or if a different transition strategy is desired. Apart from #96540 how many more patches do you envisi

[clang] [HIP][Clang][Sema] Fix crash when calling builtins with pointer arguments (PR #95957)

2024-06-25 Thread Raymond Tian via cfe-commits
https://github.com/rymdtian updated https://github.com/llvm/llvm-project/pull/95957 >From 5f6da1bf00c4b3bdb8aa75913629ebee262f3783 Mon Sep 17 00:00:00 2001 From: Raymond Tian Date: Tue, 18 Jun 2024 09:58:32 -0700 Subject: [PATCH] [HIP][Clang][Sema] Fix crash when calling builtins with pointer

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > Do we want some sort of optimization for constant printf? 99% of the time, we > could parse the string at compile-time. (This sort of optimization is common > for embedded targets.) Yes! @michaelrj-google has some ideas. Orthogonal to this PR though. https://github.co

[clang] [llvm] [mlir] [polly] [IR][NFC] Update IRBuilder to use InsertPosition (PR #96497)

2024-06-25 Thread Stephen Tozer via cfe-commits
SLTozer wrote: > My guess here would have been that the issue is the cases where an > Instruction* or BasicBlock* is passed rather than BB+Iterator, because those > two cases go through an out-of-line constructor. Seems like you're right - removing the extra dereference does little-to-nothing

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-25 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: Thanks for looking at this, let's make this an error instead of a crash in the future. https://github.com/llvm/llvm-project/pull/96487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-25 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/96487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-25 Thread Reid Kleckner via cfe-commits
@@ -2986,6 +2989,9 @@ void MicrosoftCXXNameMangler::mangleCallingConvention(CallingConv CC) { case CC_Swift: Out << 'S'; break; case CC_SwiftAsync: Out << 'W'; break; case CC_PreserveMost: Out << 'U'; break; +case CC_PreserveNone: + Out << 'V'; ---

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-25 Thread Reid Kleckner via cfe-commits
@@ -2986,6 +2989,9 @@ void MicrosoftCXXNameMangler::mangleCallingConvention(CallingConv CC) { case CC_Swift: Out << 'S'; break; rnk wrote: The default case here should be a proper compiler error, not an unreachable, since there's no good way to prevent arb

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: I'm not sure about tying this to __FINITE_MATH_ONLY__; -ffinite-math-only doesn't mean infinity doesn't exist, it just means you're promising that you won't use floating-point arithmetic/comparison ops on infinity. Which is weird, but that's fast-ma

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/96659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
https://github.com/michaelrj-google edited https://github.com/llvm/llvm-project/pull/96369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
@@ -0,0 +1,73 @@ +//===--- GPU helper functions for printf using RPC ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
@@ -54,7 +54,8 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter = michaelrj-google wrote: why was this change made? https://github.com/llvm/llvm-project/pull/96369

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
https://github.com/michaelrj-google commented: I thought I submitted these comments already, oops https://github.com/llvm/llvm-project/pull/96369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Richard Smith via cfe-commits
@@ -5368,16 +5368,85 @@ The ``#pragma comment(lib, ...)`` directive is supported on all ELF targets. The second parameter is the library name (without the traditional Unix prefix of ``lib``). This allows you to provide an implicit link of dependent libraries. -Evaluating Ob

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Richard Smith via cfe-commits
https://github.com/zygoloid updated https://github.com/llvm/llvm-project/pull/96573 >From 3394d999888087535db9ede87668829eddc33ac7 Mon Sep 17 00:00:00 2001 From: Richard Smith Date: Mon, 24 Jun 2024 15:52:18 -0700 Subject: [PATCH 1/2] Add documentation for `__builtin_object_size`. Explicitly d

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Joseph Huber via cfe-commits
@@ -54,7 +54,8 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter = jhuber6 wrote: I now use the `MockArgList` to tell determine how big the "struct" needs to be to contain the arguments. https://github.co

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Joseph Huber via cfe-commits
@@ -0,0 +1,73 @@ +//===--- GPU helper functions for printf using RPC ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
@@ -0,0 +1,73 @@ +//===--- GPU helper functions for printf using RPC ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
@@ -54,7 +54,8 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter = michaelrj-google wrote: in that case it'd be better to create a new `ArgList` that is intended to count sizes instead of just modifying th

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I'm not sure about tying this to `__FINITE_MATH_ONLY__`; -ffinite-math-only > doesn't mean infinity doesn't exist, it just means you're promising that you > won't use floating-point arithmetic/comparison ops on infinity. Which is > weird, but that's fast-math. Also, other

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-25 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/96358 >From bb407e7c6de15d7ed2f0dd645ca2a469ee1f8a8e Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 21 Jun 2024 16:57:30 -0400 Subject: [PATCH 1/4] Revert "Revert "[clang-doc] Add --asset option to clang-doc"

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Joseph Huber via cfe-commits
@@ -54,7 +54,8 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter = jhuber6 wrote: I didn't see any tests that actively depended on this value, and figured that it does a similar job stating how many bytes

[clang] a790279 - [flang] Add basic -mtune support (#95043)

2024-06-25 Thread via cfe-commits
Author: Alexis Perry-Holby Date: 2024-06-25T18:39:35+01:00 New Revision: a790279bf2a8be2f9c42bf80f55a63933e398d0e URL: https://github.com/llvm/llvm-project/commit/a790279bf2a8be2f9c42bf80f55a63933e398d0e DIFF: https://github.com/llvm/llvm-project/commit/a790279bf2a8be2f9c42bf80f55a63933e398d0e.

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-25 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space closed https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > and that implies (at least to me) that an expression cannot form an infinity > to begin with, so the act of trying to expand INFINITY is nonsensical in that > case, right? It's undefined behavior at runtime. I don't think we need to worry too much about what the C stand

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Michael Jones via cfe-commits
@@ -54,7 +54,8 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter = michaelrj-google wrote: I don't think anything directly depends on its output, but also the comments on it specifically say that it's for

[clang] [C23] Add INFINITY and NAN macros to (PR #96659)

2024-06-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > and that implies (at least to me) that an expression cannot form an > > infinity to begin with, so the act of trying to expand INFINITY is > > nonsensical in that case, right? > > It's undefined behavior at runtime. > > I don't think we need to worry too much about wha

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-cuda-l4` running on `cuda-l4-0` while building `clang,flang,mlir` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/101/builds/691 Here is the relevant piece of the build log

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-25 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `clang,flang,mlir` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/buil

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-25 Thread Paul Kirth via cfe-commits
ilovepi wrote: Seems like a tidy test is failing on windows ... can you try updating the branch once more? https://github.com/llvm/llvm-project/pull/96358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] a086933 - [C11] Remove WG14 N1537 from the status page

2024-06-25 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-06-25T14:02:05-04:00 New Revision: a0869331ec0c9ae42f696e87d72416ea5ecb926f URL: https://github.com/llvm/llvm-project/commit/a0869331ec0c9ae42f696e87d72416ea5ecb926f DIFF: https://github.com/llvm/llvm-project/commit/a0869331ec0c9ae42f696e87d72416ea5ecb926f.diff

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-06-25 Thread via cfe-commits
@@ -0,0 +1,174 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-25 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: > LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` > running on `linaro-flang-aarch64-libcxx` while building `clang,flang,mlir` at > step 6 "test-build-unified-tree-check-flang". > > Full details are available at: > https://lab.llvm.org/buildbot/#

[clang] [LinkerWrapper][NFC] Simplify StringErrors (PR #96650)

2024-06-25 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. LG and good to know we have format support :-) https://github.com/llvm/llvm-project/pull/96650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] Add documentation for `__builtin_object_size`. (PR #96573)

2024-06-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Thank you for the additional docs, they LGTM! https://github.com/llvm/llvm-project/pull/96573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] b9353f7 - [LinkerWrapper][NFC] Simplify StringErrors (#96650)

2024-06-25 Thread via cfe-commits
Author: Joseph Huber Date: 2024-06-25T13:16:28-05:00 New Revision: b9353f7f3ec88ecc5c4cdfc109665c89599b7f2f URL: https://github.com/llvm/llvm-project/commit/b9353f7f3ec88ecc5c4cdfc109665c89599b7f2f DIFF: https://github.com/llvm/llvm-project/commit/b9353f7f3ec88ecc5c4cdfc109665c89599b7f2f.diff

[clang] [LinkerWrapper][NFC] Simplify StringErrors (PR #96650)

2024-06-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/96650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-25 Thread Joseph Huber via cfe-commits
@@ -54,7 +54,8 @@ class MockArgList { } template LIBC_INLINE T next_var() { -++arg_counter; +arg_counter = jhuber6 wrote: Done https://github.com/llvm/llvm-project/pull/96369 ___ cfe-commits mailing li

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [Memprof] Adds the option to collect AccessCountHistograms for memprof. (PR #94264)

2024-06-25 Thread Matthew Weingarten via cfe-commits
@@ -216,6 +228,35 @@ u64 GetShadowCount(uptr p, u32 size) { return count; } +// Accumulates the access count from the shadow for the given pointer and size. +// See memprof_mapping.h for an overview on histogram counters. +u64 GetShadowCountHistogram(uptr p, u32 size) { + u

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [Memprof] Adds the option to collect AccessCountHistograms for memprof. (PR #94264)

2024-06-25 Thread Matthew Weingarten via cfe-commits
https://github.com/mattweingarten updated https://github.com/llvm/llvm-project/pull/94264 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [compiler-rt] [lldb] [llvm] [Memprof] Adds the option to collect AccessCountHistograms for memprof. (PR #94264)

2024-06-25 Thread Teresa Johnson via cfe-commits
https://github.com/teresajohnson approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/94264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >