https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634
>From 64e557f1b5e6dcf3b0ac78c83d4bef3d6cd8f7ba Mon Sep 17 00:00:00 2001
From: Kohei Asano
Date: Mon, 3 Jun 2024 09:15:44 +0900
Subject: [PATCH] [clang-format] add an option to insert a space only for empty
braces
@@ -108,3 +108,16 @@ behavior between Clang and DXC. Some examples include:
diagnostic notifying the user of the conversion rather than silently altering
precision relative to the other overloads (as FXC does) or generating code
that will fail validation (as DXC does).
+
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634
>From 4f25089286e85682d79f78b3168138d7d2450142 Mon Sep 17 00:00:00 2001
From: Kohei Asano
Date: Mon, 3 Jun 2024 09:15:44 +0900
Subject: [PATCH] [clang-format] add an option to insert a space only for empty
braces
Author: Adrian Prantl
Date: 2024-06-12T14:36:56-07:00
New Revision: 8f6acd973a38da6dce45faa676cbb51da37f72e5
URL:
https://github.com/llvm/llvm-project/commit/8f6acd973a38da6dce45faa676cbb51da37f72e5
DIFF:
https://github.com/llvm/llvm-project/commit/8f6acd973a38da6dce45faa676cbb51da37f72e5.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jthackray approved this pull request.
LGTM, assuming it causes no regressions.
https://github.com/llvm/llvm-project/pull/92145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/Andarwinux closed
https://github.com/llvm/llvm-project/pull/94731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Andarwinux created
https://github.com/llvm/llvm-project/pull/95320
fixes #91216
>From f7f12f9b026c0c290456d403d59911734ba05b57 Mon Sep 17 00:00:00 2001
From: Andarwinux <144242044+andarwi...@users.noreply.github.com>
Date: Fri, 7 Jun 2024 07:07:40 +
Subject: [PATCH] [Driv
https://github.com/Andarwinux updated
https://github.com/llvm/llvm-project/pull/95320
>From f71020889c8276e975336f921f647c9ab9863651 Mon Sep 17 00:00:00 2001
From: Andarwinux <144242044+andarwi...@users.noreply.github.com>
Date: Fri, 7 Jun 2024 07:07:40 +
Subject: [PATCH] [Driver] Add winsys
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Andarwinux)
Changes
fixes #91216
---
Full diff: https://github.com/llvm/llvm-project/pull/95320.diff
1 Files Affected:
- (modified) clang/include/clang/Driver/Options.td (+2)
``diff
diff --git a/clang/include/clang/Driv
@@ -6371,6 +6376,70 @@ ASTContext::getCanonicalTemplateName(const TemplateName
&Name) const {
canonArgPack, subst->getAssociatedDecl()->getCanonicalDecl(),
subst->getFinal(), subst->getIndex());
}
+ case TemplateName::DeducedTemplate: {
+assert(IgnoreDed
@@ -6371,6 +6376,70 @@ ASTContext::getCanonicalTemplateName(const TemplateName
&Name) const {
canonArgPack, subst->getAssociatedDecl()->getCanonicalDecl(),
subst->getFinal(), subst->getIndex());
}
+ case TemplateName::DeducedTemplate: {
+assert(IgnoreDed
farzonl wrote:
@aeubanks The issue you are seeing here is because only aarch64 and x86
backends have tan intrinsic lowering support. This shouldn't be a regression
because there never was a llvm.tan.v2f32 for ARMv7. That still needs to be
add. Can you show me how you could have generated `l
@@ -9434,6 +9505,32 @@ ASTContext::getSubstTemplateTemplateParmPack(const
TemplateArgument &ArgPack,
return TemplateName(Subst);
}
+/// Retrieve the template name that represents a template name
+/// deduced from a specialization.
+TemplateName
+ASTContext::getDeducedTempla
aeubanks wrote:
this seems to have broken code like
[this](https://crsrc.org/c/base/allocator/partition_allocator/src/partition_alloc/random.cc;drc=36293863bf9bbc8131797eb8f4d2bafe8af3de79;l=33)
with
```
../../base/allocator/partition_allocator/src/partition_alloc/random.cc:33:69:
error: inval
@@ -0,0 +1,95 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -cl-std=CL2.0 -target-cpu
verde -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple
aeubanks wrote:
reduced:
```
struct Lock {};
struct A {
Lock lock;
union {
bool b __attribute__((guarded_by(lock)));
};
};
```
seems like a regression, can we revert for now?
https://github.com/llvm/llvm-project/pull/94216
delcypher wrote:
@aeubanks I'll revert. Is this example C or C++?
https://github.com/llvm/llvm-project/pull/94216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Dan Liew
Date: 2024-06-12T15:43:12-07:00
New Revision: c9d580033f29196223cd56a0fa238c3ba51d23e4
URL:
https://github.com/llvm/llvm-project/commit/c9d580033f29196223cd56a0fa238c3ba51d23e4
DIFF:
https://github.com/llvm/llvm-project/commit/c9d580033f29196223cd56a0fa238c3ba51d23e4.diff
LOG:
delcypher wrote:
Reverted in c9d580033f29196223cd56a0fa238c3ba51d23e4
https://github.com/llvm/llvm-project/pull/94216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delcypher wrote:
@pdherbemont Could you take a look at this?
https://github.com/llvm/llvm-project/pull/94216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
This broke our buildbot:
https://lab.llvm.org/buildbot/#/builders/37/builds/35987
```
FAILED:
tools/clang/lib/Driver/CMakeFiles/obj.clangDriver.dir/ToolChains/Darwin.cpp.o
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache
/b/sanitizer-x86_64-linux/build/llvm_build0/bin/clang++
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/95325
Reverts llvm/llvm-project#95164
This broke a buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/35987
>From fc671bbb1ceb94f8aac63bc0e4963e5894bc660e Mon Sep 17 00:00:00 2001
From: Florian Mayer
Date: W
Author: Florian Mayer
Date: 2024-06-12T15:50:30-07:00
New Revision: fcc4935560720556defff25a9bd4fc44ffa3135b
URL:
https://github.com/llvm/llvm-project/commit/fcc4935560720556defff25a9bd4fc44ffa3135b
DIFF:
https://github.com/llvm/llvm-project/commit/fcc4935560720556defff25a9bd4fc44ffa3135b.diff
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/95325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Florian Mayer (fmayer)
Changes
Reverts llvm/llvm-project#95164
This broke a buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/35987
---
Full diff: https://github.com/llvm/llvm-project/pull/9532
@@ -128,12 +128,13 @@ enum class CudaArch {
GFX12_GENERIC,
GFX1200,
GFX1201,
+ AMDGCNSPIRV,
Generic, // A processor model named 'generic' if the target backend defines a
// public one.
LAST,
CudaDefault = CudaArch::SM_52,
- HIPDefault = CudaArch::
adrian-prantl wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jonathan Thackray
Date: 2024-06-13T00:00:57+01:00
New Revision: e80c59556d2d71cc2d0dcb2bd712c36cc4043025
URL:
https://github.com/llvm/llvm-project/commit/e80c59556d2d71cc2d0dcb2bd712c36cc4043025
DIFF:
https://github.com/llvm/llvm-project/commit/e80c59556d2d71cc2d0dcb2bd712c36cc4043025.d
https://github.com/jthackray closed
https://github.com/llvm/llvm-project/pull/95214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/amykhuang approved this pull request.
Looks reasonable to me.
https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,3 +108,16 @@ behavior between Clang and DXC. Some examples include:
diagnostic notifying the user of the conversion rather than silently altering
precision relative to the other overloads (as FXC does) or generating code
that will fail validation (as DXC does).
+
@@ -0,0 +1,95 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -cl-std=CL2.0 -target-cpu
verde -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/95259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krzysz00 wrote:
Just a note - and maybe this was already discussed above - is there good reason
not to explicitly make this type a 128-bit scalar? The LLVM data layout
already does this
https://github.com/llvm/llvm-project/pull/94830
___
cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5d87ba1c1f584dfbd5afaf187099b43681b2206d
f4fdb0eb680ab1ddf4f289bde30b1a72872b2f8d --
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/95331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Fangrui Song
Date: 2024-06-12T16:42:58-07:00
New Revision: ca91538c9c6f5328f398ac849dcc4230824b007e
URL:
https://github.com/llvm/llvm-project/commit/ca91538c9c6f5328f398ac849dcc4230824b007e
DIFF:
https://github.com/llvm/llvm-project/commit/ca91538c9c6f5328f398ac849dcc4230824b007e.diff
alexfh wrote:
So, what's happening here is a significant increase in the compilation time of
a pretty large source that has a large number of modular dependencies (using
Clang header modules rather than C++20 modules).
The times reported by `clang -ftime-report` for clang frontend change
dras
https://github.com/zeroomega created
https://github.com/llvm/llvm-project/pull/95337
This patch adds armv7m and armv8m runtimes to Fuchsia Clang toolchain
configuration.
>From 5dfd619b9a5799539606d3bb2879c9d13111a6da Mon Sep 17 00:00:00 2001
From: Haowei Wu
Date: Wed, 12 Jun 2024 17:27:23 -07
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haowei (zeroomega)
Changes
This patch adds armv7m and armv8m runtimes to Fuchsia Clang toolchain
configuration.
---
Full diff: https://github.com/llvm/llvm-project/pull/95337.diff
1 Files Affected:
- (modified) clang/cmake/caches/Fuchs
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/87578
>From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 3 Apr 2024 13:15:59 -0700
Subject: [PATCH 01/14] implement binding type error for t/cbuffers and
rwbuffers
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/95337
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/95202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-06-13T09:36:33+08:00
New Revision: b06da39cae0f7e2c6b8bc0bb03b734f9715c0bf3
URL:
https://github.com/llvm/llvm-project/commit/b06da39cae0f7e2c6b8bc0bb03b734f9715c0bf3
DIFF:
https://github.com/llvm/llvm-project/commit/b06da39cae0f7e2c6b8bc0bb03b734f9715c0bf3.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/95265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/95202
>From 8bd63f109c2bc1888b4d8dbd5e880900bbb4cef7 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Wed, 12 Jun 2024 00:42:48 -0300
Subject: [PATCH] [clang] fix broken canonicalization of
DeducedTemplateSpecial
Author: Matheus Izvekov
Date: 2024-06-12T22:40:39-03:00
New Revision: 2e1ad93961a3f444659c5d02d800e3144acccdb4
URL:
https://github.com/llvm/llvm-project/commit/2e1ad93961a3f444659c5d02d800e3144acccdb4
DIFF:
https://github.com/llvm/llvm-project/commit/2e1ad93961a3f444659c5d02d800e3144acccdb4.dif
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/95202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
Oh, the time regression is surprising to me. And I observed that @alexfh only
reports (compile performance) problems on AArch64 but @bgra8 reports (size
increase problems) on both ARM64 and X86_64.
@alexfh is it true?
So I **guess** the problem may come from the unaligned a
aeubanks wrote:
> @aeubanks I'll revert. Is this example C or C++?
C++
https://github.com/llvm/llvm-project/pull/94216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/75912
>From cf8be3c418dde67b74d4a5a4ea98a33f0e2fbd72 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Tue, 19 Dec 2023 17:00:59 +0800
Subject: [PATCH 1/6] [C++20] [Modules] [Itanium ABI] Generate the vtable in
the m
@@ -318,6 +318,9 @@ namespace {
if (Diags.hasUnrecoverableErrorOccurred())
return;
+ if (RD->shouldEmitInExternalSource())
ChuanqiXu9 wrote:
I use `isInCurrentModuleUnit` instead since I feel the semantics are more clear.
https://github.co
@@ -1483,26 +1484,40 @@ void Preprocessor::emitFinalMacroWarning(const Token
&Identifier,
}
bool Preprocessor::isSafeBufferOptOut(const SourceManager &SourceMgr,
- const SourceLocation &Loc) const {
- // Try to find a region in `Safe
@@ -1911,6 +1911,20 @@ SourceManager::getDecomposedIncludedLoc(FileID FID)
const {
return DecompLoc;
}
+FileID SourceManager::getFirstFIDOfLoadedAST(SourceLocation Loc) const {
+ assert(isLoadedSourceLocation(Loc) &&
+ "Must be a source location in a loaded PCH/Mod
haoNoQ wrote:
Ok I think I'm completely happy with the patch now. It makes perfect sense to
me and appears to be doing the right thing. Thank you @ziqingluo-90 for
figuring this out! Let's add that comment and land.
https://github.com/llvm/llvm-project/pull/92031
__
aeubanks wrote:
SLPVectorizer can introduce `llvm.tan.v2f32`. For example, running `opt -O3` on
the following introduces `llvm.tan.v2f32`
```
target datalayout = "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
target triple = "thumbv7-unknown-linux-android26"
; Function Attrs: null_pointe
@@ -318,6 +318,9 @@ namespace {
if (Diags.hasUnrecoverableErrorOccurred())
return;
+ if (RD->shouldEmitInExternalSource())
efriedma-quic wrote:
Did you mean to change something in ModuleBuilder.cpp?
https://github.com/llvm/llvm-project/pul
@@ -318,6 +318,9 @@ namespace {
if (Diags.hasUnrecoverableErrorOccurred())
return;
+ if (RD->shouldEmitInExternalSource())
ChuanqiXu9 wrote:
Yes, I think it is not bad to put the check `RD->shouldEmitInExternalSource()`
into `HandleVTable`
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/94889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/94889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10918,22 +10944,24 @@ QualType
Sema::DeduceTemplateSpecializationFromInitializer(
if (!(RD->getDefinition() && RD->isAggregate()))
return;
QualType Ty = Context.getRecordType(RD);
- SmallVector ElementTypes;
-
- InitListChecker CheckInitList(*
farzonl wrote:
It seems like we have four options here. We can drop the `def Tan :
FPMathTemplate, LibBuiltin<"math.h">` builtins so no `Builtin::BItanf` or
`Builtin::BItanl` in cgbuitlin switch case. That wouldn't solve the
SLPVectorizer case but doesn't expose it either unless you use a
@@ -1269,10 +1269,17 @@ class AnnotatingParser {
if (CurrentToken && CurrentToken->is(tok::less)) {
CurrentToken->setType(TT_TemplateOpener);
next();
- if (!parseAngle())
+ TemplateDeclarationDepth++;
+ if (!parseAngle()) {
+TemplateDeclar
@@ -1449,7 +1449,10 @@ void InitListChecker::CheckSubElementType(const
InitializedEntity &Entity,
// dependent non-array type or an array type with a value-dependent
// bound
assert(AggrDeductionCandidateParamTypes);
- if (!isa_and_nonnull(
+ //
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/94889
>From 217c00f47aaa65b113d1c1cfd93a9c4e1d235c1a Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sun, 9 Jun 2024 11:49:18 +0800
Subject: [PATCH 1/7] [Clang] Fix two issues of CTAD for aggregates
---
clang/lib/S
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/95348
See the post commit message in
https://github.com/llvm/llvm-project/pull/92083.
I suspect the compile time regression in AArch64 is related to alignments.
I am not sure if this is the problem since I can't re
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: Chuanqi Xu (ChuanqiXu9)
Changes
See the post commit message in
https://github.com/llvm/llvm-project/pull/92083.
I suspect the compile time regression in AArch64 is related to alignments.
I am not sure if
ChuanqiXu9 wrote:
I sent https://github.com/llvm/llvm-project/pull/95348 for aligned related
change.
For size increase, the reason and the possible solution are clear. We should
store the declaration ID as two slots instead of one in the serialized format
so that we can utilize VBR6 format be
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 78ee473784e5ef6f0b19ce4cb111fb6e4d23c6b2
eeef0c06e2a17f49ce3bdf8ae78b9bf1cd05a077 --
ChuanqiXu9 wrote:
@alexfh Could you try to test this? And if this doesn't mitigate it, it will be
helpful to provide the hotspot.
https://github.com/llvm/llvm-project/pull/95348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
yxsamliu wrote:
> > I am wondering whether prefix the builtin type with `__amdgcn_` would be
> > better since I envision risk of conflicting with reserved names of other
> > compilers or standard libraries.
>
> In the patch where the type was introduced we had a brief back-and-forth. I
> chec
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/94981
>From f05e8590c7fae599d0658829949fa907942e83f2 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 20 May 2024 01:15:03 -0300
Subject: [PATCH] [clang] Implement CWG2398 provisional TTP matching to class
t
@@ -0,0 +1,95 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -cl-std=CL2.0 -target-cpu
verde -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple
@@ -9434,6 +9505,32 @@ ASTContext::getSubstTemplateTemplateParmPack(const
TemplateArgument &ArgPack,
return TemplateName(Subst);
}
+/// Retrieve the template name that represents a template name
+/// deduced from a specialization.
+TemplateName
+ASTContext::getDeducedTempla
PeterChou1 wrote:
> @petrhosek I'm pretty sure there's a better way to spell this, but I think we
> need something similar to properly test clang-doc w/o an install step.
>
> cc: @PeterChou1
It looks like copy_directory_if_different is not available on windows
https://github.com/llvm/llvm-pro
@@ -9219,7 +9222,8 @@ class Sema final : public SemaBase {
/// \returns true if an error occurred, false otherwise.
bool CheckTemplateArgumentList(
TemplateDecl *Template, SourceLocation TemplateLoc,
- TemplateArgumentListInfo &TemplateArgs, bool PartialTemplateA
mizvekov wrote:
FYI https://github.com/itanium-cxx-abi/cxx-abi/issues/184 is the tracking issue
for the mangling rules we need here.
We will probably end up with something quite different than what I coded here
so far.
https://github.com/llvm/llvm-project/pull/94981
___
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/70306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,95 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-unknown -cl-std=CL2.0 -target-cpu
verde -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple
https://github.com/mizvekov approved this pull request.
I think what I tried to do here is generally consistent: The convention on the
Text node dumper is to add a space at the beginning of the field you want to
append.
I think the true issue here is the label: It breaks convention by adding a
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/95276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/94515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
This is much better, thanks!
LGTM
https://github.com/llvm/llvm-project/pull/94515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
@@ -2402,10 +2405,9 @@ Expr *VarDecl::getInit() {
auto *Eval = getEvaluatedStmt();
- return cast_if_present(
- Eval->Value.isOffset()
- ? Eval->Value.get(getASTContext().getExternalSource())
- : Eval->Value.get(nullptr));
+ return cast(Eval->Value.i
@@ -336,9 +336,10 @@ def warn_anyx86_excessive_regsave : Warning<
" with attribute 'no_caller_saved_registers'"
" or be compiled with '-mgeneral-regs-only'">,
InGroup>;
-def warn_arm_interrupt_calling_convention : Warning<
- "call to function without interrupt attribute
@@ -384,6 +384,10 @@ Modified Compiler Flags
evaluating to ``true`` and an empty body such as ``while(1);``)
are considered infinite, even when the ``-ffinite-loop`` flag is set.
+- Removed "arm interrupt calling convention" warning that was included in
ch
mizvekov wrote:
I think this is missing one detail: We now have the same qualifier in two
places: The elaborated type node attached to the TST, and in the name of the
TST itself.
While this is not ideal situation, I think it makes sense to just drop the
TemplateName qualifier in the transform
chrisnc wrote:
Thank you for the review!
> * Calling a function marked interrupt from a function marked interrupt is
> still UB isn't it? Should there be another warning to cover that scenario as
> well?
Correct. I can create a separate issue to describe such a warning.
> * I see that gcc ha
Author: Timm Bäder
Date: 2024-06-13T06:55:07+02:00
New Revision: 64c9a1e1266ec7bc4c4896b2df116fa12dbacf15
URL:
https://github.com/llvm/llvm-project/commit/64c9a1e1266ec7bc4c4896b2df116fa12dbacf15
DIFF:
https://github.com/llvm/llvm-project/commit/64c9a1e1266ec7bc4c4896b2df116fa12dbacf15.diff
LO
efriedma-quic wrote:
Can we change the target-independent bits of the tan() implementation in the
backend so it doesn't require each target to explicitly request that tan()
needs to be expanded? It should be possible to adjust the code in
TargetLoweringBase.cpp a bit so FTAN defaults to being
https://github.com/mizvekov requested changes to this pull request.
Needs changes as discussed.
https://github.com/llvm/llvm-project/pull/94725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
davemgreen wrote:
If you remove tan from isTriviallyVectorizable it should prevent vectorization
in the short term.
It might be better to default FTAN to expand in
https://github.com/llvm/llvm-project/blob/64c9a1e1266ec7bc4c4896b2df116fa12dbacf15/llvm/lib/CodeGen/TargetLoweringBase.cpp#L960,
mahesh-attarde wrote:
Regcall ABI is described on
https://cdrdv2-public.intel.com/679047/Intel-ABI-Vector-Function-v0.9.8.pdf
Page No. 18
>
https://github.com/llvm/llvm-project/pull/95257
_
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/95354
Fixes #45002.
>From 02f1731d57d40e51605f667c8a0b1223b159e645 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 12 Jun 2024 22:04:17 -0700
Subject: [PATCH] [clang-format] Don't overindent comment below unbraced b
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #45002.
---
Full diff: https://github.com/llvm/llvm-project/pull/95354.diff
3 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+5)
- (modified) clang/lib/Format/UnwrappedLine
owenca wrote:
@Erich-Reitz you were on the right track. See #95354.
https://github.com/llvm/llvm-project/pull/94776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PeterChou1 wrote:
I think this finally works i think we could also shelve
https://github.com/llvm/llvm-project/pull/94717
since I wrote that pr to get around the fact that we can't copy assets
https://github.com/llvm/llvm-project/pull/93928
___
cfe-
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/91870
>From a67b6703d384eb63b947e75c13d6421a5f961f6c Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Sat, 11 May 2024 00:15:50 -0700
Subject: [PATCH] [ARM][clang] Fix warning for VFP function calls from
interrupts
301 - 400 of 417 matches
Mail list logo
