[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-06-02 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From ba9b31041671099434570c6d3301782bc41c2c4a Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Sat, 1 Jun 2024 02:55:50 -0400 Subject: [PATCH] [libunwind][libcxx][lib

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-06-02 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 4f1ce895254dd9505150c1f5f5cb77454b9aca68 Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Sat, 1 Jun 2024 02:55:50 -0400 Subject: [PATCH] [libunwind][libcxx][lib

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

2024-06-02 Thread Dimitri John Ledkov via cfe-commits
xnox wrote: Requiring a config file when previously was not needed is a regression in behaviour for distributions. I guess Ubuntu would have to continue to patch this back in. Built-in defaults exist for a reason and yes at times need to be higher. This change risks performance regressions fo

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-02 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/93113 >From d1507bf2be71940c795925cdc8159cbc90b17f0d Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 23 May 2024 01:48:06 +0200 Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning tru

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/94159 Resolves #93066 >From 9c90d4a83a913566d782774700a06dd640722dfd Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 2 Jun 2024 18:33:37 +0530 Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when d

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rajveer Singh Bharadwaj (Rajveer100) Changes Resolves #93066 --- Full diff: https://github.com/llvm/llvm-project/pull/94159.diff 3 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+3) - (modified) clang/li

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: cc @Sirraide https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/94159 >From e637dc83ec205f7e4dde356b8f5d06ce3abc899e Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 2 Jun 2024 18:33:37 +0530 Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiab

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/94159 >From 95ce40b0336cda8c5a352d8abb824906b1d643d9 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 2 Jun 2024 18:33:37 +0530 Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiab

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 14304055e0d223a6dd224625b8fd128e6f711eb5 e637dc83ec205f7e4dde356b8f5d06ce3abc899e --

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-02 Thread via cfe-commits
https://github.com/aniplcc created https://github.com/llvm/llvm-project/pull/94161 Closes #86128. >From ad4c0e737f3d8de3202e027646c05d916a695e30 Mon Sep 17 00:00:00 2001 From: aniplcc Date: Sun, 2 Jun 2024 19:47:10 +0530 Subject: [PATCH 1/2] [X86] Enable constexpr on LZCNT & BMI intrinsics -

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: aniplcc (aniplcc) Changes Closes #86128. --- Full diff: https://github.com/llvm/llvm-project/pull/94161.diff 4 Files Affected: - (modified) clang/lib/Headers/bmiintrin.h (+31-19) - (modified) clang/lib/Headers/lzcntintrin.h (+13

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-02 Thread via cfe-commits
https://github.com/aniplcc updated https://github.com/llvm/llvm-project/pull/94161 >From ad4c0e737f3d8de3202e027646c05d916a695e30 Mon Sep 17 00:00:00 2001 From: aniplcc Date: Sun, 2 Jun 2024 19:47:10 +0530 Subject: [PATCH 1/3] [X86] Enable constexpr on LZCNT & BMI intrinsics --- clang/lib/Hea

[clang] [llvm] [mlir] Use llvm::less_first (NFC) (PR #94136)

2024-06-02 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/94136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 197c3a3 - Use llvm::less_first (NFC) (#94136)

2024-06-02 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-06-02T07:45:50-07:00 New Revision: 197c3a3efc703711ac8f14bc4f1765eaadb8e5bc URL: https://github.com/llvm/llvm-project/commit/197c3a3efc703711ac8f14bc4f1765eaadb8e5bc DIFF: https://github.com/llvm/llvm-project/commit/197c3a3efc703711ac8f14bc4f1765eaadb8e5bc.diff L

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0310f7f2d0c56a5697710251cec9803cbf7b4d56 7ede5764c9279a64cd36a5703255ec94a8109341 --

[clang] [clang-format] Handle attributes before lambda return arrow (PR #94119)

2024-06-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/94119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-02 Thread via cfe-commits
aniplcc wrote: forgot to update ExprConstant with builtins https://github.com/llvm/llvm-project/pull/94161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c26a993 - [clang][NFC] Update CWG issues list

2024-06-02 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-06-02T19:23:42+03:00 New Revision: c26a99384bce5719107d26f4617d6e3b1e9253ff URL: https://github.com/llvm/llvm-project/commit/c26a99384bce5719107d26f4617d6e3b1e9253ff DIFF: https://github.com/llvm/llvm-project/commit/c26a99384bce5719107d26f4617d6e3b1e9253ff.

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-06-02 Thread via cfe-commits
https://github.com/aniplcc converted_to_draft https://github.com/llvm/llvm-project/pull/94161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang][Modules] Move `ASTSourceDescriptor` into its own file (PR #67930)

2024-06-02 Thread David Stone via cfe-commits
davidstone wrote: Could I get someone to merge this for me if there are no other changes required? https://github.com/llvm/llvm-project/pull/67930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

2024-06-02 Thread David Stone via cfe-commits
davidstone wrote: Is there any additional work needed on this before it can be merged? https://github.com/llvm/llvm-project/pull/93417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev created https://github.com/llvm/llvm-project/pull/94166 None >From 896f3090ca2eadf650459caee9a4106fc7dd381d Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Thu, 30 May 2024 05:05:41 + Subject: [PATCH] [clang-repl] Teach clang-repl how to load PCHs. ---

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Vassil Vassilev (vgvassilev) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94166.diff 6 Files Affected: - (modified) clang/include/clang/CodeGen/ModuleBuilder.h (+6) - (modified) clang/lib/CodeGen/BackendCon

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-02 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,14 @@ +// REQUIRES: host-supports-jit +// UNSUPPORTED: system-aix + +// RUN: rm -f %t.pch +// RUN: %clang_cc1 -fmax-type-align=16 -pic-level 2 -fdeprecated-macro -stack-protector 1 -fblocks -fskip-odr-check-in-gmf -fexceptions -fcxx-exceptions -fgnuc-version=0 -triple

[clang] [clang-repl] Support wasm execution (PR #86402)

2024-06-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/86402 >From 4434ceeef152b95998ebd0a3b09a56d105490c4d Mon Sep 17 00:00:00 2001 From: Anubhab Ghosh Date: Sat, 23 Mar 2024 15:13:57 + Subject: [PATCH 1/3] [clang-repl] Support wasm execution. This commit introduc

[clang] [clang-repl] Support wasm execution (PR #86402)

2024-06-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/86402 >From 6b94e0cd67e59a7fcde2a327d6565a3850dc5f50 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Thu, 30 May 2024 05:08:17 + Subject: [PATCH 1/2] Revert "Revert "[clang-repl] Extend the C support. (#89

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94167 This patch adds tests for some CWG issues that were discussed at 2024-05-31 telecon. While all of them are tentatively ready at the moment, I'm expecting them to be moved to DRs without changes. CWG issues that

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch adds tests for some CWG issues that were discussed at 2024-05-31 telecon. While all of them are tentatively ready at the moment, I'm expecting them to be moved to DRs without changes. CWG is

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/94167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 80303cb - [clang-format] Handle attributes before lambda return arrow (#94119)

2024-06-02 Thread via cfe-commits
Author: Owen Pan Date: 2024-06-02T12:26:10-07:00 New Revision: 80303cb287e2c52c7bf4923bc61ebe25b2421bdc URL: https://github.com/llvm/llvm-project/commit/80303cb287e2c52c7bf4923bc61ebe25b2421bdc DIFF: https://github.com/llvm/llvm-project/commit/80303cb287e2c52c7bf4923bc61ebe25b2421bdc.diff LOG:

[clang] [clang-format] Handle attributes before lambda return arrow (PR #94119)

2024-06-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/94119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f06f016 - [clang-format][NFC] Add missing parens of __attribute in unit tests

2024-06-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-06-02T12:44:40-07:00 New Revision: f06f0164199d4a968d8336937cd5ef2c05946d8d URL: https://github.com/llvm/llvm-project/commit/f06f0164199d4a968d8336937cd5ef2c05946d8d DIFF: https://github.com/llvm/llvm-project/commit/f06f0164199d4a968d8336937cd5ef2c05946d8d.diff LOG:

[clang-tools-extra] fix(clang-tools-extra/**.py): fix comparison to None (PR #94013)

2024-06-02 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/94013 >From 0697c7c7976eb3c01c0f51495560ce6000176434 Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH] fix(clang-tools-extra/**.py): fix comparison to None from PEP8

[clang-tools-extra] fix(clang-tools-extra/**.py): fix comparison to None (PR #94013)

2024-06-02 Thread Eisuke Kawashima via cfe-commits
@@ -1071,7 +1071,7 @@ bool IdentifierNamingCheck::isParamInMainLikeFunction( if (!IsIntType(FDecl->parameters()[0]->getType())) return false; MainType Type = IsCharPtrPtr(FDecl->parameters()[1]->getType()); - if (Type == None) + if (Type is None) e-kw

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/94173 Fixes #80474 >From b4f5d6d43d369649711cece6057c8fe2758a5a89 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 3 Jun 2024 00:22:02 +0300 Subject: [PATCH] fix(80474): use expression error on incomplete __ar

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #80474 --- Full diff: https://github.com/llvm/llvm-project/pull/94173.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/lib/Parse/ParseExprCXX.cpp (+3) - (a

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-06-02 Thread Owen Pan via cfe-commits
@@ -3850,6 +3850,7 @@ LangOptions getFormattingLangOpts(const FormatStyle &Style) { // the sequence "<::" will be unconditionally treated as "[:". // Cf. Lexer::LexTokenInternal. LangOpts.Digraphs = LexingStd >= FormatStyle::LS_Cpp11; + LangOpts.RawStringLiterals = Lexi

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-06-02 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/88265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-06-02 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/88265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-06-02 Thread Owen Pan via cfe-commits
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-06-02 Thread Owen Pan via cfe-commits
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-06-02 Thread Owen Pan via cfe-commits
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] 2fbc9f2 - [clang-format][doc] Clean up quotes, etc.

2024-06-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-06-02T16:45:17-07:00 New Revision: 2fbc9f217e5fe8db8444a87dbd7138a768b8aa85 URL: https://github.com/llvm/llvm-project/commit/2fbc9f217e5fe8db8444a87dbd7138a768b8aa85 DIFF: https://github.com/llvm/llvm-project/commit/2fbc9f217e5fe8db8444a87dbd7138a768b8aa85.diff LOG:

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-06-02 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634 >From b55d09f4baa5f0a5cbe9b2614c23cc0ab5f2ef58 Mon Sep 17 00:00:00 2001 From: Kohei Asano Date: Mon, 3 Jun 2024 09:15:44 +0900 Subject: [PATCH] [clang-format] add an option to insert a space only for empty braces

[clang] d7d2d4f - [clang-format] Fix documentation build error

2024-06-02 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-06-02T18:03:12-07:00 New Revision: d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a URL: https://github.com/llvm/llvm-project/commit/d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a DIFF: https://github.com/llvm/llvm-project/commit/d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a.diff LOG:

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

2024-06-02 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634 >From 5d409bcd0966a7581effdf1488c2f4cfa32aebc6 Mon Sep 17 00:00:00 2001 From: Kohei Asano Date: Mon, 3 Jun 2024 09:15:44 +0900 Subject: [PATCH] [clang-format] add an option to insert a space only for empty braces

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-02 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: > Specification link: https://github.com/riscvarchive/riscv-indirect-csr-access You may need to update link to https://github.com/riscv/riscv-isa-manual/blob/main/src/indirect-csr.adoc. https://github.com/llvm/llvm-project/pull/93952 ___

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
https://github.com/Sirraide commented: In addition to what I’ve pointed out below, there are a few more things to be done: - This needs a release note (in `clang/docs/ReleaseNotes.rst`, probably under the ‘Improvements to Clang’s Diagnostics’ section). - I find it hard to believe that the test

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
@@ -13587,10 +13587,22 @@ static bool CheckForModifiableLvalue(Expr *E, SourceLocation Loc, Sema &S) { SourceRange Assign; if (Loc != OrigLoc) Assign = SourceRange(OrigLoc, OrigLoc); - if (NeedType) + if (NeedType) { S.Diag(Loc, DiagID) << E->getType() << E->get

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s + Sirraide wrote: Judging by these here, this is going in the right direction, though I would also want to see some more tests for other expressions that are not themselves modifiable lval

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-02 Thread via cfe-commits
@@ -8777,6 +8777,9 @@ def err_typecheck_incomplete_type_not_modifiable_lvalue : Error< def err_typecheck_lvalue_casts_not_supported : Error< "assignment to cast is illegal, lvalue casts are not supported">; +def note_typecheck_expression_not_modifiable_lvalue : Note< + "de

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-02 Thread via cfe-commits
https://github.com/YanWQ-monad edited https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -verify -std=c++11 %s + +auto f() { // expected-error {{'auto' return without trailing return type; deduced return types are a C++14 extension}} Sirraide wrote: I’d set the standard version to `C++14` or later to avoid unrelat

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/94173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM Though I do wonder how many other type traits are also affected by this, because at least the function below this one also doesn’t seem to check for parse errors... it would probably make sense to take a look at the rest of them to

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-06-02 Thread via cfe-commits
@@ -3850,6 +3850,7 @@ LangOptions getFormattingLangOpts(const FormatStyle &Style) { // the sequence "<::" will be unconditionally treated as "[:". // Cf. Lexer::LexTokenInternal. LangOpts.Digraphs = LexingStd >= FormatStyle::LS_Cpp11; + LangOpts.RawStringLiterals = Lexi

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-06-02 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/88265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove goma support from clang (PR #93942)

2024-06-02 Thread Takuto Ikuta via cfe-commits
atetubou wrote: I don't have merge permission. Could someone merge this PR if this looks good? https://github.com/llvm/llvm-project/pull/93942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-06-02 Thread via cfe-commits
https://github.com/Discookie updated https://github.com/llvm/llvm-project/pull/91951 >From 69cbd3da19eb0f8eb6758782b46daf99b5b79ea4 Mon Sep 17 00:00:00 2001 From: Viktor Date: Mon, 6 May 2024 06:11:58 + Subject: [PATCH 01/14] Add `bugprone-virtual-arithmetic` check Finds pointer arithmetic

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-06-02 Thread via cfe-commits
@@ -0,0 +1,49 @@ +//===--- VirtualArithmeticCheck.cpp - clang-tidy---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-06-02 Thread via cfe-commits
@@ -0,0 +1,60 @@ +.. title:: clang-tidy - bugprone-pointer-arithmetic-on-polymorphic-object + +bugprone-pointer-arithmetic-on-polymorphic-object += + +Finds pointer arithmetic performed on classes that declare a virtual function. + +

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-06-02 Thread via cfe-commits
@@ -0,0 +1,60 @@ +.. title:: clang-tidy - bugprone-pointer-arithmetic-on-polymorphic-object + +bugprone-pointer-arithmetic-on-polymorphic-object += + +Finds pointer arithmetic performed on classes that declare a virtual function. + +

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-06-02 Thread via cfe-commits
@@ -0,0 +1,49 @@ +//===--- VirtualArithmeticCheck.cpp - clang-tidy---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [cmake] Respect CLANG_LINK_CLANG_DYLIB for objlibs (PR #93454)

2024-06-02 Thread Nikita Popov via cfe-commits
nikic wrote: ping https://github.com/llvm/llvm-project/pull/93454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Be const-correct with all uses of `Module *`. (PR #93493)

2024-06-02 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. I feel good with this too. But if later you have similar multiple consecutive large NFC patches like this, I'll recommend you send the PR as stacked PR and then we can land the continuously. It'll help the downstream project slightly.

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

2024-06-02 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/93417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

2024-06-02 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Is there any additional work needed on this before it can be merged? No, it looks good. I'll merge this. https://github.com/llvm/llvm-project/pull/93417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] aaa4ff8 - [clang][Modules] Remove unnecessary includes of `Module.h` (#93417)

2024-06-02 Thread via cfe-commits
Author: David Stone Date: 2024-06-03T14:49:04+08:00 New Revision: aaa4ff88d6a2ef69053211e7bbee623f24723b51 URL: https://github.com/llvm/llvm-project/commit/aaa4ff88d6a2ef69053211e7bbee623f24723b51 DIFF: https://github.com/llvm/llvm-project/commit/aaa4ff88d6a2ef69053211e7bbee623f24723b51.diff L

[clang] [clang-tools-extra] [libcxx] [clang][Modules] Remove unnecessary includes of `Module.h` (PR #93417)

2024-06-02 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/93417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-06-02 Thread Chuanqi Xu via cfe-commits
@@ -1180,6 +1185,21 @@ bool CodeGenVTables::isVTableExternal(const CXXRecordDecl *RD) { TSK == TSK_ExplicitInstantiationDefinition) return false; + // Itanium C++ ABI [5.2.3]: + // Virtual tables for dynamic classes are emitted as follows: + // + // - If the cla

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/94173 >From b4f5d6d43d369649711cece6057c8fe2758a5a89 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 3 Jun 2024 00:22:02 +0300 Subject: [PATCH 1/2] fix(80474): use expression error on incomplete __array_exten

[clang] fix(80474): Clang crash on improper use of __array_extent (PR #94173)

2024-06-02 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -verify -std=c++11 %s + +auto f() { // expected-error {{'auto' return without trailing return type; deduced return types are a C++14 extension}} a-tarasyuk wrote: Thanks for the review. I've updated test https://github.com/ll

[clang] 5161a3f - [clang][dataflow] Rewrite `getReferencedDecls()` with a `RecursiveASTVisitor`. (#93461)

2024-06-02 Thread via cfe-commits
Author: martinboehme Date: 2024-06-03T08:59:09+02:00 New Revision: 5161a3f6e5e92c78c33aed5e38e0680a1a9b088e URL: https://github.com/llvm/llvm-project/commit/5161a3f6e5e92c78c33aed5e38e0680a1a9b088e DIFF: https://github.com/llvm/llvm-project/commit/5161a3f6e5e92c78c33aed5e38e0680a1a9b088e.diff

[clang] [clang][dataflow] Rewrite `getReferencedDecls()` with a `RecursiveASTVisitor`. (PR #93461)

2024-06-02 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/93461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits