[clang] [clang] Enable C++17 relaxed template template argument matching by default (PR #89807)

2024-05-28 Thread via cfe-commits
eaeltsin wrote: :( My goal now is to fix xtensor implementation/original tests, so this is not a question of reduction. I need to understand where the compiler picked a different specialization with relaxed argument matching. https://github.com/llvm/llvm-project/pull/89807 __

[clang] [C++20] [Modules] Don't generate the defintition for non-const available external variables (PR #93530)

2024-05-28 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/93530 >From ebe47b2b411d7623ddafadad45a9be25913fe1c1 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 29 May 2024 10:48:51 +0800 Subject: [PATCH] [C++20] [Modules] Don't generate the defintition for non-const a

[clang] [C++20] [Modules] Don't generate the defintition for non-const available external variables (PR #93530)

2024-05-28 Thread Chuanqi Xu via cfe-commits
@@ -5341,6 +5341,15 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D, !IsDefinitionAvailableExternally && D->needsDestruction(getContext()) == QualType::DK_cxx_destructor; + // It is helpless to emit the definition for an available_externally varia

[clang] [C++20] [Modules] Don't generate the defintition for non-const available external variables (PR #93530)

2024-05-28 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/93530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve ast-dumper text printing of TemplateArgument (PR #93431)

2024-05-28 Thread Matheus Izvekov via cfe-commits
@@ -947,6 +947,26 @@ void TextNodeDumper::dumpDeclRef(const Decl *D, StringRef Label) { }); } +void TextNodeDumper::dumpTemplateArgument(const TemplateArgument &TA) { + llvm::SmallString<128> Str; + { +llvm::raw_svector_ostream SS(Str); +TA.print(PrintPolicy, SS,

[clang] b0f10a1 - [C++20] [Modules] Don't generate the defintition for non-const available external variables (#93530)

2024-05-28 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-05-29T13:39:57+08:00 New Revision: b0f10a1dc34aa1b73faeeabdc2d348074a02c75d URL: https://github.com/llvm/llvm-project/commit/b0f10a1dc34aa1b73faeeabdc2d348074a02c75d DIFF: https://github.com/llvm/llvm-project/commit/b0f10a1dc34aa1b73faeeabdc2d348074a02c75d.diff LO

[clang] [C++20] [Modules] Don't generate the defintition for non-const available external variables (PR #93530)

2024-05-28 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/93530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable C++17 relaxed template template argument matching by default (PR #89807)

2024-05-28 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > :( My goal now is to fix xtensor implementation/original tests, so this is > not a question of reduction. I need to understand where the compiler picked a > different specialization with relaxed argument matching. So from the reduction you can see you have a problem where `sv

[clang] [NFC] Construct Twines before concatenation (PR #90728)

2024-05-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. LGTM. This avoids a temporary std::string, which might need a memory allocation. https://github.com/llvm/llvm-project/pull/90728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] 476a6d8 - [NFC] Construct Twines before concatenation (#90728)

2024-05-28 Thread via cfe-commits
Author: MagentaTreehouse Date: 2024-05-28T23:12:26-07:00 New Revision: 476a6d81a3648cf638400632c098e9f0ed025f8f URL: https://github.com/llvm/llvm-project/commit/476a6d81a3648cf638400632c098e9f0ed025f8f DIFF: https://github.com/llvm/llvm-project/commit/476a6d81a3648cf638400632c098e9f0ed025f8f.di

[clang] [NFC] Construct Twines before concatenation (PR #90728)

2024-05-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/90728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `bugprone-virtual-arithmetic` check (PR #91951)

2024-05-28 Thread via cfe-commits
https://github.com/Discookie updated https://github.com/llvm/llvm-project/pull/91951 >From 69cbd3da19eb0f8eb6758782b46daf99b5b79ea4 Mon Sep 17 00:00:00 2001 From: Viktor Date: Mon, 6 May 2024 06:11:58 + Subject: [PATCH 01/10] Add `bugprone-virtual-arithmetic` check Finds pointer arithmetic

[clang] [Clang][HIP] Suppress availability diagnostics for mismatched host/device overloads (PR #93546)

2024-05-28 Thread Fabian Ritter via cfe-commits
ritter-x2a wrote: > If we are adding a special case for handling overloads, perhaps a better > approach would be to consider inferring the caller context from the > enveloping function declaration attributes, and allow overload resolution to > pick a device function instead. It would avoid the

<    1   2   3   4   5