https://github.com/pkasting commented:
Drive-by
https://github.com/llvm/llvm-project/pull/92432
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/92442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-beanz wrote:
> Could you explain more about can't put any vectors or matrices into the
> cbuffer structure type?
Consider this example (regardless of packoffset):
```hlsl
cbuffer {
float F;
float2 V;
}
```
The layout for this is basically:
```c
struct {
float F;
float Vx; // v.x
@@ -368,7 +368,8 @@ Changes in existing checks
- Improved :doc:`readability-implicit-bool-conversion
` check to provide
valid fix suggestions for ``static_cast`` without a preceding space and
- fixed problem with duplicate parentheses in double implicit casts.
+ fixed pro
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/92449
Clang incorrectly accepts the following when using C++14 or later:
```cpp
struct A {
template
void f() const;
template<>
constexpr void f();
};
```
Non-static member functions declared `constexpr` are
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Clang incorrectly accepts the following when using C++14 or later:
```cpp
struct A {
template
void f() const;
template<>
constexpr void f();
};
```
Non-static member functio
https://github.com/erichkeane approved this pull request.
Release note, else LGTM
https://github.com/llvm/llvm-project/pull/92449
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/92449
>From b56eeb2ef435f06764bac0b062a8a0e747f697d4 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 16 May 2024 15:47:04 -0400
Subject: [PATCH 1/2] [Clang][Sema] Do not add implicit 'const' when match
pogo59 wrote:
> @pogo59 - you might find this interesting in terms of bitrotten tests, etc.
Fixing these typos is great. Identifying recurring patterns in the typos would
help motivate changes to FileCheck itself to detect them sooner. I think
@jdenny-ornl might have had some private patches,
efriedma-quic wrote:
> The data layout will insert 4-bytes of padding between the float and the
> vector because the vector needs to be properly aligned.
You can use `type <{ float, <2 x float>}>` if you need the tightly-packed
layout.
https://github.com/llvm/llvm-project/pull/91999
_
klensy wrote:
I've made pr for some FileCheck improvements here:
https://github.com/llvm/llvm-project/pull/92248
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
efriedma-quic wrote:
clang already generates certain diagnostics from ExprConstant; expanding the
set of diagnostics could be reasonable.
Alternatively, we could try to add some sort of cooperation between
DiagRuntimeBehavior and constant evaluation, to try to avoid having to diagnose
everyth
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/92427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
The key here is that `__arm_streaming_compatible` is the only way to write code
that runs in both streaming and non-streaming mode; outside of
`__arm_streaming_compatible`, there generally isn't an issue. If you know
you're not in streaming mode, you can just check direct
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/92452
Clang crashes when diagnosing the following invalid redeclaration in C++11:
```cpp
struct A {
void f();
};
constexpr void A::f() { } // crash here
```
This happens because `DiagnoseInvalidRedeclaration` trie
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Clang crashes when diagnosing the following invalid redeclaration in C++11:
```cpp
struct A {
void f();
};
constexpr void A::f() { } // crash here
```
This happens because `DiagnoseInvalidRedeclar
llvm-beanz wrote:
> You can use `type <{ float, <2 x float>}>` if you need the tightly-packed
> layout.
I think we need to figure out how we're going to lower this too. Loading from
this memory space requires loading 128 bytes at a time, and we need to slice it
down to just the parts of the s
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/92449
>From b56eeb2ef435f06764bac0b062a8a0e747f697d4 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 16 May 2024 15:47:04 -0400
Subject: [PATCH 1/2] [Clang][Sema] Do not add implicit 'const' when match
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/92454
This commit deletes the "simple" constructor of `CallDescription` which did not
require a `CallDescription::Mode` argument and always used the "wildcard" mode
`CDM::Unspecified`.
A few months ago, this vague
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Donát Nagy (NagyDonat)
Changes
This commit deletes the "simple" constructor of `CallDescription` which did not
require a `CallDescription::Mode
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From da3ec0033706609c79216fd2e5360c49304223f4 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/92452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -724,6 +724,8 @@ Bug Fixes to C++ Support
templates during partial ordering when deducing template arguments from a
function declaration or when
taking the address of a function template.
- Fix a bug with checking constrained non-type template parameters for
equivalenc
@@ -9203,15 +9203,15 @@ static NamedDecl *DiagnoseInvalidRedeclaration(
<< Idx << FDParam->getType()
<< NewFD->getParamDecl(Idx - 1)->getType();
} else if (FDisConst != NewFDisConst) {
- SemaRef.Diag(FD->getLocation(), diag::note_member_def_close_const_
@@ -1527,20 +1527,20 @@ struct DeclaratorChunk {
/// Retrieve the location of the 'const' qualifier.
SourceLocation getConstQualifierLoc() const {
- assert(MethodQualifiers);
- return MethodQualifiers->getConstSpecLoc();
+ return MethodQualifiers ? Metho
@@ -9203,15 +9203,15 @@ static NamedDecl *DiagnoseInvalidRedeclaration(
<< Idx << FDParam->getType()
<< NewFD->getParamDecl(Idx - 1)->getType();
} else if (FDisConst != NewFDisConst) {
- SemaRef.Diag(FD->getLocation(), diag::note_member_def_close_const_
https://github.com/erichkeane commented:
@AaronBallman is probably the best one to review DeclChunk stuff, perhaps
@cor3ntin
https://github.com/llvm/llvm-project/pull/92452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
nicovank wrote:
Rebased on top of cc54129b983799e1aaea77aa0ff3040dc30cbc8c.
Ping @PiotrZSL, what to do here? I can keep the current flush and separate
stdout/stderr behavior in this PR, it can be changed later.
But I don't think flushing fixes that issue of mis-ordered output lines, IMO
either
@@ -368,7 +368,8 @@ Changes in existing checks
- Improved :doc:`readability-implicit-bool-conversion
` check to provide
valid fix suggestions for ``static_cast`` without a preceding space and
- fixed problem with duplicate parentheses in double implicit casts.
+ fixed pro
@@ -724,6 +724,8 @@ Bug Fixes to C++ Support
templates during partial ordering when deducing template arguments from a
function declaration or when
taking the address of a function template.
- Fix a bug with checking constrained non-type template parameters for
equivalenc
https://github.com/bjosv updated https://github.com/llvm/llvm-project/pull/92241
From 44ae41f00064dc477db0eb00b45fceff811cadec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Svensson?=
Date: Mon, 29 Apr 2024 12:49:59 +0200
Subject: [PATCH 1/4] [clang-tidy] Use C-style casts on C23 in
rea
@@ -9203,15 +9203,15 @@ static NamedDecl *DiagnoseInvalidRedeclaration(
<< Idx << FDParam->getType()
<< NewFD->getParamDecl(Idx - 1)->getType();
} else if (FDisConst != NewFDisConst) {
- SemaRef.Diag(FD->getLocation(), diag::note_member_def_close_const_
efriedma-quic wrote:
> Thinking about it a bit more, maybe we can just do some magic to make things
> work? Say, if you specify `__attribute__((target("sve")))
> __arm_streaming_compatible`, and the caller is in streaming mode, allow the
> call even if the caller doesn't have SVE proper.
Thin
@@ -9203,15 +9203,15 @@ static NamedDecl *DiagnoseInvalidRedeclaration(
<< Idx << FDParam->getType()
<< NewFD->getParamDecl(Idx - 1)->getType();
} else if (FDisConst != NewFDisConst) {
- SemaRef.Diag(FD->getLocation(), diag::note_member_def_close_const_
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7115ed0fff027b65fa76fdfae215ed1382ed1473
3f28f74af90ee4c0d9fe2d9fdb1d91ba62c1441f --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7115ed0fff027b65fa76fdfae215ed1382ed1473...3f28f74af90ee4c0d9fe2d9fdb1d91ba62c1441f
compi
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/92318
>From 4ae259b21661caae2a9cd89437c56f3915195682 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 15 May 2024 16:13:03 -0400
Subject: [PATCH 1/4] [Clang][Sema] Don't build CXXDependentScopeMemberExp
https://github.com/zygoloid commented:
I think we should go ahead with this. The behavior here is subtle but I think
it does make sense, and we're in the process of proposing this change to WG21.
https://github.com/llvm/llvm-project/pull/90820
___
cfe
Author: Matheus Izvekov
Date: 2024-05-16T18:44:41-03:00
New Revision: c86a53d75995d65601d5745b2fceb2d50a970645
URL:
https://github.com/llvm/llvm-project/commit/c86a53d75995d65601d5745b2fceb2d50a970645
DIFF:
https://github.com/llvm/llvm-project/commit/c86a53d75995d65601d5745b2fceb2d50a970645.dif
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1382,6 +1382,10 @@ collectSanitizerRuntimes(const ToolChain &TC, const
ArgList &Args,
StaticRuntimes.push_back("asan_cxx");
}
+ if (!SanArgs.needsSharedRt() && SanArgs.needsRadsanRt()) {
+StaticRuntimes.push_back("radsan");
+ }
cjappl wrote:
@@ -32,6 +32,9 @@ set(ALL_ASAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32}
${ARM64} ${RISCV64}
${LOONGARCH64})
set(ALL_ASAN_ABI_SUPPORTED_ARCH ${X86_64} ${ARM64} ${ARM64_32})
set(ALL_DFSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${LOONGARCH64})
+set(ALL_RADSAN_SUPPORTED_A
haoNoQ wrote:
I think there should be a way to enable/disable this check separately because
memory exhaustion / denial of service isn't necessarily something you care
about when you enable taint analysis.
It's essential for web servers when the attacker is interested in interrupting
their ope
cjappl wrote:
Pinging possibly interested parties for review.
@yln @vitalybuka @Sirraide @AaronBallman @dougsonos @davidtrevelyan
Please feel free to add more, we don't know who all may be interested. Thanks
in advance
https://github.com/llvm/llvm-project/pull/92460
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjappl reopened
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1551,6 +1567,58 @@ bool
Preprocessor::isPPInSafeBufferOptOutRegion(SourceLocation &StartLoc) {
return InSafeBufferOptOutRegion;
}
+SmallVector
+Preprocessor::serializeSafeBufferOptOutMap() const {
+ assert(!InSafeBufferOptOutRegion &&
ziqingluo-90 wrot
https://github.com/aeubanks approved this pull request.
we've resolved the performance regression from the previous patch internally,
thanks for waiting!
https://github.com/llvm/llvm-project/pull/89872
___
cfe-commits mailing list
cfe-commits@lists.ll
python3kgae wrote:
> > Could you explain more about can't put any vectors or matrices into the
> > cbuffer structure type?
>
> Consider this example (regardless of packoffset):
>
> ```hlsl
> cbuffer {
> float F;
> float2 V;
> }
> ```
>
> The layout for this is basically:
>
> ```c
> struc
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/92200
>From 2c7f9a083c129df70a79d019286b6a29643a8973 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 14 May 2024 17:42:59 -0500
Subject: [PATCH 1/4] [clang][Sema] Warn consecutive builtin comparisons in an
expr
@@ -535,20 +535,23 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr,
llvm::ArrayType *AType,
elementType.isTriviallyCopyableType(CGF.getContext())) {
CodeGen::CodeGenModule &CGM = CGF.CGM;
ConstantEmitter Emitter(CGF);
-LangAS AS = ArrayQTy.getAddressSpa
@@ -215,3 +215,10 @@ namespace PR20735 {
// fix-it:"{{.*}}":{[[@LINE-9]]:20-[[@LINE-9]]:20}:")"
}
}
+
+void consecutive_builtin_compare(int x, int y, int z) {
+ (void)(x < y < z); // expected-warning {{comparisons like 'X<=Y<=Z' don't
have their mathematical meaning}}
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: Ahmed Bougacha (ahmedbougacha)
Changes
This is in effect a revert of f139ae3d93797, as we have since gained a more
sophisticated way of doing extra IRGen with the addition of RawAddress in #86923.
---
P
veluca93 wrote:
Ping
(I suspect that the assigned reviewers are likely not the most appropriate, but
I would be unsure on how to change them and to whom)
https://github.com/llvm/llvm-project/pull/91051
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/python3kgae edited
https://github.com/llvm/llvm-project/pull/91999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/python3kgae edited
https://github.com/llvm/llvm-project/pull/91999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/92401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 edited
https://github.com/llvm/llvm-project/pull/92200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
python3kgae wrote:
> > You can use `type <{ float, <2 x float>}>` if you need the tightly-packed
> > layout.
>
> I think we need to figure out how we're going to lower this too. Loading from
> this memory space requires loading 128 bytes at a time, and we need to slice
> it down to just the p
@@ -535,20 +535,23 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr,
llvm::ArrayType *AType,
elementType.isTriviallyCopyableType(CGF.getContext())) {
CodeGen::CodeGenModule &CGM = CGF.CGM;
ConstantEmitter Emitter(CGF);
-LangAS AS = ArrayQTy.getAddressSpa
llvm-beanz wrote:
> This PR will not change this. The padding will only be added when required.
_That's the problem_
>
> ```hlsl
> cbuffer {
> float F;
> float2 V;
> }
> ```
>
> will still got
>
> ```llvm
> type { float, <2 x float>}
> ```
And there will implicitly be padding between th
Author: Dan Liew
Date: 2024-05-16T15:24:11-07:00
New Revision: 84abe0a6d4face73c15ed6344be74ae231f18718
URL:
https://github.com/llvm/llvm-project/commit/84abe0a6d4face73c15ed6344be74ae231f18718
DIFF:
https://github.com/llvm/llvm-project/commit/84abe0a6d4face73c15ed6344be74ae231f18718.diff
LOG:
https://github.com/delcypher closed
https://github.com/llvm/llvm-project/pull/91032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Seems like a bot is broken:
https://lab.llvm.org/buildbot/#/builders/271/builds/7701 ; can you check?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
python3kgae wrote:
> > This PR will not change this. The padding will only be added when required.
>
> _That's the problem_
>
> > ```hlsl
> > cbuffer {
> > float F;
> > float2 V;
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > will stil
@@ -14574,9 +14574,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
default:
return false;
+ case Builtin::BI__builtin_frexpl:
+// AIX library function `frexpl` has 'long double' type and not
+// PPCDoubleDouble type. To make sure we generate t
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/92031
>From ac5aeb5c3a134d085320fc7fc5cf3f2c8c41a1f1 Mon Sep 17 00:00:00 2001
From: ziqingluo-90
Date: Mon, 13 May 2024 13:31:21 -0700
Subject: [PATCH 1/3] fix safe buffer opt-out region serialization
---
clang/
mizvekov wrote:
That test was merged after the last time pre-commit CI was run on this MR.
The change looks like a consequence of my refactoring, we now preserve the type
sugar from the injected arguments.
https://github.com/llvm/llvm-project/pull/90820
@@ -1551,6 +1567,58 @@ bool
Preprocessor::isPPInSafeBufferOptOutRegion(SourceLocation &StartLoc) {
return InSafeBufferOptOutRegion;
}
+SmallVector
+Preprocessor::serializeSafeBufferOptOutMap() const {
+ assert(!InSafeBufferOptOutRegion &&
+ "Attempt to serialize sa
jcsxky wrote:
> I don't think this is the right approach. I stepped though the example and
> the reason we reject is because:
>
> * We substitute a dependent `AutoType` in for the types of the template
> parameters when they are initially built.
> * We call `getMoreSpecialized` determine wheth
joker-eph wrote:
So are we reverting here or do you have quick fix available?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
The quick fix would be to change the expectations of the test, I can do it for
you.
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
mizvekov wrote:
Weirdly enough the test passes on my machine, latest MacOS.
Maybe the test is not constrained on target, and this is causing differences
between machines?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cf
@@ -14574,9 +14574,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
default:
return false;
+ case Builtin::BI__builtin_frexpl:
+// AIX library function `frexpl` has 'long double' type and not
+// PPCDoubleDouble type. To make sure we generate t
mizvekov wrote:
Yep, I confirm the behavior happens if I add `-triple x86_64-windows-msvc` to
RUN line.
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Matheus Izvekov
Date: 2024-05-16T19:56:45-03:00
New Revision: f210152e5fbcec1c50ff5ccc1f6680ab2c39b46f
URL:
https://github.com/llvm/llvm-project/commit/f210152e5fbcec1c50ff5ccc1f6680ab2c39b46f
DIFF:
https://github.com/llvm/llvm-project/commit/f210152e5fbcec1c50ff5ccc1f6680ab2c39b46f.dif
Author: Matheus Izvekov
Date: 2024-05-16T19:56:45-03:00
New Revision: fe4d5f0d0e457a0a7dec2c7dc87996706b30a25e
URL:
https://github.com/llvm/llvm-project/commit/fe4d5f0d0e457a0a7dec2c7dc87996706b30a25e
DIFF:
https://github.com/llvm/llvm-project/commit/fe4d5f0d0e457a0a7dec2c7dc87996706b30a25e.dif
mizvekov wrote:
I just pushed a fix.
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14574,9 +14574,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
default:
return false;
+ case Builtin::BI__builtin_frexpl:
+// AIX library function `frexpl` has 'long double' type and not
+// PPCDoubleDouble type. To make sure we generate t
joker-eph wrote:
Great, thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -420,25 +420,63 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) {
//already duplicated
// - call both from Sema and from here
- const auto *BaseDRE =
- dyn_cast(Node.getBase()->IgnoreParenImpCasts());
- if (!BaseDRE)
+ if (const auto *BaseDRE =
+
@@ -420,25 +420,63 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) {
//already duplicated
// - call both from Sema and from here
- const auto *BaseDRE =
- dyn_cast(Node.getBase()->IgnoreParenImpCasts());
- if (!BaseDRE)
+ if (const auto *BaseDRE =
+
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/92473
Based on @OfekShochat's https://reviews.llvm.org/D133648
init.c is the primary test for array initialization, but it uses a
32-bit triple, which would lead to an "array is too large" error. Add
the new test to ar
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
Based on @OfekShochat's https://reviews.llvm.org/D133648
init.c is the primary test for array initialization, but it uses a
32-bit triple, which would lead to an "array is too large" error. Add
the new test t
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Fangrui Song (MaskRay)
Changes
Based on @OfekShochat's https://reviews.llvm.org/D133648
init.c is the primary test for array initialization, but it uses a
32-bit triple, which would lead to an "array is too large" error. Add
the ne
https://github.com/ahatanak approved this pull request.
https://github.com/llvm/llvm-project/pull/92465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
LGTM, thanks for the fix!
https://github.com/llvm/llvm-project/pull/92263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zeroomega wrote:
Hi @hokein , your change probably broke the test "Clang ::
SemaCXX/cxx20-ctad-type-alias.cpp" on Windows. Could you take a look please?
We are seeing test failures on this with error message:
```
Exit Code: 1
Command Output (stdout):
--
# RUN: at line 1
c:\b\s\w\ir\x\w\llvm_b
mizvekov wrote:
I just double checked, the issue is present on main before this PR was merged,
it's completely unrelated.
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
mizvekov wrote:
I already fixed this. We just had to constrain the triple, as there are
differences in size_t underlying type which affect diagnostics.
https://github.com/llvm/llvm-project/pull/92389
___
cfe-commits mailing list
cfe-commits@lists.llvm
@@ -0,0 +1,93 @@
+//===-- llvm/GEPNoWrapFlags.h - NoWrap flags for GEPs ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -949,11 +949,11 @@ tryEmitGlobalCompoundLiteral(ConstantEmitter &emitter,
static llvm::Constant *
EmitArrayConstant(CodeGenModule &CGM, llvm::ArrayType *DesiredType,
- llvm::Type *CommonElementType, unsigned ArrayBound,
+ llvm::Type *Common
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/92477
https://godbolt.org/z/G1K8Wszn9 for reference.
Starting with MSVC 1920+, VS2019, C++17 auto NTTP now adds `M ` to the
mangled name to avoid name collisions with different deduced types.
This PR fixes pointers.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Max Winkler (MaxEW707)
Changes
https://godbolt.org/z/G1K8Wszn9 for reference.
Starting with MSVC 1920+, VS2019, C++17 auto NTTP now adds `M ` to
the mangled name to avoid name collisions with different deduced types.
This PR fixes p
https://github.com/FreddyLeaf updated
https://github.com/llvm/llvm-project/pull/92338
>From 41fbc18c7a4a26b11bc4b772bbe2e384ad9d9dbc Mon Sep 17 00:00:00 2001
From: Freddy Ye
Date: Fri, 10 May 2024 16:29:55 +0800
Subject: [PATCH 1/4] [X86] Support EGPR for inline assembly.
"jR": explictly enabl
ChuanqiXu9 wrote:
> I can reproduce the failure. The problem is that the CHECK line
>
> ```
> // CHECK: [[A_CALL:%[a-zA-Z0-9]+]] = call{{.*}}@_Z6MakeVR(
> ```
>
> assumes that a value is returned. On SystemZ, the return value is passed as
> `sret` argument, and the function itself returns
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/92207
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 400 of 443 matches
Mail list logo
