[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-18 Thread Isha Agarwal via cfe-commits
https://github.com/iagarwa updated https://github.com/llvm/llvm-project/pull/88736 >From 821c61fb4905b491176e00ea9ed322aad04c98e3 Mon Sep 17 00:00:00 2001 From: Isha Agarwal Date: Mon, 15 Apr 2024 06:22:34 -0700 Subject: [PATCH 1/3] [X86][test] Added extra cet tests Updated cet test to: -Check

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-18 Thread Isha Agarwal via cfe-commits
https://github.com/iagarwa updated https://github.com/llvm/llvm-project/pull/88736 >From 821c61fb4905b491176e00ea9ed322aad04c98e3 Mon Sep 17 00:00:00 2001 From: Isha Agarwal Date: Mon, 15 Apr 2024 06:22:34 -0700 Subject: [PATCH 1/3] [X86][test] Added extra cet tests Updated cet test to: -Check

[clang-tools-extra] 9760b6b - [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (#88138)

2024-04-18 Thread via cfe-commits
Author: Mike Weller Date: 2024-04-18T15:19:06+08:00 New Revision: 9760b6b1ecff3d3c43d182ea488fa34a82472a3e URL: https://github.com/llvm/llvm-project/commit/9760b6b1ecff3d3c43d182ea488fa34a82472a3e DIFF: https://github.com/llvm/llvm-project/commit/9760b6b1ecff3d3c43d182ea488fa34a82472a3e.diff L

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore deleted ctor in `bugprone-forwarding-reference-overload` (PR #88138)

2024-04-18 Thread via cfe-commits
github-actions[bot] wrote: @MikeWeller Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] da579ad - [clang][dataflow] Refactor `PropagateResultObject()` with a switch statement. (#88865)

2024-04-18 Thread via cfe-commits
Author: martinboehme Date: 2024-04-18T09:21:10+02:00 New Revision: da579ad807bd55c686e1c1c52e0a4bcc259347b4 URL: https://github.com/llvm/llvm-project/commit/da579ad807bd55c686e1c1c52e0a4bcc259347b4 DIFF: https://github.com/llvm/llvm-project/commit/da579ad807bd55c686e1c1c52e0a4bcc259347b4.diff

[clang] [clang][dataflow] Refactor `PropagateResultObject()` with a switch statement. (PR #88865)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/88865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Refactor `PropagateResultObject()` with a switch statement. (PR #88865)

2024-04-18 Thread via cfe-commits
martinboehme wrote: Didn't notice that there were failing tests in CI. Reverting. https://github.com/llvm/llvm-project/pull/88865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][dataflow] Refactor `PropagateResultObject()` with a switch statement." (PR #89176)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/89176 Reverts llvm/llvm-project#88865 There were failing tests in the CI that I didn't notice. Sorry. >From bbcfd7fc26799704dd33cb6d34767ac3f1359dbe Mon Sep 17 00:00:00 2001 From: martinboehme Date: Thu, 18 Apr

[clang] b5f2cec - Revert "[clang][dataflow] Refactor `PropagateResultObject()` with a switch statement." (#89176)

2024-04-18 Thread via cfe-commits
Author: martinboehme Date: 2024-04-18T09:23:03+02:00 New Revision: b5f2cecf833f8d08197cda80ac684c250b8fa0f9 URL: https://github.com/llvm/llvm-project/commit/b5f2cecf833f8d08197cda80ac684c250b8fa0f9 DIFF: https://github.com/llvm/llvm-project/commit/b5f2cecf833f8d08197cda80ac684c250b8fa0f9.diff

[clang] Revert "[clang][dataflow] Refactor `PropagateResultObject()` with a switch statement." (PR #89176)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/89176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][dataflow] Refactor `PropagateResultObject()` with a switch statement." (PR #89176)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes Reverts llvm/llvm-project#88865 There were failing tests in the CI that I didn't notice. Sorry. --- Full diff: https://github.com/llvm/llvm-project/pull/89176.diff 1 Files

[clang] [clang] Catch missing format attributes (PR #70024)

2024-04-18 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From d74a1c4372fe343d8c7a0560e3df607e1babf913 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribut

[clang] [X86][test] Added extra cet tests (PR #88736)

2024-04-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/88736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][test] Added extra cet tests, NFC (PR #88736)

2024-04-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/88736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 135472b - [X86][test] Added extra cet tests, NFC (#88736)

2024-04-18 Thread via cfe-commits
Author: Isha Agarwal Date: 2024-04-18T15:37:01+08:00 New Revision: 135472b553ccc18e4337b23f8d5616c8dda5e2a6 URL: https://github.com/llvm/llvm-project/commit/135472b553ccc18e4337b23f8d5616c8dda5e2a6 DIFF: https://github.com/llvm/llvm-project/commit/135472b553ccc18e4337b23f8d5616c8dda5e2a6.diff

[clang] [X86][test] Added extra cet tests, NFC (PR #88736)

2024-04-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/88736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/88381 From d747d817b6df04c8b93b7f89379448e467f0a0cd Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 11 Apr 2024 14:02:43 +0200 Subject: [PATCH] [clangd] Use TargetOpts from preamble when building ASTs Build

[clang] [X86][test] Added extra cet tests, NFC (PR #88736)

2024-04-18 Thread via cfe-commits
github-actions[bot] wrote: @iagarwa Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-18 Thread kadir çetinkaya via cfe-commits
@@ -112,7 +112,10 @@ struct UpdateIndexCallbacks : public ParsingCallbacks { // Index outlives TUScheduler (declared first) FIndex(FIndex), // shared_ptr extends lifetime - Stdlib(Stdlib)]() mutable { +

[clang] 5d4e072 - [C++20] [Modules] [Reduced BMI] Don't eagerly write static entities in

2024-04-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-04-18T15:38:02+08:00 New Revision: 5d4e072a253afac018e312d75290314bd2d03b30 URL: https://github.com/llvm/llvm-project/commit/5d4e072a253afac018e312d75290314bd2d03b30 DIFF: https://github.com/llvm/llvm-project/commit/5d4e072a253afac018e312d75290314bd2d03b30.diff LO

[clang] [clang] Catch missing format attributes (PR #70024)

2024-04-18 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From 9286a2cc9acec86284e4b1a4b3d42e3116d46fa1 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribut

[clang] Stop double-diagnosing explicit convert operator in switch condition (PR #89142)

2024-04-18 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I'm having second thoughts about leveraging recovery expressions as a side-band mechanism to de-duplicate diagnostics, because not modeling things properly in AST might backfire in the future. But I don't have anything better on my mind, so I don't want to block the progress of

[clang] Add new flag -Wpointer-integer-ordered-compare (PR #88489)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/88489 >From bc08f479ba483e1582304ca103dbd92481108f12 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 12 Apr 2024 14:56:42 +0530 Subject: [PATCH 1/3] add new flag -Wpointer-integer-ordered-compare Signed-off-by: 11ha

[clang] 609ee9f - [clang] Remove unused lambda capture (NFC)

2024-04-18 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-04-18T15:49:52+08:00 New Revision: 609ee9fe6a96113c893e8344f0dfaef5eba73e3d URL: https://github.com/llvm/llvm-project/commit/609ee9fe6a96113c893e8344f0dfaef5eba73e3d DIFF: https://github.com/llvm/llvm-project/commit/609ee9fe6a96113c893e8344f0dfaef5eba73e3d.diff LOG: [

[clang] Add new flag -Wpointer-integer-ordered-compare (PR #88489)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Hello @vincent-mailhol thank you for the review I have made the suggested changed. https://github.com/llvm/llvm-project/pull/88489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] Add new flag -Wpointer-integer-ordered-compare (PR #88489)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
11happy wrote: humble reminder @AaronBallman , @shafik https://github.com/llvm/llvm-project/pull/88489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Hello @PiotrZSL , I ran it on simple codebases & it looks good. I havent tried it on llvm codebase. it was taking a lot of time on my pc. https://github.com/llvm/llvm-project/pull/84481 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang-format] Do not update cursor pos if no includes replacement (PR #77456)

2024-04-18 Thread via cfe-commits
NorthBlue333 wrote: Friendly ping again here, as the status on this has been asked again by my team! :) @owenca, @mydeveloperday, and maybe @HazardyKnusperkeks (about splitting the issue in 2). https://github.com/llvm/llvm-project/pull/77456 ___ cfe-

[clang] e7a8dd9 - [docs] [C++20] [Modules] Mentioning Module Initializer

2024-04-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-04-18T16:12:14+08:00 New Revision: e7a8dd9b0d419403fe1d8adeb177a4ec78e036cc URL: https://github.com/llvm/llvm-project/commit/e7a8dd9b0d419403fe1d8adeb177a4ec78e036cc DIFF: https://github.com/llvm/llvm-project/commit/e7a8dd9b0d419403fe1d8adeb177a4ec78e036cc.diff LO

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,109 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16 -S -emit-llvm %s -o - | FileCheck %s +// CHECK-LABEL: define dso_local half @test

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm requested changes to this pull request. Bitcast is not the correct behavior https://github.com/llvm/llvm-project/pull/89051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/89051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,109 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16 -S -emit-llvm %s -o - | FileCheck %s +// CHECK-LABEL: define dso_local half @test

[libclc] [libclc] Fix build with Unix Makefiles (PR #89147)

2024-04-18 Thread Matt Arsenault via cfe-commits
@@ -39,6 +39,10 @@ function(compile_to_bc) set( TARGET_ARG "-target" ${ARG_TRIPLE} ) endif() + # Ensure the directory we are told to output to exists + get_filename_component( ARG_OUTPUT_DIR ${ARG_OUTPUT} DIRECTORY ) arsenm wrote: I thought there was

[libclc] [libclc] Fix build with Unix Makefiles (PR #89147)

2024-04-18 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/89147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Revert "[FMV] Remove useless features according the latest ACLE spec." (PR #89184)

2024-04-18 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Revert "[FMV] Remove useless features according the latest ACLE spec." (PR #89184)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: David Spickett (DavidSpickett) Changes Reverts llvm/llvm-project#88965 This caused a test suite failure: https://lab.llvm.org/buildbot/#/builders/185/builds/6583 NOEXE: test-suite::aarch64-acle-fmv-features.test ``` /home/tcwg-buildbot/wo

[clang] fd98f80 - [clang][Interp] Finish initializing structs from CompoundLiteralExprs

2024-04-18 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-18T10:31:31+02:00 New Revision: fd98f80f602e11d523d252feef301634c2c689a7 URL: https://github.com/llvm/llvm-project/commit/fd98f80f602e11d523d252feef301634c2c689a7 DIFF: https://github.com/llvm/llvm-project/commit/fd98f80f602e11d523d252feef301634c2c689a7.diff LO

[clang] Stop double-diagnosing explicit convert operator in switch condition (PR #89142)

2024-04-18 Thread via cfe-commits
cor3ntin wrote: Did you try to use `ExprDependence::Error`? https://github.com/llvm/llvm-project/pull/89142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Let DefineOutline tweak create a definition from scratch (PR #71950)

2024-04-18 Thread Tom Praschan via cfe-commits
tom-anders wrote: > The new patch set properly considers "external" definitions (using the > frowned-upon index lookup). I've been using this patch for a few weeks now, and it works very well. Haven't encountered any issues/crashes yet. Performance also seems reasonable (working in a medium-s

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread via cfe-commits
https://github.com/JinjinLi868 updated https://github.com/llvm/llvm-project/pull/89051 >From a8d31ec6602f55f845b9e508f71a42f83e3a474e Mon Sep 17 00:00:00 2001 From: Jinjin Li Date: Wed, 17 Apr 2024 16:44:50 +0800 Subject: [PATCH] [clang] Fix half && bfloat16 convert node expr codegen Data type

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [clang] Catch missing format attributes (PR #70024)

2024-04-18 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From 80274db3b96ec8dc4b19da9290d3a4748b679e07 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribut

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread Matt Arsenault via cfe-commits
arsenm wrote: > But In some target, it supply a HW instruction to complete the process > (fp16->float32->bf16) . so it just supply a intrinsic (fp16 -> bf16) Which is not a bitcast. The correct IR representation of this conversion is fpext+fptrunc https://github.com/llvm/llvm-project/pull/89

[clang] [llvm] [ARM] Armv8-R does not require fp64 or neon. (PR #88287)

2024-04-18 Thread via cfe-commits
https://github.com/ostannard approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix add_new_check.py regex (PR #89189)

2024-04-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/89189 avoid invalid escape sequence. ``` SyntaxWarning: invalid escape sequence '\(' ``` >From ea4452ec24608111ca37624b0113a5e4de6c6429 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 18 Apr 2024 17:15:44

[clang-tools-extra] [clang-tidy] fix add_new_check.py regex (PR #89189)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes avoid invalid escape sequence. ``` SyntaxWarning: invalid escape sequence '\(' ``` --- Full diff: https://github.com/llvm/llvm-project/pull/89189.diff 1 Files Affected: - (modified) clang-

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/87623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/84481 >From 8fdf6306085ed4cf0f77b7e718e374e9f65fedf9 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 8 Mar 2024 19:02:47 +0530 Subject: [PATCH 01/12] add clang-tidy check readability-math-missing-parentheses Signed

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,97 @@ +//===--- MathMissingParenthesesCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [ARM] Armv8-R does not require fp64 or neon. (PR #88287)

2024-04-18 Thread David Green via cfe-commits
davemgreen wrote: Does this disable neon by default for cortex-r52? If so I don't think it should be doing that, it would be a break in the existing behaviour, and should at least be in the release notes. The general rule for -mcpu options is that they should (roughly) enable the maximum set

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/84481 >From 8fdf6306085ed4cf0f77b7e718e374e9f65fedf9 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 8 Mar 2024 19:02:47 +0530 Subject: [PATCH 01/13] add clang-tidy check readability-math-missing-parentheses Signed

[clang] Add new flag -Wpointer-integer-ordered-compare (PR #88489)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
@@ -714,10 +714,11 @@ def HeaderHygiene : DiagGroup<"header-hygiene">; def DuplicateDeclSpecifier : DiagGroup<"duplicate-decl-specifier">; def CompareDistinctPointerType : DiagGroup<"compare-distinct-pointer-types">; def GNUUnionCast : DiagGroup<"gnu-union-cast">; +def PointerI

[clang] Add new flag -Wpointer-integer-ordered-compare (PR #88489)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
@@ -245,6 +245,12 @@ Modified Compiler Flags f3 *c = (f3 *)x; } +- Added a new diagnostic flag ``-Wpointer-integer-ordered-compare`` which is + grouped under ``-Wpointer-integer-compare`` and moved previously + ungrouped diagnostics ``ext_typecheck_ordered_compa

[clang] Add new flag -Wpointer-integer-ordered-compare (PR #88489)

2024-04-18 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,30 @@ +// RUN: %clang_cc1 -Wno-pointer-integer-compare -Wpointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer-ordered %s +// RUN: %clang_cc1 -Wpointer-integer-compare -Wno-pointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer %s + +vo

[clang] [Modules] No transitive source location change (PR #86912)

2024-04-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Fix conflicts and rebase with main. @Bigcheese @jansvoboda11 ping~ https://github.com/llvm/llvm-project/pull/86912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle structs with inner structs and no fields (PR #89126)

2024-04-18 Thread Bill Wendling via cfe-commits
@@ -844,7 +847,18 @@ const FieldDecl *CodeGenFunction::FindFlexibleArrayMemberField( if (const FieldDecl *Field = bwendling wrote: > FieldNo and Layout are referring to fields of "RD"; the "Field" found in the > recursive visit is a member of Record (or

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-18 Thread via cfe-commits
https://github.com/mahtohappy updated https://github.com/llvm/llvm-project/pull/89036 >From 56c2b4f70735a6ef3b80cb8461a88ea51f2d02d7 Mon Sep 17 00:00:00 2001 From: mahtohappy Date: Tue, 16 Apr 2024 17:48:45 +0530 Subject: [PATCH 1/5] [Clang][Sema] placement new initializes typedef array with c

[clang] Reapply "[Clang][Sema] placement new initializes typedef array with correct size (#83124)" (PR #89036)

2024-04-18 Thread via cfe-commits
https://github.com/mahtohappy updated https://github.com/llvm/llvm-project/pull/89036 >From 56c2b4f70735a6ef3b80cb8461a88ea51f2d02d7 Mon Sep 17 00:00:00 2001 From: mahtohappy Date: Tue, 16 Apr 2024 17:48:45 +0530 Subject: [PATCH 1/5] [Clang][Sema] placement new initializes typedef array with c

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [clang]MveEmitter:Pass Args as const references (PR #89202)

2024-04-18 Thread via cfe-commits
https://github.com/aniplcc created https://github.com/llvm/llvm-project/pull/89202 Closes #89192 >From bd5b445b9a1fe6ff465ebc0ca51d3833ab0c9a3c Mon Sep 17 00:00:00 2001 From: aniplcc Date: Thu, 18 Apr 2024 15:38:55 +0530 Subject: [PATCH] [clang]MveEmitter:Update args with const references --

[clang] [clang]MveEmitter:Pass Args as const references (PR #89202)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: aniplcc (aniplcc) Changes Closes #89192 --- Full diff: https://github.com/llvm/llvm-project/pull/89202.diff 1 Files Affected: - (modified) clang/utils/TableGen/MveEmitter.cpp (+2-2) ``diff diff --git a/clang/utils/TableGen/M

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/89204 Lambdas used in the initializer of a local class were not mangling the name of the member. Fixes #88906 >From 6382171fbd2075f1f0f3484bfde9ad96ec878f6e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu,

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Lambdas used in the initializer of a local class were not mangling the name of the member. Fixes #88906 --- Full diff: https://github.com/llvm/llvm-project/pull/89204.diff 3 Files Affected: - (modified) cla

[clang-tools-extra] [clang-tidy] bugprone-lambda-function-name ignore macro in captures (PR #89076)

2024-04-18 Thread Piotr Zegar via cfe-commits
@@ -69,9 +73,13 @@ void LambdaFunctionNameCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { } void LambdaFunctionNameCheck::registerMatchers(MatchFinder *Finder) { - // Match on PredefinedExprs inside a lambda. - Finder->addMatcher(predefinedExpr(hasAncestor(lambdaEx

[clang-tools-extra] [clang-tidy] fix add_new_check.py regex (PR #89189)

2024-04-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/89189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/89213 None >From d4205b37d9ba3cecd7cd947a188ec84e9afec899 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 18 Apr 2024 10:50:40 + Subject: [PATCH] [clang][dataflow] Model conditional operator correctl

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/89213.diff 7 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h (+15) - (modified) clang/include/clang/An

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/89213.diff 7 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h (+15) - (modified) clang/include

[clang] [ARM64EC] Add softintrin.lib as an implicit dependency to object files. (PR #89171)

2024-04-18 Thread Jacek Caban via cfe-commits
https://github.com/cjacek approved this pull request. LGTM (and CI failure doesn't seem related) https://github.com/llvm/llvm-project/pull/89171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)

2024-04-18 Thread Julian Schmidt via cfe-commits
5chmidti wrote: I let it run for a few minutes and didn't observe any crashes (on a release build though). However, I did find an issue with macros: ```c++ int sink(int); #define FUN(ARG) (sink(ARG)) #define FUN2(ARG) sink((ARG)) #define FUN3(ARG) sink(ARG) void f() { ... //CHECK-MESSA

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread Aaron Ballman via cfe-commits
@@ -538,6 +538,7 @@ Bug Fixes to C++ Support - Fix a crash in requires expression with templated base class member function. Fixes (#GH84020). - Fix a crash caused by defined struct in a type alias template when the structure has fields with dependent type. Fixes (#GH75221)

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu %s -emit-llvm -o - | FileCheck %s AaronBallman wrote: Do you know if we're doing the correct thing for Microsoft mangling in this case? (Do we have test coverage for that? Maybe add some tests as a fo

[clang] 652ae4e - [Clang][Sema] Warn when 'exclude_from_explicit_instantiation' attribute is used on local classes and members thereof (#88777)

2024-04-18 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-04-18T07:48:10-04:00 New Revision: 652ae4ecadaa972d70ef5cea3b68f2ff103c4af2 URL: https://github.com/llvm/llvm-project/commit/652ae4ecadaa972d70ef5cea3b68f2ff103c4af2 DIFF: https://github.com/llvm/llvm-project/commit/652ae4ecadaa972d70ef5cea3b68f2ff103c4af2

[clang] [Clang][Sema] Warn when 'exclude_from_explicit_instantiation' attribute is used on local classes and members thereof (PR #88777)

2024-04-18 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/88777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Avoid mentions of Clang in Flang's command line reference. (PR #88932)

2024-04-18 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. https://github.com/llvm/llvm-project/pull/88932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix shift-exponent ubsan check for signed _BitInt (PR #88004)

2024-04-18 Thread Björn Pettersson via cfe-commits
bjope wrote: ping https://github.com/llvm/llvm-project/pull/88004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV][HLSL] map lerp to Fmix (PR #88976)

2024-04-18 Thread Vyacheslav Levytskyy via cfe-commits
@@ -58,4 +58,6 @@ let TargetPrefix = "spv" in { Intrinsic<[ llvm_ptr_ty ], [llvm_i8_ty], [IntrWillReturn]>; def int_spv_all : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty]>; def int_spv_any : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty]>; + def int_spv_lerp

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [llvm] [SPIRV][HLSL] map lerp to Fmix (PR #88976)

2024-04-18 Thread Vyacheslav Levytskyy via cfe-commits
VyacheslavLevytskyy wrote: LGTM, just one question about documentation https://github.com/llvm/llvm-project/pull/88976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV][HLSL] map lerp to Fmix (PR #88976)

2024-04-18 Thread Vyacheslav Levytskyy via cfe-commits
https://github.com/VyacheslavLevytskyy approved this pull request. https://github.com/llvm/llvm-project/pull/88976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix -Wnullability-completeness false-positive in dependent code (PR #88727)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/88727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/89213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/89213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
@@ -657,17 +658,22 @@ class TransferVisitor : public ConstStmtVisitor { } void VisitConditionalOperator(const ConditionalOperator *S) { -// FIXME: Revisit this once flow conditions are added to the framework. For -// `a = b ? c : d` we can add `b => a == c && !b =

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
@@ -5243,6 +5243,67 @@ TEST(TransferTest, BinaryOperatorComma) { }); } +TEST(TransferTest, ConditionalOperatorValue) { + std::string Code = R"( +void target(bool Cond, bool B1, bool B2) { + bool JoinSame = Cond ? B1 : B1; + bool JoinDifferent = Cond ? B1 :

[clang] [llvm] [clang] Migrate clang-rename to OptTable parsing (PR #89167)

2024-04-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall commented: I'm not sold on the use of OptTable here, and think we should try some alternatives. I don't want to be a burden, so I'm happy to try this out if you like. If it's just this tool then it's not that important, but I assume it's not. There's possible scop

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/89204 >From 6382171fbd2075f1f0f3484bfde9ad96ec878f6e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 18 Apr 2024 12:19:41 +0200 Subject: [PATCH 1/2] [Clang] Fix the mangling of lambdas Lambdas used in the in

[clang] [clang] Fix a "!CodeSynthesisContexts.empty()" assertion failure when constructing aggregate deduction guides. (PR #89227)

2024-04-18 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/89227 We were missing to push an record to the instantiation stack in `DeclareAggregateDeductionGuideForTypeAlias`. This patch fixes that. >From 04c5dfa09f78fa52b31378295a8d27a20278498a Mon Sep 17 00:00:00 2001 From:

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu %s -emit-llvm -o - | FileCheck %s cor3ntin wrote: > Do you know if we're doing the correct thing for Microsoft mangling in this > case? Yes. I added tests https://github.com/llvm/llvm-project/pull/8

[clang] [clang] Fix a "!CodeSynthesisContexts.empty()" assertion failure when constructing aggregate deduction guides. (PR #89227)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes We were missing to push an record to the instantiation stack in `DeclareAggregateDeductionGuideForTypeAlias`. This patch fixes that. --- Full diff: https://github.com/llvm/llvm-project/pull/89227.diff 2 File

[clang] [clang-format] Remove YAML hack to emit a BasedOnStyle comment (PR #89228)

2024-04-18 Thread Jannik Silvanus via cfe-commits
https://github.com/jasilvanus created https://github.com/llvm/llvm-project/pull/89228 When serializing a formatting style to YAML, we were emitting a comment `# BasedOnStyle:

[clang] [clang] Fix a "!CodeSynthesisContexts.empty()" assertion failure when constructing aggregate deduction guides. (PR #89227)

2024-04-18 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/89227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Remove YAML hack to emit a BasedOnStyle comment (PR #89228)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Jannik Silvanus (jasilvanus) Changes When serializing a formatting style to YAML, we were emitting a comment `# BasedOnStyle: