https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/88666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
1 nit, else this lgtm.
https://github.com/llvm/llvm-project/pull/88666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti created
https://github.com/llvm/llvm-project/pull/88737
Clangd already implements some utility functions for converting between
SourceLocations, Positions and Offsets into a buffer.
>From 3ee0dfe6292146d188f7d14f717c1e989c668e1c Mon Sep 17 00:00:00 2001
From: Julian
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clangd
Author: Julian Schmidt (5chmidti)
Changes
Clangd already implements some utility functions for converting between
SourceLocations, Positions and Offsets into a buffer.
---
Full diff: https://github.com/llvm
farzonl wrote:
Thank you for the reviews!
https://github.com/llvm/llvm-project/pull/88325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Farzon Lotfi
Date: 2024-04-15T09:52:47-04:00
New Revision: 105dcc882cf0152baeaa02ac0e50e2527b6940db
URL:
https://github.com/llvm/llvm-project/commit/105dcc882cf0152baeaa02ac0e50e2527b6940db
DIFF:
https://github.com/llvm/llvm-project/commit/105dcc882cf0152baeaa02ac0e50e2527b6940db.diff
https://github.com/farzonl closed
https://github.com/llvm/llvm-project/pull/88325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
5chmidti wrote:
@ckandeler while opening up your other changes in my editor, I wanted to see if
some of the logic around `Position`s and `Offset`s could be simplified. It
looks like `clangd` already implements some of the functionality in the
`SourceCode.h` file. This shouldn't actually change
https://github.com/erichkeane approved this pull request.
Ah, I had missed (thanks github review tool!) that the 'ImplicitObjectMember'
part already existed. Sorry for that.
https://github.com/llvm/llvm-project/pull/85198
___
cfe-commits mailing list
@@ -287,6 +286,10 @@ Changes in existing checks
check by resolving fix-it overlaps in template code by disregarding implicit
instances.
+- Improved :doc:`bugprone-forwarding-reference-overload
PiotrZSL wrote:
move it to line 149, to keep checks in alphabe
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/88600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
2 nits, else LGTM. Once you and @kimgr are in agreement with what to do next
(and have looked into my nits), feel free to commit.
https://github.com/llvm/llvm-project/pull/88600
___
cfe-commi
@@ -275,13 +278,15 @@ void DeclPrinter::prettyPrintAttributes(const Decl *D,
if (Pos != AttrPosAsWritten::Left)
Out << ' ';
A->printPretty(Out, Policy);
+ hasPrinted = true;
if (Pos == AttrPosAsWritten::Left)
Out
@@ -252,16 +252,19 @@ static DeclPrinter::AttrPosAsWritten
getPosAsWritten(const Attr *A,
return DeclPrinter::AttrPosAsWritten::Right;
}
-void DeclPrinter::prettyPrintAttributes(const Decl *D,
+// returns true if an attribute was printed.
+bool DeclPrinter::prettyPrintAttri
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/75533
>From b8f3f364310ca6094a6944f4f3ee9349c8aa77d6 Mon Sep 17 00:00:00 2001
From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com>
Date: Sat, 21 Jan 2023 14:49:58 +0100
Subject: [PATCH 1/3] [clangd] Extrac
@@ -252,16 +252,19 @@ static DeclPrinter::AttrPosAsWritten
getPosAsWritten(const Attr *A,
return DeclPrinter::AttrPosAsWritten::Right;
}
-void DeclPrinter::prettyPrintAttributes(const Decl *D,
+// returns true if an attribute was printed.
+bool DeclPrinter::prettyPrintAttri
@@ -2,12 +2,20 @@
// RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=branch %s |
FileCheck %s --check-prefix=BRANCH
// RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=full %s |
FileCheck %s --check-prefix=FULL
// RUN: not %clang_cc1 -emit-llvm-only -triple
https://github.com/PiotrZSL approved this pull request.
For me looks fine.
Give it few days before merging, so others would have opportunity to review.
https://github.com/llvm/llvm-project/pull/88735
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/88735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -61,6 +61,44 @@ struct
DenseMapInfo {
namespace clang::tidy {
namespace {
+/// Returns the function that \p Method is overridding. If There are none or
+/// multiple overrides it returns nullptr. If the overridden function itself is
+/// overridding then it will recurse up
@@ -2,12 +2,20 @@
// RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=branch %s |
FileCheck %s --check-prefix=BRANCH
// RUN: %clang_cc1 -E -triple i386 -dM -o - -fcf-protection=full %s |
FileCheck %s --check-prefix=FULL
// RUN: not %clang_cc1 -emit-llvm-only -triple
https://github.com/phoebewang edited
https://github.com/llvm/llvm-project/pull/88736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/phoebewang edited
https://github.com/llvm/llvm-project/pull/88736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -91,11 +91,24 @@ static StringRef normalizeAttrName(StringRef Name) {
/// isAttributeLateParsed - Return true if the attribute has arguments that
/// require late parsing.
-static bool isAttributeLateParsed(const IdentifierInfo &II) {
+bool Parser::isAttributeLateParsed(con
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/3] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/HerrCai0907 approved this pull request.
LGTM in source code part.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -286,6 +286,10 @@ Changes in existing checks
check by resolving fix-it overlaps in template code by disregarding implicit
instances.
+- Improved :doc:`bugprone-forwarding-reference-overload
+ `
+ check to not flag deleted constructors which are unable to hide anything
cor3ntin wrote:
Can you:
- add a changelog entry referencing the issue
- rename the test file or reference the issue number in a comment in the test?
thanks!
https://github.com/llvm/llvm-project/pull/83124
___
cfe-commits mailing list
cfe-commits@l
@@ -508,6 +508,11 @@ class ResultObjectVisitor : public
RecursiveASTVisitor {
isa(E)) {
return;
}
+if (auto *Op = dyn_cast(E);
martinboehme wrote:
I'm not sure.
* The cases involving a `dyn_cast` need a cast anyway, as they access
pro
https://github.com/ckandeler updated
https://github.com/llvm/llvm-project/pull/83412
>From 78393d26e62f2f9a30f366501f8e61b1a32d6af4 Mon Sep 17 00:00:00 2001
From: Christian Kandeler
Date: Thu, 29 Feb 2024 12:26:52 +0100
Subject: [PATCH] [clangd] Remove potential prefix from enum value names
..
ckandeler wrote:
Incorporated review comments.
https://github.com/llvm/llvm-project/pull/83412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
> @pogo59 Hmm - I thought you held a strong preference that debugger tuning
> never be the only way to access a certain feature, and that we should always
> have direct control of these features via flags (but with default (or
> explicit) debugger tuning setting some of these fla
https://github.com/MikeWeller updated
https://github.com/llvm/llvm-project/pull/88138
>From 483bd05ec3c0575ed6771ef093368d6be19f5d3f Mon Sep 17 00:00:00 2001
From: Mike Weller
Date: Tue, 9 Apr 2024 16:03:31 +0100
Subject: [PATCH 1/4] [clang-tidy] Ignore delete ctor in
`bugprone-forwarding-refe
https://github.com/CarolineConcatto edited
https://github.com/llvm/llvm-project/pull/88105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CarolineConcatto approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -286,14 +286,26 @@ multiclass sme_outer_product_fp64
def : SME_ZA_Tile_TwoPred_TwoVec_Pat;
}
-multiclass sme2p1_fmop_tile_fp16 op,
ZPRRegOp zpr_ty>{
- def NAME : sme_fp_outer_product_inst {
+multiclass sme2p1_fmop_tile_f8f16 op> {
+ def NAME : sme_fp_outer_product_inst
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/88737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Donát?= Nagy ,NagyDonat
Message-ID:
In-Reply-To:
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/88416
>From da3b7d89dfa03555a39ff5f0b29cde225a8d6eda Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Mon, 11 Mar 2024 15:56:43 +0100
S
https://github.com/whisperity closed
https://github.com/llvm/llvm-project/pull/88655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: whisperity
Date: 2024-04-15T16:32:52+02:00
New Revision: a2691959cd23de9505243e9396897a3415606689
URL:
https://github.com/llvm/llvm-project/commit/a2691959cd23de9505243e9396897a3415606689
DIFF:
https://github.com/llvm/llvm-project/commit/a2691959cd23de9505243e9396897a3415606689.diff
LO
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/88740
This fixes an assertion in Expr::Classify when a
trying to deduce a dependent dereference operator.
Fixes #88329
>From 1d59c24d228404d9625ba58e7ec64b4bbd493bb2 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Dat
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
This fixes an assertion in Expr::Classify when a
trying to deduce a dependent dereference operator.
Fixes #88329
---
Full diff: https://github.com/llvm/llvm-project/pull/88740.diff
4 Files Affected:
- (modif
https://github.com/ckandeler approved this pull request.
https://github.com/llvm/llvm-project/pull/88737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -508,6 +508,11 @@ class ResultObjectVisitor : public
RecursiveASTVisitor {
isa(E)) {
return;
}
+if (auto *Op = dyn_cast(E);
ymand wrote:
I guess the `isa` calls were what we really jumped out since they amount to N
calls and tests on
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -298,6 +298,17 @@ multiclass ZAAddSub {
def NAME # _ZA64_VG1X2_F64 : Inst<"sv" # n_suffix # "_za64[_{d}]_vg1x2",
"vm2", "d", MergeNone, "aarch64_sme_" # n_suffix # "_za64_vg1x2", [IsStreaming,
IsInOutZA], []>;
def NAME # _ZA64_VG1X4_F64 : Inst<"sv" # n_suffix # "_za
@@ -0,0 +1,146 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 4
+; RUN: llc -verify-machineinstrs < %s | FileCheck %s
+
+target triple = "aarch64-linux"
CarolineConcatto wrote:
I think we should add the test
@@ -0,0 +1,191 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -fclang-abi-compat=latest
-triple aarch64-none-linux-gnu -target-feature +sme2p1 -target-feature
+sme-f16f16
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-backend-x86
@llvm/pr-subscribers-clang
Author: Maciej Gabka (mgabka)
Changes
This patch is moving out following intrinsics:
* vector.interleave2/deinterleave2
* vector.revert
* vector.splice
from the experimental names
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?=
Message-ID:
In-Reply-To:
RKSimon wrote:
Other than fixing the ReleaseNotes.rst conflict is there anything outstanding
on this now?
https://github.com/llvm/llvm-project/pull/76615
__
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/88750
Apple's ld supports alias_lists, described as
```
-alias_list filename
The specified filename contains a list of aliases. The symbol name
and its alias are on one
line, separate
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
Apple's ld supports alias_lists, described as
```
-alias_list filename
The specified filename contains a list of aliases. The symbol name
and its alias are on one
line, sepa
https://github.com/spavloff updated
https://github.com/llvm/llvm-project/pull/85605
>From 07e171e0566ab584299a57c210106bb8220c6261 Mon Sep 17 00:00:00 2001
From: Serge Pavlov
Date: Mon, 18 Mar 2024 13:20:15 +0700
Subject: [PATCH 1/4] [clang] Set correct FPOptions if attribute 'optnone'
present
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a06073f91e7532e68bbf6b903c2f5051f4c2
3170f89b36ccf3ad6003f24decb282e23951d943 --
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From d7a4e72f80a9dcd18770dec1e06fd54518b60233 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH] [InstallAPI] Add support for aliased exports
Apple's ld suppo
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/87933
>From 9fba6da7cb1ffbc7d46b69c6ac0cfd15a89c4b56 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Mon, 8 Apr 2024 01:38:23 +0800
Subject: [PATCH 1/2] [Clang] Support lifetime extension of temporary created
by aggreg
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/88750
>From b2b54ad8ccf930a19327563a64c52c9f4013103f Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 11 Apr 2024 13:13:45 -0700
Subject: [PATCH] [InstallAPI] Add support for aliased exports
Apple's ld suppo
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/88751
Fixes https://github.com/llvm/llvm-project/issues/88478
Promoting the `EHCleanup` to `NormalAndEHCleanup` in `EmitCallArgs` surfaced
another bug with deactivation of normal cleanups. Here we missed emitting CPP
sc
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Utkarsh Saxena (usx95)
Changes
Fixes https://github.com/llvm/llvm-project/issues/88478
Promoting the `EHCleanup` to `NormalAndEHCleanup` in `EmitCallArgs` surfaced
another bug with deactivation of normal cleanups. Here we missed emitting
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Utkarsh Saxena (usx95)
Changes
Fixes https://github.com/llvm/llvm-project/issues/88478
Promoting the `EHCleanup` to `NormalAndEHCleanup` in `EmitCallArgs` surfaced
another bug with deactivation of normal cleanups. Here we missed e
yronglin wrote:
friendly ping~ @hubert-reinterpretcast
https://github.com/llvm/llvm-project/pull/87930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2599,6 +2619,28 @@ multiclass sme2p1_multi_vec_array_vg4_index_16b op,
sme_elm_idx0_7:$imm3, multi_vector_ty:$Zn, zpr_ty:$Zm,
VectorIndexH:$i), 0>;
}
+// SME2.1 multi-vec ternary indexed four registers 16-bit
+multiclass sme2p1_multi_vec_array_vg4_index_16b op,
+
@@ -0,0 +1,462 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --filter-out "// kill:.*$" --version 4
+; RUN: llc -verify-machineinstrs < %s | FileCheck %s
+
CarolineConcatto wrote:
I believe we can add these tests in
@@ -2599,6 +2619,28 @@ multiclass sme2p1_multi_vec_array_vg4_index_16b op,
sme_elm_idx0_7:$imm3, multi_vector_ty:$Zn, zpr_ty:$Zm,
VectorIndexH:$i), 0>;
}
+// SME2.1 multi-vec ternary indexed four registers 16-bit
+multiclass sme2p1_multi_vec_array_vg4_index_16b op,
+
@@ -2461,9 +2461,29 @@ multiclass sme2_multi_vec_array_vg2_index_32b sz, bits<
}
// SME2.1 multi-vec ternary indexed two registers 16-bit
-// SME2 multi-vec indexed FP8 two-way dot product to FP16 two registers
multiclass sme2p1_multi_vec_array_vg2_index_16b sz,
bits<3> op,
@@ -0,0 +1,592 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
CarolineConcatto wrote:
If you change these prototypes to be sme2 like the ACLE we need to change these
run lines to be sme2
https://github.c
@@ -2461,9 +2461,29 @@ multiclass sme2_multi_vec_array_vg2_index_32b sz, bits<
}
// SME2.1 multi-vec ternary indexed two registers 16-bit
-// SME2 multi-vec indexed FP8 two-way dot product to FP16 two registers
multiclass sme2p1_multi_vec_array_vg2_index_16b sz,
bits<3> op,
@@ -0,0 +1,592 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -fclang-abi-compat=latest
-triple aarch64-none-linux-gnu -target-feature +sme2p1 -target-feature
+sme-f16f16
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/88751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@yronglin fee free to merge. Thanks!
https://github.com/llvm/llvm-project/pull/87930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/revane updated
https://github.com/llvm/llvm-project/pull/88735
>From 2249f8c4e28297d72d6f5d36e883b921116f33e4 Mon Sep 17 00:00:00 2001
From: Edwin Vane
Date: Thu, 28 Mar 2024 09:30:32 -0400
Subject: [PATCH] [clang-tidy] Refactor how NamedDecl are renamed
The handling of rena
@@ -61,6 +61,44 @@ struct
DenseMapInfo {
namespace clang::tidy {
namespace {
+/// Returns the function that \p Method is overridding. If There are none or
+/// multiple overrides it returns nullptr. If the overridden function itself is
+/// overridding then it will recurse up
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
@@ -451,6 +451,7 @@ ParsedAST::build(llvm::StringRef Filename, const
ParseInputs &Inputs,
DiagnosticConsumer *DiagConsumer = &ASTDiags;
IgnoreDiagnostics DropDiags;
if (Preamble) {
+CI->TargetOpts = Preamble->TargetOpts;
Patch = PreamblePatch::createFullPatch(Fi
yronglin wrote:
> @yronglin fee free to merge. Thanks!
Thanks for your confirmation!
https://github.com/llvm/llvm-project/pull/87930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yronglin
Date: 2024-04-15T23:52:26+08:00
New Revision: 7b9b28dbd2938877a94737e28b7eb9e3cdd82755
URL:
https://github.com/llvm/llvm-project/commit/7b9b28dbd2938877a94737e28b7eb9e3cdd82755
DIFF:
https://github.com/llvm/llvm-project/commit/7b9b28dbd2938877a94737e28b7eb9e3cdd82755.diff
LOG:
https://github.com/yronglin closed
https://github.com/llvm/llvm-project/pull/87930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/88602
>From 9d0656461683c4a6af76aa3990def06b04eb1b0a Mon Sep 17 00:00:00 2001
From: yronglin
Date: Sat, 13 Apr 2024 15:46:36 +0800
Subject: [PATCH] [Clang] Diagnose apply AST consume actions on LLVM IR
Signed-off-by:
yronglin wrote:
I'm not sure if this diagnostic information makes sense, do you have any
suggestions?
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
OCHyams wrote:
Thanks @dwblaikie
> Bit unfortunate to store template parameters in different ways (in the
> extraData for the alias template, but in the templateParams for the composite
> types) - but I guess it'd be more invasive to try to represent alias
> templates as composite types?
I
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?=
Message-ID:
In-Reply-To:
Destroyerrrocket wrote:
There are some minor comments I believe, I just haven't had any time to
look at them. I'm sorry about that! Hopefully I'll be able to give it the
nudge it
@@ -768,6 +764,35 @@ TEST(ParsedASTTest, GracefulFailureOnAssemblyFile) {
<< "Should not try to build AST for assembly source file";
}
+TEST(ParsedASTTest, PreambleWithDifferentTarget) {
+ constexpr std::string_view kPreambleTarget = "x86_64";
kadircet
kadircet wrote:
> Just to confirm I understand the broader context: we only need it when
> building the AST because the rest of the code (completions, signature help)
> actually already uses a compile command and FS from preamble inputs, right?
That was my remembrance, but apparently it was wr
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/88381
From 233f413b5921ff23c171fa5ada5623ad1a8e3d82 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 4 Apr 2024 10:57:44 +0200
Subject: [PATCH 1/2] [clangd] Propagate context into stdlib indexing thread
Some
https://github.com/bazuzi created
https://github.com/llvm/llvm-project/pull/88754
Moves free functions from DataflowEnvironment.h/cc and
DataflowAnalysisContext.h/cc to RecordOps and a new ASTOps and exposes them as
needed for current use and to expose getReferencedDecls for out-of-tree use.
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Samira Bazuzi (bazuzi)
Changes
Moves free functions from DataflowEnvironment.h/cc and
DataflowAnalysisContext.h/cc to RecordOps and a new ASTOps and exposes them as
needed for current use and to expose getReferencedDecls for out-
bazuzi wrote:
@ymand @martinboehme Apologies for the broken chains of comments; can you take
another look?
https://github.com/llvm/llvm-project/pull/88754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 02d98a20ad2214c928d6ffcc7f54abe1172a2407 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/4] Reapply "[Clang][Sema] Fix crash when 'this' is used
@@ -973,5 +978,24 @@ bool DylibVerifier::verifyBinaryAttrs(const
ArrayRef ProvidedTargets,
return true;
}
+std::unique_ptr DylibVerifier::getExports() {
+ for (const auto &[Alias, Base] : Aliases) {
ributzka wrote:
This loop runs every time someone calls
@@ -107,6 +107,9 @@ struct LinkerOptions {
/// \brief Additional library search paths.
PathSeq LibPaths;
+ /// \brief List of aliased symbol exports.
ributzka wrote:
```suggestion
/// \brief List of alias symbol files.
```
https://github.com/llvm/llvm
sdkrystian wrote:
The primary change since #88311 is `UnresolvedLookupExpr::Create` is called
directly in `BuildPossibleImplicitMemberExpr` with `KnownDependent` as `true`
(which causes the expression type to be set to `ASTContext::DependentTy`). This
ensures that any further semantic analysis
@@ -645,7 +645,7 @@ LazyValueInfoImpl::solveBlockValueImpl(Value *Val,
BasicBlock *BB) {
// instruction is placed, even if it could legally be hoisted much higher.
// That is unfortunate.
PointerType *PT = dyn_cast(BBI->getType());
- if (PT && isKnownNonZero(BBI, DL))
+
https://github.com/danix800 updated
https://github.com/llvm/llvm-project/pull/88014
>From 9b293d37ec5c0193e3ad4e1bab2d382ebe54d7b6 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Tue, 9 Apr 2024 00:26:03 +0800
Subject: [PATCH 1/3] [AST][RecoveryExpr] Fix a crash on c89/c90 invalid
InitListExpr (#
@@ -3391,7 +3391,7 @@ class Sema final : public SemaBase {
bool ConstexprSupported, bool CLinkageMayDiffer);
/// type checking declaration initializers (C99 6.7.8)
- bool CheckForConstantInitializer(Expr *e, QualType t);
+ bool CheckForConstantInitializer(Expr *Init,
https://github.com/ymand approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/88754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov approved this pull request.
Minor nit, otherwise LGTM.
https://github.com/llvm/llvm-project/pull/81662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/81662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3453,6 +3453,10 @@ ExprResult Sema::BuildDeclarationNameExpr(const
CXXScopeSpec &SS,
NeedsADL, R.isOverloadedResult(),
R.begin(), R.end());
+ if (ULE && R.isSingleResult() && R.getFoundDecl()->isInvali
101 - 200 of 450 matches
Mail list logo
