[clang] Fix printing of templated records. (PR #86339)

2024-03-27 Thread via cfe-commits
mikaelholmen wrote: > @zahiraam I still get > > ``` > ../../clang/unittests/AST/DeclPrinterTest.cpp:1394:3: error: expression > result unused [-Werror,-Wunused-value] > [](PrintingPolicy &Policy) { Policy.SuppressTagKeyword = false; }; > ^

[clang] defc485 - [AArch64] Remove Automatic Enablement of FEAT_F32MM (#85203)

2024-03-27 Thread via cfe-commits
Author: Jack Styles Date: 2024-03-27T07:49:38Z New Revision: defc4859b032ccaec69f24b6cfd9882fece5f093 URL: https://github.com/llvm/llvm-project/commit/defc4859b032ccaec69f24b6cfd9882fece5f093 DIFF: https://github.com/llvm/llvm-project/commit/defc4859b032ccaec69f24b6cfd9882fece5f093.diff LOG: [

[clang] [llvm] [AArch64] Remove Automatic Enablement of FEAT_F32MM (PR #85203)

2024-03-27 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 closed https://github.com/llvm/llvm-project/pull/85203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread via cfe-commits
https://github.com/komalverma04 edited https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Matt Arsenault via cfe-commits
@@ -1399,13 +1401,22 @@ RValue AtomicInfo::convertAtomicTempToRValue(Address addr, LVal.getBaseInfo(), TBAAAccessInfo())); } +static bool shouldCastToInt(llvm::Type *ValTy, bool CmpXchg) { arsenm wrote: The answer should just be false. I see no reason

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Matt Arsenault via cfe-commits
arsenm wrote: > The non-ieee FP types left out as it seems easier if someone working with > that target does this part including test updates, which should be simple > enough by now. Just add the tests https://github.com/llvm/llvm-project/pull/86691 _

[clang] [compiler-rt] [clang][UBSan] Add implicit conversion check for bitfields (PR #75481)

2024-03-27 Thread Axel Lundberg via cfe-commits
Zonotora wrote: > Also, I don't have commit access (first PR here), someone has to commit on my > behalf! @AaronBallman https://github.com/llvm/llvm-project/pull/75481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [llvm] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #86721)

2024-03-27 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/86721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Implement 32-bit expansion for rldimi (PR #86783)

2024-03-27 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises created https://github.com/llvm/llvm-project/pull/86783 rldimi is 64-bit instruction, due to backward compatibility, it needs to be expanded into series of rlwimi in 32-bit environment. In the future, we may improve bit permutation selector and remove such direct c

[clang] [llvm] [PowerPC] Implement 32-bit expansion for rldimi (PR #86783)

2024-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-powerpc Author: Qiu Chaofan (ecnelises) Changes rldimi is 64-bit instruction, due to backward compatibility, it needs to be expanded into series of rlwimi in 32-bit environment. In the future, we may improve bit permu

[clang] [clang] CTAD: Track template template type parameters that referenced in (PR #85405)

2024-03-27 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/85405 >From 2d3aee2e763e3e4970d97406e59df66e5861d5ba Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 15 Mar 2024 15:09:10 +0100 Subject: [PATCH 1/2] [clang] CTAD: Track template template type parameters that refer

[clang] [clang] CTAD: Track template template type parameters that referenced in (PR #85405)

2024-03-27 Thread Haojian Wu via cfe-commits
hokein wrote: > But my question is: how does the missing call to `MarkAppeared()` leads to > the out-of-bounds access? Do we allocate a vector that has the size of > `max(Index)` and expect that we have previously marked all template > parameters mentioned in the type? Yes, almost. The templa

[clang] [X86_64] fix arg pass error in struct. (PR #85394)

2024-03-27 Thread Longsheng Mou via cfe-commits
https://github.com/CoTinker updated https://github.com/llvm/llvm-project/pull/85394 >From ad805988f682030cd3ed6ff6b063488ed6f5707c Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 15 Mar 2024 20:50:54 +0800 Subject: [PATCH] [X86_64] fix arg pass error in struct. In some struct like s67,

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/86411 >From b6ca6f0ef83d03e299d6ee9a8ed9b8044477914e Mon Sep 17 00:00:00 2001 From: komalverma04 <114138604+komalverm...@users.noreply.github.com> Date: Sat, 23 Mar 2024 11:14:44 -0700 Subject: [PATCH 1/7] Update check

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
steakhal wrote: I figured, it might be easier to directly propose and apply some of my thoughts. Let me know if you like it. My goal was: - be specific what is the impact of not having the optimal layout: memory, cachemisses - have a single block of examples, demonstrating the bad, the good a

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-03-27 Thread Krystian Stasiowski via cfe-commits
@@ -75,6 +75,25 @@ class TextTokenRetokenizer { return *Pos.BufferPtr; } + char peekNext(unsigned offset) const { +assert(!isEnd()); +assert(Pos.BufferPtr != Pos.BufferEnd); +if (Pos.BufferPtr + offset <= Pos.BufferEnd) { sdkrystian wrote:

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-03-27 Thread Krystian Stasiowski via cfe-commits
@@ -149,6 +276,93 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexType(Token &Tok) { +if (isEnd()) + return false; +Position SavedPos = Pos; +consumeWhitespace(); +SmallString<32> NextToken; +SmallString<32

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-03-27 Thread Krystian Stasiowski via cfe-commits
@@ -149,6 +276,93 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexType(Token &Tok) { +if (isEnd()) + return false; +Position SavedPos = Pos; +consumeWhitespace(); +SmallString<32> NextToken; +SmallString<32

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-03-27 Thread Krystian Stasiowski via cfe-commits
@@ -89,6 +108,114 @@ class TextTokenRetokenizer { } } + bool continueInt(SmallString<32> &NextToken) { +return NextToken.ends_with(StringRef("char")) || sdkrystian wrote: Don't really understand what this is for... https://github.com/llvm/llvm-pro

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-03-27 Thread Krystian Stasiowski via cfe-commits
@@ -149,6 +276,93 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexType(Token &Tok) { +if (isEnd()) + return false; +Position SavedPos = Pos; +consumeWhitespace(); +SmallString<32> NextToken; +SmallString<32

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: > > The non-ieee FP types left out as it seems easier if someone working with > > that target does this part including test updates, which should be simple > > enough by now. > > Just add the tests I think this case isn't that simple as it is an 80 bit value. Currently that i

[clang] Fix buildbot failure. (PR #86741)

2024-03-27 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/86741 >From 8d113344d0742f80bc967019131c9111a0db78ff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 26 Mar 2024 14:21:16 -0700 Subject: [PATCH] Fix buildbot https://lab.llvm.org/buildbot/#/builders/36/

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/86536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread Balazs Benics via cfe-commits
@@ -124,34 +124,45 @@ class CStringChecker : public Checker< eval::Call, const CallEvent &)>; CallDescriptionMap Callbacks = { - {{CDM::CLibrary, {"memcpy"}, 3}, + {{CDM::CLibraryMaybeHardened, {"memcpy"}, 3}, std::bind(

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread Balazs Benics via cfe-commits
@@ -110,13 +110,24 @@ bool CheckerContext::isCLibraryFunction(const FunctionDecl *FD, if (FName.starts_with("__inline") && FName.contains(Name)) return true; - if (FName.starts_with("__") && FName.ends_with("_chk") && - FName.contains(Name)) -return true; -

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: I like your patch. This is an important fix. I only had a couple nits, but overall looks good. https://github.com/llvm/llvm-project/pull/86536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread Balazs Benics via cfe-commits
@@ -124,34 +124,45 @@ class CStringChecker : public Checker< eval::Call, const CallEvent &)>; CallDescriptionMap Callbacks = { - {{CDM::CLibrary, {"memcpy"}, 3}, + {{CDM::CLibraryMaybeHardened, {"memcpy"}, 3}, std::bind(

[clang] [clang][ExtractAPI] Add ability to create multiple symbol graphs (PR #86676)

2024-03-27 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg deleted https://github.com/llvm/llvm-project/pull/86676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Jonas Paulsson via cfe-commits
@@ -1399,13 +1401,22 @@ RValue AtomicInfo::convertAtomicTempToRValue(Address addr, LVal.getBaseInfo(), TBAAAccessInfo())); } +static bool shouldCastToInt(llvm::Type *ValTy, bool CmpXchg) { JonPsson1 wrote: This is a bit messy... - For one thing, there

[clang] [compiler-rt] [clang][UBSan] Add implicit conversion check for bitfields (PR #75481)

2024-03-27 Thread Aaron Ballman via cfe-commits
@@ -147,6 +147,7 @@ struct ImplicitConversionData { const TypeDescriptor &FromType; const TypeDescriptor &ToType; /* ImplicitConversionCheckKind */ unsigned char Kind; + unsigned int BitfieldBits; AaronBallman wrote: Ping @zygoloid -- I'm not certain if

[clang] [compiler-rt] [clang][UBSan] Add implicit conversion check for bitfields (PR #75481)

2024-03-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Also, I don't have commit access (first PR here), someone has to commit on > > my behalf! > > @AaronBallman Thank you for mentioning this! I'll commit on your behalf, but I'd like to hear from @zygoloid on the ABI question. It would also be nice if @efriedma-quic sign

[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

2024-03-27 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Ping @erichkeane https://github.com/llvm/llvm-project/pull/84050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

2024-03-27 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/85460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [CodeGen][LLVM] Make the `va_list` related intrinsics generic. (PR #85460)

2024-03-27 Thread Alex Voicu via cfe-commits
AlexVlx wrote: Thank you everyone for the reviews. https://github.com/llvm/llvm-project/pull/85460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread via cfe-commits
https://github.com/NagyDonat approved this pull request. Overall LGTM, I have minor inline suggestions that clarify the description of bitpacking (but the current state is also acceptable). https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commi

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread via cfe-commits
@@ -804,10 +804,88 @@ Check for performance anti-patterns when using Grand Central Dispatch. .. _optin-performance-Padding: -optin.performance.Padding -" +optin.performance.Padding (C, C++, ObjC) + Check for ex

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread via cfe-commits
@@ -804,10 +804,88 @@ Check for performance anti-patterns when using Grand Central Dispatch. .. _optin-performance-Padding: -optin.performance.Padding -" +optin.performance.Padding (C, C++, ObjC) + Check for ex

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread via cfe-commits
@@ -124,34 +124,45 @@ class CStringChecker : public Checker< eval::Call, const CallEvent &)>; CallDescriptionMap Callbacks = { - {{CDM::CLibrary, {"memcpy"}, 3}, + {{CDM::CLibraryMaybeHardened, {"memcpy"}, 3}, std::bind(

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/86536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread via cfe-commits
https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/86536 >From fdde1056e8a34ad642f50eef120dbc8ee08f8825 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Mon, 18 Mar 2024 14:47:57 +0100 Subject: [PATCH 1/2] [analyzer] Make recognition of hardened __F

[clang] [Clang][Sema] Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > LGTM > > The one thing I'm worried about here is the possibility that a future C > standard version standardizes a similar extension, but with different > semantics (since we're not using any reserved keywords here). Like I > mentioned before, that's very unlikely to hap

[clang] [NFC][CLANG] Fix null pointer dereferences (PR #86760)

2024-03-27 Thread Botond István Horváth via cfe-commits
HoBoIs wrote: Looks good to me. https://github.com/llvm/llvm-project/pull/86760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread via cfe-commits
NagyDonat wrote: [Replying to the following inline comment of @steakhal :] > You had a comment about __builtin___vsprintf_chk. ``` // This is using `equals()` instead of more lenient prefix/suffix/substring // checks because we don't want to say that e.g. `__builtin___vsprintf_chk()` // is

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread via cfe-commits
komalverma04 wrote: Okay, i completely agree with you. Thank you so much for helping. https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/86536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix an out-of-bound crash when checking template partial specializations. (PR #86794)

2024-03-27 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/86794 I found this issue (a separate one) during the investigation of #86757, the crash is similar in substituteParameterMappings, but at different inner places. This was an out-of-bound issue where we access front ele

[clang] [clang] Fix an out-of-bound crash when checking template partial specializations. (PR #86794)

2024-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes I found this issue (a separate one) during the investigation of #86757, the crash is similar in substituteParameterMappings, but at different inner places. This was an out-of-bound issue where we access front

[clang] add some missing Kinds to libclang python bindings (PR #85571)

2024-03-27 Thread Thomas Schenker via cfe-commits
schenker wrote: Thanks for the fix. Will these changes find their way into an 18.x release? https://github.com/llvm/llvm-project/pull/85571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [Clang][Sema] Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. I think the changes LGTM, but I do think we've got some more work to do to make this a first-class extension. For example, we lack constant expression support: ``` struct S { int y[]; }; constexpr struct S a1 = { 8, 12 }; ``` gives: ```

[clang] [analyzer] Make recognition of hardened __FOO_chk functions explicit (PR #86536)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM, but I'd recommed @Xazax-hun to also have a look. If nothing happens, merge this after one week. https://github.com/llvm/llvm-project/pull/86536 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/86411 >From b6ca6f0ef83d03e299d6ee9a8ed9b8044477914e Mon Sep 17 00:00:00 2001 From: komalverma04 <114138604+komalverm...@users.noreply.github.com> Date: Sat, 23 Mar 2024 11:14:44 -0700 Subject: [PATCH 1/8] Update check

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/86411 >From b6ca6f0ef83d03e299d6ee9a8ed9b8044477914e Mon Sep 17 00:00:00 2001 From: komalverma04 <114138604+komalverm...@users.noreply.github.com> Date: Sat, 23 Mar 2024 11:14:44 -0700 Subject: [PATCH 1/9] Update check

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Fix second arg of __builtin_{clzg,ctzg} not always being evaluated (PR #86742)

2024-03-27 Thread via cfe-commits
https://github.com/overmighty updated https://github.com/llvm/llvm-project/pull/86742 >From c615f656153fcb1d4158548660f87d1d69960864 Mon Sep 17 00:00:00 2001 From: OverMighty Date: Tue, 26 Mar 2024 21:25:59 + Subject: [PATCH 1/3] [clang][ExprConst] Fix second arg of __builtin_{clzg,ctzg} n

[clang] [RFC][Clang] Enable custom type checking for printf (PR #86801)

2024-03-27 Thread Vikram Hegde via cfe-commits
https://github.com/vikramRH created https://github.com/llvm/llvm-project/pull/86801 The motivation for this change comes from an ongoing PR (#72556 ) , which enables hostcall based printf lowering for AMDGPU target and OpenCL inputs. The OpenCL printf has a different signature than the C print

[clang] [analyzer] Document the `optin.performance.Padding` checker (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

2024-03-27 Thread Vikram Hegde via cfe-commits
https://github.com/vikramRH closed https://github.com/llvm/llvm-project/pull/72554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Treat printf as builtin for OpenCL (PR #72554)

2024-03-27 Thread Vikram Hegde via cfe-commits
vikramRH wrote: closing this in favour of https://github.com/llvm/llvm-project/pull/86801 https://github.com/llvm/llvm-project/pull/72554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] b8cc838 - [analyzer][docs] Document the `optin.performance.Padding` checker (#86411)

2024-03-27 Thread via cfe-commits
Author: komalverma04 Date: 2024-03-27T13:51:27+01:00 New Revision: b8cc838427efa80eb5ca4ec7c8adb53e4adfc4c7 URL: https://github.com/llvm/llvm-project/commit/b8cc838427efa80eb5ca4ec7c8adb53e4adfc4c7 DIFF: https://github.com/llvm/llvm-project/commit/b8cc838427efa80eb5ca4ec7c8adb53e4adfc4c7.diff

[clang] [analyzer] Document the `optin.performance.Padding` checker (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][docs] Document the `optin.performance.Padding` checker (PR #86411)

2024-03-27 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][docs] Document the `optin.performance.Padding` checker (PR #86411)

2024-03-27 Thread via cfe-commits
github-actions[bot] wrote: @komalverma04 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a b

[clang] [clang] Fix an out-of-bound crash when checking template partial specializations. (PR #86794)

2024-03-27 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/86794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Matt Arsenault via cfe-commits
arsenm wrote: > I think this case isn't that simple as it is an 80 bit value. Currently that > is loaded atomically first with i128, then stored as a temporary and then > loaded as an fp80. If I remove that casting, the verifier complains "atomic > memory access' operand must have a power-of-t

[clang] [APINotes] Upstream the remaining API Notes fixes and tests (PR #84773)

2024-03-27 Thread Egor Zhdan via cfe-commits
egorzhdan wrote: I'm going to land this patch now to unblock other work on APINotes, but I'm happy to address more review feedback post-merge. https://github.com/llvm/llvm-project/pull/84773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [APINotes] Upstream the remaining API Notes fixes and tests (PR #84773)

2024-03-27 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/84773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix anonymous reference parameter with default value (PR #86254)

2024-03-27 Thread via cfe-commits
https://github.com/rayroudc updated https://github.com/llvm/llvm-project/pull/86254 >From bda7c429a4072e54b99d4fbd561fbd5d406692fd Mon Sep 17 00:00:00 2001 From: "C. Rayroud" Date: Mon, 18 Mar 2024 06:39:26 + Subject: [PATCH] [clang-format] Fix anonymous reference parameter with default va

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-03-27 Thread Kishan Parmar via cfe-commits
@@ -396,12 +405,85 @@ CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { return CharUnits::fromQuantity(4); } +ABIArgInfo PPC32_SVR4_ABIInfo::handleComplex(uint64_t &TypeSize) const { + llvm::Type *ElemTy; + unsigned RegsNeeded; // Registers Needed f

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-03-27 Thread Kishan Parmar via cfe-commits
https://github.com/Long5hot edited https://github.com/llvm/llvm-project/pull/77732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __is_array returning true for zero-sized arrays (PR #86652)

2024-03-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > I think we need to consider the following things: > > ``` > > * Should `Ty[0]` and `Ty[]` be handled the same way? (Remember, we support > > `[0]` in structures as a sort of flexible array member and we support > > flexible array members in C++ as an extension.) > > ```

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-27 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add const-qualified `getIteratorModifier` to OMPMapClause (PR #86666)

2024-03-27 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Will revisit this when the using code is ready for review/merge. https://github.com/llvm/llvm-project/pull/8 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-03-27 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx @llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang @llvm/pr-subscribers-mlir Author: None (AngryLoki) Changes This fixes "SyntaxWarning: invalid escape sequence" and "SyntaxWarning: "is" with 'int' literal", exce

[clang] [clang] Fix an out-of-bound crash when checking template partial specializations. (PR #86794)

2024-03-27 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/86794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 11b20d7 - [clang] Fix an out-of-bound crash when checking template partial specializations. (#86794)

2024-03-27 Thread via cfe-commits
Author: Haojian Wu Date: 2024-03-27T15:31:55+01:00 New Revision: 11b20d7ab09511d9e2bcd40606dfd3b31976efe0 URL: https://github.com/llvm/llvm-project/commit/11b20d7ab09511d9e2bcd40606dfd3b31976efe0 DIFF: https://github.com/llvm/llvm-project/commit/11b20d7ab09511d9e2bcd40606dfd3b31976efe0.diff LO

[clang] [CLANG][DRIVER] Resolve Argument Visibility and Duplication Issue for Cuda ToolChain (PR #86807)

2024-03-27 Thread Jefferson Le Quellec via cfe-commits
https://github.com/jle-quel created https://github.com/llvm/llvm-project/pull/86807 # Description This PR makes the argument `-Xcuda-ptxas` visible to the driver in cl-mode. Furthermore, it has been noticed that the arguments are being passed twice to `ptxas`. This also has been fixed by filt

[clang] [CLANG][DRIVER] Resolve Argument Visibility and Duplication Issue for Cuda ToolChain (PR #86807)

2024-03-27 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [CLANG][DRIVER] Resolve Argument Visibility and Duplication Issue for Cuda ToolChain (PR #86807)

2024-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jefferson Le Quellec (jle-quel) Changes # Description This PR makes the argument `-Xcuda-ptxas` visible to the driver in cl-mode. Furthermore, it has been noticed that the arguments are being passed twice to `ptxas`. This also has

[clang] [CLANG][DRIVER] Resolve Argument Visibility and Duplication Issue for Cuda ToolChain (PR #86807)

2024-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jefferson Le Quellec (jle-quel) Changes # Description This PR makes the argument `-Xcuda-ptxas` visible to the driver in cl-mode. Furthermore, it has been noticed that the arguments are being passed twice to `ptxas`. This also has been f

[clang] [AST] Print the "aggregate" for aggregate deduction guide decl. (PR #84018)

2024-03-27 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/84018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Print the "aggregate" for aggregate deduction guide decl. (PR #84018)

2024-03-27 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/84018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Print the "aggregate" for aggregate deduction guide decl. (PR #84018)

2024-03-27 Thread Sam McCall via cfe-commits
@@ -1990,6 +1990,18 @@ void TextNodeDumper::VisitFunctionDecl(const FunctionDecl *D) { } } +void TextNodeDumper::VisitCXXDeductionGuideDecl(const CXXDeductionGuideDecl *D) { + VisitFunctionDecl(D); + switch (D->getDeductionCandidateKind()) { + case DeductionCandidate::N

[clang] [clang][RISCV] Enable RVV with function attribute __attribute__((target("arch=+v"))) (PR #83674)

2024-03-27 Thread Brandon Wu via cfe-commits
@@ -8927,8 +8927,13 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) { } } - if (T->isRVVSizelessBuiltinType()) -checkRVVTypeSupport(T, NewVD->getLocation(), cast(CurContext)); + if (T->isRVVSizelessBuiltinType() && isa(CurContext)) { +const FunctionD

[clang] [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies… (PR #86808)

2024-03-27 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/86808 … with auto keyword Reported by Static Analyzer Tool: In clang::installapi::InstallAPIVisitor::VisitFunctionDecl(clang::FunctionDecl const *): Using the auto keyword without an & causes the copy of an object o

[clang] [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies… (PR #86808)

2024-03-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes … with auto keyword Reported by Static Analyzer Tool: In clang::installapi::InstallAPIVisitor::VisitFunctionDecl(clang::FunctionDecl const *): Using the auto keyword without an & causes the copy of an object of t

[clang] [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies… (PR #86808)

2024-03-27 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/86808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto keyword (PR #86808)

2024-03-27 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/86808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Enable -fconvergent-functions by default (PR #86571)

2024-03-27 Thread via cfe-commits
aniplcc wrote: I was getting match errors with the RUN script. I went ahead and updated it with the checks in: `clang/test/CodeGen/convergent-functions.cpp` Hope that's correct/OK? ```hlsl // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.4-library -emit-llvm -disable-llvm-passes -o - %s |

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 updated https://github.com/llvm/llvm-project/pull/86691 >From ea3c2d02073ecd3761b53783ad78c132ba88486e Mon Sep 17 00:00:00 2001 From: Jonas Paulsson Date: Tue, 26 Mar 2024 01:16:25 +0100 Subject: [PATCH 1/2] Refactoring with shouldCastToInt(). Also include atomic p

[clang] [ClangFE] Improve handling of casting of atomic memory operations. (PR #86691)

2024-03-27 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: > > I think this case isn't that simple as it is an 80 bit value. Currently > > that is loaded atomically first with i128, then stored as a temporary and > > then loaded as an fp80. If I remove that casting, the verifier complains > > "atomic memory access' operand must have a

[clang] [clang][dataflow] Introduce a helper class for handling record initializer lists. (PR #86675)

2024-03-27 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/86675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Introduce a helper class for handling record initializer lists. (PR #86675)

2024-03-27 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/86675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Introduce a helper class for handling record initializer lists. (PR #86675)

2024-03-27 Thread Yitzhak Mandelbaum via cfe-commits
@@ -744,6 +744,35 @@ RecordStorageLocation *getBaseObjectLocation(const MemberExpr &ME, std::vector getFieldsForInitListExpr(const InitListExpr *InitList); +/// Helper class for initialization of a record with an `InitListExpr`. +/// `InitListExpr::inits()` contains the initi

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-03-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. Libc++ parts LGTM. https://github.com/llvm/llvm-project/pull/86806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Enable -fconvergent-functions by default (PR #86571)

2024-03-27 Thread via cfe-commits
https://github.com/aniplcc updated https://github.com/llvm/llvm-project/pull/86571 >From c22f63359b7391e9f69d74e5d4f4bdf6cf585c2c Mon Sep 17 00:00:00 2001 From: aniplcc Date: Tue, 26 Mar 2024 01:35:36 +0530 Subject: [PATCH 1/2] [HLSL] Enable -fconvergent-functions by default --- clang/lib/Fro

[clang] [HLSL] enforce unsigned types for reversebits (PR #86720)

2024-03-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/86720 >From 13296921ee46ab93d703eb7446479ce8aa7fadce Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Tue, 26 Mar 2024 15:15:03 -0400 Subject: [PATCH] [HLSL] enforce unsigned types for reversebits fixes #86719 `SemaC

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] Fix SyntaxWarning messages from python 3.12 (PR #86806)

2024-03-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r e82765bf07a978674c0e75c8b2e20f154ae24a4c...c7d6289573379be760ca9d691d62e0f87ba0ee8a .gith

[clang] [llvm] [RISCV] RISCV vector calling convention (1/2) (PR #77560)

2024-03-27 Thread Brandon Wu via cfe-commits
4vtomat wrote: Rebase and squash https://github.com/llvm/llvm-project/pull/77560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >