[clang-tools-extra] [clang-tidy] Added bugprone-exception-rethrow check (PR #86448)

2024-03-25 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,50 @@ +//===--- ExceptionRethrowCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-format] Fix anonymous reference parameter with default value (PR #86254)

2024-03-25 Thread via cfe-commits
https://github.com/rayroudc updated https://github.com/llvm/llvm-project/pull/86254 >From 3d4d9d701ee39d0bd4d60e4d0cd4a8577ce085d7 Mon Sep 17 00:00:00 2001 From: "C. Rayroud" Date: Mon, 18 Mar 2024 06:39:26 + Subject: [PATCH 1/2] [clang-format] Fix anonymous reference parameter with defaul

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/85497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Thanks for the patch! https://github.com/llvm/llvm-project/pull/85497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Nathan Ridge via cfe-commits
@@ -367,7 +367,13 @@ class Checker { auto Hints = inlayHints(*AST, LineRange); for (const auto &Hint : Hints) { - vlog(" {0} {1} {2}", Hint.kind, Hint.position, Hint.label); + vlog(" {0} {1} [{2}]", Hint.kind, Hint.position, [&] { +return llvm::join

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Nathan Ridge via cfe-commits
@@ -1483,9 +1483,18 @@ llvm::json::Value toJSON(const InlayHintKind &Kind) { llvm_unreachable("Unknown clang.clangd.InlayHintKind"); } +namespace { + +llvm::json::Array toJSON(const std::vector &Labels) { + return llvm::json::Array{ + llvm::map_range(Labels, [](auto &L

[clang-tools-extra] [clang-tidy] Added bugprone-exception-rethrow check (PR #86448)

2024-03-25 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: > By the way, looking at the issue, it seems like someone claimed to be working > on it, though we haven't seen any progress so far. Was it okay to take over > before asking that person first? No pull request, no branch, no update for almost 3 months. I assumed that it's abando

[clang] [clang-format] Fix anonymous reference parameter with default value (PR #86254)

2024-03-25 Thread via cfe-commits
@@ -471,6 +471,9 @@ AlignTokenSequence(const FormatStyle &Style, unsigned Start, unsigned End, Previous >= 0 && Changes[Previous].Tok->getType() == TT_PointerOrReference; --Previous) { +// Don't align function default argument using ret

[clang] [clang-format] Fix anonymous reference parameter with default value (PR #86254)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-03-25 Thread Felix via cfe-commits
@@ -3369,6 +3369,48 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, bool Is64Bit = Subtarget.isPPC64(); bool HasAIXSmallLocalExecTLS = Subtarget.hasAIXSmallLocalExecTLS(); TLSModel::Model Model = getTargetMachine().getTLSModel(GV); + // Initialize heu

[clang] [llvm] [Sema] Implement support for -Wformat-signedness (PR #74440)

2024-03-25 Thread Karl-Johan Karlsson via cfe-commits
karka228 wrote: > Can you also add a test showing the difference between `-Wformat > -Wformat-signedness` and `-Wformat-signedness` by itself (which does nothing)? With the current implementation `-Wformat-signedness` by itself actually turn on the signedness warnings. This is not compatible w

[clang] [llvm] [Sema] Implement support for -Wformat-signedness (PR #74440)

2024-03-25 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 updated https://github.com/llvm/llvm-project/pull/74440 >From aa9d6cd10ff32fdcdd3d1b2ef334aa70f56cccb1 Mon Sep 17 00:00:00 2001 From: Karl-Johan Karlsson Date: Tue, 5 Dec 2023 10:03:00 +0100 Subject: [PATCH 1/8] [Sema] Implement support for -Wformat-signedness In gc

[clang] [OpenMP] Allow dynamic `condition` selector in Metadirective (PR #86457)

2024-03-25 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/86457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sema] Implement support for -Wformat-signedness (PR #74440)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/74440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [OpenMP] Allow dynamic `condition` selector in Metadirective (PR #86457)

2024-03-25 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis edited https://github.com/llvm/llvm-project/pull/86457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Issue #19 and #20 - Describe auto (C++11) type inferences (PR #86474)

2024-03-25 Thread Nisarga V via cfe-commits
https://github.com/nisarga3 created https://github.com/llvm/llvm-project/pull/86474 None >From 6d3343fe3894d1706baa6316d76a5277af596f91 Mon Sep 17 00:00:00 2001 From: Nisarga V Date: Tue, 19 Mar 2024 06:35:04 -0500 Subject: [PATCH 1/2] Added 'fdump-autotype inference' option for Issue #19. -

[clang] Issue #19 and #20 - Describe auto (C++11) type inferences (PR #86474)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Issue #19 and #20 - Describe auto (C++11) type inferences (PR #86474)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nisarga V (nisarga3) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/86474.diff 7 Files Affected: - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+2) - (modified) clang/include/clang/Basic/LangOptions.d

[clang] Issue #19 and #20 - Describe auto (C++11) type inferences (PR #86474)

2024-03-25 Thread Nisarga V via cfe-commits
https://github.com/nisarga3 closed https://github.com/llvm/llvm-project/pull/86474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-03-25 Thread Felix via cfe-commits
@@ -329,6 +329,12 @@ def FeatureAIXLocalExecTLS : "Produce a TOC-free local-exec TLS sequence for this function " "for 64-bit AIX">; +def FeatureAIXSharedLibraryTLSModelHeuristic : + SubtargetFeature<"aix-shared-library-tls-model-heurist

[clang-tools-extra] [clangd] Support outgoing calls in call hierarchy (PR #77556)

2024-03-25 Thread via cfe-commits
pidgeon777 wrote: I was thinking that it's a real pity this branch is so hard to get merged 😅 I think other than the review it would be 100% done? I mean, no big further modifications would be involved? https://github.com/llvm/llvm-project/pull/77556 ___

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/84132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [PowerPC] Tune AIX shared library TLS model at function level by heuristic (PR #84132)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/84132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang-repl] Fix Value for platforms where unqualified char is unsigned (PR #86118)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
weliveindetail wrote: Windows buildbot failure is unrelated. This code is covered in unittest ClangReplInterpreterTests and it passed. https://github.com/llvm/llvm-project/pull/86118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] aa962d6 - [clang-repl] Fix Value for platforms where unqualified char is unsigned (#86118)

2024-03-25 Thread via cfe-commits
Author: Stefan GrÀnitz Date: 2024-03-25T09:42:41+01:00 New Revision: aa962d67ee896f416e285a9298e45fc08ff95eef URL: https://github.com/llvm/llvm-project/commit/aa962d67ee896f416e285a9298e45fc08ff95eef DIFF: https://github.com/llvm/llvm-project/commit/aa962d67ee896f416e285a9298e45fc08ff95eef.diff

[clang] [clang-repl] Fix Value for platforms where unqualified char is unsigned (PR #86118)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/86118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0cf4788 - [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (#84461)

2024-03-25 Thread via cfe-commits
Author: Stefan GrÀnitz Date: 2024-03-25T09:44:25+01:00 New Revision: 0cf4788d9d0df60980cb48d28aafe7a86aa15a14 URL: https://github.com/llvm/llvm-project/commit/0cf4788d9d0df60980cb48d28aafe7a86aa15a14 DIFF: https://github.com/llvm/llvm-project/commit/0cf4788d9d0df60980cb48d28aafe7a86aa15a14.diff

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/84461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Ping for review: @AaronBallman @jyknight @efriedma-quic @zygoloid Could you please suggest other reviewers if you do not have the bandwidth for the same? https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-co

[clang] [clang][dataflow] Bail out if input is Objective-C++. (PR #86479)

2024-03-25 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/86479 We only ever intended to support C++, but the condition we were testing allowed Objective-C++ code by mistake. >From cfbd1b3633b78a2323eb5aebcb637112eeaa1571 Mon Sep 17 00:00:00 2001 From: Martin Braenne D

[clang] [clang][dataflow] Bail out if input is Objective-C++. (PR #86479)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes We only ever intended to support C++, but the condition we were testing allowed Objective-C++ code by mistake. --- Full diff: https://github.com/llvm/llvm-project/pull/86479.diff 3 Files Affected: -

[clang] [clang][dataflow] Bail out if input is Objective-C++. (PR #86479)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang][dataflow] Bail out if input is Objective-C++. (PR #86479)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang] Catch missing format attributes (PR #70024)

2024-03-25 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From 7adedf54a6c4d509046915777600b6e66b90bb8c Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 13 Oct 2023 14:45:15 +0200 Subject: [PATCH] [clang] Catch missing format attribu

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy Message-ID: In-Reply-To: @@ -394,8 +394,10 @@ class MallocChecker const CallEvent &Call, CheckerContext &C)>; const CallDescriptionMap PreFnMap{ - {{{"getline"}, 3}, &MallocChecker:

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy Message-ID: In-Reply-To: @@ -446,8 +448,11 @@ class MallocChecker std::bind(&MallocChecker::checkRealloc, _1, _2, _3, false)}, {{{"g_realloc_n"}, 3}, &MallocChecker::checkReallocN}, {{{"g_try_reallo

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy ,NagyDonat Message-ID: In-Reply-To: https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/85791 >From 3fbc8da42726aa63ad0aef7ba12141125197279b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Tue, 19

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy ,NagyDonat Message-ID: In-Reply-To: https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/85791 >From 3fbc8da42726aa63ad0aef7ba12141125197279b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Tue, 19

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy ,NagyDonat Message-ID: In-Reply-To: github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/85791

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Jan Patrick Lehr via cfe-commits
Stefan =?utf-8?q?GrÀnitz?= Message-ID: In-Reply-To: jplehr wrote: Hi, I think this one broke one of our buildbots: https://lab.llvm.org/buildbot/#/builders/259/builds/1769 I'm happy to help looking into it. https://github.com/llvm/llvm-project/pull/84461

[clang] 772e316 - [FMV] Allow multi versioning without default declaration. (#85454)

2024-03-25 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-03-25T09:43:41Z New Revision: 772e316457ef94759804d9f4da0af70d8d2ca4d4 URL: https://github.com/llvm/llvm-project/commit/772e316457ef94759804d9f4da0af70d8d2ca4d4 DIFF: https://github.com/llvm/llvm-project/commit/772e316457ef94759804d9f4da0af70d8d2ca4d4.di

[clang] [FMV] Allow multi versioning without default declaration. (PR #85454)

2024-03-25 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/85454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #70024)

2024-03-25 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From 7adedf54a6c4d509046915777600b6e66b90bb8c Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 13 Oct 2023 14:45:15 +0200 Subject: [PATCH] [clang] Catch missing format attribu

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-03-25 Thread Nathan Gauër via cfe-commits
@@ -1295,11 +1295,13 @@ double4 trunc(double4); /// true, across all active lanes in the current wave. _HLSL_AVAILABILITY(shadermodel, 6.0) _HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_active_count_bits) +__attribute__((convergent)) Keenuts wrote: Right, so in that

[clang] [analyzer] Set and display CSA analysis entry points as notes on debugging (PR #84823)

2024-03-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/84823 >From 94c6be96d92d8a25693ccbbffedf9edabfe79cc5 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Mon, 11 Mar 2024 21:18:30 +0100 Subject: [PATCH 1/2] [analyzer] Set and display CSA analysis entry points as not

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Younan Zhang via cfe-commits
@@ -367,7 +367,13 @@ class Checker { auto Hints = inlayHints(*AST, LineRange); for (const auto &Hint : Hints) { - vlog(" {0} {1} {2}", Hint.kind, Hint.position, Hint.label); + vlog(" {0} {1} [{2}]", Hint.kind, Hint.position, [&] { +return llvm::join

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-25 Thread Wang Pengcheng via cfe-commits
@@ -49,3 +49,62 @@ if ((MINGW OR CYGWIN) AND BUILD_SHARED_LIBS) # despite potential dllexports. target_link_options(clangInterpreter PRIVATE LINKER:--export-all-symbols) endif() + +if(MSVC) + set_target_properties(clangInterpreter PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS 1)

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-25 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: Windows CI is passed now, many thanks to @AaronBallman @vgvassilev! I may land this in a few days if there is no more comment. :-) https://github.com/llvm/llvm-project/pull/83774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Set and display CSA analysis entry points as notes on debugging (PR #84823)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/84823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [analyzer] Set and display CSA analysis entry points as notes on debugging (PR #84823)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/84823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Younan Zhang via cfe-commits
@@ -367,7 +367,13 @@ class Checker { auto Hints = inlayHints(*AST, LineRange); for (const auto &Hint : Hints) { - vlog(" {0} {1} {2}", Hint.kind, Hint.position, Hint.label); + vlog(" {0} {1} [{2}]", Hint.kind, Hint.position, [&] { +return llvm::join

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy ,NagyDonat Message-ID: In-Reply-To: @@ -1435,9 +1440,17 @@ void MallocChecker::checkGMallocN0(const CallEvent &Call, C.addTransition(State); } +static bool isFromStdNamespace(const CallEvent &Call) { + const Decl *FD = Cal

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy ,NagyDonat ,NagyDonat Message-ID: In-Reply-To: https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/85791 >From 3fbc8da42726aa63ad0aef7ba12141125197279b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Dat

[clang] 37785fe - [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (#83985)

2024-03-25 Thread via cfe-commits
Author: Discookie Date: 2024-03-25T10:08:56Z New Revision: 37785fedabd8fa752129ef5bac3462311af91c35 URL: https://github.com/llvm/llvm-project/commit/37785fedabd8fa752129ef5bac3462311af91c35 DIFF: https://github.com/llvm/llvm-project/commit/37785fedabd8fa752129ef5bac3462311af91c35.diff LOG: [cl

[clang] [clang][analyzer] Bring cplusplus.ArrayDelete out of alpha (PR #83985)

2024-03-25 Thread via cfe-commits
https://github.com/Discookie closed https://github.com/llvm/llvm-project/pull/83985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-25 Thread Vassil Vassilev via cfe-commits
@@ -49,3 +49,62 @@ if ((MINGW OR CYGWIN) AND BUILD_SHARED_LIBS) # despite potential dllexports. target_link_options(clangInterpreter PRIVATE LINKER:--export-all-symbols) endif() + +if(MSVC) + set_target_properties(clangInterpreter PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS 1)

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
weliveindetail wrote: Thanks for your note. Looks like the problem is that the ARM target is not registered. It's an uncommon requirement for a unitttest.. Will see how to check that at runtime. If you have an idea, let me know. Thanks https://github.com/llvm/llvm-project/pull/84461 __

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
weliveindetail wrote: I will try this https://github.com/llvm/llvm-project/blob/release/18.x/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp#L482 and push a quick-fix. https://github.com/llvm/llvm-project/pull/84461 ___ cfe-commits mailin

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-03-25 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts updated https://github.com/llvm/llvm-project/pull/80680 From afbe709931942b3970f92884022e250c1e7eb84f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= Date: Fri, 2 Feb 2024 16:38:46 +0100 Subject: [PATCH 1/8] [clang][HLSL][SPRI-V] Add convergence intrins

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-03-25 Thread Nathan Gauër via cfe-commits
Keenuts wrote: Rebases on main (almost, HEAD is slightly broken), and added back the convergence attribute. The backend changes are ready for this intrinsic. https://github.com/llvm/llvm-project/pull/80680 ___ cfe-commits mailing list cfe-commits@list

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Jan Patrick Lehr via cfe-commits
Stefan =?utf-8?q?GrÀnitz?= Message-ID: In-Reply-To: jplehr wrote: Thanks! I am quite unfamiliar with that part of the code base and wonder if the symbol needs to just exist somewhere. The other thing used there (`InitializeNativeTargetAsmPrinter`) is declared in `TargetSelect.h`. So, does it

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-03-25 Thread via cfe-commits
Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= Message-ID: In-Reply-To: github-actions[bot] wrote: :white_check_mark: With the latest revision this PR p

[clang] [[clang::always-destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread via cfe-commits
https://github.com/ycdtosa created https://github.com/llvm/llvm-project/pull/86486 user wants the warning silenced by the attribute so no warning should be issued. >From 016152bc21c2625db77d3e31a7123bcf08114133 Mon Sep 17 00:00:00 2001 From: ycdtosa Date: Mon, 25 Mar 2024 10:28:02 + Subjec

[clang] [[clang::always-destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [[clang::always-destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (ycdtosa) Changes user wants the warning silenced by the attribute so no warning should be issued. --- Full diff: https://github.com/llvm/llvm-project/pull/86486.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaDeclCXX.cpp (+

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-25 Thread Wang Pengcheng via cfe-commits
@@ -49,3 +49,62 @@ if ((MINGW OR CYGWIN) AND BUILD_SHARED_LIBS) # despite potential dllexports. target_link_options(clangInterpreter PRIVATE LINKER:--export-all-symbols) endif() + +if(MSVC) + set_target_properties(clangInterpreter PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS 1)

[clang] [[clang::always-destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread via cfe-commits
ycdtosa wrote: this was lightly discussed in https://github.com/llvm/llvm-project/issues/68686 https://github.com/llvm/llvm-project/pull/86486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/85497 >From 6d61aa1e43bb522412904bdd77c7f1cfc4b42889 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 16 Mar 2024 12:33:58 +0800 Subject: [PATCH 1/5] [clangd] Support go-to-definition on type hints. The protocol

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread Younan Zhang via cfe-commits
@@ -1483,9 +1483,18 @@ llvm::json::Value toJSON(const InlayHintKind &Kind) { llvm_unreachable("Unknown clang.clangd.InlayHintKind"); } +namespace { + +llvm::json::Array toJSON(const std::vector &Labels) { + return llvm::json::Array{ + llvm::map_range(Labels, [](auto &L

[clang-tools-extra] [clangd] Support go-to-definition on type hints. The protocol part (PR #85497)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/85497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] 13078cb - [clang-repl] Skip cross-JIT tests if specified target is not available (#84461)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
Author: Stefan GrÀnitz Date: 2024-03-25T11:50:21+01:00 New Revision: 13078cbc3eeb0ae91c370ce0f604f7165b26e0c8 URL: https://github.com/llvm/llvm-project/commit/13078cbc3eeb0ae91c370ce0f604f7165b26e0c8 DIFF: https://github.com/llvm/llvm-project/commit/13078cbc3eeb0ae91c370ce0f604f7165b26e0c8.diff

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Stefan GrÀnitz via cfe-commits
weliveindetail wrote: We do need the target and not just the symbols. It could be any non-native target, but implementing a selection mechanism isn't worth the effort. We just try ARM and (with my above patch) otherwise skip the test. https://github.com/llvm/llvm-project/pull/84461 ___

[clang] [C++20] [Modules] Introduce -fgen-reduced-bmi (PR #85050)

2024-03-25 Thread Iain Sandoe via cfe-commits
https://github.com/iains commented: I have no issue with the general intention or phasing here; my main concern is that we are introducing [yet] another user-facing modules option that actually we intend will become irrelevant after a few releases. In practice, removing user-facing options is

[clang] [C++20] [Modules] Introduce -fgen-reduced-bmi (PR #85050)

2024-03-25 Thread Iain Sandoe via cfe-commits
@@ -3031,6 +3032,11 @@ defm skip_odr_check_in_gmf : BoolOption<"f", "skip-odr-check-in-gmf", "Perform ODR checks for decls in the global module fragment.">>, Group; +def gen_reduced_bmi : Flag<["-"], "fgen-reduced-bmi">, iains wrote: If this is g

[clang] [C++20] [Modules] Introduce -fgen-reduced-bmi (PR #85050)

2024-03-25 Thread Iain Sandoe via cfe-commits
https://github.com/iains edited https://github.com/llvm/llvm-project/pull/85050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Factor out CreateJITBuilder() and allow specialization in derived classes (PR #84461)

2024-03-25 Thread Jan Patrick Lehr via cfe-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: jplehr wrote: I see. Thanks for the explanation and the fix! Bot is back to green. https://github.com/llvm/llvm-project/pull/84461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread Balazs Benics via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy ,NagyDonat ,NagyDonat Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/85791 ___ cfe-commits mailing list cfe-commit

[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -49,3 +49,62 @@ if ((MINGW OR CYGWIN) AND BUILD_SHARED_LIBS) # despite potential dllexports. target_link_options(clangInterpreter PRIVATE LINKER:--export-all-symbols) endif() + +if(MSVC) + set_target_properties(clangInterpreter PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS 1)

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread via cfe-commits
Sirraide wrote: I’m the wrong person to ping if it’s anything codegen-related; I’ll leave reviewing this to people more familiar w/ that part of Clang. https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

2024-03-25 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks. LGTM apart from one nit. https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

2024-03-25 Thread Younan Zhang via cfe-commits
@@ -5674,6 +5675,11 @@ QualType getApproximateType(const Expr *E) { return getApproximateType(VD->getInit()); } } + if (const auto *UO = llvm::dyn_cast(E)) { +if (UO->getOpcode() == UnaryOperatorKind::UO_Deref) { zyn0217 wrote: nit: We [don

[clang] [clang][CodeComplete] Handle deref operator in getApproximateType (PR #86466)

2024-03-25 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/86466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OpenMP] Migrate GPU Reductions CodeGen from Clang to OMPIRBuilder (PR #80343)

2024-03-25 Thread Akash Banerjee via cfe-commits
TIFitis wrote: @jdoerfert @jsjodin polite ping for review. https://github.com/llvm/llvm-project/pull/80343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Set and display CSA analysis entry points as notes on debugging (PR #84823)

2024-03-25 Thread via cfe-commits
https://github.com/NagyDonat approved this pull request. https://github.com/llvm/llvm-project/pull/84823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e1d4ddb - Reapply "[analyzer] Accept C library functions from the `std` namespace" again (#85791)

2024-03-25 Thread via cfe-commits
Author: NagyDonat Date: 2024-03-25T12:43:51+01:00 New Revision: e1d4ddb0c68f69001d7de43d9c678f4d73c1ecba URL: https://github.com/llvm/llvm-project/commit/e1d4ddb0c68f69001d7de43d9c678f4d73c1ecba DIFF: https://github.com/llvm/llvm-project/commit/e1d4ddb0c68f69001d7de43d9c678f4d73c1ecba.diff LOG

[clang] [llvm] Reapply "[analyzer] Accept C library functions from the `std` namespace" again (PR #85791)

2024-03-25 Thread via cfe-commits
=?utf-8?q?DonĂĄt?= Nagy , =?utf-8?q?DonĂĄt?= Nagy ,NagyDonat ,NagyDonat Message-ID: In-Reply-To: https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/85791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes seem reasonable to me, but there are test failures in `llvm/utils/lit/tests` that could perhaps be related to your changes. I think .natvis files should be CRLF (those are used with Visual Studio for debug visualizers). https://github.com

[clang] [X86_64] fix SSE type error in vaarg. (PR #86377)

2024-03-25 Thread Longsheng Mou via cfe-commits
@@ -21,3 +21,18 @@ empty empty_record_test(int z, ...) { __builtin_va_start(list, z); return __builtin_va_arg(list, empty); } + CoTinker wrote: done https://github.com/llvm/llvm-project/pull/86377 ___ cfe-commit

[clang] Fix printing of templated records. (PR #86339)

2024-03-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/86339 >From ab7d280abf053b67b716e0723e2e70876e639810 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 22 Mar 2024 13:55:44 -0700 Subject: [PATCH 1/2] Fix printing of templated records. --- clang/lib/AST

[clang] Fix printing of templated records. (PR #86339)

2024-03-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/86339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/86493 The latest ACLE allows it and further clarifies the following in regards to the combination of the two attributes: "If the `default` matches with another explicitly provided version in the same translation unit

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Alexandros Lamprineas (labrinea) Changes The latest ACLE allows it and further clarifies the following in regards to the combination of the two attributes: "If the `default` matches with another explicitly provided version in the

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 13078cbc3eeb0ae91c370ce0f604f7165b26e0c8 65bfc47298131d6fb5dfeed722dc3f2d9d85eadd --

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/86493 >From dfef9d04c0a65423a051ac00044b39f8911aa731 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Fri, 22 Mar 2024 17:21:13 + Subject: [PATCH] [FMV] Allow mixing target_version with target_clones. T

[clang] [clang][dataflow] Bail out if input is Objective-C++. (PR #86479)

2024-03-25 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/86479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Hopefully @rjmccall or @efriedma-quic can take a look at the codegen bits. I did have some questions about other kinds of flow control statements we might want to cover. https://github.com/llvm/llvm-project/pull/85398 _

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

  1   2   3   4   5   >