[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-02-29 Thread Sander de Smalen via cfe-commits
@@ -7513,6 +7516,36 @@ void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto, } } +auto *CallerFD = dyn_cast(CurContext); +bool IsCalleeStreaming = +(ExtInfo.AArch64SMEAttributes & FunctionType::SME_PStateSMEnabledMask); +bool IsC

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-02-29 Thread Sander de Smalen via cfe-commits
@@ -3717,6 +3717,16 @@ def err_sme_definition_using_za_in_non_sme_target : Error< "function using ZA state requires 'sme'">; def err_sme_definition_using_zt0_in_non_sme2_target : Error< "function using ZT0 state requires 'sme2'">; +def warn_sme_streaming_pass_return_vl_to_

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-02-29 Thread Sander de Smalen via cfe-commits
@@ -12230,12 +12230,22 @@ bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD, } // Check if the function definition uses any AArch64 SME features without - // having the '+sme' feature enabled. + // having the '+sme' feature enabled and warn user if sme l

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-02-29 Thread Sander de Smalen via cfe-commits
@@ -7513,6 +7516,36 @@ void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto, } } +auto *CallerFD = dyn_cast(CurContext); +bool IsCalleeStreaming = +(ExtInfo.AArch64SMEAttributes & FunctionType::SME_PStateSMEnabledMask); +bool IsC

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-02-29 Thread Sander de Smalen via cfe-commits
@@ -3717,6 +3717,16 @@ def err_sme_definition_using_za_in_non_sme_target : Error< "function using ZA state requires 'sme'">; def err_sme_definition_using_zt0_in_non_sme2_target : Error< "function using ZT0 state requires 'sme2'">; +def warn_sme_streaming_pass_return_vl_to_

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread via cfe-commits
https://github.com/overmighty updated https://github.com/llvm/llvm-project/pull/83431 >From 580ee1d6f9807e02762a4d5e25fc9306aab9ddde Mon Sep 17 00:00:00 2001 From: OverMighty Date: Thu, 29 Feb 2024 14:23:40 + Subject: [PATCH] [clang] Implement __builtin_{clzg,ctzg} Fixes #83075, fixes #830

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread via cfe-commits
https://github.com/overmighty edited https://github.com/llvm/llvm-project/pull/83431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Concepts] Add Decls from the outer scope of the current lambda for conversion function constraints (PR #83420)

2024-02-29 Thread Younan Zhang via cfe-commits
@@ -7976,7 +7976,8 @@ void Sema::AddConversionCandidate( if (Conversion->getTrailingRequiresClause()) { ConstraintSatisfaction Satisfaction; -if (CheckFunctionConstraints(Conversion, Satisfaction) || +if (CheckFunctionConstraints(Conversion, Satisfaction, /*Usage

[clang] [clang] Implement __builtin_{clzg,ctzg} (PR #83431)

2024-02-29 Thread via cfe-commits
@@ -662,6 +662,12 @@ def Clz : Builtin, BitShort_Int_Long_LongLongTemplate { // FIXME: Add int clzimax(uintmax_t) overmighty wrote: Should this FIXME and the `ctzimax(uintmax_t)` one below be removed? https://github.com/llvm/llvm-project/pull/83431 __

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-29 Thread Xiang Li via cfe-commits
https://github.com/python3kgae updated https://github.com/llvm/llvm-project/pull/83077 >From 56240f07c39deb4c48bf7370dc72b3c67299eee1 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Sun, 25 Feb 2024 20:08:09 -0500 Subject: [PATCH] start of lerp intrinsic --- clang/include/clang/Basic/Builti

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-02-29 Thread via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/83432 The class `CallDescription` is used to define patterns that are used for matching `CallEvent`s. For example, a `CallEvent{{"std", "find_if"}, 3}` matches a call to `std::find_if` with 3 arguments. However, th

[clang] e60ebbd - [HLSL] implementation of lerp intrinsic (#83077)

2024-02-29 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-02-29T07:01:36-08:00 New Revision: e60ebbd0001f2e66cb9f76874ddd69290e2086c1 URL: https://github.com/llvm/llvm-project/commit/e60ebbd0001f2e66cb9f76874ddd69290e2086c1 DIFF: https://github.com/llvm/llvm-project/commit/e60ebbd0001f2e66cb9f76874ddd69290e2086c1.diff

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-29 Thread Xiang Li via cfe-commits
https://github.com/python3kgae closed https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: None (NagyDonat) Changes The class `CallDescription` is used to define patterns that are used for matching `CallEvent`s. For example, a `CallEvent{{"std", "find_if"}, 3}` matches a call to `std

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-02-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6f7d824b804b272335d55f5b899295db833f3829 7a72174f9df2211febf789941ed0adb75ebacc89 --

[clang] [Clang] [Sema] Handle `this` in `__restrict`-qualified member functions properly (PR #83187)

2024-02-29 Thread via cfe-commits
Sirraide wrote: > > however, GCC accepts this; should we do so as well? > > If so, should that be a separate pr, perhaps? @AaronBallman If you think it’s related enough I can look into this as well for this pr; otherwise, I’m gonna go ahead and merge this one and then probably look into that

[clang] [Concepts] Add Decls from the outer scope of the current lambda for conversion function constraints (PR #83420)

2024-02-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/83420 >From 19d97fcf8867554f06973ea6ccb36b47d286ec30 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 29 Feb 2024 23:14:46 +0800 Subject: [PATCH] Limit the scope to lambda conversion function only --- clang/doc

[clang] [Concepts] Add Decls from the outer scope of the current lambda for conversion function constraints (PR #83420)

2024-02-29 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @erichkeane : I've updated the patch to limit the scope to lambda-only, which is now more appropriate to me. PTAL, thanks! https://github.com/llvm/llvm-project/pull/83420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread via cfe-commits
@@ -16710,7 +16705,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { verifyFormat("typedef void (*cb)(int);", SpaceFuncDef); verifyFormat("T A::operator()();", SpaceFuncDef); verifyFormat("X A::operator++(T);", SpaceFuncDef); - // verifyFormat("T A::operator() ()

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

2024-02-29 Thread Balázs Kéri via cfe-commits
@@ -218,87 +218,6 @@ inline void assertStreamStateOpened(const StreamState *SS) { assert(SS->isOpened() && "Stream is expected to be opened"); } -struct StreamOperationEvaluator { balazske wrote: There should be something that is used from `StreamChecker`

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-02-29 Thread via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/83432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread via cfe-commits
https://github.com/rayroudc edited https://github.com/llvm/llvm-project/pull/83380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-02-29 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/NagyDonat updated https://github.com/llvm/llvm-project/pull/83432 >From 7a72174f9df2211febf789941ed0adb75ebacc89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Thu, 22 Feb 2024 18:09:15 +0100 Subject: [PAT

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread via cfe-commits
@@ -16671,9 +16667,8 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { SpaceFuncDecl); verifyFormat("int f () throw(Deprecated);", SpaceFuncDecl); verifyFormat("typedef void (*cb)(int);", SpaceFuncDecl); - // FIXME these tests regressed behaviour. - //

[clang] [Concepts] Add Decls from the outer scope of the current lambda for conversion function constraints (PR #83420)

2024-02-29 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I think this looks good, but I want @cor3ntin to do the final approval, he touched it last :) https://github.com/llvm/llvm-project/pull/83420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-29 Thread zhijian lin via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/82809 >From cef79b36bcb3f4b7452d01aafdf111ff0e50605d Mon Sep 17 00:00:00 2001 From: zhijian Date: Fri, 23 Feb 2024 13:23:18 -0500 Subject: [PATCH 1/8] Implement a subset of builtin_cpu_supports() features --- clang

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-02-29 Thread via cfe-commits
https://github.com/rayroudc edited https://github.com/llvm/llvm-project/pull/83380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Aaron Ballman via cfe-commits
@@ -173,6 +173,10 @@ Bug Fixes in This Version for logical operators in C23. Fixes (`#64356 `_). +- Clang now doesn't produce false-positive warning `-Wunused-variable` + for variables created through copy initialization

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I think we should handle pre-C++17 as well, because the constructors *are* called there: https://godbolt.org/z/YWjb8P67c (the ASTs are different but the runtime effects are not). https://github.com/llvm/llvm-project/pull/81127

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83315 >From 2ec582be1c361c212ea846c8433a9cebfeb7b4ba Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 29 Feb 2024 10:23:31 -0500 Subject: [PATCH 1/3] address merge conflicts --- clang/include/clang/Basic/Builti

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

2024-02-29 Thread Balázs Kéri via cfe-commits
@@ -313,6 +232,9 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Handle `this` in `__restrict`-qualified member functions properly (PR #83187)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! I think the other work should be done in a follow-up patch as it is slightly different than this fix. https://github.com/llvm/llvm-project/pull/83187 ___ cfe-commits mailing list cfe-co

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-29 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @python3kgae I wanted to hold off on merging this one because I was investigating why [56240f0](https://github.com/llvm/llvm-project/commit/56240f07c39deb4c48bf7370dc72b3c67299eee1) wiped out my changes on [d4384c5](https://github.com/llvm/llvm-project/commit/d4384c5ac52596e

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

2024-02-29 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/83288 From f5aeb6e97e73d317d55189c656c31a84757f9636 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 28 Feb 2024 17:51:29 +0100 Subject: [PATCH 1/2] [clang][analyzer] Add StreamChecker not

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83315 >From 2ec582be1c361c212ea846c8433a9cebfeb7b4ba Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 29 Feb 2024 10:23:31 -0500 Subject: [PATCH 1/4] address merge conflicts --- clang/include/clang/Basic/Builti

[clang] [clang][analyzer] Change default value of checker option in unix.StdCLibraryFunctions. (PR #80457)

2024-02-29 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/80457 From 1f65abda712efce624c01ec99675c8261a8e6cea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 31 Jan 2024 17:40:21 +0100 Subject: [PATCH 1/2] {clang][analyzer] Change default value

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The failure found by CI looks to be related: ``` :422:1: note: possible intended match here VarDecl:{ResultType struct struct X}{TypedText f1} (50) (deprecated) ``` (note the `struct struct`). https://github.com/llvm/llvm-project/pull/67592

[clang] c4c35d9 - [Clang] [Sema] Handle `this` in `__restrict`-qualified member functions properly (#83187)

2024-02-29 Thread via cfe-commits
Author: Sirraide Date: 2024-02-29T17:43:01+01:00 New Revision: c4c35d9522d19a0a511ee2cc011a21661e69f3c0 URL: https://github.com/llvm/llvm-project/commit/c4c35d9522d19a0a511ee2cc011a21661e69f3c0 DIFF: https://github.com/llvm/llvm-project/commit/c4c35d9522d19a0a511ee2cc011a21661e69f3c0.diff LOG:

[clang] [Clang] [Sema] Handle `this` in `__restrict`-qualified member functions properly (PR #83187)

2024-02-29 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/83187 >From e9df22166fd5768e11273446cb9e52953e55cd5d Mon Sep 17 00:00:00 2001 From: Sirraide Date: Tue, 27 Feb 2024 22:07:23 +0100 Subject: [PATCH 1/4] [Clang] [Sema] Handle __restrict-qualified member functions prop

[clang] [Clang] [Sema] Handle `this` in `__restrict`-qualified member functions properly (PR #83187)

2024-02-29 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/83187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-02-29 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/83065 >From 9b0ebc71341dbda73714c6fbd0da4ec7d338f4b7 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 27 Feb 2024 14:40:42 +0100 Subject: [PATCH 1/2] [Clang] Fix __has_cpp_attribute and C++11 attributes wit

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-02-29 Thread Nikolas Klauser via cfe-commits
@@ -1,7 +1,7 @@ -// RUN: %clang_cc1 -std=gnu++17 -fsyntax-only -fms-compatibility -verify %s - -void f() { - // GNU-style attributes are prohibited in this position. +// RUN: %clang_cc1 -std=gnu++17 -fsyntax-only -fms-compatibility -verify %s philnik777 wrote: I

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-02-29 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/83065 >From 84443dfd39a4a1c567a0e301a3d9892955b9a2fe Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 27 Feb 2024 14:40:42 +0100 Subject: [PATCH] [Clang] Fix __has_cpp_attribute and C++11 attributes with a

[clang] [llvm] Computing, storing, and restoring conservative call graphs with LLVM (PR #80104)

2024-02-29 Thread via cfe-commits
Prabhuk wrote: Thanks for the comments. I am working on breaking this into smaller PRs. I'll send them out as soon as possible. https://github.com/llvm/llvm-project/pull/80104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [llvm] [HLSL][SPIR-V] Add SV_DispatchThreadID semantic support (PR #82536)

2024-02-29 Thread Chris B via cfe-commits
@@ -342,8 +343,19 @@ llvm::Value *CGHLSLRuntime::emitInputSemantic(IRBuilder<> &B, return B.CreateCall(FunctionCallee(DxGroupIndex)); } if (D.hasAttr()) { -llvm::Function *DxThreadID = CGM.getIntrinsic(Intrinsic::dx_thread_id); -return buildVectorInput(B, DxThr

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

2024-02-29 Thread via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -313,6 +232,9 @@ class StreamChecker : public Checkerhttps://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang][analyzer] Add StreamChecker note tags for "indeterminate stream position". (PR #83288)

2024-02-29 Thread via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/NagyDonat approved this pull request. LGTM, thanks for the update! https://github.com/llvm/llvm-project/pull/83288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 2d61979 - [OpenACC] Add dependent test for break/continue compute construct diag

2024-02-29 Thread via cfe-commits
Author: erichkeane Date: 2024-02-29T08:57:42-08:00 New Revision: 2d61979137cfea8f016e618dd17f5be8e7d865bf URL: https://github.com/llvm/llvm-project/commit/2d61979137cfea8f016e618dd17f5be8e7d865bf DIFF: https://github.com/llvm/llvm-project/commit/2d61979137cfea8f016e618dd17f5be8e7d865bf.diff LO

[clang] Don't do casting of atomic FP loads/stores in FE. (PR #83446)

2024-02-29 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/83446 The casting of FP atomic loads and stores are always done by the front-end, even though the AtomicExpandPass will do it if the target requests it (which is the default). This patch removes this casting in the

[clang] Don't do casting of atomic FP loads/stores in FE. (PR #83446)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-systemz Author: Jonas Paulsson (JonPsson1) Changes The casting of FP atomic loads and stores are always done by the front-end, even though the AtomicExpandPass will do it if the target requests it (which is the defaul

[clang] [Headers][X86] Add rounding and exception notes to conversions (PR #83447)

2024-02-29 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/83447 Consistently describe rounding/truncating on convert intrinsics. Add notes where an out-of-range result can raise an exception. >From 64cdd358d0bf359383a5dd3d1da236a219644c9e Mon Sep 17 00:00:00 2001 From: Paul R

[clang] [Headers][X86] Add rounding and exception notes to conversions (PR #83447)

2024-02-29 Thread Paul T Robinson via cfe-commits
pogo59 wrote: FYI @cflores https://github.com/llvm/llvm-project/pull/83447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add rounding and exception notes to conversions (PR #83447)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul T Robinson (pogo59) Changes Consistently describe rounding/truncating on convert intrinsics. Add notes where an out-of-range result can raise an exception. --- Patch is 23.00 KiB, truncated to 20.00 KiB below, full version: https:/

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/83065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-02-29 Thread Aaron Ballman via cfe-commits
@@ -1,7 +1,7 @@ -// RUN: %clang_cc1 -std=gnu++17 -fsyntax-only -fms-compatibility -verify %s - -void f() { - // GNU-style attributes are prohibited in this position. +// RUN: %clang_cc1 -std=gnu++17 -fsyntax-only -fms-compatibility -verify %s AaronBallman wrote:

[clang] 0869ffa - [OpenMP] Clang Codegen Interop : Accept multiple use & destroy clauses (#83398)

2024-02-29 Thread via cfe-commits
Author: SunilKuravinakop Date: 2024-02-29T11:11:29-06:00 New Revision: 0869ffa6bd6e9562b35bc93e48207d11261d67df URL: https://github.com/llvm/llvm-project/commit/0869ffa6bd6e9562b35bc93e48207d11261d67df DIFF: https://github.com/llvm/llvm-project/commit/0869ffa6bd6e9562b35bc93e48207d11261d67df.di

[clang] [OpenMP] Clang Codegen Interop : Accept multiple use & destroy clauses (PR #83398)

2024-02-29 Thread via cfe-commits
https://github.com/chichunchen closed https://github.com/llvm/llvm-project/pull/83398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83315 >From 2ec582be1c361c212ea846c8433a9cebfeb7b4ba Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 29 Feb 2024 10:23:31 -0500 Subject: [PATCH 1/5] address merge conflicts --- clang/include/clang/Basic/Builti

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-29 Thread S. Bharadwaj Yadavalli via cfe-commits
@@ -5246,6 +5246,23 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { return true; } +bool CheckAllArgsAreFloatRepresentation(Sema *S, CallExpr *TheCall) { bharadwajy wrote: Consider changing the function name to either `CheckAllArgsAreFloat

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-29 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/83340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-29 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/83340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83315 >From 2ec582be1c361c212ea846c8433a9cebfeb7b4ba Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Thu, 29 Feb 2024 10:23:31 -0500 Subject: [PATCH 1/6] address merge conflicts --- clang/include/clang/Basic/Builti

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Vinayak Dev via cfe-commits
vinayakdsci wrote: @AaronBallman C++17 and later mark all of these constructor calls as _non_-elidable after ignoring the implicit casts, while C++14 and before mark the constructor that is assigned by `=` as elidable, and hence the warning. Should the constructor also be marked as elidable in

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-29 Thread Chris B via cfe-commits
@@ -10266,6 +10266,11 @@ def err_block_on_vm : Error< def err_sizeless_nonlocal : Error< "non-local variable with sizeless type %0">; +def err_vec_builtin_non_vector_all : Error< + "all arguments to %0 must be vectors">; +def err_vec_builtin_incompatible_vector_all : Error<

[clang] ANDROID: AArch64: Change default max-page-size from 4k to 16k (PR #70251)

2024-02-29 Thread via cfe-commits
https://github.com/pirama-arumuga-nainar closed https://github.com/llvm/llvm-project/pull/70251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 856ce49 - ANDROID: AArch64: Change default max-page-size from 4k to 16k (#70251)

2024-02-29 Thread via cfe-commits
Author: Kalesh Singh Date: 2024-02-29T10:06:25-08:00 New Revision: 856ce495e52b8ea8855d7f34d84346c82b1fddc2 URL: https://github.com/llvm/llvm-project/commit/856ce495e52b8ea8855d7f34d84346c82b1fddc2 DIFF: https://github.com/llvm/llvm-project/commit/856ce495e52b8ea8855d7f34d84346c82b1fddc2.diff

[clang] [clang][Sema] Warn on self move for inlined static cast (PR #76646)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. LGTM, any objections @tbaederr https://github.com/llvm/llvm-project/pull/76646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Warn on self move for inlined static cast (PR #76646)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/76646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Warn on self move for inlined static cast (PR #76646)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
@@ -35,11 +41,14 @@ class field_test { int x; field_test(field_test&& other) { x = std::move(x); // expected-warning{{explicitly moving}} +x = static_cast(x); // expected-warning{{explicitly moving}} shafik wrote: Can you add some tests where we

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-02-29 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/83460 Like the last few patches, branching in/out of a compute construct is not valid. This patch implements checking to ensure that a 'case' or 'default' statement cannot jump into a Compute Construct (in the sty

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes Like the last few patches, branching in/out of a compute construct is not valid. This patch implements checking to ensure that a 'case' or 'default' statement cannot jump into a Compute Construct (in the

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-02-29 Thread Alexey Bataev via cfe-commits
@@ -534,6 +534,25 @@ class Scope { return false; } + /// Determine if this scope (or its parents) are a compute construct inside of + /// the nearest 'switch' scope. This is needed to check whether we are inside + /// of a 'duffs' device, which is an illegal branch

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-02-29 Thread Erich Keane via cfe-commits
@@ -534,6 +534,25 @@ class Scope { return false; } + /// Determine if this scope (or its parents) are a compute construct inside of + /// the nearest 'switch' scope. This is needed to check whether we are inside + /// of a 'duffs' device, which is an illegal branch

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-02-29 Thread Alexey Bataev via cfe-commits
@@ -534,6 +534,25 @@ class Scope { return false; } + /// Determine if this scope (or its parents) are a compute construct inside of + /// the nearest 'switch' scope. This is needed to check whether we are inside + /// of a 'duffs' device, which is an illegal branch

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-02-29 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/83460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 489eadd - [HLSL] Implementation of the frac intrinsic (#83315)

2024-02-29 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-02-29T10:40:38-08:00 New Revision: 489eadd142e858dc28e375320da774eba53d21bb URL: https://github.com/llvm/llvm-project/commit/489eadd142e858dc28e375320da774eba53d21bb DIFF: https://github.com/llvm/llvm-project/commit/489eadd142e858dc28e375320da774eba53d21bb.diff

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-29 Thread Xiang Li via cfe-commits
https://github.com/python3kgae closed https://github.com/llvm/llvm-project/pull/83315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c9b1f1c - [HLSL] standardize builtin unit tests (#83340)

2024-02-29 Thread via cfe-commits
Author: Farzon Lotfi Date: 2024-02-29T10:41:40-08:00 New Revision: c9b1f1c337ce7c12664b670c0ba1022e5d5b8001 URL: https://github.com/llvm/llvm-project/commit/c9b1f1c337ce7c12664b670c0ba1022e5d5b8001 DIFF: https://github.com/llvm/llvm-project/commit/c9b1f1c337ce7c12664b670c0ba1022e5d5b8001.diff

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-29 Thread Xiang Li via cfe-commits
https://github.com/python3kgae closed https://github.com/llvm/llvm-project/pull/83340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2024-02-29 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > struct struct X Interesting! The LIT test is passing on a debug build on Windows and generating the right output: `VarDecl:{ResultType struct X}{TypedText f1} (50) (deprecated)` I will try a release build. https://github.com/llvm/llvm-project/pull/67592 __

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -1369,13 +1369,50 @@ class TargetInfo : public TransferrableTargetInfo, } struct BranchProtectionInfo { -LangOptions::SignReturnAddressScopeKind SignReturnAddr = -LangOptions::SignReturnAddressScopeKind::None; -LangOptions::SignReturnAddressKeyKind SignK

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -1369,13 +1369,50 @@ class TargetInfo : public TransferrableTargetInfo, } struct BranchProtectionInfo { -LangOptions::SignReturnAddressScopeKind SignReturnAddr = -LangOptions::SignReturnAddressScopeKind::None; -LangOptions::SignReturnAddressKeyKind SignK

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -109,38 +109,29 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo { if (!FD) return; -const auto *TA = FD->getAttr(); -if (TA == nullptr) - return; - -ParsedTargetAttr Attr = -CGM.getTarget().parseTargetAttr(TA->getFeaturesStr(

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -173,6 +167,13 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { diag::warn_target_unsupported_branch_protection_attribute) << Attr.CPU; } +} else if (CGM.getTarget().isBranchProtectionSupportedArch( + CGM.getT

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-02-29 Thread Nick Desaulniers via cfe-commits
@@ -173,6 +167,13 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { diag::warn_target_unsupported_branch_protection_attribute) << Attr.CPU; } +} else if (CGM.getTarget().isBranchProtectionSupportedArch( + CGM.getT

[clang] [FMV] Use lexicographic order of feature names when mangling. (PR #83464)

2024-02-29 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/83464 This decouples feature priorities from name mangling. Doing so will prevent ABI breakages in case we change the feature priorities. Formalized in ACLE here: https://github.com/ARM-software/acle/pull/303. >From

[clang] [FMV] Use lexicographic order of feature names when mangling. (PR #83464)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes This decouples feature priorities from name mangling. Doing so will prevent ABI breakages in case we change the feature priorities. Formalized in ACLE here: https://github.com/ARM-software/acle/pul

[clang] [llvm] [HLSL][SPIR-V] Add SV_DispatchThreadID semantic support (PR #82536)

2024-02-29 Thread Michal Paszkowski via cfe-commits
https://github.com/michalpaszkowski approved this pull request. https://github.com/llvm/llvm-project/pull/82536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Implement N3018: The constexpr specifier for object definitions (PR #73099)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I've done another pass over the changes and in general, I think we're really close to done. I spotted these two issues: ``` #define NAN __builtin_nan("1") #define FLT_SNAN __builtin_nansf("1") constexpr float f2 = (long double)NAN; // 6.7.2p21 EXAMPLE

[clang] [clang] Add `clang::behaves_like_std(...)` attribute (PR #76596)

2024-02-29 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Adding @AaronBallman and @erichkeane for a wider audience https://github.com/llvm/llvm-project/pull/76596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman C++17 and later mark all of these constructor calls as > _non_-elidable after ignoring the implicit casts, while C++14 and before mark > the constructor that is assigned by `=` as elidable, and hence the warning. > Should the constructor also be marked as el

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Aside from some grammatical changes to the release note, the changes LGTM! Do you need someone to land this on your behalf once those changes are made? https://github.com/llvm/llvm-project/pull/81127 ___

[clang-tools-extra] 525fe44 - [clang-tidy] Add new check `modernize-use-designated-initializers` (#80541)

2024-02-29 Thread via cfe-commits
Author: Danny Mösch Date: 2024-02-29T20:48:05+01:00 New Revision: 525fe4492bbecf357d3580d879f2092bf99c12a2 URL: https://github.com/llvm/llvm-project/commit/525fe4492bbecf357d3580d879f2092bf99c12a2 DIFF: https://github.com/llvm/llvm-project/commit/525fe4492bbecf357d3580d879f2092bf99c12a2.diff L

[clang] [clang-tools-extra] [clang-tidy] Add new check `modernize-use-designated-initializers` (PR #80541)

2024-02-29 Thread Danny Mösch via cfe-commits
https://github.com/SimplyDanny closed https://github.com/llvm/llvm-project/pull/80541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

2024-02-29 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/83470 Removing `TrapBB->getParent()->size()` added with #65972. Counter as-is is not very unique after inlining https://godbolt.org/z/4KfEKq7zb (see m()). >From e44df1c386d96472614939658e496cf2a9643e05 Mon Sep 17 0

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

2024-02-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Vitaly Buka (vitalybuka) Changes Removing `TrapBB->getParent()->size()` added with #65972. Counter as-is is not very unique after inlining https://godbolt.org/z/4KfEKq7zb (see m()). --- Full diff: https

[clang] [llvm] Modify BoundsSan to improve debuggability (PR #65972)

2024-02-29 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > So long as the debuggability is preserved so that it is possible to attribute > crashes to specific lines of code, I am fine! Do you have an alternate > solution? In IR these traps are not de-duplicated with -ubsan-unique-traps It happens later, in LLVM backend, it needs t

[clang] [UBSAN] Preserve ubsan code with ubsan-unique-traps (PR #83470)

2024-02-29 Thread Oskar Wirga via cfe-commits
oskarwirga wrote: > It happens later, in LLVM backend, it needs to be fixed. >From https://github.com/llvm/llvm-project/pull/65972#issuecomment-1971855638 Is this something you have planned to fix? If not would replacing the .size() counter with perhaps a seeded random uint8 be acceptable? M

<    1   2   3   4   >