[clang] [Clang] CGCoroutine: Skip moving parameters if the allocation decision is false (PR #81195)

2024-02-10 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: yes if I remember correctly. I am away from the computer so I can't find the wording. But I don't think this is related to how the frame gets allocated. https://github.com/llvm/llvm-project/pull/81195 ___ cfe-commits mailing list

[clang] [clang-format] Add BreakAfterReturnType option to deprecate AlwaysBreakAfterReturnType. (PR #80827)

2024-02-10 Thread via cfe-commits
https://github.com/rmarker updated https://github.com/llvm/llvm-project/pull/80827 >From 3c3e167711dccfcc0a56c5b465b20c17854451a4 Mon Sep 17 00:00:00 2001 From: rmarker Date: Tue, 6 Feb 2024 21:53:20 +1030 Subject: [PATCH] [clang-format] Rename option AlwaysBreakAfterReturnType. --- clang/doc

[clang] [clang-format] Rename option AlwaysBreakAfterReturnType. (PR #80827)

2024-02-10 Thread via cfe-commits
https://github.com/rmarker edited https://github.com/llvm/llvm-project/pull/80827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Rename option AlwaysBreakAfterReturnType. (PR #80827)

2024-02-10 Thread via cfe-commits
https://github.com/rmarker edited https://github.com/llvm/llvm-project/pull/80827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Rename option AlwaysBreakAfterReturnType. (PR #80827)

2024-02-10 Thread via cfe-commits
rmarker wrote: Right. I've updated the PR, following the pattern of #81093. https://github.com/llvm/llvm-project/pull/80827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Rename option AlwaysBreakAfterReturnType. (PR #80827)

2024-02-10 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/80827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix crash when inheriting from a cv-qualified type (PR #70594)

2024-02-10 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 edited https://github.com/llvm/llvm-project/pull/70594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-02-10 Thread via cfe-commits
https://github.com/koachan updated https://github.com/llvm/llvm-project/pull/74927 >From fd0bae41e2c3ed791a6a73affc9e1709e21ff880 Mon Sep 17 00:00:00 2001 From: Koakuma Date: Wed, 29 Nov 2023 08:08:29 +0700 Subject: [PATCH 1/7] [SPARC] Support reserving arbitrary general purpose registers Thi

[clang] [llvm] [LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/81331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
@@ -312,6 +312,12 @@ void IntrinsicLowering::LowerIntrinsicCall(CallInst *CI) { CI->replaceAllUsesWith(ConstantInt::get(Type::getInt64Ty(Context), 0)); break; } + case Intrinsic::readfixedtimer: { +errs() << "WARNING: this target does not support the llvm.readfix

[clang] [llvm] [LLVM] Add `__builtin_readfixedtimer` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81331 >From 164d9775046d273fa45e9934cea1db07fdd2ca79 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 9 Feb 2024 16:13:42 -0600 Subject: [PATCH] [WIP][LLVM] Add `__builtin_readsteadycounter` intrinsic and buiilt

[clang] [llvm] [LLVM] Add `__builtin_readsteadycounter` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/81331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add `__builtin_readsteadycounter` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Added clang test and renamed to `readsteadycounter` as I think it's more descriptive and matches the existing `readcyclecounter` better. https://github.com/llvm/llvm-project/pull/81331 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] [LLVM] Add `__builtin_readsteadycounter` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81331 >From 109939223e7944472363134d72a223524e1e3f0a Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 9 Feb 2024 16:13:42 -0600 Subject: [PATCH] [WIP][LLVM] Add `__builtin_readsteadycounter` intrinsic and buiilt

[clang] [llvm] [MC/DC] Refactor: Let MCDCConditionID int16_t with zero-origin (PR #81257)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81257 >From b2e8b3eaa067844a5fa5643aca17dbb0f237182e Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Sat, 10 Feb 2024 00:08:36 +0900 Subject: [PATCH 1/2] [MC/DC] Refactor: Let MCDCConditionID int16_t with zero-or

[clang] [llvm] [MC/DC] Refactor: Let MCDCConditionID int16_t with zero-origin (PR #81257)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni edited https://github.com/llvm/llvm-project/pull/81257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 59037c0 - [RISCV] Add Zicfiss support to the shadow call stack implementation. (#68075)

2024-02-10 Thread via cfe-commits
Author: Yeting Kuo Date: 2024-02-10T22:18:46+08:00 New Revision: 59037c0975de51ae29a5f9bd4260131ba3b7c22a URL: https://github.com/llvm/llvm-project/commit/59037c0975de51ae29a5f9bd4260131ba3b7c22a DIFF: https://github.com/llvm/llvm-project/commit/59037c0975de51ae29a5f9bd4260131ba3b7c22a.diff LO

[clang] [llvm] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-02-10 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk closed https://github.com/llvm/llvm-project/pull/68075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM] Add `__builtin_readsteadycounter` intrinsic and buiiltin for realtime clocks (PR #81331)

2024-02-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/81331 >From 30341079e795c2668588b791f2c97b44006e7a04 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 9 Feb 2024 16:13:42 -0600 Subject: [PATCH] [WIP][LLVM] Add `__builtin_readsteadycounter` intrinsic and buiilt

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
@@ -183,7 +185,12 @@ void foo(int size) { NonTriviallyDestructible array[2]; // no warning NonTriviallyDestructible nestedArray[2][2]; // no warning + // Copy initialzation gives warning before C++17 +#if __cplusplus <= 201402L Foo fooScalar = 1; // expected-warning {

[clang] [clang-format] Support of TableGen value annotations. (PR #80299)

2024-02-10 Thread Hirofumi Nakamura via cfe-commits
https://github.com/hnakamura5 updated https://github.com/llvm/llvm-project/pull/80299 >From 36f83a124ea8ad27cfefa1d12ae5aa781f8e6e3e Mon Sep 17 00:00:00 2001 From: hnakamura5 Date: Thu, 1 Feb 2024 23:07:42 +0900 Subject: [PATCH 1/3] [clang-format] Support of TableGen value annotations. --- cl

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
@@ -183,7 +185,12 @@ void foo(int size) { NonTriviallyDestructible array[2]; // no warning NonTriviallyDestructible nestedArray[2][2]; // no warning + // Copy initialzation gives warning before C++17 +#if __cplusplus <= 201402L Foo fooScalar = 1; // expected-warning {

[clang] [clang-format] Support of TableGen value annotations. (PR #80299)

2024-02-10 Thread Hirofumi Nakamura via cfe-commits
@@ -833,13 +885,207 @@ class AnnotatingParser { Left->setType(TT_ArrayInitializerLSquare); } FormatToken *Tok = CurrentToken; + if (Style.isTableGen()) { +if (CurrentToken->isOneOf(tok::comma, tok::minus, tok::ellipsis)) { + // '-' and

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81221 >From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Fri, 9 Feb 2024 07:56:51 +0900 Subject: [PATCH 1/3] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
@@ -217,6 +217,9 @@ class CounterExpressionBuilder { using LineColPair = std::pair; +using MCDCConditionID = unsigned int; +using MCDCConditionIDs = std::array; chapuni wrote: `first` and `second` didn't make sense to me. https://github.com/llvm/llvm-projec

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71709 >From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 8 Nov 2023 20:30:37 +0300 Subject: [PATCH 1/3] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` This

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
chapuni wrote: @evodius96 As an experiment, I've made subscripts as `bool`. It works semantically however I wonder they wouldn't be intuitive to us. I can rewind it. https://github.com/llvm/llvm-project/pull/81221 ___ cfe-commits mailing list cfe-com

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-10 Thread Vinayak Dev via cfe-commits
https://github.com/vinayakdsci updated https://github.com/llvm/llvm-project/pull/81127 >From 335d2277881af6737ba899417121c321ce4d098f Mon Sep 17 00:00:00 2001 From: Vinayak Dev Date: Thu, 8 Feb 2024 17:29:44 +0530 Subject: [PATCH] [Clang][Sema]: Allow copy constructor side effects --- clang/d

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-10 Thread Vinayak Dev via cfe-commits
vinayakdsci wrote: I hope this does it! https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC/DC] Refactor: Make `MCDCParams` as `std::variant` (PR #81227)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
@@ -250,18 +251,27 @@ struct CounterMappingRegion { }; using MCDCConditionID = unsigned int; - struct MCDCParameters { + struct MCDCDecisionParameters { /// Byte Index of Bitmap Coverage Object for a Decision Region. -unsigned BitmapIdx = 0; +unsigned Bitmap

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

2024-02-10 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov updated https://github.com/llvm/llvm-project/pull/68550 >From 96dd0121b095f92cc66fcfc3ef08a19d0b2d6bec Mon Sep 17 00:00:00 2001 From: Sergei Barannikov Date: Mon, 9 Oct 2023 01:38:33 +0300 Subject: [PATCH 1/2] [clang] Differentiate between identifier and string

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 created https://github.com/llvm/llvm-project/pull/81364 Fixes #68933. >From aa48713c9bf23c24bbc0c22dd67f332ca970d2b8 Mon Sep 17 00:00:00 2001 From: Vadim Dudkin Date: Sat, 10 Feb 2024 02:29:48 +0300 Subject: [PATCH] Add -Wmissing-designated-field-initializers, dec

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. LGTM Make sure @cor3ntin is happy, too. https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-02-10 Thread Alexandros Lamprineas via cfe-commits
@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma labrinea wrote: I raised this with the GCC team, I don'

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 updated https://github.com/llvm/llvm-project/pull/81364 >From b7e3ffb25e1a50ac29e50ac8536ea93244f219a1 Mon Sep 17 00:00:00 2001 From: vvd170501 <36827317+vvd170...@users.noreply.github.com> Date: Sat, 10 Feb 2024 19:19:52 +0300 Subject: [PATCH] Add -Wmissing-designat

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 18987af24d2f53d00e2ac42998a8f1580e35afdf Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-02-10 Thread Vinayak Dev via cfe-commits
vinayakdsci wrote: > LGTM Make sure @cor3ntin is happy, too. Thanks a lot! I have requested a review from @cor3ntin too. Thanks for your guidance! https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 edited https://github.com/llvm/llvm-project/pull/81364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 ready_for_review https://github.com/llvm/llvm-project/pull/81364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vadim D. (vvd170501) Changes Fixes #68933. #56628 changed the behavior of `-Wmissing-field-initializers`, which introduces many new warnings in C++ code that uses partial designated initializers. If such code is being built with `-Wextr

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 18987af24d2f53d00e2ac42998a8f1580e35afdf Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [llvm] [MC/DC] Refactor: Make `MCDCParams` as `std::variant` (PR #81227)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81227 >From c2b49a5317bf5b8af419cba814f95cc9305bec21 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Thu, 8 Feb 2024 23:12:54 +0900 Subject: [PATCH 1/2] [MC/DC] Refactor: Make `MCDCParams` as `std::variant` Intro

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 edited https://github.com/llvm/llvm-project/pull/81364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: @rjmccall Do you think this is acceptable? https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b4c6ab6 - [clang][Interp][NFC] Don't use visitLocalInitializer in visitExpr

2024-02-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-10T18:01:30+01:00 New Revision: b4c6ab600f2ef6f3a842afee569dcf86bce7a43a URL: https://github.com/llvm/llvm-project/commit/b4c6ab600f2ef6f3a842afee569dcf86bce7a43a DIFF: https://github.com/llvm/llvm-project/commit/b4c6ab600f2ef6f3a842afee569dcf86bce7a43a.diff LO

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-02-10 Thread Mark de Wever via cfe-commits
mordante wrote: @kaz7 ping https://github.com/llvm/llvm-project/pull/76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d2e4a72 - [clang] Update Clang version from 18 to 19 in scan-build.1.

2024-02-10 Thread Frederic Cambus via cfe-commits
Author: Frederic Cambus Date: 2024-02-10T18:16:08+01:00 New Revision: d2e4a725da5b4cbef8b5c1446f29fed1487aeab0 URL: https://github.com/llvm/llvm-project/commit/d2e4a725da5b4cbef8b5c1446f29fed1487aeab0 DIFF: https://github.com/llvm/llvm-project/commit/d2e4a725da5b4cbef8b5c1446f29fed1487aeab0.dif

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-02-10 Thread Jon Roelofs via cfe-commits
@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma jroelofs wrote: I think they are part of ABI, and givin

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams created https://github.com/llvm/llvm-project/pull/81367 Shorts are half an int, so HalfWidth and HalfAlign apply here. >From b7c50bfa24abe51e73852667a6d972780dbf8cc2 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sat, 10

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes Shorts are half an int, so HalfWidth and HalfAlign apply here. --- Full diff: https://github.com/llvm/llvm-project/pull/81367.diff 1 Files Affected: - (modified) clang/include/clang/Basic/TargetInfo.h (

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-em

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81367 >From f12c08eb449781e782f84fc534d0bc6f8483e14f Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sat, 10 Feb 2024 12:35:20 -0500 Subject: [PATCH] Resolve FIXME: Use Half

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From 071f8df3f82798255bcc0e2787fd7167b607d59f Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:53:56 + Subject: [PATCH] In compilation data

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (Overhatted) Changes I haven't finished all of the tests and formatting so it's a bit in a POC stage but I would like to know if this change would be accepted. The change is to support relative paths in the "directory" fi

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From 071f8df3f82798255bcc0e2787fd7167b607d59f Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:53:56 + Subject: [PATCH] In compilation data

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From cb57948468634e952d0c953fe0215fa15f030e28 Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:53:56 + Subject: [PATCH] In compilation data

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81367 >From ebd724f537fe0f7c1ad468d15bb13245c7d56d9f Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sat, 10 Feb 2024 12:35:20 -0500 Subject: [PATCH] [clang] Resolve FIXME:

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 70c646a54852f33306ff567b5cb125558e2b9529 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid printing overly large integer. (PR #75902)

2024-02-10 Thread Nhat Nguyen via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001 From:

[clang] ba451c8 - [clang][Interp][NFC] Only set result invalid if empty

2024-02-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-10T19:45:10+01:00 New Revision: ba451c80ba67ab6834305f35d47e36b6b446ce83 URL: https://github.com/llvm/llvm-project/commit/ba451c80ba67ab6834305f35d47e36b6b446ce83 DIFF: https://github.com/llvm/llvm-project/commit/ba451c80ba67ab6834305f35d47e36b6b446ce83.diff LO

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: > Shorts are half an int, so HalfWidth and HalfAlign apply here. This is not true for our downstream target where `short` has the same width as `int` (note that the standard allows it). It would be better to introduce `ShortWidth` / `ShortAlign` fields and initialize them t

[clang] bc034ba - [clang][Interp] Protect InitPtr from non-initializable pointers

2024-02-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-10T19:45:10+01:00 New Revision: bc034baaff1f6ce4e18b68c20df3be45bfb5104f URL: https://github.com/llvm/llvm-project/commit/bc034baaff1f6ce4e18b68c20df3be45bfb5104f DIFF: https://github.com/llvm/llvm-project/commit/bc034baaff1f6ce4e18b68c20df3be45bfb5104f.diff LO

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71709 >From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 8 Nov 2023 20:30:37 +0300 Subject: [PATCH 1/4] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` This

[clang] [llvm] [HLSL] Implementation of dot intrinsic (PR #81190)

2024-02-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/81190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71709 >From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 8 Nov 2023 20:30:37 +0300 Subject: [PATCH 1/4] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` This

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 8c850241cedeaad1bcc91c68ad7558f485d212e8 Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sat, 10 Feb 2024 20:52:03 +0100 Subject: [PATCH] [clangd] Do not render large initializer expressions from the preamble

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 1739d0a4fd079d2201e63166fbaba60644c52297 Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sat, 10 Feb 2024 20:52:03 +0100 Subject: [PATCH] [clangd] Do not render large initializer expressions from the preamble

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 3ad404a10c3def9f92f399774f9f1507442bca1b Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sat, 10 Feb 2024 20:52:03 +0100 Subject: [PATCH] [clangd] Do not render large initializer expressions from the preamble

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
@@ -138,15 +138,9 @@ std::string getNamespaceScope(const Decl *D) { std::string printDefinition(const Decl *D, PrintingPolicy PP, const syntax::TokenBuffer &TB) { - if (auto *VD = llvm::dyn_cast(D)) { -if (auto *IE = VD->getInit()) { - //

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
@@ -1720,6 +1720,12 @@ void StmtPrinter::VisitInitListExpr(InitListExpr* Node) { OS << "{"; for (unsigned i = 0, e = Node->getNumInits(); i != e; ++i) { if (i) OS << ", "; +// TODO: There is duplicated functionality in APValue::printPretty. +// Would be good to

[clang] 3a05e76 - [clang][NFC] Annotate `Sema/DeclSpec.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-10T23:37:00+03:00 New Revision: 3a05e7651bc71b3c71757bb406f211645c1c1a37 URL: https://github.com/llvm/llvm-project/commit/3a05e7651bc71b3c71757bb406f211645c1c1a37 DIFF: https://github.com/llvm/llvm-project/commit/3a05e7651bc71b3c71757bb406f211645c1c1a37.

[clang] [lld] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-02-10 Thread Dimitry Andric via cfe-commits
DimitryAndric wrote: Maybe I'm doing something wrong, but after this commit (and its merge to 18.x) I don't see to get stack traces from clang anymore after assertions? How is this supposed to work? https://github.com/llvm/llvm-project/pull/76306 _

[clang] [lld] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-02-10 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: llvm-driver-template.cpp.in is what should be generating the real main for Clang (and call clang_main), and that was patched in this commit. https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread John McCall via cfe-commits
https://github.com/rjmccall requested changes to this pull request. Okay, your description of the change here is very misleading; it doesn't even mention that this is specific to having an `@implementation` for every intermediate class. Your test seems completely inadequate — you need to test

[clang] 4e16a75 - [clang][NFC] Annotate `Sema/ScopeInfo.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-10T23:58:26+03:00 New Revision: 4e16a75902d5718f4932fae9b2a07c410cd0ba34 URL: https://github.com/llvm/llvm-project/commit/4e16a75902d5718f4932fae9b2a07c410cd0ba34 DIFF: https://github.com/llvm/llvm-project/commit/4e16a75902d5718f4932fae9b2a07c410cd0ba34.

[clang] [lld] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-02-10 Thread Dimitry Andric via cfe-commits
DimitryAndric wrote: Ah that was my error, I hadn't used the regenerated `*-driver.cpp` files. These indeed should contain the `InitLLVM` call. https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-02-10 Thread via cfe-commits
wheatman wrote: @AaronBallman I am a little confused about what is the correct behavior for one the the cases in the test file for c. ```cpp enum PR4515 {PR4515a=1u,PR4515b=(PR4515a-2)/2}; int CheckPR4515[PR4515b==0?1:-1]; ``` At present since everything is ints this works fine, but some things

[clang] d2812d2 - [clang][NFC] Annotate `Sema/Overload.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T00:11:13+03:00 New Revision: d2812d2d1a9b4edb64e95a9a86a2599a24bcb5ec URL: https://github.com/llvm/llvm-project/commit/d2812d2d1a9b4edb64e95a9a86a2599a24bcb5ec DIFF: https://github.com/llvm/llvm-project/commit/d2812d2d1a9b4edb64e95a9a86a2599a24bcb5ec.

[clang] 425fd3e - [clang][NFC] Rename FirstCoroutineStmtKind enumerators

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T00:15:25+03:00 New Revision: 425fd3eb10f29e73d722b4c2bc9cb50798de18e8 URL: https://github.com/llvm/llvm-project/commit/425fd3eb10f29e73d722b4c2bc9cb50798de18e8 DIFF: https://github.com/llvm/llvm-project/commit/425fd3eb10f29e73d722b4c2bc9cb50798de18e8.

[clang] 6a7cf80 - [clang][NFC] Annotate `Sema/ParsedAttr.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T00:21:37+03:00 New Revision: 6a7cf806a66c67df01818fda01116a2dd2d90b0d URL: https://github.com/llvm/llvm-project/commit/6a7cf806a66c67df01818fda01116a2dd2d90b0d DIFF: https://github.com/llvm/llvm-project/commit/6a7cf806a66c67df01818fda01116a2dd2d90b0d.

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: > Okay, your description of the change here is very misleading; it doesn't even > mention that this is specific to having an `@implementation` for every > intermediate class. > > Your test seems completely inadequate — you need to test that we're doing the > static layout p

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: > test seems completely inadequate — you need to test that we're doing the > static layout properly, and you need to test with ivars coming from a variety > of different places, including: > > * ivars declared in the `@interface` > * ivars declared in the `@implementation` >

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 527e24ae4d6f662c2bee1a281914df028bcd01e1 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (44-2-Kupa-Martin) Changes …C mode Factored logic from `CheckImplicitConversion` into new methods `Expr::getEnumConstantDecl` and `Expr::getEnumCoercedType` for use in `checkEnumArithmeticConversions`. Fix #29217 --- Patch is 650

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 527e24ae4d6f662c2bee1a281914df028bcd01e1 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b17348c3b541d7fc7ec441c98db75c18d8959910 b256939140c99356f2ab41e2c69f3d218ffc81a6 --

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 4bdf6f78a595e7e33387a1b4f1f80286b0163d47 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 4bdf6f78a595e7e33387a1b4f1f80286b0163d47 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
44-2-Kupa-Martin wrote: Got the formatter wrong https://github.com/llvm/llvm-project/pull/81389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
https://github.com/44-2-Kupa-Martin closed https://github.com/llvm/llvm-project/pull/81389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 3287e1ddb572f73ca774e50323b037d50b600e34 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: Layout before and after my change: https://github.com/llvm/llvm-project/assets/83477269/6e45ad11-16e8-4dcc-8d7b-f8e29a1a9cc0";> https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: Sorry, that was codegen, I meant ![image](https://github.com/llvm/llvm-project/assets/83477269/cd59af73-2f4a-48b6-b847-0994c8191ab2) https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llv

  1   2   >