[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread via cfe-commits
@@ -7805,10 +7805,38 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc, TypeSourceInfo *TInfo, diag::err_variable_object_no_init)) return ExprError(); } + } else if (LangOpts.C23 && + (literalType->is

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. Do you need me to merge that for you? https://github.com/llvm/llvm-project/pull/76361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-29 Thread Jimmy Z via cfe-commits
jimmy-zx wrote: Ping. Can one of you press the merge button? https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/79788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ee08b99 - [libclang/python] Expose Rewriter to the python binding (#77269)

2024-01-29 Thread via cfe-commits
Author: Jimmy Z Date: 2024-01-29T11:19:34-05:00 New Revision: ee08b992514bd1556c38f42409d92728af3451f7 URL: https://github.com/llvm/llvm-project/commit/ee08b992514bd1556c38f42409d92728af3451f7 DIFF: https://github.com/llvm/llvm-project/commit/ee08b992514bd1556c38f42409d92728af3451f7.diff LOG:

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxx] [libcxxabi] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -36,7 +36,12 @@ struct __cxa_exception; _LIBCPP_OVERRIDABLE_FUNC_VIS __cxa_exception* __cxa_init_primary_exception( void*, std::type_info*, -void( +# if defined(__USING_WASM_EXCEPTIONS__) ldionne wrote: Let's introduce a typedef name for this f

[libunwind] [libcxxabi] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -15,6 +15,7 @@ #include <__libunwind_config.h> +#ifndef __wasm__ ldionne wrote: What is the purpose of this header if it's entirely empty on wasm? https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits

[libcxx] [libunwind] [libcxxabi] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libcxxabi] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -10,14 +10,11 @@ // //===--===// +#if __STDC_VERSION__ < 202311L ldionne wrote: This change seems unrelated to the rest of the patch. https://github.com/llvm/llvm-project/pull/79667

[libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -12,6 +12,7 @@ #include #include "config.h" +#ifndef __wasm__ ldionne wrote: Similar question as above here. If this file is basically empty on wasm, we should instead avoid adding it in the CMakeLists.txt. https://github.com/llvm/llvm-project/pull/7966

[libcxxabi] [libunwind] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -180,6 +180,7 @@ #endif #define _LIBUNWIND_HIGHEST_DWARF_REGISTER \ _LIBUNWIND_HIGHEST_DWARF_REGISTER_LOONGARCH +#elif defined(__wasm__) ldionne wrote: Why don't we define `_LIBUNWIND_CURSOR_SIZE` and friends on wasm?

[libunwind] [libcxx] [libcxxabi] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-29 Thread Louis Dionne via cfe-commits
@@ -35,7 +32,12 @@ struct _Unwind_LandingPadContext { // Communication channel between compiler-generated user code and personality // function -thread_local struct _Unwind_LandingPadContext __wasm_lpad_context; +#if __STDC_VERSION__ >= 202311L ldionne wrote:

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/79788 >From dde16b48d563b3e279872081bad148614e9d28a3 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Sun, 28 Jan 2024 22:42:53 -0800 Subject: [PATCH] [Clang][Sema] Fix crash when type used in return statement cont

[clang] [clang-tools-extra] [llvm] Add STACK_SIZES section for MachOS. (PR #77106)

2024-01-29 Thread via cfe-commits
https://github.com/shamithoke updated https://github.com/llvm/llvm-project/pull/77106 >From e939dbedfa4cd875858825e890310d2581bfa525 Mon Sep 17 00:00:00 2001 From: shami Date: Thu, 28 Dec 2023 21:19:36 +0530 Subject: [PATCH 1/2] Add STACK_SIZES section for MachOS. --- llvm/lib/MC/MCObjectFile

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: In order to aid the discussion on the temporary flag, I think it would be helpful to have a full set of tests that show what elements won't work right with the current set of changes. I think this will help us gauge how impactful partial support would be an

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
yronglin wrote: > LGTM. Do you need me to merge that for you? Thanks a lot for your review and help! I have commit access, once the CI green, I'll land this patch. https://github.com/llvm/llvm-project/pull/76361 ___ cfe-commits mailing list cfe-commi

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread Louis Dionne via cfe-commits
ldionne wrote: > I am on the fence whether a driver option is really needed. It is a very > shallow layer of extra abstraction that a curious reader has to look through. > I guess I'll not object to this, if people really want to add it. Setting macros that are reserved names is really unappea

[llvm] [clang-tools-extra] [clang] [DirectX] Rename DXILOperationCommon.h to DXILABI.h. NFC (PR #78224)

2024-01-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/78224 >From 698fb909b55b9134b23da7ec1c87c75375f950b4 Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Mon, 15 Jan 2024 18:32:54 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[flang] [clang-tools-extra] [llvm] [clang] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-29 Thread Yi Wu via cfe-commits
yi-wu-arm wrote: build and pass all test on Windows on Arm MSVC, native. https://github.com/llvm/llvm-project/pull/74309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread Sam James via cfe-commits
thesamesam wrote: > > I am on the fence whether a driver option is really needed. It is a very > > shallow layer of extra abstraction that a curious reader has to look > > through. I guess I'll not object to this, if people really want to add it. > > Setting macros that are reserved names is r

[flang] [clang-tools-extra] [llvm] [clang] [flang] add SYSTEM runtime and lowering intrinsics support (PR #74309)

2024-01-29 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm closed https://github.com/llvm/llvm-project/pull/74309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae8005f - [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (#79614)

2024-01-29 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-01-29T16:37:09Z New Revision: ae8005ffb6cd18900de8ed5a86f60a4a16975471 URL: https://github.com/llvm/llvm-project/commit/ae8005ffb6cd18900de8ed5a86f60a4a16975471 DIFF: https://github.com/llvm/llvm-project/commit/ae8005ffb6cd18900de8ed5a86f60a4a16975471.di

[llvm] [clang] [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (PR #79614)

2024-01-29 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/79614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread Erich Keane via cfe-commits
erichkeane wrote: >We could revert the whole patch when things are broken (and it is what we >usually do). But I'm not sure revert/reland a big patch back and forth is a >good idea. This is effectively what we did repeatedly with the deferred concepts patch and IMO, was a really nice healthy

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread Louis Dionne via cfe-commits
ldionne wrote: > > > I am on the fence whether a driver option is really needed. It is a very > > > shallow layer of extra abstraction that a curious reader has to look > > > through. I guess I'll not object to this, if people really want to add it. > > > > > > Setting macros that are reserve

[clang] [clang] Implement CTAD for type alias template. (PR #77890)

2024-01-29 Thread via cfe-commits
@@ -10636,6 +10889,113 @@ QualType Sema::DeduceTemplateSpecializationFromInitializer( // clear on this, but they're not found by name so access does not apply. Guides.suppressDiagnostics(); + SmallVector GuidesCandidates; + if (AliasTemplate) { yronglin

[lld] [clang] [libcxx] [flang] [llvm] [compiler-rt] [libc] [lldb] [clang-tools-extra] [mlir] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-29 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[openmp] [clang] [flang] [libcxx] [llvm] [compiler-rt] [libc] [lldb] [clang-tools-extra] [mlir] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From cff4446c697e4abfb18ea0a17ca2b6596c23015f Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:25:57 +0800 Subject: [PATCH 1/3] [Clang] Implement P2718R0 "Lifetime extension in range-based for

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread Aaron Ballman via cfe-commits
@@ -7730,6 +7730,14 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">, } // let Visibility = [CC1Option] +def stdlib_hardening_EQ : Joined<["-"], "fstdlib-hardening=">, AaronBallman wrote: I am worried about that -- I'm also worried about folk

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread via cfe-commits
@@ -7730,6 +7730,14 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">, } // let Visibility = [CC1Option] +def stdlib_hardening_EQ : Joined<["-"], "fstdlib-hardening=">, cor3ntin wrote: It is consistent with `-stdlib` https://github.com/llvm/l

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Guillot Tony via cfe-commits
@@ -7805,10 +7805,38 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc, TypeSourceInfo *TInfo, diag::err_variable_object_no_init)) return ExprError(); } + } else if (LangOpts.C23 && + (literalType->is

[clang] [clang] Only set the trailing bytes to zero when filling a partially … (PR #79502)

2024-01-29 Thread via cfe-commits
serge-sans-paille wrote: @nikic / @AaronBallman any thought on the general approach? https://github.com/llvm/llvm-project/pull/79502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Mariya Podchishchaeva via cfe-commits
@@ -7639,6 +7639,8 @@ def err_attribute_arm_mve_polymorphism : Error< "'__clang_arm_mve_strict_polymorphism' attribute can only be applied to an MVE/NEON vector type">; def err_attribute_webassembly_funcref : Error< "'__funcref' attribute can only be applied to a function

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Setting macros that are reserved names is really unappealing for people. I think that may depend on your background. For example, in the C standard library, there's a whole pile of `WANT` macros that users are expected to define before including a header file to opt in to

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/79845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Only set the trailing bytes to zero when filling a partially … (PR #79502)

2024-01-29 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/79502 >From 376f62b2aa3e1c2ec37b53a66f7525ae02e54172 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 25 Jan 2024 22:12:55 +0100 Subject: [PATCH] [clang] Only set the trailing bytes to zero when fi

[libc] [flang] [clang] [libcxx] [llvm] [clang-tools-extra] [compiler-rt] [openmp] [mlir] [lldb] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-29 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From cff4446c697e4abfb18ea0a17ca2b6596c23015f Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:25:57 +0800 Subject: [PATCH 1/4] [Clang] Implement P2718R0 "Lifetime extension in range-based for

[clang] [llvm] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-29 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/79316 >From d0dfa97f58a183d7fab1e6ddf2ef29ba3b3c3f36 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Wed, 24 Jan 2024 15:26:01 + Subject: [PATCH] [FMV] Change feature priorities according to ACLE. This

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-29 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/79796 >From d40f2ed71e72c9cee266e63abbae4b9aac1de47c Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 29 Jan 2024 00:43:19 -0800 Subject: [PATCH] [clang-format] Simplify the AfterPlacementOperator option Change After

[clang] [llvm] [clang-tools-extra] [DirectX] Rename DXILOperationCommon.h to DXILABI.h. NFC (PR #78224)

2024-01-29 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/78224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: This seems to have perturbed the HIP build. https://lab.llvm.org/staging/#/builders/22/builds/22 The problem is that we used to set `__AMDGCN_WAVEFRONTSIZE` for the host compilation as well in a bunch of the wave function macros. I think that this is just poor programming, beca

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > This seems to have perturbed the HIP build. > https://lab.llvm.org/staging/#/builders/22/builds/22 > > The problem is that we used to set `__AMDGCN_WAVEFRONTSIZE` for the host > compilation as well in a bunch of the wave function macros. I think that this > is just poor prog

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > This seems to have perturbed the HIP build. > > https://lab.llvm.org/staging/#/builders/22/builds/22 > > The problem is that we used to set `__AMDGCN_WAVEFRONTSIZE` for the host > > compilation as well in a bunch of the wave function macros. I think that > > this is just poo

[llvm] [clang] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-29 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs edited https://github.com/llvm/llvm-project/pull/79316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-29 Thread Jon Roelofs via cfe-commits
@@ -659,21 +659,21 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._Mfp16fmlMsimd +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MsimdMfp16fml // CHECK-SAME: () #[[ATTR7]] { // CHECK-NEXT: entry: // CH

[llvm] [clang] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-29 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/79316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 72d4fc1 - Revert "[AMDGPU] Do not emit arch dependent macros with unspecified cpu (#79660)"

2024-01-29 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-01-29T11:11:25-06:00 New Revision: 72d4fc1b4d5cfc4f7d50cc5cf1b315543c088f4d URL: https://github.com/llvm/llvm-project/commit/72d4fc1b4d5cfc4f7d50cc5cf1b315543c088f4d DIFF: https://github.com/llvm/llvm-project/commit/72d4fc1b4d5cfc4f7d50cc5cf1b315543c088f4d.diff

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Reverted. I don't think there's a "proper" solution here since this seems to have leaked into the headers due to whoever set this up initially not properly setting these on the host. That seems to be endemic now, so the best we can do it just set it to some dummy values I think.

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/79788 >From f7f1007954503d013294c2e21ce2160dc7866164 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Sun, 28 Jan 2024 22:42:53 -0800 Subject: [PATCH] [Clang][Sema] Fix crash when type used in return statement cont

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-29 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd created https://github.com/llvm/llvm-project/pull/79867 This PR adds the following features 1. If there are at least 2 distinct fixable diagnostics stemming from either `clang` or `clang-tidy` overall and their edits are distinct as well, we add a Fix to each on

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-29 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd @llvm/pr-subscribers-clang-tools-extra Author: Tor Shepherd (torshepherd) Changes This PR adds the following features 1. If there are at least 2 distinct fixable diagnostics stemming from either `clang` or `clang-tidy` overall and their edits ar

[clang-tools-extra] [clang] [llvm] [DirectX] Rename DXILOperationCommon.h to DXILABI.h. NFC (PR #78224)

2024-01-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/78224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][C23] N3006 Underspecified object declarations (PR #79845)

2024-01-29 Thread Guillot Tony via cfe-commits
@@ -7639,6 +7639,8 @@ def err_attribute_arm_mve_polymorphism : Error< "'__clang_arm_mve_strict_polymorphism' attribute can only be applied to an MVE/NEON vector type">; def err_attribute_webassembly_funcref : Error< "'__funcref' attribute can only be applied to a function

[mlir] [clang] [llvm] [libc] [clang-tools-extra] [compiler-rt] [flang] [lldb] [lld] [openmp] [libcxx] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-29 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-29 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/79230 >From 678cd8ea37f1d02c70fd09b7107542c8301c3bd2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 16 Jan 2024 13:18:09 -0800 Subject: [PATCH 1/5] Add support for builtin_verbose_trap The builtin causes th

[clang] [llvm] [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (PR #79614)

2024-01-29 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea milestoned https://github.com/llvm/llvm-project/pull/79614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-29 Thread Akira Hatanaka via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[llvm] [clang] [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (PR #79614)

2024-01-29 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: /cherry-pick ae8005f https://github.com/llvm/llvm-project/pull/79614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-01-29 Thread Tom Praschan via cfe-commits
tom-anders wrote: Duplicate issue: https://github.com/clangd/clangd/issues/741 https://github.com/llvm/llvm-project/pull/78454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-01-29 Thread Akira Hatanaka via cfe-commits
@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcxx-exceptions -verify %s + +#if !__has_builtin(__builtin_verbose_trap) +#error +#endif + +constexpr char const* constMsg1 = "hello"; +char const* const constMsg2 = "hello"; +char const constMsg3[] = "hello"; + +templ

[llvm] [clang] [AArch64][TargetParser] Add mcpu alias for Microsoft Azure Cobalt 100. (PR #79614)

2024-01-29 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#79870 https://github.com/llvm/llvm-project/pull/79614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [clang-tools-extra] [llvm] [openmp] [DirectX] Move DXIL ResourceKind and ElementType to DXILABI.h. NFC (PR #78225)

2024-01-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/78225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [openmp] [flang] [DirectX] Move DXIL ResourceKind and ElementType to DXILABI.h. NFC (PR #78225)

2024-01-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/78225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Reverted. I don't think there's a "proper" solution here since this seems to > have leaked into the headers due to whoever set this up initially not > properly setting these on the host. That seems to be endemic now, so the best > we can do it just set it to some dummy values

[clang] [NVPTX] Allow compiling LLVM-IR without `-march` set (PR #79873)

2024-01-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/79873 Summary: The NVPTX tools require an architecture to be used, however if we are creating generic LLVM-IR we should be able to leave it unspecified. This will result in the `target-cpu` attributes not being set on t

[clang] [NVPTX] Allow compiling LLVM-IR without `-march` set (PR #79873)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: The NVPTX tools require an architecture to be used, however if we are creating generic LLVM-IR we should be able to leave it unspecified. This will result in the `target-cpu` attributes not bei

[llvm] [clang] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar edited https://github.com/llvm/llvm-project/pull/79765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [libcxx] [lld] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-29 Thread Caslyn Tonelli via cfe-commits
@@ -5,6 +5,8 @@ ; RUN: %ld64 -lto_library %llvmshlibdir/libLTO.dylib -dylib -arch x86_64 -macos_version_min 10.10.0 -o %t.dylib %t.o -save-temps -undefined dynamic_lookup -exported_symbol _bar -lSystem -mllvm -lto-discard-value-names=false ; RUN: llvm-dis %t.dylib.lto.opt.bc

[clang] [llvm] [openmp] [libcxx] [lld] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-29 Thread Caslyn Tonelli via cfe-commits
https://github.com/Caslyn closed https://github.com/llvm/llvm-project/pull/77695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add builtin for 'exit' handling (PR #79777)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Justin Lebar via cfe-commits
jlebar wrote: Unlike the other PRs, this one has a CUDA function, `__activemask()`. Presumably we should make that one work by hacking our headers? https://github.com/llvm/llvm-project/pull/79768 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-01-29 Thread Jun Wang via cfe-commits
jwanggit86 wrote: @arsenm @krzysz00 Any comments? https://github.com/llvm/llvm-project/pull/79035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Unlike the other PRs, this one has a CUDA function, `__activemask()`. > Presumably we should make that one work by hacking our headers? That is currently defined here https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/__clang_cuda_intrinsics.h#L214. I was planni

[clang] [NVPTX] Allow compiling LLVM-IR without `-march` set (PR #79873)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

2024-01-29 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-29 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov created https://github.com/llvm/llvm-project/pull/79875 Particular example that lead to this is a very long chain of `UsingShadowDecl`s that we hit in our codebase in generated code. To avoid that, check for stack exhaustion when deserializing the declaration.

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Justin Lebar via cfe-commits
jlebar wrote: > I was planning on updating this to use the new instrinsic for the newer > version. Alternatively we could make __activemask the builtin which expands > to both versions, but I'm somewhat averse since we should target the > instruction directly I feel. Yes, I agree that the bui

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Ilya Biryukov (ilya-biryukov) Changes Particular example that lead to this is a very long chain of `UsingShadowDecl`s that we hit in our codebase in generated code. To avoid that, check for stack exhaust

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [DirectX][docs] Architecture and design philosophy of DXIL support (PR #78221)

2024-01-29 Thread Justin Bogner via cfe-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/78221 >From 8903229f71503c1c4291254c355b1692d9d908a3 Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Mon, 15 Jan 2024 18:14:07 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > I was planning on updating this to use the new instrinsic for the newer > > version. Alternatively we could make __activemask the builtin which expands > > to both versions, but I'm somewhat averse since we should target the > > instruction directly I feel. > > Yes, I agree

[clang] 7b0396f - [Clang][Sema] Fix crash when type used in return statement contains errors (#79788)

2024-01-29 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2024-01-29T10:08:09-08:00 New Revision: 7b0396faabce0cec470779ae5e3a851bedb2ac12 URL: https://github.com/llvm/llvm-project/commit/7b0396faabce0cec470779ae5e3a851bedb2ac12 DIFF: https://github.com/llvm/llvm-project/commit/7b0396faabce0cec470779ae5e3a851bedb2ac12.dif

[clang] [Clang][Sema] Fix crash when type used in return statement contains errors (PR #79788)

2024-01-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/79788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-29 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/79875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-29 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: I think the alternative we could try to chase is turning the chain of using-shadow-decls into an array somehow, so we can process it in a loop instead of recursion. I am not sure if there is an an approach that does **not** involve structural change

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-29 Thread Ilya Biryukov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/usings.cppm -o %t/usings.pcm +// RUN: %clang_cc1 -std=c++20 -fmodule-file=usings=%t/usings.pcm %t/use.cpp -verify -fsyntax-only -Wno-stac

[clang] [AMDGPU] Do not emit arch dependent macros with unspecified cpu (PR #79660)

2024-01-29 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: HIP host compilation can be identified by LangOpts.HIP && !LangOpts.CUDAIsDevice https://github.com/llvm/llvm-project/pull/79660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[lldb] [openmp] [clang] [clang-tools-extra] [compiler-rt] [mlir] [libc] [libcxx] [flang] [lld] [llvm] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-29 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[clang] [Docs] Add release note about Clang-defined target OS macros (PR #79879)

2024-01-29 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w created https://github.com/llvm/llvm-project/pull/79879 None >From b773a6911ef1f842b7d5d548c98109012d80dd10 Mon Sep 17 00:00:00 2001 From: Zixu Wang Date: Thu, 25 Jan 2024 16:35:37 -0800 Subject: [PATCH] [Docs] Add release note about Clang-defined target OS macros --

[clang] [Docs] Add release note about Clang-defined target OS macros (PR #79879)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zixu Wang (zixu-w) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/79879.diff 1 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+29) ``diff diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/Rel

[libcxx] [llvm] [lld] [openmp] [clang] [lto] Add minimum macos sdk requirement to test (PR #77695)

2024-01-29 Thread Florian Hahn via cfe-commits
fhahn wrote: Thanks for confirming! https://github.com/llvm/llvm-project/pull/77695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Restructure and extend the testing of template pack deduction (PR #79881)

2024-01-29 Thread Gábor Spaits via cfe-commits
https://github.com/spaits created https://github.com/llvm/llvm-project/pull/79881 Previously I worked on #78449 . I added tests in my solution #79371, but I think there should be other scenarios that should be tested and these tests deserve their namespace. In this PR I would like to make thes

[clang] [Sema] Restructure and extend the testing of template pack deduction (PR #79881)

2024-01-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Gábor Spaits (spaits) Changes Previously I worked on #78449 . I added tests in my solution #79371, but I think there should be other scenarios that should be tested and these tests deserve their namespace. In this PR I would like to make t

[compiler-rt] [flang] [clang] [lldb] [clang-tools-extra] [llvm] [libcxx] [libc] [llvm-cov] Simplify and optimize MC/DC computation (PR #79727)

2024-01-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [compiler-rt] [libc] [libcxx] [flang] [clang-tools-extra] [llvm] [llvm-cov] Simplify and optimize MC/DC computation (PR #79727)

2024-01-29 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/79727 >From 1d2470c2d67673f9ef9ea504e0abb3e964d43ebb Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sat, 27 Jan 2024 22:24:39 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

<    1   2   3   4   5   6   >