cor3ntin wrote:
> Should we also dump the sub-expr which in `CXXDefaultArgExpr`: for example:
> Consider:
>
> ```
> struct A {
> A();
> ~A();
> };
>
> typedef int vec3[3];
> vec3 &f(const A &a = A{});
>
> void foo() {
> for (auto e : f()) {}
> }
> ```
>
> Current AST Dump:
>
> ```
> F
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation
Loc, FieldDecl *Field) {
ImmediateCallVisitor V(getASTContext());
if (!NestedDefaultChecking)
V.TraverseDecl(Field);
- if (V.HasImmediateCalls) {
+ if (V.HasImmediateCalls || InLifetimeEx
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation
Loc, FieldDecl *Field) {
ImmediateCallVisitor V(getASTContext());
if (!NestedDefaultChecking)
V.TraverseDecl(Field);
- if (V.HasImmediateCalls) {
+ if (V.HasImmediateCalls || InLifetimeEx
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inclyc commented:
Also I kindly wonder if this intrinsic is necessary for optimization/codegen.
Why not prefer inline assembly?
https://github.com/llvm/llvm-project/pull/79672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -2558,6 +2558,14 @@ def : Pat<(rotr GPR32:$Rn, (i64 imm0_31:$imm)),
def : Pat<(rotr GPR64:$Rn, (i64 imm0_63:$imm)),
(EXTRXrri GPR64:$Rn, GPR64:$Rn, imm0_63:$imm)>;
+def SDT_AArch64BFI_32bit : SDTypeProfile<1, 2, [SDTCisVT<0, i32>, SDTCisVT<1,
i32>,
+
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yronglin wrote:
For this case, should
> > Should we also dump the sub-expr which in `CXXDefaultArgExpr`: for example:
> > Consider:
>
> I think this makes sense, but it can be a separate patch, unless it helps for
> testing.
Cool! Let's do it in a separate patch.
> FYI, we prefer merge comm
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/79733
>From 9834d065580a668f94f74adaf8507ca672e9118f Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 28 Jan 2024 15:12:01 +0800
Subject: [PATCH] [Clang][Sema] fix deducing auto& from const int in template
parameters
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inclyc approved this pull request.
Looks like an NFC patch
https://github.com/llvm/llvm-project/pull/79701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inclyc edited https://github.com/llvm/llvm-project/pull/79701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
> However, this doesn't seem to change the behavior in vscode:
I applied the patch locally, and it does have _an_ effect on the steps from
#1536 (running `Auto fix` with code containing multiple diagnostics selected):
* before, it would show a message saying no fixes are
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/79539
>From 024e972034d5e6a91157feeba30cc76368819b8f Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Thu, 25 Jan 2024 16:20:47 -0500
Subject: [PATCH] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM
Add a li
davemgreen wrote:
Hello. Can you explain why this is needed, as opposed to using the equivalent
shift/and/ors?
https://github.com/llvm/llvm-project/pull/79672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
Enna1 wrote:
Hi @fhahn
I think this change introduce a memory leak in `VPlan::duplicate()`, see
https://lab.llvm.org/buildbot/#/builders/168/builds/18308/steps/10/logs/stdio
Can you take a look?
https://github.com/llvm/llvm-project/pull/73158
___
cf
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76090
>From 7c31c8bc2acf60bd50cb6d63944ee8d4946b9638 Mon Sep 17 00:00:00 2001
From: Florian Hahn
Date: Thu, 4 May 2023 21:33:24 +0100
Subject: [PATCH 1/3] [VPlan] Replace VPRecieOrVPValue with VP2VP recipe
simplification
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/78120
>From aaee7cfdea325459d68bc4e7205d7e25ca045d1a Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Sun, 14 Jan 2024 19:41:59 -0800
Subject: [PATCH 1/9] [RISCV] Relax march string order constraint
---
clang/test/Driver/
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation
Loc, FieldDecl *Field) {
ImmediateCallVisitor V(getASTContext());
if (!NestedDefaultChecking)
V.TraverseDecl(Field);
- if (V.HasImmediateCalls) {
+ if (V.HasImmediateCalls || InLifetimeEx
jplehr wrote:
Hi @aaupov I think this did break the AMD Hip build bot (another annotated
builder).
Are you looking into the potential issue?
https://github.com/llvm/llvm-project/pull/69133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/rwols created https://github.com/llvm/llvm-project/pull/79746
Previously we checked whether we were dealing with a large initializer using
TokenBuffer::expandedTokens. However, TokenBuffer does not contain the tokens
of the preamble. This causes large arrays imported from an
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Raoul Wols (rwols)
Changes
Previously we checked whether we were dealing with a large initializer using
TokenBuffer::expandedTokens. However, TokenBuffer does not contain the tokens
of the preamble. This causes large arrays imported from
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1b37e8087e1e1ecf5aadd8da536ee17dc21832e2
27bc0b64e17afce3196eb8d8415a8c61619dfae2 --
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746
>From 6f95aba8dbdf2ac807216597e5ab7fc62af29770 Mon Sep 17 00:00:00 2001
From: Raoul Wols
Date: Sun, 28 Jan 2024 14:14:29 +0100
Subject: [PATCH] [clangd] Prevent printing huge initializer lists in hover
definitions
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/76361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jcsxky wrote:
> Oh wow, thanks for this fix! It will need a Changelog entry.
>
> Does it fixes any of these issues? #68885
This patch can't fix #68885. I have looked into the code and the root cause
maybe different (probably relate to ExprConst, I'm not sure). Need more work on
that issue.
h
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/79747
Add (de)serialization support for them, like we do for Floating values.
Unfortunately I wasn't able to eliminate the code duplication coming from the
signed/unsigned split here. I was trying to avoid adding a t
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Add (de)serialization support for them, like we do for Floating values.
Unfortunately I wasn't able to eliminate the code duplication coming from the
signed/unsigned split here. I was trying to avoid adding
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/79733
>From af0b28a28f0bf46b22521c0b39d5200eb94838dd Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 28 Jan 2024 15:12:01 +0800
Subject: [PATCH] [Clang][Sema] fix deducing auto& from const int in template
parameters
Author: Timm Bäder
Date: 2024-01-28T14:36:27+01:00
New Revision: 70e22537549c65d69ae97a311d821c6459b32289
URL:
https://github.com/llvm/llvm-project/commit/70e22537549c65d69ae97a311d821c6459b32289
DIFF:
https://github.com/llvm/llvm-project/commit/70e22537549c65d69ae97a311d821c6459b32289.diff
LO
https://github.com/cor3ntin approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/79733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-01-28T16:15:21+01:00
New Revision: 354548621fdbaead4832361d26922b91488e401a
URL:
https://github.com/llvm/llvm-project/commit/354548621fdbaead4832361d26922b91488e401a
DIFF:
https://github.com/llvm/llvm-project/commit/354548621fdbaead4832361d26922b91488e401a.diff
LO
Author: Timm Bäder
Date: 2024-01-28T16:15:22+01:00
New Revision: 916bd7d3bb42627f52e2f8ed2f87e08db4960a72
URL:
https://github.com/llvm/llvm-project/commit/916bd7d3bb42627f52e2f8ed2f87e08db4960a72
DIFF:
https://github.com/llvm/llvm-project/commit/916bd7d3bb42627f52e2f8ed2f87e08db4960a72.diff
LO
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/79753
The Float print type is backed by the Floating class, which in turn uses
APFloat, which might heap-allocate memory, so might be expensive to copy.
Add an 'AsRef' bit to the ArgType tablegen class, which defines
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
The Float print type is backed by the Floating class, which in turn uses
APFloat, which might heap-allocate memory, so might be expensive to copy.
Add an 'AsRef' bit to the ArgType tablegen class, which defi
tbaederr wrote:
For reference, the generated code with this patch looks like this:
```c++
#if defined(GET_EVAL_PROTO) || defined(GET_LINK_PROTO)
bool emitConstFloat(const Floating &, const SourceInfo &);
#endif
#ifdef GET_LINK_IMPL
bool ByteCodeEmitter::emitConstFloat(const Floating &A0, const S
https://github.com/SunilKuravinakop updated
https://github.com/llvm/llvm-project/pull/79475
>From 6614e517cf0888b4502efc0af974d1612fa7a822 Mon Sep 17 00:00:00 2001
From: Sunil Kuravinakop
Date: Thu, 25 Jan 2024 10:37:20 -0600
Subject: [PATCH 1/2] Changes to Support Parsing & Sema of atomic comp
carlos4242 wrote:
I think unit testing the bug fix to this function (the copy that is in Sema) is
going to be nearly impossible.
To prove the point, I tried hard coding the wrong return value for many types
just now...
```
switch (Kind) {
case tok::kw_bool:
case tok::kw_short:
case to
https://github.com/i-ky created https://github.com/llvm/llvm-project/pull/79758
Its operation principles differ from Bear, which allows it to capture compile
commands when Bear is not able to.
Full disclosure: I am the author of basset.
>From 3166a7ff57893e34963b51770f2e711a2b28e7b6 Mon Sep 17
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (i-ky)
Changes
Its operation principles differ from Bear, which allows it to capture compile
commands when Bear is not able to.
Full disclosure: I am the author of basset.
---
Full diff: https://github.com/llvm/llvm-project/pull/797
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/79760
This removes on-stack `TemplateArgumentList`'s. They were primary used to pass
an `ArrayRef` to `Sema::getTemplateInstantiationArgs`, which
had a `const TemplateArgumentList*` parameter for the innermost temp
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
This removes on-stack `TemplateArgumentList`'s. They were primary used to pass
an `ArrayRef` to `Sema::getTemplateInstantiationArgs`,
which had a `const TemplateArgumentList*` par
@@ -4216,6 +4217,95 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned
ROpc, unsigned MOpc,
return CNode;
}
+// When the consumer of a right shift (arithmetic or logical) wouldn't notice
+// the difference if the instruction was a rotate right instead (because the
+//
@@ -6375,12 +6383,16 @@ ExprResult Sema::BuildCXXDefaultInitExpr(SourceLocation
Loc, FieldDecl *Field) {
ImmediateCallVisitor V(getASTContext());
if (!NestedDefaultChecking)
V.TraverseDecl(Field);
- if (V.HasImmediateCalls) {
+ if (V.HasImmediateCalls || InLifetimeEx
RamaMalladiAWS wrote:
> Hello. Can you explain why this is needed, as opposed to using the equivalent
> shift/and/ors?
Hi @davemgreen, one of AWS customers requested for such an intrinsic to be made
available so that they could consume it their IR directly. The reasoning they
had was to use 1
DimitryAndric wrote:
FWIW I think I just hit this when building llvm itself (though 15.0.6) with a
recent clang, and getting:
```text
/wrkdirs/usr/ports/devel/llvm15/work-default/llvm-project-15.0.7.src/llvm/tools/sancov/sancov.cpp:532:44:
error: chosen constructor is explicit in copy-initiali
https://github.com/bolshakov-a created
https://github.com/llvm/llvm-project/pull/79764
`OpaqueValueExpr` doesn't necessarily contain a source expression.
Particularly, after #78041, it is used to carry the type and the value kind of
a non-type template argument of floating-point type or referr
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Andrey Ali Khan Bolshakov (bolshakov-a)
Changes
`OpaqueValueExpr` doesn't necessarily contain a source expression.
Particularly, after #78041, it is used to carry the type and the value
kind of a non-type template argume
bolshakov-a wrote:
@steakhal, @cor3ntin, @erichkeane
https://github.com/llvm/llvm-project/pull/79764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lntue wrote:
> These are all annotated builders. I tried triggering rebuilds with clean
> build dir through buildbot UI but it didn't have an effect. I don't think
> it's a reasonable expectation that every change must configure cleanly from
> an existing build directory.
I'm sorry but I also
Author: Kazu Hirata
Date: 2024-01-28T10:47:03-08:00
New Revision: d1427fb6d0e1dbe3b7dbf46c26e43ce96b9b56d5
URL:
https://github.com/llvm/llvm-project/commit/d1427fb6d0e1dbe3b7dbf46c26e43ce96b9b56d5
DIFF:
https://github.com/llvm/llvm-project/commit/d1427fb6d0e1dbe3b7dbf46c26e43ce96b9b56d5.diff
L
Author: Kazu Hirata
Date: 2024-01-28T10:47:05-08:00
New Revision: 26648daeb2ea1e9443d214e3923583efba346603
URL:
https://github.com/llvm/llvm-project/commit/26648daeb2ea1e9443d214e3923583efba346603
DIFF:
https://github.com/llvm/llvm-project/commit/26648daeb2ea1e9443d214e3923583efba346603.diff
L
mordante wrote:
> @mordante I guess the PR missed LLVM18 release. I'll update the release notes
> accordingly. Is that OK?
Yes. It would have been nice to get this in LLVM 18, but I don't feel it's
critical to backport it. (Especially since it's a C++26 only feature and I
expect very few peop
https://github.com/Bryce-MW updated
https://github.com/llvm/llvm-project/pull/77964
>From d4c312b9dbf447d0a53dda0e6cdc482bd908430b Mon Sep 17 00:00:00 2001
From: Bryce Wilson
Date: Fri, 12 Jan 2024 16:01:32 -0600
Subject: [PATCH 01/16] [X86] Use RORX over SHR imm
---
llvm/lib/Target/X86/X86In
aaupov wrote:
Status of the builders that reported breakage:
- [reverse-iteration](https://lab.llvm.org/buildbot/#/builders/54):
https://lab.llvm.org/buildbot/#/builders/54/builds/8671 broken,
https://lab.llvm.org/buildbot/#/builders/54/builds/8672 green, breakage was
unrelated (unresolved tes
https://github.com/Bryce-MW updated
https://github.com/llvm/llvm-project/pull/77964
>From d4c312b9dbf447d0a53dda0e6cdc482bd908430b Mon Sep 17 00:00:00 2001
From: Bryce Wilson
Date: Fri, 12 Jan 2024 16:01:32 -0600
Subject: [PATCH 01/16] [X86] Use RORX over SHR imm
---
llvm/lib/Target/X86/X86In
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/79765
Summary:
This patch adds support for `globaltimer` to match `clock` and
`clock64`. See the PTX ISA reference fro details. This patch does not
implement the `hi` or `lo` variants for brevity as they can be obtained
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-llvm-ir
Author: Joseph Huber (jhuber6)
Changes
Summary:
This patch adds support for `globaltimer` to match `clock` and
`clock64`. See the PTX ISA reference fro details. This patch does not
implement the `hi` or `lo` variants fo
aaupov wrote:
This issue with incremental builds is explicitly mentioned in
[HowToAddABuilder](https://llvm.org/docs/HowToAddABuilder.html):
> Use CCache and NOT incremental builds
Using ccache materially improves average build times. Incremental builds can be
slightly faster, but introduce th
fhahn wrote:
@Enna1 thanks, should be fixed by 1b37e8087e1e1ecf5aadd8da536ee17dc21832e2. Bot
should be back to green
https://github.com/llvm/llvm-project/pull/73158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/76090
>From 7c31c8bc2acf60bd50cb6d63944ee8d4946b9638 Mon Sep 17 00:00:00 2001
From: Florian Hahn
Date: Thu, 4 May 2023 21:33:24 +0100
Subject: [PATCH 1/4] [VPlan] Replace VPRecieOrVPValue with VP2VP recipe
simplification
@@ -8378,9 +8357,8 @@ void VPRecipeBuilder::fixHeaderPhis() {
}
}
-VPRecipeOrVPValueTy VPRecipeBuilder::handleReplication(Instruction *I,
- VFRange &Range,
- VPlan &Pl
@@ -8999,6 +8963,18 @@ void
LoopVectorizationPlanner::adjustRecipesForReductions(
LinkVPBB->insert(FMulRecipe, CurrentLink->getIterator());
VecOp = FMulRecipe;
} else {
+auto *Blend = dyn_cast(CurrentLink);
fhahn wrote:
Done, tha
@@ -806,6 +806,19 @@ static unsigned getOpcodeForRecipe(VPRecipeBase &R) {
/// Try to simplify recipe \p R.
static void simplifyRecipe(VPRecipeBase &R, VPTypeAnalysis &TypeInfo) {
+ // Try to remove redundant blend recipes.
+ if (auto *Blend = dyn_cast(&R)) {
+bool AllEq
@@ -8999,6 +8963,18 @@ void
LoopVectorizationPlanner::adjustRecipesForReductions(
LinkVPBB->insert(FMulRecipe, CurrentLink->getIterator());
VecOp = FMulRecipe;
} else {
+auto *Blend = dyn_cast(CurrentLink);
+if (PhiR->isInLoop() && Blend)
@@ -8999,6 +8963,18 @@ void
LoopVectorizationPlanner::adjustRecipesForReductions(
LinkVPBB->insert(FMulRecipe, CurrentLink->getIterator());
VecOp = FMulRecipe;
} else {
+auto *Blend = dyn_cast(CurrentLink);
+if (PhiR->isInLoop() && Blend)
@@ -116,12 +111,11 @@ class VPRecipeBuilder {
/// Check if an existing VPValue can be used for \p Instr or a recipe can be
/// create for \p I withing the given VF \p Range. If an existing VPValue can
fhahn wrote:
Updated, thanks!
https://github.com/llvm
@@ -88,8 +86,8 @@ class VPRecipeBuilder {
/// or a new VPBlendRecipe otherwise. Currently all such phi nodes are turned
fhahn wrote:
Updated, thanks!
https://github.com/llvm/llvm-project/pull/76090
___
cfe-commits m
@@ -8292,13 +8271,13 @@ VPRecipeOrVPValueTy VPRecipeBuilder::tryToBlend(PHINode
*Phi,
for (unsigned In = 0; In < NumIncoming; In++) {
VPValue *EdgeMask =
createEdgeMask(Phi->getIncomingBlock(In), Phi->getParent(), *Plan);
-assert((EdgeMask || NumIncoming == 1
@@ -922,8 +922,23 @@ struct FormatStyle {
/// };
/// int f();
/// int f() { return 1; }
+/// int f::
HazardyKnusperkeks wrote:
I'd go with short names, and just name them like `LongName` o
@@ -587,7 +590,7 @@ bool ContinuationIndenter::mustBreak(const LineState
&State) {
!State.Line->ReturnTypeWrapped &&
// Don't break before a C# function when no break after return type.
(!Style.isCSharp() ||
- Style.AlwaysBreakAfterReturnType != FormatS
@@ -922,8 +922,23 @@ struct FormatStyle {
/// };
/// int f();
/// int f() { return 1; }
+/// int f::
+/// bar();
/// \endcode
RTBS_None,
+/// Break after return t
@@ -922,8 +922,23 @@ struct FormatStyle {
/// };
/// int f();
/// int f() { return 1; }
+/// int f::
+/// bar();
/// \endcode
RTBS_None,
+/// Break after return t
@@ -474,7 +474,7 @@ class State:
opts = sorted(opts, key=lambda x: x.name)
options_text = "\n\n".join(map(str, opts))
-with open(DOC_FILE) as f:
+with open(DOC_FILE, encoding="utf-8") as f:
HazardyKnusperkeks wrote:
Unrelated.
https://github.com/llvm/llvm-pr
HazardyKnusperkeks wrote:
> @mydeveloperday @HazardyKnusperkeks @rymiel this patch fixes a very old bug
> and will cause behavior changes whether the default is changed to the new
> `AllowShortType` or left at `None`. Which way should we go?
What would change if the default was kept at `None`?
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From fdc1e0dbec6821e292ba3da7770dbae22923db20 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Fri, 26 Jan 2024 14:20:48 +
Subject: [PATCH 1/2] [clang] - Sema::isSimpleTypeSpecifier return true
for
@@ -4754,6 +4754,11 @@ void Sema::MergeVarDecl(VarDecl *New, LookupResult
&Previous) {
return New->setInvalidDecl();
}
+ if (Old->getFormalLinkage() != New->getFormalLinkage()) {
+Diag(New->getLocation(), diag::err_multiple_linkage) << New->getDeclName();
+retu
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/79765
>From 9a07e319274f4ec2f7b12a174b7664af118de4e9 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 29 Jan 2024 08:12:35 -0600
Subject: [PATCH] [NVPTX} Add builtin support for 'globaltimer'
Summary:
This patch
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/79768
Summary:
This patch adds support for getting the 'activemask' instruction's value
without needing to use inline assembly. See the relevant PTX reference
for details.
https://docs.nvidia.com/cuda/parallel-thread-e
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: Joseph Huber (jhuber6)
Changes
Summary:
This patch adds support for getting the 'activemask' instruction's value
without needing to use inline assembly. See the relevant PTX reference
for details.
https://docs.nvidia.com/cuda/parallel-th
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Joseph Huber (jhuber6)
Changes
Summary:
This patch adds support for getting the 'activemask' instruction's value
without needing to use inline assembly. See the relevant PTX reference
for details.
https://docs.nvidia.com/cuda/parallel-thre
https://github.com/ayalz approved this pull request.
Looks good to me, thanks for cleaning this up!
Adding a couple of minor nits.
https://github.com/llvm/llvm-project/pull/76090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/ayalz edited https://github.com/llvm/llvm-project/pull/76090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -9058,6 +9026,20 @@ void
LoopVectorizationPlanner::adjustRecipesForReductions(
LinkVPBB->insert(FMulRecipe, CurrentLink->getIterator());
VecOp = FMulRecipe;
} else {
+auto *Blend = dyn_cast(CurrentLink);
+if (PhiR->isInLoop() && Blend)
@@ -100,11 +99,8 @@ class VPRecipeBuilder {
/// Check if \p I has an opcode that can be widened and return a
VPWidenRecipe
ayalz wrote:
(Indeed back to returning VPWidenRecipe as documented...)
https://github.com/llvm/llvm-project/pull/76090
@@ -9027,7 +8994,8 @@ void LoopVectorizationPlanner::adjustRecipesForReductions(
// the phi until LoopExitValue. We keep track of the previous item
// (PreviousLink) to tell which of the two operands of a Link will remain
// scalar and which will be reduced. For min
@@ -827,6 +827,16 @@ static unsigned getOpcodeForRecipe(VPRecipeBase &R) {
/// Try to simplify recipe \p R.
static void simplifyRecipe(VPRecipeBase &R, VPTypeAnalysis &TypeInfo) {
+ // Try to remove redundant blend recipes.
+ if (auto *Blend = dyn_cast(&R)) {
---
https://github.com/PiotrZSL requested changes to this pull request.
Too overengineered. There are easier ways, just check comments.
Except that, looks +- fine.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lis
@@ -0,0 +1,230 @@
+// RUN: %check_clang_tidy %s readability-use-std-min-max %t
+#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b))
+
+constexpr int myConstexprMin(int a, int b) {
+ return a < b ? a : b;
+}
+
+constexpr int myConstexprMax(int a, int b) {
+ return a > b ? a : b;
+
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,240 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
1 - 100 of 165 matches
Mail list logo
