[clang] 499507f - [clang][Interp][NFC] Remove unused function

2024-01-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-27T09:06:03+01:00 New Revision: 499507fdec8eb37dc68cee6c2b6c75557b28024e URL: https://github.com/llvm/llvm-project/commit/499507fdec8eb37dc68cee6c2b6c75557b28024e DIFF: https://github.com/llvm/llvm-project/commit/499507fdec8eb37dc68cee6c2b6c75557b28024e.diff LO

[clang] ce75cbe - [clang][Interp][NFC] Don't unnecessarily use std::optional

2024-01-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-27T09:06:04+01:00 New Revision: ce75cbeda21e3e4e5d0c47ecf44954caf98acfe8 URL: https://github.com/llvm/llvm-project/commit/ce75cbeda21e3e4e5d0c47ecf44954caf98acfe8 DIFF: https://github.com/llvm/llvm-project/commit/ce75cbeda21e3e4e5d0c47ecf44954caf98acfe8.diff LO

[clang-tools-extra] [clang] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-27 Thread Shourya Goel via cfe-commits
@@ -179,7 +179,7 @@ def err_verify_invalid_no_diags : Error< "%select{expected|'expected-no-diagnostics'}0 directive cannot follow " "%select{'expected-no-diagnostics' directive|other expected directives}0">; Sh0g0-1758 wrote: Can you please elaborate o

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-27 Thread Brad Smith via cfe-commits
brad0 wrote: Able to look at this further? https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
@@ -858,6 +859,27 @@ class PackDeductionScope { Info.PendingDeducedPacks[Pack.Index] = Pack.Outer; } + // Return the size of the saved packs if all of them has the same size. + std::optional getSavedPackSizeIfAllEqual() const { +if (Packs.size() == 0 || +

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/79683 Reapplies #78274 with the addition of a default-error warning (`strict-primary-template-shadow`) that is issued for instances of shadowing which were previously accepted prior to this patch. >From abc8f062a

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes Reapplies #78274 with the addition of a default-error warning (`strict-primary-template-shadow`) that is issued for instances of shadowing which were previously accepted prior to this patch. ---

[clang] [Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (PR #78274)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: See #79683 https://github.com/llvm/llvm-project/pull/78274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff faef68bca852d08511ea0311d8a0d221cb202e73 abc8f062add9e41ce00b9d035c796256a62859ef --

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Need to run clang-format on this and mention the flag in the release notes, but should be otherwise GTG https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread via cfe-commits
=?utf-8?q?G=C3=A1bor?= Spaits,Gabor Spaits ,Gabor Spaits Message-ID: In-Reply-To: https://github.com/cor3ntin approved this pull request. Thanks for working on this! The changes looks good to me. Will you need me to merge them on your behalf? https://github.com/llvm/llvm-project/pull/79371 _

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
@@ -6506,12 +6500,25 @@ NamedDecl *Sema::HandleDeclarator(Scope *S, Declarator &D, RemoveUsingDecls(Previous); } - if (Previous.isSingleResult() && - Previous.getFoundDecl()->isTemplateParameter()) { + // if (Previous.isSingleResult() && + //Previous.getFoun

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
@@ -6506,12 +6500,25 @@ NamedDecl *Sema::HandleDeclarator(Scope *S, Declarator &D, RemoveUsingDecls(Previous); } - if (Previous.isSingleResult() && - Previous.getFoundDecl()->isTemplateParameter()) { + // if (Previous.isSingleResult() && + //Previous.getFoun

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
spaits wrote: Thank you for reviewing. Before merge we should take a look at the CI. It still fails for libc++ 26 suite, with the same reason as before. I wanted to reproduce the issue. I built libc++ with the clang++ I compiled: ``` cmake -S "../runtimes" -GNinja \ -DLLVM_ENABLE_RUN

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: The libcxx test failure are unrelated. https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
spaits wrote: @cor3ntin I see that you have CI runs that fail with exactly the same reason as my runs: https://buildkite.com/llvm-project/clang-ci/builds/10874#018d49c2-1224-4939-9430-0e5a2be796a9 . https://github.com/llvm/llvm-project/pull/79371 __

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread via cfe-commits
=?utf-8?q?G=C3=A1bor?= Spaits,Gabor Spaits ,Gabor Spaits Message-ID: In-Reply-To: cor3ntin wrote: It's unrelated to your changes. Configuration issue on the CI, probably https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
spaits wrote: > It's unrelated to your changes. Configuration issue on the CI, probably Okay. Then I will merge this. Thank you very much for reviewing my PR and helping me. https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list

[clang] 7fcba00 - [Sema] Substitute parameter packs when deduced from function arguments (#79371)

2024-01-27 Thread via cfe-commits
Author: Gábor Spaits Date: 2024-01-27T10:43:38+01:00 New Revision: 7fcba000e90b85ce1236a1d43bebb8128332580e URL: https://github.com/llvm/llvm-project/commit/7fcba000e90b85ce1236a1d43bebb8128332580e DIFF: https://github.com/llvm/llvm-project/commit/7fcba000e90b85ce1236a1d43bebb8128332580e.diff

[clang] [Sema] Substitute parameter packs when deduced from function arguments (PR #79371)

2024-01-27 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/79371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: I have confirmed that the libcxx issues are unrelated. Feel free to merge :) https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From 391254191932c8ca325346978de5c57b233cbab8 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-27 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: How about taking a step at a time with this patch. Perhaps we should introduce the on-disk hash table infrastructure and always deserialize everything. Then we can verify that part works on our build infrastructure and then move on with the deferring the template loading. I b

[clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread Owen Pan via cfe-commits
owenca wrote: OTOH, if we change `LLVMStyle.AlwaysBreakAfterReturnType` to `RTBS_AllowShortType`, we get the following: ``` $ ninja polly-check-format [24/105] Checking format of /Users/Owe...olly/include/polly/DependenceInfo.h... FAILED: tools/polly/polly-check-format16 /Users/Owen/llvm-projec

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation PointOfInstantiation, /// that the template parameter 'PrevDecl' is being shadowed by a new /// declaration at location Loc. Returns true to indicate that this is /// an error, and false otherwise.

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
@@ -6535,6 +6543,12 @@ NamedDecl *Sema::HandleDeclarator(Scope *S, Declarator &D, if (getLangOpts().CPlusPlus) CheckExtraCXXDefaultArguments(D); + // The scope passed in may not be a decl scope. Zip up the scope tree until + // we find one that is. + while ((S->getF

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation PointOfInstantiation, /// that the template parameter 'PrevDecl' is being shadowed by a new /// declaration at location Loc. Returns true to indicate that this is /// an error, and false otherwise.

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

2024-01-27 Thread Pavel Kalugin via cfe-commits
https://github.com/p4vook converted_to_draft https://github.com/llvm/llvm-project/pull/75629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

2024-01-27 Thread Pavel Kalugin via cfe-commits
p4vook wrote: I converted the PR to draft, as this seems to be a part of a bigger problem with inserting statements into wrong nodes of the syntax tree (this seems to only show up when namespaces are present). I believe it shouldn't be fixed just by a simple check for `nullptr`. https://githu

[compiler-rt] [mlir] [llvm] [flang] [clang] [clang-tools-extra] [libunwind] [libc] [lld] [libcxx] [lldb] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (PR #79032)

2024-01-27 Thread Hristo Hristov via cfe-commits
H-G-Hristov wrote: > I tried this branch on our Windows builders although I'm not sure if it's > related or not to this patch: > > ``` > # COMPILED WITH > C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe > C:\b\s\w\ir\x\w\github-H-G-Hristov-llvm-project\libcxx\test\libcxx\fuzzing\random.pass.cpp

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: This triggers asan on bots, fix coming in the next couple hours. https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
@@ -6535,6 +6543,12 @@ NamedDecl *Sema::HandleDeclarator(Scope *S, Declarator &D, if (getLangOpts().CPlusPlus) CheckExtraCXXDefaultArguments(D); + // The scope passed in may not be a decl scope. Zip up the scope tree until + // we find one that is. + while ((S->getF

[lld] [clang-tools-extra] [libcxx] [flang] [clang] [libc] [lldb] [compiler-rt] [llvm] [VPlan] Implement cloning of VPlans. (PR #73158)

2024-01-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/73158 >From 13a26e8e7440c3b501730b22588af393a3e543cd Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 6 Jul 2023 08:07:45 +0100 Subject: [PATCH 1/4] [VPlan] Implement cloning of VPlans. This patch implements clonin

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation PointOfInstantiation, /// that the template parameter 'PrevDecl' is being shadowed by a new /// declaration at location Loc. Returns true to indicate that this is /// an error, and false otherwise.

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread via cfe-commits
https://github.com/rmarker updated https://github.com/llvm/llvm-project/pull/78011 >From a1312a0a463bb946f336977b5b01ef7afbede678 Mon Sep 17 00:00:00 2001 From: rmarker Date: Thu, 11 Jan 2024 15:01:18 +1030 Subject: [PATCH 1/7] [clang-format] Add ShortReturnTypeColumn option. --- clang/docs/C

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread via cfe-commits
rmarker wrote: Sounds good. Updated formatting in polly. https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c23608b8d58bdeb0134d99168e6d0335da2c8366 01fd15c864b01218d36f1acd86da8476cddf97c8 --

[lld] [clang-tools-extra] [libcxx] [flang] [clang] [libc] [lldb] [compiler-rt] [llvm] [VPlan] Implement cloning of VPlans. (PR #73158)

2024-01-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/73158 >From 13a26e8e7440c3b501730b22588af393a3e543cd Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 6 Jul 2023 08:07:45 +0100 Subject: [PATCH 1/5] [VPlan] Implement cloning of VPlans. This patch implements clonin

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Andrew Schenk via cfe-commits
https://github.com/schenka0 updated https://github.com/llvm/llvm-project/pull/76668 >From fd5e586d807fa4532f26188822ac5790202673bc Mon Sep 17 00:00:00 2001 From: schenka0 <154034018+schen...@users.noreply.github.com> Date: Mon, 1 Jan 2024 01:31:05 -0500 Subject: [PATCH 1/4] Check for invalid SLo

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread via cfe-commits
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation PointOfInstantiation, /// that the template parameter 'PrevDecl' is being shadowed by a new /// declaration at location Loc. Returns true to indicate that this is /// an error, and false otherwise.

[libc] [compiler-rt] [llvm] [lldb] [flang] [clang-tools-extra] [lld] [libcxx] [clang] [VPlan] Implement cloning of VPlans. (PR #73158)

2024-01-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/73158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] update list of fast tidy checks (PR #69723)

2024-01-27 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Given that the release branch for 18 was created, could the list be updated and backported, so that clangd-18 will contain the up-to-date fast-checks? https://github.com/llvm/llvm-project/pull/69723 ___ cfe-commits mailing list cfe-com

[clang] 143b510 - [Clang] Fix asan error after ad1a65fca

2024-01-27 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2024-01-27T14:35:18+01:00 New Revision: 143b510a8fefb0d203c9ac7e036aa9967dd8a2ef URL: https://github.com/llvm/llvm-project/commit/143b510a8fefb0d203c9ac7e036aa9967dd8a2ef DIFF: https://github.com/llvm/llvm-project/commit/143b510a8fefb0d203c9ac7e036aa9967dd8a2ef.diff

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: Fixed in 143b510a8fefb0d203c9ac7e036aa9967dd8a2ef https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread Jie Fu 傅杰 via cfe-commits
DamonFool wrote: lldb may also need to be fixed? ``` llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4074:11: error: enumeration value 'PackIndexing' not handled in switch [-Werror,-Wswitch] switch (qual_type->getTypeClass()) { ^ llvm-pro

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: > lldb may also need to be fixed? > > ``` > llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4074:11: > error: enumeration value 'PackIndexing' not handled in switch > [-Werror,-Wswitch] > switch (qual_type->getTypeClass()) { > ^

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

2024-01-27 Thread Krystian Stasiowski via cfe-commits
@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation PointOfInstantiation, /// that the template parameter 'PrevDecl' is being shadowed by a new /// declaration at location Loc. Returns true to indicate that this is /// an error, and false otherwise.

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-27 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From f3f2807dbbdcb81ca4bc575e0572ab49483ecdb7 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 22:54:26 +0800 Subject: [PATCH] [Clang] Implement P2718R0 "Lifetime extension in range-based for loo

[clang] [Clang][C++26] Implement Pack Indexing (P2662R3). (PR #72644)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: https://github.com/llvm/llvm-project/pull/79695 https://github.com/llvm/llvm-project/pull/72644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-27 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From 077d90133dac70d9ea83718063715aa95c2405b0 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:05:37 +0800 Subject: [PATCH] [Clang] Implement P2718R0 "Lifetime extension in range-based for loo

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-27 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From 7bb3c8f8f1e7ffebcf0abfdcbf4a70a9fe73b3ae Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:09:15 +0800 Subject: [PATCH] [Clang] Implement P2718R0 "Lifetime extension in range-based for loo

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 edited https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
@@ -0,0 +1,195 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
@@ -0,0 +1,238 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
https://github.com/felix642 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
@@ -0,0 +1,238 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Resolve FIXME in altivec.h (PR #78905)

2024-01-27 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/78905 >From f20a18d41c87443483df35314c14ecb560ad4fde Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sun, 21 Jan 2024 11:52:11 -0500 Subject: [PATCH] [clang] Resolve FIXME i

[clang] Update test intrinsic to support immediates (PR #79174)

2024-01-27 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/79174 >From c9c9c1373ac8e0d900fb4bc53f3d47c9ba6c9c39 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Tue, 23 Jan 2024 12:31:49 -0500 Subject: [PATCH] Update test intrinsic t

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-27 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From 20b860d86e1db5981b6e362a11ac3ac437a4f007 Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:25:57 +0800 Subject: [PATCH] [Clang] Implement P2718R0 "Lifetime extension in range-based for loo

[clang] [libcxx] [SemaCXX] Implement CWG2137 (list-initialization from objects of the same type) (PR #77768)

2024-01-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > As I understood the author, more time was needed to prepare the tests and > > > the fix. I just tried to bring the tip of the tree to a good state soon > > > (our internal release process was blocked on this) without putting any > > > pressure on the author. > > > >

[clang] [clang] Resolve FIXME in altivec.h (PR #78905)

2024-01-27 Thread Anton Korobeynikov via cfe-commits
asl wrote: I do not thing this is a proper fix and that it actually improves anything. "Treat as signed 5-bit literal" means that: - Only allow literal parameters - Only allow integers that would fit into 5-bit signed immediate https://github.com/llvm/llvm-project/pull/78905 _

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
wheatman wrote: @cor3ntin I tried to ask for your review since it was just what github recommended, if you can't do it, could you please suggest somebody else. Thanks. https://github.com/llvm/llvm-project/pull/78742 ___ cfe-commits mailing list cfe-c

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
@@ -19807,20 +19807,46 @@ EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum, // sufficient to contain the incremented value. If no such type // exists, the program is ill-formed. QualType T = getNextLargerIntegralType(Context, EltTy);

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
@@ -19807,20 +19807,46 @@ EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum, // sufficient to contain the incremented value. If no such type // exists, the program is ill-formed. QualType T = getNextLargerIntegralType(Context, EltTy);

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
https://github.com/cor3ntin commented: For the C changes, we should make sure we implement the relevant changes of https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3029.htm and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3030.htm https://github.com/llvm/llvm-project/pull/78742

[clang] [llvm] [clang-tools-extra] [mlir] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
https://github.com/NxPKG created https://github.com/llvm/llvm-project/pull/79697 [feat: upgrade vscode-languageclient from 8.0.2-next.5 to 9.0.1](https://github.com/llvm/llvm-project/commit/f7b4f61db6016a1a02d775efc1e921fac785e823) [fix: upgrade chokidar from 3.5.2 to 3.5.3](https://github.com/

[clang] [llvm] [clang-tools-extra] [mlir] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] 718aac9 - [clang][Diagnostics] Highlight code snippets (#66514)

2024-01-27 Thread via cfe-commits
Author: Timm Baeder Date: 2024-01-27T17:52:20+01:00 New Revision: 718aac9f7a19227b5c5ec85819a3a5ae24ce32e1 URL: https://github.com/llvm/llvm-project/commit/718aac9f7a19227b5c5ec85819a3a5ae24ce32e1 DIFF: https://github.com/llvm/llvm-project/commit/718aac9f7a19227b5c5ec85819a3a5ae24ce32e1.diff L

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] [mlir] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
https://github.com/NxPKG updated https://github.com/llvm/llvm-project/pull/79697 >From f7b4f61db6016a1a02d775efc1e921fac785e823 Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Fri, 19 Jan 2024 07:12:22 + Subject: [PATCH 1/6] feat: upgrade vscode-languageclient from 8.0.2-next.5 to 9.0.1 Snyk

[lldb] [mlir] [flang] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [lld] [llvm] [clang] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-27 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-27 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: Thanks for review! https://github.com/llvm/llvm-project/pull/73511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34dd8ec - [clang, SystemZ] Support -munaligned-symbols (#73511)

2024-01-27 Thread via cfe-commits
Author: Jonas Paulsson Date: 2024-01-27T18:29:37+01:00 New Revision: 34dd8ec8aec17965313b17308faaa6272c235c53 URL: https://github.com/llvm/llvm-project/commit/34dd8ec8aec17965313b17308faaa6272c235c53 DIFF: https://github.com/llvm/llvm-project/commit/34dd8ec8aec17965313b17308faaa6272c235c53.diff

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-27 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 closed https://github.com/llvm/llvm-project/pull/73511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/79698 This is a follow-up for the comparison of constraints on out-of-line function template definitions. We require the instantiation of a ParmVarDecl while transforming the expression if that Decl gets referenced by

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/79698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This is a follow-up for the comparison of constraints on out-of-line function template definitions. We require the instantiation of a ParmVarDecl while transforming the expression if that Decl gets reference

[clang] e976053 - [clang, SystemZ] Fix test case for buildbot.

2024-01-27 Thread Jonas Paulsson via cfe-commits
Author: Jonas Paulsson Date: 2024-01-27T19:02:36+01:00 New Revision: e976053a63c251e9b65733ed3574e5c3de62084c URL: https://github.com/llvm/llvm-project/commit/e976053a63c251e9b65733ed3574e5c3de62084c DIFF: https://github.com/llvm/llvm-project/commit/e976053a63c251e9b65733ed3574e5c3de62084c.diff

[clang] Resolve redundant predicates (PR #79701)

2024-01-27 Thread via cfe-commits
https://github.com/Rageking8 created https://github.com/llvm/llvm-project/pull/79701 Fixes #79686 >From 6d0591f238444674f327ca502a93ad72bdd46110 Mon Sep 17 00:00:00 2001 From: Rageking8 <106309953+rageki...@users.noreply.github.com> Date: Sun, 28 Jan 2024 02:06:39 +0800 Subject: [PATCH] Resolve

[clang] Resolve redundant predicates (PR #79701)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Rageking8) Changes Fixes #79686 --- Full diff: https://github.com/llvm/llvm-project/pull/79701.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+4-4) ``diff diff --git a/clang/lib/Sema/SemaChecking.c

[mlir] [clang] [llvm] Fix unsigned typos (PR #76670)

2024-01-27 Thread via cfe-commits
Rageking8 wrote: Is this PR ready to merge? https://github.com/llvm/llvm-project/pull/76670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,195 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,238 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,238 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clang] [libc] [compiler-rt] [flang] [lld] [libcxx] [libcxxabi] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[llvm] [clang] [compiler-rt] [libcxx] [clang-tools-extra] [libcxxabi] [lld] [libc] [flang] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[libcxx] [clang-tools-extra] [flang] [compiler-rt] [libc] [llvm] [libcxxabi] [lld] [clang] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[llvm] [libcxxabi] [clang] [lld] [compiler-rt] [libcxx] [flang] [libc] [clang-tools-extra] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2460,63 +2528,108 @@ void SampleProfileMatcher::runOnFunction(const Function &F) { !ProbeManager->profileIsValid(F, *FSFlattened)) { // The matching result will be saved to IRToProfileLocationMap, create a new // map for each function. +auto &IRToProfile

[clang-tools-extra] [clang] [libc] [flang] [libcxxabi] [libcxx] [lld] [llvm] [compiler-rt] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { WenleiHe wrote: I was mostly thinking about a simple struct to encapsulate different stats, while

[libcxx] [llvm] [lld] [libc] [flang] [clang-tools-extra] [clang] [compiler-rt] [libcxxabi] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[flang] [lld] [clang] [libcxxabi] [compiler-rt] [libc] [llvm] [clang-tools-extra] [libcxx] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[libc] [lld] [llvm] [compiler-rt] [libcxx] [flang] [clang-tools-extra] [libcxxabi] [clang] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[libc] [libcxx] [lld] [compiler-rt] [flang] [clang] [libcxxabi] [llvm] [clang-tools-extra] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[flang] [lld] [clang] [libcxxabi] [compiler-rt] [libc] [llvm] [clang-tools-extra] [libcxx] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang-tools-extra] [mlir] [clang] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
https://github.com/NxPKG updated https://github.com/llvm/llvm-project/pull/79697 >From f7b4f61db6016a1a02d775efc1e921fac785e823 Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Fri, 19 Jan 2024 07:12:22 + Subject: [PATCH 1/6] feat: upgrade vscode-languageclient from 8.0.2-next.5 to 9.0.1 Snyk

  1   2   >