https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/5] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/77406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/banach-space edited
https://github.com/llvm/llvm-project/pull/77365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/banach-space approved this pull request.
LGTM, this is very thoroughly tested and documented now, thank you 🙏🏻👌🏻
Feel free to ignore my final suggestion.
https://github.com/llvm/llvm-project/pull/77365
___
cfe-commits mailing list
c
banach-space wrote:
This is great, thanks! I do wonder though - why limit it to Darwin? 🤔
https://github.com/llvm/llvm-project/pull/77365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
banach-space wrote:
Love this cleanup!
https://github.com/llvm/llvm-project/pull/77365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dwblaikie wrote:
looking good from what I've tested - thanks again!
https://github.com/llvm/llvm-project/pull/72235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dschuff approved this pull request.
Thanks for the fix!
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/gedare updated
https://github.com/llvm/llvm-project/pull/77522
>From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Mon, 17 Jul 2023 18:24:30 -0600
Subject: [PATCH 1/2] Add SpaceInParensOption for __attribute__ keyword
The __attrib
https://github.com/gedare edited https://github.com/llvm/llvm-project/pull/77522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -839,9 +839,11 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I)
{
unsigned Reg;
-if (Attrs.hasParamAttr(I, Attribute::SExt))
+if (Attrs.hasParamAttr(I, Attribute::SExt) ||
+(IsDirect && Func->hasParamAttribute(I, Attribute::SExt)))
---
aqjune wrote:
I will be back from office in a few hours and check whether I can use
CallBase::paramHasAttr. Could you wait a bit until then?
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/gedare updated
https://github.com/llvm/llvm-project/pull/77522
>From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001
From: Gedare Bloom
Date: Mon, 17 Jul 2023 18:24:30 -0600
Subject: [PATCH 1/4] Add SpaceInParensOption for __attribute__ keyword
The __attrib
ilovepi wrote:
sounds good. I'll go ahead and close this in favor of
https://github.com/llvm/llvm-project/pull/77516 then, and leave the LLVM PR
alone.
https://github.com/llvm/llvm-project/pull/66916
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/66916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
As @MaskRay pointed out in #66916, there's a bit too much context in this
review, so please just ignore my earlier question about moving to a stacked PR.
https://github.com/llvm/llvm-project/pull/66915
___
cfe-commits mailing list
cfe-
@@ -11,6 +11,7 @@
//===--===//
#include "SystemZ.h"
+#include "clang/AST/Decl.h"
JonPsson1 wrote:
What is the motivation for this? I mean, is there any general consensus that
this really sh
https://github.com/mstorsjo created
https://github.com/llvm/llvm-project/pull/77534
This applies the same change as in
760261a3daf98882ccbd177e3133fb4a058f47ad (where they were applied to libcxxabi
and libcxx) to libunwind as well.
These options can reasonably be set either as an absolute or r
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Author: Martin Storsjö (mstorsjo)
Changes
This applies the same change as in
760261a3daf98882ccbd177e3133fb4a058f47ad (where they were applied to libcxxabi
and libcxx) to libunwind as well.
These options can reasonably be set either as an abs
https://github.com/mstorsjo created
https://github.com/llvm/llvm-project/pull/77536
If using multiarch directories with musl, the multiarch directory still uses
*-linux-gnu triples - which may or may not be intentional, while it is somewhat
consistent at least.
However, for musl armhf targets
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Martin Storsjö (mstorsjo)
Changes
If using multiarch directories with musl, the multiarch directory still uses
*-linux-gnu triples - which may or may not be intentional, while it is somewhat
consistent at least.
However, for musl
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Martin Storsjö (mstorsjo)
Changes
If using multiarch directories with musl, the multiarch directory still uses
*-linux-gnu triples - which may or may not be intentional, while it is somewhat
consistent at least.
However, for musl armhf t
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/14] [libc++] Implement ranges::contains_subrange
---
libcxx
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 01/15] [libc++] Implement ranges::contains_subrange
---
libcxx
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/77534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/77534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/77536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
darkfeline wrote:
@d0k @r4nt @kirillbobyrev @jpienaar tagging people based on git blame on the
files, apologies in advance if you aren't the right persons for this.
https://github.com/llvm/llvm-project/pull/76110
___
cfe-commits mailing list
cfe-commi
bwendling wrote:
@kees, the issue should be fixed with the newest push.
https://github.com/llvm/llvm-project/pull/76348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5495,14 +5495,12 @@ static void TryOrBuildParenListInitialization(
return;
}
// ...and value-initialized for each k < i <= n;
-if (ArrayLength > Args.size()) {
efriedma-quic wrote:
What is this change supposed to do?
The existing cod
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer(
return true;
};
+ const InitListExpr *ILE = dyn_cast(Init);
+ const CXXParenListInitExpr *CPLIE = dyn_cast(Init);
+ const StringLiteral *SL = dyn_cast(Init);
// If the initializer is an initiali
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/77537
Part of https://reviews.llvm.org/D158218
GCC_INSTALL_PREFIX is a rarely-used legacy option inherited from
pre-CMake build system and has configuration file replacement nowadays.
Many `clang/test/Driver` tests spe
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
Part of https://reviews.llvm.org/D158218
GCC_INSTALL_PREFIX is a rarely-used legacy option inherited from
pre-CMake build system and has configuration file replacement nowadays.
Many `clang/test/Driver` tests
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/77312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar approved this pull request.
I'm in favor of removing this. It doesn't make a lot of sense now that we have
better config file support.
https://github.com/llvm/llvm-project/pull/77537
___
cfe-commits mailing list
cfe-commit
MaskRay wrote:
`bool isEABIHF` from clang/lib/CodeGen/Targets/ARM.cpp can probably be factored.
https://github.com/llvm/llvm-project/pull/77536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
shafik wrote:
> ping @shafik @cor3ntin @ChuanqiXu9, how can we make progress here?
Please add a release note and address my previous comment:
https://github.com/llvm/llvm-project/pull/69076#issuecomment-1780327252
CC @cor3ntin
https://github.com/llvm/llvm-project/pull/69076
_
dschuff wrote:
Yeah, sorry I missed Alex's suggestion there. There's no hurry.
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/2] [LLVM][DWARF] Fix accelerator swtiching with TU re-us
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/3] [LLVM][DWARF] Fix accelerator swtiching with TU re-us
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/77511
>From 5e6ee63fabac0dabc692c00d3c017e2542c98273 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Tue, 9 Jan 2024 10:51:55 -0800
Subject: [PATCH 1/4] [LLVM][DWARF] Fix accelerator swtiching with TU re-us
kees wrote:
> @kees, the issue should be fixed with the newest push.
Nice! This is so extremely close. It fixed all but 1 instance in the torture
testing. The remaining seems to be union order sensitive. O_o This arrangement
still reports non-zero for the `int count_bytes` one, unless I move i
https://github.com/aqjune updated
https://github.com/llvm/llvm-project/pull/77281
>From 1bbfe05bc50e1fbdb207f21a178b6fc7ab24e8cf Mon Sep 17 00:00:00 2001
From: Juneyoung Lee
Date: Mon, 8 Jan 2024 02:01:41 -0600
Subject: [PATCH 1/3] [WebAssembly] Correctly consider signext/zext arg flags
at fun
https://github.com/aqjune updated
https://github.com/llvm/llvm-project/pull/77281
>From 1bbfe05bc50e1fbdb207f21a178b6fc7ab24e8cf Mon Sep 17 00:00:00 2001
From: Juneyoung Lee
Date: Mon, 8 Jan 2024 02:01:41 -0600
Subject: [PATCH 1/3] [WebAssembly] Correctly consider signext/zext arg flags
at fun
aqjune wrote:
I updated it to use the paramHasAttr which passed my test as it supposed to do
so. :) Thanks for suggestion.
https://github.com/llvm/llvm-project/pull/77281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/HighCommander4 approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/77504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nour1248
Date: 2024-01-09T18:58:38-05:00
New Revision: feb49bb42433c55a206489d4c8dafd940c019e30
URL:
https://github.com/llvm/llvm-project/commit/feb49bb42433c55a206489d4c8dafd940c019e30
DIFF:
https://github.com/llvm/llvm-project/commit/feb49bb42433c55a206489d4c8dafd940c019e30.diff
LOG:
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/77504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS
Support
TargetParser
FrontendOpenMP
+ FrontendDriver
topperc wrote:
I've very confused by naming of the library. It's called FrontendDriver but is
currently important by clang's CodeGen library rather than the d
https://github.com/topperc deleted
https://github.com/llvm/llvm-project/pull/77327
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2,6 +2,7 @@ set(LLVM_LINK_COMPONENTS
Support
TargetParser
FrontendOpenMP
+ FrontendDriver
topperc wrote:
Ignore the earlier comment I wrote here I misread CodeGenOptions.cpp.
This is currently important into the clang Driver library which makes sen
Author: Ding Fei
Date: 2024-01-10T08:49:36+08:00
New Revision: 46944210ebd93765b068eeba22bd3e337099af3e
URL:
https://github.com/llvm/llvm-project/commit/46944210ebd93765b068eeba22bd3e337099af3e
DIFF:
https://github.com/llvm/llvm-project/commit/46944210ebd93765b068eeba22bd3e337099af3e.diff
LOG:
https://github.com/danix800 closed
https://github.com/llvm/llvm-project/pull/77434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -380,14 +380,14 @@ void RISCVIntrinsicManagerImpl::InitRVVIntrinsic(
OverloadedName += "_" + OverloadedSuffixStr.str();
// clang built-in function name, e.g. __builtin_rvv_vadd.
- std::string BuiltinName = "__builtin_rvv_" + std::string(Record.Name);
+ std::string B
@@ -463,7 +464,7 @@ void
RISCVIntrinsicManagerImpl::CreateRVVIntrinsicDecl(LookupResult &LR,
bool RISCVIntrinsicManagerImpl::CreateIntrinsicIfFound(LookupResult &LR,
IdentifierInfo *II,
@@ -463,7 +464,7 @@ void
RISCVIntrinsicManagerImpl::CreateRVVIntrinsicDecl(LookupResult &LR,
bool RISCVIntrinsicManagerImpl::CreateIntrinsicIfFound(LookupResult &LR,
IdentifierInfo *II,
@@ -416,8 +416,10 @@ class RVVIntrinsic {
RVVTypePtr getOutputType() const { return OutputType; }
const RVVTypes &getInputTypes() const { return InputTypes; }
llvm::StringRef getBuiltinName() const { return BuiltinName; }
- llvm::StringRef getName() const { return Name;
bwendling wrote:
> > @kees, the issue should be fixed with the newest push.
>
> Nice! This is so extremely close. It fixed all but 1 instance in the torture
> testing. The remaining seems to be union order sensitive. O_o This
> arrangement still reports non-zero for the `int count_bytes` one,
kees wrote:
Accessing `mi->ints` is unambiguous (it would use the declared `count_ints`)
but I'm fine to wait and fix that later. The flex array union is gloriously
rare in the kernel. As for whole object, I say pick smallest from all available
under bdos(x, 1) and largest for bdos(x, 0), or j
MaskRay wrote:
Nice filtering!
https://github.com/llvm/llvm-project/pull/77406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bwendling wrote:
Like I said, I can fix the `mi->ints` issue. It's when we're trying to ask for
the size of the whole struct with more than one `__counted_by` attribute that
we don't be able to handle.
https://github.com/llvm/llvm-project/pull/76348
yingcong-wu wrote:
Thank you very much.
https://github.com/llvm/llvm-project/pull/77058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/6] [clang] Fix parenthesized list initialization of arrays
not wor
@@ -5495,14 +5495,12 @@ static void TryOrBuildParenListInitialization(
return;
}
// ...and value-initialized for each k < i <= n;
-if (ArrayLength > Args.size()) {
alanzhao1 wrote:
> What is this change supposed to do?
`CodeGenFunction::
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer(
return true;
};
+ const InitListExpr *ILE = dyn_cast(Init);
+ const CXXParenListInitExpr *CPLIE = dyn_cast(Init);
+ const StringLiteral *SL = dyn_cast(Init);
// If the initializer is an initiali
@@ -100,6 +100,11 @@ ExternalASTSource::FindExternalVisibleDeclsByName(const
DeclContext *DC,
return false;
}
+void ExternalASTSource::LoadExternalSpecializations(
+const Decl *D, ArrayRef TemplateArgs) {
+ return;
ChuanqiXu9 wrote:
Will do in the nex
ChuanqiXu9 wrote:
> Have you run that patch on bigger workflows? Do we have some performance
> numbers to compare?
I've tested it functionality in our largest workload about modules. It runs
well. But our uses of modules don't have a lot of complexities while it has a
large scale. For perform
KanRobert wrote:
cc @FreddyLeaf
https://github.com/llvm/llvm-project/pull/77525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd edited
https://github.com/llvm/llvm-project/pull/77255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/77255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2210,7 +2219,11 @@ CGObjCGNU::CGObjCGNU(CodeGenModule &cgm, unsigned
runtimeABIVersion,
// void objc_exception_throw(id);
ExceptionThrowFn.init(&CGM, "objc_exception_throw", VoidTy, IdTy);
- ExceptionReThrowFn.init(&CGM, "objc_exception_throw", VoidTy, IdTy);
+ if (
https://github.com/phoebewang approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/77525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/FreddyLeaf approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/77525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yingopq wrote:
@topperc Could you help review this patch? Thanks.
https://github.com/llvm/llvm-project/pull/77291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Yujinmon updated
https://github.com/llvm/llvm-project/pull/77479
>From b5586e9935d30a587323699aac2213bae5d14174 Mon Sep 17 00:00:00 2001
From: Yujin <78896558+yujin...@users.noreply.github.com>
Date: Tue, 9 Jan 2024 23:14:52 +0900
Subject: [PATCH 1/3] fixed typo error about se
benshi001 wrote:
> I have already a patch to add these functions: #76979. The conditions for
> `fputc` are not the same, this can be clarified at the other patch.
I see. It would be better to close this PR, and supplement my parts in your PR.
https://github.com/llvm/llvm-project/pull/77435
___
https://github.com/benshi001 closed
https://github.com/llvm/llvm-project/pull/77435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/KanRobert approved this pull request.
https://github.com/llvm/llvm-project/pull/77525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ecnelises updated
https://github.com/llvm/llvm-project/pull/77412
>From 87e1d4acdd87d45f265e590ad135e21f352dc5ad Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
Date: Tue, 9 Jan 2024 13:33:56 +0800
Subject: [PATCH 1/2] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128
ppc_fp128 value
Author: Vitaly Buka
Date: 2024-01-09T18:37:04-08:00
New Revision: a828cda9c80282a77b579f8fc9dc17a310173af4
URL:
https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4
DIFF:
https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4.diff
L
Author: Vitaly Buka
Date: 2024-01-09T18:37:04-08:00
New Revision: a828cda9c80282a77b579f8fc9dc17a310173af4
URL:
https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4
DIFF:
https://github.com/llvm/llvm-project/commit/a828cda9c80282a77b579f8fc9dc17a310173af4.diff
L
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 061e4f24b24a3b59d73a94dc6f2f0d21a2b7beac
557604301ab98d89b5ddf6d857d85326d7d3da3d --
FantasqueX wrote:
Gently ping~
https://github.com/llvm/llvm-project/pull/76719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
h-vetinari wrote:
Gentle ping @llvm/pr-subscribers-clang, could someone have a look and merge
this? 🙃
https://github.com/llvm/llvm-project/pull/76418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/antangelo created
https://github.com/llvm/llvm-project/pull/77552
Fixes a crash where the template argument depth computed in the semantic
context for a friend FunctionDecl with a constrained parameter is compared
against arguments in the lexical context for the purpose of c
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (antangelo)
Changes
Fixes a crash where the template argument depth computed in the semantic
context for a friend FunctionDecl with a constrained parameter is compared
against arguments in the lexical context for the purpose of check
@@ -68,8 +68,18 @@ define dso_local zeroext i32 @func(double noundef %0, double
noundef %1) #0 {
; CHECK-LABEL: __adddf3
}
+; To check ppc_fp128 soften without crash
+define zeroext i1 @ppcf128_soften(ppc_fp128 %a) #0 {
+entry:
+ %fpclass = tail call i1 @llvm.is.fpcla
@@ -2315,6 +2315,8 @@ bool UnwrappedLineParser::tryToParseLambdaIntroducer() {
if (Next->is(tok::greater))
return false;
}
+ if (tok::isLiteral(FormatTok->Tok.getKind()))
+return false;
owenca wrote:
```suggestion
```
Instead, I would change l
owenca wrote:
Please add an assertion in `WhitespaceManager.h`:
```
--- a/clang/lib/Format/WhitespaceManager.h
+++ b/clang/lib/Format/WhitespaceManager.h
@@ -282,6 +282,7 @@ private:
for (auto PrevIter = Start; PrevIter != End; ++PrevIter) {
// If we broke the line the initial spaces
@@ -17,6 +17,13 @@ def HasStdExtZicsr :
Predicate<"Subtarget->hasStdExtZicsr()">,
AssemblerPredicate<(all_of FeatureStdExtZicsr),
"'Zicsr' (CSRs)">;
+def FeatureStdExtI
+: SubtargetFeature<"i", "HasStdExtI",
arsenm wrote:
ping @krzysz00
https://github.com/llvm/llvm-project/pull/75647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -83,13 +88,14 @@ RISCVRegisterInfo::getCalleeSavedRegs(const MachineFunction
*MF) const {
}
BitVector RISCVRegisterInfo::getReservedRegs(const MachineFunction &MF) const {
+ const RISCVSubtarget &STI = MF.getSubtarget();
wangpc-pp wrote:
This should be a
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion,
Style);
}
+TEST_F(FormatTestMacroExpansion, CommaAsOperator) {
+ FormatStyle Style = getGoogleStyle();
+ Style.ColumnLimit = 42;
owenca wrote:
```suggestion
FormatStyle Style =
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion,
Style);
}
+TEST_F(FormatTestMacroExpansion, CommaAsOperator) {
+ FormatStyle Style = getGoogleStyle();
+ Style.ColumnLimit = 42;
+ Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c");
+ veri
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion,
Style);
}
+TEST_F(FormatTestMacroExpansion, CommaAsOperator) {
+ FormatStyle Style = getGoogleStyle();
+ Style.ColumnLimit = 42;
+ Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c");
+ veri
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion,
Style);
}
+TEST_F(FormatTestMacroExpansion, CommaAsOperator) {
+ FormatStyle Style = getGoogleStyle();
+ Style.ColumnLimit = 42;
+ Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c");
+ veri
@@ -255,6 +255,41 @@ TEST_F(FormatTestMacroExpansion,
Style);
}
+TEST_F(FormatTestMacroExpansion, CommaAsOperator) {
+ FormatStyle Style = getGoogleStyle();
+ Style.ColumnLimit = 42;
+ Style.Macros.push_back("MACRO(a, b, c)=a=(b); if(x) c");
+ veri
@@ -985,9 +1003,10 @@ void
RISCVFrameLowering::determineCalleeSaves(MachineFunction &MF,
};
for (auto Reg : CSRegs)
- SavedRegs.set(Reg);
+ if (Reg < RISCV::X16 || !Subtarget.isRVE())
wangpc-pp wrote:
The psABI says:
> If used with an ISA t
401 - 500 of 566 matches
Mail list logo
