[llvm] [clang] [llvm] Add support for building on illumos (PR #74930)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/74930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [llvm] Add support for building on illumos (PR #74930)

MaskRay wrote: `[CMake]` may be a good tag. https://github.com/llvm/llvm-project/pull/74930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/77214 From 8f1370aae4db2048c35516a85fb72c742557942b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 7 Jan 2024 00:13:08 +0100 Subject: [PATCH] [coverage] fix incorrect coverage repo

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/77214 From bde3362e609a129f410890745b1dcfd635ba2ec0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 7 Jan 2024 00:13:08 +0100 Subject: [PATCH] [coverage] fix incorrect coverage repo

[clang] [OpenMP] Change `__tgt_device_image` to point to the image (PR #77003)

@@ -19,8 +19,8 @@ // OPENMP-COFF: @__start_omp_offloading_entries = hidden constant [0 x %struct.__tgt_offload_entry] zeroinitializer, section "omp_offloading_entries$OA" // OPENMP-COFF-NEXT: @__stop_omp_offloading_entries = hidden constant [0 x %struct.__tgt_offload_ent

[clang] [libcxx] [llvm] Reapply "[libc++][streams] P1759R6: Native handles and file streams" (PR #77190)

Zingam wrote: > I test run it with C++26 on Windows, it clears the test failures happened in > the original PR. Thank you! https://github.com/llvm/llvm-project/pull/77190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

@@ -7732,7 +7732,8 @@ TreeTransform::TransformIfStmt(IfStmt *S) { if (Then.isInvalid()) return StmtError(); } else { -Then = new (getSema().Context) NullStmt(S->getThen()->getBeginLoc()); +Then = new (getSema().Context) +CompoundStmt(S->getThen()->ge

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/cor3ntin commented: Thanks for the patch! I think this might need a release note (referencing the couple open issues about this bug), and probably some tests. https://github.com/llvm/llvm-project/pull/77214 ___ cfe-commits mailing

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/77214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

@@ -1631,8 +1631,10 @@ class CompoundStmt final SourceLocation RB); // Build an empty compound statement with a location. - explicit CompoundStmt(SourceLocation Loc) - : Stmt(CompoundStmtClass), LBraceLoc(Loc), RBraceLoc(Loc) { + explicit

[clang] [clang-format] Fix crash involving array designators and dangling comma (PR #77045)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/77045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

hanickadot wrote: Fixes https://github.com/llvm/llvm-project/issues/54419. https://github.com/llvm/llvm-project/pull/77214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c82c54a - [Clang][NFC] Fix trailing whitespace in ReleaseNotes.rst

Author: cor3ntin Date: 2024-01-07T11:19:16+01:00 New Revision: c82c54a1ef89ebd4903adfd977dabd34718a136e URL: https://github.com/llvm/llvm-project/commit/c82c54a1ef89ebd4903adfd977dabd34718a136e DIFF: https://github.com/llvm/llvm-project/commit/c82c54a1ef89ebd4903adfd977dabd34718a136e.diff LOG:

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

@@ -1631,8 +1631,10 @@ class CompoundStmt final SourceLocation RB); // Build an empty compound statement with a location. - explicit CompoundStmt(SourceLocation Loc) - : Stmt(CompoundStmtClass), LBraceLoc(Loc), RBraceLoc(Loc) { + explicit

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/77214 From 1891847f50311c4ffbaa40577900eca2245c0a7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 7 Jan 2024 00:13:08 +0100 Subject: [PATCH] [coverage] fix incorrect coverage repo

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

cor3ntin wrote: Adding a few folks to the review (We do not seem to update the coverage mapping very often) https://github.com/llvm/llvm-project/pull/77214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

@@ -7732,7 +7732,8 @@ TreeTransform::TransformIfStmt(IfStmt *S) { if (Then.isInvalid()) return StmtError(); } else { -Then = new (getSema().Context) NullStmt(S->getThen()->getBeginLoc()); +Then = new (getSema().Context) +CompoundStmt(S->getThen()->ge

[clang-tools-extra] [clang] [llvm] [compiler-rt] fix wrong links in documentation (PR #76502)

https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/76502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/77214 From fb2efdecce3a629c801d1f179297b1189e1ec287 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 7 Jan 2024 00:13:08 +0100 Subject: [PATCH] [coverage] fix incorrect coverage repo

[llvm] [clang] [clang-tools-extra] [compiler-rt] [lldb] [mlir] Fix Multiple Build Errors on different platforms (PR #77216)

https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/77216 >From a1156a564c798192cb7608e28ce9b9ed846a8b1c Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sat, 6 Jan 2024 20:21:06 -0500 Subject: [PATCH 1/2] Fix Multiple Build Errors on different platforms Particularly f

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/77194 >From 3c8dfcf96e732f4546f8019c0111fd873b233162 Mon Sep 17 00:00:00 2001 From: 11happy Date: Mon, 1 Jan 2024 19:53:45 +0530 Subject: [PATCH 01/28] Changed Checks from TriviallyCopyable to TriviallyCopyConstructib

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

@@ -870,9 +870,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ -- Fixed a bug where Template Instantiation failed to handle Lambda Express

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

@@ -870,9 +870,9 @@ Bug Fixes to AST Handling - Fixed a bug where RecursiveASTVisitor fails to visit the initializer of a bitfield. `Issue 64916 `_ -- Fixed a bug where Template Instantiation failed to handle Lambda Express

[libcxx] [llvm] [clang] "Reapply "[Sema] Fix crash on invalid code with parenthesized aggrega… (PR #76833)

mordante wrote: > @mordante The lines could be changed to `// expected-error-re@*:* 0-1 > (excess elements in struct initializer|no matching constructor for > initialization of)}}{{.*` to still have coverage. FWIW the `{{.*}}` at > the end seems to be redundant too. Totally forgot usi

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

chfast wrote: > But in future it would be useful to mark whole gap there as skipped instead. > If there is interest I would do it in another PR. This would be very useful not to treat compile-time unreachable code as uncovered. Can the skipped code be marked separately in the reports? https:/

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

https://github.com/cor3ntin approved this pull request. LGTM. Congratulation on your first contribution! https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #77194)

11happy wrote: Thanks, I am really grateful for your guidance. https://github.com/llvm/llvm-project/pull/77194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [mlir] [llvm] [libc] [NFC][ObjectSizeOffset] Use classes instead of std::pair (PR #76882)

bwendling wrote: > Hi @bwendling, your change to MemoryBuiltins.h is hitting an error in the > version of Visual Studio 2019 that we use internally to build: > > ``` > C:\j\w\779ddbee\p\llvm\include\llvm/Analysis/MemoryBuiltins.h(217): error > C2990: 'llvm::SizeOffsetType': non-class template

[libc] [llvm] [mlir] [clang] [lldb] [NFC][ObjectSizeOffset] Use classes instead of std::pair (PR #76882)

bwendling wrote: Actually, that fix was making all of the other builds fail: ``` /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Analysis/MemoryBuiltins.h:279:47: error: specialization of ‘llvm::SizeOffsetType’ after instantiation 279 | template friend class SizeOffsetType; |

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

hanickadot wrote: Yes, and it will be a bit bigger change. This is currently my biggest change yet :) But I want to do it as next. This fix's intention is to make the source location of regions properly done. https://github.com/llvm/llvm-project/pull/77214 _

[clang] [clang][coverage] fixing "if constexpr" and "if consteval" coverage report (PR #77214)

https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/77214 From 5aa041529997724e19109c45cf1483eb72d7dab6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Sun, 7 Jan 2024 00:13:08 +0100 Subject: [PATCH] [coverage] fix incorrect coverage repo

[clang] [llvm] Revert "InstCombine: Fold is.fpclass(x, fcInf) to fabs+fcmp" (PR #76338)

https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/76338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Change `__tgt_device_image` to point to the image (PR #77003)

@@ -19,8 +19,8 @@ // OPENMP-COFF: @__start_omp_offloading_entries = hidden constant [0 x %struct.__tgt_offload_entry] zeroinitializer, section "omp_offloading_entries$OA" // OPENMP-COFF-NEXT: @__stop_omp_offloading_entries = hidden constant [0 x %struct.__tgt_offload_ent

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions &Opts, if (Opts.RWPI) Builder.defineMacro("__ARM_RWPI", "1"); + // Macros for enabling co-proc intrinsics + uint64_t FeatureCoprocBF = 0; + switch (ArchKind) { + default: +break; + case

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

davemgreen wrote: If you can make armv9-a work the same as armv8-a and add some tests for it then this LGTM https://github.com/llvm/llvm-project/pull/75440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] 8f76f18 - [OpenMP][Obvious] Fix test failing on BE architectures

Author: Joseph Huber Date: 2024-01-07T08:38:50-06:00 New Revision: 8f76f1816ea63b7cc28e150ba319ffbfe6351f9e URL: https://github.com/llvm/llvm-project/commit/8f76f1816ea63b7cc28e150ba319ffbfe6351f9e DIFF: https://github.com/llvm/llvm-project/commit/8f76f1816ea63b7cc28e150ba319ffbfe6351f9e.diff

[clang-tools-extra] [clangd] don't lower severity of clang-tidy modernize-* checks to remarks (PR #75706)

marzojr wrote: Coming from the issue I posted on `vscode-clangd`, I think it was a bad decision to make `modernize-*` checks basically disappear from the GUI. I feel less strongly with regards to `misc-unused-*` checks, but it is probably also true for those. While trying to remove clutter is

[clang] [flang] [Flang][Driver] Enable gpulibc/nogpulibc options for Flang, which allows linking of GPU LIBC for the fortran and OpenMP runtime (PR #77135)

banach-space wrote: Thanks for the discussion! > It defaults to on if it finds the `libc` wrapper headers in the `clang` > resource directory, > `lib/clang/18/include/llvm_libc_wrappers/llvm-libc-decls`. I'm assuming that > Fortran doesn't have this? It shouldn't, which means that the semant

[lldb] [clang] [libcxx] [llvm] [clang-tools-extra] [compiler-rt] [mlir] Fix Multiple Build Errors on different platforms (PR #77216)

https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/77216 >From a1156a564c798192cb7608e28ce9b9ed846a8b1c Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sat, 6 Jan 2024 20:21:06 -0500 Subject: [PATCH 1/2] Fix Multiple Build Errors on different platforms Particularly f

[clang] [libcxx] [llvm] Reapply "[libc++][streams] P1759R6: Native handles and file streams" (PR #77190)

Zingam wrote: I'm relanding this and I'll keep eyes on it here: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64 https://github.com/llvm/llvm-project/pull/77190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [libcxx] [llvm] Reapply "[libc++][streams] P1759R6: Native handles and file streams" (PR #77190)

https://github.com/Zingam closed https://github.com/llvm/llvm-project/pull/77190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [lldb] [clang] [libcxx] [compiler-rt] [llvm] [mlir] Fix Multiple Build Errors on different platforms (PR #77216)

https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/77216 >From a1156a564c798192cb7608e28ce9b9ed846a8b1c Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sat, 6 Jan 2024 20:21:06 -0500 Subject: [PATCH 1/2] Fix Multiple Build Errors on different platforms Particularly f

[flang] [llvm] [clang-tools-extra] [libc] [libcxx] [clang] [compiler-rt] [libc++] Implement LWG3940: std::expected::value() also needs E to be copy constructible (PR #71819)

@@ -0,0 +1,51 @@ +//===--===// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2

[compiler-rt] [flang] [llvm] [libcxx] [clang-tools-extra] [libc] [clang] [libc++] Implement LWG3940: std::expected::value() also needs E to be copy constructible (PR #71819)

@@ -1150,12 +1150,15 @@ class expected<_Tp, _Err> { } _LIBCPP_HIDE_FROM_ABI constexpr void value() const& { +static_assert(is_copy_constructible_v<_Err>); if (!__has_val_) { std::__throw_bad_expected_access<_Err>(__union_.__unex_); } } _LIBCPP_

[libcxx] [flang] [clang-tools-extra] [compiler-rt] [llvm] [libc] [clang] [libc++] Implement LWG3940: std::expected::value() also needs E to be copy constructible (PR #71819)

https://github.com/mordante commented: > The CI finally passed now : ) Great. A few minor comment and then it LGTM. I'll leave the final approval to @huixie90 https://github.com/llvm/llvm-project/pull/71819 ___ cfe-commits mailing list cfe-commits@l

[compiler-rt] [libcxx] [llvm] [clang] [flang] [libc] [clang-tools-extra] [libc++] Implement LWG3940: std::expected::value() also needs E to be copy constructible (PR #71819)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/71819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

https://github.com/arichardson commented: While I think this is a reasonable change, I don't think we can change this function signature without breaking the ABI. So it probably needs to be a new function instead. https://github.com/llvm/llvm-project/pull/77185

[llvm] [compiler-rt] [libcxx] [clang] [mlir] [asan] Enable StackSafetyAnalysis by default (PR #77210)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/77210 >From af33fcdf5a46c5bd34db89615a037e5eca421ef9 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Fri, 5 Jan 2024 23:50:40 -0800 Subject: [PATCH] [asan] Enable StackSafetyAnalysis by default StackSafetyAnalysis d

[clang] [llvm] [compiler-rt] [libcxx] [mlir] [asan] Enable StackSafetyAnalysis by default (PR #77210)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/77210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add -fandroid-pad-segment/-fno-android-pad-segment (PR #77244)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/77244 -fandroid-pad-segment is an Android-specific opt-in option that links in crt_pad_segment.o. crt_pad_segment.o contains a note section, which will be included in the linker-created PT_NOTE segment. This PT_NOTE te

[libunwind] [libunwind] Add length info for dynamic .eh_frame registration (PR #77185)

https://github.com/lhames requested changes to this pull request. As @arichardson noted this would break the ABI. The best solution is to fix the implementation of `__unw_add_dynamic_eh_frame_section` (and `__unw_remove_dynamic_eh_frame_section`) as described in https://github.com/llvm/llvm-p

[clang-tools-extra] [clang-tidy] Add support for lambdas in cppcoreguidelines-owning-memory (PR #77246)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/77246 Implement proper support for lambdas and sub-functions/classes. Moved from https://reviews.llvm.org/D157285 Fixes: #59389 >From b2e230f90f97c0fb3385ab05d0217371b72b9a88 Mon Sep 17 00:00:00 2001 From: Piotr Zega

[clang-tools-extra] [clang-tidy] Add support for lambdas in cppcoreguidelines-owning-memory (PR #77246)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Implement proper support for lambdas and sub-functions/classes. Moved from https://reviews.llvm.org/D157285 Fixes: #59389 --- Full diff: https://github.com/llvm/llvm-project/pull/77246.diff 3 Files Af

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Abhinkop wrote: add runs for -std=cNN for all remaining 5 of them? and also add extra test cases where conflicts arise? https://github.com/llvm/llvm-project/pull/77178 ___

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Endilll wrote: Yes, more `RUN` lines with different `-std=` options, and potentially more `expected` directives tailored for particular language mode. We have an example of this in C++ defect

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[llvm] [clang] [lld] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

@@ -719,60 +730,83 @@ decodeBBAddrMapImpl(const ELFFile &EF, Feature = Data.getU8(Cur); // Feature byte if (!Cur) break; - auto FeatEnableOrErr = PGOAnalysisMap::Features::decode(Feature); + auto FeatEnableOrErr = BBAddrMap::Features::decode(Featur

[lld] [clang] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

https://github.com/red1bluelost edited https://github.com/llvm/llvm-project/pull/74128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

https://github.com/red1bluelost commented: Overall looks good to me so far, just two minor things and the merge conflict. https://github.com/llvm/llvm-project/pull/74128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[llvm] [clang] [lld] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

@@ -0,0 +1,89 @@ +; COM: Emitting basic-block-address-map when machine function splitting is enabled. +; RUN: llc < %s -mtriple=x86_64 -function-sections -split-machine-functions -basic-block-address-map | FileCheck %s --check-prefixes=CHECK,BASIC + +; COM: Emitting basic-block-

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

@@ -719,60 +730,83 @@ decodeBBAddrMapImpl(const ELFFile &EF, Feature = Data.getU8(Cur); // Feature byte if (!Cur) break; - auto FeatEnableOrErr = PGOAnalysisMap::Features::decode(Feature); + auto FeatEnableOrErr = BBAddrMap::Features::decode(Featur

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik created https://github.com/llvm/llvm-project/pull/77255 The GNUstep Objective C runtime (libobjc2) is adding support for MinGW. This runtime uses C++ exceptions in that configuration. >From 4cbc22e9b7c53547b97c666b24f191b25ae8866f Mon Sep 17 00:00:00 2001 From: F

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Frederik Carlier (qmfrederik) Changes The GNUstep Objective C runtime (libobjc2) is adding support for MinGW. This runtime uses C++ exceptions in that configuration. --- Full diff: https://github.com/llvm/llvm-project/pull/77255.

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e1ecd100d7663a91135b1cf6c4a603681b7385b 4cbc22e9b7c53547b97c666b24f191b25ae8866f --

[clang] [llvm] [lld] [clang-tools-extra] [lldb] [mlir] [libc] [compiler-rt] [libcxx] Fix Multiple Build Errors on different platforms (PR #77216)

https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/77216 >From a1156a564c798192cb7608e28ce9b9ed846a8b1c Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sat, 6 Jan 2024 20:21:06 -0500 Subject: [PATCH 1/2] Fix Multiple Build Errors on different platforms Particularly f

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/77255 >From 62d7da8476b786f7950ea6bb8d6ac223fc6d0468 Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Thu, 4 Jan 2024 11:10:05 -0800 Subject: [PATCH] Objective C: use C++ exceptions on MinGW+GNUstep The GNUste

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/77255 >From d04a41177e9c39799b73168d397dd87fb948caa1 Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Thu, 4 Jan 2024 11:10:05 -0800 Subject: [PATCH] Objective C: use C++ exceptions on MinGW+GNUstep The GNUste

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

@@ -156,7 +154,11 @@ static const EHPersonality &getObjCPersonality(const TargetInfo &Target, case ObjCRuntime::WatchOS: return EHPersonality::NeXT_ObjC; case ObjCRuntime::GNUstep: -if (L.ObjCRuntime.getVersion() >= VersionTuple(1, 7)) +if (T.isOSCygMing()) ---

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik edited https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik edited https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

qmfrederik wrote: /cc @davidchisnall https://github.com/llvm/llvm-project/pull/77255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4ca1b5e - [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (#76949)

Author: Martin Storsjö Date: 2024-01-07T23:24:06+02:00 New Revision: 4ca1b5e094280ef1af40412e3cfcb62dc3cf15bc URL: https://github.com/llvm/llvm-project/commit/4ca1b5e094280ef1af40412e3cfcb62dc3cf15bc DIFF: https://github.com/llvm/llvm-project/commit/4ca1b5e094280ef1af40412e3cfcb62dc3cf15bc.diff

[clang] [clang] [MinGW] Don't look for a GCC in path if the install base has a proper mingw sysroot (PR #76949)

https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/76949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

@@ -156,7 +154,11 @@ static const EHPersonality &getObjCPersonality(const TargetInfo &Target, case ObjCRuntime::WatchOS: return EHPersonality::NeXT_ObjC; case ObjCRuntime::GNUstep: -if (L.ObjCRuntime.getVersion() >= VersionTuple(1, 7)) +if (T.isOSCygMing()) ---

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/77255 >From d3e6d552b2502765eff8faccd20b7566a9362491 Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Thu, 4 Jan 2024 11:10:05 -0800 Subject: [PATCH] Objective C: use C++ exceptions on MinGW+GNUstep The GNUste

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/77255 >From 4212c79b5bb9168ae741b05b2c3388aa23e38693 Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Thu, 4 Jan 2024 11:10:05 -0800 Subject: [PATCH] Objective C: use C++ exceptions on MinGW+GNUstep The GNUste

[clang] Objective C: use C++ exceptions on MinGW+GNUstep (PR #77255)

https://github.com/qmfrederik updated https://github.com/llvm/llvm-project/pull/77255 >From d5dec27c1b0eb1999a86035ac458da377132ec7d Mon Sep 17 00:00:00 2001 From: Frederik Carlier Date: Thu, 4 Jan 2024 11:10:05 -0800 Subject: [PATCH] Objective C: use C++ exceptions on MinGW+GNUstep The GNUste

[llvm] [clang] [clang-tools-extra] [X86] Emit Warnings for frontend options to enable knl/knm specific ISAs. (PR #75580)

https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/75580 >From e16afbdc9f0c04bad0e8f80f90c0eb26c13d3326 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 15 Dec 2023 16:50:23 +0800 Subject: [PATCH 1/7] [X86] Emit Warnings for frontend options to enable knl/knm.

[clang] 5034994 - [Sema] Warning for _Float16 passed to format specifier '%f' (#74439)

Author: Haocong Lu Date: 2024-01-08T09:50:36+08:00 New Revision: 5034994134bbec92c1f1116c56008ac504f7d763 URL: https://github.com/llvm/llvm-project/commit/5034994134bbec92c1f1116c56008ac504f7d763 DIFF: https://github.com/llvm/llvm-project/commit/5034994134bbec92c1f1116c56008ac504f7d763.diff LO

[clang] [Sema] Warning for _Float16 passed to format specifier '%f' (PR #74439)

https://github.com/Luhaocong closed https://github.com/llvm/llvm-project/pull/74439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [PGO]Add `-fdiagnostics-show-profile-count` option to show real loop count from instr-profile (PR #75021)

https://github.com/ElvisWang123 updated https://github.com/llvm/llvm-project/pull/75021 >From 22ff830f3bd113eebd6b8369c61700879ae02b4a Mon Sep 17 00:00:00 2001 From: Elvis Wang Date: Sun, 10 Dec 2023 18:34:37 -0800 Subject: [PATCH 1/2] [PGO] Add `-fdiagnostics-show-profile-count` option to sho

[clang] [CMake] Include riscv32-unknown-elf runtimes in Fuchsia toolchain (PR #76849)

https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/76849 >From 0cb22bea1e724ca62306081da2ae97bbcc395a86 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Fri, 9 Jun 2023 07:17:13 + Subject: [PATCH] [CMake] Include riscv32-unknown-elf runtimes in Fuchsia toolchain

[clang] 78550be - [CMake] Include riscv32-unknown-elf runtimes in Fuchsia toolchain (#76849)

Author: Petr Hosek Date: 2024-01-07T18:13:39-08:00 New Revision: 78550bef98347bccbf0e8e5fb66dc59718fc35ec URL: https://github.com/llvm/llvm-project/commit/78550bef98347bccbf0e8e5fb66dc59718fc35ec DIFF: https://github.com/llvm/llvm-project/commit/78550bef98347bccbf0e8e5fb66dc59718fc35ec.diff LO

[clang] [CMake] Include riscv32-unknown-elf runtimes in Fuchsia toolchain (PR #76849)

https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/76849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

@@ -7575,15 +7577,27 @@ static void visitLifetimeBoundArguments(IndirectLocalPath &Path, Expr *Call, Path.pop_back(); }; - if (ObjectArg && implicitObjectParamIsLifetimeBound(Callee)) -VisitLifetimeBoundArg(Callee, ObjectArg); - bool CheckCoroCall = false; if

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

https://github.com/ChuanqiXu9 commented: Maybe it'll be better to say this is related to `[[coro_lifetimebound]]`. My instinct reaction to this is that "no, this is not strictly correct". But I feel good after I know it is an extension of `[[coro_lifetimebound]]` only. https://github.com/llvm/

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

@@ -7575,15 +7577,27 @@ static void visitLifetimeBoundArguments(IndirectLocalPath &Path, Expr *Call, Path.pop_back(); }; - if (ObjectArg && implicitObjectParamIsLifetimeBound(Callee)) -VisitLifetimeBoundArg(Callee, ObjectArg); - bool CheckCoroCall = false; if

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Detect lifetime issues with coroutine lambda captures (PR #77066)

https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/77066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a90ed3e - Revert "[CMake] Include riscv32-unknown-elf runtimes in Fuchsia toolchain (#76849)"

Author: Petr Hosek Date: 2024-01-08T03:29:30Z New Revision: a90ed3e8a4ea8c5238fd660bbac0371366afe3b5 URL: https://github.com/llvm/llvm-project/commit/a90ed3e8a4ea8c5238fd660bbac0371366afe3b5 DIFF: https://github.com/llvm/llvm-project/commit/a90ed3e8a4ea8c5238fd660bbac0371366afe3b5.diff LOG: Re

[clang-tools-extra] [clangd] Handle lambda scopes inside Node::getDeclContext() (PR #76329)

https://github.com/HighCommander4 approved this pull request. Thanks, the change looks good to me! I went through the existing callers of `Node::getDeclContext()`, and I was able to construct a test case where the patch actually changes behaviour (in a good way): ```c++ namespace NS { void un

[clang-tools-extra] [clangd] Handle lambda scopes inside Node::getDeclContext() (PR #76329)

HighCommander4 wrote: > Happy New Year 2024! You too! https://github.com/llvm/llvm-project/pull/76329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PGO]Add `-fdiagnostics-show-profile-count` option to show real loop count from instr-profile (PR #75021)

https://github.com/ElvisWang123 deleted https://github.com/llvm/llvm-project/pull/75021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

@@ -0,0 +1,50 @@ +// REQUIRES: !system-windows + +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: %clang_cc1 -std=c++20 %t/layer1.cppm -triple %itanium_abi_triple \ +// RUN: -emit-module-interface -o %t/foo-layer1.pcm +// RUN: %clang_cc1 -std=c++20 %t/l

[clang] [llvm] [PGO]Add `-fdiagnostics-show-profile-count` option to show real loop count from instr-profile (PR #75021)

@@ -2091,6 +2091,12 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions &Opts, ArgList &Args, bool UsingProfile = UsingSampleProfile || !Opts.ProfileInstrumentUsePath.empty(); + if (Args.hasArg(options::OPT_fdiagnostics_show_profile_count) &&

[clang] [libclang/python] Expose Rewriter to the libclang python binding. (PR #71341)

https://github.com/jimmy-zx closed https://github.com/llvm/llvm-project/pull/71341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

https://github.com/HighCommander4 approved this pull request. Thanks, LGTM! https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

https://github.com/HighCommander4 approved this pull request. Thanks, looks good with the added comments. https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

  1   2   >