[llvm] [clang] [clang-tools-extra] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 commented: Maybe we can do some perf test between this expansion for set rounding mode and the system library's version for `fesetround()`. On AIX, I saw some improvements were introduced in the system library's implementation. https://github.com/llvm/llvm-proj

[llvm] [clang-tools-extra] [clang] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 edited https://github.com/llvm/llvm-project/pull/67302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
@@ -8900,6 +8900,82 @@ SDValue PPCTargetLowering::LowerINT_TO_FP(SDValue Op, return FP; } +SDValue PPCTargetLowering::LowerSET_ROUNDING(SDValue Op, + SelectionDAG &DAG) const { + SDLoc Dl(Op); + MachineFunction &MF = DAG.getMachi

[llvm] [clang-tools-extra] [clang] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
@@ -8900,6 +8900,82 @@ SDValue PPCTargetLowering::LowerINT_TO_FP(SDValue Op, return FP; } +SDValue PPCTargetLowering::LowerSET_ROUNDING(SDValue Op, + SelectionDAG &DAG) const { + SDLoc Dl(Op); + MachineFunction &MF = DAG.getMachi

[clang-tools-extra] [llvm] [clang] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
@@ -77,4 +77,196 @@ return: ; preds = %entry ret i32 %retval3 } -declare i32 @llvm.get.rounding() nounwind +define void @setrnd_tozero() { +; PPC32-LABEL: setrnd_tozero: +; PPC32: # %bb.0: # %entry +; PPC32-NEXT:mtfsb0 30 +; PPC32-NEXT:mtfsb1 3

[llvm] [clang-tools-extra] [clang] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
@@ -8900,6 +8900,82 @@ SDValue PPCTargetLowering::LowerINT_TO_FP(SDValue Op, return FP; } +SDValue PPCTargetLowering::LowerSET_ROUNDING(SDValue Op, + SelectionDAG &DAG) const { + SDLoc Dl(Op); + MachineFunction &MF = DAG.getMachi

[llvm] [clang] [clang-tools-extra] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
@@ -8900,6 +8900,82 @@ SDValue PPCTargetLowering::LowerINT_TO_FP(SDValue Op, return FP; } +SDValue PPCTargetLowering::LowerSET_ROUNDING(SDValue Op, + SelectionDAG &DAG) const { + SDLoc Dl(Op); + MachineFunction &MF = DAG.getMachi

[clang-tools-extra] [llvm] [clang] [PowerPC] Implement llvm.set.rounding intrinsic (PR #67302)

2024-01-02 Thread Chen Zheng via cfe-commits
@@ -8900,6 +8900,82 @@ SDValue PPCTargetLowering::LowerINT_TO_FP(SDValue Op, return FP; } +SDValue PPCTargetLowering::LowerSET_ROUNDING(SDValue Op, + SelectionDAG &DAG) const { + SDLoc Dl(Op); + MachineFunction &MF = DAG.getMachi

[clang-tools-extra] [clangd][RFC] Add container field to remote index Refs grpc method (PR #71605)

2024-01-02 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Emit Warnings for frontend options to enable knl/knm. (PR #75580)

2024-01-02 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: ping for review @RKSimon are we aligned on the direction to removing knl/knm supports in the end? https://github.com/llvm/llvm-project/pull/75580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang-tools-extra] [clangd] don't lower severity of clang-tidy modernize-* checks to remarks (PR #75706)

2024-01-02 Thread kadir çetinkaya via cfe-commits
kadircet wrote: hi @5chmidti and @HighCommander4! it was deliberate to cover `modernize-` checks as they're pretty similar to `-wdeprecated` in nature, and they're both explicit, user needs to annotate code or opt-in for particular clang-tidy checks. feedback we received in the past was, thes

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-02 Thread David Green via cfe-commits
https://github.com/davemgreen commented: Thanks. This is looking good to me. I just have a few comments about different architecture revisions. https://github.com/llvm/llvm-project/pull/75440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-02 Thread David Green via cfe-commits
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions &Opts, if (Opts.RWPI) Builder.defineMacro("__ARM_RWPI", "1"); + // Macros for enabling co-proc intrinsics + uint64_t FeatureCoprocBF = 0; + switch (ArchKind) { + default: +break; + case

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-02 Thread David Green via cfe-commits
@@ -836,6 +837,70 @@ void ARMTargetInfo::getTargetDefines(const LangOptions &Opts, if (Opts.RWPI) Builder.defineMacro("__ARM_RWPI", "1"); + // Macros for enabling co-proc intrinsics + uint64_t FeatureCoprocBF = 0; + switch (ArchKind) { + default: +break; + case

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-02 Thread David Green via cfe-commits
@@ -756,6 +756,58 @@ __arm_st64bv0(void *__addr, data512_t __value) { __builtin_arm_mops_memset_tag(__tagged_address, __value, __size) #endif +/* Coprocessor Intrinsics */ +#if defined(__ARM_FEATURE_COPROC) + +#if (__ARM_FEATURE_COPROC & 0x1) + +#if (__ARM_ARCH != 8) ---

[clang] [ARM] arm_acle.h add Coprocessor Instrinsics (PR #75440)

2024-01-02 Thread David Green via cfe-commits
https://github.com/davemgreen edited https://github.com/llvm/llvm-project/pull/75440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] don't lower severity of clang-tidy modernize-* checks to remarks (PR #75706)

2024-01-02 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > You mentioned `inconsistencies`, is it inside clangd or in other places that > surface clang-tidy findings? I understood it as, the appearance of `modernize-*` clang-tidy diagnostics in the editor is not consistent with the appearance of other (non-`modernize-*`) clang

[lldb] [compiler-rt] [libc] [clang] [libcxx] [clang-tools-extra] [llvm] [mlir] [openmp] [flang] [OpenMP] atomic compare fail : Codegen support (PR #75709)

2024-01-02 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/75709 >From fe931d64741f427629407bca3e68a61bec6f2b67 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Sat, 16 Dec 2023 11:43:35 -0600 Subject: [PATCH 1/3] Adding parameter to fail clause (i.e. memory ord

[clang] 5055eee - [Clang][AArch64] Add missing SME functions to header file. (#75791)

2024-01-02 Thread via cfe-commits
Author: Sander de Smalen Date: 2024-01-02T09:43:30Z New Revision: 5055eeea5205d938320590236eeb782c92e40911 URL: https://github.com/llvm/llvm-project/commit/5055eeea5205d938320590236eeb782c92e40911 DIFF: https://github.com/llvm/llvm-project/commit/5055eeea5205d938320590236eeb782c92e40911.diff L

[clang] [Clang][AArch64] Add missing SME functions to header file. (PR #75791)

2024-01-02 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm closed https://github.com/llvm/llvm-project/pull/75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [libcxx] [llvm] [mlir] [flang] [analyzer][NFC] Cleanup BugType lazy-init patterns (PR #76655)

2024-01-02 Thread via cfe-commits
DonatNagyE wrote: Thanks for cleaning this up! https://github.com/llvm/llvm-project/pull/76655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-02 Thread via cfe-commits
@@ -87,6 +85,28 @@ bool isStdVariant(const Type *Type) { return isStdType(Type, llvm::StringLiteral("variant")); } +bool isStdAny(const Type *Type) { + return isStdType(Type, llvm::StringLiteral("any")); +} + +bool isVowel(char a) { + switch (a) { + case 'a': + case 'e':

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-02 Thread via cfe-commits
@@ -0,0 +1,170 @@ +// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \ +// RUN: -Xclang -analyzer-checker=core \ +// RUN: -Xclang -analyzer-checker=debug.ExprInspection \ +// RUN: -Xclang -analyzer-checker=core,alpha.core.StdAny + +#include "Inputs/system-header-simulat

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2024-01-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/72892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-02 Thread Gábor Spaits via cfe-commits
@@ -87,6 +85,28 @@ bool isStdVariant(const Type *Type) { return isStdType(Type, llvm::StringLiteral("variant")); } +bool isStdAny(const Type *Type) { + return isStdType(Type, llvm::StringLiteral("any")); +} + +bool isVowel(char a) { + switch (a) { + case 'a': + case 'e':

[clang] [analyzer] Add std::any checker (PR #76580)

2024-01-02 Thread via cfe-commits
@@ -87,6 +85,28 @@ bool isStdVariant(const Type *Type) { return isStdType(Type, llvm::StringLiteral("variant")); } +bool isStdAny(const Type *Type) { + return isStdType(Type, llvm::StringLiteral("any")); +} + +bool isVowel(char a) { + switch (a) { + case 'a': + case 'e':

[clang] [openmp] [flang] [lldb] [libc] [mlir] [llvm] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2024-01-02 Thread Jay Foad via cfe-commits
jayfoad wrote: Ping! https://github.com/llvm/llvm-project/pull/76149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Fix SME2 mla/mls tests (PR #76711)

2024-01-02 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau created https://github.com/llvm/llvm-project/pull/76711 The ACLE defines these builtins as svmla[_single]_za32[_f32]_vg1x2, which means the SVE_ACLE_FUNC macro should test the overloaded forms as SVE_ACLE_FUNC(svmla,_single,_za32,_f32,_vg1x2) https://github.com/AR

[clang] [AArch64][SME2] Fix SME2 mla/mls tests (PR #76711)

2024-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthew Devereau (MDevereau) Changes The ACLE defines these builtins as svmla[_single]_za32[_f32]_vg1x2, which means the SVE_ACLE_FUNC macro should test the overloaded forms as SVE_ACLE_FUNC(svmla,_single,_za32,_f32,_vg1x2) https://githu

[clang] Changed Checks from TriviallyCopyable to TriviallyCopyConstructible (PR #76680)

2024-01-02 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Hello @Endilll Can I work on some other issues also till this PR get reviewed? Thank you https://github.com/llvm/llvm-project/pull/76680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [AArch64][SME2] Add __arm_streaming_compatible attribute to CLAMP bui… (PR #76712)

2024-01-02 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov created https://github.com/llvm/llvm-project/pull/76712 …ltins. Patch-by: Caroline Concatto >From d21c30bb3d655ab66e1ecb2f9b26dc441ca8928a Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Tue, 2 Jan 2024 12:01:17 + Subject: [PATCH] [AArch64][SME2]

[clang] [AArch64][SME2] Add __arm_streaming_compatible attribute to CLAMP bui… (PR #76712)

2024-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dinar Temirbulatov (dtemirbulatov) Changes …ltins. Patch-by: Caroline Concatto --- Full diff: https://github.com/llvm/llvm-project/pull/76712.diff 4 Files Affected: - (modified) clang/include/clang/Basic/arm

[libc] [clang] [lldb] [llvm] [openmp] [mlir] [flang] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2024-01-02 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/76149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

2024-01-02 Thread Alexey Bataev via cfe-commits
@@ -6106,6 +6106,8 @@ class OMPTeamsGenericLoopDirective final : public OMPLoopDirective { class OMPTargetTeamsGenericLoopDirective final : public OMPLoopDirective { friend class ASTStmtReader; friend class OMPExecutableDirective; + /// true if loop directive's associated

[openmp] [clang] [libc] [mlir] [lldb] [flang] [llvm] [AMDGPU] GFX12 global_atomic_ordered_add_b64 instruction and intrinsic (PR #76149)

2024-01-02 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/76149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix crash on invalid code with parenthesized aggregate initialization (PR #76232)

2024-01-02 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Thanks for reverting it and sorry for the trouble, I will make sure to check libc++ tests before a reland. Clang does report less errors now, but that's expected. The errors were spurious, caused by Clang trying to initialize an "invalid" class (more details below in case

[clang] 687c51a - [clang][Interp][NFC] Remove unused using alias

2024-01-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-02T14:18:29+01:00 New Revision: 687c51a3972af17b3f225e692e79fd898a1b6f95 URL: https://github.com/llvm/llvm-project/commit/687c51a3972af17b3f225e692e79fd898a1b6f95 DIFF: https://github.com/llvm/llvm-project/commit/687c51a3972af17b3f225e692e79fd898a1b6f95.diff LO

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2024-01-02 Thread Fangrui Song via cfe-commits
@@ -214,6 +214,14 @@ // RUN: -mnan=legacy -mnan=2008 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-NAN2008 %s // CHECK-NAN2008: "-target-feature" "+nan2008" +// CHECK-NAN2008: "-target-feature" "+abs2008" +// +// -mnan=2008 -mabs=legacy +// RUN: %clang -target mips-linu

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2024-01-02 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/71157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2024-01-02 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/71157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2024-01-02 Thread Fangrui Song via cfe-commits
@@ -214,6 +214,14 @@ // RUN: -mnan=legacy -mnan=2008 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-NAN2008 %s // CHECK-NAN2008: "-target-feature" "+nan2008" +// CHECK-NAN2008: "-target-feature" "+abs2008" MaskRay wrote: If abs2008 is adjacent, just pla

[clang-tools-extra] [clang] [llvm] [clang] Accept recursive non-dependent calls to functions with deduced return type (PR #75456)

2024-01-02 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/75456 >From 0e190f131862dd8f4b07891c3ee712a0a163f936 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Thu, 14 Dec 2023 01:33:17 -0800 Subject: [PATCH] [clang] Accept recursive non-dependent calls to func

[clang] [clang-format] Add common attribute macros to Google style (PR #76239)

2024-01-02 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: This change did not aim to change the behavior, it's quite the opposite, I tried to guide `clang-format` parsing to recognize attribute and format the code in the way we always intended it to. If there is a way to do that without adding the macro names to the configuratio

[clang-tools-extra] [clang] [llvm] [X86] Use plain load/store instead of cmpxchg16b for atomics with AVX (PR #74275)

2024-01-02 Thread James Y Knight via cfe-commits
jyknight wrote: Ping! https://github.com/llvm/llvm-project/pull/74275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix diagnosing non-const variables pre-C++11 (PR #76718)

2024-01-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/76718 Depends on https://github.com/llvm/llvm-project/pull/71919 In CheckConstant(), consider that in C++98 const variables may not be read at all, and diagno

[clang] [clang][Interp] Fix diagnosing non-const variables pre-C++11 (PR #76718)

2024-01-02 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Depends on https://github.com/llvm/llvm-project/pull/71919 In CheckConstant(), consider that in C++98 const variables may not be read at all, and dia

[clang] [Clang] Use const pointer to eliminate warning with libxml 2.12.0 (PR #76719)

2024-01-02 Thread via cfe-commits
https://github.com/FantasqueX created https://github.com/llvm/llvm-project/pull/76719 Currently, if `CLANG_HAVE_LIBXML` is defined, and the version of libxml2 is above 2.12.0, there will be two warnings when building clang. warning: initializing 'xmlErrorPtr' (aka 'struct _xmlError *') with an

[clang] [Clang] Use const pointer to eliminate warning with libxml 2.12.0 (PR #76719)

2024-01-02 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [Clang] Use const pointer to eliminate warning with libxml 2.12.0 (PR #76719)

2024-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: FantasqueX (FantasqueX) Changes Currently, if `CLANG_HAVE_LIBXML` is defined, and the version of libxml2 is above 2.12.0, there will be two warnings when building clang. warning: initializing 'xmlErrorPtr' (aka 'struct _xmlError *') with

[clang] [APINotes] Upstream Sema logic to apply API Notes to decls (PR #73017)

2024-01-02 Thread Egor Zhdan via cfe-commits
egorzhdan wrote: @compnerd ping ;) https://github.com/llvm/llvm-project/pull/73017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] don't lower severity of clang-tidy modernize-* checks to remarks (PR #75706)

2024-01-02 Thread Julian Schmidt via cfe-commits
5chmidti wrote: There is also the use-case to keep a relatively modern code-base in a modern state. In that case, the user might want to know about modernizations/deprecations right in the editor. Example (vscode): ![image](https://github.com/llvm/llvm-project/assets/44101708/e66b4fc8-7e3a-4edb

[clang] Multilib support for libraries with exceptions (PR #75031)

2024-01-02 Thread Michael Platings via cfe-commits
https://github.com/mplatings edited https://github.com/llvm/llvm-project/pull/75031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Multilib support for libraries with exceptions (PR #75031)

2024-01-02 Thread Michael Platings via cfe-commits
https://github.com/mplatings commented: I'd be disinclined to add `CachedExceptionsMode`: * It's more code to maintain. * Most toolchains will never use it so for them it's a small extra runtime cost with no benefit. I think you could calculate the exceptions mode in `getMultilibFlags` when ne

[clang] Multilib support for libraries with exceptions (PR #75031)

2024-01-02 Thread Michael Platings via cfe-commits
@@ -77,10 +77,21 @@ static ToolChain::RTTIMode CalculateRTTIMode(const ArgList &Args, return NoRTTI ? ToolChain::RM_Disabled : ToolChain::RM_Enabled; } +static ToolChain::ExceptionsMode CalculateExceptionsMode(const ArgList &Args) { + + Arg *exceptionsArg = Args.getLastArg

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2024-01-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/72892 >From 14873b8729e97425049e654adf40fb239ccfab6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 20 Nov 2023 11:5

[clang] Multilib support for libraries with exceptions (PR #75031)

2024-01-02 Thread Michael Platings via cfe-commits
mplatings wrote: > I'm not actively working on LLVM any more so I'm going to remove myself as > reviewer now. Or at least I would if GitHub would let me! https://github.com/orgs/community/discussions/23054 https://github.com/llvm/llvm-project/pull/75031 ___

[clang] [clang][Interp] Implement IntegralAP::{div, rem} (PR #72614)

2024-01-02 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/72614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add an EvaluationResult class (PR #71315)

2024-01-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/71315 >From c4c9473b8be62028f204e85066ad7b0cf7dda29b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 14:57:51 +0100 Subject: [PATCH] EvaluationResult --- clang/lib/AST/CMakeLists.

[llvm] [clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2024-01-02 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/68075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2024-01-02 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/68075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2024-01-02 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk updated https://github.com/llvm/llvm-project/pull/68075 >From be70878169742f7e9cbb276a05254019c586897b Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Tue, 3 Oct 2023 16:08:06 +0800 Subject: [PATCH 1/4] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss

[clang] 02347fc - Reapply "[Sema] Fix crash on invalid code with parenthesized aggregate initialization" (#76272)

2024-01-02 Thread Ilya Biryukov via cfe-commits
Author: Ilya Biryukov Date: 2024-01-02T16:00:55+01:00 New Revision: 02347fc7191ff4d073f439dde6523add3f5496de URL: https://github.com/llvm/llvm-project/commit/02347fc7191ff4d073f439dde6523add3f5496de DIFF: https://github.com/llvm/llvm-project/commit/02347fc7191ff4d073f439dde6523add3f5496de.diff

[llvm] [clang] [RISCV] Implement shadow stack on shadow stack mode with Zicfiss. (PR #68075)

2024-01-02 Thread Yeting Kuo via cfe-commits
yetingk wrote: Rebase and ping. I also update the first comment of the first comment of this pr since the control stack mode is removed and we add new feature `forced-sw-shadow-stack`. https://github.com/llvm/llvm-project/pull/68075 ___ cfe-commits m

[clang] [clang-tools-extra] [mlir] [llvm] [compiler-rt] [flang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Mehdi Amini via cfe-commits
@@ -866,16 +866,41 @@ struct TransferOpConversion : public VectorToSCFPattern { this->setHasBoundedRewriteRecursion(); } + static void getMaskBufferLoadIndices(OpTy xferOp, Value castedMaskBuffer, + SmallVector &loadIndices, --

[mlir] [flang] [clang-tools-extra] [llvm] [compiler-rt] [clang] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Mehdi Amini via cfe-commits
@@ -897,7 +921,8 @@ struct TransferOpConversion : public VectorToSCFPattern { } else { // It's safe to assume the mask buffer can be unpacked if the data // buffer was unpacked. -auto castedMaskType = *unpackOneDim(maskBufferType); +auto m

[flang] [clang-tools-extra] [clang] [mlir] [llvm] [compiler-rt] [mlir][vector] Fix invalid `LoadOp` indices being created (PR #76292)

2024-01-02 Thread Mehdi Amini via cfe-commits
@@ -866,16 +866,41 @@ struct TransferOpConversion : public VectorToSCFPattern { this->setHasBoundedRewriteRecursion(); } + static void getMaskBufferLoadIndices(OpTy xferOp, Value castedMaskBuffer, + SmallVector &loadIndices, +

[clang] [Clang][RISCV] Forward --no-relax option to linker for RISC-V (PR #76432)

2024-01-02 Thread Andreu Carminati via cfe-commits
https://github.com/andcarminati updated https://github.com/llvm/llvm-project/pull/76432 >From 13648eaf3becc5650924c3399fb1dc1ecb9fa7c7 Mon Sep 17 00:00:00 2001 From: Andreu Carminati Date: Wed, 27 Dec 2023 09:47:54 +0100 Subject: [PATCH 1/2] [Clang][RISCV] Forward --no-relax option to linker fo

[clang] [Clang][RISCV] Forward --no-relax option to linker for RISC-V (PR #76432)

2024-01-02 Thread Andreu Carminati via cfe-commits
andcarminati wrote: > Should this also be done in `tools::gnutools::Linker::ConstructJob`? Addressed with a new commit. https://github.com/llvm/llvm-project/pull/76432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[llvm] [clang-tools-extra] [clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2024-01-02 Thread Tom Ritter via cfe-commits
tomrittervg wrote: > However, what should we do if multiple (N) classes implement Base? Trying > each N, and basically splitting the state to (N+1) ways is not going to > scale. Unless N is of course really small, like 2 or 3 at most. That's kind of what I imagined - try them all. The Analyze

[clang] [AArch64][SME2] Add __arm_streaming_compatible attribute to CLAMP bui… (PR #76712)

2024-01-02 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm requested changes to this pull request. Perhaps I'm missing something obvious here, but it looks like this patch is implementing the opposite of #75958 ? https://github.com/llvm/llvm-project/pull/76712 ___ cfe-commits

[clang] [AArch64][SME2] Add __arm_streaming_compatible attribute to CLAMP bui… (PR #76712)

2024-01-02 Thread Dinar Temirbulatov via cfe-commits
dtemirbulatov wrote: I missed that implemtation in https://github.com/llvm/llvm-project/pull/75958, Closing then. https://github.com/llvm/llvm-project/pull/76712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [AArch64][SME2] Add __arm_streaming_compatible attribute to CLAMP bui… (PR #76712)

2024-01-02 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov closed https://github.com/llvm/llvm-project/pull/76712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [coroutines] Do not check coroutine wrappers for skipped function bodies (PR #76729)

2024-01-02 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/76729 Without function bodies, we cannot tell whether a function is a coroutine or not. The analysis of coroutine wrappers is not useful when this information is not available. We therefore now skip this analysis for sk

[clang] [clang-tools-extra] [coroutines] Do not check coroutine wrappers for skipped function bodies (PR #76729)

2024-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clangd Author: Utkarsh Saxena (usx95) Changes Without function bodies, we cannot tell whether a function is a coroutine or not. The analysis of coroutine wrappers is not useful when this information is not available. We ther

[clang] Clang/MIPS: Use -mnan value for -mabs if not specified (PR #71157)

2024-01-02 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa updated https://github.com/llvm/llvm-project/pull/71157 >From 4e1b075a26db2831d981bad61ae883ede890bd58 Mon Sep 17 00:00:00 2001 From: YunQiang Su Date: Fri, 3 Nov 2023 03:30:52 -0400 Subject: [PATCH] Clang/MIPS: Use -mnan value for -mabs if not specified On most hard

[clang] [clang][ASTImporter][StructuralEquivalence] improve StructuralEquivalence on recordType (PR #76226)

2024-01-02 Thread Balázs Kéri via cfe-commits
@@ -1491,6 +1492,12 @@ static bool IsRecordContextStructurallyEquivalent(RecordDecl *D1, return false; } +if (auto *D1Spec = dyn_cast(DC1)) { + auto *D2Spec = dyn_cast(DC2); balazske wrote: It would be better to check if `D2Spec` is null

[clang] [llvm] [clang][AArch64] Add a -mbranch-protection option to enable GCS (PR #75486)

2024-01-02 Thread John Brawn via cfe-commits
https://github.com/john-brawn-arm updated https://github.com/llvm/llvm-project/pull/75486 >From cceb8766d2c93cadc940b45f0817abc5e6d0a225 Mon Sep 17 00:00:00 2001 From: John Brawn Date: Wed, 13 Dec 2023 16:20:33 + Subject: [PATCH] [clang][AArch64] Add a -mbranch-protection option to enable

[clang] [Clang][Parser] Fix crash of clang when using C++ constructs like :: in C code (PR #74926)

2024-01-02 Thread via cfe-commits
https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 92ae6f1d822e704cfc8f03d6582772758af3aa66 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Tue, 2 Jan 2024 17:14:21 +0100 Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only w

[clang] [Clang][Parser] Fix crash of clang when using C++ constructs like :: in C code (PR #74926)

2024-01-02 Thread via cfe-commits
ChipsSpectre wrote: Sorry @tbaederr, I made a mistake in fixing the ReleaseNotes. Now I added the missing brackets to the link for this issue in the ReleaseNotes. Could you merge the pull request now? https://github.com/llvm/llvm-project/pull/74926 _

[clang] [clang-tools-extra] [coroutines] Do not check coroutine wrappers for skipped function bodies (PR #76729)

2024-01-02 Thread Ilya Biryukov via cfe-commits
@@ -15845,7 +15845,7 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) { } void Sema::CheckCoroutineWrapper(FunctionDecl *FD) { - if (!FD) + if (!FD || FD->hasSkippedBody()) ilya-biryukov wrote: Suggestion: a comment would be appropriate here, e.g. `//

[compiler-rt] [clang] [llvm] [clang-tools-extra] [Profile] Allow profile merging with multiple correlate files. (PR #75957)

2024-01-02 Thread Zequan Wu via cfe-commits
@@ -481,3 +509,49 @@ Error BinaryInstrProfCorrelator::correlateProfileNameImpl() { this->Names.append(this->Ctx->NameStart, this->Ctx->NameSize); return Error::success(); } + +llvm::Expected> InstrProfCorrelators::get( +ArrayRef> +CorrelateInputs, +uint32_

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-02 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/76733 Reuse the patterns governing the previous input file being formatted if the the current input file is from the same directory. >From 7f8da18dc59706df8f1ee15d22076b4794881579 Mon Sep 17 00:00:00 2001 From: Owen Pa

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Owen Pan (owenca) Changes Reuse the patterns governing the previous input file being formatted if the the current input file is from the same directory. --- Full diff: https://github.com/llvm/llvm-project/pull/76733.diff 3 Files Affecte

[compiler-rt] [clang] [llvm] [clang-tools-extra] [Profile] Allow profile merging with multiple correlate files. (PR #75957)

2024-01-02 Thread Zequan Wu via cfe-commits
@@ -118,18 +118,18 @@ cl::opt ProfiledBinary( "profiled-binary", cl::init(""), cl::desc("Path to binary from which the profile was collected."), cl::sub(ShowSubcommand), cl::sub(MergeSubcommand)); -cl::opt DebugInfoFilename( -"debug-info", cl::init(""), +cl::lis

[lld] [flang] [llvm] [libcxx] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -245,6 +267,18 @@ public: # endif _LIBCPP_HIDE_FROM_ABI basic_filebuf* __open(int __fd, ios_base::openmode __mode); basic_filebuf* close(); +# if _LIBCPP_STD_VER >= 26 + _LIBCPP_HIDE_FROM_ABI native_handle_type native_handle() const noexcept { +_LIBCPP_ASSERT_UNC

[clang] [X86] Emit Warnings for frontend options to enable knl/knm. (PR #75580)

2024-01-02 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: I think if we have an approach that allows people to emulate a very basic KNL/KNM implementation with the equivalent of "-march=x86-64-v3 -mavx512f -mavx512cd" then that would be sufficient. I do think we should be keeping -march/tune support though for the knl/knm cpu model nam

[polly] [clang] [llvm] [X86] Remove Intel Xeon Phi Supports. (PR #76383)

2024-01-02 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/76383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [polly] [clang] [X86] Remove Intel Xeon Phi Supports. (PR #76383)

2024-01-02 Thread Simon Pilgrim via cfe-commits
@@ -159,8 +159,6 @@ #define bit_AVX512IFMA 0x0020 #define bit_CLFLUSHOPT 0x0080 #define bit_CLWB0x0100 -#define bit_AVX512PF0x0400 -#define bit_AVX512ER0x0800 RKSimon wrote: I'd probably keep these for future reference. h

[clang] [polly] [llvm] [X86] Remove Intel Xeon Phi Supports. (PR #76383)

2024-01-02 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon commented: I still think we should keep the knl/knm cpu models in place, even if they don't support all features anymore. https://github.com/llvm/llvm-project/pull/76383 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [llvm] [clang-tools-extra] Add out-of-line-atomics support to GlobalISel (PR #74588)

2024-01-02 Thread Thomas Preud'homme via cfe-commits
RoboTux wrote: My apologies @arsenm, I had missed your review comments. All fixed now. https://github.com/llvm/llvm-project/pull/74588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-01-02 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: same in our stage 2 build ``` [4643/5157] Building CXX object tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o FAILED: tools/dsymutil/CMakeFiles/dsymutil.dir/CFBundle.cpp.o /Volumes/Work/s/w/ir/cache/builder/src/third_party/llvm-bootstrap-install/bin/clang++ -DGTEST_H

[flang] [libcxx] [llvm] [clang] [lld] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [lld] [llvm] [clang] [flang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -245,6 +267,18 @@ public: # endif _LIBCPP_HIDE_FROM_ABI basic_filebuf* __open(int __fd, ios_base::openmode __mode); basic_filebuf* close(); +# if _LIBCPP_STD_VER >= 26 + _LIBCPP_HIDE_FROM_ABI native_handle_type native_handle() const noexcept { +_LIBCPP_ASSERT_UNC

[lld] [llvm] [libcxx] [flang] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -0,0 +1,81 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[libcxx] [lld] [flang] [llvm] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
https://github.com/mordante requested changes to this pull request. I did a full review. There are a number of comments, once these are addressed the patch is ready. https://github.com/llvm/llvm-project/pull/76632 ___ cfe-commits mailing list cfe-comm

[llvm] [lld] [flang] [libcxx] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -245,6 +267,18 @@ public: # endif _LIBCPP_HIDE_FROM_ABI basic_filebuf* __open(int __fd, ios_base::openmode __mode); basic_filebuf* close(); +# if _LIBCPP_STD_VER >= 26 + _LIBCPP_HIDE_FROM_ABI native_handle_type native_handle() const noexcept { +_LIBCPP_ASSERT_UNC

[lld] [flang] [llvm] [libcxx] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -0,0 +1,81 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [lld] [libcxx] [llvm] [flang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -0,0 +1,58 @@ +//===--===// mordante wrote: Not related to this file. But I miss tests for the typedefs added to the 4 classes. These are typically in the types tests. For example, libcxx/te

[lld] [llvm] [clang] [libcxx] [flang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -0,0 +1,58 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[lld] [flang] [libcxx] [llvm] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

2024-01-02 Thread Mark de Wever via cfe-commits
@@ -0,0 +1,81 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

  1   2   3   >