[clang] [clang][modules] Print library module manifest path. (PR #76451)

2023-12-27 Thread Chuanqi Xu via cfe-commits
@@ -602,6 +602,16 @@ class Driver { // FIXME: This should be in CompilationInfo. std::string GetProgramPath(StringRef Name, const ToolChain &TC) const; + /// GetModuleManifestPath - Lookup the name of the Standard library manifest. ChuanqiXu9 wrote: ```s

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2023-12-27 Thread Chuanqi Xu via cfe-commits
@@ -5280,6 +5280,9 @@ def print_resource_dir : Flag<["-", "--"], "print-resource-dir">, def print_search_dirs : Flag<["-", "--"], "print-search-dirs">, HelpText<"Print the paths used for finding libraries and programs">, Visibility<[ClangOption, CLOption]>; +def print_libr

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2023-12-27 Thread Chuanqi Xu via cfe-commits
@@ -602,6 +602,16 @@ class Driver { // FIXME: This should be in CompilationInfo. std::string GetProgramPath(StringRef Name, const ToolChain &TC) const; + /// GetModuleManifestPath - Lookup the name of the Standard library manifest. + /// + /// \param C - The compilation

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2023-12-27 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,15 @@ +// Test that -print-library-module-manifest-path finds the correct file. + +// RUN: %clang -print-library-module-manifest-path \ +// RUN: -stdlib=libc++ \ +// RUN: --sysroot=%S/Inputs/cxx23_modules \ +// RUN: --target=x86_64-linux-gnu 2>&1 \ +// RUN:

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2023-12-27 Thread Chuanqi Xu via cfe-commits
@@ -2164,6 +2164,12 @@ bool Driver::HandleImmediateArgs(const Compilation &C) { return false; } + if (C.getArgs().hasArg(options::OPT_print_library_module_manifest_path)) { +llvm::outs() << "module: =" ChuanqiXu9 wrote: Do we need the prefix? I am

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2023-12-27 Thread Chuanqi Xu via cfe-commits
@@ -602,6 +602,16 @@ class Driver { // FIXME: This should be in CompilationInfo. std::string GetProgramPath(StringRef Name, const ToolChain &TC) const; + /// GetModuleManifestPath - Lookup the name of the Standard library manifest. + /// + /// \param C - The compilation

[clang] [Clang][RISCV] Forward --no-relax option to linker for RISC-V (PR #76432)

2023-12-27 Thread Craig Topper via cfe-commits
topperc wrote: Should this also be done in `tools::gnutools::Linker::ConstructJob`? https://github.com/llvm/llvm-project/pull/76432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][MC] Add support for experimental Zcmop extension (PR #76395)

2023-12-27 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk approved this pull request. LGTM. But please wait for @topperc's review. https://github.com/llvm/llvm-project/pull/76395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] c2c840b - [Modules] Don't prevent @import from ObjectiveC

2023-12-27 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-12-28T10:45:47+08:00 New Revision: c2c840bd92cfac155f6205ff7505b109b301d389 URL: https://github.com/llvm/llvm-project/commit/c2c840bd92cfac155f6205ff7505b109b301d389 DIFF: https://github.com/llvm/llvm-project/commit/c2c840bd92cfac155f6205ff7505b109b301d389.diff LO

[llvm] [clang] [RISCV][MC] Add support for experimental Zcmop extension (PR #76395)

2023-12-27 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/76395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [libc++] Re-enable the clang_modules_include test for Objective-C++ (PR #66801)

2023-12-27 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I tried to fix this in https://github.com/llvm/llvm-project/commit/c2c840bd92cfac155f6205ff7505b109b301d389. Sorry for disturbing. https://github.com/llvm/llvm-project/pull/66801 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] 52770d8 - [Serialization] Don't pack bits for the function scope index of ParmVarDecl

2023-12-27 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-12-28T11:04:11+08:00 New Revision: 52770d83bf00fc56e9496e32f083f0f940bf7315 URL: https://github.com/llvm/llvm-project/commit/52770d83bf00fc56e9496e32f083f0f940bf7315 DIFF: https://github.com/llvm/llvm-project/commit/52770d83bf00fc56e9496e32f083f0f940bf7315.diff LO

[clang] Avoid printing overly large integer. (PR #75902)

2023-12-27 Thread Nhat Nguyen via cfe-commits
@@ -17132,6 +17132,10 @@ static bool ConvertAPValueToString(const APValue &V, QualType T, case BuiltinType::WChar_U: { unsigned TyWidth = Context.getIntWidth(T); assert(8 <= TyWidth && TyWidth <= 32 && "Unexpected integer width"); + if (V.g

[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

2023-12-27 Thread via cfe-commits
kon72 wrote: Hello @HighCommander4 , Could you take a look at this change? Thanks! https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] support vector subscript expressions in constant evaluator (WIP) (PR #76379)

2023-12-27 Thread Vikram Hegde via cfe-commits
https://github.com/vikramRH closed https://github.com/llvm/llvm-project/pull/76379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] support vector subscript expressions in constant evaluator (WIP) (PR #76379)

2023-12-27 Thread Vikram Hegde via cfe-commits
vikramRH wrote: Putting this on hold hold as @yuanfang-chen already has a PR https://github.com/llvm/llvm-project/pull/76379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5c27e00 - [RISCV][NFC] Use errorToBool (#76429)

2023-12-27 Thread via cfe-commits
Author: Wang Pengcheng Date: 2023-12-28T12:59:11+08:00 New Revision: 5c27e00055e920c435fdb3883e233b3533576559 URL: https://github.com/llvm/llvm-project/commit/5c27e00055e920c435fdb3883e233b3533576559 DIFF: https://github.com/llvm/llvm-project/commit/5c27e00055e920c435fdb3883e233b3533576559.diff

[clang] [RISCV][NFC] Use errorToBool (PR #76429)

2023-12-27 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/76429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 705065f - [RISCV][NFC] Use RISCVISAInfo instead of string comparison (#76387)

2023-12-27 Thread via cfe-commits
Author: Wang Pengcheng Date: 2023-12-28T13:00:43+08:00 New Revision: 705065f365a9df5c26bd37f2a3380427da1b1b7f URL: https://github.com/llvm/llvm-project/commit/705065f365a9df5c26bd37f2a3380427da1b1b7f DIFF: https://github.com/llvm/llvm-project/commit/705065f365a9df5c26bd37f2a3380427da1b1b7f.diff

[clang] [RISCV][NFC] Use RISCVISAInfo instead of string comparison (PR #76387)

2023-12-27 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/76387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 13cdee9 - [RISCV][MC] Add support for experimental Zcmop extension (#76395)

2023-12-27 Thread via cfe-commits
Author: Wang Pengcheng Date: 2023-12-28T13:03:16+08:00 New Revision: 13cdee9047d24d84505c469481563c3fb55e4131 URL: https://github.com/llvm/llvm-project/commit/13cdee9047d24d84505c469481563c3fb55e4131 DIFF: https://github.com/llvm/llvm-project/commit/13cdee9047d24d84505c469481563c3fb55e4131.diff

[clang] [llvm] [RISCV][MC] Add support for experimental Zcmop extension (PR #76395)

2023-12-27 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/76395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Refactor checkRVVTypeSupport to use BuiltinVectorTypeInfo. (PR #74949)

2023-12-27 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD approved this pull request. Looks good. If I understand correctly, you mean that `vbool64_t` should emit diagnosis of requiring `zve64x` and should not emit error of `zve32x.` https://github.com/llvm/llvm-project/pull/74949 _

[clang] [RISCV] Prevent checkRVVTypeSupport from issuing more than 1 diagnostic. (PR #74950)

2023-12-27 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD edited https://github.com/llvm/llvm-project/pull/74950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Refactor checkRVVTypeSupport to use BuiltinVectorTypeInfo. (PR #74949)

2023-12-27 Thread Craig Topper via cfe-commits
topperc wrote: > Looks good. > > If I understand correctly, you mean that `vbool64_t` should emit diagnosis of > requiring `zve64x` and should not emit error of `zve32x.` Correct. Since vbool64_t requires SEW/LMUL==64 which is only possible with SEW=8 LMUL=1/8, SEW=16 LMUL=1/4 or SEW=32 LMUL=

[clang] 9807305 - [RISCV] Refactor checkRVVTypeSupport to use BuiltinVectorTypeInfo. (#74949)

2023-12-27 Thread via cfe-commits
Author: Craig Topper Date: 2023-12-27T21:53:27-08:00 New Revision: 98073057ee45bc4a9256ecc70dc3da20b0fd5d3b URL: https://github.com/llvm/llvm-project/commit/98073057ee45bc4a9256ecc70dc3da20b0fd5d3b DIFF: https://github.com/llvm/llvm-project/commit/98073057ee45bc4a9256ecc70dc3da20b0fd5d3b.diff

[clang] [RISCV] Refactor checkRVVTypeSupport to use BuiltinVectorTypeInfo. (PR #74949)

2023-12-27 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/74949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Prevent checkRVVTypeSupport from issuing more than 1 diagnostic. (PR #74950)

2023-12-27 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD approved this pull request. Looks good since we have just landed #74949. https://github.com/llvm/llvm-project/pull/74950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [RISCV] Prevent checkRVVTypeSupport from issuing more than 1 diagnostic. (PR #74950)

2023-12-27 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/74950 >From 7675400ba14c6b747fd8ed8b821059fbdb54a3ef Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Sat, 9 Dec 2023 12:46:48 -0800 Subject: [PATCH 1/2] [RISCV] Prevent checkRVVTypeSupport from issuing more than 1 d

[clang] 471f8f5 - [RISCV] Prevent checkRVVTypeSupport from issuing more than 1 diagnostic. (#74950)

2023-12-27 Thread via cfe-commits
Author: Craig Topper Date: 2023-12-27T23:44:45-08:00 New Revision: 471f8f50d0790cd7e77b8b385d8592c95df53974 URL: https://github.com/llvm/llvm-project/commit/471f8f50d0790cd7e77b8b385d8592c95df53974 DIFF: https://github.com/llvm/llvm-project/commit/471f8f50d0790cd7e77b8b385d8592c95df53974.diff

[clang] [RISCV] Prevent checkRVVTypeSupport from issuing more than 1 diagnostic. (PR #74950)

2023-12-27 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/74950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Avoid crash when summarizing pointer-to-member expr for block-end hint (PR #76492)

2023-12-27 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/76492 Fixes https://github.com/clangd/clangd/issues/1873 >From b60a2515bbfbfc79bc3b0bb81ef6fe1db13404bd Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 28 Dec 2023 02:47:04 -0500 Subject: [PATCH] [clangd

[clang-tools-extra] [clangd] Avoid crash when summarizing pointer-to-member expr for block-end hint (PR #76492)

2023-12-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Nathan Ridge (HighCommander4) Changes Fixes https://github.com/clangd/clangd/issues/1873 --- Full diff: https://github.com/llvm/llvm-project/pull/76492.diff 2 Files Affected: - (modified) clang-tools-extra/clangd/InlayHints.cpp (+1-1)

[clang] [clang][ASTImporter] import InstantiatedFromMember of ClassTemplateSpecializationDecl (PR #76493)

2023-12-27 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/76493 import of `ClassTemplateSpecializationDecl` didn't set `InstantiatedFromMember` and this makes ast-dump crash. import and set `InstantiatedFromMember`. fix [issue](https://github.com/llvm/llvm-project/issues/7646

[clang] [clang][ASTImporter] import InstantiatedFromMember of ClassTemplateSpecializationDecl (PR #76493)

2023-12-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes import of `ClassTemplateSpecializationDecl` didn't set `InstantiatedFromMember` and this makes ast-dump crash. import and set `InstantiatedFromMember`. fix [issue](https://github.com/llvm/llvm-project/issues/7646

<    1   2