[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

@@ -1026,6 +1030,71 @@ void SystemZAsmPrinter::emitADASection() { OutStreamer->popSection(); } +static uint32_t getProductVersion(Module &M) { + if (auto *VersionVal = mdconst::extract_or_null( + M.getModuleFlag("zos_product_major_version"))) +return VersionVal

[compiler-rt] [clang] [llvm] [lld] [flang] [libc] [libcxx] Fix ISel crash when lowering BUILD_VECTOR (PR #73186)

llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: David Li (david-xl) Changes 512bit vpbroadcastw is available only with AVX512BW. Avoid lowering BUILD_VEC into vbroard_cast node when the condition is not met. This fixed a crash (see the added new test). --- Full diff: https://git

[clang-tools-extra] [llvm] [clang] [Clang] Fix linker error for function multiversioning (PR #71706)

https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/71706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [Clang] Fix linker error for function multiversioning (PR #71706)

https://github.com/tahonermann requested changes to this pull request. I requested some minor changes. Can we document the `.ifunc` symbols as a deprecated feature? With this change, they will never be referenced except by code compiled by older compiler versions. Maybe plan to deprecate them

[clang-tools-extra] [clang] [llvm] [Clang] Fix linker error for function multiversioning (PR #71706)

@@ -555,6 +555,7 @@ Bug Fixes in This Version Fixes (`#67687 `_) - Fix crash from constexpr evaluator evaluating uninitialized arrays as rvalue. Fixes (`#67317 `_) +- Fix l

[clang-tools-extra] [clang] [llvm] [Clang] Fix linker error for function multiversioning (PR #71706)

@@ -4114,8 +4114,26 @@ void CodeGenModule::emitMultiVersionFunctions() { } llvm::Constant *ResolverConstant = GetOrCreateMultiVersionResolver(GD); -if (auto *IFunc = dyn_cast(ResolverConstant)) +if (auto *IFunc = dyn_cast(ResolverConstant)) { ResolverCon

[clang] [llvm] [clang-tools-extra] [Clang] Fix linker error for function multiversioning (PR #71706)

@@ -16,13 +16,22 @@ // LINUX: @__cpu_model = external dso_local global { i32, i32, i32, [1 x i32] } // LINUX: @__cpu_features2 = external dso_local global [3 x i32] -// LINUX: @internal.ifunc = internal ifunc i32 (), ptr @internal.resolver -// LINUX: @foo.ifunc = weak_odr ifun

[clang-tools-extra] [clang] [llvm] [Clang] Fix linker error for function multiversioning (PR #71706)

@@ -4114,8 +4114,26 @@ void CodeGenModule::emitMultiVersionFunctions() { } llvm::Constant *ResolverConstant = GetOrCreateMultiVersionResolver(GD); -if (auto *IFunc = dyn_cast(ResolverConstant)) +if (auto *IFunc = dyn_cast(ResolverConstant)) { ResolverCon

[clang] [clang-tools-extra] [llvm] [Clang] Fix linker error for function multiversioning (PR #71706)

@@ -4282,10 +4300,19 @@ llvm::Constant *CodeGenModule::GetOrCreateMultiVersionResolver(GlobalDecl GD) { // Holds the name of the resolver, in ifunc mode this is the ifunc (which has // a separate resolver). std::string ResolverName = MangledName; - if (getTarget().suppo

[clang] [clang] Fix sorting module headers (PR #73146)

tuliom wrote: > Sorry, I don't quite understand tnhis @dwblaikie Would you have any questions? I'd be glad to answer them. https://github.com/llvm/llvm-project/pull/73146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [clang] Fix sorting module headers (PR #73146)

tuliom wrote: > Sorry, I don't quite understand tnhis - but I guess the second field ( > PathRelativeToRootModuleDirectory ) comparison was to address this bug? @dwblaikie Yes. > It'd probably be good to fix that separately, so it can be discussed in more > detail, etc. The commit is already

[clang] [AArch64][SME2] Add multi-vector SEL (x2, x4) ACLE builtins & intrinsics (PR #73188)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Dinar Temirbulatov (dtemirbulatov) Changes Add multi-vector SEL (x2, x4) ACLE builtins & intrinsics Patch by: David Sherwood --- Patch is 114.68 KiB, truncated to 20.00 KiB below, full version: https://github.com

[clang] [clang] Fix sorting module headers (PR #73146)

dwblaikie wrote: > Splitting it wouldn't help with bisect, as we would continue having a broken > commit. Not sure I understand - presumably this bug has existed for a while, separate from the qsort issue? So fixing it separately seems good so that patches do one thing clearly - makes it easy

[clang] [clang][analyzer][NFC] Use `*EofVal` instead of constant `-1` (PR #73072)

https://github.com/benshi001 closed https://github.com/llvm/llvm-project/pull/73072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b14f651 - [Driver] Default Generic_GCC aarch64_be to -fasynchronous-unwind-tables (#72971)

Author: dong jianqiang Date: 2023-11-23T09:30:51+08:00 New Revision: b14f651caf4bb507753ffc94db8911bb2e2a7995 URL: https://github.com/llvm/llvm-project/commit/b14f651caf4bb507753ffc94db8911bb2e2a7995 DIFF: https://github.com/llvm/llvm-project/commit/b14f651caf4bb507753ffc94db8911bb2e2a7995.diff

[clang] [Driver] Default Generic_GCC aarch64_be to -fasynchronous-unwind-tables (PR #72971)

https://github.com/hstk30-hw closed https://github.com/llvm/llvm-project/pull/72971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix emitvaarg when struct is null (PR #72624)

Jolyon0202 wrote: @efriedma-quic https://github.com/llvm/llvm-project/pull/72624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore macro definitions (PR #70338)

owenca wrote: After giving more thoughts to this, I think what we really want is `SkipMacroDefinitionBody`, which would format the code below: ``` # define A a. b //comment # define A( x , y ) ( ( x ) + ( y ) ) ``` To the following: ``` #define A a. b // comment #define A(x, y)

[clang] [clang] Refactor TBAA Base Info construction (PR #70499)

urnathan wrote: I'm going to break this apart, as I've realized this has conflated two separate problems. https://github.com/llvm/llvm-project/pull/70499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

alexfh wrote: Could you first land the two reverts (511cecff7f76958ebfe713189bc106615763b64a and e9a8e906d4c14eb4b317a7420b9bba3dc7321ba2) and then have the third commit properly reverted? @Artem-B may be unavailable for a few more days, but we'd like a fix/revert to land very soon. https://g

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

yxsamliu wrote: > Could you first land the two reverts > ([511cecf](https://github.com/llvm/llvm-project/commit/511cecff7f76958ebfe713189bc106615763b64a) > and > [e9a8e90](https://github.com/llvm/llvm-project/commit/e9a8e906d4c14eb4b317a7420b9bba3dc7321ba2)) > and then have the third commit p

[clang] 22078bd - Revert "[CUDA][HIP] ignore implicit host/device attr for override (#72815)"

Author: Yaxun (Sam) Liu Date: 2023-11-22T21:04:55-05:00 New Revision: 22078bd9f6842411aac2b75196975d68a817a358 URL: https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358 DIFF: https://github.com/llvm/llvm-project/commit/22078bd9f6842411aac2b75196975d68a817a358.dif

[clang] 6b3470b - Revert "[CUDA][HIP] make trivial ctor/dtor host device (#72394)"

Author: Yaxun (Sam) Liu Date: 2023-11-22T21:20:53-05:00 New Revision: 6b3470b4b83195aeeda60b101e8d3bf8800c321c URL: https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c DIFF: https://github.com/llvm/llvm-project/commit/6b3470b4b83195aeeda60b101e8d3bf8800c321c.dif

[libunwind] [libunwind][WebAssembly] Don't build libunwind.cpp (PR #73196)

https://github.com/aheejin created https://github.com/llvm/llvm-project/pull/73196 Wasm doesn't use that file; Wasm does not allow access of system registers and those functionalities are provided from the VM. Wasm only uses https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unwind-wa

[libunwind] [libunwind][WebAssembly] Don't build libunwind.cpp (PR #73196)

llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Heejin Ahn (aheejin) Changes Wasm doesn't use that file; Wasm does not allow access of system registers and those functionalities are provided from the VM. Wasm only uses https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unw

[clang] b16f765 - [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (#72889)

Author: Joseph Huber Date: 2023-11-22T20:23:23-06:00 New Revision: b16f765d6fec56a07aecd2056bb1760a9e72d64f URL: https://github.com/llvm/llvm-project/commit/b16f765d6fec56a07aecd2056bb1760a9e72d64f DIFF: https://github.com/llvm/llvm-project/commit/b16f765d6fec56a07aecd2056bb1760a9e72d64f.diff

[clang] [LinkerWrapper] Accept some needed lld-link linker arguments for COFF targets (PR #72889)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/72889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/73140 >From 2dc8bda89483ee655e7a76deac19b8ea9e463c7b Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Wed, 22 Nov 2023 10:02:59 -0500 Subject: [PATCH] [CUDA][HIP] allow trivial ctor/dtor in device var init Trea

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

yxsamliu wrote: > Could you first land the two reverts > ([511cecf](https://github.com/llvm/llvm-project/commit/511cecff7f76958ebfe713189bc106615763b64a) > and > [e9a8e90](https://github.com/llvm/llvm-project/commit/e9a8e906d4c14eb4b317a7420b9bba3dc7321ba2)) > and then have the third commit p

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/72627 >From 3032cafc2ad43baeeea14de318cd82026b96d035 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Fri, 17 Nov 2023 17:22:10 +0800 Subject: [PATCH] [clang][analyzer] Support `fgetc` in StreamChecker --- .../StaticAn

[clang] [CUDA][HIP] allow trivial ctor/dtor in device var init (PR #73140)

alexfh wrote: Thank you! https://github.com/llvm/llvm-project/pull/73140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2eb9c64 - [RISCV] Use Float type instead of Half type for Fixed RVV vector type mangling (#73091)

Author: Jianjian Guan Date: 2023-11-23T11:08:27+08:00 New Revision: 2eb9c649f0971aaa05404764d74ee7fff15b83ed URL: https://github.com/llvm/llvm-project/commit/2eb9c649f0971aaa05404764d74ee7fff15b83ed DIFF: https://github.com/llvm/llvm-project/commit/2eb9c649f0971aaa05404764d74ee7fff15b83ed.diff

[clang] [RISCV] Use Float type instead of Half type for Fixed RVV vector type mangling (PR #73091)

https://github.com/jacquesguan closed https://github.com/llvm/llvm-project/pull/73091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/73207 https://reviews.llvm.org/D151863 (2023-05) removed `BaseReg = BaseReg ? BaseReg : 1` (introduced in commit 175d0aeef3725ce17032e9ef76e018139f2f52f0 (2013)) and caused a regression: ensuring a non-zero `BaseReg` wa

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/73207 >From 5b74d57faf8ab5fae4d9512517d6ec4d888a6ecd Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 22 Nov 2023 16:14:14 -0800 Subject: [PATCH] ms inline asm: Fix {call,jmp} fptr https://reviews.llvm.org/D1518

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/73207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes https://reviews.llvm.org/D151863 (2023-05) removed `BaseReg = BaseReg ? BaseReg : 1` (introduced in commit 175d0aeef3725ce17032e9ef76e018139f2f52f0 (2013)) and caused a regression: ensuring a non-zero `BaseReg

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

MaskRay wrote: I should confess that I don't understand the mechanism well. I've tried hard to write a good description but I cannot improve the comments in `CreateMemForMSInlineAsm`. https://github.com/llvm/llvm-project/pull/73207 ___ cfe-commits m

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/73207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] ms inline asm: Fix {call,jmp} fptr (PR #73207)

https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/73207 >From f8d61499c92d98e3c29027f0137e9d2f734d39c0 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 22 Nov 2023 16:14:14 -0800 Subject: [PATCH] ms inline asm: Fix {call,jmp} fptr https://reviews.llvm.org/D1518

[clang] [clang] Add partial-inlining options (PR #73210)

https://github.com/Jolyon0202 created https://github.com/llvm/llvm-project/pull/73210 Adaptation of adding -fpartial-inlining and -fno-partial-inlining options with GCC. >From f525387d65a1cdee561f919b3351b528bd44a535 Mon Sep 17 00:00:00 2001 From: Jian Yang Date: Thu, 23 Nov 2023 12:54:52 +08

[clang] [clang] Add partial-inlining options (PR #73210)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jolyon (Jolyon0202) Changes Adaptation of adding -fpartial-inlining and -fno-partial-inlining options with GCC. --- Full diff: https://github.com/llvm/llvm-project/pull/73210.diff 3 Files Affected: - (modified) clang/include/cla

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

xgupta wrote: Does this fix https://github.com/llvm/llvm-project/issues/56687? https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

@@ -12,9 +12,10 @@ #include "CGCleanup.h" #include "CodeGenFunction.h" -#include "llvm/ADT/ScopeExit.h" +#include "clang/AST/ExprCXX.h" #include "clang/AST/StmtCXX.h" #include "clang/AST/StmtVisitor.h" +#include "llvm/ADT/ScopeExit.h" ChuanqiXu9 wrote: Is t

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

@@ -129,7 +130,14 @@ static SmallString<32> buildSuspendPrefixStr(CGCoroData &Coro, AwaitKind Kind) { return Prefix; } -static bool memberCallExpressionCanThrow(const Expr *E) { +static bool ResumeExprCanThrow(const CoroutineSuspendExpr &S) { + const Expr *E = S.getResumeE

[clang] [Clang] CGCoroutines skip emitting try block for value returning `noexcept` init `await_resume` calls (PR #73160)

@@ -38,9 +39,52 @@ Task coro_create() { co_return; } -// CHECK-LABEL: define{{.*}} ptr @_Z11coro_createv( +// CHECK-LABEL: define{{.*}} ptr @_ZN9can_throw11coro_createEv( // CHECK: init.ready: // CHECK-NEXT: store i1 true, ptr {{.*}} -// CHECK-NEXT: call void @_ZN4Task23

[flang] [clang] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib (PR #72601)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/72601 >From da17459071b039e9da0f53ae5e68ab1c3aaa13e4 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Wed, 15 Nov 2023 14:24:11 -0500 Subject: [PATCH] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib -

[flang] [clang] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib (PR #72601)

brad0 wrote: > It would be helpful if you could clearly distinguish between the two opposite > cases that are currently being tested in "dynamic-linker.f90". Ok, done. https://github.com/llvm/llvm-project/pull/72601 ___ cfe-commits mailing list cfe-

[clang] 0d2860b - [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (#71677)

Author: serge-sans-paille Date: 2023-11-23T05:38:14Z New Revision: 0d2860b795879f4dd152963b52f969b53b136899 URL: https://github.com/llvm/llvm-project/commit/0d2860b795879f4dd152963b52f969b53b136899 DIFF: https://github.com/llvm/llvm-project/commit/0d2860b795879f4dd152963b52f969b53b136899.diff

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/71677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

HighCommander4 wrote: A somewhat narrow use case where this approach might be workable is unity builds (groups of source files batched together to be compiled as a single translation unit for build performance). That's a situation where the non-self-contained files of interest (the individual

[clang] [Driver] Add the --gcc-triple option (PR #73214)

https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/73214 When --gcc-triple is used, the driver will search for the 'best' gcc installation that has the given triple. This is useful for distributions that want clang to use a specific gcc triple, but do not want to pi

[clang] [Driver] Add the --gcc-triple option (PR #73214)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Tom Stellard (tstellar) Changes When --gcc-triple is used, the driver will search for the 'best' gcc installation that has the given triple. This is useful for distributions that want clang to use a spec

[clang] [Driver] Add the --gcc-triple option (PR #73214)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7f18f9a28c73490d09938af1fdb1908eb333a62c 72f6f3a611f237f71ce02cfb79620257a9e2d827 --

[clang] clang/CodeGen/RISCV: test lowering of math builtins (PR #71399)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] allow single element access of vector object to be constant expression (PR #72607)

https://github.com/yuanfang-chen updated https://github.com/llvm/llvm-project/pull/72607 >From b7d7c5fc70ffb792f67d007ec1bd71bcaed868fc Mon Sep 17 00:00:00 2001 From: Yuanfang Chen Date: Fri, 17 Nov 2023 03:16:38 + Subject: [PATCH] [clang][ExprConst] allow single element access of vector o

[clang] 083a539 - clang/CodeGen/RISCV: test lowering of math builtins (#71399)

Author: Ramkumar Ramachandra Date: 2023-11-23T07:39:32Z New Revision: 083a53971758c6f9bbd448eeb9c5d839661e3f68 URL: https://github.com/llvm/llvm-project/commit/083a53971758c6f9bbd448eeb9c5d839661e3f68 DIFF: https://github.com/llvm/llvm-project/commit/083a53971758c6f9bbd448eeb9c5d839661e3f68.dif

[clang] clang/CodeGen/RISCV: test lowering of math builtins (PR #71399)

https://github.com/artagnon closed https://github.com/llvm/llvm-project/pull/71399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

omjavaid wrote: This change appears to have broken several clang tests on following buildbots: https://lab.llvm.org/buildbot/#/builders/245 https://lab.llvm.org/buildbot/#/builders/188 https://lab.llvm.org/buildbot/#/builders/186 https://lab.llvm.org/buildbot/#/builders/183 Kindly fix issues if

[clang] [clang][AST][ASTMerge] prevent AST nodes from being deallocated early (PR #73096)

ChuanqiXu9 wrote: > Debug the https://github.com/llvm/llvm-project/issues/72783 can prove it. > Address interval (local from 0x3a9a00 to 0x3aaa00) allocated by allocator > contains a IdentifierInfo variable (local address:0x3aa190) whose address is > freed early. In this case, it looks better

[flang] [clang] [flang][Driver] Support -nodefaultlibs, -nostartfiles and -nostdlib (PR #72601)

brad0 wrote: @MaskRay Still could use some input about the ```CLOption, DXCOption``` part. Same with 34e4e5eb70818fca90574beb8f5617e27bfac138. https://github.com/llvm/llvm-project/pull/72601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

<    1   2   3   4