[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

HighCommander4 wrote: > I suspect it won't work with the present `TemplateTypeParm{Type,Decl}` > models. `TemplateTypeParmDecl` per se is not tied to any `CXXRecordDecl` nor > `FunctionDecl` that the template parameter is declaring with. (For the most > seemingly-relevant part, i.e. the `DeclC

[llvm] [clang-tools-extra] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

Fznamznon wrote: Ping. https://github.com/llvm/llvm-project/pull/70829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cdf6693 - [AArch64][SME] Add support for sme-fa64 (#70809)

Author: Matthew Devereau Date: 2023-11-20T08:37:52Z New Revision: cdf6693f072b97ec42a95f569115ad7f0afd37d5 URL: https://github.com/llvm/llvm-project/commit/cdf6693f072b97ec42a95f569115ad7f0afd37d5 DIFF: https://github.com/llvm/llvm-project/commit/cdf6693f072b97ec42a95f569115ad7f0afd37d5.diff L

[compiler-rt] [llvm] [clang] [AArch64][SME] Add support for sme-fa64 (PR #70809)

https://github.com/MDevereau closed https://github.com/llvm/llvm-project/pull/70809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

wangpc added a comment. @craig.topper Thanks! @asb Hi Alex, I'd like to get another approval from you. Are there any more concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 _

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

jrtc27 added a comment. GCC only ever defines __riscv_32e Comment at: clang/lib/Basic/Targets/RISCV.cpp:210 +if (Is64Bit) + Builder.defineMacro("__riscv_64e"); +else Ugh, these don't align with the normal pattern. __riscv_e already exists in the s

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

jrtc27 added a comment. In D70401#4657098 , @jrtc27 wrote: > GCC only ever defines __riscv_32e Hm, seems the comments about __riscv_32e were from months ago, ignore them if they aren't correct or have become outdated... Repository: rG LLVM Github Mon

[clang] edd675a - [OpenMP] atomic compare fail : Parser & AST support

Author: Sunil Kuravinakop Date: 2023-11-20T03:05:31-06:00 New Revision: edd675ac283909397880f85ba68d0d5f99dc1be2 URL: https://github.com/llvm/llvm-project/commit/edd675ac283909397880f85ba68d0d5f99dc1be2 DIFF: https://github.com/llvm/llvm-project/commit/edd675ac283909397880f85ba68d0d5f99dc1be2.d

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= ,

[clang] [clang-tools-extra] [llvm] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

@@ -0,0 +1,61 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -target-feature +b16b16 -target-feature +sve -S -disable-O0-optnone -

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

kadircet wrote: hi! thanks for the interest @sr-tream but I am afraid this is likely to cause disruption in more cases than it might improve. apart from technical details like the threading concerns and reliance on certain variants that we don't really have (eg order of includes); at a high l

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

@@ -81,22 +81,21 @@ bool BuiltinFunctionChecker::evalCall(const CallEvent &Call, case Builtin::BI__builtin_alloca_with_align: case Builtin::BI__builtin_alloca: { -// FIXME: Refactor into StoreManager itself? -MemRegionManager& RM = C.getStoreManager().getRegionMana

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

https://github.com/gamesh411 approved this pull request. LGTM, added two remarks inline, but those can be separate patches as well. https://github.com/llvm/llvm-project/pull/72402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

https://github.com/gamesh411 edited https://github.com/llvm/llvm-project/pull/72402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

@@ -266,13 +266,18 @@ void CheckUseZeroAllocated1(void) { } char CheckUseZeroAllocated2(void) { + // FIXME: The return value of `alloca()` is modeled with `AllocaRegion` + // instead of `SymbolicRegion`, so the current implementation of + // `MallocChecker::checkUseZeroAllo

[clang] [clang][ASTImporter] Fix import of variable template redeclarations. (PR #72841)

https://github.com/balazske created https://github.com/llvm/llvm-project/pull/72841 In some cases variable templates (specially if static member of record) were not correctly imported and an assertion "Missing call to MapImported?" could happen. From 99d6169f62862b7b1147da7fd26a85df20a0aba5 M

[clang] [clang][ASTImporter] Fix import of variable template redeclarations. (PR #72841)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes In some cases variable templates (specially if static member of record) were not correctly imported and an assertion "Missing call to MapImported?" could happen. --- Full diff: https://github.com/llvm/llvm-

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

sr-tream wrote: > apart from technical details like the threading concerns and reliance on > certain variants that we don't really have (eg order of includes); at a high > level the idea of "finding a representative source file for the header and > replicating the PP state" is hard to work in

[clang] [clang-tools-extra] [llvm] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

@@ -0,0 +1,61 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -target-feature +b16b16 -target-feature +sve -S -disable-O0-optnone -

[libc] [llvm] [lldb] [clang] [flang] [mlir] [compiler-rt] [libunwind] [clang-tools-extra] [libcxxabi] [lld] [libcxx] PR#72453 : Exceeding maximum file name length (PR #72654)

https://github.com/shahidiqbal13 updated https://github.com/llvm/llvm-project/pull/72654 >From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001 From: Shahid Iqbal Date: Thu, 16 Nov 2023 11:26:43 -0500 Subject: [PATCH 1/6] TESTING infra --- clang/NOTES.txt | 2 ++ 1 file chang

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

wangpc added a comment. In D70401#4657101 , @jrtc27 wrote: > In D70401#4657098 , @jrtc27 wrote: > >> GCC only ever defines __riscv_32e > > Hm, seems the comments about __riscv_32e were from months ago, ignore them i

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

@@ -266,13 +266,18 @@ void CheckUseZeroAllocated1(void) { } char CheckUseZeroAllocated2(void) { + // FIXME: The return value of `alloca()` is modeled with `AllocaRegion` + // instead of `SymbolicRegion`, so the current implementation of + // `MallocChecker::checkUseZeroAllo

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

kadircet wrote: > We can limit ourselves to only the paired source file, and cancel inclusions > if the source file does not include a non-self-contained header directly. > This will reduce the number of situations in which this hack works, but will > avoid the problems you describe deducing

[clang] f7b5c25 - [AArch64][SME] Remove immediate argument restriction for svldr and svstr (#68565)

Author: Sam Tebbs Date: 2023-11-20T09:57:29Z New Revision: f7b5c255070ef2d8a4492a45613a6a7df0b5f0cb URL: https://github.com/llvm/llvm-project/commit/f7b5c255070ef2d8a4492a45613a6a7df0b5f0cb DIFF: https://github.com/llvm/llvm-project/commit/f7b5c255070ef2d8a4492a45613a6a7df0b5f0cb.diff LOG: [AA

[clang] [mlir] [llvm] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

https://github.com/SamTebbs33 closed https://github.com/llvm/llvm-project/pull/68565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

https://github.com/sr-tream closed https://github.com/llvm/llvm-project/pull/72479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [MachineLICM][AArch64] Hoist COPY instructions with other uses in the loop (PR #71403)

https://github.com/Rin18 closed https://github.com/llvm/llvm-project/pull/71403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [flang] [clang-tools-extra] [flang ]GETLOG runtime and extension implementation: get login username (PR #70917)

https://github.com/jeanPerier approved this pull request. LGTM, thanks for addressing all my comments! https://github.com/llvm/llvm-project/pull/70917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/72402 >From 703c06e2d6781c45e55d7021929a06cdb0275a14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Wed, 15 Nov 2023 16:03:22 +0100 Subject: [PA

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -81,22 +81,21 @@ bool BuiltinFunctionChecker::evalCall(const CallEvent &Call, case Builtin::BI__builtin_alloca_with_align: case Builtin::BI__builtin_alloca: { -// FIXME: Refactor into StoreManager itself? -MemRe

[clang] [analyzer] Use AllocaRegion in MallocChecker (PR #72402)

=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE edited https://github.com/llvm/llvm-project/pull/72402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/72730 >From 6dcb09dcc50a9b9e92640412242927b3e226929e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 18 Nov 2023 00:20:05 + Subject: [PATCH 1/6] [clang][DebugInfo][NFC] Create evaluateConstantInitializer

[clang] [llvm] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

https://github.com/MDevereau created https://github.com/llvm/llvm-project/pull/72849 Use ZTR instead of MatrixOP to prevent expensive test check and machine verifier failures. >From e1685cc0dea9501a993cbe3f8185a40e1f285591 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 20 Nov 2023 10

[clang] [llvm] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Matthew Devereau (MDevereau) Changes Use ZTR instead of MatrixOP to prevent expensive test check and machine verifier failures. --- Full diff: https://github.com/llvm/llvm-project/pull/72849.diff 10 Files Affected: - (modified) clang/i

[llvm] [clang] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Matthew Devereau (MDevereau) Changes Use ZTR instead of MatrixOP to prevent expensive test check and machine verifier failures. --- Full diff: https://github.com/llvm/llvm-project/pull/72849.diff 10 Files Affected: - (modified) clang

[llvm] [clang] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

https://github.com/MDevereau edited https://github.com/llvm/llvm-project/pull/72849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/72850 This has two major benefits: * We avoid performing joins on boolean expressions and hence extending the flow condition in cases where this is not needed. Simpler flow conditions should reduce the amou

[clang] [clang][dataflow] Discard unneeded `ExprToLoc` and `ExprToVal` entries. (PR #72850)

llvmbot wrote: @llvm/pr-subscribers-clang-analysis @llvm/pr-subscribers-clang Author: None (martinboehme) Changes This has two major benefits: * We avoid performing joins on boolean expressions and hence extending the flow condition in cases where this is not needed. Simpler flow cond

[clang] 661a73f - Fix typo in DiagnosticSemaKinds.td

Author: Utkarsh Saxena Date: 2023-11-20T12:04:32+01:00 New Revision: 661a73ff712c54d05042eb37d536be4bade307b4 URL: https://github.com/llvm/llvm-project/commit/661a73ff712c54d05042eb37d536be4bade307b4 DIFF: https://github.com/llvm/llvm-project/commit/661a73ff712c54d05042eb37d536be4bade307b4.diff

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 558134. BeMg added a comment. 1. reuse the find result 2. replace for loop with llvm::copy_if 3. use explicit std::vector declaration instead of auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https

[flang] [llvm] [clang] [flang][OpenMP] Add semantic check for declare target (PR #72770)

@@ -1851,6 +1853,18 @@ bool ClauseProcessor::processTo( }); } +bool ClauseProcessor::processEnter( +llvm::SmallVectorImpl &result) const { + return findRepeatableClause( + [&](const ClauseTy::Enter *enterClause, + const Fortran::parser::CharBlock &) {

[clang] [llvm] [flang] [flang][OpenMP] Add semantic check for declare target (PR #72770)

https://github.com/skatrak edited https://github.com/llvm/llvm-project/pull/72770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [flang] [flang][OpenMP] Add semantic check for declare target (PR #72770)

@@ -590,6 +590,8 @@ class ClauseProcessor { bool processSectionsReduction(mlir::Location currentLocation) const; bool processTo(llvm::SmallVectorImpl &result) const; bool + processEnter(llvm::SmallVectorImpl &result) const; skatrak wrote: Nit: It would

[clang] [flang] [llvm] [flang][OpenMP] Add semantic check for declare target (PR #72770)

https://github.com/skatrak commented: Thank you Shraiysh, I just have a couple of nits. https://github.com/llvm/llvm-project/pull/72770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SVE2.1][Clang][LLVM]Add 128bits builtin in Clang and LLVM intrinisc (PR #71930)

https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/71930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72516)

https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/72516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/72851 None >From 28e9fda4b78e1e60287048891cc92bafdef3ac4c Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH] Introduce [[clang::coro_lifetimebound]] --- clang/include/c

[clang] [llvm] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/72849 >From 3b1d34afb1ae365f48716ae5eb9202a474adf234 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Mon, 20 Nov 2023 10:49:27 + Subject: [PATCH] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics ---

[clang] [flang] [Flang][Clang] Add support for frame pointers in Flang Driver (PR #72146)

https://github.com/Radu2k updated https://github.com/llvm/llvm-project/pull/72146 >From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001 From: Radu2k Date: Mon, 13 Nov 2023 17:49:06 + Subject: [PATCH 1/5] [Flang][Clang] Add support for frame pointers in Flang --- clang/in

[clang] [llvm] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #72849)

https://github.com/MDevereau edited https://github.com/llvm/llvm-project/pull/72849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

https://github.com/kuganv converted_to_draft https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

https://github.com/kuganv ready_for_review https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

kuganv wrote: @revane, @pepsiman: Could you please review this. Thanks. https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a8b43b - [clang][Interp][NFC] Factor array element init into its own function

Author: Timm Bäder Date: 2023-11-20T13:00:57+01:00 New Revision: 4a8b43ba3bd5427dd98a7a93d1b1ed25051c31e8 URL: https://github.com/llvm/llvm-project/commit/4a8b43ba3bd5427dd98a7a93d1b1ed25051c31e8 DIFF: https://github.com/llvm/llvm-project/commit/4a8b43ba3bd5427dd98a7a93d1b1ed25051c31e8.diff LO

[clang] 9bdbb82 - [clang][Interp][NFC] Use isArrayRoot() when comparing pointers

Author: Timm Bäder Date: 2023-11-20T13:17:47+01:00 New Revision: 9bdbb8226e70fb248b40a4b5002699ee9eeeda93 URL: https://github.com/llvm/llvm-project/commit/9bdbb8226e70fb248b40a4b5002699ee9eeeda93 DIFF: https://github.com/llvm/llvm-project/commit/9bdbb8226e70fb248b40a4b5002699ee9eeeda93.diff LO

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/72730 >From 6dcb09dcc50a9b9e92640412242927b3e226929e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 18 Nov 2023 00:20:05 + Subject: [PATCH 1/7] [clang][DebugInfo][NFC] Create evaluateConstantInitializer

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/72730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/72863 Per [[class.friend]p6](http://eel.is/c++draft/class.friend#6) a friend function shall not be defined if its name isn't unqualified. A _template-id_ is not a name, meaning that a friend function specialization

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes Per [[class.friend]p6](http://eel.is/c++draft/class.friend#6) a friend function shall not be defined if its name isn't unqualified. A _template-id_ is not a name, meaning that a friend function spe

[clang] [clang][Interp] Use array filler expression (PR #72865)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/72865 This is obviously not what we should ideally do, but the current state is also broken. We are just leaving the other elements uninitialized and rely on them being zero-ed. >From c6a945bcd760803909ec085b384ead6

[clang] [clang][Interp] Use array filler expression (PR #72865)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This is obviously not what we should ideally do, but the current state is also broken. We are just leaving the other elements uninitialized and rely on them being zero-ed. --- Full diff: https://github.com/

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/72863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [SVE2.1][Clang][LLVM]Add BFloat16 builtin in Clang and LLVM intrinisc (PR #70362)

@@ -0,0 +1,61 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve2p1 -target-feature +b16b16 -target-feature +sve -S -disable-O0-optnone -

[clang] [clang][NFC] Refactor Builtins.def to be a tablegen file (PR #68324)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ba24b814f2a20a136f0a7a0b492b6ad8a62114c6 da81d45e7bb78b611886035b0f331318e5fdd7e7 --

[clang] [APINotes] Upstream APINotesManager (PR #72389)

egorzhdan wrote: @nico sorry for not leaving a more detailed description. I'll make sure to add a release note once the API notes are upstreamed entirely. https://github.com/llvm/llvm-project/pull/72389 ___ cfe-commits mailing list cfe-commits@lists.l

[flang] [clang] [Flang][Clang] Add support for frame pointers in Flang Driver (PR #72146)

https://github.com/Radu2k updated https://github.com/llvm/llvm-project/pull/72146 >From 0b0f02eab4dc02adf79461bc865be6f7580938cf Mon Sep 17 00:00:00 2001 From: Radu2k Date: Mon, 13 Nov 2023 17:49:06 + Subject: [PATCH 1/6] [Flang][Clang] Add support for frame pointers in Flang --- clang/in

[clang] [flang] [llvm] [flang][OpenMP] Add semantic check for declare target (PR #72770)

https://github.com/agozillon approved this pull request. LGTM, aside from Sergio's Nits! Might be worth asking someone from the Clang team to have a look at the Clang changes if you're a little unsure on them, but if you're happy with them can disregard doing that! https://github.com/llvm/ll

[clang] [llvm] [AArch64][SVE2.1] Add intrinsics for quadword loads/stores with unscaled offset (PR #70474)

https://github.com/david-arm approved this pull request. LGTM. I think I would have preferred the patch to be split up into 3 - one for contiguous extending loads/truncating stores, one for structured loads/stores, and one for the gathers. That's why it took me so long to review this patch as

[clang] [clang][DebugInfo] Attach DW_AT_const_value to static data-member definitions if available (PR #72730)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/72730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] ignore implicit host/device attr for override (PR #72815)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/72815 >From 1f48a0eb04df6ccc2d8117ebd6b68cc45484a0f3 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Sun, 19 Nov 2023 19:34:35 -0500 Subject: [PATCH] [CUDA][HIP] ignore implicit host/device attr for override W

[clang] [CUDA][HIP] ignore implicit host/device attr for override (PR #72815)

@@ -1000,13 +1000,9 @@ void Sema::checkCUDATargetOverload(FunctionDecl *NewFD, // should have the same implementation on both sides. if (NewTarget != OldTarget && ((NewTarget == CFT_HostDevice && - !(LangOpts.OffloadImplicitHostDeviceTemplates && -

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

sdkrystian wrote: Ping @AaronBallman @erichkeane https://github.com/llvm/llvm-project/pull/72863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

revane wrote: Does this PR address a bug I logged? I'm not sure why you've requested my input. https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

kuganv wrote: > Does this PR address a bug I logged? I'm not sure why you've requested my > input. Sorry for not being clear. I was tagging developers who touched this part of the codebase to see if you can review this change. https://github.com/llvm/llvm-project/pull/70801 __

[clang] [llvm] [SVE2.1][Clang][LLVM]Add 128bits builtin in Clang and LLVM intrinisc (PR #71930)

@@ -1992,3 +1992,36 @@ let TargetGuard = "sme2" in { def SVADD_SINGLE_X2 : SInst<"svadd[_single_{d}_x2]", "22d", "cUcsUsiUilUl", MergeNone, "aarch64_sve_add_single_x2", [IsStreaming], []>; def SVADD_SINGLE_X4 : SInst<"svadd[_single_{d}_x4]", "44d", "cUcsUsiUilUl", MergeNon

[clang] [llvm] [SVE2.1][Clang][LLVM]Add 128bits builtin in Clang and LLVM intrinisc (PR #71930)

@@ -1992,3 +1992,36 @@ let TargetGuard = "sme2" in { def SVADD_SINGLE_X2 : SInst<"svadd[_single_{d}_x2]", "22d", "cUcsUsiUilUl", MergeNone, "aarch64_sve_add_single_x2", [IsStreaming], []>; def SVADD_SINGLE_X4 : SInst<"svadd[_single_{d}_x4]", "44d", "cUcsUsiUilUl", MergeNon

[clang-tools-extra] [clang-apply-replacements] Apply format only if --format is specified (PR #70801)

revane wrote: I haven't touched this code in 10 years. I don't think I'm a good candidate for providing a review. https://github.com/llvm/llvm-project/pull/70801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[compiler-rt] [lld] [libcxx] [clang-tools-extra] [clang] [llvm] [libc] [lldb] [mlir] [flang] [MLIR] Enable GPU Dialect to SYCL runtime integration (PR #71430)

@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry ®istry) { registerLLVMDialectTranslation(registry); registerNVVMDialectTranslation(registry); registerROCDLDialectTranslation(registry); + registerSPIRVDialectTranslation(registry); fa

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

@@ -4,7 +4,8 @@ void f(T); template struct A { - // expected-error@+1{{cannot declare an explicit specialization in a friend}} + // expected-error@+2{{cannot declare an explicit specialization in a friend}} + // expected-error@+1{{friend function specialization cannot be de

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

@@ -373,6 +373,7 @@ template void foo() {} // expected-note{{candidate ignored: not a memb } using ns::foo; template struct A { + // expected-error@+1{{friend function specialization cannot be defined}} erichkeane wrote: These already error, and doing a do

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/72863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend function specialization definitions (PR #72863)

https://github.com/erichkeane commented: Needs a release note, + this should be replacing errors in the below cases. https://github.com/llvm/llvm-project/pull/72863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72851 >From 28e9fda4b78e1e60287048891cc92bafdef3ac4c Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH 1/2] Introduce [[clang::coro_lifetimebound]] --- clang/include/cla

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/72851 >From 28e9fda4b78e1e60287048891cc92bafdef3ac4c Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Mon, 20 Nov 2023 12:17:30 +0100 Subject: [PATCH 1/3] Introduce [[clang::coro_lifetimebound]] --- clang/include/cla

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/usx95 ready_for_review https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) Changes Adds attribute `[[clang::coro_lifetimebound]]`. All arguments to a function are considered to be **lifetime bound** if the function returns a type annotated with ``[[clang::coro_lifetimebound]]`` and ``[[c

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

alexey-bataev wrote: Need to add tests https://github.com/llvm/llvm-project/pull/72692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

@@ -45,11 +47,36 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = GetOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

erichkeane wrote: > Need to add tests I mentioned in the commit message, that unfortunately this doesn't change behavior in a way that we can discover in our testing (unless you know how to check which character a diagnostic was issued on with `VerifyDiagnosticsConsumer`?). I'd left the test

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

erichkeane wrote: > > Need to add tests > > I mentioned in the commit message, that unfortunately this doesn't change > behavior in a way that we can discover in our testing (unless you know how to > check which character a diagnostic was issued on with > `VerifyDiagnosticsConsumer`?). I'd le

[clang] [Clang] Introduce scoped variants of GNU atomic functions (PR #72280)

yxsamliu wrote: > > > The underlying implementation is a string literal in the LLVM syncscope > > > argument, but the problem is that this isn't standardized at all and > > > varies between backends potentially > > > > > > We don't have to use the same set of strings as syncscope if that does

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

@@ -45,11 +47,36 @@ OpenACCDirectiveKind ParseOpenACCDirectiveKind(Parser &P) { P.ConsumeToken(); std::string FirstTokSpelling = P.getPreprocessor().getSpelling(FirstTok); - OpenACCDirectiveKind DirKind = GetOpenACCDirectiveKind(FirstTokSpelling); + OpenACCDirectiveKind

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72692 >From 33ca88871b48fcfb16bdf7fa636a9ecfa4f38e08 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 11:34:43 -0800 Subject: [PATCH 1/4] [OpenACC] Implement compound construct parsing This patch im

[clang] [llvm] [SVE2.1][Clang][LLVM]Add 128bits builtin in Clang and LLVM intrinisc (PR #71930)

@@ -1992,3 +1992,36 @@ let TargetGuard = "sme2" in { def SVADD_SINGLE_X2 : SInst<"svadd[_single_{d}_x2]", "22d", "cUcsUsiUilUl", MergeNone, "aarch64_sve_add_single_x2", [IsStreaming], []>; def SVADD_SINGLE_X4 : SInst<"svadd[_single_{d}_x4]", "44d", "cUcsUsiUilUl", MergeNon

[clang] 8bd06d5 - [C23] Complete support for WG14 N2508 (#71398)

Author: Aaron Ballman Date: 2023-11-20T10:52:11-05:00 New Revision: 8bd06d5b65845e5e01dd899a2deb773580460b89 URL: https://github.com/llvm/llvm-project/commit/8bd06d5b65845e5e01dd899a2deb773580460b89 DIFF: https://github.com/llvm/llvm-project/commit/8bd06d5b65845e5e01dd899a2deb773580460b89.diff

[clang-tools-extra] [flang] [llvm] [clang] [libc] [libcxx] [compiler-rt] [C23] Complete support for WG14 N2508 (PR #71398)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/71398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/72692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement compound construct parsing (PR #72692)

https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/72692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] Dont alter cold function alignment unless using Os (PR #72387)

pogo59 wrote: > We already have a way to set alignment: it's the "align" attribute. Is clang aware of the target's default function alignment? I'd thought not, in which case deferring to LLVM (as this new attribute does) is correct. Happy to be corrected on this point. > there isn't any obvio

  1   2   3   4   >