[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) { << FixItHint::CreateInsertion(P.first, "self->"); } +void Sema::CheckCoroutineWrapper(FunctionDecl *FD) { + if (!FD || getCurFunction()->isCoroutine()) usx95 wrote: `get

[flang] [clang] [Flang] Add code-object-version option (PR #72638)

2023-11-17 Thread Jan Leyonberg via cfe-commits
https://github.com/jsjodin edited https://github.com/llvm/llvm-project/pull/72638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang] Add code-object-version option (PR #72638)

2023-11-17 Thread Jan Leyonberg via cfe-commits
@@ -264,6 +263,37 @@ static void addDepdendentLibs(mlir::ModuleOp &mlirModule, } } +// Add to MLIR code target specific items which are dependent on target +// configuration specified by the user +static void addTargetSpecificMLIRItems(mlir::ModuleOp &mlirModule, +

[clang] [flang] [Flang] Add code-object-version option (PR #72638)

2023-11-17 Thread Jan Leyonberg via cfe-commits
https://github.com/jsjodin requested changes to this pull request. https://github.com/llvm/llvm-project/pull/72638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Emit bad shift warnings (PR #70307)

2023-11-17 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70307 From c9b85c8e435790d8b4a42340f3963d852e7d65ae Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Thu, 26 Oct 2023 10:39:52 +0200 Subject: [PATCH] [clang] Emit bad shift warnings ---

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Ilya Biryukov via cfe-commits
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) { << FixItHint::CreateInsertion(P.first, "self->"); } +void Sema::CheckCoroutineWrapper(FunctionDecl *FD) { + if (!FD || getCurFunction()->isCoroutine()) ilya-biryukov wrot

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. LGTM assuming the `getCurFunction()` comment is addressed in some form (moving it to callers or adding an assertion) Thanks for the change! https://github.com/llvm/llvm-project/pull/71945 _

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,117 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + + +template struct [[clang::coro_return_type]] Gen { + struct promi

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945 >From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 10 Nov 2023 15:10:44 +0100 Subject: [PATCH 01/11] [coroutines] Introduce [[clang::coro_return_type]] and [[cla

[llvm] [clang] [Offloading][NFC] Refactor handling of offloading entries (PR #72544)

2023-11-17 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield approved this pull request. Test change is suspect for a patch claiming NFC but it looks like the change is harmless. Thanks for separating refactor from functional change https://github.com/llvm/llvm-project/pull/72544

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945 >From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 10 Nov 2023 15:10:44 +0100 Subject: [PATCH 01/12] [coroutines] Introduce [[clang::coro_return_type]] and [[cla

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
@@ -15811,6 +15813,20 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) { << FixItHint::CreateInsertion(P.first, "self->"); } +void Sema::CheckCoroutineWrapper(FunctionDecl *FD) { + if (!FD || getCurFunction()->isCoroutine()) usx95 wrote: Move

[compiler-rt] [llvm] [lld] [clang-tools-extra] [libcxx] [clang] [flang] [lldb] [libunwind] [AMDGPU] - Add constant folding for s_quadmask (PR #72381)

2023-11-17 Thread Jessica Del via cfe-commits
https://github.com/OutOfCache closed https://github.com/llvm/llvm-project/pull/72381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9c0e649 - [Offloading][NFC] Refactor handling of offloading entries (#72544)

2023-11-17 Thread via cfe-commits
Author: Joseph Huber Date: 2023-11-17T08:26:20-06:00 New Revision: 9c0e64999b23046d0b8987a48ddc41a4c6129f9d URL: https://github.com/llvm/llvm-project/commit/9c0e64999b23046d0b8987a48ddc41a4c6129f9d DIFF: https://github.com/llvm/llvm-project/commit/9c0e64999b23046d0b8987a48ddc41a4c6129f9d.diff

[llvm] [clang] [Offloading][NFC] Refactor handling of offloading entries (PR #72544)

2023-11-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/72544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -0,0 +1,33 @@ +// RUN: %clang_cc1 -verify -fsyntax-only %s erichkeane wrote: Typically we find a similar test file and put it there, just wrapped in a namespace for the github issue. https://github.com/llvm/llvm-project/pull/72346 ___

[clang] [Clang] Fix finding instantiated decls for class template specializations during instantiation (PR #72346)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: I don't have a great feel if this is the right fix, but if it doesn't break anything in the tests, and does fix something, this is likely acceptable for now. This DOES need a release note, and as Shafik says: this should likely be placed in an existing

[clang] ff219ea - [OpenACC] Initial commits to support OpenACC (#70234)

2023-11-17 Thread via cfe-commits
Author: Erich Keane Date: 2023-11-17T06:29:02-08:00 New Revision: ff219ea9ca80f46ff85dbdb94622ffb319a0d237 URL: https://github.com/llvm/llvm-project/commit/ff219ea9ca80f46ff85dbdb94622ffb319a0d237 DIFF: https://github.com/llvm/llvm-project/commit/ff219ea9ca80f46ff85dbdb94622ffb319a0d237.diff L

[libc] [llvm] [lld] [clang-tools-extra] [libcxx] [clang] [flang] [lldb] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/70234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
@@ -300,6 +300,11 @@ Attribute Changes in Clang to reduce the size of the destroy functions for coroutines which are known to be destroyed after having reached the final suspend point. +- Clang now introduced ``[[clang::coro_return_type]]`` and ``[[clang::coro_wrapper]]``

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945 >From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 10 Nov 2023 15:10:44 +0100 Subject: [PATCH 01/13] [coroutines] Introduce [[clang::coro_return_type]] and [[cla

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Thank you everyone for the review. https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [libunwind] [clang-tools-extra] [lld] [lldb] [compiler-rt] [libcxxabi] [clang] [llvm] [libc] [flang] [libcxx] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Shahid Iqbal via cfe-commits
https://github.com/shahidiqbal13 created https://github.com/llvm/llvm-project/pull/72654 This issue is raised by @DrTodd13 The code in include/llvm/Analysis/DOTGraphTraitsPass.h will exceed most normal file system's maximum filename length of 255 if, e.g., the function's name is that length.

[mlir] [libunwind] [clang-tools-extra] [lld] [lldb] [compiler-rt] [libcxxabi] [clang] [llvm] [libc] [flang] [libcxx] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis Author: Shahid Iqbal (shahidiqbal13) Changes This issue is raised by @DrTodd13 The code in include/llvm/Analysis/DOTGraphTraitsPass.h will exceed most normal file system's maximum filename length of 255 if, e.g., the function's name is t

[mlir] [libunwind] [clang-tools-extra] [lld] [lldb] [compiler-rt] [libcxxabi] [clang] [llvm] [libc] [flang] [libcxx] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 44af5924b1cbbb395e7e71250a5445053c4ec4a3 7662d4f177d32c3159c1c48b11ce3884e4ea78c8 --

[mlir] [libunwind] [clang-tools-extra] [lld] [lldb] [compiler-rt] [libcxxabi] [clang] [llvm] [libc] [flang] [libcxx] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Shahid Iqbal via cfe-commits
https://github.com/shahidiqbal13 updated https://github.com/llvm/llvm-project/pull/72654 >From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001 From: Shahid Iqbal Date: Thu, 16 Nov 2023 11:26:43 -0500 Subject: [PATCH 1/3] TESTING infra --- clang/NOTES.txt | 2 ++ 1 file chang

[flang] [compiler-rt] [lldb] [lld] [libcxx] [llvm] [mlir] [libcxxabi] [clang] [libunwind] [libc] [clang-tools-extra] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Shahid Iqbal via cfe-commits
https://github.com/shahidiqbal13 updated https://github.com/llvm/llvm-project/pull/72654 >From b6bfb18e25c111baf6c95a0a4a1c3d667bb25b6d Mon Sep 17 00:00:00 2001 From: Shahid Iqbal Date: Thu, 16 Nov 2023 11:26:43 -0500 Subject: [PATCH 1/4] TESTING infra --- clang/NOTES.txt | 2 ++ 1 file chang

[clang] [clang][Interp] Fix float->int casts overflowing (PR #72658)

2023-11-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/72658 If S.noteUndefinedBehavior() returns true, we will continue evaluation and need a value on the stack. >From 070102561f8af1916b860225c79f07009cf368b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?=

[clang] [clang][Interp] Fix float->int casts overflowing (PR #72658)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes If S.noteUndefinedBehavior() returns true, we will continue evaluation and need a value on the stack. --- Full diff: https://github.com/llvm/llvm-project/pull/72658.diff 2 Files Affected: - (modified) cla

[clang] [clang][Interp] Decay pointers to the first element (PR #72660)

2023-11-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/72660 I _think_ this makes sense to do here. This way we have a pointer to the first element on the stack. >From 7ea07d2aa8be337e1ff4ff2e28ae407c57a382fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?=

[clang] [clang][Interp] Decay pointers to the first element (PR #72660)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes I _think_ this makes sense to do here. This way we have a pointer to the first element on the stack. --- Full diff: https://github.com/llvm/llvm-project/pull/72660.diff 2 Files Affected: - (modified) clan

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/72661 As the first real parsing effort for the OpenACC implementation effort, this implements the parsing for construct/directive names. This does not do any semantic analysis, nor any parsing for the parens for af

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-11-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/72660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes As the first real parsing effort for the OpenACC implementation effort, this implements the parsing for construct/directive names. This does not do any semantic analysis, nor any parsing for the parens for

[clang] 965d301 - [clang][Interp] Implement __builtin_classify_type (#71972)

2023-11-17 Thread via cfe-commits
Author: Timm Baeder Date: 2023-11-17T16:13:23+01:00 New Revision: 965d301dff1837e2a7a0671c549bcf7ddb350486 URL: https://github.com/llvm/llvm-project/commit/965d301dff1837e2a7a0671c549bcf7ddb350486 DIFF: https://github.com/llvm/llvm-project/commit/965d301dff1837e2a7a0671c549bcf7ddb350486.diff L

[clang] [clang][Interp] Implement __builtin_classify_type (PR #71972)

2023-11-17 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/71972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [compiler-rt] [lldb] [lld] [libcxx] [llvm] [mlir] [libcxxabi] [clang] [libunwind] [libc] [clang-tools-extra] [lldb][test] Add the ability to extract the variable value out of the summary. (PR

2023-11-17 Thread Walter Erquinigo via cfe-commits
https://github.com/walter-erquinigo approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/72631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libcxxabi] [libcxx] [clang-tools-extra] [lldb] [mlir] [libc] [clang] [lld] [flang] [compiler-rt] [libunwind] [lldb][test] Add the ability to extract the variable value out of the summary. (PR

2023-11-17 Thread Walter Erquinigo via cfe-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/72631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8f81c605f5f450c4b4b641f805935a85b9409d98 01fc81b37ad744a265f712b26fd6c3a85430c719 --

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72661 >From 01fc81b37ad744a265f712b26fd6c3a85430c719 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 06:29:35 -0800 Subject: [PATCH 1/2] [OpenACC] Implement initial parsing for Construct/Directive

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,72 @@ +//===--- OpenACCKinds.h - OpenACC Enums -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -3531,7 +3535,7 @@ class Parser : public CodeCompletionHandler { /// Placeholder for now, should just ignore the directives after emitting a /// diagnostic. Eventually will be split into a few functions to parse /// different situations. - DeclGroupPtrTy ParseOpenACCD

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -0,0 +1,72 @@ +//===--- OpenACCKinds.h - OpenACC Enums -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [Tooling/Inclusion] Avoid narrowing-conversions in macro expansion (PR #72664)

2023-11-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/72664 ``` clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:144:65: warning: narrowing conversion of ‘llvm::StringRef(((const char*)"std::experimental::filesystem::")).llvm::StringRef::size()’ from ‘size_t’ {a

[clang] [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (PR #72664)

2023-11-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/72664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (PR #72664)

2023-11-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes ``` clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:144:65: warning: narrowing conversion of ‘llvm::StringRef(((const char*)"std::experimental::filesystem::")).llvm::StringRef::size()’ from

[clang] [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (PR #72664)

2023-11-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/72664 >From a6c711d61221558bad907a8e1a4944260d38c6ae Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 17 Nov 2023 09:18:02 -0600 Subject: [PATCH] [Tooling/Inclusion] Avoid narrowing conversions in macro

[clang] [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (PR #72664)

2023-11-17 Thread Benjamin Kramer via cfe-commits
https://github.com/d0k approved this pull request. https://github.com/llvm/llvm-project/pull/72664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/71945 >From 89a2d60fc012742a74a008fb77213bcd47734503 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 10 Nov 2023 15:10:44 +0100 Subject: [PATCH 01/14] [coroutines] Introduce [[clang::coro_return_type]] and [[cla

[clang] 7d1a9e8 - [OpenACC] Rename ParseOpenACCDirective to ParseOpenACCDirectiveDecl

2023-11-17 Thread via cfe-commits
Author: erichkeane Date: 2023-11-17T07:28:33-08:00 New Revision: 7d1a9e81b0b59d020a52c789d659acb5ee5fdc41 URL: https://github.com/llvm/llvm-project/commit/7d1a9e81b0b59d020a52c789d659acb5ee5fdc41 DIFF: https://github.com/llvm/llvm-project/commit/7d1a9e81b0b59d020a52c789d659acb5ee5fdc41.diff LO

[llvm] [clang] [lldb] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72661 >From 01fc81b37ad744a265f712b26fd6c3a85430c719 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 06:29:35 -0800 Subject: [PATCH 1/2] [OpenACC] Implement initial parsing for Construct/Directive

[llvm] [clang] [lldb] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -3531,7 +3535,7 @@ class Parser : public CodeCompletionHandler { /// Placeholder for now, should just ignore the directives after emitting a /// diagnostic. Eventually will be split into a few functions to parse /// different situations. - DeclGroupPtrTy ParseOpenACCD

[llvm] [clang] [lldb] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70353 >From be2381c9e795af6dc6eec9a3eb9a0ef467edfe5c Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 26 Oct 2023 18:40:15 +0200 Subject: [PATCH] [Clang] Warn on deprecated specializations used in system head

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-17 Thread via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/69704 >From b88cdbcd106e27d3e594dc06824df10d77f9402b Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 19 Oct 2023 17:51:11 +0200 Subject: [PATCH] [clangd] Allow "move function body out-of-line" in non-hea

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/70353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/70353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,28 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +#ifdef BE_THE_HEADER +#pragma clang system_header + +template +struct traits; + +template <> +struct [[ deprecated]] traits {}; // expected-note {{'traits' has been explicitly marked deprecated here}} -

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread Aaron Ballman via cfe-commits
@@ -11615,3 +11615,25 @@ void Sema::checkSpecializationReachability(SourceLocation Loc, Sema::AcceptableKind::Reachable) .check(Spec); } + +/// Returns the top most location responsible for the definition of \p N. +/// If \p N is

[clang] [lldb] [llvm] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70353 >From be2381c9e795af6dc6eec9a3eb9a0ef467edfe5c Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 26 Oct 2023 18:40:15 +0200 Subject: [PATCH 1/2] [Clang] Warn on deprecated specializations used in system

[clang] [llvm] [lldb] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -0,0 +1,72 @@ +//===--- OpenACCKinds.h - OpenACC Enums -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2023-11-17 Thread via cfe-commits
ckandeler wrote: The new patch set inserts at the end of the namespace block for the same-file case. https://github.com/llvm/llvm-project/pull/69704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[libc] [clang-tools-extra] [libcxx] [clang] [lld] [lldb] [flang] [llvm] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-17 Thread Shilei Tian via cfe-commits
shiltian wrote: We will want to have OpenACC label(s) such that people who are interested can be notified. https://github.com/llvm/llvm-project/pull/70234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[libc] [clang-tools-extra] [libcxx] [clang] [lld] [lldb] [flang] [llvm] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-17 Thread Erich Keane via cfe-commits
erichkeane wrote: > We will want to have OpenACC label(s) such that people who are interested can > be notified. Done, see the next patch in the set here: https://github.com/llvm/llvm-project/pull/72661 I'll start adding them and see if I can get @llvmbot to teach me how to add it. https://

[clang] [lldb] [llvm] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[clang] [lldb] [llvm] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -10,18 +10,240 @@ // //===--===// +#include "clang/Basic/OpenACCKinds.h" #include "clang/Parse/ParseDiagnostic.h" #include "clang/Parse/Parser.h" +#include "clang/Parse/RAIIObjectsForParser.h" +#include

[lldb] [clang] [llvm] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
@@ -0,0 +1,72 @@ +//===--- OpenACCKinds.h - OpenACC Enums -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [libcxx] [flang] [lldb] [llvm] [libc] [lld] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-17 Thread Shilei Tian via cfe-commits
shiltian wrote: You might also want to update the team "pr-subscribers-openacc" because currently it only reflects Flang. https://github.com/llvm/llvm-project/pull/70234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[flang] [libc] [libunwind] [libcxx] [clang-tools-extra] [libcxxabi] [lld] [llvm] [lldb] [clang] [compiler-rt] [mlir] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
https://github.com/DrTodd13 requested changes to this pull request. I don't think these changes as they are solve the problem. https://github.com/llvm/llvm-project/pull/72654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [libunwind] [lldb] [lld] [flang] [compiler-rt] [clang-tools-extra] [llvm] [libc] [libcxx] [mlir] [libcxxabi] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); DrTodd13 wrote: If Filename is too long, then EC here will already contain an error code. https://github.com/

[libunwind] [libcxxabi] [clang] [mlir] [compiler-rt] [clang-tools-extra] [libcxx] [flang] [lldb] [llvm] [libc] [lld] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
https://github.com/DrTodd13 edited https://github.com/llvm/llvm-project/pull/72654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [libunwind] [libcxx] [libcxxabi] [libc] [clang] [lldb] [compiler-rt] [lld] [clang-tools-extra] [flang] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -310,7 +312,7 @@ void WriteDOTGraphToFile(Function &F, GraphT &&Graph, std::string GraphName = DOTGraphTraits::getGraphName(Graph); std::string Title = GraphName + " for '" + F.getName().str() + "' function"; - if (!EC) + if (!EC && (Filename.length() <= MAX_FILENAME_

[llvm] [clang-tools-extra] [libcxx] [flang] [clang] [libc] [mlir] [lldb] [compiler-rt] [libunwind] [lld] [libcxxabi] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); std::string GraphName = DOTGraphTraits::getGraphName(Graph); - if (!EC) + if (!EC && (Filename.length() <= MAX_FILENAME_L

[clang] [libc] [libcxxabi] [mlir] [llvm] [compiler-rt] [lldb] [flang] [lld] [libcxx] [clang-tools-extra] [libunwind] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); DrTodd13 wrote: I needed to work around this bug when I found it so in my local version I did a (Name.str() +

[compiler-rt] [mlir] [libc] [libcxxabi] [clang-tools-extra] [libunwind] [libcxx] [clang] [lld] [lldb] [flang] [llvm] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Todd A. Anderson via cfe-commits
@@ -280,7 +282,7 @@ class DOTGraphTraitsModulePrinterWrapperPass : public ModulePass { raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); std::string Title = DOTGraphTraits::getGraphName(Graph); -if (!EC) +if (!EC && (Filename.length() <= MAX_FILENAM

[lldb] [clang] [llvm] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
@@ -0,0 +1,72 @@ +//===--- OpenACCKinds.h - OpenACC Enums -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc] [libcxxabi] [mlir] [llvm] [compiler-rt] [lldb] [flang] [lld] [libcxx] [clang-tools-extra] [libunwind] PR#72453 : Exceeding maximum file name length (PR #72654)

2023-11-17 Thread Shahid Iqbal via cfe-commits
@@ -94,7 +96,7 @@ void printGraphForFunction(Function &F, GraphT Graph, StringRef Name, raw_fd_ostream File(Filename, EC, sys::fs::OF_TextWithCRLF); shahidiqbal13 wrote: @DrTodd13 , Will change the fix later , need to think https://github.com/llvm/llvm-proje

[clang] c601be9 - [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (#71945)

2023-11-17 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2023-11-17T17:29:30+01:00 New Revision: c601be9c8400929f7b5c015a2bceae57e3aab550 URL: https://github.com/llvm/llvm-project/commit/c601be9c8400929f7b5c015a2bceae57e3aab550 DIFF: https://github.com/llvm/llvm-project/commit/c601be9c8400929f7b5c015a2bceae57e3aab550.diff

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

2023-11-17 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for Construct/Directive Names (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/72661 >From 01fc81b37ad744a265f712b26fd6c3a85430c719 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 17 Nov 2023 06:29:35 -0800 Subject: [PATCH 1/3] [OpenACC] Implement initial parsing for Construct/Directive

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Erich Keane via cfe-commits
erichkeane wrote: @alexey-bataev : Patch reduced to just parallel as requested. https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [llvm] [clang] [OpenACC] Implement initial parsing for `parallel` construct (PR #72661)

2023-11-17 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/72661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add includes from source to non-self-contained headers (PR #72479)

2023-11-17 Thread via cfe-commits
https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/72479 >From 032fddf0fbb03f0e3da86505aa81634a8a8e1cbc Mon Sep 17 00:00:00 2001 From: SR_team Date: Thu, 16 Nov 2023 07:15:10 +0200 Subject: [PATCH] Add includes from source to non-self-contained headers --- clang-too

[llvm] [compiler-rt] [clang] [clang-tools-extra] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts for local functions at O0 (PR #72129)

2023-11-17 Thread Janek van Oirschot via cfe-commits
https://github.com/JanekvO updated https://github.com/llvm/llvm-project/pull/72129 >From 04b0856ae59ff367fd1b6736d49430648976cb25 Mon Sep 17 00:00:00 2001 From: Janek van Oirschot Date: Mon, 13 Nov 2023 07:38:15 -0800 Subject: [PATCH 1/2] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts

[llvm] [compiler-rt] [clang] [clang-tools-extra] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts for local functions at O0 (PR #72129)

2023-11-17 Thread Janek van Oirschot via cfe-commits
https://github.com/JanekvO updated https://github.com/llvm/llvm-project/pull/72129 >From 04b0856ae59ff367fd1b6736d49430648976cb25 Mon Sep 17 00:00:00 2001 From: Janek van Oirschot Date: Mon, 13 Nov 2023 07:38:15 -0800 Subject: [PATCH 1/3] [AMDGPU] Avoid hitting AMDGPUAsmPrinter related asserts

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-11-17 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70772 >From 5436d89e4ca3fbb1d53f27f8d5347f3eff100dd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 31 Oct 2023 07:17:16 +0100 Subject: [PATC

[clang] 764c3af - [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (#72664)

2023-11-17 Thread via cfe-commits
Author: Krzysztof Parzyszek Date: 2023-11-17T10:53:43-06:00 New Revision: 764c3afd43128f7ccddb070953c330b340ebe811 URL: https://github.com/llvm/llvm-project/commit/764c3afd43128f7ccddb070953c330b340ebe811 DIFF: https://github.com/llvm/llvm-project/commit/764c3afd43128f7ccddb070953c330b340ebe811

[clang] [Tooling/Inclusion] Avoid narrowing conversions in macro expansion (PR #72664)

2023-11-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/72664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesManager (PR #72389)

2023-11-17 Thread Nico Weber via cfe-commits
nico wrote: I was wondering what this is. It looks like we have documentation that describes it at https://clang.llvm.org/docs/APINotes.html (in case anyone else is wondering too). https://github.com/llvm/llvm-project/pull/72389 ___ cfe-commits maili

[clang] [clang codegen][regression] Add dso_local/hidden/etc. markings to VTT definitions and declarations (PR #72452)

2023-11-17 Thread via cfe-commits
bd1976bris wrote: > I'd prefer not to call setGVProperties() twice on the same variable; under > what conditions is the first call not sufficient? The test-case I posted is one such scenario: https://godbolt.org/z/s4rPffsrK. I suspect it may be related to whether there is a key function presen

[clang] aafad2d - [Clang] Warn on deprecated specializations used in system headers. (#70353)

2023-11-17 Thread via cfe-commits
Author: cor3ntin Date: 2023-11-17T18:16:34+01:00 New Revision: aafad2d214246bae4d53ce3178b11486ebc83890 URL: https://github.com/llvm/llvm-project/commit/aafad2d214246bae4d53ce3178b11486ebc83890 DIFF: https://github.com/llvm/llvm-project/commit/aafad2d214246bae4d53ce3178b11486ebc83890.diff LOG:

[clang] [Clang] Warn on deprecated specializations used in system headers. (PR #70353)

2023-11-17 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/70353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >