[llvm] [clang] [AIX] Enable tests relating to 64-bit XCOFF object files (PR #71814)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jake Egan (jakeegan) Changes We now have 64-bit XCOFF object file support, so these tests can be enabled again. However, some tests still fail due to unsupported debug sections, so I cleaned up their comments. --- Patch is 24.37 KiB, t

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 558061. gedare added a comment. Add TokenAnnotator tests and light refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156370/new/ https://reviews.llvm.org/D156370 Files: clang/lib/Format/TokenAnnotato

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare abandoned this revision. gedare added a comment. This is not needed due to https://github.com/llvm/llvm-project/pull/70768 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154550/new/ https://reviews.llvm.org/D154550 __

[llvm] [clang] [clang-tools-extra] [SimplifyCFG] Prevent merging cbranch to cbranch if the branch probability from the first to second is too low. (PR #69375)

2023-11-09 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: Guys, I really need this change submitted, I'm going to submit it on monday if there're no objections. https://github.com/llvm/llvm-project/pull/69375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-09 Thread via cfe-commits
jyu2-git wrote: Hi @efriedma-quic, Thanks for looking into this. First for test case: We are having difficult to reproduce the problem with small test case, the error come from very big application, which related various heuristics to trigger in a specific way to get the symbol renaming to ha

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 558063. gedare added a comment. Rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154755/new/ https://reviews.llvm.org/D154755 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/For

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
@@ -0,0 +1,56 @@ +; REQUIRES: arm-registered-target +; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m85 -mfloat-abi=hard -save-temps=obj -S -o - %s | FileCheck %s +; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m55 -mfloat-abi=hard -save-temps=obj -S -o - %s | FileCheck %s

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare added a comment. @MyDeveloperDay ping I have rebased to main without any problems. This patch fixes the bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154755/new/ https://reviews.llvm.org/D154755 ___

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
simpal01 wrote: > I think the commit title would make more sense at a glance if it was saying > what is being done instead of what's being fixed. How about: > > ``` > [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not > include MVE features > ``` > > Then the commit mess

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
simpal01 wrote: > I think the commit title would make more sense at a glance if it was saying > what is being done instead of what's being fixed. How about: > > ``` > [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not > include MVE features > ``` > > Then the commit mess

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-09 Thread Samira Bazuzi via cfe-commits
bazuzi wrote: Could you merge for me? I don't have write access. https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3001d6d - [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (#71573)

2023-11-09 Thread via cfe-commits
Author: Samira Bazuzi Date: 2023-11-09T16:57:04+01:00 New Revision: 3001d6ddaa7809274e49b794cb7ec07d21da130e URL: https://github.com/llvm/llvm-project/commit/3001d6ddaa7809274e49b794cb7ec07d21da130e DIFF: https://github.com/llvm/llvm-project/commit/3001d6ddaa7809274e49b794cb7ec07d21da130e.diff

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-09 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix buggy assertion: Compare an unqualified type to an unqualified type. (PR #71573)

2023-11-09 Thread via cfe-commits
martinboehme wrote: > Could you merge for me? I don't have write access. Done! https://github.com/llvm/llvm-project/pull/71573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' handling in StdLibraryFunctionsChecker. (PR #71392)

2023-11-09 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/71392 From e92bf72fc80bb6823996cb71cb811d238b304aaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 2 Nov 2023 18:12:32 +0100 Subject: [PATCH 1/3] [clang][analyzer] Improve 'errno' handli

[clang] [X86][AVX10] Permit AVX512 options/features used together with AVX10 (PR #71318)

2023-11-09 Thread Shengchen Kan via cfe-commits
@@ -131,35 +135,50 @@ bool X86TargetInfo::initFeatureMap( continue; } -if (Feature.substr(0, 7) == "+avx10.") { - HasAVX10 = true; - HasAVX512F = true; - if (Feature.substr(Feature.size() - 3, 3) == "512") { -HasEVEX512 = true; - } els

[llvm] [clang] [clang-tools-extra] [CodeGen] Revamp counted_by calculations (PR #70606)

2023-11-09 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna approved this pull request. Thank you! LGTM. https://github.com/llvm/llvm-project/pull/70606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][AVX10] Permit AVX512 options/features used together with AVX10 (PR #71318)

2023-11-09 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. LGTM. Maybe we can add some explanations about why we add attribute `no-evex512` for intrinsics in the description of the PR. It's a little tricky. https://github.com/llvm/llvm-project/pull/71318 __

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Iain Sandoe via cfe-commits
iains wrote: Let us try to determine fundamental constraints. To produce a BMI (David's ImplementationBMI) that can generate the object file, it must contain all the AST. this is equivalent to hypothetical ` clang++ -x c++-module foo.cpp --prepcompile -fmodule-file=X=X-implementation.pcm`

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Iain Sandoe via cfe-commits
iains wrote: > > clang++ -std=c++20 foo.cpp -c -fmodule-file=X=some/dir/X.pcm > > Hm, according to https://clang.llvm.org/docs/StandardCPlusPlusModules.html > this can already be achieved with the `-fmodule-output` option (and which I > was about to try in `build2`). Is there a reason a diffe

[llvm] [clang] Remove experimental from Vector Crypto extensions (PR #69000)

2023-11-09 Thread Craig Topper via cfe-commits
https://github.com/topperc commented: Do we need to add the "experimental" feature to RISCVFeatures.td? If the feature string shows up in the function attributes, won't the backend print that it doesn't recognize the feature name when it parses the string? https://github.com/llvm/llvm-project/

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 558064. gedare added a comment. Rebase to main. Fix up use of TT_AttributeParen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOp

[clang] [flang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread via cfe-commits
https://github.com/jeanPerier created https://github.com/llvm/llvm-project/pull/71820 Patch 1/3 of the transition to use the HLFIR step by default in lowering as described in https://discourse.llvm.org/t/rfc-enabling-the-hlfir-lowering-by-default/72778/7 This option will allow to lower code w

[clang] [flang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (jeanPerier) Changes Patch 1/3 of the transition to use the HLFIR step by default in lowering as described in https://discourse.llvm.org/t/rfc-enabling-the-hlfir-lowering-by-default/72778/7 This option will allow to lower cod

[llvm] [clang] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics (PR #71795)

2023-11-09 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/71795 >From 9846bc9efd79e6e3c2662ea42367c102df88799d Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Thu, 9 Nov 2023 10:50:05 + Subject: [PATCH 1/3] [AArch64][SME2] Add ldr_zt, str_zt builtins and intrinsics

[llvm] [libc] [flang] [clang] [libcxx] [compiler-rt] [clang-tools-extra] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/71545 >From c7c02e2bea3cb6fb674a5e568b7d14998776c00f Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Tue, 7 Nov 2023 13:05:08 + Subject: [PATCH] [ARM] .fpu equals fpv5-d16 disables floating point MVE which

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-11-09 Thread Serge Pavlov via cfe-commits
spavloff wrote: `pragma pack` uses pragma stack and it is allowed in any place: https://godbolt.org/z/f8fP1vn63 . If such pragma presents in the late-parsed template, and push-pop operations in it are not balanced, the late parse of such function can break the pragma stack and next templates c

[clang-tools-extra] [flang] [clang] [compiler-rt] [llvm] [RISCV] Add bset optimization for left shift code (PR #71420)

2023-11-09 Thread Ryan Taylor via cfe-commits
https://github.com/rtayl updated https://github.com/llvm/llvm-project/pull/71420 >From 284c04113dcb3d683e8eaad3242d5bc5d0b4987d Mon Sep 17 00:00:00 2001 From: Ryan Taylor Date: Mon, 6 Nov 2023 10:54:17 -0500 Subject: [PATCH] [RISCV] Add bset optimization for left shift code Changes: li a1, -1

[clang] [openmp] [llvm] [OpenMP] Rework handling of global ctor/dtors in OpenMP (PR #71739)

2023-11-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/71739 >From 45a645c4e65d3b1f98dee23c2eba1cf6db99bff0 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Tue, 7 Nov 2023 17:12:31 -0600 Subject: [PATCH] [OpenMP] Rework handling of global ctor/dtors in OpenMP Summary: T

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-11-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/69340 >From 610d0b544d7927af93b6943078df033f154b74f8 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Thu, 9 Nov 2023 09:30:24 -0700 Subject: [PATCH 1/2] Revert "Revert "[clang-format] Fix align consecutive declaratio

[llvm] [openmp] [clang] [OpenMP] Rework handling of global ctor/dtors in OpenMP (PR #71739)

2023-11-09 Thread Joseph Huber via cfe-commits
@@ -2794,6 +2794,14 @@ void ItaniumCXXABI::registerGlobalDtor(CodeGenFunction &CGF, const VarDecl &D, if (D.isNoDestroy(CGM.getContext())) return; + // OpenMP offloading supports C++ constructors and destructors but we do not + // always have 'atexit' available. Inste

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-11-09 Thread Gedare Bloom via cfe-commits
gedare wrote: force push was required to layer the revert commit correctly. https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] readability-identifier-naming: add support for concepts (PR #71586)

2023-11-09 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/71586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6fdb1bf - [clang-tidy] readability-identifier-naming: add support for concepts (#71586)

2023-11-09 Thread via cfe-commits
Author: nvartolomei Date: 2023-11-09T18:18:40+01:00 New Revision: 6fdb1bfbc7846f9978fe98c658deb440534d2ca0 URL: https://github.com/llvm/llvm-project/commit/6fdb1bfbc7846f9978fe98c658deb440534d2ca0 DIFF: https://github.com/llvm/llvm-project/commit/6fdb1bfbc7846f9978fe98c658deb440534d2ca0.diff L

[clang] [flang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread Tom Eccles via cfe-commits
@@ -1073,6 +1073,12 @@ bool CompilerInvocation::createFromArgs( res.loweringOpts.setLowerToHighLevelFIR(true); } + // -flang-deprecated-no-hlfir + if (args.hasArg(clang::driver::options::OPT_flang_deprecated_no_hlfir) && + !args.hasArg(clang::driver::options::OPT_

[clang] [flang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread Tom Eccles via cfe-commits
https://github.com/tblah requested changes to this pull request. Thanks for this! Please could you also add testing in flang/Driver/frontend-forwarding.f90, flang/test/HLFIR/hlfir-flang.f90 https://github.com/llvm/llvm-project/pull/71820 ___ cfe-comm

[clang] [flang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread Tom Eccles via cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/71820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME2] Add single and multi min and max builtins (PR #71688)

2023-11-09 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm approved this pull request. Thanks @SamTebbs33, I just have one small suggestion but otherwise this LGTM. https://github.com/llvm/llvm-project/pull/71688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Clang][SME2] Add single and multi min and max builtins (PR #71688)

2023-11-09 Thread Kerry McLaughlin via cfe-commits
https://github.com/kmclaughlin-arm edited https://github.com/llvm/llvm-project/pull/71688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SME2] Add single and multi min and max builtins (PR #71688)

2023-11-09 Thread Kerry McLaughlin via cfe-commits
@@ -1987,8 +1987,26 @@ defm SVREVD : SInstZPZ<"svrevd", "csilUcUsUiUl", "aarch64_sve_revd">; // SME intrinsics which operate only on vectors and do not require ZA should be added here, // as they could possibly become SVE instructions in the future. +multiclass MinMaxIntr {

[clang] [clang][CodeGen] Ensure consistent `mustprogress` attribute emission across all paths (PR #71452)

2023-11-09 Thread Antonio Frighetto via cfe-commits
@@ -1482,6 +1477,11 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn, } else llvm_unreachable("no definition for emitted function"); + // This is checked after emitting the function body so we know if there + // are any permitted infinite loops.

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-09 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/71748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-09 Thread Reid Kleckner via cfe-commits
rnk wrote: > I guess that's > https://github.com/llvm/llvm-project/commit/b2615aa44d0cabd821b7afe5acdc847af9937c76... > but I'm pretty sure we fixed -fdata-sections so the backend automatically > generates comdats. So maybe we should just revert that. That seems reasonable, however, there are

[llvm] [flang] [libc] [clang] [libcxx] [compiler-rt] [clang-tools-extra] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/71545 >From c7c02e2bea3cb6fb674a5e568b7d14998776c00f Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Tue, 7 Nov 2023 13:05:08 + Subject: [PATCH 1/2] [ARM] .fpu equals fpv5-d16 disables floating point MVE wh

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-09 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > That seems reasonable, however, there are other QOI reasons for attempting to > generate globally unique names for lambdas Sure. But we wouldn't want to special-case vftables for that. > I think our strategy to ensure internal lambdas like this are globally unique > is

[clang] [Clang][SME2] Add single and multi min/max by vector builtins (PR #71707)

2023-11-09 Thread Kerry McLaughlin via cfe-commits
@@ -0,0 +1,444 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target + +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme2 -target-feature +sve2 -S -disable-O0-optnone -Werror -Wall -emit-llv

[clang] [clang][CodeGen] Ensure consistent `mustprogress` attribute emission across all paths (PR #71452)

2023-11-09 Thread Eli Friedman via cfe-commits
@@ -1482,6 +1477,11 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD, llvm::Function *Fn, } else llvm_unreachable("no definition for emitted function"); + // This is checked after emitting the function body so we know if there + // are any permitted infinite loops.

[clang] [llvm] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

2023-11-09 Thread Momchil Velikov via cfe-commits
@@ -1457,6 +1457,24 @@ class AdvSIMD_GatherLoad_VS_Intrinsic ], [IntrReadMem]>; +class AdvSIMD_GatherLoadQ_VS_Intrinsic +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], +[ + llvm_nxv1i1_ty, + ll

[clang] [AMDGPU] - Add clang builtins for tied WMMA intrinsics (PR #70669)

2023-11-09 Thread Stanislav Mekhanoshin via cfe-commits
@@ -292,13 +292,17 @@ TARGET_BUILTIN(__builtin_amdgcn_wmma_f32_16x16x16_f16_w32, "V8fV16hV16hV8f", "nc TARGET_BUILTIN(__builtin_amdgcn_wmma_f32_16x16x16_bf16_w32, "V8fV16sV16sV8f", "nc", "gfx11-insts") TARGET_BUILTIN(__builtin_amdgcn_wmma_f16_16x16x16_f16_w32, "V16hV16hV16hV1

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/71545 >From e2b6fa1cb088f2c3cf05a38959a3f3d34eda92c5 Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Tue, 7 Nov 2023 13:05:08 + Subject: [PATCH 1/2] [ARM] .fpu equals fpv5-d16 disables floating point MVE wh

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
@@ -0,0 +1,56 @@ +; REQUIRES: arm-registered-target +; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m85 -mfloat-abi=hard -save-temps=obj -S -o - %s | FileCheck %s +; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m55 -mfloat-abi=hard -save-temps=obj -S -o - %s | FileCheck %s

[llvm] [clang] [llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not include MVE features (PR #71545)

2023-11-09 Thread via cfe-commits
@@ -0,0 +1,56 @@ +; REQUIRES: arm-registered-target +; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m85 -mfloat-abi=hard -save-temps=obj -S -o - %s | FileCheck %s +; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m55 -mfloat-abi=hard -save-temps=obj -S -o - %s | FileCheck %s

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-09 Thread Jun Wang via cfe-commits
@@ -52,6 +52,11 @@ static cl::opt ForceEmitZeroFlag( cl::desc("Force all waitcnt instrs to be emitted as s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)"), cl::init(false), cl::Hidden); +static cl::opt +PreciseMemOpFlag("amdgpu-precise-memory-op", + cl::de

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-09 Thread via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/71738 >From 592e0de1d87ad5dbfc7a1fb80974546ce161c02f Mon Sep 17 00:00:00 2001 From: zhijian Date: Wed, 8 Nov 2023 11:27:30 -0500 Subject: [PATCH 1/4] [Driver][LTO] Copy fix empty stats filename to AIX --- clang/lib

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-09 Thread Jun Wang via cfe-commits
@@ -1809,6 +1816,23 @@ bool SIInsertWaitcnts::shouldFlushVmCnt(MachineLoop *ML, return HasVMemLoad && UsesVgprLoadedOutside; } +bool SIInsertWaitcnts::insertWaitcntAfterMemOp(MachineFunction &MF) { + bool Modified = false; + + for (auto &MBB : MF) { jwangg

[clang] [MS-ABI] create unique vftable name for vftable defined with internal alias. (PR #71748)

2023-11-09 Thread Reid Kleckner via cfe-commits
rnk wrote: > In the testcase, the lambda is just at global scope. Not sure what you're > expecting to happen here. I think that's what I'm trying to get at, this strategy is incomplete and didn't work. I think a principled fix to the general problem would be to incorporate the anonymous name

[clang] [CodeGen] Implement post-opt linking option for builtin bitocdes (PR #69371)

2023-11-09 Thread Jacob Lambert via cfe-commits
@@ -113,7 +120,7 @@ class EmitAssemblyHelper { const CodeGenOptions &CodeGenOpts; const clang::TargetOptions &TargetOpts; const LangOptions &LangOpts; - Module *TheModule; + llvm::Module *TheModule; lamb-j wrote: When including the new BackendConsumer.

[llvm] [clang-tools-extra] [clang] [CodeGen] Revamp counted_by calculations (PR #70606)

2023-11-09 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/70606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bc09ec6 - [CodeGen] Revamp counted_by calculations (#70606)

2023-11-09 Thread via cfe-commits
Author: Bill Wendling Date: 2023-11-09T10:18:17-08:00 New Revision: bc09ec696209b3aea74d49767b15c2f34e363933 URL: https://github.com/llvm/llvm-project/commit/bc09ec696209b3aea74d49767b15c2f34e363933 DIFF: https://github.com/llvm/llvm-project/commit/bc09ec696209b3aea74d49767b15c2f34e363933.diff

[llvm] [clang-tools-extra] [clang] [CodeGen] Revamp counted_by calculations (PR #70606)

2023-11-09 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/70606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread via cfe-commits
https://github.com/jeanPerier updated https://github.com/llvm/llvm-project/pull/71820 >From bf7d4afdde4cae23f28bd8725f9a09b7141b7ed1 Mon Sep 17 00:00:00 2001 From: Jean Perier Date: Thu, 9 Nov 2023 03:11:31 -0800 Subject: [PATCH 1/2] [flang][driver] add -flang-deprecated-no-hlfir hidden option

[flang] [clang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread via cfe-commits
jeanPerier wrote: > Please could you also add testing in flang/Driver/frontend-forwarding.f90, > flang/test/HLFIR/hlfir-flang.f90 Thanks for the review @tblah. I could not find flang/test/HLFIR/hlfir-flang.f90 test, did you mean flang/test/HLFIR/hlfir-**flags**.f90 (in which case it is update

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-11-09 Thread John McCall via cfe-commits
rjmccall wrote: > pragma pack uses pragma stack and it is allowed in any place: > https://godbolt.org/z/f8fP1vn63 . If such pragma presents in the late-parsed > template, and push-pop operations in it are not balanced, the late parse of > such function can break the pragma stack and next templ

[clang] [Driver][LTO] Copy fix empty stats filename to AIX (PR #71738)

2023-11-09 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu approved this pull request. LGTM! Thanks so much! https://github.com/llvm/llvm-project/pull/71738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64] Add quadword gather load/scatter store intrinsics with unscaled vector offset (PR #71290)

2023-11-09 Thread Momchil Velikov via cfe-commits
@@ -9497,8 +9500,11 @@ Value *CodeGenFunction::EmitSVEScatterStore(const SVETypeFlags &TypeFlags, // mapped to . However, this might be incompatible with the // actual type being stored. For example, when storing doubles (i64) the // predicated should be instead. At the

[clang] [CodeGen] Implement post-opt linking option for builtin bitocdes (PR #69371)

2023-11-09 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Implement post-opt linking option for builtin bitocdes (PR #69371)

2023-11-09 Thread Jacob Lambert via cfe-commits
@@ -113,7 +120,7 @@ class EmitAssemblyHelper { const CodeGenOptions &CodeGenOpts; const clang::TargetOptions &TargetOpts; const LangOptions &LangOpts; - Module *TheModule; + llvm::Module *TheModule; lamb-j wrote: Without the qualification, we get the f

[clang] [CodeGen] Implement post-opt linking option for builtin bitocdes (PR #69371)

2023-11-09 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Implement post-opt linking option for builtin bitocdes (PR #69371)

2023-11-09 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Don't say "is declared here" for invalid template locations (PR #71264)

2023-11-09 Thread Justin Bogner via cfe-commits
bogner wrote: ping. @AaronBallman Does this look like a reasonable thing to do to you? https://github.com/llvm/llvm-project/pull/71264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Vector standard conversions (PR #71098)

2023-11-09 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Return empty QualType when a negative array was created (PR #71552)

2023-11-09 Thread Shilei Tian via cfe-commits
shiltian wrote: The changes look good to me. @alexey-bataev WDYT? https://github.com/llvm/llvm-project/pull/71552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] add -flang-deprecated-no-hlfir hidden option (PR #71820)

2023-11-09 Thread Slava Zakharin via cfe-commits
https://github.com/vzakhari approved this pull request. Thank you, Jean! https://github.com/llvm/llvm-project/pull/71820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Return empty QualType when a negative array was created (PR #71552)

2023-11-09 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/71552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
https://github.com/yonghong-song created https://github.com/llvm/llvm-project/pull/71856 Sometimes bpf developer might want to develop different codes based on particular cpu versioins. For example, cpu v1/v2/v3 branch target is 16bit while cpu v4 branch target is 32bit, thus cpu v4 allows mor

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (yonghong-song) Changes Sometimes bpf developer might want to develop different codes based on particular cpu versioins. For example, cpu v1/v2/v3 branch target is 16bit while cpu v4 branch target is 32bit, thus cpu v4 allows more ag

[llvm] [clang-tools-extra] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-09 Thread Richard Smith via cfe-commits
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, if (hadError || VerifyOnly) { // Do nothing } else if (Init < NumInits) { zygoloid wrote: Hmm, how does that work? If this `if` condition doesn't

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
yonghong-song wrote: cc @4ast @anakryiko https://github.com/llvm/llvm-project/pull/71856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (PR #71677)

2023-11-09 Thread Eli Friedman via cfe-commits
@@ -1244,29 +1244,28 @@ static void emitStoresForConstant(CodeGenModule &CGM, const VarDecl &D, // If the initializer is small, use a handful of stores. if (shouldSplitConstantStore(CGM, ConstantSize)) { if (auto *STy = dyn_cast(Ty)) { - // FIXME: handle the case

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
https://github.com/yonghong-song edited https://github.com/llvm/llvm-project/pull/71856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-11-09 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/70646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-11-09 Thread John McCall via cfe-commits
@@ -710,9 +710,11 @@ class Sema final { return result; } + // Saves the current floating-point pragma stack and clear it in this Sema. class FpPragmaStackSaveRAII { public: -FpPragmaStackSaveRAII(Sema &S) : S(S), SavedStack(S.FpPragmaStack) {} +FpPragmaSta

[clang] [clang] Do not clear FP pragma stack when instantiating functions (PR #70646)

2023-11-09 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: Otherwise LGTM https://github.com/llvm/llvm-project/pull/70646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-09 Thread Richard Smith via cfe-commits
@@ -727,6 +734,38 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, if (hadError || VerifyOnly) { // Do nothing } else if (Init < NumInits) { + if (WarnIfMissing) { +auto CheckAnonMember = [&](const FieldDecl *FD, +

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-11-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/69340 >From 610d0b544d7927af93b6943078df033f154b74f8 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Thu, 9 Nov 2023 09:30:24 -0700 Subject: [PATCH 1/3] Revert "Revert "[clang-format] Fix align consecutive declaratio

[clang] [clang-format] Handle variable declarations in BreakAfterAttributes (PR #71755)

2023-11-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/71755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Make template implicitly host device (PR #70369)

2023-11-09 Thread Artem Belevich via cfe-commits
Artem-B wrote: Now that we're making an even larger class of functions implicitly HD, the last logical step would be to make *all* unattributed functions implicitly HD, too (in a separate patch). After all, a template is as GPU-portable (or not) as a regular function. Unlike constexpr or compi

[clang] [CUDA][HIP] Make template implicitly host device (PR #70369)

2023-11-09 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/70369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --gcc-install-dir for RISCV baremetal toolchains (PR #71803)

2023-11-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. . https://github.com/llvm/llvm-project/pull/71803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 558066. gedare added a comment. Rebase to D155529 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 Files: clang/docs/ClangFormatSt

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

2023-11-09 Thread Gedare Bloom via Phabricator via cfe-commits
gedare added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156360/new/ https://reviews.llvm.org/D156360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang] Enable --gcc-install-dir for RISCV baremetal toolchains (PR #71803)

2023-11-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: A user has recently asked me about `RISCVToolChain` and I am puzzled by its behavior. Why is the return value of `RISCVToolChain::hasGCCToolchain` used to choose `toolchains::RISCVToolChain` or `toolchains::BareMetal`? The logic should be decided by the target triple, not wheth

[clang] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

2023-11-09 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud created https://github.com/llvm/llvm-project/pull/71862 None >From 6636745d1c444747a33c91b366a730d81ca5db5a Mon Sep 17 00:00:00 2001 From: Rashmi Mudduluru Date: Wed, 1 Nov 2023 13:43:12 -0700 Subject: [PATCH 1/3] [-Wunsafe-buffer-usage][WIP] Fixable gadget for AddA

[clang] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rashmi Mudduluru (t-rasmud) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/71862.diff 3 Files Affected: - (modified) clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def (+1) - (modified) clang/lib/Ana

[clang] [clang] Enable --gcc-install-dir for RISCV baremetal toolchains (PR #71803)

2023-11-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: I am not familiar with RISC-V baremetal toolchains, but this toolchain gave me a feeling of "there is a lot of fragmentation in this area. However, we as a vendor upstreamed first what we did to clang/lib/Driver/ToolChains/RISCVToolchain.cpp and made it apply to all target trip

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
https://github.com/eddyz87 approved this pull request. Hi Yonghong, Thank you for working on this. https://github.com/llvm/llvm-project/pull/71856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang] Add information about lld presence in RISCVToolchain. (PR #68904)

2023-11-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: > @MaskRay, could you please look into this? Sorry for my late reply. I am still adapting to the github pr workflow. Related to the linker question you have, I am puzzled by RISCVToolChain's choices: https://github.com/llvm/llvm-project/pull/71803#issuecomment-180464 https:

[clang] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

2023-11-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a2d9d2e1d96a3e81f4eed7f70e0a62cbc0e77cfd ec71495b80e209e7c2dffaaadb1f05814cfafaed --

[clang] [-Wunsafe-buffer-usage] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

2023-11-09 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud edited https://github.com/llvm/llvm-project/pull/71862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
@@ -29,6 +29,14 @@ void BPFTargetInfo::getTargetDefines(const LangOptions &Opts, MacroBuilder &Builder) const { Builder.defineMacro("__bpf__"); Builder.defineMacro("__BPF__"); + + std::string CPU = getTargetOpts().CPU; + if (CPU == "pr

<    1   2   3   4   >