[clang] [clang][Interp] Fix IntAP(s) to IntAP(s) casts (PR #69915)

2023-11-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/69915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix IntAP(s) to IntAP(s) casts (PR #69915)

2023-11-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69915 >From b82acd12f1217468d6fc53ab2b2f5856802b9b78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 23 Oct 2023 12:46:25 +0200 Subject: [PATCH] [clang][Interp] Fix IntAP(s) to IntAP(s) casts

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-11-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= ,

[clang] b178cec - [clang][NFC] Annotate most of `clang/Basic` headers with `preferred_type`

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2023-11-06T14:18:26+03:00 New Revision: b178cec84f95210db615cfa0a84e78585445f16b URL: https://github.com/llvm/llvm-project/commit/b178cec84f95210db615cfa0a84e78585445f16b DIFF: https://github.com/llvm/llvm-project/commit/b178cec84f95210db615cfa0a84e78585445f16b.

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-11-06 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1894,6 +1894,8 @@ void TypePrinter::printAttributedAfter(const AttributedType *T, case attr::ArmMveStrictPolymorphism:

[clang] [clang][analyzer] Improve StdLibraryFunctionsChecker 'readlink' modeling. (PR #71373)

2023-11-06 Thread via cfe-commits
https://github.com/DonatNagyE approved this pull request. This is straightforward small change that clarifies some _very confusing_ (but technically true positive) bug reports that I encountered on some open source projects. https://github.com/llvm/llvm-project/pull/71373

[llvm] [clang] [clang-tools-extra] [SimplifyCFG] Prevent merging cbranch to cbranch if the branch probability from the first to second is too low. (PR #69375)

2023-11-06 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: > I've been puzzling over the rationale for looking at `MD_unpredictable`. How > can a branch that is heavily biased to one side be unpredictable? I'm curious either, I just decided to follow a 'standard' pattern in this source. https://github.com/llvm/llvm-project/pull/69375

[clang] 684b8e1 - Add missing header in MigratorOptions.h for 1a0e743ab01716ecafeb33858d9975cf90017c59.

2023-11-06 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-11-06T12:32:43+01:00 New Revision: 684b8e1c08f4ed3bfa452fea5eac230e449bf2aa URL: https://github.com/llvm/llvm-project/commit/684b8e1c08f4ed3bfa452fea5eac230e449bf2aa DIFF: https://github.com/llvm/llvm-project/commit/684b8e1c08f4ed3bfa452fea5eac230e449bf2aa.diff LO

[clang] [llvm] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

2023-11-06 Thread Sam Tebbs via cfe-commits
@@ -4825,6 +4827,72 @@ SDValue AArch64TargetLowering::getPStateSM(SelectionDAG &DAG, SDValue Chain, Mask); } +SDValue LowerSMELdrStr(SDValue N, SelectionDAG &DAG, bool IsLoad) { + // Lower an SME LDR/STR ZA intrinsic to LDR_ZA_PSEUDO or STR_ZA. + // If

[clang] [llvm] [AArch64][SME] Remove immediate argument restriction for svldr and svstr (PR #68565)

2023-11-06 Thread Sam Tebbs via cfe-commits
https://github.com/SamTebbs33 updated https://github.com/llvm/llvm-project/pull/68565 >From de07976922782b9dcf5d13d44551b782dc8b3b94 Mon Sep 17 00:00:00 2001 From: Samuel Tebbs Date: Fri, 6 Oct 2023 17:09:36 +0100 Subject: [PATCH 1/6] [AArch64][SME] Remove immediate argument restriction for sv

[clang] [analyzer] Fix assertion failure in `CXXInstanceCall::getCXXThisVal` (PR #70837)

2023-11-06 Thread via cfe-commits
@@ -30,3 +30,24 @@ void test(int i) { clang_analyzer_dump(g4); // expected-warning@-1 {{&i [as 64 bit integer]}} } + +struct A { + int n; + void set(int x) { +n = x; + } +}; +using ptr_size = decltype(sizeof(void *)); DonatNagyE wrote: Thanks! http

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2023-11-06 Thread via cfe-commits
Overhatted wrote: @MaskRay Can you take a look at this PR? For now I'm not looking for a full review, just an answer to my question of whether supporting a relative directory in the "directory" field of a compilation database is an acceptable change. Thanks. https://github.com/llvm/llvm-proj

[clang] [analyzer][solver] On SymSym RelOps, check EQClass members for contradictions (PR #71284)

2023-11-06 Thread Balazs Benics via cfe-commits
steakhal wrote: > @DonatNagyE The most straightforward issue that I see is that (if I > understand the code correctly) the intersected constraint (the value of the > variable `Constraint` at the end of > `handleEquivalentAlternativeSymOperands()`) is just discarded after checking > that it's

[clang] [clang][dataflow] Fix assert-fail when calling assignment operator with by-value parameter. (PR #71384)

2023-11-06 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/71384 The code assumed that the source parameter of an assignment operator is always passed by reference, but it is legal for it to be passed by value. This patch includes a test that assert-fails without the fix.

[clang] [clang][dataflow] Fix assert-fail when calling assignment operator with by-value parameter. (PR #71384)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes The code assumed that the source parameter of an assignment operator is always passed by reference, but it is legal for it to be passed by value. This patch includes a test that assert-fails without the

[clang] [analyzer][solver] On SymSym RelOps, check EQClass members for contradictions (PR #71284)

2023-11-06 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/71284 >From 92ece501b340c3a2a52b5a4614ddb70bb3e35c93 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sat, 4 Nov 2023 13:44:28 +0100 Subject: [PATCH 1/3] [analyzer][solver] On SymSym RelOps, check EQClass members f

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Aaron Ballman via cfe-commits
@@ -2034,18 +2035,19 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, // - If the new-initializer is omitted, the object is default- // initialized (8.5); if no initialization is performed, // the object has indeterminate val

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Aaron Ballman via cfe-commits
@@ -2008,22 +2008,23 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, SourceRange TypeRange = AllocTypeInfo->getTypeLoc().getSourceRange(); SourceLocation StartLoc = Range.getBegin(); - CXXNewExpr::InitializationStyle initStyle; + CXXNewInitializationS

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread J.C. Moyer via cfe-commits
https://github.com/jcmoyer created https://github.com/llvm/llvm-project/pull/71385 Improves the accuracy of `readability-identifier-naming` for cases `Camel_Snake_Case` and `camel_Snake_Back`. Prior to this commit, these cases matched identifiers with **only** a leading upper case letter or le

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: J.C. Moyer (jcmoyer) Changes Improves the accuracy of `readability-identifier-naming` for cases `Camel_Snake_Case` and `camel_Snake_Back`. Prior to this commit, these cases matched identifiers with **only** a leading upper case lette

[clang] [analyzer][solver] On SymSym RelOps, check EQClass members for contradictions (PR #71284)

2023-11-06 Thread via cfe-commits
DonatNagyE wrote: > I think we haven't discussed yet the approach of applying the constraint to > every eqclass member. That would feel like defeating the purpose of eqclasses > at all. I only mentioned it because from a high-level perspective it's equivalent to applying the constraint on the

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71322 >From 40d25b8009f1c8734a99fd1350adaced6884cc7f Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 5 Nov 2023 18:53:48 +0300 Subject: [PATCH 1/5] [clang][NFC] Refacator `CXXNewExpr::InitializationStyle`

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
@@ -2008,22 +2008,23 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, SourceRange TypeRange = AllocTypeInfo->getTypeLoc().getSourceRange(); SourceLocation StartLoc = Range.getBegin(); - CXXNewExpr::InitializationStyle initStyle; + CXXNewInitializationS

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
@@ -2034,18 +2035,19 @@ ExprResult Sema::BuildCXXNew(SourceRange Range, bool UseGlobal, // - If the new-initializer is omitted, the object is default- // initialized (8.5); if no initialization is performed, // the object has indeterminate val

[clang] [llvm] [WebAssembly] Mark externref as not being valid vector elements (PR #71069)

2023-11-06 Thread Paulo Matos via cfe-commits
pmatos wrote: I am now investigating the use of TargetExtTypes to represent Wasm Reference Types. https://github.com/llvm/llvm-project/pull/71069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll ready_for_review https://github.com/llvm/llvm-project/pull/71322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Vlad Serebrennikov (Endilll) Changes This patch converts `CXXNewExpr::InitializationStyle` into a scoped enum at namespace scope. It also affirms the status quo by adding a new enumerator to represent implicit initializer. --- Full

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/71322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] ace4489 - [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (#71322)

2023-11-06 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-11-06T17:34:22+04:00 New Revision: ace4489397d17abfb20d36de1404cfbe102401a7 URL: https://github.com/llvm/llvm-project/commit/ace4489397d17abfb20d36de1404cfbe102401a7 DIFF: https://github.com/llvm/llvm-project/commit/ace4489397d17abfb20d36de1404cfbe102401a7.

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/71322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Improve 'errno' handling in StdLibraryFunctionsChecker. (PR #71392)

2023-11-06 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/71392 The checker now displays one combined note tag for errno-related and "case"-related notes. Previous functions in the errno-modeling part that were used for construction of note tags are removed. The note tag ad

[clang] [clang][analyzer] Improve 'errno' handling in StdLibraryFunctionsChecker. (PR #71392)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes The checker now displays one combined note tag for errno-related and "case"-related notes. Previous functions in the errno-modeling part that were used for constr

[clang] [clang][Interp] Fix IntAP(s) to IntAP(s) casts (PR #69915)

2023-11-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM but please add the description to the patch commit message when landing. https://github.com/llvm/llvm-project/pull/69915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (PR #71393)

2023-11-06 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/71393 A few symbols within libclangInterpreter have got explicit dllexport attributes, in order to make them exported (and thus visible at runtime) in any build, not only when they are part of e.g. a DLL libclang-cpp

[clang] [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (PR #71393)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Martin Storsjö (mstorsjo) Changes A few symbols within libclangInterpreter have got explicit dllexport attributes, in order to make them exported (and thus visible at runtime) in any build, not only when they are part of e.g. a DLL libcla

[clang] [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (PR #71393)

2023-11-06 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: CC @brechtsanders, this is an alternative to #66881. https://github.com/llvm/llvm-project/pull/71393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-11-06 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1894,6 +1894,8 @@ void TypePrinter::printAttributedAfter(const AttributedType *T, case attr::ArmMveStrictPolymorphism:

[clang] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwrite of StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/71394 None >From 965c109cc19187329d5ab2ae324665dfbd7c17ee Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 6 Nov 2023 21:49:36 +0800 Subject: [PATCH] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwr

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

2023-11-06 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Thanks, I wasn't aware of this issue (I don't routinely try building with `-DBUILD_SHARED_LIBS=ON`, which I presume is what you've done to trigger this). See 592e935e115ffb451eb9b782376711dab6558fe0 for earlier context on this issue; therefore I'd prefer to fix this as I do in

[clang-tools-extra] [clang] Revert "[clang][NFC] Refactor `CXXNewExpr::InitializationStyle`" (PR #71395)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/71395 Reverts llvm/llvm-project#71322 >From 40921a217a4bda5ce739561606a4e16677ee48f5 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 6 Nov 2023 17:53:21 +0400 Subject: [PATCH] Revert "[clang][NFC] Refacto

[clang] 43e5f77 - Revert "[clang][NFC] Refactor `CXXNewExpr::InitializationStyle`" (#71395)

2023-11-06 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-11-06T17:54:09+04:00 New Revision: 43e5f77500acd64fb2738ef2832691ad488048a8 URL: https://github.com/llvm/llvm-project/commit/43e5f77500acd64fb2738ef2832691ad488048a8 DIFF: https://github.com/llvm/llvm-project/commit/43e5f77500acd64fb2738ef2832691ad488048a8.

[clang] [clang-tools-extra] Revert "[clang][NFC] Refactor `CXXNewExpr::InitializationStyle`" (PR #71395)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/71395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "[clang][NFC] Refactor `CXXNewExpr::InitializationStyle`" (PR #71395)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Vlad Serebrennikov (Endilll) Changes Reverts llvm/llvm-project#71322 --- Full diff: https://github.com/llvm/llvm-project/pull/71395.diff 8 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp

[clang-tools-extra] [clang] Revert "[clang][NFC] Refactor `CXXNewExpr::InitializationStyle`" (PR #71395)

2023-11-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 22a323e3db0cad736b2e793dd8143195fd9c0fc0 40921a217a4bda5ce739561606a4e16677ee48f5 --

[clang] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwrite of StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71394 >From abbca31776cf4223392726d64aadfa5c79b57a69 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 6 Nov 2023 21:49:36 +0800 Subject: [PATCH] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwrite of

[clang] [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (PR #71393)

2023-11-06 Thread Jun Zhang via cfe-commits
https://github.com/junaire approved this pull request. Thanks for the fix! I'm fine with it if this fixes your problem. But yeah, please make sure @vgvassilev is aware of it. https://github.com/llvm/llvm-project/pull/71393 ___ cfe-commits mailing list

[clang] [AMDGPU] Accept/Ignore any -mcmodel arguments. (PR #70760)

2023-11-06 Thread Yaxun Liu via cfe-commits
@@ -5743,9 +5743,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, } else if (Triple.getArch() == llvm::Triple::x86_64) { Ok = llvm::is_contained({"small", "kernel", "medium", "large", "tiny"}, CM); -} else if (Tripl

[clang] [clang][Analyzer] Move checker 'alpha.unix.Errno' to 'unix.Errno'. (PR #69469)

2023-11-06 Thread Balázs Kéri via cfe-commits
balazske wrote: PRs #71373 and #71392 are created to improve the indicated problems. https://github.com/llvm/llvm-project/pull/69469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AMDGPU] Add code model (#70760) test for amdgpu target. (PR #71019)

2023-11-06 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: I think we need to fix clang and not passing -mcmodel=tiny/kernel to clang -cc1. https://github.com/llvm/llvm-project/pull/70760/files#r1383372722 probably we can do that in this PR https://github.com/llvm/llvm-project/pull/71019 __

[clang] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwrite of StreamChecker (PR #71394)

2023-11-06 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/71394 >From 56d5604cf0442919d62def08c233e8d48b654885 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Mon, 6 Nov 2023 21:49:36 +0800 Subject: [PATCH] [clang][Analyzer][NFC] Simplify preDefault/preFseek/preFreadFwrite of

[llvm] [clang] [clang-tools-extra] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

2023-11-06 Thread Valery Pykhtin via cfe-commits
vpykhtin wrote: Thanks Nicolai! https://github.com/llvm/llvm-project/pull/68714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libcxx] [llvm] [flang] [clang] [compiler-rt] [libc] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/71398 In Clang 16, we implemented the ability to add a label at the end of a compound statement. These changes complete the implementation by allowing a label to be followed by a declaration in C. Note, this see

[clang-tools-extra] [libcxx] [llvm] [flang] [clang] [compiler-rt] [libc] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-openmp Author: Aaron Ballman (AaronBallman) Changes In Clang 16, we implemented the ability to add a label at the end of a compound statement. These changes complete the implementation by allowing a label to be followed by a declaration in C. Note, th

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-11-06 Thread Balazs Benics via cfe-commits
@@ -492,11 +492,13 @@ void check_required_cast() { void check_cast_behavior(OSObject *obj) { OSArray *arr1 = OSDynamicCast(OSArray, obj); - clang_analyzer_eval(arr1 == obj); // expected-warning{{TRUE}} -// expected-note@-1{{TRUE}} -

[clang] feedb7c - [clang][Interp] Fix IntAP(s) to IntAP(s) casts (#69915)

2023-11-06 Thread via cfe-commits
Author: Timm Baeder Date: 2023-11-06T15:13:43+01:00 New Revision: feedb7c0db1e06b9082f9c015362cdbf334696ff URL: https://github.com/llvm/llvm-project/commit/feedb7c0db1e06b9082f9c015362cdbf334696ff DIFF: https://github.com/llvm/llvm-project/commit/feedb7c0db1e06b9082f9c015362cdbf334696ff.diff L

[clang] [clang][Interp] Fix IntAP(s) to IntAP(s) casts (PR #69915)

2023-11-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/69915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread via cfe-commits
zmodem wrote: I landed a commit close to this one, and got at least 10 emails about broken buildbots so far (e.g. https://lab.llvm.org/buildbot/#/builders/188/builds/37563). How come presubmit testing isn't catching this? @metaflow https://github.com/llvm/llvm-project/pull/71322

[clang] clang/CodeGen/RISCV: test lowering of math builtins (PR #71399)

2023-11-06 Thread Ramkumar Ramachandra via cfe-commits
https://github.com/artagnon created https://github.com/llvm/llvm-project/pull/71399 Ever since 98c90a1 (ISel: introduce vector ISD::LRINT, ISD::LLRINT; custom RISCV lowering) landed, there have been several discussions on how the lrint and llrint libcalls would lower to LLVM IR via clang on RV

[clang] clang/CodeGen/RISCV: test lowering of math builtins (PR #71399)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ramkumar Ramachandra (artagnon) Changes Ever since 98c90a1 (ISel: introduce vector ISD::LRINT, ISD::LLRINT; custom RISCV lowering) landed, there have been several discussions on how the lrint and llrint libcalls would lower to LLVM IR via

[clang-tools-extra] [clang] [llvm] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

2023-11-06 Thread Valery Pykhtin via cfe-commits
https://github.com/vpykhtin closed https://github.com/llvm/llvm-project/pull/68714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use new interpreter in EvaluateAsConstantExpr if requested (PR #70763)

2023-11-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: > I don't have a good idea how a release note could be phrased here, but if you > could try one, it would be appreciated and I think it is worth doing. You mean about this change specifically? > Side note: it would be really cool if at the end of the release cycle, you > did a

[llvm] [clang] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

2023-11-06 Thread Yusra Syeda via cfe-commits
ysyeda wrote: ping https://github.com/llvm/llvm-project/pull/68926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [flang] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread Mariya Podchishchaeva via cfe-commits
@@ -299,6 +299,12 @@ def note_missing_selector_name : Note< def note_force_empty_selector_name : Note< "or insert whitespace before ':' to use %0 as parameter name " "and have an empty entry in the selector">; +def ext_c_label_followed_by_declaration : ExtWarn< + "label fo

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: It catches (https://buildkite.com/llvm-project/github-pull-requests/builds/12931#018ba4b7-1e05-425f-a30d-46ac33f582b6), you just didn't wait for a results (or ignored them) and forced a merge. https://github.com/llvm/llvm-project/pull/71322 _

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-06 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/71234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [clang][NFC] Refactor `CXXNewExpr::InitializationStyle` (PR #71322)

2023-11-06 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I've seen those exact test failures locally, but since precommit CI was fine, I landed this PR and kept a close eye on the bots. Me and Aaron are also wondering now how did it pass CI, and what's wrong with changes here. I'm sorry @zmodem that we got you involved. > It catches

[clang] [libc] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [flang] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread Aaron Ballman via cfe-commits
@@ -299,6 +299,12 @@ def note_missing_selector_name : Note< def note_force_empty_selector_name : Note< "or insert whitespace before ':' to use %0 as parameter name " "and have an empty entry in the selector">; +def ext_c_label_followed_by_declaration : ExtWarn< + "label fo

[clang] [clang-repl] Fix BUILD_SHARED_LIBS symbols from libclangInterpreter on MinGW (PR #71393)

2023-11-06 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Thank you, @mstorsjo! https://github.com/llvm/llvm-project/pull/71393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 approved this pull request. https://github.com/llvm/llvm-project/pull/71029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Nikita Popov via cfe-commits
nikic wrote: You also need to replace uses in polly. https://github.com/llvm/llvm-project/pull/71029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Youngsuk Kim via cfe-commits
JOE1994 wrote: https://buildkite.com/llvm-project/github-pull-requests/builds/12872#018ba3cf-2050-4af1-b46a-55b5482323fc https://github.com/llvm/llvm-project/pull/71029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[llvm] [clang] [NFC] Remove Type::getInt8PtrTy (PR #71029)

2023-11-06 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 requested changes to this pull request. Please update existing uses in `polly`, and rebase onto latest `main`. https://github.com/llvm/llvm-project/pull/71029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread Piotr Zegar via cfe-commits
@@ -871,8 +871,8 @@ bool IdentifierNamingCheck::matchesStyle( llvm::Regex("^[a-z][a-zA-Z0-9]*$"), llvm::Regex("^[A-Z][A-Z0-9_]*$"), llvm::Regex("^[A-Z][a-zA-Z0-9]*$"), - llvm::Regex("^[A-Z]([a-z0-9]*(_[A-Z])?)*"), - llvm::Regex("^[a-z]([a-z0-9]*(_[A-

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Also update release notes, add one sentence there about this. https://github.com/llvm/llvm-project/pull/71385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread J.C. Moyer via cfe-commits
@@ -871,8 +871,8 @@ bool IdentifierNamingCheck::matchesStyle( llvm::Regex("^[a-z][a-zA-Z0-9]*$"), llvm::Regex("^[A-Z][A-Z0-9_]*$"), llvm::Regex("^[A-Z][a-zA-Z0-9]*$"), - llvm::Regex("^[A-Z]([a-z0-9]*(_[A-Z])?)*"), - llvm::Regex("^[a-z]([a-z0-9]*(_[A-

[clang] [clang][Interp] Fix creating APSInt from IntegralAP (PR #71410)

2023-11-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71410 The boolean argument in the APSInt constructor is IsUnsigned, not IsSigned. This marks the 10th time I've run into this issue. Happy anniversary. >From 81836da057f2703f49f30d31955306577a0e1170 Mon Sep 17 00:00:

[clang] [clang][Interp] Fix creating APSInt from IntegralAP (PR #71410)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The boolean argument in the APSInt constructor is IsUnsigned, not IsSigned. This marks the 10th time I've run into this issue. Happy anniversary. --- Full diff: https://github.com/llvm/llvm-project/pull/7141

[clang] [compiler-rt] [llvm] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
@@ -1133,6 +1133,9 @@ typedef struct __ifunc_arg_t { #ifndef HWCAP2_SME_F64F64 #define HWCAP2_SME_F64F64 (1 << 25) #endif +#ifndef HWCAP2_SME_FA64 +#define HWCAP2_SME_FA64 (1 << 26) MDevereau wrote: This comes from here https://github.com/torvalds/linux/blob/

[llvm] [clang] [compiler-rt] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
@@ -491,13 +491,15 @@ bool AArch64Subtarget::isStreamingCompatible() const { } bool AArch64Subtarget::isNeonAvailable() const { - return hasNEON() && !isStreaming() && !isStreamingCompatible(); + if (hasSMEFA64()) +return true; + return (hasNEON() && !isStreaming() && !

[clang] [compiler-rt] [llvm] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
@@ -491,13 +491,15 @@ bool AArch64Subtarget::isStreamingCompatible() const { } bool AArch64Subtarget::isNeonAvailable() const { - return hasNEON() && !isStreaming() && !isStreamingCompatible(); + if (hasSMEFA64()) +return true; + return (hasNEON() && !isStreaming() && !

[llvm] [clang] [compiler-rt] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
@@ -508,6 +508,9 @@ def FeatureSMEI16I64 : SubtargetFeature<"sme-i16i64", "HasSMEI16I64", "true", def FeatureSMEF16F16 : SubtargetFeature<"sme-f16f16", "HasSMEF16F16", "true", "Enable SME2.1 non-widening Float16 instructions (FEAT_SME_F16F16)", []>; +def FeatureSMEFA64 : Su

[llvm] [clang] [compiler-rt] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
@@ -162,6 +163,7 @@ enum ArchExtKind : unsigned { AEK_FPMR = 58, // FEAT_FPMR AEK_FP8 = 59, // FEAT_FP8 AEK_FAMINMAX = 60, // FEAT_FAMINMAX + AEK_SMEFA64 = 61, // FEAT_SMEFA64 MDevereau wrote: I've moved it to be AEK_SM

[llvm] [clang] [compiler-rt] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau edited https://github.com/llvm/llvm-project/pull/70809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [compiler-rt] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Matthew Devereau via cfe-commits
@@ -0,0 +1,33 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mattr=+sve -mattr=+sme-fa64 -force-streaming-compatible-sve < %s | FileCheck %s -check-prefix=FA64 +; RUN: llc -mattr=+sve -force-streaming-compatible-sve < %s | FileCheck

[llvm] [clang] [clang-tools-extra] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-06 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/70829 >From ac30780250875802d13450d17e6959f9e2ad3a70 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 31 Oct 2023 09:27:51 -0700 Subject: [PATCH 1/2] [clang] Fix false positive -Wmissing-field-initi

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread J.C. Moyer via cfe-commits
jcmoyer wrote: > Also update release notes, add one sentence there about this. Done. https://github.com/llvm/llvm-project/pull/71385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve alternate snake case warnings (PR #71385)

2023-11-06 Thread J.C. Moyer via cfe-commits
https://github.com/jcmoyer updated https://github.com/llvm/llvm-project/pull/71385 >From 41f2765e7d3a0a04ac8c47d73059b16b138bd779 Mon Sep 17 00:00:00 2001 From: "J.C. Moyer" Date: Sun, 5 Nov 2023 17:21:32 -0500 Subject: [PATCH] [clang-tidy] Improve alternate snake case warnings Improves the ac

[clang-tools-extra] [clang] [llvm] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-06 Thread Mariya Podchishchaeva via cfe-commits
@@ -2537,19 +2555,13 @@ class FieldInitializerValidatorCCC final : public CorrectionCandidateCallback { /// actually be initialized. Fznamznon wrote: I removed addition of `InitializedFields` parameter, so probably it makes sense to update the comment comment

[clang-tools-extra] [clang] [llvm] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-06 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: > I wonder if it would make sense to move the checking for this warning here, > to the else case in line 725 Thanks for the suggestion, I gave it a try. https://github.com/llvm/llvm-project/pull/70829 ___ cfe-commits mailing list cfe

[clang] [clang][Interp] Fix creating APSInt from IntegralAP (PR #71410)

2023-11-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8f76522a61d01cf7d70debd39418259e969bb8d6 81836da057f2703f49f30d31955306577a0e1170 --

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/71413 This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes >From f80d68edf0787821531c0f88d845b

[clang] [APINotes] Upstream APINotes YAML compiler (PR #71413)

2023-11-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes --- Patch is 23.21 KiB, truncate

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-11-06 Thread Simon Tatham via cfe-commits
statham-arm wrote: @petrhosek, do you have any further comments? I'll merge this change based on @MaskRay's approval if I haven't heard back in another week. https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@list

[clang] 34ee69b - [clang][CGObjCMac] Remove no-op ptr-to-ptr bitcasts (NFC)

2023-11-06 Thread Youngsuk Kim via cfe-commits
Author: Youngsuk Kim Date: 2023-11-06T10:19:48-06:00 New Revision: 34ee69b4ce66280ccc65acc1799a5863de2f2aa6 URL: https://github.com/llvm/llvm-project/commit/34ee69b4ce66280ccc65acc1799a5863de2f2aa6 DIFF: https://github.com/llvm/llvm-project/commit/34ee69b4ce66280ccc65acc1799a5863de2f2aa6.diff

[clang] [clang][Interp] Fix creating APSInt from IntegralAP (PR #71410)

2023-11-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/71410 >From 8984ebb39a4bb2ba475440b0ed41c534f586a4c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 6 Nov 2023 16:59:33 +0100 Subject: [PATCH] [clang][Interp] Fix creating APSInt from Integral

[clang] clang/CodeGen/RISCV: test lowering of math builtins (PR #71399)

2023-11-06 Thread Ramkumar Ramachandra via cfe-commits
artagnon wrote: The main takeaways here: - There is only ever an i64 variant of llrint produced, and we have tested codegen of that on RV32 and RV64. - Only an i32 variant of lrint is produced on RV32, and an i64 variant on RV64. We have tested the codegen of both. Hence, I would conclude that

[libc] [libcxx] [compiler-rt] [clang-tools-extra] [clang] [llvm] [flang] [C23] Complete support for WG14 N2508 (PR #71398)

2023-11-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/71398 >From 1d54a5cc6b34aca0e34ab57d7ee62815707d9153 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 6 Nov 2023 08:54:40 -0500 Subject: [PATCH 1/2] [C23] Complete support for WG14 N2508 In Clang 16, we im

[llvm] [compiler-rt] [clang] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/70809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [AArch64][SME] Add support for sme-fa64 (PR #70809)

2023-11-06 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. LGTM (with nit addressed), but please check with @ilinpv on the FMV priorities before merging the patch. https://github.com/llvm/llvm-project/pull/70809 ___ cfe-commits mailing list cfe-comm

  1   2   3   4   5   >