Author: Timm Baeder
Date: 2023-11-05T08:26:29+01:00
New Revision: a9af8f8882f9d64870d3b60adfbe07e59c63c523
URL:
https://github.com/llvm/llvm-project/commit/a9af8f8882f9d64870d3b60adfbe07e59c63c523
DIFF:
https://github.com/llvm/llvm-project/commit/a9af8f8882f9d64870d3b60adfbe07e59c63c523.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/69912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Fangrui Song
Date: 2023-11-05T00:39:38-07:00
New Revision: c0a73918bfddc6a04a897aab57fb95e8d2da7ec0
URL:
https://github.com/llvm/llvm-project/commit/c0a73918bfddc6a04a897aab57fb95e8d2da7ec0
DIFF:
https://github.com/llvm/llvm-project/commit/c0a73918bfddc6a04a897aab57fb95e8d2da7ec0.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc0a73918bfdd: [ItaniumCXXABI] Add
-fassume-nothrow-exception-dtor to assume that all… (authored by MaskRay).
Changed prior to commit:
https://reviews.llvm.org/D108905?vs=557976&id=558008#toc
Repository
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/69867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic approved this pull request.
https://github.com/llvm/llvm-project/pull/71295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vlad Serebrennikov
Date: 2023-11-05T12:30:49+03:00
New Revision: 3e6ce58701a3a8463b53fb3fd2023c02b4e90554
URL:
https://github.com/llvm/llvm-project/commit/3e6ce58701a3a8463b53fb3fd2023c02b4e90554
DIFF:
https://github.com/llvm/llvm-project/commit/3e6ce58701a3a8463b53fb3fd2023c02b4e90554.
Author: Vlad Serebrennikov
Date: 2023-11-05T13:36:08+03:00
New Revision: c23aaa410358b9f9c364ddaaeb6b2069b185a99b
URL:
https://github.com/llvm/llvm-project/commit/c23aaa410358b9f9c364ddaaeb6b2069b185a99b
DIFF:
https://github.com/llvm/llvm-project/commit/c23aaa410358b9f9c364ddaaeb6b2069b185a99b.
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/70587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/69900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith edited
https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/robincaloudis created
https://github.com/llvm/llvm-project/pull/71313
The documentation is written relatively to `clang-llvm`, not the root
repository directory. Therefore, the `llvm-project` repo needs to be cloned
into the existing directory `clang-llvm`. As cloning into a
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Robin Caloudis (robincaloudis)
Changes
The documentation is written relatively to `clang-llvm`, not the root
repository directory. Therefore, the `llvm-project` repo needs to be cloned
into the existing directory `clang-llvm`. As cloning
https://github.com/robincaloudis edited
https://github.com/llvm/llvm-project/pull/71313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jamesETsmith updated
https://github.com/llvm/llvm-project/pull/68494
>From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001
From: James Smith
Date: Thu, 28 Sep 2023 10:11:15 -0400
Subject: [PATCH 01/17] [libc++] Implement ranges::iota and
ranges::out_value_r
Author: Vlad Serebrennikov
Date: 2023-11-05T15:39:05+03:00
New Revision: 6e35db0694b2cb80ffe0c7edfed3090f9ede4805
URL:
https://github.com/llvm/llvm-project/commit/6e35db0694b2cb80ffe0c7edfed3090f9ede4805
DIFF:
https://github.com/llvm/llvm-project/commit/6e35db0694b2cb80ffe0c7edfed3090f9ede4805.
https://github.com/robincaloudis updated
https://github.com/llvm/llvm-project/pull/71313
>From a2862b11889a0ce5ad696c6397a1a557f72c2191 Mon Sep 17 00:00:00 2001
From: Robin Caloudis <53619127+robincalou...@users.noreply.github.com>
Date: Sun, 5 Nov 2023 13:34:29 +0100
Subject: [PATCH] [clang][do
@@ -0,0 +1,28 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -passes=indvars -S | FileCheck %s
+
+declare void @foo(i16 noundef)
+
+; Function Attrs: mustprogress noreturn uwtable
+define void @bar(i64 noundef %ptr) {
+; CHECK-LABEL:
https://github.com/markoshorro edited
https://github.com/llvm/llvm-project/pull/71072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/71315
Add an `EvaluationResult` class. This contains the result either as a `Pointer`
or as a `APValue`.
This way, we can inspect the result of the evaluation and diagnose problems
with it (e.g. uninitialized fields
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/71315
>From b102c7d258e5538ad9f4a851191656243b913523 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 31 Oct 2023 14:57:51 +0100
Subject: [PATCH] EvaluationResult
---
clang/lib/AST/CMakeLists.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Add an `EvaluationResult` class. This contains the result either as a `Pointer`
or as a `APValue`.
This way, we can inspect the result of the evaluation and diagnose problems
with it (e.g. uninitialized fie
Author: Vlad Serebrennikov
Date: 2023-11-05T16:38:45+03:00
New Revision: a9070f22a29e28f7d6f83c24a8dd88f3a94969ae
URL:
https://github.com/llvm/llvm-project/commit/a9070f22a29e28f7d6f83c24a8dd88f3a94969ae
DIFF:
https://github.com/llvm/llvm-project/commit/a9070f22a29e28f7d6f83c24a8dd88f3a94969ae.
https://github.com/phoebewang created
https://github.com/llvm/llvm-project/pull/71317
None
>From 50fb9c29b16c26e82bbc07ae8a092f572caa73a5 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Sun, 5 Nov 2023 21:50:44 +0800
Subject: [PATCH] [X86] Add a EVEX256 macro to match with GCC and MSVC
---
https://github.com/phoebewang created
https://github.com/llvm/llvm-project/pull/71318
This patch relaxes the driver logic to permit combinations between AVX512 and
AVX10 options and makes sure we have a unified behavior between options and
features combination.
Here are rules we are following
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Phoebe Wang (phoebewang)
Changes
This patch relaxes the driver logic to permit combinations between AVX512 and
AVX10 options and makes sure we have a unified behavior between options and
features combination.
Here are rules we are
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8a7846fe86f95e82c6bd5f4f45b8dd311320e903
d9ee6309924e7f248695cbd488afe98273432e84 --
@@ -0,0 +1,33 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mattr=+sve -mattr=+sme-fa64 -force-streaming-compatible-sve < %s |
FileCheck %s -check-prefix=FA64
+; RUN: llc -mattr=+sve -force-streaming-compatible-sve < %s | FileCheck
@@ -162,6 +163,7 @@ enum ArchExtKind : unsigned {
AEK_FPMR = 58, // FEAT_FPMR
AEK_FP8 = 59, // FEAT_FP8
AEK_FAMINMAX = 60, // FEAT_FAMINMAX
+ AEK_SMEFA64 = 61, // FEAT_SMEFA64
sdesmalen-arm wrote:
nit: can you define this a
@@ -508,6 +508,9 @@ def FeatureSMEI16I64 : SubtargetFeature<"sme-i16i64",
"HasSMEI16I64", "true",
def FeatureSMEF16F16 : SubtargetFeature<"sme-f16f16", "HasSMEF16F16", "true",
"Enable SME2.1 non-widening Float16 instructions (FEAT_SME_F16F16)", []>;
+def FeatureSMEFA64 : Su
@@ -248,8 +250,9 @@ inline constexpr ExtensionInfo Extensions[] = {
{"simd", AArch64::AEK_SIMD, "+neon", "-neon", FEAT_SIMD,
"+fp-armv8,+neon", 100},
{"sm4", AArch64::AEK_SM4, "+sm4", "-sm4", FEAT_SM4,
"+sm4,+fp-armv8,+neon", 60},
{"sme-f16f16", AArch64::AEK_SMEF1
https://github.com/phoebewang updated
https://github.com/llvm/llvm-project/pull/71318
>From d9ee6309924e7f248695cbd488afe98273432e84 Mon Sep 17 00:00:00 2001
From: Phoebe Wang
Date: Sun, 5 Nov 2023 21:15:53 +0800
Subject: [PATCH 1/2] [X86][AVX10] Permit AVX512 options/features used together
wi
@@ -111,16 +115,18 @@ void ContainerDataPointerCheck::check(const
MatchFinder::MatchResult &Result) {
MemberExpr>(CE))
ReplacementText = "(" + ReplacementText + ")";
- if (CE->getType()->isPointerType())
-ReplacementText += "->data()";
- else
-Replace
https://github.com/BertalanD created
https://github.com/llvm/llvm-project/pull/71321
Commit 46ca880fca made `@encode` skip fields that are made zero-sized by
`[[no_unique_address]]`. When iterating the fields, the index which is passed
to `getFieldOffset` failed to be incremented for those due
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniel Bertalan (BertalanD)
Changes
Commit 46ca880fca made `@encode` skip fields that are made zero-sized
by `[[no_unique_address]]`. When iterating the fields, the index which is
passed to `getFieldOffset` failed to be incremented for th
https://github.com/BertalanD unassigned
https://github.com/llvm/llvm-project/pull/71321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/BertalanD unassigned
https://github.com/llvm/llvm-project/pull/71321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/71322
This patch converts `CXXNewExpr::InitializationStyle` into a scoped enum at
namespace scope. It also affirms the status quo by adding a new enumerator to
represent implicit initializer.
>From 40d25b8009f1c8734a
@@ -111,16 +115,18 @@ void ContainerDataPointerCheck::check(const
MatchFinder::MatchResult &Result) {
MemberExpr>(CE))
ReplacementText = "(" + ReplacementText + ")";
- if (CE->getType()->isPointerType())
-ReplacementText += "->data()";
- else
-Replace
https://github.com/neoncube2 deleted
https://github.com/llvm/llvm-project/pull/71304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/antiagainst approved this pull request.
LGTM. Thanks for addressing the comments!
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/antiagainst edited
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/neoncube2 updated
https://github.com/llvm/llvm-project/pull/71304
>From ab1e2e7487fdc7b1e16e563c63e225a3dd39da05 Mon Sep 17 00:00:00 2001
From: Eli Black
Date: Sun, 5 Nov 2023 13:43:20 +0800
Subject: [PATCH] [clang-tidy] Improve `container-data-pointer` check to use
`c_str()
@@ -3,13 +3,9 @@
readability-container-data-pointer
==
-Finds cases where code could use ``data()`` rather than the address of the
-element at index 0 in a container. This pattern is commonly used to materialize
-a pointer to the backing data of
@@ -111,16 +115,18 @@ void ContainerDataPointerCheck::check(const
MatchFinder::MatchResult &Result) {
MemberExpr>(CE))
ReplacementText = "(" + ReplacementText + ")";
- if (CE->getType()->isPointerType())
-ReplacementText += "->data()";
- else
-Replace
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/71322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/antiagainst closed
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
antiagainst wrote:
I revised the commit message a bit and landed it. Thanks for the waiting!
https://github.com/llvm/llvm-project/pull/69949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: Youngsuk Kim
Date: 2023-11-05T10:17:45-06:00
New Revision: b26b1cee2e6b0b730fda87dbd4a236810d424129
URL:
https://github.com/llvm/llvm-project/commit/b26b1cee2e6b0b730fda87dbd4a236810d424129
DIFF:
https://github.com/llvm/llvm-project/commit/b26b1cee2e6b0b730fda87dbd4a236810d424129.diff
neoncube2 wrote:
@PiotrZSL Thanks for the quick review! :)
I think #54076 covers the `const` issue. Since `container-data-pointer` is
already broken for code such as `char *t = str.data();`, I think merging this
PR wouldn't cause additional issues, but I could be wrong about that! :)
I'd like
https://github.com/Munesanz edited
https://github.com/llvm/llvm-project/pull/66919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2388,15 +2389,20 @@ class CXXNewExpr final
/// Whether this new-expression has any initializer at all.
bool hasInitializer() const {
-return CXXNewExprBits.StoredInitializationStyle > 0;
+switch (getInitializationStyle()) {
+case CXXNewInitializationStyle::
https://github.com/MaskRay approved this pull request.
Mostly looks good
https://github.com/llvm/llvm-project/pull/70255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5011,6 +5011,12 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
Args.AddLastArg(CmdArgs, options::OPT_fthinlto_index_EQ);
}
+ if (Triple.isPPC())
+if (const Arg *A =
MaskRay wrote:
use `AddOptInFlag`
https://github.com/llvm/l
@@ -0,0 +1,18 @@
+// REQUIRES: powerpc-registered-target
+// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mcpu=pwr8 -O3 -mregnames \
+// RUN: %s 2>&1 >/dev/null | FileCheck %s --check-prefix=FULLNAMES
+// RUN: %clang -### -target powerpc64-ibm-aix-xcoff -mcpu=pwr8 -O3 -mregna
@@ -0,0 +1,18 @@
+// REQUIRES: powerpc-registered-target
+// RUN: %clang -### -target powerpc-ibm-aix-xcoff -mcpu=pwr8 -O3 -mregnames \
+// RUN: %s 2>&1 >/dev/null | FileCheck %s --check-prefix=FULLNAMES
+// RUN: %clang -### -target powerpc64-ibm-aix-xcoff -mcpu=pwr8 -O3 -mregna
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/70255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1780,6 +1780,9 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions
&Opts, ArgList &Args,
Opts.setDebugInfo(llvm::codegenoptions::LimitedDebugInfo);
}
+ if (const Arg *A = Args.getLastArg(OPT_mregnames))
+Opts.PPCUseFullRegisterNames = true;
--
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/70255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JOE1994 wrote:
This revision seems related to the following buildbot failure:
* https://lab.llvm.org/buildbot/#/builders/268/builds/1747
(+ builds 1748 & 1749)
Would you mind taking a look? Thank you 👍
https://github.com/llvm/llvm-project/pull/69949
antiagainst wrote:
Sorry about that! I uploaded
https://github.com/llvm/llvm-project/commit/4a4b8570f7c16346094c59fab1bd8debf9b177e1
to fix this. Verified that it fixes the break for me locally.
https://github.com/llvm/llvm-project/pull/69949
___
cfe
jaredgrubb added inline comments.
Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:55
+const FormatToken *LParenTok, const FormatToken *RParenTok) const {
+ // Skip past any leading comments.
+ const FormatToken *const BeginTok = LParenTok->getNextNonComment
jaredgrubb updated this revision to Diff 558009.
jaredgrubb marked 28 inline comments as done.
jaredgrubb added a comment.
Addressing all review comments to date.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150083/new/
https://reviews.llvm.org/D150083
Files:
clang/docs/ClangFormatS
jaredgrubb added a comment.
I opened https://github.com/llvm/llvm-project/issues/71323 for this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150083/new/
https://reviews.llvm.org/D150083
___
cfe-commits mailing list
cfe-commits@lists.l
Overhatted wrote:
@MaskRay Pinging. Please let me know if I should tag someone else.
https://github.com/llvm/llvm-project/pull/69887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silee2 wrote:
@antiagainst @joker-eph Can someone merge this PR?
https://github.com/llvm/llvm-project/pull/69941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/71322
>From 40d25b8009f1c8734a99fd1350adaced6884cc7f Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sun, 5 Nov 2023 18:53:48 +0300
Subject: [PATCH 1/3] [clang][NFC] Refacator `CXXNewExpr::InitializationStyle`
@@ -2388,15 +2389,20 @@ class CXXNewExpr final
/// Whether this new-expression has any initializer at all.
bool hasInitializer() const {
-return CXXNewExprBits.StoredInitializationStyle > 0;
+switch (getInitializationStyle()) {
+case CXXNewInitializationStyle::
https://github.com/mshockwave updated
https://github.com/llvm/llvm-project/pull/71197
>From 8d5acb56b364648d1abd6bfff6815af71e131d6e Mon Sep 17 00:00:00 2001
From: Min Hsu
Date: Thu, 2 Nov 2023 17:26:17 -0700
Subject: [PATCH 1/2] [Clang][Driver][LTO] Fix empty stats filename when in LTO
mode
@@ -20,6 +20,8 @@
// CHECK-INVALID: invalid value 'bla' in '-save-stats=bla'
// RUN: %clang -target x86_64-linux-unknown -save-stats -flto -o
obj/dir/save-stats.exe %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-LTO
+// Previously `-plugin-opt=stats-file` would use empty fil
@@ -535,7 +535,15 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C,
const JobAction &JA,
if (D.isUsingLTO()) {
assert(!Inputs.empty() && "Must have at least one input.");
-addLTOOptions(ToolChain, Args, CmdArgs, Output, Inputs[0],
+// Find the first
Author: Min-Yih Hsu
Date: 2023-11-05T11:31:26-08:00
New Revision: 85451f486d8144f8aacd94a47802c77da5a04d27
URL:
https://github.com/llvm/llvm-project/commit/85451f486d8144f8aacd94a47802c77da5a04d27
DIFF:
https://github.com/llvm/llvm-project/commit/85451f486d8144f8aacd94a47802c77da5a04d27.diff
L
https://github.com/mshockwave closed
https://github.com/llvm/llvm-project/pull/71197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15,6 +15,7 @@
#include "Utils.h"
#include "mlir/Dialect/GPU/IR/GPUDialect.h"
+#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h"
jpienaar wrote:
This feels off: you have GPU dialect transforms depending on SPIRV
attributes/dialect (esp in header). Why is
@@ -15,6 +15,7 @@
#include "Utils.h"
#include "mlir/Dialect/GPU/IR/GPUDialect.h"
+#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h"
fabianmcg wrote:
Back when the compilation redesign was happening we decided to add the attach*
passes in GPU to avoid pollut
@@ -18,8 +18,11 @@
_LIBCPP_BEGIN_NAMESPACE_STD
-template
-struct __is_trivial_plus_operation : false_type {};
+template
AntonRydahl wrote:
Hi @ldionne!
I am unsure about what I am supposed to do with the following:
```C++
template struct __desugars_to<__
Author: Brad Smith
Date: 2023-11-05T15:09:31-05:00
New Revision: 8103ae666402fbcfd68839994bfd848c3925fbed
URL:
https://github.com/llvm/llvm-project/commit/8103ae666402fbcfd68839994bfd848c3925fbed
DIFF:
https://github.com/llvm/llvm-project/commit/8103ae666402fbcfd68839994bfd848c3925fbed.diff
LO
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
In quite a few places we only detect `.exe` as the extension name. I am not
sure we should commit to arbitrary extension name now. The build systems can
consider `--driver-mode=cl`
https://github.com/llvm/llvm-project/pull/69887
___
cf
MaskRay wrote:
I think this is fine, but we probably should think about the general option
compatibility problem
https://github.com/llvm/llvm-project/pull/70740#issuecomment-1786180822
https://github.com/llvm/llvm-project/pull/70799
___
cfe-commits m
https://github.com/AntonRydahl updated
https://github.com/llvm/llvm-project/pull/68642
>From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001
From: AntonRydahl
Date: Mon, 9 Oct 2023 15:13:22 -0700
Subject: [PATCH 1/5] Merged __is_trivial_equality_predicate and
__is_trivial_plu
https://github.com/AntonRydahl updated
https://github.com/llvm/llvm-project/pull/68642
>From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001
From: AntonRydahl
Date: Mon, 9 Oct 2023 15:13:22 -0700
Subject: [PATCH 1/5] Merged __is_trivial_equality_predicate and
__is_trivial_plu
ADKaster added inline comments.
Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:202
+ addSystemInclude(DriverArgs, CC1Args,
+ concat(D.SysRoot, "/usr/local/include"));
+ addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, "/usr/include"));
---
jaredgrubb updated this revision to Diff 558010.
jaredgrubb added a comment.
Adjusting the Style comments, since the behavior changed and were not updated
to reflect that leading/trailing comments no longer have special handling.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150083/new/
Xazax-hun wrote:
I think every time we need to iterate over all member of an equivalence class,
we might do something wrong. The point of the equivalence class would be to
make sure those elements are equivalent. One way to avoid iteration would be to
always use the representative of the equiv
ADKaster added inline comments.
Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:76
+ if (!IsStatic || IsStaticPIE)
+CmdArgs.push_back("--eh-frame-hdr");
+
MaskRay wrote:
> This is not tested
Hm. this also seems like incorrect logic. In my next push I wi
@@ -1180,8 +1180,19 @@ void Clang::AddPreprocessingOptions(Compilation &C,
const JobAction &JA,
if (ArgM->getOption().matches(options::OPT_M) ||
ArgM->getOption().matches(options::OPT_MD))
CmdArgs.push_back("-sys-header-deps");
+
+ // #70011: Canonicaliz
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/71097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/71097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,3 +1,6 @@
+// REQUIRES: !system-windows
MaskRay wrote:
`UNSUPPORTED: system-windows`
https://github.com/llvm/llvm-project/pull/71097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
@@ -0,0 +1,38 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/69498
>From 77c0256c3ae99808a8def68bfcf5eee2fad704ca Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 14 Jun 2023 17:49:22 -0700
Subject: [PATCH 1/7] [libc++] Fix the behavior of throwing `operator new`
under -f
ldionne wrote:
> I think we can check whether it's been overridden more easily using an asm
> alias like this (when libc++ is built under -fno-exceptions):
This doesn't work on Darwin (apparently we don't support the alias attribute on
that platform). I could investigate doing this all non-Dar
https://github.com/MaskRay requested changes to this pull request.
Agree that the motivation should be communicated. Driver options have stronger
stability guarantee. If there are sufficient motivation and useful
MCTargetOptions that we don't feel comfortable exposing driver options, I think
t
https://github.com/jimmy-zx created
https://github.com/llvm/llvm-project/pull/71341
Exposes `CXRewriter` API in
https://github.com/llvm/llvm-project/commit/69e5abb57b70570cf04671a93246e5e624023650.
>From 887751e365ca72515679f61d0734b1631ac38335 Mon Sep 17 00:00:00 2001
From: Jimmy Z <51149050+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jimmy Z (jimmy-zx)
Changes
Exposes `CXRewriter` API in
https://github.com/llvm/llvm-project/commit/69e5abb57b70570cf04671a93246e5e624023650.
---
Full diff: https://github.com/llvm/llvm-project/pull/71341.diff
2 Files Affected:
- (modif
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:76
+ if (!IsStatic || IsStaticPIE)
+CmdArgs.push_back("--eh-frame-hdr");
+
ADKaster wrote:
> MaskRay wrote:
> > This is not tested
> Hm. this also seems like incorrect logic.
https://github.com/jimmy-zx updated
https://github.com/llvm/llvm-project/pull/71341
>From 887751e365ca72515679f61d0734b1631ac38335 Mon Sep 17 00:00:00 2001
From: Jimmy Z <51149050+jimmy...@users.noreply.github.com>
Date: Mon, 6 Nov 2023 00:25:39 +
Subject: [PATCH 1/2] [libclang/python] Expos
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68753
>From 9824ef111975386152173916c1fd6a85264be0a0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Oct 2023 16:35:11 -0700
Subject: [PATCH 1/5] [libc++] Allow running the test suite with optimizations
This
https://github.com/jimmy-zx edited
https://github.com/llvm/llvm-project/pull/71341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 171 matches
Mail list logo
