[clang] Perf/lexer faster slow get char and size (PR #70543)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e00d32afb9d33a1eca48e2b041c9688436706c5b a20790e9e87d2ede14605b277184d2b8c5b0979f --

[clang] Perf/lexer faster slow get char and size (PR #70543)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70543 >From 7bbcabd82edc1736cc22243e109dc0858036c6ac Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Fri, 27 Oct 2023 22:48:08 +0200 Subject: [PATCH 1/2] [clang] Change GetCharAndSizeSlow interface to

[clang] [clang][Interp] Fix variables refering to their own address (PR #70587)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/70587 This was a combination of issues: 1) We can subtract pointers that don't point into arrays. 2) In C, everything is possible. >From 01d5cccfc4cd3813fb57e17af3c7b395bc0c9646 Mon Sep 17 00:00:00 2001 From: =?UT

[clang] [clang][Interp] Fix variables refering to their own address (PR #70587)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This was a combination of issues: 1) We can subtract pointers that don't point into arrays. 2) In C, everything is possible. --- Full diff: https://github.com/llvm/llvm-project/pull/70587.diff 3 Files A

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= ,

[clang] [clang][Interp] Handle CXXTryStmts (PR #70584)

https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/70584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/6] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/7] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/7] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang] Fix #68492: point to the correct const location (PR #69103)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69103 >From 354a8e4034afd82e6ea854848a86b9011e26269b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Fri, 13 Oct 2023 19:27:15 +0100 Subject: [PATCH 1/5] Fix #68492: point to the correct const location --- .../read

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69103 >From 354a8e4034afd82e6ea854848a86b9011e26269b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Fri, 13 Oct 2023 19:27:15 +0100 Subject: [PATCH 1/5] Fix #68492: point to the correct const location --- .../read

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4655487 , @rsmith wrote: > In D86993#4655474 , @RalfJung wrote: > >> With everything moving to github PRs, what are the next steps for this patch? > > I'm unlikely to have cy

[clang] [OpenMP] Add support for Solaris (PR #70593)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70593 Tested on `amd64-pc-solaris2.11`. >From 808764675f3cc37f9b2e0f3f31372be93ada6b84 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 29 Oct 2023 09:02:12 -0400 Subject: [PATCH] [OpenMP] Add support for Solaris Te

[clang] [OpenMP] Add support for Solaris (PR #70593)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad Smith (brad0) Changes Tested on `amd64-pc-solaris2.11`. --- Full diff: https://github.com/llvm/llvm-project/pull/70593.diff 7 Files Affected: - (modified) clang/lib/Driver/ToolChains/Solaris.cpp (+5) - (modified) clang/test/Driver

[clang] [OpenMP] Add support for Solaris (PR #70593)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 640274ff1fe17852615564a80d9f8c69b67f1d59 808764675f3cc37f9b2e0f3f31372be93ada6b84 --

[clang] [OpenMP] Add support for Solaris (PR #70593)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70593 >From 80c900b380de3b6b536084e680bcffbd2b94962d Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 29 Oct 2023 09:02:12 -0400 Subject: [PATCH] [OpenMP] Add support for Solaris Tested on `amd64-pc-solaris2.11`. ---

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

https://github.com/Rajveer100 created https://github.com/llvm/llvm-project/pull/70594 Resolves Issue #35603 This change makes the `assertion` less strict in `debug` builds by stripping qualifiers from the base class and ignoring them. I hope `weakened` assertions don't affect other cases wher

[clang] [clang] Fix clang++ crash on assertions when compiling source (PR #70594)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Rajveer Singh Bharadwaj (Rajveer100) Changes Resolves Issue #35603 This change makes the `assertion` less strict in `debug` builds by stripping qualifiers from the base class and ignoring them. I hope `weakened` assertions don't affect o

[clang] f8fe400 - [clang][Interp][NFC] Make IntegralAP::isSigned() constexpr

Author: Timm Bäder Date: 2023-10-29T14:15:44+01:00 New Revision: f8fe40090ab302921bc4b83969bfec8b31c902aa URL: https://github.com/llvm/llvm-project/commit/f8fe40090ab302921bc4b83969bfec8b31c902aa DIFF: https://github.com/llvm/llvm-project/commit/f8fe40090ab302921bc4b83969bfec8b31c902aa.diff LO

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/70306 >From b7af057b1e8cd56ce1151d6232244c137d349ea9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?

[clang-tools-extra] [clang-tidy] Add readability-redundant-casting check (PR #70595)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Detects explicit type casting operations that involve the same source and destination types, and subsequently recommend their removal. Covers a range of explicit casting operations. Its primary objectiv

[clang-tools-extra] [clang-tidy] Add readability-redundant-casting check (PR #70595)

PiotrZSL wrote: 431 issues found in llvm. Example: ``` clang/lib/Sema/SemaAttr.cpp:332:21: warning: redundant explicit casting to the same type 'Expr *' as the sub-expression, remove this casting [readability-redundant-casting] 332 | Expr *Alignment = static_cast(alignment); |

[clang-tools-extra] [clang-tidy] Add readability-redundant-casting check (PR #70595)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/70595 Detects explicit type casting operations that involve the same source and destination types, and subsequently recommend their removal. Covers a range of explicit casting operations. Its primary objective is to

[clang-tools-extra] [clang-tidy] Fix #68492: point to the correct const location (PR #69103)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Fix #68492: point to the correct const location (PR #69103)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix #68492: point to the correct const location (PR #69103)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tidy] Fix readability-avoid-const-params-in-decls - point to the correct const location (PR #69103)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix readability-avoid-const-params-in-decls - point to the correct const location (PR #69103)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 3f64c0f - [clang-tidy] Fix readability-avoid-const-params-in-decls - point to the correct const location (#69103)

Author: Da-Viper Date: 2023-10-29T15:17:32+01:00 New Revision: 3f64c0fc48c5b2efc5b9ba11351647d515f23418 URL: https://github.com/llvm/llvm-project/commit/3f64c0fc48c5b2efc5b9ba11351647d515f23418 DIFF: https://github.com/llvm/llvm-project/commit/3f64c0fc48c5b2efc5b9ba11351647d515f23418.diff LOG:

[clang] [clang-tidy] Fix readability-avoid-const-params-in-decls - point to the correct const location (PR #69103)

https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix readability-avoid-const-params-in-decls - point to the correct const location (PR #69103)

https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Add support for Solaris (PR #70593)

shiltian wrote: I'm not familiar with Solaris but does it need dedicated implementation of the function invocation written in ASM? https://github.com/llvm/llvm-project/pull/70593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] Perf/lexer faster slow get char and size (PR #70543)

@@ -1964,11 +1969,14 @@ bool Lexer::LexIdentifierContinue(Token &Result, const char *CurPtr) { /// isHexaLiteral - Return true if Start points to a hex constant. /// in microsoft mode (where this is supposed to be several different tokens). bool Lexer::isHexaLiteral(const char

[clang] Perf/lexer faster slow get char and size (PR #70543)

https://github.com/cor3ntin approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle CXXTryStmts (PR #70584)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/70584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change representation of CurLexerKind (PR #70381)

@@ -817,7 +817,7 @@ For later versions of Visual Studio, no setup is required--> {IncludeMacroStack._Mypair._Myval2._Mylast - 1,na} {CurLexer._Mypair._Myval2,na} Expanding Macro: {CurTokenLexer._Mypair._Myval2,na} - cor3ntin wrote: @AaronBal

[clang] [clang] Change representation of CurLexerKind (PR #70381)

@@ -1914,7 +1909,7 @@ class Preprocessor { /// Recompute the current lexer kind based on the CurLexer/ /// CurTokenLexer pointers. - void recomputeCurLexerKind(); + void recomputeCurLexerCallback(); cor3ntin wrote: I think renaming this one is a bit too

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

@@ -4078,8 +4092,20 @@ OpenMPIRBuilder::createTargetInit(const LocationDescription &Loc, bool IsSPMD) { Constant *DebugIndentionLevelVal = ConstantInt::getSigned(Int16, 0); Function *Kernel = Builder.GetInsertBlock()->getParent(); - auto [MinThreadsVal, MaxThreadsVal] =

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

@@ -339,9 +339,33 @@ Error GenericKernelTy::init(GenericDeviceTy &GenericDevice, ImagePtr = &Image; - PreferredNumThreads = GenericDevice.getDefaultNumThreads(); + // Retrieve kernel environment object for the kernel. + GlobalTy KernelEnv(std::string(Name) + "_kernel_env

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/70383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

https://github.com/jhuber6 approved this pull request. Lots of churn but looks straightforward enough. Few nits. https://github.com/llvm/llvm-project/pull/70383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] d8f5a18 - Perf/lexer faster slow get char and size (#70543)

Author: serge-sans-paille Date: 2023-10-29T18:17:02Z New Revision: d8f5a18b6e587aeaa8b99707e87b652f49b160cd URL: https://github.com/llvm/llvm-project/commit/d8f5a18b6e587aeaa8b99707e87b652f49b160cd DIFF: https://github.com/llvm/llvm-project/commit/d8f5a18b6e587aeaa8b99707e87b652f49b160cd.diff

[clang] Perf/lexer faster slow get char and size (PR #70543)

https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change representation of CurLexerKind (PR #70381)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70381 >From 3fe63f81fcb999681daa11b2890c82fda3aaeef5 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH 1/2] [clang] Change representation of CurLexerKind

[clang] [clang] Change representation of CurLexerKind (PR #70381)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70381 >From 3fe63f81fcb999681daa11b2890c82fda3aaeef5 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH 1/2] [clang] Change representation of CurLexerKind

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

https://github.com/jdoerfert updated https://github.com/llvm/llvm-project/pull/70383 >From fa6d6d9cf6398915f911e06eecc78c7ba83d3623 Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Wed, 25 Oct 2023 16:46:01 -0700 Subject: [PATCH] [OpenMP] Associate the KernelEnvironment with the GenericK

[clang] d346c82 - [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (#70383)

Author: Johannes Doerfert Date: 2023-10-29T11:35:34-07:00 New Revision: d346c82435f377984c2ff3d7d4b5e3942c72bc17 URL: https://github.com/llvm/llvm-project/commit/d346c82435f377984c2ff3d7d4b5e3942c72bc17 DIFF: https://github.com/llvm/llvm-project/commit/d346c82435f377984c2ff3d7d4b5e3942c72bc17.d

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

https://github.com/jdoerfert closed https://github.com/llvm/llvm-project/pull/70383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change representation of CurLexerKind (PR #70381)

https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/70381 >From 3fe63f81fcb999681daa11b2890c82fda3aaeef5 Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Thu, 26 Oct 2023 22:31:43 +0200 Subject: [PATCH 1/3] [clang] Change representation of CurLexerKind

[clang-tools-extra] [clang-tidy] Improve modernize-make-shared check (PR #70600)

https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/70600 Improved modernize-make-shared check to support std::shared_ptr implementations that inherit the reset method from a base class. In GCC that class is called __shared_ptr. Fixes #64481 >From 79c01dbf330cd3489ee8

[clang-tools-extra] [clang-tidy] Improve modernize-make-shared check (PR #70600)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Improved modernize-make-shared check to support std::shared_ptr implementations that inherit the reset method from a base class. In GCC that class is called __shared_ptr. Fixes #64481 --- Full diff: htt

[clang] 91b9a66 - [clang-format][NFC] Reduce indent

Author: Björn Schäpers Date: 2023-10-29T20:55:12+01:00 New Revision: 91b9a661c21891dc06e1721a26478d5bfe53e4ed URL: https://github.com/llvm/llvm-project/commit/91b9a661c21891dc06e1721a26478d5bfe53e4ed DIFF: https://github.com/llvm/llvm-project/commit/91b9a661c21891dc06e1721a26478d5bfe53e4ed.diff

[clang] [clang-format][NFC] Reduce indent (PR #70583)

https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/70583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotating annotations after requires clause (PR #70602)

https://github.com/HazardyKnusperkeks created https://github.com/llvm/llvm-project/pull/70602 Fixes #69325. From 9d3169cbd756f6c3ba9ac2a7e334677c330da3d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Sun, 29 Oct 2023 20:55:31 +0100 Subject: [PATCH] [clang-format]

[clang] [clang-format] Fix annotating annotations after requires clause (PR #70602)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Björn Schäpers (HazardyKnusperkeks) Changes Fixes #69325. --- Full diff: https://github.com/llvm/llvm-project/pull/70602.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+2-1) - (modified) clang/unittests

[clang] [clang-format] Fix annotating annotations after requires clause (PR #70602)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/70602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Perf/lexer faster slow get char and size (PR #70543)

rorth wrote: This patch broke builders like [Solaris/amd64](https://lab.llvm.org/staging/#/builders/8/builds/761) that include `clang-tools-extra`. https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] Perf/lexer faster slow get char and size (PR #70543)

nico wrote: This breaks building: http://45.33.8.238/linux/121901/step_4.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/70606 Break down the counted_by calculations so that they correctly handle anonymous structs, which are specified internally as IndirectFieldDecls. Also simplify the code to use helper methods to get the field referen

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes Break down the counted_by calculations so that they correctly handle anonymous structs, which are specified internally as IndirectFieldDecls. Also simplify the code to use helper methods to get the field re

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

bwendling wrote: To answer @nickdesaulniers 's question, the testcases are in the works. :-) https://github.com/llvm/llvm-project/pull/70606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 91b9a661c21891dc06e1721a26478d5bfe53e4ed 19dd7db8ab5f98a618c717944c96b34e604fbc30 --

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/70606 >From 19dd7db8ab5f98a618c717944c96b34e604fbc30 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Sun, 29 Oct 2023 14:58:04 -0700 Subject: [PATCH 1/2] [CodeGen] Revamp counted_by calculations Break down the co

[clang] [OpenMP] Add support for Solaris (PR #70593)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70593 >From 0933677259d446875c25898383c1c206b0c6efd8 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 29 Oct 2023 09:02:12 -0400 Subject: [PATCH] [OpenMP] Add support for Solaris Tested on `amd64-pc-solaris2.11`. ---

[clang] [Clang] Warn against unused parameters in C++ coroutines with `-Wunused-parameters` (PR #70567)

https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/70567 >From ba6c43cc63e9ae3c8d174406ced4df839af3e0a7 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Fri, 27 Oct 2023 16:37:40 -0700 Subject: [PATCH 1/3] [Clang] Coroutines: warn against unused parameters in C+

[clang] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for bare kernel (PR #68373)

https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/68373 >From d0d8bcc9fa002304ef79ca48d736853ca621c0bd Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 29 Oct 2023 19:17:19 -0400 Subject: [PATCH] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for b

[clang] [OpenMP] Add support for Solaris (PR #70593)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70593 >From e4482f4e77f8ed3de5e3aedbfb8662f2deccef2b Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 29 Oct 2023 09:02:12 -0400 Subject: [PATCH] [OpenMP] Add support for Solaris Tested on `amd64-pc-solaris2.11`. ---

[clang] no default grid size (PR #70612)

https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/70612 - [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for bare kernel - [OpenMP] Directly use user's grid and block size in kernel language mode >From 7b0eaa1606ad2e557105fed9509c135f857db375 Mon Sep 17

[clang] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/70612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/70612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/70612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/70612 >From 7b0eaa1606ad2e557105fed9509c135f857db375 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 29 Oct 2023 19:18:49 -0400 Subject: [PATCH 1/2] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` f

[clang] [OpenMP] Directly use user's grid and block size in kernel language mode (PR #70612)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Shilei Tian (shiltian) Changes In kernel language mode, use user's grid and blocks size directly. No validity check, which means if user's values are too large, the launch will fail, similar to what CUDA and HIP are doing right now. Depend

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added a comment. @MaskRay @phosek Daniel and I have updated the patch set, Would you rather I update the phab patch series, or re-upload the set as GitHub PRs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llv

[clang] 1c876ff - Revert "Perf/lexer faster slow get char and size (#70543)"

Author: Nico Weber Date: 2023-10-29T21:11:39-04:00 New Revision: 1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4 URL: https://github.com/llvm/llvm-project/commit/1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4 DIFF: https://github.com/llvm/llvm-project/commit/1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4.diff LO

[clang] Perf/lexer faster slow get char and size (PR #70543)

nico wrote: Reverted in 1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4 for now. https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. In D154396#4655494 , @ADKaster wrote: > @MaskRay @phosek Daniel and I have updated the patch set, Would you rather I > update the phab patch series, or re-upload the set as GitHub PRs? Update the phab patch series. Repository:

[clang] [OpenMP] Add support for Solaris (PR #70593)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70593 >From e59311bf2d895ebd5c031d01113d5de879c9c542 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 29 Oct 2023 09:02:12 -0400 Subject: [PATCH] [OpenMP] Add support for Solaris/x86_64 Tested on `amd64-pc-solaris2.1

[clang] [OpenMP] Add support for Solaris/x86_64 (PR #70593)

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/70593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/zyn0217 commented: Thank you for working on this! Some nit comments, hope you don't mind. (Also invited some clang folks to have a detailed look at this. :=) https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing li

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema &S, llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifie

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema &S, llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifie

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema &S, llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifie

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema &S, llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifie

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Add support for Solaris/x86_64 (PR #70593)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70593 >From fcb4794f8f27357b456f6c99a51e593c8410477d Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 29 Oct 2023 09:02:12 -0400 Subject: [PATCH] [OpenMP] Add support for Solaris/x86_64 Tested on `amd64-pc-solaris2.1

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster updated this revision to Diff 557927. ADKaster added a comment. Herald added subscribers: wangpc, s.egerton, ormris, simoncook, asb. Base on Generic_ELF driver, add tests, add myself as co-author Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D154401: [tools] Support building shared libLLVM and libClang for SerenityOS

ADKaster updated this revision to Diff 557930. ADKaster added a comment. prefer CMake platform defined name SERENITYOS over CMAKE_SYSTEM_NAME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154401/new/ https://reviews.llvm.org/D154401 Files: llvm/

[PATCH] D154402: [compiler-rt] Enable profile instrumentation for SerenityOS

ADKaster updated this revision to Diff 557931. ADKaster added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update Driver as well, and add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154402/new/ https://re

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added a comment. In D154396#4655496 , @brad wrote: > In D154396#4655494 , @ADKaster > wrote: > >> @MaskRay @phosek Daniel and I have updated the patch set, Would you rather >> I update the phab patch s

[clang] 2204364 - [docs] [C++20] [Modules] Add document for the case of duplicated '-fmodule-file=='

Author: Chuanqi Xu Date: 2023-10-30T11:25:21+08:00 New Revision: 22043643c64f748cb00ae92476f2085b3c0903c9 URL: https://github.com/llvm/llvm-project/commit/22043643c64f748cb00ae92476f2085b3c0903c9 DIFF: https://github.com/llvm/llvm-project/commit/22043643c64f748cb00ae92476f2085b3c0903c9.diff LO

[clang] [C++20] [Modules] Warn if we found #include in module purview (PR #69555)

ChuanqiXu9 wrote: @Bigcheese ping https://github.com/llvm/llvm-project/pull/69555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Add support for Solaris/x86_64 (PR #70593)

brad0 wrote: > I'm not familiar with Solaris but does it need dedicated implementation of > the function invocation written in ASM? Can you point out what you're referring to? Looking at the patches for adding support for OpenBSD and other OS's I don't see any ASM additions. https://github.co

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. Make use of the concat macro with the various header and library paths. https://github.com/llvm/llvm-project/commit/1d0cc510516d50c459f78896a0375fadb13a2b45 Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:78 + + if (Output.isFilename()) { +CmdArg

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. You also have to add Serenity to clang/lib/Lex/InitHeaderSearch.cpp InitHeaderSearch::ShouldAddDefaultIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 ___

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.h:81 + + unsigned GetDefaultDwarfVersion() const override { return 5; } + This just overrides the default DWARF version anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69551 >From c91007b51e164d22c8f73a864105494ebc10a004 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Mon, 30 Oct 2023 11:51:04 +0800 Subject: [PATCH] [clang-scan-deps] [P1689] Keep consistent behavior for make depe

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

ChuanqiXu9 wrote: > Thanks for the ping, I had missed your question > > > How do you think about the idea to add a flag to the MDC about whether or > > not calling makeAbsoluteAndPreferred? > > SGTM; this seems like a good compromise since we can't easily extract this > into the consumer. Do

[clang-tools-extra] create new clang-tidy check to add namespaces to symbol references (PR #70621)

https://github.com/daltairwalter created https://github.com/llvm/llvm-project/pull/70621 What should be done when "using namespace" has been abused or used in header files? This check will update all references to include full namespace qualification. >From f44d7746a990a3bd8e53de047a30baee4d

[clang-tools-extra] create new clang-tidy check to add namespaces to symbol references (PR #70621)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a8d0c86174b4e7355e250b3eb266e055df224f48 38df6a99730d64eb96945845b69ce7602ce3ddfa --

  1   2   >