[clang] [libc++] Fixed uniform_real_distribution.h where it was allowing initialization with non floating point types (PR #70485)

2023-10-27 Thread via cfe-commits
@@ -27,6 +28,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD template class _LIBCPP_TEMPLATE_VIS uniform_real_distribution { + static_assert(std::is_floating_point<_RealType>::value, "result_type must be a floating point type"); philnik777 wrote: This needs a test. You

[clang] [libc++] Fixed uniform_real_distribution.h where it was allowing initialization with non floating point types (PR #70485)

2023-10-27 Thread via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/70485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Fixed uniform_real_distribution.h where it was allowing initialization with non floating point types (PR #70485)

2023-10-27 Thread via cfe-commits
philnik777 wrote: You should also mention the issue in the description. https://github.com/llvm/llvm-project/pull/70485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Fixed uniform_real_distribution.h where it was allowing initialization with non floating point types (PR #70485)

2023-10-27 Thread Pranav Tatavarthy via cfe-commits
Pranav10903 wrote: Thank you for your guidance, I will do the required changes. Thank you. https://github.com/llvm/llvm-project/pull/70485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] 08e9c46 - SwiftCallingConv: Fix the splitVectorEntry function (#69953)

2023-10-27 Thread via cfe-commits
Author: Arnold Schwaighofer Date: 2023-10-27T11:42:37-07:00 New Revision: 08e9c462eaa900449c2250c7ae84d9d303de9fb4 URL: https://github.com/llvm/llvm-project/commit/08e9c462eaa900449c2250c7ae84d9d303de9fb4 DIFF: https://github.com/llvm/llvm-project/commit/08e9c462eaa900449c2250c7ae84d9d303de9fb4

[clang] SwiftCallingConv: Fix the splitVectorEntry function (PR #69953)

2023-10-27 Thread Arnold Schwaighofer via cfe-commits
https://github.com/aschwaighofer closed https://github.com/llvm/llvm-project/pull/69953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-10-27 Thread Sunil K via Phabricator via cfe-commits
koops updated this revision to Diff 557920. koops added a comment. Removing the printing of parameter of FailClause. This needed a special if statement in Visit(const OMPClause *C) , which is a generalized Visit for Clauses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ ht

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-27 Thread David Pagan via Phabricator via cfe-commits
ddpagan added a comment. Did anything change after the patch was reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] [libc] Adding a version of memset with software prefetching (PR #70493)

2023-10-27 Thread via cfe-commits
https://github.com/doshimili created https://github.com/llvm/llvm-project/pull/70493 Software prefetching helps recover performance when hardware prefetching is disabled. The 'LIBC_COPT_MEMSET_X86_USE_SOFTWARE_PREFETCHING' compile time option allows users to use this patch. >From 6c313955185c

[clang] [libc] Adding a version of memset with software prefetching (PR #70493)

2023-10-27 Thread via cfe-commits
https://github.com/doshimili created https://github.com/llvm/llvm-project/pull/70493 Software prefetching helps recover performance when hardware prefetching is disabled. The 'LIBC_COPT_MEMSET_X86_USE_SOFTWARE_PREFETCHING' compile time option allows users to use this patch. >From 6c313955185c

[clang] [libc++] Fixed uniform_real_distribution.h where it was allowing initialization with non floating point types (PR #70485)

2023-10-27 Thread Pranav Tatavarthy via cfe-commits
https://github.com/Pranav10903 updated https://github.com/llvm/llvm-project/pull/70485 >From 52cb5d88e3a4bd347f6993405b18480acc0835f1 Mon Sep 17 00:00:00 2001 From: Pranav Tatavarthy <97344709+pranav10...@users.noreply.github.com> Date: Fri, 27 Oct 2023 21:41:41 +0530 Subject: [PATCH 1/3] Update

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-27 Thread Sunil K via Phabricator via cfe-commits
koops added a comment. In D158266#4655433 , @ddpagan wrote: > Did anything change after the patch was reverted? I have not changed anything in the code yet. I am still investigating. The test where it is failing has nothing to do with my changes. I do n

[clang] [clang][wasm] Resolve assertion errors caused by converting ComplexTy… (PR #70496)

2023-10-27 Thread via cfe-commits
https://github.com/knightXun created https://github.com/llvm/llvm-project/pull/70496 When a function parameter is of the built-in Complex type in Clang, the conversion from ComplexType to RecordType is not possible, resulting in a crash in Clang. RecordType is a helper class for structs, union

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-27 Thread David Pagan via Phabricator via cfe-commits
ddpagan added a comment. Ok. Thanks for the clarification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] make v32i16/v32f16 legal (PR #70484)

2023-10-27 Thread Changpeng Fang via cfe-commits
https://github.com/changpeng edited https://github.com/llvm/llvm-project/pull/70484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][wasm] Resolve assertion errors caused by converting ComplexTy… (PR #70496)

2023-10-27 Thread via cfe-commits
https://github.com/knightXun updated https://github.com/llvm/llvm-project/pull/70496 >From e0ce1bab37de863d32d5d2e9b97f8bc345ef9ad9 Mon Sep 17 00:00:00 2001 From: xuknight Date: Sat, 28 Oct 2023 02:52:43 +0800 Subject: [PATCH] [clang][wasm] Resolve assertion errors caused by converting Complex

[clang] [clang] Refactor TBAA Base Info construction (PR #70499)

2023-10-27 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/70499 I noticed a few issues with `CodeGenTBAA::getBaseTypeInfo`. 1) `isValidBaseType` explicitly checks for a reference type to return false, but then also returns false for all non-record types. Just remove that r

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-10-27 Thread Owen Pan via cfe-commits
owenca wrote: > @gedare can you fix the merge conflict on this one? We don't want to merge this yet. See [here](https://github.com/llvm/llvm-project/issues/68079#issuecomment-1776826021). https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commit

[clang-tools-extra] 2463a0e - [clang-tidy][test] Add more bugprone-string-constructor tests (#70456)

2023-10-27 Thread via cfe-commits
Author: ツ Date: 2023-10-27T21:20:37+02:00 New Revision: 2463a0ed70754524efb6e05b09d632dcacf9b51f URL: https://github.com/llvm/llvm-project/commit/2463a0ed70754524efb6e05b09d632dcacf9b51f DIFF: https://github.com/llvm/llvm-project/commit/2463a0ed70754524efb6e05b09d632dcacf9b51f.diff LOG: [clang

[clang-tools-extra] [clang-tidy][test] Add more bugprone-string-constructor tests (PR #70456)

2023-10-27 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/70456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][AMDGPU] Do not include 'ockl' implementations in OpenMP (PR #70462)

2023-10-27 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield approved this pull request. https://github.com/llvm/llvm-project/pull/70462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Please see [here](https://github.com/llvm/llvm-project/issues/68079#issuecomment-1776826021). https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commits mailing list cfe-commits@li

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-10-27 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: No need to change to `sink(std::numbers::phi)`, simply just replace numbers, leave usage like it is. https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread James E T Smith via cfe-commits
jamesETsmith wrote: Making the operations conditionals was pretty straightforward, but `using difference_type = std::iter_difference_t` is causing problems because it requires that all `T` types implement `T::difference_type` which I think is too strong a requirement. For example, this will ca

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread Björn Schäpers via cfe-commits
@@ -24153,6 +24153,23 @@ TEST_F(FormatTest, WhitespaceSensitiveMacros) { verifyNoChange("FOO(String-ized&Messy+But: :Still=Intentional);", Style); } +TEST_F(FormatTest, IgnorePPDefinitions) { HazardyKnusperkeks wrote: Add some tests: * With formatted code a

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread Björn Schäpers via cfe-commits
@@ -4648,6 +4648,10 @@ struct FormatStyle { /// \version 11 std::vector WhitespaceSensitiveMacros; + /// Ignore formatting in preprocessor definitions. + /// \version 18 + bool IgnorePPDefinitions; HazardyKnusperkeks wrote: Please sort alphabetically.

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread Björn Schäpers via cfe-commits
@@ -1354,7 +1354,9 @@ unsigned UnwrappedLineFormatter::format( bool FixIndentation = (FixBadIndentation || ContinueFormatting) && Indent != TheLine.First->OriginalColumn; -bool ShouldFormat = TheLine.Affected || FixIndentation; +bool Shoul

[clang] [Driver][NFC] Make use of final (PR #70416)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/70416 >From 0a43742a20a0845f61acfa21d19904f426a0f6b8 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 02:22:21 -0400 Subject: [PATCH] [Driver][NFC] Make some derived classes of Tool final --- clang/lib/D

[clang] [Driver][NFC] Make some derived classes of Tool final (PR #70416)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/70416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50403: [clang-format]AlignConsecutiveAssignments

2023-10-27 Thread Owen Pan via Phabricator via cfe-commits
owenpan abandoned this revision. owenpan added a comment. We habe `AlignCompound` now. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to clang/include/clang/Format/Format.h but does not contain an update to ClangFormatStyleOptions.rst C

[clang] 7415799 - [Driver][NFC] Make some derived classes of Tool final (#70416)

2023-10-27 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-27T15:53:14-04:00 New Revision: 741579930e9b49cee9d859a7468f5e9d0c6f2006 URL: https://github.com/llvm/llvm-project/commit/741579930e9b49cee9d859a7468f5e9d0c6f2006 DIFF: https://github.com/llvm/llvm-project/commit/741579930e9b49cee9d859a7468f5e9d0c6f2006.diff LO

<    1   2   3   4