LLVM ABI Annotations (PR #67502)

2023-10-27 Thread Tom Stellard via cfe-commits
tstellar wrote: I'm working on rebasing this. https://github.com/llvm/llvm-project/pull/67502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM ABI Annotations (PR #67502)

2023-10-27 Thread Tom Stellard via cfe-commits
tstellar wrote: I'm working on rebasing this. https://github.com/llvm/llvm-project/pull/67502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM ABI Annotations (PR #67502)

2023-10-27 Thread Tom Stellard via cfe-commits
tstellar wrote: I'm working on rebasing this. https://github.com/llvm/llvm-project/pull/67502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Changes to support running tests for Windows arm64 asan (PR #66973)

2023-10-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/66973 >From 141c9aa7f9b1a6f7b4f877a82c4ccf92ae2b8287 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Wed, 20 Sep 2023 22:58:08 -0400 Subject: [PATCH] Changes to support running tests for Windows arm64 asan 1. Differ

[clang] Changes to support running tests for Windows arm64 asan (PR #66973)

2023-10-27 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/66973 >From 141c9aa7f9b1a6f7b4f877a82c4ccf92ae2b8287 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Wed, 20 Sep 2023 22:58:08 -0400 Subject: [PATCH] Changes to support running tests for Windows arm64 asan 1. Differ

[clang] [clang][analyzer] Add 'tmpfile' as an open function to SimpleStreamChecker (PR #70539)

2023-10-27 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/70539 None >From 10bd2b51df19b6a2a76ad326462528d7aebfc548 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Sat, 28 Oct 2023 14:41:47 +0800 Subject: [PATCH] [clang][analyzer] Add 'tmpfile' as an open function to SimpleS

[clang] [clang][analyzer] Add 'tmpfile' as an open function to SimpleStreamChecker (PR #70539)

2023-10-27 Thread Ben Shi via cfe-commits
benshi001 wrote: There are also many format changes in this PR, since I `clang-format -i` it. https://github.com/llvm/llvm-project/pull/70539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { cor3ntin wrote: I had a chat with @Endilll offline.

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-10-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,816 @@ +// RUN: %clang_cc1 -verify -std=c++2a -fsyntax-only -fexperimental-new-constant-inter

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-27 Thread via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { cor3ntin wrote: @erichkeane @AaronBallman wdyt? htt

[clang] Disable memtag sanitization for global fnptrs going into .ctors (PR #70186)

2023-10-27 Thread Mitch Phillips via cfe-commits
hctim wrote: (friendly ping @eugenis / @vitalybuka) https://github.com/llvm/llvm-project/pull/70186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASAN] For Asan instrumented global, emit two symbols, one with actual size and other with instrumented size. (PR #70166)

2023-10-27 Thread Mitch Phillips via cfe-commits
hctim wrote: I talked with some folks internally and we came to the consensus that this'll almost certainly break some debugging tools and such, it probably won't effect the runtime of binaries, but I wouldn't say that this is a super confidence-inspiring thing to do. > AMD language runtimes

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-10-27 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu accepted this revision. zixuan-wu added a comment. This revision is now accepted and ready to land. LGTM if nobody objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-27 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/68774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-27 Thread Balázs Kéri via cfe-commits
@@ -1373,6 +1373,40 @@ TEST_P(ASTImporterOptionSpecificTestBase, ImportCorrectTemplatedDecl) { ASSERT_EQ(ToTemplated1, ToTemplated); } +TEST_P(ASTImporterOptionSpecificTestBase, + ImportTemplateSpecializationStaticMember) { + auto FromCode = R"( + template clas

[clang] [clang][ASTImporter] Fix crash when template class static member imported to other translation unit. (PR #68774)

2023-10-27 Thread Balázs Kéri via cfe-commits
https://github.com/balazske commented: The fix looks good but the formatting of the test code could be better, like in the other tests. https://github.com/llvm/llvm-project/pull/68774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] c149ff3 - [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (#69817)

2023-10-27 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-27T04:43:19-04:00 New Revision: c149ff3d372a70e7d9de838a1ff0357394b8d017 URL: https://github.com/llvm/llvm-project/commit/c149ff3d372a70e7d9de838a1ff0357394b8d017 DIFF: https://github.com/llvm/llvm-project/commit/c149ff3d372a70e7d9de838a1ff0357394b8d017.diff LO

[clang] [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (PR #69817)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/69817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 051fade - [clang][Interp][NFC] Use delegate() address-of operators

2023-10-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-27T10:43:35+02:00 New Revision: 051fade10f03515b0980c58541fe4c28220e0e67 URL: https://github.com/llvm/llvm-project/commit/051fade10f03515b0980c58541fe4c28220e0e67 DIFF: https://github.com/llvm/llvm-project/commit/051fade10f03515b0980c58541fe4c28220e0e67.diff LO

[clang] e64e478 - [clang][Interp][NFC] Rename a parameter

2023-10-27 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-27T10:43:35+02:00 New Revision: e64e4784ee1c3ed9bb06458e9c427542927224ab URL: https://github.com/llvm/llvm-project/commit/e64e4784ee1c3ed9bb06458e9c427542927224ab DIFF: https://github.com/llvm/llvm-project/commit/e64e4784ee1c3ed9bb06458e9c427542927224ab.diff LO

[clang] e9a7876 - [C++20] [Modules] Chose BMI from for module m with the last

2023-10-27 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-10-27T16:52:21+08:00 New Revision: e9a7876c2c81423f2289aa85eeac32d7a55cd3c8 URL: https://github.com/llvm/llvm-project/commit/e9a7876c2c81423f2289aa85eeac32d7a55cd3c8 DIFF: https://github.com/llvm/llvm-project/commit/e9a7876c2c81423f2289aa85eeac32d7a55cd3c8.diff LO

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 created https://github.com/llvm/llvm-project/pull/70427 This patch fixes the code example on CommonOptionParser on https://intel.github.io/llvm-docs/clang/LibTooling.html CommonOptionParser's constructor is protected and we can use `CommonOptionParser::create` instead

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kohei Asano (khei4) Changes This patch fixes the code example on CommonOptionParser on https://intel.github.io/llvm-docs/clang/LibTooling.html CommonOptionParser's constructor is protected and we can use `CommonOptionParser::create` inst

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-27 Thread Owen Pan via cfe-commits
owenca wrote: IMO, the new behavior is consistent with the [documentation](https://clang.llvm.org/docs/ClangFormatStyleOptions.html#columnlimit) for `ColumnLimt: 0`. https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list cfe-com

[clang] [Driver] Handle Flang in same manner between Gnu and *BSD/Solaris ToolChain (PR #70429)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70429 None >From d8a4aecf5a22382fe57f654616fa59358477d9a4 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 04:53:19 -0400 Subject: [PATCH] [Driver] Handle Flang in same manner between Gnu and *BSD/Solari

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 converted_to_draft https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread via cfe-commits
philnik777 wrote: Why does the proxy not satisfy `weakly_incrementable`? Is it maybe just missing some member functions? https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread via cfe-commits
philnik777 wrote: Why does the proxy not satisfy `weakly_incrementable`? Is it maybe just missing some member functions? https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-27 Thread via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/68413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]set invalid for lambda which missing capture `this` (PR #70432)

2023-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/70432 It can suppression further crash. Fixes: #67687 >From c12aeb6f2a83b9cb3c3815e72d57638cf7de43a0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 27 Oct 2023 16:51:59 +0800 Subject: [PATCH] WIP fix lambd

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

2023-10-27 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70434 Same as 12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d >From 0c21090272eb3e1d6477585ef223413dc627a451 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Fri, 27 Oct 2023 05:13:59 -0400 Subject: [PATCH] [Driver] Silence stdl

[clang] [Driver] Silence stdlib warning when linking C on *BSD / Solaris / Haiku (PR #70434)

2023-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad Smith (brad0) Changes Same as 12b87f6ef720080fab1e2d48ca2d8c5ba478ee5d --- Full diff: https://github.com/llvm/llvm-project/pull/70434.diff 5 Files Affected: - (modified) clang/lib/Driver/ToolChains/DragonFly.cpp (+3) - (modified)

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 1ae7edddc79a0e96fd4b142d09b0752aa3d9ff85 Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH] use: create instead of protected Constructor handle: expected --- clang/do

[clang] 6c3bc91 - [clang-format][NFC] Remove more extraneous newlines in unit tests

2023-10-27 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-27T02:22:36-07:00 New Revision: 6c3bc910588f962e49470098ccc3b13c29cae493 URL: https://github.com/llvm/llvm-project/commit/6c3bc910588f962e49470098ccc3b13c29cae493 DIFF: https://github.com/llvm/llvm-project/commit/6c3bc910588f962e49470098ccc3b13c29cae493.diff LOG:

[clang] [clang][dataflow][NFC] Move `parseAll()` to TestingSupport and rename `parseFormulas()` (PR #70437)

2023-10-27 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/70437 I'm working on a patch that will use this function from a different test. >From 34daee21bca7dbfe906e270a88e829e6beb79c97 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Fri, 27 Oct 2023 09:27:12 +

[clang] [clang][dataflow][NFC] Move `parseAll()` to TestingSupport and rename `parseFormulas()` (PR #70437)

2023-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes I'm working on a patch that will use this function from a different test. --- Full diff: https://github.com/llvm/llvm-project/pull/70437.diff 3 Files Affected: - (modified) clang/unittests/Analysis/FlowSensi

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-27 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/69447 >From 2a65ae75e8c8e62e7275a439849837919599e896 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Thu, 14 Sep 2023 14:51:17 +0100 Subject: [PATCH 1/2] [Driver] Add ExclusiveGroup feature to multilib.yaml. Thi

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Owen Pan via cfe-commits
owenca wrote: > [Google](https://google.github.io/styleguide/cppguide.html) is the only one > mentioning attributes: > > > Attributes, and macros that expand to attributes, appear at the very > > beginning of the function declaration or definition, before the return type: > > ```c++ > > ABSL_

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-27 Thread Simon Tatham via cfe-commits
@@ -0,0 +1,69 @@ +# REQUIRES: shell +# UNSUPPORTED: system-windows + +# RUN: rm -rf %t + +# RUN: mkdir -p %t/baremetal_multilib/bin +# RUN: ln -s %clang %t/baremetal_multilib/bin/clang + +# RUN: mkdir -p %t/baremetal_multilib/lib/clang-runtimes +# RUN: ln -s %s %t/baremetal_multil

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-27 Thread Simon Tatham via cfe-commits
@@ -152,6 +180,7 @@ template <> struct llvm::yaml::MappingTraits { static void mapping(llvm::yaml::IO &io, MultilibSerialization &V) { io.mapRequired("Dir", V.Dir); io.mapRequired("Flags", V.Flags); +io.mapOptional("ExclusiveGroup", V.ExclusiveGroup); ---

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Owen Pan via cfe-commits
@@ -794,6 +794,7 @@ clang-format - Add ``AllowBreakBeforeNoexceptSpecifier`` option. - Add ``AllowShortCompoundRequirementOnASingleLine`` option. +- Change ``BreakAfterAttributes`` from ``Never`` to ``Leave`` in LLVM style owenca wrote: Full stop

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Owen Pan via cfe-commits
@@ -26179,7 +26179,7 @@ TEST_F(FormatTest, RemoveSemicolon) { TEST_F(FormatTest, BreakAfterAttributes) { FormatStyle Style = getLLVMStyle(); - EXPECT_EQ(Style.BreakAfterAttributes, FormatStyle::ABS_Never); + EXPECT_EQ(Style.BreakAfterAttributes, FormatStyle::ABS_Leave); --

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From f9f61fd520727d1e03269af4b5c1e40119d7524e Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH] use: create instead of protected Constructor handle: expected fix: later e

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-27 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/69447 >From 2a65ae75e8c8e62e7275a439849837919599e896 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Thu, 14 Sep 2023 14:51:17 +0100 Subject: [PATCH 1/2] [Driver] Add ExclusiveGroup feature to multilib.yaml. Thi

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 166f580fda7a7cf4b87b167be03777d28638feff Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH] use create instead of protected Constructor --- clang/docs/LibTooling.rst

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-10-27 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc added a comment. @asb @kito-cheng @jrtc27 @craig.topper Can I commit this since the support of RVE is really of great importance for some downstreams? If there are some problems, I will be there to fix them. If we all agree with this, I will mark RVE as exprimental and commit it then. R

[clang] [SVE2.1][Clang][LLVM]Int/FP reduce builtin in Clang and LLVM intrinsic (PR #69926)

2023-10-27 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/69926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 166f580fda7a7cf4b87b167be03777d28638feff Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH 1/2] use create instead of protected Constructor --- clang/docs/LibTooling.

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-10-27 Thread Matt Arsenault via cfe-commits
@@ -5612,6 +5612,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, BundleList); EmitBlock(Cont); } + if (CI->getCalledFunction() && CI->getCalledFunction()->hasName() && + CI->getCalledFunction()->getName().startsw

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-10-27 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. lgtm, but a strict reading of the spec would filter out arbitrary other ext_vector_types https://github.com/llvm/llvm-project/pull/66651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 edited https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/70427 >From 12e29c46366e93c98c96e7561258bc83f66755c1 Mon Sep 17 00:00:00 2001 From: khei4 Date: Fri, 27 Oct 2023 17:46:34 +0900 Subject: [PATCH] use create instead of protected Constructor --- clang/docs/LibTooling.rst

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-27 Thread via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/67805 >From f384bc5feab5b2a0ae71d4c96d123c3fe0d13a73 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 29 Sep 2023 15:45:56 +0200 Subject: [PATCH] [Clang] Add __datasizeof --- clang/docs/LanguageExtensions

[clang] [Clang] Add __datasizeof (PR #67805)

2023-10-27 Thread via cfe-commits
philnik777 wrote: @AaronBallman This did indeed catch a bug. Also, I think there was something about how codegen tests should be written, but I don't remember exactly anymore. Could you take a look at the test? https://github.com/llvm/llvm-project/pull/67805 ___

[clang] [analyzer] Extend EnumCastOutOfRange diagnostics (PR #68191)

2023-10-27 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/68191 From a08f51109bd93f88271f0548719c52c75afc96e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Wed, 4 Oct 2023 10:38:00 +0200 Subject: [PATCH 1/4] [analyzer] Extend EnumCastOutOfRange di

[clang] 9299ace - [clang-format][NFC] Remove extraneous newlines in remaining unit tests

2023-10-27 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-27T03:42:16-07:00 New Revision: 9299ace0a20d3ea4d921c033a49364ea6f24263e URL: https://github.com/llvm/llvm-project/commit/9299ace0a20d3ea4d921c033a49364ea6f24263e DIFF: https://github.com/llvm/llvm-project/commit/9299ace0a20d3ea4d921c033a49364ea6f24263e.diff LOG:

[clang] 7360c6a - [Driver][test][NFC] Simplify some of the OpenBSD tests

2023-10-27 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2023-10-27T06:46:12-04:00 New Revision: 7360c6acf1c485bde54361dee6e307cf435582a3 URL: https://github.com/llvm/llvm-project/commit/7360c6acf1c485bde54361dee6e307cf435582a3 DIFF: https://github.com/llvm/llvm-project/commit/7360c6acf1c485bde54361dee6e307cf435582a3.diff LO

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-27 Thread David Sherwood via cfe-commits
https://github.com/david-arm approved this pull request. LGTM! Eccelente! Thanks for the changes @kmclaughlin-arm. https://github.com/llvm/llvm-project/pull/69725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D134475: [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute

2023-10-27 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt added a comment. Should I re-submit it to GitHub? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475/new/ https://reviews.llvm.org/D134475 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [clang] c149ff3 - [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (#69817)

2023-10-27 Thread Joerg Sonnenberger via cfe-commits
On Friday, October 27, 2023 10:43:23 AM CEST via cfe-commits wrote: > Author: Brad Smith > Date: 2023-10-27T04:43:19-04:00 > New Revision: c149ff3d372a70e7d9de838a1ff0357394b8d017 > > URL: > https://github.com/llvm/llvm-project/commit/c149ff3d372a70e7d9de838a1ff0357 > 394b8d017 DIFF: > https://git

[clang-tools-extra] [clangd] Use InitLLVM (PR #69119)

2023-10-27 Thread Aleksandr Platonov via cfe-commits
ArcsinX wrote: Friendly ping https://github.com/llvm/llvm-project/pull/69119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/70360 >From 3866a77d62a34e612ff869cde7c743e31350eed2 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 26 Oct 2023 20:41:25 +0300 Subject: [PATCH 1/2] [clang-format] Change LLVM style to BreakAfterAttributes

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Vlad Serebrennikov via cfe-commits
@@ -26179,7 +26179,7 @@ TEST_F(FormatTest, RemoveSemicolon) { TEST_F(FormatTest, BreakAfterAttributes) { FormatStyle Style = getLLVMStyle(); - EXPECT_EQ(Style.BreakAfterAttributes, FormatStyle::ABS_Never); + EXPECT_EQ(Style.BreakAfterAttributes, FormatStyle::ABS_Leave); --

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-27 Thread Vlad Serebrennikov via cfe-commits
@@ -794,6 +794,7 @@ clang-format - Add ``AllowBreakBeforeNoexceptSpecifier`` option. - Add ``AllowShortCompoundRequirementOnASingleLine`` option. +- Change ``BreakAfterAttributes`` from ``Never`` to ``Leave`` in LLVM style Endilll wrote: Fixed. h

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread via cfe-commits
https://github.com/tomekpaszek updated https://github.com/llvm/llvm-project/pull/70338 >From 8404d703d58658593e6112b478533edb124cd0e1 Mon Sep 17 00:00:00 2001 From: Tomek Paszek Date: Thu, 26 Oct 2023 16:19:36 +0200 Subject: [PATCH 1/2] Added an option to ignore macro definitions. --- clang/i

[PATCH] D157879: [clang] Report missing designated initializers in C++

2023-10-27 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon added a comment. In D157879#4655321 , @rsmith wrote: > This change has introduced a false positive for anonymous union members: > > struct A { > int m; > union { int n = 0; }; > }; > > A a = A{.m = 0}; > > now produces a fal

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread via cfe-commits
https://github.com/tomekpaszek ready_for_review https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread via cfe-commits
https://github.com/tomekpaszek edited https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread via cfe-commits
https://github.com/tomekpaszek edited https://github.com/llvm/llvm-project/pull/70338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread via cfe-commits
https://github.com/tomekpaszek updated https://github.com/llvm/llvm-project/pull/70338 >From 8404d703d58658593e6112b478533edb124cd0e1 Mon Sep 17 00:00:00 2001 From: Tomek Paszek Date: Thu, 26 Oct 2023 16:19:36 +0200 Subject: [PATCH 1/2] Added an option to ignore macro definitions. --- clang/i

[clang-tools-extra] [clangd] Support `-specs` arguments when querying the driver. (PR #70285)

2023-10-27 Thread Chris Carlon via cfe-commits
https://github.com/cjc25 converted_to_draft https://github.com/llvm/llvm-project/pull/70285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Option to ignore PP directives (PR #70338)

2023-10-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ba11d314a67638454989d4e0aebae64145d1a8ac 228301b783fe365bb01cc8b7ba122ed9845c9a37 --

[clang] [Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC) (PR #70427)

2023-10-27 Thread Kohei Asano via cfe-commits
https://github.com/khei4 ready_for_review https://github.com/llvm/llvm-project/pull/70427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix --entry command line option (PR #69114)

2023-10-27 Thread Tuur Martens via cfe-commits
https://github.com/JohnyTheCarrot updated https://github.com/llvm/llvm-project/pull/69114 >From 111d19a7e03e2c59afc8d40c8210a901378594ee Mon Sep 17 00:00:00 2001 From: Tuur Martens Date: Sun, 15 Oct 2023 18:08:35 +0200 Subject: [PATCH 1/3] [clang] Fix --entry command line option --- clang/inc

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-10-27 Thread Tobias Hieta via cfe-commits
tru wrote: @gedare can you fix the merge conflict on this one? https://github.com/llvm/llvm-project/pull/69340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

2023-10-27 Thread Nicolai Hähnle via cfe-commits
@@ -396,3 +396,115 @@ true: false: ret i32 33 } + +declare i32 @llvm.amdgcn.icmp.i32(i1, i1, i32) + +define amdgpu_cs i32 @branch_divergent_simulated_negated_ballot_ne_zero_and(i32 %v1, i32 %v2) { +; CHECK-LABEL: branch_divergent_simulated_negated_ballot_ne_zero_and: +; CHEC

[clang-tools-extra] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

2023-10-27 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle commented: Seems pretty reasonable to me https://github.com/llvm/llvm-project/pull/68714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

2023-10-27 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle edited https://github.com/llvm/llvm-project/pull/68714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve selection of conditional branch on amdgcn.ballot!=0 condition in SelectionDAG. (PR #68714)

2023-10-27 Thread Nicolai Hähnle via cfe-commits
@@ -396,3 +396,115 @@ true: false: ret i32 33 } + +declare i32 @llvm.amdgcn.icmp.i32(i1, i1, i32) + +define amdgpu_cs i32 @branch_divergent_simulated_negated_ballot_ne_zero_and(i32 %v1, i32 %v2) { +; CHECK-LABEL: branch_divergent_simulated_negated_ballot_ne_zero_and: +; CHEC

[clang] [clang]set invalid for lambda which missing capture `this` (PR #70432)

2023-10-27 Thread via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c++17 %s + +struct S { + int n; + int d = (4, []() { return n; }()); // expected-error {{'this' cannot be implicitly captured in this context}} \ + // expected-note {{explicitly

[clang-tools-extra] [clang]set invalid for lambda which missing capture `this` (PR #70432)

2023-10-27 Thread via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c++17 %s + +struct S { + int n; + int d = (4, []() { return n; }()); // expected-error {{'this' cannot be implicitly captured in this context}} \ + // expected-note {{explicitly

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread James E T Smith via cfe-commits
jamesETsmith wrote: @philnik777, I think you're right that `Proxy` is missing a few member functions (and type aliases). Here's a minimal example of my additions to it: https://godbolt.org/z/8T9eqjjEj. If that seems reasonable, I'll update `test_iterators.h`. https://github.com/llvm/llvm-proj

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread James E T Smith via cfe-commits
jamesETsmith wrote: @philnik777, I think you're right that `Proxy` is missing a few member functions (and type aliases). Here's a minimal example of my additions to it: https://godbolt.org/z/8T9eqjjEj. If that seems reasonable, I'll update `test_iterators.h`. https://github.com/llvm/llvm-proj

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread via cfe-commits
philnik777 wrote: You should make the operators conditionally available based on whether the underlying type has them. The rest looks good. https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-27 Thread via cfe-commits
philnik777 wrote: You should make the operators conditionally available based on whether the underlying type has them. The rest looks good. https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-27 Thread Sander de Smalen via cfe-commits
@@ -263,3 +263,38 @@ multiclass ZAFPOuterProd { defm SVMOPA : ZAFPOuterProd<"mopa">; defm SVMOPS : ZAFPOuterProd<"mops">; + + +// SME2 - ADD, SUB + +multiclass ZAAddSub { sdesmalen

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-27 Thread Sander de Smalen via cfe-commits
@@ -10266,35 +10288,13 @@ Value *CodeGenFunction::EmitAArch64SVEBuiltinExpr(unsigned BuiltinID, Value *CodeGenFunction::EmitAArch64SMEBuiltinExpr(unsigned BuiltinID, const CallExpr *E) { - // Find out if any arguments are req

[clang] [Clang][SME2] Add multi-vector add/sub builtins (PR #69725)

2023-10-27 Thread Sander de Smalen via cfe-commits
@@ -9571,22 +9571,17 @@ Value *CodeGenFunction::EmitSVEStructStore(const SVETypeFlags &TypeFlags, Value *BasePtr = Ops[1]; // Does the store have an offset? - if (Ops.size() > 3) + if (Ops.size() > (2 + N)) sdesmalen-arm wrote: `EmitSVEStructStore` doe

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

2023-10-27 Thread via cfe-commits
MaggieYingYi wrote: Gentle ping ... https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 396b562 - [clang] use relative paths for builtin headers during module compilation (#68023)

2023-10-27 Thread via cfe-commits
Author: Richard Howell Date: 2023-10-27T07:10:46-07:00 New Revision: 396b5621f94ca6fc4d86d4fb0e33e9e51a86affd URL: https://github.com/llvm/llvm-project/commit/396b5621f94ca6fc4d86d4fb0e33e9e51a86affd DIFF: https://github.com/llvm/llvm-project/commit/396b5621f94ca6fc4d86d4fb0e33e9e51a86affd.diff

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-27 Thread Richard Howell via cfe-commits
https://github.com/rmaz closed https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-27 Thread Louis Dionne via cfe-commits
@@ -37,9 +37,10 @@ struct __fn { _LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __low))), "Bad bounds passed to std::ranges::clamp"); -if (std::invoke(__comp, std::invoke(__proj,

[clang-tools-extra] [libc++] Fix complexity guarantee in ranges::clamp (PR #68413)

2023-10-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68413 >From 24d5794c366670fb4d8fe3ec72c27d7c9ef335b9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 6 Oct 2023 08:57:23 -0400 Subject: [PATCH 1/3] [libc++] Fix complexity guarantee in std::clamp This patch pre

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-27 Thread Piotr Zegar via cfe-commits
@@ -156,6 +153,49 @@ void PreferMemberInitializerCheck::check( const CXXRecordDecl *Class = Ctor->getParent(); bool FirstToCtorInits = true; + std::map AssignedFields{}; + + // Checks if Field is initialised using a field that will be initialised after + // it. + // T

[clang-tools-extra] [clang-tidy][test] Add more bugprone-string-constructor tests (PR #70456)

2023-10-27 Thread via cfe-commits
https://github.com/maflcko created https://github.com/llvm/llvm-project/pull/70456 Test: * string literal concatenation is accepted * escaped embedded null char is accepted * taking over the implicit null char is rejected From fa93a9851f03c5ae67299f5b37f7594ca67396e1 Mon Sep 17 00:00:00 2001 F

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-27 Thread Piotr Zegar via cfe-commits
@@ -156,6 +153,49 @@ void PreferMemberInitializerCheck::check( const CXXRecordDecl *Class = Ctor->getParent(); bool FirstToCtorInits = true; + std::map AssignedFields{}; PiotrZSL wrote: Consider something like llvm::SmallDenceMap or llvm::SmallMapVector

[clang-tools-extra] [clang-tidy][test] Add more bugprone-string-constructor tests (PR #70456)

2023-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: ツ (maflcko) Changes Test: * string literal concatenation is accepted * escaped embedded null char is accepted * taking over the implicit null char is rejected --- Full diff: https://github.com/llvm/llvm-project/pull/70456.diff 1 Fi

<    1   2   3   4   >