[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/69102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][LTO] Change the filename format for LTO'd stats file (PR #70242)

2023-10-25 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave created https://github.com/llvm/llvm-project/pull/70242 Use ".ld.stats" instead of ".stats" for stats file generated by LTO backend. The new extension makes it easier to search for LTO'd stats file and be consistent with LTO'd optimization remarks files' naming c

[clang] [Clang][Driver][LTO] Change the filename format for LTO'd stats file (PR #70242)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Min-Yih Hsu (mshockwave) Changes Use ".ld.stats" instead of ".stats" for stats file generated by LTO backend. The new extension makes it easier to search for LTO'd stats file and be consistent with LT

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-25 Thread Richard Howell via cfe-commits
rmaz wrote: Thanks for the detailed reviews all, will get this rebased and landed. https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-25 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From 87bbfac1ea77b9ff528f05f9eab0e380a5d85cbb Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] add module builtin headers relative to resource dir When inc

[PATCH] D159546: [OpenMP 5.2] Initial parsing and semantic analysis support for 'step' modifier on 'linear' clause

2023-10-25 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1352 +def err_omp_multiple_step_or_linear_modifier : Error< + "multiple %select{'step size'|'linear modifier'}0 found in linear clause">; def warn_pragma_expected_colon_r_paren : Warnin

[clang] 0ab6947 - [clang] Fix trailing whitespace in DiagnosticParseKinds.td

2023-10-25 Thread via cfe-commits
Author: Jessica Clarke Date: 2023-10-25T20:03:57+01:00 New Revision: 0ab694754e3722f7edbd8b3ad23ac0b312515d3b URL: https://github.com/llvm/llvm-project/commit/0ab694754e3722f7edbd8b3ad23ac0b312515d3b DIFF: https://github.com/llvm/llvm-project/commit/0ab694754e3722f7edbd8b3ad23ac0b312515d3b.diff

[clang] Complex range (PR #70244)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/70244 None >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/8] Revert "[clang] Support fixed point types in C++ (#677

[PATCH] D159546: [OpenMP 5.2] Initial parsing and semantic analysis support for 'step' modifier on 'linear' clause

2023-10-25 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1352 +def err_omp_multiple_step_or_linear_modifier : Error< + "multiple %select{'step size'|'linear modifier'}0 found in linear clause">; def warn_pragma_expected_colon_r_paren : Warnin

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/70152 >From afec5a9efe1dc1e933ccd26c5428d26c52e078b7 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Tue, 24 Oct 2023 18:36:53 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate old syntax of linear clause The syntax of

[clang] [libc] Attempt to enable missing string functions for offloading (PR #67869)

2023-10-25 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Invalidated by a merged PR. https://github.com/llvm/llvm-project/pull/67869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Attempt to enable missing string functions for offloading (PR #67869)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Complex range (PR #70244)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0ab694754e3722f7edbd8b3ad23ac0b312515d3b 2aa766352db0c3010991b4bc53ded7a2d1693bfd --

[clang-tools-extra] Complex range (PR #70244)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/9] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang] Complex range (PR #70244)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/9] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,134 @@ +//===- SocketMsgSupport.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Robustify openmp test (PR #69739)

2023-10-25 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert commented: Your motivation is sound, apologies for the churn this caused. Thaat said, this alias is not `noalias` but global symbols aliases. The commit that introduced the NOT check removed: ``` // CHECK-DAG: @_ZN16SpecSpecialFuncs6MethodEv = {{.*}}alias i32 (%stru

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
@@ -24,15 +24,38 @@ using namespace llvm; -/// Get the __llvm_prf_cnts section. -Expected getCountersSection(const object::ObjectFile &Obj) { +namespace llvm { +// Deprecated. Use -profile-correlate=debug-info. +cl::opt DebugInfoCorrelate( +"debug-info-correlate", +c

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-25 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/69656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add sched model for XiangShan-NanHu (PR #70232)

2023-10-25 Thread Philip Reames via cfe-commits
preames wrote: Can you separate out the basic processor definition (using NoSchedModel), and a patch which adds the scheduling model? We can at least get the processor definition landed while we iterate on the scheduling related pieces. https://github.com/llvm/llvm-project/pull/70232 __

[clang-tools-extra] [clang-tidy] Support functional cast in bugprone-dangling-handle (PR #69067)

2023-10-25 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/69067 >From 6d4c7297e19193781d97fe19c3ccf8e65226ad0b Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Sat, 14 Oct 2023 14:51:16 + Subject: [PATCH 1/3] [clang-tidy] Support functional cast in bugprone-dangling-han

[clang-tools-extra] [clang-tidy] Improve bugprone-unused-return-value check (PR #66573)

2023-10-25 Thread Piotr Zegar via cfe-commits
@@ -130,26 +130,35 @@ UnusedReturnValueCheck::UnusedReturnValueCheck(llvm::StringRef Name, "::std::error_condition;" "::std::errc;" "::std::expec

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
@@ -2807,6 +2807,9 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, bool StrictFPModel = false; StringRef Float16ExcessPrecision = ""; StringRef BFloat16ExcessPrecision = ""; + StringRef CxLimitedRange = "NoCxLimiteRange";

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel edited https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel commented: I'm sure Aaron would appreciate me also saying that these changes would require addition to the clang release notes. 😄 https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commi

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
@@ -846,6 +859,31 @@ void Parser::HandlePragmaFEnvRound() { Actions.ActOnPragmaFEnvRound(PragmaLoc, RM); } +void Parser::HandlePragmaCXLimitedRange() { + assert(Tok.is(tok::annot_pragma_cx_limited_range)); + tok::OnOffSwitch OOS = static_cast( + reinterpret_cast(Tok.g

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
@@ -846,6 +865,105 @@ ComplexPairTy ComplexExprEmitter::EmitBinMul(const BinOpInfo &Op) { return ComplexPairTy(ResR, ResI); } +ComplexPairTy ComplexExprEmitter::EmitAlgebraicDiv(llvm::Value *LHSr, + llvm::Value *LHSi, +

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
@@ -28,4 +28,6 @@ OPTION(FPEvalMethod, LangOptions::FPEvalMethodKind, 2, AllowApproxFunc) OPTION(Float16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) OPTION(BFloat16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, Float16ExcessPrecision) OPTION(Mat

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
@@ -846,6 +865,105 @@ ComplexPairTy ComplexExprEmitter::EmitBinMul(const BinOpInfo &Op) { return ComplexPairTy(ResR, ResI); } +ComplexPairTy ComplexExprEmitter::EmitAlgebraicDiv(llvm::Value *LHSr, + llvm::Value *LHSi, +

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Joshua Cranmer via cfe-commits
@@ -846,6 +865,105 @@ ComplexPairTy ComplexExprEmitter::EmitBinMul(const BinOpInfo &Op) { return ComplexPairTy(ResR, ResI); } +ComplexPairTy ComplexExprEmitter::EmitAlgebraicDiv(llvm::Value *LHSr, + llvm::Value *LHSi, +

[clang] Complex range (PR #70244)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/70244 >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 01/10] Revert "[clang] Support fixed point types in C++ (#67750)"

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Johannes Doerfert (jdoerfert) Changes We now provide the information about the min/max thread and team count from to the OMPIRBuilder, no matter what the source was. That means we unify `thread_limit`, `num_teams`, `num_threads` h

[clang] [clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-25 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > I'm sure Aaron would appreciate me also saying that these changes would > require addition to the clang release notes. 😄 Yes :-) Will do that. I just wanted you to have a first run through it. I am getting a funny fail with the formatting as you can see. I think somehow my PR

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I don't think a global variable is the right interface for this; we've been trying to move away from global variables because they cause breakage when LLVM is used in multiple contexts in the same process. Functions that construct pass pipelines that are usable as librarie

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 5def87462e3b48cfebafdc2526ac929f5cb9cea3 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 1/6] [clang][MBD] set up module build daemon infrastructure The modu

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
wsmoses wrote: > acks presently can be done one of two ways: > > * a shared library plugin > * modifying the extensions list (and thus extensions.def) > > This prevents the use of such functionality for static builds on build > systems that cannot be modified, as well as prevents such function

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if (Fi

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if (Fi

[clang] ANDROID: AArch64: Change default max-page-size from 4k to 16k (PR #70251)

2023-10-25 Thread Kalesh Singh via cfe-commits
https://github.com/Kalesh-Singh created https://github.com/llvm/llvm-project/pull/70251 File size increase were found negligible from sparseness and zero block compression in f2fs and ext4 (supported filesystems for Android's userdata partition). >From 9a28c8670619cef36c24cfae426631098920fecc

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/69079 From df2dba040dadb5e3222b44b41ea92978d9ddafed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sat, 14 Oct 2023 00:55:18 +0300 Subject: [PATCH 1/2] [clang] [Gnu] Improve GCCVersion parsing

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

2023-10-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Herald added a project: All. Comment at: clang/test/Driver/mcmodel.c:15 // LARGE: "-mcmodel=large" +// AIX-MCMEDIUM-OVERRIDE: "-mcmodel=large" Is it intentional that -mcmodel=medium is changed to large for 32-bit systems? Is thi

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: @@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion =

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: @@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion =

[clang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-10-25 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/5] [OpenACC] Initial commit for OpenACC Support This is the ini

[clang] 8958f0d - [Driver][test] Improve mcmodel.c

2023-10-25 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-10-25T13:48:06-07:00 New Revision: 8958f0dca0b57262d187eb4c9721e9df276251ea URL: https://github.com/llvm/llvm-project/commit/8958f0dca0b57262d187eb4c9721e9df276251ea DIFF: https://github.com/llvm/llvm-project/commit/8958f0dca0b57262d187eb4c9721e9df276251ea.diff

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if (Fi

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/69079 From df2dba040dadb5e3222b44b41ea92978d9ddafed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sat, 14 Oct 2023 00:55:18 +0300 Subject: [PATCH 1/3] [clang] [Gnu] Improve GCCVersion parsing

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/69079 From df2dba040dadb5e3222b44b41ea92978d9ddafed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sat, 14 Oct 2023 00:55:18 +0300 Subject: [PATCH 1/4] [clang] [Gnu] Improve GCCVersion parsing

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

2023-10-25 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Sidwell (urnathan) Changes An assert is better here. --- Full diff: https://github.com/llvm/llvm-project/pull/70149.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGExprScalar.cpp (+4-5) ``diff diff --git a/clan

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
Martin =?utf-8?q?Storsjö?= , Martin =?utf-8?q?Storsjö?= , Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: @@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Secon

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Jon Roelofs via cfe-commits
Martin =?utf-8?q?Storsj=C3=B6?= , Martin =?utf-8?q?Storsj=C3=B6?= , Martin =?utf-8?q?Storsj=C3=B6?= Message-ID: In-Reply-To: https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69079 ___ cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > > Implementing a timeout as part of this patch as a safety measure seems > > worth while too but I'm not sure I understand your final solution. You all > > spawned a clang job that had to communicate with the daemon to make sure > > one did not exist? > > It is something li

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > I had a couple of questions. I guess my main concern here is that the TODO > for portability might turn out to be quite heavy lifting. Perhaps we should > be looking to abstract the socket-like interface at a lower level. We have someone working on a simple socket library fo

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-10-25 Thread Michael Spencer via cfe-commits
@@ -15,21 +12,12 @@ int main() {return 0;} // RUN: %clang -fmodule-build-daemon=mbd-handshake -Rmodule-build-daemon %t/main.c &> %t/output-existing // RUN: cat %t/output-existing | FileCheck %s --check-prefix=CHECK-EXIST -// CHECK: remark: Trying to spawn module build daemon

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: You need to make sure you tests have newlines at the end https://github.com/llvm/llvm-project/pull/69061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,103 @@ +// RUN: %clang_cc1 -Wchar-subscripts -fsyntax-only -verify %s + +void t1(void) { + int array[1] = { 0 }; + char subscript = 0; + int val = array[subscript]; // expected-warning{{array subscript is of type 'char'}} +} + +void t2(void) { + int array[1] = { 0

[clang] [clang][deps] Fix `__has_include` behavior with umbrella headers (PR #70144)

2023-10-25 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/70144 >From 4199b80e5cb0a8873f63c356e4c4304833d6fffa Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 24 Oct 2023 16:30:22 -0700 Subject: [PATCH 1/2] [clang][deps] Fix `__has_include` behavior with umbrella

[clang] [clang][deps] Fix `__has_include` behavior with umbrella headers (PR #70144)

2023-10-25 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Can you clarify how this bug occurs in terms of what information about the > header is stored that causes us to get the wrong module? I updated the test case to be more in line with how the bug manifested in the wild. Let me annotate the test case here to hopefully clarif

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-25 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm created https://github.com/llvm/llvm-project/pull/70255 This option already exists on GCC and so it is being added to LLVM so that we use the same option as them. >From a561647c59119eb8da82e0468d9158e674102904 Mon Sep 17 00:00:00 2001 From: Stefan Pintilie Date:

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
=?utf-8?b?5YiY6Zuo5Z+5?= Message-ID: In-Reply-To: https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
=?utf-8?b?5YiY6Zuo5Z+5?= Message-ID: In-Reply-To: https://github.com/shafik commented: A couple of nitpicks https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
=?utf-8?b?5YiY6Zuo5Z+5?= Message-ID: In-Reply-To: @@ -354,10 +354,10 @@ UnresolvedLookupExpr::UnresolvedLookupExpr( NestedNameSpecifierLoc QualifierLoc, SourceLocation TemplateKWLoc, const DeclarationNameInfo &NameInfo, bool RequiresADL, bool Overloaded, const Te

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-25 Thread Shafik Yaghmour via cfe-commits
=?utf-8?b?5YiY6Zuo5Z+5?= Message-ID: In-Reply-To: @@ -1299,8 +1299,9 @@ static bool checkTupleLikeDecomposition(Sema &S, // in the associated namespaces. Expr *Get = UnresolvedLookupExpr::Create( S.Context, nullptr, NestedNameSpecifierLoc(), SourceLoc

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Stefan Pintilie (stefanp-ibm) Changes This option already exists on GCC and so it is being added to LLVM so that we use the same option as them. --- Full diff: https://github.com/llvm/llvm-project/pull/70255.diff 8 Files Affected: - (m

[clang] [clang][deps] Fix `__has_include` behavior with umbrella headers (PR #70144)

2023-10-25 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. > Yeah. I did try to fix up all calls to LookupFile to perform module map > lookup, but a bunch of tests started failing (mostly standard C++ modules > tests IIRC), so there's probably more nuance required there. Okay, I do think this

[clang] [PowerPC] Add an alias for -mregnames so that full register names used in assembly. (PR #70255)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 740582fa4c9512b34128dc97b2eff56820984421 a561647c59119eb8da82e0468d9158e674102904 --

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-25 Thread Joseph Huber via cfe-commits
@@ -9,6 +9,7 @@ #include "ABIInfoImpl.h" #include "TargetInfo.h" #include "llvm/IR/IntrinsicsNVPTX.h" +#include jhuber6 wrote: Is this necessary? https://github.com/llvm/llvm-project/pull/70247 ___ cfe-commits mail

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-25 Thread Joseph Huber via cfe-commits
@@ -4227,8 +4227,106 @@ static const omp::GV &getGridValue(Function *Kernel) { llvm_unreachable("No grid value available for this architecture!"); } +static MDNode *getNVPTXMDNode(Function &Kernel, StringRef Name) { + Module &M = *Kernel.getParent(); + NamedMDNode *MD = M.

[libunwind] Implement libcxx ranges contains (PR #70258)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK created https://github.com/llvm/llvm-project/pull/70258 I close https://github.com/llvm/llvm-project/pull/65148 accidentally and no restore button here. I reopen one. >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date:

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Seems fine overall https://github.com/llvm/llvm-project/pull/70247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-25 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/70247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/6] [libc++] Implement ranges::contains_subrange --- libcxx/i

[clang-tools-extra] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/6] [libc++] Implement ranges::contains_subrange --- libcxx/i

[libunwind] Implement libcxx ranges contains (PR #70258)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/70258 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/16] [libc++] Implement ranges::contains Differential Revision

[clang] Implement libcxx ranges contains (PR #70258)

2023-10-25 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/70258 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/16] [libc++] Implement ranges::contains Differential Revision

[clang] a1b4238 - [clang][deps] Fix `__has_include` behavior with umbrella headers (#70144)

2023-10-25 Thread via cfe-commits
Author: Jan Svoboda Date: 2023-10-25T14:58:09-07:00 New Revision: a1b4238eaf76d3fc51e417a5d70fc8abf202d1c2 URL: https://github.com/llvm/llvm-project/commit/a1b4238eaf76d3fc51e417a5d70fc8abf202d1c2 DIFF: https://github.com/llvm/llvm-project/commit/a1b4238eaf76d3fc51e417a5d70fc8abf202d1c2.diff L

[clang] [clang][deps] Fix `__has_include` behavior with umbrella headers (PR #70144)

2023-10-25 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/70144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ANDROID: AArch64: Change default max-page-size from 4k to 16k (PR #70251)

2023-10-25 Thread Dan Albert via cfe-commits
DanAlbert wrote: I thought we'd decided to not do this yet. https://github.com/llvm/llvm-project/pull/70251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-25 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/70262 -mcmodel= is supported for a few architectures. Reject the option for other architectures. * -mcmodel= is unsupported on x86-32. * -mcmodel=large is unsupported for PIC on AArch64. * -mcmodel= is unsupported for

[libunwind] Implement libcxx ranges contains (PR #70258)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4c60c0cb4e3e7ac45f588499da8d674619d3845a 3e16ddebac3ddc424b88fd5c8fdc296dac3fab85 --

[clang] Implement libcxx ranges contains (PR #70258)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4c60c0cb4e3e7ac45f588499da8d674619d3845a 3e16ddebac3ddc424b88fd5c8fdc296dac3fab85 --

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes -mcmodel= is supported for a few architectures. Reject the option for other architectures. * -mcmodel= is unsupported on x86-32. * -mcmodel=large is unsupported for PIC on AArch64. * -mcmodel= is unsupported

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel updated https://github.com/llvm/llvm-project/pull/69648 >From 843d9b200f3708676119ed0b2b3b0657cd3fd47b Mon Sep 17 00:00:00 2001 From: Nishant Patel Date: Mon, 18 Sep 2023 18:26:22 + Subject: [PATCH 1/4] Add SYCL runtimet wrappers --- .../ExecutionEngine/SyclRunt

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel updated https://github.com/llvm/llvm-project/pull/69648 >From 843d9b200f3708676119ed0b2b3b0657cd3fd47b Mon Sep 17 00:00:00 2001 From: Nishant Patel Date: Mon, 18 Sep 2023 18:26:22 + Subject: [PATCH 1/4] Add SYCL runtimet wrappers --- .../ExecutionEngine/SyclRunt

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Nishant Patel (nbpatel) Changes This PR is a breakdown of the big PR #65539 which enables intel gpu integration. In this PR we add the code for the sycl runtime wrappers and also the cmake modules to find the dependent components. Integra

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-10-25 Thread via cfe-commits
https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/69061 >From af3b7f9a94d7862acf5bd56dfb0ef652a684244d Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Sat, 14 Oct 2023 12:02:19 -0400 Subject: [PATCH] Remove warnings from -Wchar-subscripts for known positive cons

[clang] Remove warnings from -Wchar-subscripts for known positive constants (PR #69061)

2023-10-25 Thread via cfe-commits
@@ -0,0 +1,103 @@ +// RUN: %clang_cc1 -Wchar-subscripts -fsyntax-only -verify %s + +void t1(void) { + int array[1] = { 0 }; + char subscript = 0; + int val = array[subscript]; // expected-warning{{array subscript is of type 'char'}} +} + +void t2(void) { + int array[1] = { 0

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Ivan Butygin via cfe-commits
@@ -0,0 +1,222 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Ivan Butygin via cfe-commits
@@ -0,0 +1,222 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel updated https://github.com/llvm/llvm-project/pull/69648 >From 843d9b200f3708676119ed0b2b3b0657cd3fd47b Mon Sep 17 00:00:00 2001 From: Nishant Patel Date: Mon, 18 Sep 2023 18:26:22 + Subject: [PATCH 1/5] Add SYCL runtimet wrappers --- .../ExecutionEngine/SyclRunt

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel updated https://github.com/llvm/llvm-project/pull/69648 >From 843d9b200f3708676119ed0b2b3b0657cd3fd47b Mon Sep 17 00:00:00 2001 From: Nishant Patel Date: Mon, 18 Sep 2023 18:26:22 + Subject: [PATCH 1/5] Add SYCL runtimet wrappers --- .../ExecutionEngine/SyclRunt

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Ivan Butygin via cfe-commits
@@ -0,0 +1,222 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-25 Thread Ivan Butygin via cfe-commits
@@ -0,0 +1,222 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

2023-10-25 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/69975 >From 0270c76e779457486ee89f100db2b7151832c290 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 10 Oct 2023 14:16:13 -0700 Subject: [PATCH 1/4] [clang][modules] Make `DIAGNOSTIC_OPTIONS` skippable ---

[clang] [clang][deps] Skip slow `UNHASHED_CONTROL_BLOCK` records (PR #69975)

2023-10-25 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Besides deps scanning, have you tried to enable these option to compile with > clang modules? I mean, if it is safe to enable such options at compilation > times, it looks a valid optimization for C++20 modules too. I did not. I suspect it won't show in profiles of compil

[clang] 9237ce4 - [OpenMP 5.2] Deprecate old syntax of linear clause (#70152)

2023-10-25 Thread via cfe-commits
Author: Fazlay Rabbi Date: 2023-10-25T15:36:36-07:00 New Revision: 9237ce46138c311849e7de19a9a3ea930f1dbd6d URL: https://github.com/llvm/llvm-project/commit/9237ce46138c311849e7de19a9a3ea930f1dbd6d DIFF: https://github.com/llvm/llvm-project/commit/9237ce46138c311849e7de19a9a3ea930f1dbd6d.diff

[clang] [OpenMP 5.2] Deprecate old syntax of linear clause (PR #70152)

2023-10-25 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay closed https://github.com/llvm/llvm-project/pull/70152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Fix target data if/logical expression assert fail (PR #70268)

2023-10-25 Thread David Pagan via cfe-commits
https://github.com/ddpagan created https://github.com/llvm/llvm-project/pull/70268 Fixed assertion failure Basic Block in function 'main' does not have terminator! label %land.end caused by premature setting of CodeGenIP upon entry to emitTargetDataCalls, where subsequent evaluation of lo

<    1   2   3   4   5   6   >